From patchwork Fri Nov 23 08:44:03 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ard Biesheuvel X-Patchwork-Id: 151846 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp1799616ljp; Fri, 23 Nov 2018 00:46:04 -0800 (PST) X-Google-Smtp-Source: AFSGD/VgDMGbsY5jwBewYxZk0LEtJhe9do26oU3gUsCui0YpAjwRgDXXsLZ2qWjPAUBCfb96fXOU X-Received: by 2002:a63:40c6:: with SMTP id n189mr12952591pga.355.1542962764771; Fri, 23 Nov 2018 00:46:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542962764; cv=none; d=google.com; s=arc-20160816; b=sjomb9PWPU5XVRAiSq2lufjOeoOscZdr4Uj8hIjJV1WbwKYTsCWr4xEWx9FkK+Z7or COwQRysvDDKpjo2pF+xtZpT0N+liJOG2ujMJGVqAU1PyIjKIRj5GrmMiqtGP8G+mTTXz 1Gn3R0+FAW2rZziTTno8okbpyPBHCe7QwBOyUrG3EbdveUemmJ9khwBgelReqTpmkMzC clD6leZj9Wju0EQf/tFh+I1uqGKQdUhdKFZkB9K9cIin0D0im9iWjH3TbEAiribpHbsS g5KeLDmIhwuXeZp0lN4ZCaS/tjLfPn7o9oAwhweeOT4PG9fUR9n6SUCDyy0lSWpGW4mJ m0Qg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:cc :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:message-id:date:to:from:dkim-signature :delivered-to; bh=tC33/MEfoQSLwI4MxzRpUwUeQ0OFHz8aM/rFum8DzP0=; b=iFmQGnVCOdCqcNRQzhkdPVxkxZ//eGSKVR7Iy66Oc3rPs50FZBfapWFz23g/EOTog/ XbyhQTxt67dzXOVBKf4oF3jGD85pjJikqw9bUI4VsniqgM3KtVwGizRJQpwZ3iwD3hTl XJqVVrdXyhnR291n/HLcdXCEAp27LYFu5KKrFaiuvgFOMunGF+Na7DTZvS3r45GJvHqf 0JoI7sOoRzSNx1eV6aGnFbugLMGc9+aTG2EwpCivAGcuIP5T2U9/B42LmMB4W0Ex9Ttg b3AAFZuOAo4DgZqtdTqHWd2P5LKXbf7xViKode93aoUu2CGCZIQSlVlBKdfDdfrth3Wb nzrw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=WlJebPjw; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from ml01.01.org (ml01.01.org. [198.145.21.10]) by mx.google.com with ESMTPS id n12si11425062pgb.563.2018.11.23.00.46.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 23 Nov 2018 00:46:04 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) client-ip=198.145.21.10; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=WlJebPjw; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 8931A21194894; Fri, 23 Nov 2018 00:46:03 -0800 (PST) X-Original-To: edk2-devel@lists.01.org Delivered-To: edk2-devel@lists.01.org Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::343; helo=mail-wm1-x343.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1E6CB21B02822 for ; Fri, 23 Nov 2018 00:44:11 -0800 (PST) Received: by mail-wm1-x343.google.com with SMTP id 125so11162599wmh.0 for ; Fri, 23 Nov 2018 00:44:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=bGkSn8AvJQOtiFoxVsAUhJDlnZg12rL8Zwk1iVY8xYo=; b=WlJebPjwSSoPnXh3MElG5YcbOHvuHYhki4mCFpwPjfJ/xikJngOuHA+YP0x4vk0KDZ 5Ej5UKa/qrEdnJJvAnE1obeUlKvVngEdF3yptYJs3eJciYA7c8c2IPUnI9vDSITK8hjP pshiNpqIRcCP+xWP9Fo8Cxclurip+qh5rp84s= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=bGkSn8AvJQOtiFoxVsAUhJDlnZg12rL8Zwk1iVY8xYo=; b=RhAX9IzA8oh4AKxZNj7sElO663Og9VwFYAW6hXRGLV1/0C3WMSo3T3kWby65bKOjid uG28z+Iw5FppLyWQNOqjzg5OL+BCiM4DM1oXwmo8LTMLFw5YqOBY3bb65MO0FAhPBrKr cUUB4RRP+h5OMUqEijf5mcAPXlOMk7xpao0kfKjSGiWLBQb611bQ7zsNKO4I9AHit5my dhi/XSLoVh+5mKU+i1PQo44QoNU5/g2PQOMpkG5bSDaW4wQfo+qnuIKs+5WQPiAV9CL7 k9Re5LUg88/dnWUR9b72Er59hzjP0M3v4sEtWq0ggRQ+TAdcNc2U2xRPX0FXKjS6VAbA 0ufA== X-Gm-Message-State: AA+aEWahUQkbEmOHM8U4kblSFH8BeJhKeTDOcTVo/Vmt6Oa3YjPOzW5o XREcwq0hyXE82BfLmDototunv/JR0oLXIQ== X-Received: by 2002:a1c:3b82:: with SMTP id i124-v6mr11776562wma.34.1542962648481; Fri, 23 Nov 2018 00:44:08 -0800 (PST) Received: from mba13.wifi.ns.nl (33.153.69.91.rev.sfr.net. [91.69.153.33]) by smtp.gmail.com with ESMTPSA id c8sm807377wrx.42.2018.11.23.00.44.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 23 Nov 2018 00:44:07 -0800 (PST) From: Ard Biesheuvel To: edk2-devel@lists.01.org Date: Fri, 23 Nov 2018 09:44:03 +0100 Message-Id: <20181123084406.27192-1-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.17.1 Subject: [edk2] [PATCH v2 edk2-platforms 0/3] Platform/ARM: fix DevicePath mishandling in BdsLib X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lersek@redhat.com, nariman.poushin@linaro.org MIME-Version: 1.0 Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" The deprecated BdsLib library class in ArmPkg is still depended upon, but only a single implementation exists, which now resides in edk2-platforms. This implementation has some issues in how it deals with Device Paths, so let's fix those, but first move over the library interface declaration and get rid of the parts that are no longer used. This will permit dropping it from ArmPkg in EDK2. Changes since v1: - add Laszlo's ack to #1 - update #2 to remove everything we no longer need from BdsLib - drop #3 which was bogus - update #4 to ensure that we only duplicate the device path when we are about to return EFI_SUCCESS Ard Biesheuvel (3): Platform/ARM: import ARM platform specific BdsLib header Platform/ARM/BdsLib: drop unused functions Platform/ARM/BdsLib: maintain alignment for DevicePaths Platform/ARM/ARM.dec | 3 + .../Drivers/FdtPlatformDxe/FdtPlatformDxe.inf | 2 +- Platform/ARM/Include/Library/BdsLib.h | 26 ++ Platform/ARM/Library/BdsLib/BdsAppLoader.c | 253 ---------------- Platform/ARM/Library/BdsLib/BdsFilePath.c | 95 +----- Platform/ARM/Library/BdsLib/BdsHelper.c | 122 -------- Platform/ARM/Library/BdsLib/BdsInternal.h | 16 +- Platform/ARM/Library/BdsLib/BdsLib.inf | 4 +- Platform/ARM/Library/BdsLib/BdsLoadOption.c | 272 ------------------ 9 files changed, 52 insertions(+), 741 deletions(-) create mode 100644 Platform/ARM/Include/Library/BdsLib.h delete mode 100644 Platform/ARM/Library/BdsLib/BdsAppLoader.c delete mode 100644 Platform/ARM/Library/BdsLib/BdsLoadOption.c -- 2.17.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel Tested-by: Thomas Abraham Reviewed-by: Leif Lindholm