From patchwork Fri Feb 26 16:16:54 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leif Lindholm X-Patchwork-Id: 63082 Delivered-To: patch@linaro.org Received: by 10.112.199.169 with SMTP id jl9csp802362lbc; Fri, 26 Feb 2016 08:17:09 -0800 (PST) X-Received: by 10.98.93.2 with SMTP id r2mr3234246pfb.64.1456503427008; Fri, 26 Feb 2016 08:17:07 -0800 (PST) Return-Path: Received: from ml01.01.org (ml01.01.org. [2001:19d0:306:5::1]) by mx.google.com with ESMTPS id vt4si3863696pab.8.2016.02.26.08.17.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 26 Feb 2016 08:17:06 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) client-ip=2001:19d0:306:5::1; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dkim=neutral (body hash did not verify) header.i=@linaro.org Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id EA57C1A1E31; Fri, 26 Feb 2016 08:17:09 -0800 (PST) X-Original-To: edk2-devel@lists.01.org Delivered-To: edk2-devel@lists.01.org Received: from mail-wm0-x22c.google.com (mail-wm0-x22c.google.com [IPv6:2a00:1450:400c:c09::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 94FA91A1E2B for ; Fri, 26 Feb 2016 08:17:08 -0800 (PST) Received: by mail-wm0-x22c.google.com with SMTP id g62so79736662wme.1 for ; Fri, 26 Feb 2016 08:17:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=vOGn0sLieBhKmj4MUgPvofT/+M5TgCLTcC85270VBu8=; b=Rohubi/alg4TYIeko2XKEbNBKJYS5kAcnV690hacMZwHL2uKIXdEc841iHFmZo5KlM /kgmoryXIC7tNBabYdxtCSI9c2IB0rcEU/fSTMYdMHUVBkUY5DdhU9LiAg0A0HKTLncC fVoCLTBJy4cB/XzqaMoi1k6ArMYvThSvmcNbA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=vOGn0sLieBhKmj4MUgPvofT/+M5TgCLTcC85270VBu8=; b=F4JGzlJ3NO8euoygQmH4Of6/R5FVRSCjgp6rjXEIrqI+c8EkkAvb9uhSWemJUfVypE crSvVC5GkAAy/9rApHaLwNJbA39N+05XyJyZ/jj1QDdTaFhcvMHSEE9n8Txsfut3sLrX 3u50YZf29o//ylrPdoLtWS0n/cTZkGfAEXz4a9k2n02HeSPKbaICyuW67v3AGtXZA7Vm iquIdZEh4Mb+EgivLKqHUP7U3isaAHwtxHrENYa9LhebnNxrmkiLRE4vb7YQyYvY73tD syNOzPciW/8DxE2sD65gIqH5GIrLCRX1XonGRy5uvSyCDe48DZL1wHR/7Xcd1h6B31Qb 4DOw== X-Gm-Message-State: AD7BkJLYvjMn7yXI7FGsr0gKp39weP+zg03+xjE/dKRpSZyfHO3Ku6lxImd5I+rfEqmcFWtQ X-Received: by 10.28.147.72 with SMTP id v69mr3761919wmd.79.1456503422203; Fri, 26 Feb 2016 08:17:02 -0800 (PST) Received: from mohikan.mushroom.smurfnet.nu (cpc92308-cmbg19-2-0-cust814.5-4.cable.virginm.net. [82.24.251.47]) by smtp.gmail.com with ESMTPSA id k8sm13067962wjr.38.2016.02.26.08.17.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 26 Feb 2016 08:17:01 -0800 (PST) From: Leif Lindholm To: edk2-devel@lists.01.org Date: Fri, 26 Feb 2016 16:16:54 +0000 Message-Id: <1456503415-17029-4-git-send-email-leif.lindholm@linaro.org> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1456503415-17029-1-git-send-email-leif.lindholm@linaro.org> References: <1456503415-17029-1-git-send-email-leif.lindholm@linaro.org> Cc: Haojian Zhuang , Ard Biesheuvel Subject: [edk2] [PATCH 3/4] ArmPlatformPkg: PL061 - drop pointless initialize function X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" PL061Initialize() did not actually do anything other than call PL061Identify() - so cut out the middle man. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Leif Lindholm --- ArmPlatformPkg/Drivers/PL061GpioDxe/PL061Gpio.c | 27 +------------------------ 1 file changed, 1 insertion(+), 26 deletions(-) -- 2.1.4 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel diff --git a/ArmPlatformPkg/Drivers/PL061GpioDxe/PL061Gpio.c b/ArmPlatformPkg/Drivers/PL061GpioDxe/PL061Gpio.c index c8125fd..45897ca 100644 --- a/ArmPlatformPkg/Drivers/PL061GpioDxe/PL061Gpio.c +++ b/ArmPlatformPkg/Drivers/PL061GpioDxe/PL061Gpio.c @@ -57,31 +57,6 @@ PL061Identify ( return EFI_SUCCESS; } -EFI_STATUS -PL061Initialize ( - VOID - ) -{ - EFI_STATUS Status; - - // Check if the PL061 GPIO module exists on board - Status = PL061Identify(); - if (EFI_ERROR (Status)) { - Status = EFI_DEVICE_ERROR; - goto EXIT; - } - - // Do other hardware initialisation things here as required - - // Disable Interrupts - //if (MmioRead8 (PL061_GPIO_IE_REG) != 0) { - // // Ensure interrupts are disabled - //} - - EXIT: - return Status; -} - /** Routine Description: @@ -298,7 +273,7 @@ PL061InstallProtocol ( // ASSERT_PROTOCOL_ALREADY_INSTALLED (NULL, &gEmbeddedGpioProtocolGuid); - Status = PL061Initialize(); + Status = PL061Identify(); if (EFI_ERROR(Status)) { return EFI_DEVICE_ERROR; }