From patchwork Thu Mar 24 10:37:20 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laszlo Ersek X-Patchwork-Id: 64328 Delivered-To: patch@linaro.org Received: by 10.112.199.169 with SMTP id jl9csp550130lbc; Thu, 24 Mar 2016 03:39:01 -0700 (PDT) X-Received: by 10.66.63.41 with SMTP id d9mr11551846pas.1.1458815934667; Thu, 24 Mar 2016 03:38:54 -0700 (PDT) Return-Path: Received: from ml01.01.org (ml01.01.org. [198.145.21.10]) by mx.google.com with ESMTPS id d27si11464464pfj.14.2016.03.24.03.38.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 24 Mar 2016 03:38:54 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) client-ip=198.145.21.10; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id E3A351A1F90; Thu, 24 Mar 2016 03:38:41 -0700 (PDT) X-Original-To: edk2-devel@ml01.01.org Delivered-To: edk2-devel@ml01.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 739A51A1EF1 for ; Thu, 24 Mar 2016 03:38:41 -0700 (PDT) Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id D78C68AE73; Thu, 24 Mar 2016 10:38:15 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-113-47.phx2.redhat.com [10.3.113.47]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u2OAbRfs032425; Thu, 24 Mar 2016 06:38:14 -0400 From: Laszlo Ersek To: edk2-devel-01 Date: Thu, 24 Mar 2016 11:37:20 +0100 Message-Id: <1458815844-24793-32-git-send-email-lersek@redhat.com> In-Reply-To: <1458815844-24793-1-git-send-email-lersek@redhat.com> References: <1458815844-24793-1-git-send-email-lersek@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 Subject: [edk2] [PATCH 31/35] SourceLevelDebugPkg: DebugCommunicationLibUsb: remove set but unused variables X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Hao Wu , Jeff Fan MIME-Version: 1.0 Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" Cc: Jeff Fan Cc: Hao Wu Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- SourceLevelDebugPkg/Library/DebugCommunicationLibUsb/DebugCommunicationLibUsb.c | 14 +------------- 1 file changed, 1 insertion(+), 13 deletions(-) -- 1.8.3.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel diff --git a/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb/DebugCommunicationLibUsb.c b/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb/DebugCommunicationLibUsb.c index b65c56dc13bd..a08a26035937 100644 --- a/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb/DebugCommunicationLibUsb.c +++ b/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb/DebugCommunicationLibUsb.c @@ -597,7 +597,6 @@ InitializeUsbDebugHardware ( RETURN_STATUS Status; USB_DEBUG_PORT_REGISTER *UsbDebugPortRegister; USB_DEBUG_PORT_DESCRIPTOR UsbDebugPortDescriptor; - UINT16 PciCmd; UINT32 *PortStatus; UINT32 *UsbCmd; UINT32 *UsbStatus; @@ -606,7 +605,6 @@ InitializeUsbDebugHardware ( UINT8 Length; UsbDebugPortRegister = (USB_DEBUG_PORT_REGISTER *)(UINTN)(Handle->UsbDebugPortMemoryBase + Handle->DebugPortOffset); - PciCmd = PciRead16 (PcdGet32(PcdUsbEhciPciAddress) + PCI_COMMAND_OFFSET); UsbHCSParam = (UINT32 *)(UINTN)(Handle->EhciMemoryBase + 0x04); UsbCmd = (UINT32 *)(UINTN)(Handle->EhciMemoryBase + 0x20); UsbStatus = (UINT32 *)(UINTN)(Handle->EhciMemoryBase + 0x24); @@ -774,7 +772,6 @@ DebugPortReadBuffer ( ) { USB_DEBUG_PORT_HANDLE *UsbDebugPortHandle; - USB_DEBUG_PORT_REGISTER *UsbDebugPortRegister; RETURN_STATUS Status; UINT8 Index; @@ -799,8 +796,6 @@ DebugPortReadBuffer ( } } - UsbDebugPortRegister = (USB_DEBUG_PORT_REGISTER *)(UINTN)(UsbDebugPortHandle->UsbDebugPortMemoryBase + UsbDebugPortHandle->DebugPortOffset); - // // Read data from buffer // @@ -1042,7 +1037,6 @@ DebugPortInitialize ( { RETURN_STATUS Status; USB_DEBUG_PORT_HANDLE Handle; - USB_DEBUG_PORT_HANDLE *UsbDebugPortHandle; // // Validate the PCD PcdDebugPortHandleBufferSize value @@ -1050,15 +1044,9 @@ DebugPortInitialize ( ASSERT (PcdGet16 (PcdDebugPortHandleBufferSize) == sizeof (USB_DEBUG_PORT_HANDLE)); if (Function == NULL && Context != NULL) { - UsbDebugPortHandle = (USB_DEBUG_PORT_HANDLE *)Context; - } else { - ZeroMem(&Handle, sizeof (USB_DEBUG_PORT_HANDLE)); - UsbDebugPortHandle = &Handle; - } - - if (Function == NULL && Context != NULL) { return (DEBUG_PORT_HANDLE *) Context; } + ZeroMem(&Handle, sizeof (USB_DEBUG_PORT_HANDLE)); Status = CalculateUsbDebugPortBar(&Handle.DebugPortOffset, &Handle.DebugPortBarNumber); if (RETURN_ERROR (Status)) {