From patchwork Thu Mar 24 10:36:52 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laszlo Ersek X-Patchwork-Id: 64300 Delivered-To: patch@linaro.org Received: by 10.112.199.169 with SMTP id jl9csp549581lbc; Thu, 24 Mar 2016 03:37:45 -0700 (PDT) X-Received: by 10.98.79.203 with SMTP id f72mr11643213pfj.102.1458815861188; Thu, 24 Mar 2016 03:37:41 -0700 (PDT) Return-Path: Received: from ml01.01.org (ml01.01.org. [198.145.21.10]) by mx.google.com with ESMTPS id n3si11410005pfb.123.2016.03.24.03.37.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 24 Mar 2016 03:37:41 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) client-ip=198.145.21.10; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id CC64A1A1EF8; Thu, 24 Mar 2016 03:38:05 -0700 (PDT) X-Original-To: edk2-devel@ml01.01.org Delivered-To: edk2-devel@ml01.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 4D67B1A1E1D for ; Thu, 24 Mar 2016 03:38:04 -0700 (PDT) Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id B3B4EC09FAB0; Thu, 24 Mar 2016 10:37:38 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-113-47.phx2.redhat.com [10.3.113.47]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u2OAbRfQ032425; Thu, 24 Mar 2016 06:37:37 -0400 From: Laszlo Ersek To: edk2-devel-01 Date: Thu, 24 Mar 2016 11:36:52 +0100 Message-Id: <1458815844-24793-4-git-send-email-lersek@redhat.com> In-Reply-To: <1458815844-24793-1-git-send-email-lersek@redhat.com> References: <1458815844-24793-1-git-send-email-lersek@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 Subject: [edk2] [PATCH 03/35] EdkCompatibilityPkg: UefiEfiIfrSupportLib: remove set but not used variables X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Liming Gao MIME-Version: 1.0 Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- EdkCompatibilityPkg/Foundation/Library/Dxe/UefiEfiIfrSupportLib/UefiIfrCommon.c | 4 ---- EdkCompatibilityPkg/Foundation/Library/Dxe/UefiEfiIfrSupportLib/UefiIfrForm.c | 4 ---- EdkCompatibilityPkg/Foundation/Library/Dxe/UefiEfiIfrSupportLib/UefiIfrOpCodeCreation.c | 2 -- 3 files changed, 10 deletions(-) -- 1.8.3.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel diff --git a/EdkCompatibilityPkg/Foundation/Library/Dxe/UefiEfiIfrSupportLib/UefiIfrCommon.c b/EdkCompatibilityPkg/Foundation/Library/Dxe/UefiEfiIfrSupportLib/UefiIfrCommon.c index 3f5243387d35..341930ae9a01 100644 --- a/EdkCompatibilityPkg/Foundation/Library/Dxe/UefiEfiIfrSupportLib/UefiIfrCommon.c +++ b/EdkCompatibilityPkg/Foundation/Library/Dxe/UefiEfiIfrSupportLib/UefiIfrCommon.c @@ -522,7 +522,6 @@ Returns: EFI_HII_DATABASE_PROTOCOL *HiiDatabase; EFI_HII_PACKAGE_LIST_HEADER *HiiPackageList; UINT8 *Package; - UINT8 *FormSet; UINT8 *OpCodeData; UINT32 Offset; UINT32 Offset2; @@ -572,7 +571,6 @@ Returns: // Offset = sizeof (EFI_HII_PACKAGE_LIST_HEADER); Offset2 = 0; - FormSet = NULL; EfiCopyMem (&PackageListLength, &HiiPackageList->PackageLength, sizeof (UINT32)); while (Offset < PackageListLength) { @@ -660,7 +658,6 @@ Returns: EFI_HII_DATABASE_PROTOCOL *HiiDatabase; EFI_HII_PACKAGE_LIST_HEADER *HiiPackageList; UINT8 *Package; - UINT8 *FormSet; UINT8 *OpCodeData; UINT32 Offset; UINT32 Offset2; @@ -709,7 +706,6 @@ Returns: // Offset = sizeof (EFI_HII_PACKAGE_LIST_HEADER); Offset2 = 0; - FormSet = NULL; EfiCopyMem (&PackageListLength, &HiiPackageList->PackageLength, sizeof (UINT32)); while (Offset < PackageListLength) { diff --git a/EdkCompatibilityPkg/Foundation/Library/Dxe/UefiEfiIfrSupportLib/UefiIfrForm.c b/EdkCompatibilityPkg/Foundation/Library/Dxe/UefiEfiIfrSupportLib/UefiIfrForm.c index 1452ef003504..864a850d4a79 100644 --- a/EdkCompatibilityPkg/Foundation/Library/Dxe/UefiEfiIfrSupportLib/UefiIfrForm.c +++ b/EdkCompatibilityPkg/Foundation/Library/Dxe/UefiEfiIfrSupportLib/UefiIfrForm.c @@ -452,9 +452,7 @@ Returns: UINTN Index; UINTN Count; UINTN Start; - UINTN End; UINTN Top; - UINTN Bottom; CHAR16 *StringPtr; UINTN LeftColumn; UINTN RightColumn; @@ -529,10 +527,8 @@ Returns: // each end plus a border. // Start = (DimensionsWidth - LargestString - 2) / 2 + LeftColumn + 1; - End = Start + LargestString + 1; Top = ((DimensionsHeight - NumberOfLines - 2) / 2) + TopRow - 1; - Bottom = Top + NumberOfLines + 2; // // Disable cursor diff --git a/EdkCompatibilityPkg/Foundation/Library/Dxe/UefiEfiIfrSupportLib/UefiIfrOpCodeCreation.c b/EdkCompatibilityPkg/Foundation/Library/Dxe/UefiEfiIfrSupportLib/UefiIfrOpCodeCreation.c index 2c454de95178..f96f3a2ea2bc 100644 --- a/EdkCompatibilityPkg/Foundation/Library/Dxe/UefiEfiIfrSupportLib/UefiIfrOpCodeCreation.c +++ b/EdkCompatibilityPkg/Foundation/Library/Dxe/UefiEfiIfrSupportLib/UefiIfrOpCodeCreation.c @@ -485,7 +485,6 @@ CreateNumericOpCode ( IN OUT EFI_HII_UPDATE_DATA *Data ) { - UINTN Length; EFI_STATUS Status; EFI_IFR_NUMERIC Numeric; MINMAXSTEP_DATA MinMaxStep; @@ -498,7 +497,6 @@ CreateNumericOpCode ( return EFI_INVALID_PARAMETER; } - Length = sizeof (EFI_IFR_NUMERIC) + sizeof (EFI_IFR_DEFAULT) + sizeof (EFI_IFR_END); if (Data->Offset + sizeof (EFI_IFR_CHECKBOX) > Data->BufferSize) { return EFI_BUFFER_TOO_SMALL; }