From patchwork Fri Aug 12 17:11:48 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leif Lindholm X-Patchwork-Id: 73864 Delivered-To: patch@linaro.org Received: by 10.140.29.52 with SMTP id a49csp273688qga; Fri, 12 Aug 2016 10:11:54 -0700 (PDT) X-Received: by 10.98.192.144 with SMTP id g16mr29261237pfk.55.1471021914354; Fri, 12 Aug 2016 10:11:54 -0700 (PDT) Return-Path: Received: from ml01.01.org (ml01.01.org. [2001:19d0:306:5::1]) by mx.google.com with ESMTPS id m6si9799795pfj.88.2016.08.12.10.11.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 12 Aug 2016 10:11:54 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) client-ip=2001:19d0:306:5::1; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE dis=NONE) header.from=linaro.org Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id A051A1A1E03; Fri, 12 Aug 2016 10:11:53 -0700 (PDT) X-Original-To: edk2-devel@lists.01.org Delivered-To: edk2-devel@lists.01.org Received: from mail-wm0-x22f.google.com (mail-wm0-x22f.google.com [IPv6:2a00:1450:400c:c09::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D8B321A1DF7 for ; Fri, 12 Aug 2016 10:11:51 -0700 (PDT) Received: by mail-wm0-x22f.google.com with SMTP id i5so46968525wmg.0 for ; Fri, 12 Aug 2016 10:11:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=xcN4SzP3KnLbdhGMH4E0kSMfcQ+6SXkhVdeQGfgsJ4o=; b=SpwTQc345Zl+9yFM5YEyG01/XUeFsKQeHIleEpLyTSruZophMM0dDToSKZDIHEQeU1 LgWB9NsrdB55LBvZ/2QicRsdkGNPIdgg0yoSybG0L0+oqTxyF+MNSOTtgbdAAsqkS++d MI3syxDaAbI9kc97gXknTxODT08R+5WueU44k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=xcN4SzP3KnLbdhGMH4E0kSMfcQ+6SXkhVdeQGfgsJ4o=; b=gnohfCn3/Z5J23cCvP96jEktGxN6v6aEydlJwwqqovu42lXRLicoODOxBlnanNQywY RHPollH7+ntZO+nfTdhbXUYjjX1CzpeVOZlcWZG2Wv6pgluxitA7GGY51Yax3ZxSTbsA NkeDZYuS6vDpb3nw2p3MCiugNi3bIhJCNONPNC7blRBDaMQzBz5HAeuB7emxEB7gts1J G8ZIw6Vr/JyDE7JmVrJNZZdmwvWGD2eZPPXzk416u6UjmNGiIDwfKUkPiLYttoSDVpNG M9BYJ3IYYJBmLdjEnhyyMSpa7BqLDYuRYBawROTDovz4V8G6TKjnnP3vTQKSAYeZKrrL DIdQ== X-Gm-Message-State: AEkoousKY2dAe5eexRvG4zrWrTY10OKIb6MmZJJTSLxVUabzFNqeR8uOet7QqVLEuq17rIlc X-Received: by 10.195.14.11 with SMTP id fc11mr16538828wjd.148.1471021910111; Fri, 12 Aug 2016 10:11:50 -0700 (PDT) Received: from mohikan.mushroom.smurfnet.nu (cpc92308-cmbg19-2-0-cust814.5-4.cable.virginm.net. [82.24.251.47]) by smtp.gmail.com with ESMTPSA id 17sm3416497wmf.6.2016.08.12.10.11.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 12 Aug 2016 10:11:49 -0700 (PDT) From: Leif Lindholm To: edk2-devel@lists.01.org Date: Fri, 12 Aug 2016 18:11:48 +0100 Message-Id: <1471021908-3509-1-git-send-email-leif.lindholm@linaro.org> X-Mailer: git-send-email 2.1.4 Subject: [edk2] [RFC] MdeModulePkg: ARM/AARCH64 requirements added to .dsc X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Feng Tian , Star Zeng , Ard Biesheuvel MIME-Version: 1.0 Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Leif Lindholm --- This is not a proposed change, but rather a demonstration: When trying to build HelloWorld standalone for ARM/AARCH64, with a command line like build -a AARCH64 -t GCC5 -p MdeModulePkg/MdeModulePkg.dsc \ -m MdeModulePkg/Application/HelloWorld/HelloWorld.inf this fails with /work/git/edk2/MdeModulePkg/MdeModulePkg.dsc(...): error 4000: Instance of library class [ArmMmuLib] is not found in [/work/git/edk2/MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf] [AARCH64] consumed by module [/work/git/edk2/MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf] Adding the below stanzas resolve the issue, but looking into why other architectures have no issues with this, I spot a lot of low-level MMU tweakery directly under DxeIplPeim. Would this not be better handled through some standardised mechanism? / Leif MdeModulePkg/MdeModulePkg.dsc | 8 ++++++++ 1 file changed, 8 insertions(+) -- 2.1.4 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel diff --git a/MdeModulePkg/MdeModulePkg.dsc b/MdeModulePkg/MdeModulePkg.dsc index 05120c7..e9c2866 100644 --- a/MdeModulePkg/MdeModulePkg.dsc +++ b/MdeModulePkg/MdeModulePkg.dsc @@ -24,6 +24,14 @@ [Defines] BUILD_TARGETS = DEBUG|RELEASE|NOOPT SKUID_IDENTIFIER = DEFAULT +[LibraryClasses.ARM, LibraryClasses.AARCH64] + ArmMmuLib|ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf +[LibraryClasses.ARM] + ArmLib|ArmPkg/Library/ArmLib/ArmV7/ArmV7Lib.inf + NULL|MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf +[LibraryClasses.AARCH64] + ArmLib|ArmPkg/Library/ArmLib/AArch64/AArch64Lib.inf + [LibraryClasses] # # Entry point