From patchwork Wed Mar 22 14:04:05 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ard Biesheuvel X-Patchwork-Id: 95742 Delivered-To: patch@linaro.org Received: by 10.182.3.34 with SMTP id 2csp230254obz; Wed, 22 Mar 2017 07:04:25 -0700 (PDT) X-Received: by 10.98.2.21 with SMTP id 21mr46806049pfc.93.1490191465569; Wed, 22 Mar 2017 07:04:25 -0700 (PDT) Return-Path: Received: from ml01.01.org (ml01.01.org. [198.145.21.10]) by mx.google.com with ESMTPS id j185si1932064pge.320.2017.03.22.07.04.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 22 Mar 2017 07:04:25 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) client-ip=198.145.21.10; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id A80B980423; Wed, 22 Mar 2017 07:04:23 -0700 (PDT) X-Original-To: edk2-devel@lists.01.org Delivered-To: edk2-devel@lists.01.org Received: from mail-wr0-x22e.google.com (mail-wr0-x22e.google.com [IPv6:2a00:1450:400c:c0c::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 10D4880423 for ; Wed, 22 Mar 2017 07:04:22 -0700 (PDT) Received: by mail-wr0-x22e.google.com with SMTP id l37so130396536wrc.1 for ; Wed, 22 Mar 2017 07:04:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=WC7cFSCtOtoaWqPSma6xgoOnRQ3RQb5v7zP6JSUvt6s=; b=e2OjCz8W90ZuPj7E3E7wJX1pWzIS1WEm1dhxdCV97BZ3K0IPly4PIAUdCYy1j0m+jV YPPP4t174qIVSy9wYCgUK18iCUyPtS2YgJpemS6cEauu3kZ0ARPxlShGJfSci7Ogx8e9 LXkQtcudtYPgP78VKAYpw3XHr+GurTfIf+Eis= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=WC7cFSCtOtoaWqPSma6xgoOnRQ3RQb5v7zP6JSUvt6s=; b=Ik3zmAVB6kbUwpGfimFqQYUtlwtR2d832qeMQnVLpUvicolnCFKiXeD64Nvwwz0YTW YR43oAieQ+cIhnsWE9wJERV1pI/QJSqxg5Yt6XxGpkwMjI8Cw/r2JAwxplwL5S9JYP24 6PUA0s5dYtPcU9uiUt8WPTXKVut9MhZb2NnJtiSjq6TpGca6CcNSKrhq7gq46etkroC9 XVF6DTUi+q+dDQclSVQ2ksTKRoQZcFIr2V5cW0VjunAlE0AuODfQMzfKLRjbaosauIii zds40mOJBiDjYujJlAxNFzA5rrh9cxFsSUCPA635Aa/KTdzyg9Bg4nRC9VjyTme+ZzMB PsUA== X-Gm-Message-State: AFeK/H1mg++05dd+QWH/lgy5OuFrP1cnZHeG+y10+b58TosleOwHVo4Vqd76u/lgzdiSt/Zs X-Received: by 10.223.171.23 with SMTP id q23mr35125768wrc.163.1490191460711; Wed, 22 Mar 2017 07:04:20 -0700 (PDT) Received: from localhost.localdomain ([160.172.77.216]) by smtp.gmail.com with ESMTPSA id 134sm507113wmj.6.2017.03.22.07.04.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 22 Mar 2017 07:04:19 -0700 (PDT) From: Ard Biesheuvel To: edk2-devel@lists.01.org, leif.lindholm@linaro.org, lersek@redhat.com, jaben.carsey@intel.com, ruiyu.ni@intel.com, michael.d.kinney@intel.com, kelly.steele@intel.com Date: Wed, 22 Mar 2017 14:04:05 +0000 Message-Id: <1490191448-22398-2-git-send-email-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1490191448-22398-1-git-send-email-ard.biesheuvel@linaro.org> References: <1490191448-22398-1-git-send-email-ard.biesheuvel@linaro.org> Subject: [edk2] [PATCH 1/4] ShellPkg: add GUID declaration for FILE_GUID of UEFI Shell app to package X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ard Biesheuvel MIME-Version: 1.0 Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" In QuarkPlatformPkg/Library/PlatformBootManagerLib/PlatformBootManager.c, there is a definition of mUefiShellFileGuid which is a constant reference to the FILE_GUID as defined in ShellPkg/Application/Shell/Shell.inf. To prevent the need for duplicating it to other modules, promote it to a proper global GUID, and add it to the ShellPkg.dec package declaration. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- ShellPkg/ShellPkg.dec | 3 +++ 1 file changed, 3 insertions(+) -- 2.7.4 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel Reviewed-by: Jaben Carsey diff --git a/ShellPkg/ShellPkg.dec b/ShellPkg/ShellPkg.dec index bb31c2df8cb3..3ad17a44b447 100644 --- a/ShellPkg/ShellPkg.dec +++ b/ShellPkg/ShellPkg.dec @@ -57,6 +57,9 @@ [Guids] gShellTftpHiiGuid = {0x738a9314, 0x82c1, 0x4592, {0x8f, 0xf7, 0xc1, 0xbd, 0xf1, 0xb2, 0x0e, 0xd4}} gShellBcfgHiiGuid = {0x5f5f605d, 0x1583, 0x4a2d, {0xa6, 0xb2, 0xeb, 0x12, 0xda, 0xb4, 0xa2, 0xb6}} + # FILE_GUID as defined in ShellPkg/Application/Shell/Shell.inf + gUefiShellFileGuid = {0x7c04a583, 0x9e3e, 0x4f1c, {0xad, 0x65, 0xe0, 0x52, 0x68, 0xd0, 0xb4, 0xd1}} + [Protocols] gEfiShellEnvironment2Guid = {0x47c7b221, 0xc42a, 0x11d2, {0x8e, 0x57, 0x00, 0xa0, 0xc9, 0x69, 0x72, 0x3b}} gEfiShellInterfaceGuid = {0x47c7b223, 0xc42a, 0x11d2, {0x8e, 0x57, 0x00, 0xa0, 0xc9, 0x69, 0x72, 0x3b}}