From patchwork Wed Oct 12 10:09:01 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laszlo Ersek X-Patchwork-Id: 77538 Delivered-To: patch@linaro.org Received: by 10.140.97.247 with SMTP id m110csp377462qge; Wed, 12 Oct 2016 03:09:14 -0700 (PDT) X-Received: by 10.66.54.227 with SMTP id m3mr401975pap.132.1476266954835; Wed, 12 Oct 2016 03:09:14 -0700 (PDT) Return-Path: Received: from ml01.01.org (ml01.01.org. [198.145.21.10]) by mx.google.com with ESMTPS id i4si5126516pgn.209.2016.10.12.03.09.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 12 Oct 2016 03:09:14 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) client-ip=198.145.21.10; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 21DC31A1E9E; Wed, 12 Oct 2016 03:09:14 -0700 (PDT) X-Original-To: edk2-devel@ml01.01.org Delivered-To: edk2-devel@ml01.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id AC7731A1E30 for ; Wed, 12 Oct 2016 03:09:12 -0700 (PDT) Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 378A16371F; Wed, 12 Oct 2016 10:09:12 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-37.phx2.redhat.com [10.3.116.37]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u9CA99vd006514; Wed, 12 Oct 2016 06:09:11 -0400 From: Laszlo Ersek To: edk2-devel-01 Date: Wed, 12 Oct 2016 12:09:01 +0200 Message-Id: <20161012100905.6296-2-lersek@redhat.com> In-Reply-To: <20161012100905.6296-1-lersek@redhat.com> References: <20161012100905.6296-1-lersek@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.26 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Wed, 12 Oct 2016 10:09:12 +0000 (UTC) Subject: [edk2] [PATCH 1/5] OvmfPkg/QemuVideoDxe: drop useless QEMU_VIDEO_MODE_DATA.RefreshRate X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jordan Justen MIME-Version: 1.0 Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" This field is never used beyond assignment and debug-logging. Remove it. Cc: Jordan Justen Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- OvmfPkg/QemuVideoDxe/Qemu.h | 1 - OvmfPkg/QemuVideoDxe/Initialize.c | 12 ++++-------- 2 files changed, 4 insertions(+), 9 deletions(-) -- 2.9.2 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel diff --git a/OvmfPkg/QemuVideoDxe/Qemu.h b/OvmfPkg/QemuVideoDxe/Qemu.h index 5844bc404cef..7c1f80c772e3 100644 --- a/OvmfPkg/QemuVideoDxe/Qemu.h +++ b/OvmfPkg/QemuVideoDxe/Qemu.h @@ -54,11 +54,10 @@ typedef struct { UINT32 InternalModeIndex; // points into card-specific mode table UINT32 HorizontalResolution; UINT32 VerticalResolution; UINT32 ColorDepth; - UINT32 RefreshRate; } QEMU_VIDEO_MODE_DATA; #define PIXEL_RED_SHIFT 0 #define PIXEL_GREEN_SHIFT 3 #define PIXEL_BLUE_SHIFT 6 diff --git a/OvmfPkg/QemuVideoDxe/Initialize.c b/OvmfPkg/QemuVideoDxe/Initialize.c index 9e0c3aa09fd6..b12253ba5892 100644 --- a/OvmfPkg/QemuVideoDxe/Initialize.c +++ b/OvmfPkg/QemuVideoDxe/Initialize.c @@ -184,19 +184,17 @@ QemuVideoCirrusModeSetup ( for (Index = 0; Index < QEMU_VIDEO_CIRRUS_MODE_COUNT; Index ++) { ModeData->InternalModeIndex = Index; ModeData->HorizontalResolution = VideoMode->Width; ModeData->VerticalResolution = VideoMode->Height; ModeData->ColorDepth = VideoMode->ColorDepth; - ModeData->RefreshRate = VideoMode->RefreshRate; DEBUG ((EFI_D_INFO, - "Adding Mode %d as Cirrus Internal Mode %d: %dx%d, %d-bit, %d Hz\n", + "Adding Mode %d as Cirrus Internal Mode %d: %dx%d, %d-bit\n", (INT32) (ModeData - Private->ModeData), ModeData->InternalModeIndex, ModeData->HorizontalResolution, ModeData->VerticalResolution, - ModeData->ColorDepth, - ModeData->RefreshRate + ModeData->ColorDepth )); ModeData ++ ; VideoMode ++; } @@ -328,19 +326,17 @@ QemuVideoBochsModeSetup ( if (RequiredFbSize <= AvailableFbSize) { ModeData->InternalModeIndex = Index; ModeData->HorizontalResolution = VideoMode->Width; ModeData->VerticalResolution = VideoMode->Height; ModeData->ColorDepth = VideoMode->ColorDepth; - ModeData->RefreshRate = 60; DEBUG ((EFI_D_INFO, - "Adding Mode %d as Bochs Internal Mode %d: %dx%d, %d-bit, %d Hz\n", + "Adding Mode %d as Bochs Internal Mode %d: %dx%d, %d-bit\n", (INT32) (ModeData - Private->ModeData), ModeData->InternalModeIndex, ModeData->HorizontalResolution, ModeData->VerticalResolution, - ModeData->ColorDepth, - ModeData->RefreshRate + ModeData->ColorDepth )); ModeData ++ ; } VideoMode ++;