From patchwork Tue Nov 6 17:58:32 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ard Biesheuvel X-Patchwork-Id: 150320 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp4192989ljp; Tue, 6 Nov 2018 10:00:02 -0800 (PST) X-Google-Smtp-Source: AJdET5eTUpjfuzU8yv33SL8Y61GVkk1mja5cVXvsNSeZfTsM6SmxYr4nhECPOPddEbjcJuALXWv2 X-Received: by 2002:a62:1954:: with SMTP id 81-v6mr27216866pfz.237.1541527202837; Tue, 06 Nov 2018 10:00:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1541527202; cv=none; d=google.com; s=arc-20160816; b=fzDW12bbPelBiALNHEvQ4fENYvZNtXwL9HgV82fpQQaKHNwQxSxRgHJBuKpRDDTxr/ MFbprslHgdWVXapYabtS7hYSafWrhWeMfuGe35ZqNp1tOGdycJJH5rMw+7tO6P4y+CAE +q6UkNDEpFxuX7W9YebWJtsM/n2oyWqKDjExcvwgdpXQvQgrmrxUbtfofPTTVeftyITS pse5DAR5oobmEQKuoTXLSjfMOJKgmK8VI63+setidGGub2V2i/A6L//wnw5Vvc+Slvk/ u144PBrZ68Xtlb9eghbLKOuCiLHwq3Rqgx6Jy0hy2AQDOWeHuXtk+M0LlBOGhlmLiuW0 i3YQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:references:in-reply-to:message-id :date:to:from:dkim-signature:delivered-to; bh=/rXDfuPfUNmWLoMyGKqlswOltmlG2TJJrDtBMyKNwjM=; b=nScDEU8gSuspIW3DNt1hArbEzKpkQYKZcSCG0YSe6z3fV49sWPi1Cq66f1adxQ5j7u oGCo4mINiHuerBH7wufTuBzSx9sQl54o/gPwvAfJXZo4tGAwyUgSKQu4MEgmGuEyasY8 rvqA1/w3ZEYfT8+8oY/G1mrRHzlfiHwVbX33gha/AYgFl2dfhagbF4qtfLZjCKbpwi7v DIeMMRcpjKqSt4q2tUfzwOurVWS/OfHIvWOwsIF2haFsIHG8T6om5/5G2YHW1pKb/hQZ 8b2u2NbIDw3r+HKjRRt2zo8Nw7pi0eWYWeH6s5eqs4hYfkxwLuWir7NTKAKaR36ePe8l d4kA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=Qd5cI8JN; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from ml01.01.org (ml01.01.org. [198.145.21.10]) by mx.google.com with ESMTPS id h71-v6si49028369pfa.261.2018.11.06.10.00.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Nov 2018 10:00:02 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) client-ip=198.145.21.10; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=Qd5cI8JN; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id BD8912118D92B; Tue, 6 Nov 2018 09:59:15 -0800 (PST) X-Original-To: edk2-devel@lists.01.org Delivered-To: edk2-devel@lists.01.org Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::442; helo=mail-wr1-x442.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 757822118D923 for ; Tue, 6 Nov 2018 09:59:14 -0800 (PST) Received: by mail-wr1-x442.google.com with SMTP id k15-v6so11595055wre.12 for ; Tue, 06 Nov 2018 09:59:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=taSk5R2Jst74hTMPa/m4SIFWRe/HGuvABbklkoONmPc=; b=Qd5cI8JN/WvnUn+Mle4c6BaebEVTd1rHguKjqth2dQYU8/alVuMiwv2c9Q4NFvwW2V YzamMQaV/4qLM54g1RcLx5NaUbcEtJrNq5z2vSHpebq/c5vAoAxmd9LglRFmcYiYt+U4 PQiN6FmEziqjQOU3m/GITmvMunLVrQAfRA488= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=taSk5R2Jst74hTMPa/m4SIFWRe/HGuvABbklkoONmPc=; b=ZkSMZ98BtzBoijRRguJyUIvUz+jUN3R9gV6d+z+s+z8FE2yN+c0u8jLZ9PCj1OMlOg MsUUZ1ywrqzpio7OhZRRwbLfAvzbRyaRSXqzz2W1LcWRUHt/pi/8NO0TCfDV1FcrehWJ IYo658jvLW7TnZzx5+e/IM1V17kQstDet20VVdanEonr1O5hAPdX8Q3BD3gD9jizy7AQ CIMXfsPqEW7fvfdXTA3UjOo4gY9Uf5fp81b7FvGbTokYnZ+Hy03T84OCKXJN6JmJaP18 jlc8xxsx5w4froZhdcy0lATiumnfldrvaam2HgSiktodrJXxzI8P5MUeISNJBP136LaD 3V5w== X-Gm-Message-State: AGRZ1gJEFGwvwq8fnCmsSKpQg17Xr1omucwyiL/fRDuUC1v7jh/EMN7Y 7fZi5Akzl21aBo0KoABDdwWXrn+gSn8= X-Received: by 2002:adf:e651:: with SMTP id b17-v6mr24454148wrn.254.1541527152710; Tue, 06 Nov 2018 09:59:12 -0800 (PST) Received: from localhost.localdomain (laubervilliers-657-1-83-120.w92-154.abo.wanadoo.fr. [92.154.90.120]) by smtp.gmail.com with ESMTPSA id 134-v6sm2971522wmp.6.2018.11.06.09.59.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Nov 2018 09:59:11 -0800 (PST) From: Ard Biesheuvel To: edk2-devel@lists.01.org Date: Tue, 6 Nov 2018 18:58:32 +0100 Message-Id: <20181106175833.26964-19-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181106175833.26964-1-ard.biesheuvel@linaro.org> References: <20181106175833.26964-1-ard.biesheuvel@linaro.org> MIME-Version: 1.0 Subject: [edk2] [PATCH edk2-staging 18/19] IntelUndiPkg/GigUndiDxe: add missing EFIAPI modifiers X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: michael.d.kinney@intel.com, eric.jin@intel.com Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- IntelUndiPkg/GigUndiDxe/AdapterInformation.c | 3 +++ IntelUndiPkg/GigUndiDxe/ComponentName.c | 2 ++ IntelUndiPkg/GigUndiDxe/ComponentName.h | 1 + IntelUndiPkg/GigUndiDxe/DriverConfiguration.c | 3 +++ IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c | 1 + IntelUndiPkg/GigUndiDxe/DriverHealth.c | 2 ++ IntelUndiPkg/GigUndiDxe/StartStop.c | 2 ++ 7 files changed, 14 insertions(+) -- 2.19.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel Reviewed-by: Ryszard Knop diff --git a/IntelUndiPkg/GigUndiDxe/AdapterInformation.c b/IntelUndiPkg/GigUndiDxe/AdapterInformation.c index 8918c538e447..1cece79911b1 100644 --- a/IntelUndiPkg/GigUndiDxe/AdapterInformation.c +++ b/IntelUndiPkg/GigUndiDxe/AdapterInformation.c @@ -123,6 +123,7 @@ GetIpv6SupportInformationBlock ( **/ STATIC EFI_STATUS +EFIAPI GetInformation ( IN EFI_ADAPTER_INFORMATION_PROTOCOL *This, IN EFI_GUID * InformationType, @@ -188,6 +189,7 @@ GetInformation ( **/ STATIC EFI_STATUS +EFIAPI SetInformation ( IN EFI_ADAPTER_INFORMATION_PROTOCOL *This, IN EFI_GUID * InformationType, @@ -234,6 +236,7 @@ SetInformation ( **/ STATIC EFI_STATUS +EFIAPI GetSupportedTypes ( IN EFI_ADAPTER_INFORMATION_PROTOCOL *This, OUT EFI_GUID ** InfoTypesBuffer, diff --git a/IntelUndiPkg/GigUndiDxe/ComponentName.c b/IntelUndiPkg/GigUndiDxe/ComponentName.c index 70baf00f4a5d..2bf9bbfbe0e4 100644 --- a/IntelUndiPkg/GigUndiDxe/ComponentName.c +++ b/IntelUndiPkg/GigUndiDxe/ComponentName.c @@ -112,6 +112,7 @@ ComponentNameInitializeControllerName ( language specified by Language. **/ EFI_STATUS +EFIAPI ComponentNameGetDriverName ( IN EFI_COMPONENT_NAME_PROTOCOL *This, IN CHAR8 * Language, @@ -182,6 +183,7 @@ ComponentNameGetDriverName ( language specified by Language. **/ EFI_STATUS +EFIAPI ComponentNameGetControllerName ( IN EFI_COMPONENT_NAME_PROTOCOL * This, IN EFI_HANDLE ControllerHandle, diff --git a/IntelUndiPkg/GigUndiDxe/ComponentName.h b/IntelUndiPkg/GigUndiDxe/ComponentName.h index 5a3d414c6970..0b93a5410fc0 100644 --- a/IntelUndiPkg/GigUndiDxe/ComponentName.h +++ b/IntelUndiPkg/GigUndiDxe/ComponentName.h @@ -65,6 +65,7 @@ ComponentNameInitializeControllerName ( language specified by Language. **/ EFI_STATUS +EFIAPI ComponentNameGetDriverName ( IN EFI_COMPONENT_NAME_PROTOCOL *This, IN CHAR8 * Language, diff --git a/IntelUndiPkg/GigUndiDxe/DriverConfiguration.c b/IntelUndiPkg/GigUndiDxe/DriverConfiguration.c index 20d40ab672ef..99e086d81044 100644 --- a/IntelUndiPkg/GigUndiDxe/DriverConfiguration.c +++ b/IntelUndiPkg/GigUndiDxe/DriverConfiguration.c @@ -310,6 +310,7 @@ GigUndiDriverConfigurationDisplayMenu ( @retval EFI_SUCCESS Configuration was successful **/ EFI_STATUS +EFIAPI GigUndiDriverConfigurationSetOptions ( IN EFI_DRIVER_CONFIGURATION_PROTOCOL * This, IN EFI_HANDLE ControllerHandle, @@ -418,6 +419,7 @@ GigUndiDriverConfigurationSetOptions ( @retval EFI_SUCCESS Always returned **/ EFI_STATUS +EFIAPI GigUndiDriverConfigurationOptionsValid ( IN EFI_DRIVER_CONFIGURATION_PROTOCOL * This, IN EFI_HANDLE ControllerHandle, @@ -442,6 +444,7 @@ GigUndiDriverConfigurationOptionsValid ( @retval EFI_SUCCESS Configuration was successful **/ EFI_STATUS +EFIAPI GigUndiDriverConfigurationForceDefaults ( IN EFI_DRIVER_CONFIGURATION_PROTOCOL * This, IN EFI_HANDLE ControllerHandle, diff --git a/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c b/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c index aceb015e480f..f6152cd24c59 100644 --- a/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c +++ b/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c @@ -1394,6 +1394,7 @@ Error: ChildHandle did not pass the diagnostic. **/ EFI_STATUS +EFIAPI GigUndiDriverDiagnosticsRunDiagnostics ( IN EFI_DRIVER_DIAGNOSTICS_PROTOCOL * This, IN EFI_HANDLE ControllerHandle, diff --git a/IntelUndiPkg/GigUndiDxe/DriverHealth.c b/IntelUndiPkg/GigUndiDxe/DriverHealth.c index b5b7db5fd814..ea306843679a 100644 --- a/IntelUndiPkg/GigUndiDxe/DriverHealth.c +++ b/IntelUndiPkg/GigUndiDxe/DriverHealth.c @@ -44,6 +44,7 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. @retval !EFI_SUCCESS Failure to retrieve health status **/ EFI_STATUS +EFIAPI GetHealthStatus ( IN EFI_DRIVER_HEALTH_PROTOCOL * This, IN EFI_HANDLE ControllerHandle, OPTIONAL @@ -119,6 +120,7 @@ GetHealthStatus ( @retval EFI_UNSUPPORTED This function is unsupported **/ EFI_STATUS +EFIAPI Repair ( IN EFI_DRIVER_HEALTH_PROTOCOL *This, IN EFI_HANDLE ControllerHandle, diff --git a/IntelUndiPkg/GigUndiDxe/StartStop.c b/IntelUndiPkg/GigUndiDxe/StartStop.c index 32bed7ce288d..a788da247e6d 100644 --- a/IntelUndiPkg/GigUndiDxe/StartStop.c +++ b/IntelUndiPkg/GigUndiDxe/StartStop.c @@ -38,6 +38,7 @@ EFI_GUID gEfiStartStopProtocolGuid = EFI_DRIVER_STOP_PROTOCOL_GUID; @retval EFI_SUCCESS Driver is stopped successfully **/ EFI_STATUS +EFIAPI StopDriver ( IN EFI_DRIVER_STOP_PROTOCOL *This ) @@ -62,6 +63,7 @@ StopDriver ( @retval EFI_SUCCESS If driver has restarted successfully **/ EFI_STATUS +EFIAPI StartDriver ( IN EFI_DRIVER_STOP_PROTOCOL *This )