From patchwork Thu Nov 15 02:33:49 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ard Biesheuvel X-Patchwork-Id: 151153 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp6454082ljp; Wed, 14 Nov 2018 18:35:13 -0800 (PST) X-Google-Smtp-Source: AJdET5cJ3nY62TbAYbUg1r25JtDg1ey3615mx+Dz0vSPzsFvix7RtakmrLMILL6kjcy8sGxJaHby X-Received: by 2002:a6b:bfc2:: with SMTP id p185-v6mr3885854iof.38.1542249313532; Wed, 14 Nov 2018 18:35:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542249313; cv=none; d=google.com; s=arc-20160816; b=PqGO0PyMN4d09ZdJPwwKWyZAQqAfLGSLqwyT3r4POwG6KemUT42IgBykD3DTW0f74V 5BF03x4WP7wIAgZnDMRyJ0FikdLn1ilaPR4EAJ2qJYGiYZW5N7BMu7CwUBdW+f91tQMH x3SZyiL1/bIfYABnC89MBVVWRu5aJ50UzTgUm/gdCut4W2ug6TgnffmRwNxqZ0Qr5upU 1Cx3hD41ucCG7/eGgplG8LsHK1788a8OryhzRURLn7cDOZZol+SuFfuIDrPH9Adhb3Ng IS0CUMW10mnUXl+8GtBTC04ntVXBh2R9913uzeq7gRV6rWbP9hAvAVcnIP6DhJ0/nsP9 ldEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:cc :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:references:in-reply-to:message-id:date :to:from:dkim-signature:delivered-to; bh=UxfET2iyTnmUbxP3LwBiTjoU07JkNmFPJqijOqYcVdQ=; b=qEcR7wAJSpVVCKpjpYxMVE9TzqYo92GgiBDPwC6gBT+kJcqQuHowGmnPTZpmJp/xu3 aaS6tIfhmlbr0CvxK2oKkK9AdRIIGkMPTN7RHcI6dVySOclBqKJihoNL/AiP8Z+MXVqO JLx5YkIaCA81ECP0mHFsaTrZvbR+6JBIeIwhTNy2aCvd0jvJgcAW1K1GWprdMCwFbz8r PGcyBxQPXH+9UjExJKfwWYQHtXkPmvW8mvn6B3zoxJOm/QnJEeqXpXDARWF9R1hO7zwv 2fmmMO58+R9hP6RP+2AzhpP4o2a0MdsjEdQHtIb013n05p1TiKwl+gV9DcJzUoI87PJF 6dNQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=Dau8uHz3; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from ml01.01.org (ml01.01.org. [2001:19d0:306:5::1]) by mx.google.com with ESMTPS id b68-v6si18927377jai.68.2018.11.14.18.35.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 14 Nov 2018 18:35:13 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) client-ip=2001:19d0:306:5::1; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=Dau8uHz3; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id EA0822119173F; Wed, 14 Nov 2018 18:34:21 -0800 (PST) X-Original-To: edk2-devel@lists.01.org Delivered-To: edk2-devel@lists.01.org Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::541; helo=mail-pg1-x541.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-pg1-x541.google.com (mail-pg1-x541.google.com [IPv6:2607:f8b0:4864:20::541]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1D7BC21191739 for ; Wed, 14 Nov 2018 18:34:21 -0800 (PST) Received: by mail-pg1-x541.google.com with SMTP id w3-v6so8259999pgs.11 for ; Wed, 14 Nov 2018 18:34:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=XZsatKNchnoIx7N3MmvGSZf4KDV3cZ0L8e/2cbI1RLk=; b=Dau8uHz35I/3Qz+Y3LsTfO4K9sVgLC3ra+jEX5h7GvFYToUeYC5YO1dHDh2BA6atHi U1BrYgqFPUy16p/x8QV+F1AiLNxvK9mfbOqwmkxC9SJ5J0QXcW7v8PkDxoFAWd6iv8ld TXDkvHVGTEExRWVk158ZyNt0gUMEIP/vAnI5I= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=XZsatKNchnoIx7N3MmvGSZf4KDV3cZ0L8e/2cbI1RLk=; b=B4k4v4wcxVs+Tp/0v4Kl2nq3mRa9dXTmJnkxOBkLKYyRDX94WSdTjy1Y11eaNHmcbp bpOP/cb2g2wRsMnwfipppq1afGYPbF2ay2mB+F1sv5om5gCeJBZAwSEJivsidrnSRsDE NoP9TkM7jvJ7ZRZjznnd6XJehgMPsp9nqLti8NsABd3WImlPcqNKMTcyEKrhEbFuSyR+ vgfYfri+MqXFbALulFtNR9n1Ij0JZeicyvRM1chL9x2sOKa4C7nba72G0NPUsIy8Ermx tS1IofwJb9BnULmIAi0TGpLWWRbOoaFUypEc3Ocirx2ScO1deLPfU6sBtAVbh7bkjdw9 teDg== X-Gm-Message-State: AGRZ1gK+KA1xgb1wgwNWLn29kL+gytvVPtWkzDO1El8UMphX+Fa5ZNlO fZroPviIYB6nZT0MhU9gse2taW0YSCeA4A== X-Received: by 2002:a63:42c1:: with SMTP id p184mr4098267pga.202.1542249260596; Wed, 14 Nov 2018 18:34:20 -0800 (PST) Received: from mba13.psav.com ([64.114.255.97]) by smtp.gmail.com with ESMTPSA id v185-v6sm27323393pfv.48.2018.11.14.18.34.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 14 Nov 2018 18:34:19 -0800 (PST) From: Ard Biesheuvel To: edk2-devel@lists.01.org Date: Wed, 14 Nov 2018 18:33:49 -0800 Message-Id: <20181115023353.20159-17-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20181115023353.20159-1-ard.biesheuvel@linaro.org> References: <20181115023353.20159-1-ard.biesheuvel@linaro.org> Subject: [edk2] [PATCH edk2-staging 16/20] IntelUndiPkg/XGigUndiDxe: add missing EFIAPI modifiers X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kamil.kacperski@intel.com, eric.jin@intel.com, pawel.orlowski@intel.com, michael.d.kinney@intel.com, harry.l.hsiung@intel.com MIME-Version: 1.0 Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" When building for the X64 target using GCC, correct use of the EFIAPI modifiers is essential to ensure that the correct calling convention is used. So add the missing ones where appropriate. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- IntelUndiPkg/XGigUndiDxe/AdapterInformation.c | 3 +++ IntelUndiPkg/XGigUndiDxe/ComponentName.c | 2 ++ IntelUndiPkg/XGigUndiDxe/ComponentName.h | 1 + IntelUndiPkg/XGigUndiDxe/DriverDiagnostics.c | 1 + IntelUndiPkg/XGigUndiDxe/DriverHealth.c | 2 ++ IntelUndiPkg/XGigUndiDxe/StartStop.c | 2 ++ 6 files changed, 11 insertions(+) -- 2.17.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel Reviewed-by: Ryszard Knop diff --git a/IntelUndiPkg/XGigUndiDxe/AdapterInformation.c b/IntelUndiPkg/XGigUndiDxe/AdapterInformation.c index 26556e284381..b25ed7c4f022 100644 --- a/IntelUndiPkg/XGigUndiDxe/AdapterInformation.c +++ b/IntelUndiPkg/XGigUndiDxe/AdapterInformation.c @@ -123,6 +123,7 @@ GetIpv6SupportInformationBlock ( **/ STATIC EFI_STATUS +EFIAPI GetInformation ( IN EFI_ADAPTER_INFORMATION_PROTOCOL *This, IN EFI_GUID * InformationType, @@ -188,6 +189,7 @@ GetInformation ( **/ STATIC EFI_STATUS +EFIAPI SetInformation ( IN EFI_ADAPTER_INFORMATION_PROTOCOL *This, IN EFI_GUID * InformationType, @@ -234,6 +236,7 @@ SetInformation ( **/ STATIC EFI_STATUS +EFIAPI GetSupportedTypes ( IN EFI_ADAPTER_INFORMATION_PROTOCOL *This, OUT EFI_GUID ** InfoTypesBuffer, diff --git a/IntelUndiPkg/XGigUndiDxe/ComponentName.c b/IntelUndiPkg/XGigUndiDxe/ComponentName.c index 2972c28bda4e..eee59d7c14f4 100644 --- a/IntelUndiPkg/XGigUndiDxe/ComponentName.c +++ b/IntelUndiPkg/XGigUndiDxe/ComponentName.c @@ -116,6 +116,7 @@ ComponentNameInitializeControllerName ( language specified by Language. **/ EFI_STATUS +EFIAPI ComponentNameGetDriverName ( IN EFI_COMPONENT_NAME_PROTOCOL *This, IN CHAR8 * Language, @@ -186,6 +187,7 @@ ComponentNameGetDriverName ( language specified by Language. **/ EFI_STATUS +EFIAPI ComponentNameGetControllerName ( IN EFI_COMPONENT_NAME_PROTOCOL * This, IN EFI_HANDLE ControllerHandle, diff --git a/IntelUndiPkg/XGigUndiDxe/ComponentName.h b/IntelUndiPkg/XGigUndiDxe/ComponentName.h index f63d58b8a18c..4f62e48379ed 100644 --- a/IntelUndiPkg/XGigUndiDxe/ComponentName.h +++ b/IntelUndiPkg/XGigUndiDxe/ComponentName.h @@ -67,6 +67,7 @@ ComponentNameInitializeControllerName ( language specified by Language. **/ EFI_STATUS +EFIAPI ComponentNameGetDriverName ( IN EFI_COMPONENT_NAME_PROTOCOL *This, IN CHAR8 * Language, diff --git a/IntelUndiPkg/XGigUndiDxe/DriverDiagnostics.c b/IntelUndiPkg/XGigUndiDxe/DriverDiagnostics.c index 2f9c66771910..77b7a954698b 100644 --- a/IntelUndiPkg/XGigUndiDxe/DriverDiagnostics.c +++ b/IntelUndiPkg/XGigUndiDxe/DriverDiagnostics.c @@ -370,6 +370,7 @@ XgbeUndiPhyLoopback ( ChildHandle did not pass the diagnostic. **/ EFI_STATUS +EFIAPI XgbeUndiDriverDiagnosticsRunDiagnostics ( IN EFI_DRIVER_DIAGNOSTICS_PROTOCOL * This, IN EFI_HANDLE ControllerHandle, diff --git a/IntelUndiPkg/XGigUndiDxe/DriverHealth.c b/IntelUndiPkg/XGigUndiDxe/DriverHealth.c index df6cfdf8a123..4b173bc8d8a9 100644 --- a/IntelUndiPkg/XGigUndiDxe/DriverHealth.c +++ b/IntelUndiPkg/XGigUndiDxe/DriverHealth.c @@ -45,6 +45,7 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. @retval !EFI_SUCCESS Failure to retrieve health status **/ EFI_STATUS +EFIAPI GetHealthStatus ( IN EFI_DRIVER_HEALTH_PROTOCOL * This, IN EFI_HANDLE ControllerHandle, OPTIONAL @@ -145,6 +146,7 @@ GetHealthStatus ( @retval EFI_UNSUPPORTED This function is unsupported **/ EFI_STATUS +EFIAPI Repair ( IN EFI_DRIVER_HEALTH_PROTOCOL *This, IN EFI_HANDLE ControllerHandle, diff --git a/IntelUndiPkg/XGigUndiDxe/StartStop.c b/IntelUndiPkg/XGigUndiDxe/StartStop.c index 156e927a35c6..c881c811aefb 100644 --- a/IntelUndiPkg/XGigUndiDxe/StartStop.c +++ b/IntelUndiPkg/XGigUndiDxe/StartStop.c @@ -38,6 +38,7 @@ EFI_GUID gEfiStartStopProtocolGuid = EFI_DRIVER_STOP_PROTOCOL_GUID; @retval EFI_SUCCESS Driver is stopped successfully **/ EFI_STATUS +EFIAPI StopDriver ( IN EFI_DRIVER_STOP_PROTOCOL *This ) @@ -63,6 +64,7 @@ StopDriver ( @retval EFI_DEVICE_ERROR Failed to initialize hardware **/ EFI_STATUS +EFIAPI StartDriver ( IN EFI_DRIVER_STOP_PROTOCOL *This )