From patchwork Thu Nov 15 02:33:50 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ard Biesheuvel X-Patchwork-Id: 151154 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp6454110ljp; Wed, 14 Nov 2018 18:35:18 -0800 (PST) X-Google-Smtp-Source: AJdET5cTTIpPvr9PGjoxF9jaajHlpTNAu2tTbRSish92QQ33SJ4DYjWcBq/wkUkFVA6AFdmoPE88 X-Received: by 2002:a63:2109:: with SMTP id h9mr4057582pgh.277.1542249317777; Wed, 14 Nov 2018 18:35:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542249317; cv=none; d=google.com; s=arc-20160816; b=CG8Qpg9SmOwa4IxKvAW4pc6U12cNfJ7lC2BWCmgzpSuprWgYtFBKmjlQaWccvo0oxx P/Di8Y6dQDvd2TyFzDb7FQde5l2BvdG9qWZLIun13BCLtn4EGwPSwyM22rda1wAFcqoy 5hv+4q0Ke57I8jGW02GveI0Ij0DeQ0LNwgbJLiF5ttwjR9yP1BI+5OowDunKMMWjk7C3 NENo0MEymmc07lpfM9gtqvcCvgulCXq/BJeHXH+8IlDXoFAKbf5w+F0J0A96f6iS4yDI Nv4Pru9zUcquryh6aGDpv8/FRZ6DmkZIuF5IxTB2LtGxQUFiAVISAxAIIWnHU01tGdAF jyZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:cc :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:references:in-reply-to:message-id:date :to:from:dkim-signature:delivered-to; bh=W1EdcwhL+7TW6uaT2wgVJdYyMrPLMqcCFBE5Cyrd+Gc=; b=0hx/zU+U9sAtqCWMIUWfnnI47hbqw2/H00NT0VWpB3EXK0aqTMZjCYHKHL9ZjNKdSn jquIyUhRRgIcTdwAwwpQmBJTjukV1s/W6G63Ep8vTjIYL4HB6C5Wll/lakHAi07m6d4u F1Z4l6GOUhfLNwJJIR5nqIe0XT5eZVP1aIyOueCZpK3GBjEMFZTC8yPi6veFQoeooTYd CW6oVTU5TLW2NrvHz5RG6sbGxu8OJHeKCJJWeQWSSrtTc6mS6Hv+P9m4WyeJwALapOtC uwX8ewZwiY6KirIDsG2D7jZP062EYhLKAcF6de3w+nyfH8vikFOXivgvXyeltCS/mXX/ mgQA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=Hu6mSCxc; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from ml01.01.org (ml01.01.org. [198.145.21.10]) by mx.google.com with ESMTPS id r2-v6si23531430pgj.139.2018.11.14.18.35.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 14 Nov 2018 18:35:17 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) client-ip=198.145.21.10; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=Hu6mSCxc; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 22CFA2119172B; Wed, 14 Nov 2018 18:34:24 -0800 (PST) X-Original-To: edk2-devel@lists.01.org Delivered-To: edk2-devel@lists.01.org Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::541; helo=mail-pg1-x541.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-pg1-x541.google.com (mail-pg1-x541.google.com [IPv6:2607:f8b0:4864:20::541]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 39D512119172B for ; Wed, 14 Nov 2018 18:34:22 -0800 (PST) Received: by mail-pg1-x541.google.com with SMTP id n2so1102605pgm.3 for ; Wed, 14 Nov 2018 18:34:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=ukBnPpiTrU3oLQ/Uygw/OyFpD1H+8j0I7sVuA4D1vHg=; b=Hu6mSCxcoNEi/pKrY6+0AYbJbNe5nF9rli+vMUqugDhFX9tj/tPL6Wdk1OweVqFeIV 0bZwnW8r307DZEGOYOBAP7PfIip26KP2dmOEc9suPyJxF299trJhkV6tWLvGS7T54aKR oMobITX2fO7N0DyBGSZN6AXaRql+7ahMr2zAs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=ukBnPpiTrU3oLQ/Uygw/OyFpD1H+8j0I7sVuA4D1vHg=; b=F7oZm1Vckb3gqR0kfjJoCg0Z8F8vq0uLQZId1p8c8F62fQID0oRdt0/YobEXx8iZao 2p0b3YBV+H1cnWhwibwNs7ZgXxVlpgbmQv3CG939DecS4tkx0iZIhhL28FmoslU24OBi HeOx/CgPwavjxDh6UNMr2KdOrByVzygWbflzij3VI+nobA7CwXD+m2VAZgjnIKeZe7UF xXfr33o62/JA1mFqUR8mSVbziMSqMoRvtxnRYRopNAfUTtcWixmZ9APr3h5P1FWjy5ST x8gUxUY94wBw3q8KYAIgmBUrN50uMx4dRhpHrDwXDUmVBgFmXFLd1VgIGNFwlFf9zyD8 c/1A== X-Gm-Message-State: AGRZ1gIp2mk/wDhV77f4P2jDhSzpU4K4Eakk63Syxyp4dZ3WhqR8KVt7 4X+W932LyMuNyBppUa+XfUs6gp2cW34bfA== X-Received: by 2002:a63:4926:: with SMTP id w38mr3955996pga.353.1542249261731; Wed, 14 Nov 2018 18:34:21 -0800 (PST) Received: from mba13.psav.com ([64.114.255.97]) by smtp.gmail.com with ESMTPSA id v185-v6sm27323393pfv.48.2018.11.14.18.34.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 14 Nov 2018 18:34:20 -0800 (PST) From: Ard Biesheuvel To: edk2-devel@lists.01.org Date: Wed, 14 Nov 2018 18:33:50 -0800 Message-Id: <20181115023353.20159-18-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20181115023353.20159-1-ard.biesheuvel@linaro.org> References: <20181115023353.20159-1-ard.biesheuvel@linaro.org> Subject: [edk2] [PATCH edk2-staging 17/20] IntelUndiPkg/XGigUndiDxe: drop unused variables X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kamil.kacperski@intel.com, eric.jin@intel.com, pawel.orlowski@intel.com, michael.d.kinney@intel.com, harry.l.hsiung@intel.com MIME-Version: 1.0 Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" Drop some variables that are defined, assigned but never referenced. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- IntelUndiPkg/XGigUndiDxe/Decode.c | 3 --- IntelUndiPkg/XGigUndiDxe/HiiInternalLib.c | 4 ---- IntelUndiPkg/XGigUndiDxe/Xgbe.c | 2 -- 3 files changed, 9 deletions(-) -- 2.17.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel Reviewed-by: Ryszard Knop diff --git a/IntelUndiPkg/XGigUndiDxe/Decode.c b/IntelUndiPkg/XGigUndiDxe/Decode.c index 5f37ce254872..c8dc3f4eb659 100644 --- a/IntelUndiPkg/XGigUndiDxe/Decode.c +++ b/IntelUndiPkg/XGigUndiDxe/Decode.c @@ -1454,14 +1454,11 @@ UndiStatus ( ) { PXE_DB_GET_STATUS * DbPtr; - UINT16 i; UINT32 IntStatus; UINT16 NumEntries; struct ixgbe_legacy_rx_desc *RxPtr; bool LinkUp; - i = 0; - if (XgbeAdapter->DriverBusy) { //DEBUGPRINT (CRITICAL, ("ERROR: UndiStatus called when driver busy\n")); diff --git a/IntelUndiPkg/XGigUndiDxe/HiiInternalLib.c b/IntelUndiPkg/XGigUndiDxe/HiiInternalLib.c index 2aacb63ca158..df5238a3b55a 100644 --- a/IntelUndiPkg/XGigUndiDxe/HiiInternalLib.c +++ b/IntelUndiPkg/XGigUndiDxe/HiiInternalLib.c @@ -197,7 +197,6 @@ GetNextRequestElement ( ) { EFI_STRING StringPtr; - EFI_STRING TmpPtr; EFI_STATUS Status; UINTN Length; UINT8 * TmpBuffer; @@ -226,9 +225,6 @@ GetNextRequestElement ( return NULL; } - // Back up the header of one - TmpPtr = StringPtr; - StringPtr += StrLen (L"OFFSET="); // Get Offset diff --git a/IntelUndiPkg/XGigUndiDxe/Xgbe.c b/IntelUndiPkg/XGigUndiDxe/Xgbe.c index 6769f2dc72ab..b3dbbd2b1d08 100644 --- a/IntelUndiPkg/XGigUndiDxe/Xgbe.c +++ b/IntelUndiPkg/XGigUndiDxe/Xgbe.c @@ -1399,12 +1399,10 @@ XgbeInitialize ( XGBE_DRIVER_DATA *XgbeAdapter ) { - UINT32 * TempBar; PXE_STATCODE PxeStatcode; EFI_STATUS Status; PxeStatcode = PXE_STATCODE_SUCCESS; - TempBar = NULL; ZeroMem ( (VOID *)(UINTN)XgbeAdapter->RxRing.UnmappedAddress,