From patchwork Wed Jul 6 12:35:30 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ard Biesheuvel X-Patchwork-Id: 71452 Delivered-To: patch@linaro.org Received: by 10.140.28.4 with SMTP id 4csp841455qgy; Wed, 6 Jul 2016 05:35:32 -0700 (PDT) X-Received: by 10.98.99.132 with SMTP id x126mr41425040pfb.48.1467808532815; Wed, 06 Jul 2016 05:35:32 -0700 (PDT) Return-Path: Received: from ml01.01.org (ml01.01.org. [2001:19d0:306:5::1]) by mx.google.com with ESMTPS id vz6si4103478pab.106.2016.07.06.05.35.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 06 Jul 2016 05:35:32 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) client-ip=2001:19d0:306:5::1; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE dis=NONE) header.from=linaro.org Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 983711A1E7B; Wed, 6 Jul 2016 05:36:12 -0700 (PDT) X-Original-To: edk2-devel@lists.01.org Delivered-To: edk2-devel@lists.01.org Received: from mail-it0-x231.google.com (mail-it0-x231.google.com [IPv6:2607:f8b0:4001:c0b::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id E305B1A1E5F for ; Wed, 6 Jul 2016 05:36:11 -0700 (PDT) Received: by mail-it0-x231.google.com with SMTP id g4so64612684ith.1 for ; Wed, 06 Jul 2016 05:35:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=PMPBYR4bqXKqtAPcYnS2BzlGCTaQ9fAi8v9IWMhGAQs=; b=QVAU+goFnlvANmhF9LXWtaHkPnH09QX+tNQpaZJBJ07aDcAQKOaktdVQ4avELsEno+ z4by83A1kY0OmVFpUf7kwHzpffGg9JD7tWyKSJEsHe6n+joH96AKW0RU32kKZIJhFyZ6 oaux59Yu2yrlCWAIuuVYVZmNWjyMJgb2QV6JY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=PMPBYR4bqXKqtAPcYnS2BzlGCTaQ9fAi8v9IWMhGAQs=; b=H3Ih6Su/OTQUOM4qn9VksmBx6Av0ubOiF1Lpcw7V/u+I87gZtk1+qYQnsDqB/G/d0b KFSNz1o/s05PUePX1eiKueSTjGbleZTVzcikiFZeNWpBbLNFuTyjsbFUtoJ8Vktvsv+M 0FVNAdxtNPlcvNsc7gU56gCggYrb6WmpbSeMqqHCA7Pyl1tbd32pfGG+jlCQq8NRqW+q AViQT9glvOgEfGXHkIRoP5ymWnIEUBjAkdEbnME5yz2FYC7N2fs7DqOZrLgfqBf+4lAZ UUQtXsTVWR1vxf9JNEab+cN7qKQaliAzgfWK6gNFqqeAyYUd94RGhPwNEg7A2up5z/5f gVLw== X-Gm-Message-State: ALyK8tLR3QfkOnqMrBlLGDsaNY3X/ObGOT4TyLd3CiRFzXlcYQmp1aMsN00hKmQ22/tKEeylK2r04FP1Y2V1pkw5 X-Received: by 10.36.138.65 with SMTP id v62mr18066890itd.51.1467808530528; Wed, 06 Jul 2016 05:35:30 -0700 (PDT) MIME-Version: 1.0 Received: by 10.36.214.6 with HTTP; Wed, 6 Jul 2016 05:35:30 -0700 (PDT) In-Reply-To: <20160704143233.GN22984@bivouac.eciton.net> References: <1467387836-3419-1-git-send-email-ard.biesheuvel@linaro.org> <20160704143233.GN22984@bivouac.eciton.net> From: Ard Biesheuvel Date: Wed, 6 Jul 2016 14:35:30 +0200 Message-ID: To: Leif Lindholm Subject: Re: [edk2] [PATCH v2 0/4] ArmPkg: refactor MMU handling routines into separate ArmMmuLib X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: edk2-devel-01 , Laszlo Ersek , "Zeng, Star" Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" On 4 July 2016 at 16:32, Leif Lindholm wrote: > On Fri, Jul 01, 2016 at 05:43:52PM +0200, Ard Biesheuvel wrote: >> The MMU routines are only used by a small subset of the users of ArmLib. >> In order to prevent all those users to have to run the library constructor >> to clean some MMU handling routines to the PoC, split off all MMU handling >> into a separate ArmMmuLib. >> >> NOTE: this change will affect out-of-tree platforms, which will need to add the >> ArmMmuLib library class resolution to their .DSC descriptions. >> >> Changes since v1: >> - updated ArmVirtQemuKernel as well as ArmVirtQemu and ArmVirtXen to switch to >> the new ArmMmuLib (#3) >> - added tags from Laszlo and Star (#3) >> - dropped ArmLib reference from DxeIp l(#3) [*] >> - clarified comment (#4) > > For the series: > Reviewed-by: Leif Lindholm > Thanks. For the record, I need to fold the following hunks into patch #3 to ensure things keep working (but this only affects out of tree ARM platforms since ArmVirtPkg has its own implementation of MemoryInitPeiLib) """ """ Since it is a trivial fixup for an expected issue following the split of ArmLib into ArmLib/ArmMmuLib, I am going to assume that everyone is ok with that without another round of review. Thanks, Ard. _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel diff --git a/ArmPlatformPkg/MemoryInitPei/MemoryInitPeiLib.c b/ArmPlatformPkg/MemoryInitPei/MemoryInitPeiLib.c index f54ec3672a2d..75e6631d7f30 100644 --- a/ArmPlatformPkg/MemoryInitPei/MemoryInitPeiLib.c +++ b/ArmPlatformPkg/MemoryInitPei/MemoryInitPeiLib.c @@ -14,6 +14,7 @@ #include +#include #include #include #include diff --git a/ArmPlatformPkg/MemoryInitPei/MemoryInitPeiLib.inf b/ArmPlatformPkg/MemoryInitPei/MemoryInitPeiLib.inf index 6d22b7c03441..cbdca6f532a9 100644 --- a/ArmPlatformPkg/MemoryInitPei/MemoryInitPeiLib.inf +++ b/ArmPlatformPkg/MemoryInitPei/MemoryInitPeiLib.inf @@ -33,7 +33,7 @@ [Packages] [LibraryClasses] DebugLib HobLib - ArmLib + ArmMmuLib ArmPlatformLib [Guids]