From patchwork Mon Mar 1 01:43:28 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shawn Guo X-Patchwork-Id: 388618 Delivered-To: patch@linaro.org Received: by 2002:a02:290e:0:0:0:0:0 with SMTP id p14csp2980391jap; Sun, 28 Feb 2021 17:45:42 -0800 (PST) X-Google-Smtp-Source: ABdhPJxule3MYmSFnJf7IZnPjiKYdVAVzpYF9Q1dD+dNuwcy9RQ+JsNt3IpYcGpZ1VlvR9bGJzj0 X-Received: by 2002:a05:6402:304b:: with SMTP id bu11mr13653370edb.157.1614563142366; Sun, 28 Feb 2021 17:45:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614563142; cv=none; d=google.com; s=arc-20160816; b=znkiG5fG3jDh25QZLfILfhObXehlxEmOonfUu4O/Ja8VKCn/VqE2x9MZmPNkaH/URD cLJIiDoK2RY2QxhMdrfE1clItgBGFr9z1fhsHQx4B3p8elGep5cn1xr/iw2nhQwNZx0V nVB9uOl2Gu6m4YlcvMIaBCOjOL4VEljy9J1nA1LCKWqRVtFS7aNLhScoMkiFvNsWk3f0 fXZozddRPIEY3n7CuFjKMpxZs/pwFyTHIvoA5hKpIacoxzoUYu1wYyqE82/0VSV8wYSQ DMrDj0JIUWEvY/+91GRG93ZPFTgqzFjbkTOYrGUD94zxYZt1ruN8dr9D3IxJ5v5HZTtZ P9Zg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from:dkim-signature; bh=re5cneH5LwtASkkb/0TTV6Xt6BX2mOBhYFKz8Fn5mZk=; b=QWTclYgkk1ufY2BM/ttU0iA/lw8fBMCZ4kCaR1Ww7XI4OokJdWnwW7jbyTSmBiH6Ee G7KC6HHUMuoYHODhdtsmy44YgE1PlwpFWGiPM/NXe6IcyfsEtGjI0Ym6T52/3EuFwNWc /oHNpNS1AFomkGvMGEkystjczOc1bdE9Z2U/1kqt7HzwpctxA5SPcBKdaC1lQJq2KBi5 6SARdIqGIkSnc0kKQ4w99lB641hO4VyIEtT0ym7CougIqQ/qPO4JgTHHFiqZETzzt42O yfcuKSSGH4CvUV7oR2z3SgGvdfam4l+Wa9zdtJYphxHJVHnMCHCZhQWD0EMMmZJSPydL 6Pog== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=m3rwZ2wc; spf=pass (google.com: domain of linux-gpio-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-gpio-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k6si10191876edo.113.2021.02.28.17.45.42; Sun, 28 Feb 2021 17:45:42 -0800 (PST) Received-SPF: pass (google.com: domain of linux-gpio-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=m3rwZ2wc; spf=pass (google.com: domain of linux-gpio-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-gpio-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231367AbhCABo0 (ORCPT + 3 others); Sun, 28 Feb 2021 20:44:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44984 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230084AbhCABoY (ORCPT ); Sun, 28 Feb 2021 20:44:24 -0500 Received: from mail-pl1-x631.google.com (mail-pl1-x631.google.com [IPv6:2607:f8b0:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2B7FEC061788 for ; Sun, 28 Feb 2021 17:43:44 -0800 (PST) Received: by mail-pl1-x631.google.com with SMTP id u18so2706647plc.12 for ; Sun, 28 Feb 2021 17:43:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=re5cneH5LwtASkkb/0TTV6Xt6BX2mOBhYFKz8Fn5mZk=; b=m3rwZ2wcH4mVG8aT8rSFmFWQcRo8Ry1I7h3d9X+MFtd+MPew3Tiuflom0cGALa5StK SDIX4kwPNrj/0YYKxJxXQBbOiukdUUgEd7AlBGnoqAVtUJFmN8ThUdQdbCEXeKXARgDP jnU+w6Xvc5H2AkA3pc985TwnffmiTtbq+GWpTr4ZucndpoFoEYL+GeACvTcab9xs4Oju N0x6pzg3IF7JONuXVI1ocuWtWIjr83cIYnaDcrPpDDJZ8JklokGqfYMqH5h11sn+OYA2 Ne17XjB8ScLWyxLoF+eO9Ca/ge7cAqYbFkvWddKTAza2kkxTGB6qBUNQng5OzUu4qu5A FJKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=re5cneH5LwtASkkb/0TTV6Xt6BX2mOBhYFKz8Fn5mZk=; b=J3RZDZfNLgOx3BOqHTFKGl3eqwIszU/iFA1uXrpecCspfMiSkkpbt2o1qVNRi3Ji6I MfNT3+AO1Wf9+J3tdXfcoP/e31J3JGUJ3VBRRD1Lb/brGs8BL8DpyXOciFMjs98xFEfW W6rocRqIX7jgRROe+1vcWoy12kZpntWfx2POjplMy5mI/+3VsQgApSHE9IJ2tElxOP8U NXD9Y+O1gQ04uBGGjo8gQOPLa5TQkcs6VSGVV/WMSfh7v1Anyy2CucEA8v77WxsxDEqH VRofhWTW+uiE1Yld0y9FM3lxx2zBWk4VfkyZYFkTlBKhRyVDSRwGJuuYJe5UO3FiHxwc G5pA== X-Gm-Message-State: AOAM533FedqfwQGgvsCeBZZ78QxDjT9D4rV4W98Z8vA1zW3pSCpvvKPt eK4XBAYexvJEiVkw6xeA74hrMg== X-Received: by 2002:a17:902:6b06:b029:e3:5edf:c2a1 with SMTP id o6-20020a1709026b06b02900e35edfc2a1mr13493323plk.51.1614563023773; Sun, 28 Feb 2021 17:43:43 -0800 (PST) Received: from localhost.localdomain (80.251.214.228.16clouds.com. [80.251.214.228]) by smtp.gmail.com with ESMTPSA id q95sm5641080pjq.20.2021.02.28.17.43.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Feb 2021 17:43:43 -0800 (PST) From: Shawn Guo To: Linus Walleij Cc: Bjorn Andersson , linux-gpio@vger.kernel.org, linux-arm-msm@vger.kernel.org, Shawn Guo Subject: [PATCH 1/2] pinctrl: qcom: handle tiles for ACPI boot Date: Mon, 1 Mar 2021 09:43:28 +0800 Message-Id: <20210301014329.30104-2-shawn.guo@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210301014329.30104-1-shawn.guo@linaro.org> References: <20210301014329.30104-1-shawn.guo@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org It's not always the case that DT and ACPI describe hardware resource in the same schema, even for a single platform. For example, on SC8180X, DT uses the tiles schema while ACPI describe memory resource as a single region. It patches msm_pinctrl_probe() function to map tiles regions only for DT. While for ACPI, it maps the single memory resource and calculate tile bases with offsets passed from SoC data. Signed-off-by: Shawn Guo --- drivers/pinctrl/qcom/pinctrl-msm.c | 18 ++++++++++++++---- drivers/pinctrl/qcom/pinctrl-msm.h | 1 + 2 files changed, 15 insertions(+), 4 deletions(-) -- 2.17.1 diff --git a/drivers/pinctrl/qcom/pinctrl-msm.c b/drivers/pinctrl/qcom/pinctrl-msm.c index 40256663264f..2526f299bdce 100644 --- a/drivers/pinctrl/qcom/pinctrl-msm.c +++ b/drivers/pinctrl/qcom/pinctrl-msm.c @@ -4,6 +4,7 @@ * Copyright (c) 2013, The Linux Foundation. All rights reserved. */ +#include #include #include #include @@ -1399,6 +1400,7 @@ int msm_pinctrl_probe(struct platform_device *pdev, { struct msm_pinctrl *pctrl; struct resource *res; + void __iomem *base; int ret; int i; @@ -1415,7 +1417,7 @@ int msm_pinctrl_probe(struct platform_device *pdev, raw_spin_lock_init(&pctrl->lock); - if (soc_data->tiles) { + if (soc_data->tiles && !has_acpi_companion(&pdev->dev)) { for (i = 0; i < soc_data->ntiles; i++) { res = platform_get_resource_byname(pdev, IORESOURCE_MEM, soc_data->tiles[i]); @@ -1425,9 +1427,17 @@ int msm_pinctrl_probe(struct platform_device *pdev, } } else { res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - pctrl->regs[0] = devm_ioremap_resource(&pdev->dev, res); - if (IS_ERR(pctrl->regs[0])) - return PTR_ERR(pctrl->regs[0]); + base = devm_ioremap_resource(&pdev->dev, res); + if (IS_ERR(base)) + return PTR_ERR(base); + + if (soc_data->tiles) { + for (i = 0; i < soc_data->ntiles; i++) + pctrl->regs[i] = base + + soc_data->tile_offsets[i]; + } else { + pctrl->regs[0] = base; + } pctrl->phys_base[0] = res->start; } diff --git a/drivers/pinctrl/qcom/pinctrl-msm.h b/drivers/pinctrl/qcom/pinctrl-msm.h index e31a5167c91e..91333942d53c 100644 --- a/drivers/pinctrl/qcom/pinctrl-msm.h +++ b/drivers/pinctrl/qcom/pinctrl-msm.h @@ -131,6 +131,7 @@ struct msm_pinctrl_soc_data { bool pull_no_keeper; const char *const *tiles; unsigned int ntiles; + const u32 *tile_offsets; const int *reserved_gpios; const struct msm_gpio_wakeirq_map *wakeirq_map; unsigned int nwakeirq_map; From patchwork Mon Mar 1 01:43:29 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shawn Guo X-Patchwork-Id: 388619 Delivered-To: patch@linaro.org Received: by 2002:a02:290e:0:0:0:0:0 with SMTP id p14csp2980408jap; Sun, 28 Feb 2021 17:45:43 -0800 (PST) X-Google-Smtp-Source: ABdhPJwm4ysshZdhaAgWAe1+L9QMWafbDM32XPDAMKWLiEzMvnWkBtB5OUhfNbFcSIgqm2o+efPk X-Received: by 2002:a17:906:e116:: with SMTP id gj22mr13456026ejb.398.1614563143249; Sun, 28 Feb 2021 17:45:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614563143; cv=none; d=google.com; s=arc-20160816; b=aSZ1oScEsQtYyCUDcVktACGB3K1PSFrH8HEONnfmNNwhGU7H8o1Whgo5nzB8C1uo7r 32SsyMRVF7hDx14s3/LXijmSWysrJVG4O5aTug2k0ox2ZOcDdO2CHEalNkpw7D7xpKdx 0SuWo4UEnsDmS8DlF0csHOD2JjEfibSdTVhhx7bODlu1o6BoFDUdU4NKTsSzAULHEjkj Ry+Fbwij9iRGH5Iw8rewzrnHpG6GWAoN40vZ2WcIECfcDdHzkuXxxQU6Lt3M0Jdi2Lu6 Sesy198q90/2S/V6sxNatklHPUHEcW2jlWCd/lrC40mtslC9PUJ94M+BiuBaEy4BVefU nT3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from:dkim-signature; bh=z0mBMHxaT4uoBSQcFVbT2L0+EZv1w1tZ9nt7sG1lKAE=; b=lYzeoUXbUpp4V+UZqwAayhrt3WG2lUHmAzpvn63yXuwC+LV4juvGGtcj5T05Qq424i NO38hszHhWf6fGbZVLnoyGOfEmZxES6vtaKWpUDwPjCok2kNWa5RT+CNlH3ZUjM1sw2V bHcEIMnv4xeeJlal/wF8h19TuKVWwBikEtBs0H0Pq2xpORx/L3yQG7yaa4fw7zD57Y6X 7xhOoGoFXbX96qQfoRHZb6Mr/CBOLOFKLaVOc19KCFsVw/2cbB7ahU9hNJ+4ePaecKiN Br0lMNxA/ZnFUiLeAupc4QxgJv8h/zlAL+IHVUyzWmrbdXyyycjK3Lnm04+D2G/48Qw6 numw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=iTqMK3mx; spf=pass (google.com: domain of linux-gpio-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-gpio-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k6si10191876edo.113.2021.02.28.17.45.43; Sun, 28 Feb 2021 17:45:43 -0800 (PST) Received-SPF: pass (google.com: domain of linux-gpio-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=iTqMK3mx; spf=pass (google.com: domain of linux-gpio-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-gpio-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231394AbhCABoo (ORCPT + 3 others); Sun, 28 Feb 2021 20:44:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45058 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230084AbhCABoo (ORCPT ); Sun, 28 Feb 2021 20:44:44 -0500 Received: from mail-pf1-x42a.google.com (mail-pf1-x42a.google.com [IPv6:2607:f8b0:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 37B80C06178B for ; Sun, 28 Feb 2021 17:43:46 -0800 (PST) Received: by mail-pf1-x42a.google.com with SMTP id l7so6206486pfd.3 for ; Sun, 28 Feb 2021 17:43:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=z0mBMHxaT4uoBSQcFVbT2L0+EZv1w1tZ9nt7sG1lKAE=; b=iTqMK3mxYaalRnrW436u79qOOY0+3tfhvfkJlOeiDEVZT8Dm0bkiObfGY7PwGqaxL1 pRAwN6jl3Zje67R6tzz+AIs0jSCtXi6WfdcK18XfL/xbuFp7rKwdAW1DRfquidKITsay SLQfr/oJoLkMKiaJKrPO1g7h7dMpNuH5h9m4pfkKlKLKV3FFQqejzehbb5Up6PHInsVj i83SKFOTx1z1RBXzrS0Wa3ZsUIIo9YXRUrOnC8Wbv9ovuhgAO2t3dvV0SsyyRp5LMbdR TvaR77CpInVN8R07ACq131vOKscnDRFORn+1YX+5qs565g5Bq9SSUU1Yrkq3+2423lM4 7oyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=z0mBMHxaT4uoBSQcFVbT2L0+EZv1w1tZ9nt7sG1lKAE=; b=JNQn7+OAhoB+v4Bu+MwdCfNRQ45cFJOhReTea5l+AB1D7YNMq3kQRVhiHaWjqLRn01 b9hvi2fCvC+ytnTBoI9M0jljSi7iuRF3DV47CaAfktZUanwZCeZnRq5t2xkrEHcbGeRn +0uZR0e5doJr0TFMm0Y3JGWCyEMeyS+WQ8PvSlCOMoyrwn6LnD7lqCq36oFCXD5plxlO Gmii6AXeC6PM8Fwu38EhpTq8gaY5tzWbDbGP+CHgVXTcBoBZ2E39J0MJbctku/8d0Zkv wwIz78djyMYF5CTcJsQQ8DwYjVDsqPwQgzCFFKDsmnf8p58+0tHyDm7AlU9kYL+zTXGs ZFLA== X-Gm-Message-State: AOAM531HWknpYnRw+KsXL9d6x37Xb4N/vopiekvcEJdlK/DPaSHvg4L7 Hr2Ee0XL7IwI4leVvhyjuUjgXg== X-Received: by 2002:a63:1c19:: with SMTP id c25mr11586114pgc.374.1614563025828; Sun, 28 Feb 2021 17:43:45 -0800 (PST) Received: from localhost.localdomain (80.251.214.228.16clouds.com. [80.251.214.228]) by smtp.gmail.com with ESMTPSA id q95sm5641080pjq.20.2021.02.28.17.43.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Feb 2021 17:43:45 -0800 (PST) From: Shawn Guo To: Linus Walleij Cc: Bjorn Andersson , linux-gpio@vger.kernel.org, linux-arm-msm@vger.kernel.org, Shawn Guo Subject: [PATCH 2/2] pinctrl: qcom: sc8180x: add ACPI probe support Date: Mon, 1 Mar 2021 09:43:29 +0800 Message-Id: <20210301014329.30104-3-shawn.guo@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210301014329.30104-1-shawn.guo@linaro.org> References: <20210301014329.30104-1-shawn.guo@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org It adds ACPI probe support with tile offsets passed over to msm core driver via sc8180x_tile_offsets, as TLMM is described a single memory region in ACPI DSDT. Signed-off-by: Shawn Guo --- drivers/pinctrl/qcom/Kconfig | 2 +- drivers/pinctrl/qcom/pinctrl-sc8180x.c | 48 +++++++++++++++++++++++++- 2 files changed, 48 insertions(+), 2 deletions(-) -- 2.17.1 diff --git a/drivers/pinctrl/qcom/Kconfig b/drivers/pinctrl/qcom/Kconfig index 6853a896c476..9f0218c4f9b3 100644 --- a/drivers/pinctrl/qcom/Kconfig +++ b/drivers/pinctrl/qcom/Kconfig @@ -222,7 +222,7 @@ config PINCTRL_SC7280 config PINCTRL_SC8180X tristate "Qualcomm Technologies Inc SC8180x pin controller driver" - depends on GPIOLIB && OF + depends on GPIOLIB && (OF || ACPI) select PINCTRL_MSM help This is the pinctrl, pinmux, pinconf and gpiolib driver for the diff --git a/drivers/pinctrl/qcom/pinctrl-sc8180x.c b/drivers/pinctrl/qcom/pinctrl-sc8180x.c index b765bf667574..38117ceb4d8f 100644 --- a/drivers/pinctrl/qcom/pinctrl-sc8180x.c +++ b/drivers/pinctrl/qcom/pinctrl-sc8180x.c @@ -4,6 +4,7 @@ * Copyright (c) 2020-2021, Linaro Ltd. */ +#include #include #include #include @@ -17,6 +18,12 @@ static const char * const sc8180x_tiles[] = { "west" }; +static const u32 sc8180x_tile_offsets[] = { + 0x00d00000, + 0x00500000, + 0x00100000 +}; + enum { SOUTH, EAST, @@ -1557,6 +1564,13 @@ static const struct msm_pingroup sc8180x_groups[] = { [193] = SDC_QDSD_PINGROUP(sdc2_data, 0x4b2000, 9, 0), }; +static const int sc8180x_acpi_reserved_gpios[] = { + 0, 1, 2, 3, + 47, 48, 49, 50, + 126, 127, 128, 129, + -1 +}; + static const struct msm_gpio_wakeirq_map sc8180x_pdc_map[] = { { 3, 31 }, { 5, 32 }, { 8, 33 }, { 9, 34 }, { 10, 100 }, { 12, 104 }, { 24, 37 }, { 26, 38 }, { 27, 41 }, { 28, 42 }, { 30, 39 }, { 36, 43 }, @@ -1588,11 +1602,42 @@ static struct msm_pinctrl_soc_data sc8180x_pinctrl = { .nwakeirq_map = ARRAY_SIZE(sc8180x_pdc_map), }; +static const struct msm_pinctrl_soc_data sc8180x_acpi_pinctrl = { + .tiles = sc8180x_tiles, + .ntiles = ARRAY_SIZE(sc8180x_tiles), + .tile_offsets = sc8180x_tile_offsets, + .pins = sc8180x_pins, + .npins = ARRAY_SIZE(sc8180x_pins), + .groups = sc8180x_groups, + .ngroups = ARRAY_SIZE(sc8180x_groups), + .reserved_gpios = sc8180x_acpi_reserved_gpios, + .ngpios = 191, +}; + static int sc8180x_pinctrl_probe(struct platform_device *pdev) { - return msm_pinctrl_probe(pdev, &sc8180x_pinctrl); + int ret; + + if (pdev->dev.of_node) { + ret = msm_pinctrl_probe(pdev, &sc8180x_pinctrl); + } else if (has_acpi_companion(&pdev->dev)) { + ret = msm_pinctrl_probe(pdev, &sc8180x_acpi_pinctrl); + } else { + dev_err(&pdev->dev, "DT and ACPI disabled\n"); + ret = -EINVAL; + } + + return ret; } +#ifdef CONFIG_ACPI +static const struct acpi_device_id sc8180x_pinctrl_acpi_match[] = { + { "QCOM040D"}, + { }, +}; +MODULE_DEVICE_TABLE(acpi, sc8180x_pinctrl_acpi_match); +#endif + static const struct of_device_id sc8180x_pinctrl_of_match[] = { { .compatible = "qcom,sc8180x-tlmm", }, { }, @@ -1603,6 +1648,7 @@ static struct platform_driver sc8180x_pinctrl_driver = { .driver = { .name = "sc8180x-pinctrl", .of_match_table = sc8180x_pinctrl_of_match, + .acpi_match_table = ACPI_PTR(sc8180x_pinctrl_acpi_match), }, .probe = sc8180x_pinctrl_probe, .remove = msm_pinctrl_remove,