From patchwork Sun Mar 7 09:45:16 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Lezcano X-Patchwork-Id: 395139 Delivered-To: patch@linaro.org Received: by 2002:a02:8562:0:0:0:0:0 with SMTP id g89csp857600jai; Sun, 7 Mar 2021 01:45:43 -0800 (PST) X-Google-Smtp-Source: ABdhPJyInXudPCTCXYfrUNvIONr5h/Ser0Fz221MnOajl9Wuuw5Cu/yUAfyRUe7KfRdtOopHrIAX X-Received: by 2002:a63:4b21:: with SMTP id y33mr15800588pga.73.1615110343307; Sun, 07 Mar 2021 01:45:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1615110343; cv=none; d=google.com; s=arc-20160816; b=wrk4we24cMj19FPmgIlFvjp7TMZUaMw9MV4s30zOlB8pMCV45E4hOfYgFTAZLZT2el tLPs2hcOM74Lz3jtfTYl/GDf65z1Qg+NUtF9FdbfUihhhMER4rAlSozy7slopHqkIXGf hvzejfyVBCPk8i+3pQOhGBnFhu58uugIxcTeMhpD1tQjTK4fXAz47IonFJ7VUJ/Qqv/Z GBRLmLSxvZtgwsh/0TLac2cch08g1svS7oFrdNU/9kf3oxquqt7it2HtNNxghWSRP8h5 XX4vR5FNgzb7h2Bih9uHKOgnGU9GjJTtJ1FgC0KJPp4qbpGrdkoU4dB/dOb42j80LMsh LmZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:cc :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:references:in-reply-to:message-id:date:subject :to:from:dkim-signature:delivered-to; bh=7LEJW/C5E7y4xVwd66YXAzGRxCjBZYD4mQkAdnSSYdQ=; b=oF1H4gp2qIAZITQibMqSvqnJnFTs9IFnU3EfO/VaxcD9L/VXKQxAh86Z7CjUOGfZvp R1EKzVKRl75jsahwT2DMrQjr+UIyohaNbpLhsAaZ/5Kbxu7rjQbh11tv/UeA4QzqYrxT oL634mNLPstNUhz+To76HBmr8XsqP8wy99VEGoZ9nmZG0rigO5L+2aPOLMxMqzdUQrJf 1MFgHbrm6iOV4zC0HSdsqBTfYUfKsLb25eh96ACT6qX/xHho01zclZ1W/tSboYyM8nUj sZzZ8ncL6fj//Kws+fXm4qrsgDYv/96mUNTu0FaxLwL2WS8kHGow0soT9LgVzb2+AeTS HHEQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=cEZv1N9M; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id e5si8882549pls.294.2021.03.07.01.45.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Mar 2021 01:45:43 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=cEZv1N9M; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4FE7A6E58E; Sun, 7 Mar 2021 09:45:39 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [IPv6:2a00:1450:4864:20::42e]) by gabe.freedesktop.org (Postfix) with ESMTPS id BBE146E588 for ; Sun, 7 Mar 2021 09:45:37 +0000 (UTC) Received: by mail-wr1-x42e.google.com with SMTP id d15so8120323wrv.5 for ; Sun, 07 Mar 2021 01:45:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=RsjSwA8oB0o8PW0ry99uhxTdXQdH9BOaf5mimdTgeO0=; b=cEZv1N9MT1tvcp5XXBU/gC/3IF30iDxLCSKZoGWnZBDvfMPIl/dDWocdAT518rBLib z9GfFnD7Vw4DdcLo6XWQ69SwwDSUG75kHjUnPLaR9OU6WdnNycO7Y8roscN1sMew0W9T n8yaXirXJTt640L5dqM2zyhVlDKbypVDKJQaCWeDlzBGnB0Kgf9RSTU5UjKuiLHebEyY ks0eFoAg7C0H4/gHHMtVmELgLhiqLCw6imgeP39zDlV+mzjWx5brsNRbSimT+hhXNZbn eXtGNYNgtSSGjIQJgD4xKtTyeRERc0I4pQTAdASh53z2pnWyPnR0IeaLzGxLmbuU9/CF jyqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=RsjSwA8oB0o8PW0ry99uhxTdXQdH9BOaf5mimdTgeO0=; b=rgTpi0ku7SgDslTrlgTBWlE+a1eV2zwzaP60OZvMN2h6UWG2WK2hqXRXvmjr0NNNvs RtGJcWVYah3SJhExr/m2flTgDRiAPBTNsuTYtgIOf2TFo5vX4Fa8x+YBrjYby7JSZkgQ vD9o8mSB1+PZ3hZIy5PUk8BPs8cUT4ZGf9vZGl58b2DUNunmSglwl5tfbhg+QVdSiM9/ ZEJQF7I5+KB4gFMxt9jaftskLMB1WHaleQL0vH3CCJ/yKJdnnlPlB3+Q4/JyMGEpyMT8 Ck5Ano1MNxu6schHpPf3VDLVPYr2Rm+hcIDEGjmIqV5mLwVofJR3CdqacIebg4+436Br X9VQ== X-Gm-Message-State: AOAM533n1tODaF/m/G53hgyMwnp7rUjVsIctjxvHMdrwtqgdV1VvJLPu vJ5H53SELPbeYCNdYUsfuwfFpg== X-Received: by 2002:adf:a59a:: with SMTP id g26mr17670383wrc.271.1615110336310; Sun, 07 Mar 2021 01:45:36 -0800 (PST) Received: from localhost.localdomain (lns-bzn-59-82-252-141-80.adsl.proxad.net. [82.252.141.80]) by smtp.gmail.com with ESMTPSA id z7sm12790737wrt.70.2021.03.07.01.45.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Mar 2021 01:45:35 -0800 (PST) From: Daniel Lezcano To: cwchoi00@gmail.com Subject: [PATCH v3 2/4] devfreq/drivers/msm: Use devfreq cooling device registration Date: Sun, 7 Mar 2021 10:45:16 +0100 Message-Id: <20210307094519.9032-2-daniel.lezcano@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210307094519.9032-1-daniel.lezcano@linaro.org> References: <20210307094519.9032-1-daniel.lezcano@linaro.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:DRM DRIVER FOR MSM ADRENO GPU" , linux-pm@vger.kernel.org, David Airlie , "open list:DRM DRIVER FOR MSM ADRENO GPU" , linux-kernel@vger.kernel.org, "open list:DRM DRIVER FOR MSM ADRENO GPU" , steven.price@arm.com, Sean Paul , lukasz.luba@arm.com MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The devfreq core code is able to register the devfreq device as a cooling device if the 'is_cooling_device' flag is set in the profile. Use this flag and remove the cooling device registering code. Tested on dragonboard 845c Signed-off-by: Daniel Lezcano --- drivers/gpu/drm/msm/msm_gpu.c | 12 +----------- drivers/gpu/drm/msm/msm_gpu.h | 2 -- 2 files changed, 1 insertion(+), 13 deletions(-) -- 2.17.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel diff --git a/drivers/gpu/drm/msm/msm_gpu.c b/drivers/gpu/drm/msm/msm_gpu.c index ab7c167b0623..eade94271a60 100644 --- a/drivers/gpu/drm/msm/msm_gpu.c +++ b/drivers/gpu/drm/msm/msm_gpu.c @@ -14,7 +14,6 @@ #include #include #include -#include #include #include @@ -82,6 +81,7 @@ static struct devfreq_dev_profile msm_devfreq_profile = { .target = msm_devfreq_target, .get_dev_status = msm_devfreq_get_dev_status, .get_cur_freq = msm_devfreq_get_cur_freq, + .is_cooling_device = true, }; static void msm_devfreq_init(struct msm_gpu *gpu) @@ -112,14 +112,6 @@ static void msm_devfreq_init(struct msm_gpu *gpu) } devfreq_suspend_device(gpu->devfreq.devfreq); - - gpu->cooling = of_devfreq_cooling_register(gpu->pdev->dev.of_node, - gpu->devfreq.devfreq); - if (IS_ERR(gpu->cooling)) { - DRM_DEV_ERROR(&gpu->pdev->dev, - "Couldn't register GPU cooling device\n"); - gpu->cooling = NULL; - } } static int enable_pwrrail(struct msm_gpu *gpu) @@ -1056,6 +1048,4 @@ void msm_gpu_cleanup(struct msm_gpu *gpu) if (gpu->worker) { kthread_destroy_worker(gpu->worker); } - - devfreq_cooling_unregister(gpu->cooling); } diff --git a/drivers/gpu/drm/msm/msm_gpu.h b/drivers/gpu/drm/msm/msm_gpu.h index d7cd02cd2109..93419368bac8 100644 --- a/drivers/gpu/drm/msm/msm_gpu.h +++ b/drivers/gpu/drm/msm/msm_gpu.h @@ -155,8 +155,6 @@ struct msm_gpu { struct msm_gpu_state *crashstate; /* True if the hardware supports expanded apriv (a650 and newer) */ bool hw_apriv; - - struct thermal_cooling_device *cooling; }; static inline struct msm_gpu *dev_to_gpu(struct device *dev) From patchwork Sun Mar 7 09:45:17 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Lezcano X-Patchwork-Id: 395140 Delivered-To: patch@linaro.org Received: by 2002:a02:8562:0:0:0:0:0 with SMTP id g89csp857627jai; Sun, 7 Mar 2021 01:45:47 -0800 (PST) X-Google-Smtp-Source: ABdhPJyySHUG+OWPUkahw+XSlvVD23Tbx4YCXfysyF+78AO5tYs2wY6oya9AOAyz0hqCNTgn69l+ X-Received: by 2002:a65:5a0a:: with SMTP id y10mr16118902pgs.285.1615110346851; Sun, 07 Mar 2021 01:45:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1615110346; cv=none; d=google.com; s=arc-20160816; b=OlxsWNsa/rVm6Bc0TEqPh/0YkNCx2LlpKYn99pNXDklKNjO4UeY4V9tmQVa708WeTy raA2AmI361RNLmEXlRvq9UwIRQFW/+8aThX62gEevHt5gfVOPCDQuVnH4+W1WbOQoUkh XKooYfz4Cmt7R4ErzNxRTGIi0dPSZq3XFSAVjim1wYqmr45zgBTalqMWhRr2eoAI6//A s0SIsxNCGuPc2A/pORtxwvu18KZhJKKqCpN06OZw7j8Lf823ITaMmBM3mLEGdouDt4// A5VfIhWUBCvVwXNLjy7mD9eMJxIB+o7x92kjb5kWgnqNpk0hQN689g+MlljrFPAqxLpu OhNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:cc :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:references:in-reply-to:message-id:date:subject :to:from:dkim-signature:delivered-to; bh=N+kS6nGilrRZWlxzLwj9S5TsHpH3UhA/Fid0a8fqpWM=; b=qeShhJnzG44VmDfmk9b/eoQH9bQhcc7zNL5hq0IIXKMQikKZTqRiolmC0mJKQJwIEZ pjxHzAY+oq/m64hZB5NPU2CKtZdo30rSoJVdWFIWkl09mENUBDxacQ2pvk5zaPpmvN1T 8qe+eAPwjKO1HtUHWOuFQDqscn0C6kpHdTTjSqvvPhPQIeUqW6VdmWOtfAeQ1BGdQTs0 4aLcc1RPXON7uQaRdThv7K+BwoOC1P7vCIsk7TVOTmG1c/EZAeYH1oKg+OMNPr2G1pwm P50FuKN11d7yP/M9mfbL9ZxzemA2JmHFPGuivoK/9nG/2ArCttp3yt8WuPWxny38JZHE e5Mw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=IMCG9brr; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id ba8si8248374plb.225.2021.03.07.01.45.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Mar 2021 01:45:46 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=IMCG9brr; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 550D86E591; Sun, 7 Mar 2021 09:45:40 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by gabe.freedesktop.org (Postfix) with ESMTPS id 67A516E591 for ; Sun, 7 Mar 2021 09:45:39 +0000 (UTC) Received: by mail-wr1-x42d.google.com with SMTP id h98so8075457wrh.11 for ; Sun, 07 Mar 2021 01:45:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=ahYwzRQmSJrX4v8ks57+n/tweaGVoFJT9QTc8vhlUHg=; b=IMCG9brrQt9OXxOqUu9VRJQSaHO249Bi5pskoqucaUgqlSLXajvgNyj8fB5buczLrp NVzKgCJwG8EjWaUo5rmBNG9GjT98RRRikYuauNSDXyxBFgM3QAxKN1/BAmCP1yQcKV5y HJQbIvC+0sdx6bnuGncA1cURxt62iFmsLIXkdh4WgWW/1u/HpYi8XiZ0Rvjw8fQJMOSi OUVmQjNb6FqCNZTMJguKbtukfUWtL7y5ebBdfxq1gZ76G+4qJhEiWGAezl5cY1Us0jPb yw/KbYm6ulF7YkGN3s6IFni73fZttTj1qdwcAA0x3zqgCf+2wpvcV6M5ToWnvpEjBFn4 sUyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=ahYwzRQmSJrX4v8ks57+n/tweaGVoFJT9QTc8vhlUHg=; b=tdgaWB0YjGyfbtFSgHv0Z4cluvMD/h4vQ9tGIPKmjPXvNmybxYMtva+/QHfTMTJKV0 N2aIX6mxKC6elCi87TH5Kj+Dqc36mB6loZmmy5JEj53b0Kry2kHsvjofd4FoTjAQy9M1 1ZFYqIzXcrK6PQA/0LPFD9poN03ktFSDXYoqSbzErvA7FPtHr4SLr0OuiMbBVUuGhJU1 OSib4ICwPKtfizbSkPVtZ8gma7rjVQIOTs0tHFwsz9nftwvIdBffneDcq/ZT65jyc+D1 k2I3S3jHexcZDcwct0pDoc9cCsUBgIIUhFgIoAaeU0ltn/VlnrnnzuvqiIHxfxgcWZJb /tdQ== X-Gm-Message-State: AOAM531R8BBglhJt/bKTkHRAfVEa9XEzKt2q0dY1avr4CDh3qtaZEEj6 z7kqgiWmELDqRv7Nqo7CrMMVYg== X-Received: by 2002:a5d:5492:: with SMTP id h18mr6433869wrv.340.1615110338036; Sun, 07 Mar 2021 01:45:38 -0800 (PST) Received: from localhost.localdomain (lns-bzn-59-82-252-141-80.adsl.proxad.net. [82.252.141.80]) by smtp.gmail.com with ESMTPSA id z7sm12790737wrt.70.2021.03.07.01.45.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Mar 2021 01:45:37 -0800 (PST) From: Daniel Lezcano To: cwchoi00@gmail.com Subject: [PATCH v3 3/4] devfreq/drivers/panfrost: Use devfreq cooling device registration Date: Sun, 7 Mar 2021 10:45:17 +0100 Message-Id: <20210307094519.9032-3-daniel.lezcano@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210307094519.9032-1-daniel.lezcano@linaro.org> References: <20210307094519.9032-1-daniel.lezcano@linaro.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tomeu Vizoso , linux-pm@vger.kernel.org, David Airlie , linux-kernel@vger.kernel.org, "open list:ARM MALI PANFROST DRM DRIVER" , steven.price@arm.com, Alyssa Rosenzweig , lukasz.luba@arm.com MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The devfreq core code is able to register the devfreq device as a cooling device if the 'is_cooling_device' flag is set in the profile. Use this flag and remove the cooling device registering code. Tested on rock960. Signed-off-by: Daniel Lezcano --- drivers/gpu/drm/panfrost/panfrost_devfreq.c | 14 +------------- drivers/gpu/drm/panfrost/panfrost_devfreq.h | 3 --- 2 files changed, 1 insertion(+), 16 deletions(-) -- 2.17.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel diff --git a/drivers/gpu/drm/panfrost/panfrost_devfreq.c b/drivers/gpu/drm/panfrost/panfrost_devfreq.c index 56b3f5935703..4d96edf1bc54 100644 --- a/drivers/gpu/drm/panfrost/panfrost_devfreq.c +++ b/drivers/gpu/drm/panfrost/panfrost_devfreq.c @@ -3,7 +3,6 @@ #include #include -#include #include #include @@ -80,6 +79,7 @@ static struct devfreq_dev_profile panfrost_devfreq_profile = { .polling_ms = 50, /* ~3 frames */ .target = panfrost_devfreq_target, .get_dev_status = panfrost_devfreq_get_dev_status, + .is_cooling_device = true, }; int panfrost_devfreq_init(struct panfrost_device *pfdev) @@ -90,7 +90,6 @@ int panfrost_devfreq_init(struct panfrost_device *pfdev) struct device *dev = &pfdev->pdev->dev; struct devfreq *devfreq; struct opp_table *opp_table; - struct thermal_cooling_device *cooling; struct panfrost_devfreq *pfdevfreq = &pfdev->pfdevfreq; opp_table = dev_pm_opp_set_regulators(dev, pfdev->comp->supply_names, @@ -139,12 +138,6 @@ int panfrost_devfreq_init(struct panfrost_device *pfdev) } pfdevfreq->devfreq = devfreq; - cooling = devfreq_cooling_em_register(devfreq, NULL); - if (IS_ERR(cooling)) - DRM_DEV_INFO(dev, "Failed to register cooling device\n"); - else - pfdevfreq->cooling = cooling; - return 0; err_fini: @@ -156,11 +149,6 @@ void panfrost_devfreq_fini(struct panfrost_device *pfdev) { struct panfrost_devfreq *pfdevfreq = &pfdev->pfdevfreq; - if (pfdevfreq->cooling) { - devfreq_cooling_unregister(pfdevfreq->cooling); - pfdevfreq->cooling = NULL; - } - if (pfdevfreq->opp_of_table_added) { dev_pm_opp_of_remove_table(&pfdev->pdev->dev); pfdevfreq->opp_of_table_added = false; diff --git a/drivers/gpu/drm/panfrost/panfrost_devfreq.h b/drivers/gpu/drm/panfrost/panfrost_devfreq.h index db6ea48e21f9..470f5c974703 100644 --- a/drivers/gpu/drm/panfrost/panfrost_devfreq.h +++ b/drivers/gpu/drm/panfrost/panfrost_devfreq.h @@ -9,14 +9,11 @@ struct devfreq; struct opp_table; -struct thermal_cooling_device; - struct panfrost_device; struct panfrost_devfreq { struct devfreq *devfreq; struct opp_table *regulators_opp_table; - struct thermal_cooling_device *cooling; bool opp_of_table_added; ktime_t busy_time; From patchwork Sun Mar 7 09:45:18 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Lezcano X-Patchwork-Id: 395141 Delivered-To: patch@linaro.org Received: by 2002:a02:8562:0:0:0:0:0 with SMTP id g89csp857636jai; Sun, 7 Mar 2021 01:45:49 -0800 (PST) X-Google-Smtp-Source: ABdhPJylc301RrPrAsOkTs+aqLg62rDe0PU+gReZv/RzEyAmknzSYCPsyucpwAMBySb4/8/AQ0Nz X-Received: by 2002:a17:902:562:b029:e5:e7cf:d749 with SMTP id 89-20020a1709020562b02900e5e7cfd749mr12012515plf.3.1615110349173; Sun, 07 Mar 2021 01:45:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1615110349; cv=none; d=google.com; s=arc-20160816; b=qvBG+pd3oa1TaZz4XSpGfXWaMowXtIs+Xu/Qa4HCLvhIN09+vyZzwApmS914ySiAW7 MpL8qSNs25DRk7oT+BTuq5jaiT+hH/tF29IEl4tOumYFhHqYe2ZnuVEwSotgHb3u9pLA MpC++jA3cvcCQ1F7EWdKH+yrDEjbuUV+Ni4cJH+lq8jO8qzZgDVjT2s1ywDedC+Ai5Tv iPxmtmDD7VEB5Xi8nMwQCK7/lLddFn4mwiYEeEbppFMeYhQt7Hy1A60HrM91cFMFSlrE SVII+W8Dx6Q9I0o1zG9C1JSkLRhYgS7X2hKAJdHUxkEXMQhEnPMY7zDmLFh/n1YLjc3m AMeQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:cc :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:references:in-reply-to:message-id:date:subject :to:from:dkim-signature:delivered-to; bh=OSH1tdk71siA+L8I4oWGHr7gNJCPHLxAbaOhafupgHc=; b=CxtX+HLUIuH+W8tdSw8cVzEt3H03UeXqJUeSAROgTWzOpExEJzAj+w4xP0YuQeFmt9 lZEpl8V5QtTHY7Bwo6fd5Xv5Vv7cTvNP0+oA59l6O0i/Gsla5oyzvaDoSgtHLK9Mhc04 yk6i3TivqGpjKmWgx7QI1d3ivOoMXEvOlgQpmiWwcfmb5sm7uTBUusq2otAV9QWmFwxh 4VnCi2cmqOms9wTV7CGu9zFfqFDW8xhibF/r63uTkWN4tm6LMYeNDcjWpncdpKEPd+wb 34/USAOAGmnCNh+Z/aEqGqQKpMwRMYV3rw5ekfuspCXiTMFDgBzCHPO2CkJGxfgLJw6k hMWA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=rwqG0rGj; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id k6si3568493pll.314.2021.03.07.01.45.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Mar 2021 01:45:49 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=rwqG0rGj; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E509B6E595; Sun, 7 Mar 2021 09:45:41 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by gabe.freedesktop.org (Postfix) with ESMTPS id EEF1E6E59D for ; Sun, 7 Mar 2021 09:45:40 +0000 (UTC) Received: by mail-wr1-x436.google.com with SMTP id u16so8103281wrt.1 for ; Sun, 07 Mar 2021 01:45:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=lZkNk3yYW/8ijhrD082tSx7qBCi8O3cbnVc/FrlwdlU=; b=rwqG0rGjDKgDJMDgyrPuL6fMMJ8FUmrimYfMpceWe9MkQbKAflo6IkH5SMQ0xZy9XR opslnX4VVS00yl+S+cZsjXsVGexmEyL/1aA+2mQLXU/Hx63HARlTApMASp9/RIjQON8i 5sbeykvJEJzSN1AcprCRE+EgUGP90baUMv+1YStLGuOU7ffiFtNElY+IKz13LxrRnlgp U1MW5w7tJbgVHjKiv5xn25VEvnNCzvjsyzZ77TsZy3ox3BgXwJt4C6mCUT+NjK6I5B5n 7bf3hQMhcHKcA1rS+DUGAwqAdw+cwpt2L6p1hDgO7x2nR3dMJvZM8DeCAD8gLhyASedW tu9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=lZkNk3yYW/8ijhrD082tSx7qBCi8O3cbnVc/FrlwdlU=; b=blt4zscBsky9FqFCx3c86VEGqSonxWrZsmU73jY+x8+K1k6bxfSIAwP20BM/h5v7Wq A/rx/11r21PjJvBFuxBWC2LCr1IF6Td+MNn9d1A2isEOYm2WE+r1S7pr0m8qzkL7Zjta wBVMoKjZ7zm+ZcyecPIfwy+6DdRifD/UTWbIah2LdzW10+B9MLplnGunSOkHdmgTFIpf uth6mux7kITMUHnqczGBKKkcHZgHmgAZngRykWB93nqqbgYCj0tvMNUKkfCcCDGAWmOc xLDpBKssAfFbKlIhi8/oDIHdxlsG9lxJUoZWsnNkfE83mglhesICev1+kSm2RqB06rGB yhiA== X-Gm-Message-State: AOAM532JrbjHxVmn2ji2D83QU9qXOJThuKLV0EyiHEdIhYbGvKWiy0c6 7uU9tPruLNX4CcJuN7V2ZEVuwA== X-Received: by 2002:a5d:5043:: with SMTP id h3mr17350887wrt.120.1615110339583; Sun, 07 Mar 2021 01:45:39 -0800 (PST) Received: from localhost.localdomain (lns-bzn-59-82-252-141-80.adsl.proxad.net. [82.252.141.80]) by smtp.gmail.com with ESMTPSA id z7sm12790737wrt.70.2021.03.07.01.45.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Mar 2021 01:45:39 -0800 (PST) From: Daniel Lezcano To: cwchoi00@gmail.com Subject: [PATCH v3 4/4] devfreq/drivers/lima: Use devfreq cooling device registration Date: Sun, 7 Mar 2021 10:45:18 +0100 Message-Id: <20210307094519.9032-4-daniel.lezcano@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210307094519.9032-1-daniel.lezcano@linaro.org> References: <20210307094519.9032-1-daniel.lezcano@linaro.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "moderated list:DRM DRIVERS FOR LIMA" , linux-pm@vger.kernel.org, David Airlie , linux-kernel@vger.kernel.org, "open list:DRM DRIVERS FOR LIMA" , steven.price@arm.com, Qiang Yu , lukasz.luba@arm.com MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The devfreq core code is able to register the devfreq device as a cooling device if the 'is_cooling_device' flag is set in the profile. Use this flag and remove the cooling device registering code. Signed-off-by: Daniel Lezcano --- drivers/gpu/drm/lima/lima_devfreq.c | 14 +------------- drivers/gpu/drm/lima/lima_devfreq.h | 2 -- 2 files changed, 1 insertion(+), 15 deletions(-) -- 2.17.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel diff --git a/drivers/gpu/drm/lima/lima_devfreq.c b/drivers/gpu/drm/lima/lima_devfreq.c index 5686ad4aaf7c..86aea1bdc4f4 100644 --- a/drivers/gpu/drm/lima/lima_devfreq.c +++ b/drivers/gpu/drm/lima/lima_devfreq.c @@ -7,7 +7,6 @@ */ #include #include -#include #include #include #include @@ -84,17 +83,13 @@ static struct devfreq_dev_profile lima_devfreq_profile = { .polling_ms = 50, /* ~3 frames */ .target = lima_devfreq_target, .get_dev_status = lima_devfreq_get_dev_status, + .is_cooling_device = true, }; void lima_devfreq_fini(struct lima_device *ldev) { struct lima_devfreq *devfreq = &ldev->devfreq; - if (devfreq->cooling) { - devfreq_cooling_unregister(devfreq->cooling); - devfreq->cooling = NULL; - } - if (devfreq->devfreq) { devm_devfreq_remove_device(ldev->dev, devfreq->devfreq); devfreq->devfreq = NULL; @@ -110,7 +105,6 @@ void lima_devfreq_fini(struct lima_device *ldev) int lima_devfreq_init(struct lima_device *ldev) { - struct thermal_cooling_device *cooling; struct device *dev = ldev->dev; struct opp_table *opp_table; struct devfreq *devfreq; @@ -173,12 +167,6 @@ int lima_devfreq_init(struct lima_device *ldev) ldevfreq->devfreq = devfreq; - cooling = of_devfreq_cooling_register(dev->of_node, devfreq); - if (IS_ERR(cooling)) - dev_info(dev, "Failed to register cooling device\n"); - else - ldevfreq->cooling = cooling; - return 0; err_fini: diff --git a/drivers/gpu/drm/lima/lima_devfreq.h b/drivers/gpu/drm/lima/lima_devfreq.h index 2d9b3008ce77..c43a2069e5d3 100644 --- a/drivers/gpu/drm/lima/lima_devfreq.h +++ b/drivers/gpu/drm/lima/lima_devfreq.h @@ -9,7 +9,6 @@ struct devfreq; struct opp_table; -struct thermal_cooling_device; struct lima_device; @@ -17,7 +16,6 @@ struct lima_devfreq { struct devfreq *devfreq; struct opp_table *clkname_opp_table; struct opp_table *regulators_opp_table; - struct thermal_cooling_device *cooling; ktime_t busy_time; ktime_t idle_time;