From patchwork Tue May 15 12:03:17 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christophe Lyon X-Patchwork-Id: 135871 Delivered-To: patch@linaro.org Received: by 2002:a2e:9706:0:0:0:0:0 with SMTP id r6-v6csp919276lji; Tue, 15 May 2018 05:03:37 -0700 (PDT) X-Google-Smtp-Source: AB8JxZo/PAA9PqIejXRFkhtpZEj8/yuUPB+3K/47dofJ4LnYGk55CjEyJM4IKOZtKTkzj7xBXAVJ X-Received: by 2002:a62:dfcd:: with SMTP id d74-v6mr14973883pfl.114.1526385817501; Tue, 15 May 2018 05:03:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526385817; cv=none; d=google.com; s=arc-20160816; b=ExUuyDU0cjjDWVeV25E8rMSe8ZoVJ8U0poN68/HuY8qP/rGUOZ2M1B8WflVNvgbE7W mO/mv8+1icFWP1Mi4Z0KG1Hurur9LCK0JyDf1qMHpwCYggIgdEKzcX0VExmZqzJqtNGI jbWrfQUl8Zhs6dHgfIA/xi5GU0tRygET8G86L27av02AjhkLScz3OSJzuEH8dROeGkpp wcWc/rvhUpBE/CUYNxhmb9gIOxVt0Z7XhTCmE4g9eSgoEIf+zjouMVNtmR/RN2TvL5kO IS48scylTQIyCNonH4OH3oePbcOlhZ5A30sjTf1VbPlEwrK6Dx3ehQTj+NqSzaJWu3dG 3G8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:user-agent:date:message-id:subject:from:cc:to :delivered-to:sender:list-help:list-post:list-archive:list-subscribe :list-unsubscribe:list-id:precedence:mailing-list:dkim-signature :domainkey-signature:arc-authentication-results; bh=ZNYKOmA6d/wZ+7luluDpmdcDU1g4ZOrtzUgU0uH0KAI=; b=Fhi4ZWrjzw1KGNMkZM7kmjXEAz7ZRuzr1z4PGXhgm9xelW77hWfK8U3GKlv+BcUx5G Fy1SBFeRKw3LX5/5lHrWhfXXkYtGlNM/sCFRe23dN2+TiFF1GlvmZxXGYmIaUvTUkCxh 91FBuY367+lMVaX1gVDFpSbsJ3bjPSnXYiYHG4i2xhkoLCLvgVaWZE7yU5OvKnKWL7nf Tjw/DvTdUnqXGWR//uYQjPuWcbeuAITKFyAVLO78BtXBpQf93X4Lk9wlSB9jm2CTOeYj fsFwcjH9b2CvEhUMEOP4kuryDuhZPPw6TvXzYGarjGfqghnkgNL1OJp1RngbYp1y35L5 sc1w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=D3P4YRM2; spf=pass (google.com: domain of binutils-return-101691-patch=linaro.org@sourceware.org designates 209.132.180.131 as permitted sender) smtp.mailfrom=binutils-return-101691-patch=linaro.org@sourceware.org Return-Path: Received: from sourceware.org (server1.sourceware.org. [209.132.180.131]) by mx.google.com with ESMTPS id r14-v6si11267392pfh.211.2018.05.15.05.03.37 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 15 May 2018 05:03:37 -0700 (PDT) Received-SPF: pass (google.com: domain of binutils-return-101691-patch=linaro.org@sourceware.org designates 209.132.180.131 as permitted sender) client-ip=209.132.180.131; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=D3P4YRM2; spf=pass (google.com: domain of binutils-return-101691-patch=linaro.org@sourceware.org designates 209.132.180.131 as permitted sender) smtp.mailfrom=binutils-return-101691-patch=linaro.org@sourceware.org DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:to:cc:from:subject:message-id:date :mime-version:content-type; q=dns; s=default; b=nKDxN0w6mvuMLhue +gRnA1VTk0ApQ2o6TBlhpdIojkNHV+ZwgnUcYRUBdT8V7YY24VTY3uaEJICjadRs 9f0BS4FXEXSN4pfdDrcQyw5GargZ8CDN11/lRRqRnTm08Z6MXWvCHrmc/kjvCCff BN3/rlbYvJ27Xus9gqW+9lB9vm0= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:to:cc:from:subject:message-id:date :mime-version:content-type; s=default; bh=TwuzYw0pjmuMVZ/XYrucdU X+/28=; b=D3P4YRM2KlV+TQDH5pKncNfouWfZBSg9zqBbkr9WyKFJ6sgjLh5Fns f7CHz3caKB0JGMq9nDG7vvq46lJFcpLHepaZaeXkKobhjuWlhptCbUxJkJB/yCdr fCbjwe421Stjr099t/XVHWdawjBT60msS8j5x8UCrVTFttA9Ts+mo= Received: (qmail 5876 invoked by alias); 15 May 2018 12:03:24 -0000 Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org Delivered-To: mailing list binutils@sourceware.org Received: (qmail 5861 invoked by uid 89); 15 May 2018 12:03:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-27.6 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx07-00178001.pphosted.com Received: from mx08-00178001.pphosted.com (HELO mx07-00178001.pphosted.com) (91.207.212.93) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 15 May 2018 12:03:21 +0000 Received: from pps.filterd (m0046661.ppops.net [127.0.0.1]) by mx08-.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id w4FBxLeB000531 for ; Tue, 15 May 2018 14:03:18 +0200 Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx08-00178001.pphosted.com with ESMTP id 2hyrtwj33j-1 (version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NOT) for ; Tue, 15 May 2018 14:03:18 +0200 Received: from zeta.dmz-eu.st.com (zeta.dmz-eu.st.com [164.129.230.9]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 0740C38 for ; Tue, 15 May 2018 12:03:17 +0000 (GMT) Received: from Webmail-eu.st.com (sfhdag5node1.st.com [10.75.127.13]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id B13762AF0 for ; Tue, 15 May 2018 12:03:17 +0000 (GMT) Received: from [10.129.178.127] (10.75.127.46) by SFHDAG5NODE1.st.com (10.75.127.13) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Tue, 15 May 2018 14:03:17 +0200 To: Binutils CC: Christophe GUILLON From: Christophe Lyon Subject: [PATCH] coffcode.h: Fix uninitialized variable. Message-ID: <5c282dd9-2a0c-5abc-6f13-4f5dcc8f0c1d@st.com> Date: Tue, 15 May 2018 14:03:17 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 X-ClientProxiedBy: SFHDAG1NODE1.st.com (10.75.127.1) To SFHDAG5NODE1.st.com (10.75.127.13) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2018-05-15_03:, , signatures=0 X-IsSubscribed: yes Hi, We hit a problem with cross mingw64-w64 binutils leading to random "multiple defined symbol" errors. Valgrind helped track this down to uninitialized variable access, which is fixed by the small attached patch, similarly to what was done in PR 17521 for instance. OK for master? It should probably be applied to release branches too. Thanks, Christophe 2018-05-15 Christophe Guillon * coffcode.h (coff_bigobj_swap_aux_in): Make sure that all fields of the aux structure are initialised. diff --git a/bfd/coffcode.h b/bfd/coffcode.h index c63ebd2..6ad991c 100644 --- a/bfd/coffcode.h +++ b/bfd/coffcode.h @@ -5528,6 +5528,9 @@ coff_bigobj_swap_aux_in (bfd *abfd, AUXENT_BIGOBJ *ext = (AUXENT_BIGOBJ *) ext1; union internal_auxent *in = (union internal_auxent *) in1; + /* Make sure that all fields in the aux structure are + initialised. */ + memset (in, 0, sizeof * in); switch (in_class) { case C_FILE: