From patchwork Wed May 23 14:14:41 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ard Biesheuvel X-Patchwork-Id: 136665 Delivered-To: patch@linaro.org Received: by 2002:a2e:9706:0:0:0:0:0 with SMTP id r6-v6csp953215lji; Wed, 23 May 2018 07:14:54 -0700 (PDT) X-Google-Smtp-Source: AB8JxZqKkfvKOu8GX3HnxHX40PCwGwpugLkbmhDIND36mhXPuogeSlg78PiM8MHqXbL4cBVlbyhE X-Received: by 2002:a17:902:a70b:: with SMTP id w11-v6mr3136646plq.342.1527084894350; Wed, 23 May 2018 07:14:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527084894; cv=none; d=google.com; s=arc-20160816; b=l5jpb2xyidy2TGxfepCipP8V4V4uTXFWRSpF9vOfnYN/F8YKFquv2Qguds6gA/yqTY 2gSUiYXr+Wbz+rSOt6OW5aQqpNLBLuGk8ucZbax6uOrJA5v+xwTrtw/UxQWEtpm/isJf TU7GNZmuiA3sHBnC8zk8pXa2yoRydbPCqkeFbe1Qdg+NKFgSovvVVYZWyOxfer8Qhpvg 1MAlhPQVsQHacUnYFkp1r9mGiZ08+AtHA0S+iWTilsfI8dIDk5My9X0Cp5pzPCoG7pg1 RnfARBben4EYOQEQKc7UL5b/AhtITmQFKaVmMO8LOlpTUSperNCTsjbOxQSZGRmLnBQs Bl1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:cc :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:references:in-reply-to:message-id:date :to:from:dkim-signature:delivered-to:arc-authentication-results; bh=1UtMSXynNfr1DifnJIMc2psehKqK5UnkBep0HAJGnQg=; b=lRmKSSChA+l/NPyHHrHghHuJPMS1miaxUod45pCGLjQA0wMI2O7aQxsn+92R7euN26 xN0iHEn6vHlPbG8bMLoXNQMk/Zb18J4xF5abLVvHpqg4Bb4WC3LsZ/zVW9BUxxCmXewI /RyrLXcf2ja7wUm2CNYwodMDkg2DfD4Bzjq129VLBS8O07TAyrsOv3XotYwePBTnV5Vy atH3Mhh5w6nah7Z9/5cQW6s/MPna2MMAe3abfyC90FCmBUaBTnksRjh4Do/ohMp/Zfyr DyJcn9U7yvozBOKkoava3TyNJZvYE/J0sPScgFfjvCe8aiqAXHsEVmqY33lX6wp+3HYY 2SYA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=KpU5okbe; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from ml01.01.org (ml01.01.org. [2001:19d0:306:5::1]) by mx.google.com with ESMTPS id v8-v6si18733420plo.306.2018.05.23.07.14.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 23 May 2018 07:14:54 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) client-ip=2001:19d0:306:5::1; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=KpU5okbe; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id E7BF6207E4DFC; Wed, 23 May 2018 07:14:53 -0700 (PDT) X-Original-To: edk2-devel@lists.01.org Delivered-To: edk2-devel@lists.01.org Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::22c; helo=mail-wm0-x22c.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x22c.google.com (mail-wm0-x22c.google.com [IPv6:2a00:1450:400c:c09::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 66CD8207E4DF3 for ; Wed, 23 May 2018 07:14:52 -0700 (PDT) Received: by mail-wm0-x22c.google.com with SMTP id a67-v6so9395266wmf.3 for ; Wed, 23 May 2018 07:14:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=FdjCqlhXL6zkwLUE/C6/5cki6r8JGOOWIBYERdErCWQ=; b=KpU5okbe+I1Te4wrZFWRZVPmt6WaIXiRpnWjnoaFNjNHNLq2tsAa3YujIyMowLFjU3 BmfSrtgeK4F8xWtanoajdISF3/9J/ATnSEpRTsoXjVIN9sbgThl0wpmSTNtLd5MgmVF0 3W7U4Jo89cLL+zYVEhpDg2Y4GdVO4SvjegSoY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=FdjCqlhXL6zkwLUE/C6/5cki6r8JGOOWIBYERdErCWQ=; b=Mjfd2osDsF0M2J1EPe1eFpxRKARPj5F/0JvEt2uHCVDpYw3D/pguWfaBERRXEeFkwF /ggdDETq51a1Yw85fRp3GapA50YqgqdC49vEJzEVkE/3olSsA5xonKmsRI1ZXm8FeZLv Vi5skxG5PsCO3IA+cdlEG6dXS+5PUQFdMvNDGlY5ZYPW73s5Wf7jFTw2J0K23JEJpLNj gITez20dKoVtiT/dEqv5wcvbibfsV5l3pYghA4GagQ0ytw9Rg/Z90dzozixzaq4Rj49W ujp4sF7ZOyYjlQTlDJgJlPSBl7eRQ66djO8YsEiCmM0Twi5xRrqE+NVnSwMgeZpbMZPq +9Ng== X-Gm-Message-State: ALKqPwcGKK9+w1liwr7CV/gS1PmTK9PNVS1YXWgNMG3I3gwxHKVrfwU+ gqbRAyQDDBVzFEQtbnyPE5eCRAu6Aoc= X-Received: by 2002:a1c:71dc:: with SMTP id d89-v6mr4239906wmi.26.1527084890390; Wed, 23 May 2018 07:14:50 -0700 (PDT) Received: from localhost.localdomain ([2a01:e35:3995:5470:200:1aff:fe1b:b328]) by smtp.gmail.com with ESMTPSA id o12-v6sm27347774wrf.31.2018.05.23.07.14.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 23 May 2018 07:14:49 -0700 (PDT) From: Ard Biesheuvel To: edk2-devel@lists.01.org Date: Wed, 23 May 2018 16:14:41 +0200 Message-Id: <20180523141444.20033-2-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180523141444.20033-1-ard.biesheuvel@linaro.org> References: <20180523141444.20033-1-ard.biesheuvel@linaro.org> Subject: [edk2] [PATCH edk2-platforms 1/4] Platform/DeveloperBox: add 96boards/Socionext logo X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: leif.lindholm@linaro.org, Ard Biesheuvel MIME-Version: 1.0 Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" Add a nice splash screen with the Socionext and 96boards logos. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- Binary omitted. File can be found here: http://people.linaro.org/~ard.biesheuvel/devbox/Logo.bmp Platform/Socionext/DeveloperBox/DeveloperBox.dsc | 2 +- Platform/Socionext/DeveloperBox/DeveloperBox.fdf | 2 +- Platform/Socionext/DeveloperBox/Logo/Logo.bmp | Bin 0 -> 1050122 bytes Platform/Socionext/DeveloperBox/Logo/Logo.c | 149 ++++++++++++++++++++ Platform/Socionext/DeveloperBox/Logo/Logo.idf | 15 ++ Platform/Socionext/DeveloperBox/Logo/LogoDxe.inf | 52 +++++++ 6 files changed, 218 insertions(+), 2 deletions(-) -- 2.17.0 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel diff --git a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc index 24b2925bf954..e7068a5b629c 100644 --- a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc +++ b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc @@ -504,7 +504,7 @@ [Components.common] MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitterDxe.inf MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsoleDxe.inf MdeModulePkg/Universal/Console/TerminalDxe/TerminalDxe.inf - MdeModulePkg/Logo/LogoDxe.inf + Platform/Socionext/DeveloperBox/Logo/LogoDxe.inf MdeModulePkg/Universal/PCD/Dxe/Pcd.inf { diff --git a/Platform/Socionext/DeveloperBox/DeveloperBox.fdf b/Platform/Socionext/DeveloperBox/DeveloperBox.fdf index 1b8de4c3823a..9e06abb38682 100644 --- a/Platform/Socionext/DeveloperBox/DeveloperBox.fdf +++ b/Platform/Socionext/DeveloperBox/DeveloperBox.fdf @@ -116,7 +116,7 @@ [FV.FvMain] INF MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitterDxe.inf INF MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsoleDxe.inf INF MdeModulePkg/Universal/Console/TerminalDxe/TerminalDxe.inf - INF MdeModulePkg/Logo/LogoDxe.inf + INF Platform/Socionext/DeveloperBox/Logo/LogoDxe.inf INF ArmPkg/Drivers/ArmGic/ArmGicDxe.inf # diff --git a/Platform/Socionext/DeveloperBox/Logo/Logo.bmp b/Platform/Socionext/DeveloperBox/Logo/Logo.bmp new file mode 100644 index 000000000000..bf87981ee71e Binary files /dev/null and b/Platform/Socionext/DeveloperBox/Logo/Logo.bmp differ diff --git a/Platform/Socionext/DeveloperBox/Logo/Logo.c b/Platform/Socionext/DeveloperBox/Logo/Logo.c new file mode 100644 index 000000000000..03bf748efd73 --- /dev/null +++ b/Platform/Socionext/DeveloperBox/Logo/Logo.c @@ -0,0 +1,149 @@ +/** @file + Logo DXE Driver, install Edkii Platform Logo protocol. + + Copyright (c) 2016 - 2017, Intel Corporation. All rights reserved.
+ Copyright (c) 2018, Linaro, Ltd. All rights reserved.
+ + This program and the accompanying materials are licensed and made available + under the terms and conditions of the BSD License which accompanies this + distribution. The full text of the license may be found at + http://opensource.org/licenses/bsd-license.php + + THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, + WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. + +**/ + +#include +#include +#include +#include +#include +#include +#include +#include + +typedef struct { + EFI_IMAGE_ID ImageId; + EDKII_PLATFORM_LOGO_DISPLAY_ATTRIBUTE Attribute; + INTN OffsetX; + INTN OffsetY; +} LOGO_ENTRY; + +STATIC EFI_HII_IMAGE_EX_PROTOCOL *mHiiImageEx; +STATIC EFI_HII_HANDLE mHiiHandle; +STATIC LOGO_ENTRY mLogos[] = { + { + IMAGE_TOKEN (IMG_LOGO), + EdkiiPlatformLogoDisplayAttributeCenter, + 0, + 0 + } +}; + +/** + Load a platform logo image and return its data and attributes. + + @param This The pointer to this protocol instance. + @param Instance The visible image instance is found. + @param Image Points to the image. + @param Attribute The display attributes of the image returned. + @param OffsetX The X offset of the image regarding the Attribute. + @param OffsetY The Y offset of the image regarding the Attribute. + + @retval EFI_SUCCESS The image was fetched successfully. + @retval EFI_NOT_FOUND The specified image could not be found. +**/ +STATIC +EFI_STATUS +EFIAPI +GetImage ( + IN EDKII_PLATFORM_LOGO_PROTOCOL *This, + IN OUT UINT32 *Instance, + OUT EFI_IMAGE_INPUT *Image, + OUT EDKII_PLATFORM_LOGO_DISPLAY_ATTRIBUTE *Attribute, + OUT INTN *OffsetX, + OUT INTN *OffsetY + ) +{ + UINT32 Current; + + if (Instance == NULL || Image == NULL || + Attribute == NULL || OffsetX == NULL || OffsetY == NULL) { + return EFI_INVALID_PARAMETER; + } + + Current = *Instance; + if (Current >= ARRAY_SIZE (mLogos)) { + return EFI_NOT_FOUND; + } + + (*Instance)++; + *Attribute = mLogos[Current].Attribute; + *OffsetX = mLogos[Current].OffsetX; + *OffsetY = mLogos[Current].OffsetY; + + return mHiiImageEx->GetImageEx (mHiiImageEx, mHiiHandle, + mLogos[Current].ImageId, Image); +} + +STATIC EDKII_PLATFORM_LOGO_PROTOCOL mPlatformLogo = { + GetImage +}; + +/** + Entrypoint of this module. + + This function is the entrypoint of this module. It installs the Edkii + Platform Logo protocol. + + @param ImageHandle The firmware allocated handle for the EFI image. + @param SystemTable A pointer to the EFI System Table. + + @retval EFI_SUCCESS The entry point is executed successfully. + +**/ +EFI_STATUS +EFIAPI +InitializeLogo ( + IN EFI_HANDLE ImageHandle, + IN EFI_SYSTEM_TABLE *SystemTable + ) +{ + EFI_STATUS Status; + EFI_HII_PACKAGE_LIST_HEADER *PackageList; + EFI_HII_DATABASE_PROTOCOL *HiiDatabase; + EFI_HANDLE Handle; + + Status = gBS->LocateProtocol (&gEfiHiiDatabaseProtocolGuid, NULL, + (VOID **) &HiiDatabase); + ASSERT_EFI_ERROR (Status); + + Status = gBS->LocateProtocol (&gEfiHiiImageExProtocolGuid, NULL, + (VOID **) &mHiiImageEx); + ASSERT_EFI_ERROR (Status); + + // + // Retrieve HII package list from ImageHandle + // + Status = gBS->OpenProtocol (ImageHandle, &gEfiHiiPackageListProtocolGuid, + (VOID **) &PackageList, ImageHandle, NULL, + EFI_OPEN_PROTOCOL_GET_PROTOCOL); + if (EFI_ERROR (Status)) { + DEBUG ((DEBUG_ERROR, + "HII Image Package with logo not found in PE/COFF resource section\n")); + return Status; + } + + // + // Publish HII package list to HII Database. + // + Status = HiiDatabase->NewPackageList (HiiDatabase, PackageList, NULL, + &mHiiHandle); + if (!EFI_ERROR (Status)) { + Handle = NULL; + Status = gBS->InstallMultipleProtocolInterfaces (&Handle, + &gEdkiiPlatformLogoProtocolGuid, &mPlatformLogo, NULL); + } + return Status; +} diff --git a/Platform/Socionext/DeveloperBox/Logo/Logo.idf b/Platform/Socionext/DeveloperBox/Logo/Logo.idf new file mode 100644 index 000000000000..43a17dff65ad --- /dev/null +++ b/Platform/Socionext/DeveloperBox/Logo/Logo.idf @@ -0,0 +1,15 @@ +// @file +// Platform Logo image definition file. +// +// Copyright (c) 2018, Linaro, Ltd. All rights reserved.
+// +// This program and the accompanying materials are licensed and made available +// under the terms and conditions of the BSD License which accompanies this +// distribution. The full text of the license may be found at +// http://opensource.org/licenses/bsd-license.php +// +// THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, +// WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. +// + +#image IMG_LOGO Logo.bmp diff --git a/Platform/Socionext/DeveloperBox/Logo/LogoDxe.inf b/Platform/Socionext/DeveloperBox/Logo/LogoDxe.inf new file mode 100644 index 000000000000..d25fd097eb10 --- /dev/null +++ b/Platform/Socionext/DeveloperBox/Logo/LogoDxe.inf @@ -0,0 +1,52 @@ +## @file +# The default logo bitmap picture shown on setup screen. +# +# Copyright (c) 2016 - 2017, Intel Corporation. All rights reserved.
+# Copyright (c) 2018, Linaro, Ltd. All rights reserved.
+# +# This program and the accompanying materials +# are licensed and made available under the terms and conditions of the BSD License +# which accompanies this distribution. The full text of the license may be found at +# http://opensource.org/licenses/bsd-license.php +# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, +# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. +# +# +## + +[Defines] + INF_VERSION = 0x0001001A + BASE_NAME = LogoDxe + FILE_GUID = 35ec7319-053b-45b8-8523-8666a662122c + MODULE_TYPE = DXE_DRIVER + VERSION_STRING = 1.0 + + ENTRY_POINT = InitializeLogo +# +# This flag specifies whether HII resource section is generated into PE image. +# + UEFI_HII_RESOURCE_SECTION = TRUE + +[Sources] + Logo.bmp + Logo.c + Logo.idf + +[Packages] + MdeModulePkg/MdeModulePkg.dec + MdePkg/MdePkg.dec + +[LibraryClasses] + UefiBootServicesTableLib + UefiDriverEntryPoint + DebugLib + +[Protocols] + gEfiHiiDatabaseProtocolGuid ## CONSUMES + gEfiHiiImageExProtocolGuid ## CONSUMES + gEfiHiiPackageListProtocolGuid ## PRODUCES CONSUMES + gEdkiiPlatformLogoProtocolGuid ## PRODUCES + +[Depex] + gEfiHiiDatabaseProtocolGuid AND + gEfiHiiImageExProtocolGuid From patchwork Wed May 23 14:14:42 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ard Biesheuvel X-Patchwork-Id: 136666 Delivered-To: patch@linaro.org Received: by 2002:a2e:9706:0:0:0:0:0 with SMTP id r6-v6csp953282lji; Wed, 23 May 2018 07:14:57 -0700 (PDT) X-Google-Smtp-Source: AB8JxZpMs6zfLEmt7mHwGfkATSOl2fF9HMvmxvqkDk+CaZU8DVzLZBKm82BEXrtYIJtQqVUyfVJi X-Received: by 2002:aa7:84c7:: with SMTP id x7-v6mr3104421pfn.195.1527084897569; Wed, 23 May 2018 07:14:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527084897; cv=none; d=google.com; s=arc-20160816; b=nNdiCXOVp5wLWQWYjSUoBg61oCJlVBpp9E3t79KniiClVJdsgZ91yi0NDDCKifs+Ok 8irfeOaeuetcxq5h//QD59LEMJbOa/7u4cyGNs1bANTUkg5f0v+NIka6TvdwXhjTFGuM L0kDQUTQ6y2582CGXN+MATAexCqpoVdiuOaZ59dZw90f+IpLAhVO5E2x42MNDRYnBfGx QR+I5QMDy7jhwGzeTj3bk5tntXtNFh7foj1WNnO3wJBj8eEW/qCk3AUSNi9kYWoB0BtM HRraTrrXgx8iQaEFCmU0uMccvTSrkvL40rCcdPSjOLwqXfWVoTtYL9hzWtvKgweOWgmM Dyig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:cc :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:references:in-reply-to:message-id:date :to:from:dkim-signature:delivered-to:arc-authentication-results; bh=wIQjrluZ4+mnuqErXj/8vhqmcPGaotHxx6PqxQxEQhk=; b=iHbiPLtERmtLZUm6sSlZkT5OZTlPdZrY/QJywg7WwBhbGoXILTGbR60XR4/aAjxuZ+ mTiwcreimUVXCyq7cFEMOhbZVPSwYYPjT6oynoDBjG3pycNpQ1JjWqSn9qrd4nVnbmG4 c1MWUb2Xq7ZqBFfpkwBn2egBS4o1+5gXvc52C16clagR0TaPl4Pa27sWzf/A0tYaO9o7 Y9Sf2PTxiYE+27YI0Iu0U7JrvAX2yYrBz+SozN8lYccTu29NtYQt110XGGh0nBqNIznm t2xrnBzZDP07ippBN1vXwfHe+Iv+5UchTgVmfsvW1ctOJvYjZR3xs8hHT2zMEMg/0iTc YDRg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=f2jeErhc; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from ml01.01.org (ml01.01.org. [198.145.21.10]) by mx.google.com with ESMTPS id a185-v6si14679021pgc.586.2018.05.23.07.14.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 23 May 2018 07:14:57 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) client-ip=198.145.21.10; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=f2jeErhc; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 2073B207E4E03; Wed, 23 May 2018 07:14:55 -0700 (PDT) X-Original-To: edk2-devel@lists.01.org Delivered-To: edk2-devel@lists.01.org Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::242; helo=mail-wm0-x242.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x242.google.com (mail-wm0-x242.google.com [IPv6:2a00:1450:400c:c09::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 91634207E4DF3 for ; Wed, 23 May 2018 07:14:53 -0700 (PDT) Received: by mail-wm0-x242.google.com with SMTP id j5-v6so9636862wme.5 for ; Wed, 23 May 2018 07:14:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=uQS5u9G325rCZEjkHJWkBi6jbX/VNlL7ibt3r2e137k=; b=f2jeErhcsKeiLGLcHQ3uaapoH/ftmNxwgrA2nb4QvF5fGO33SpMvtBFBYbaiesmuaY sim/XX51+X2o7ysWe2jDJY6aD72WWGt+N2ni+3EzidU3pj4FJclNOhhtqJiNO2GBJmYA 34q03tGbVxjFNLYXaJeJILxwA/Clm4S5IEPwM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=uQS5u9G325rCZEjkHJWkBi6jbX/VNlL7ibt3r2e137k=; b=KSe9wh+okNHm896c5ytWgNLlSYOccDm3BDGXZfpXzomnj5YXwLnPViPfcPRVEwSaQg uXuK7U2awcOeM/TEhiIYTWuoa/mBW7AO3htMexKLxV22wAPn2j1p/VFyXt0tSJveMpz2 G7wPPhpBwDmGcfcv2HyZd0CcsvffEvyRsC6MEfG5OJ12ZMEqKMzRuF1/i+GPP6NIRSly n9nrlJHtByH6hf0SCitElVyK6Vt09q0jhhFySl35WObOt+8j+9r8CJCHTDQUU7RCQ97r MhzGUipqPKXTVtBO4Q2m/oNYJEpoC9dP6AuIV/vSOAg2RmpmV2dkWIaGLp4nV+b2elwR eJ7A== X-Gm-Message-State: ALKqPwduORju01Sgi2RvAu8efV7DSXdmvdD9P3656LRvqx+MfcB3WuxQ WBIAkkXug0E8pdKAztXldu11EkqT5M0= X-Received: by 2002:a1c:6d90:: with SMTP id b16-v6mr4199702wmi.138.1527084891951; Wed, 23 May 2018 07:14:51 -0700 (PDT) Received: from localhost.localdomain ([2a01:e35:3995:5470:200:1aff:fe1b:b328]) by smtp.gmail.com with ESMTPSA id o12-v6sm27347774wrf.31.2018.05.23.07.14.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 23 May 2018 07:14:51 -0700 (PDT) From: Ard Biesheuvel To: edk2-devel@lists.01.org Date: Wed, 23 May 2018 16:14:42 +0200 Message-Id: <20180523141444.20033-3-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180523141444.20033-1-ard.biesheuvel@linaro.org> References: <20180523141444.20033-1-ard.biesheuvel@linaro.org> Subject: [edk2] [PATCH edk2-platforms 2/4] Platform/DeveloperBox: add PCI serial driver X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: leif.lindholm@linaro.org, Ard Biesheuvel MIME-Version: 1.0 Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" Add the generic PCI serial driver so UART plugin cards can be used as the serial console in UEFI. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- Platform/Socionext/DeveloperBox/DeveloperBox.dsc | 1 + Platform/Socionext/DeveloperBox/DeveloperBox.fdf | 1 + 2 files changed, 2 insertions(+) -- 2.17.0 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel diff --git a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc index e7068a5b629c..1bfe7fcaca01 100644 --- a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc +++ b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc @@ -581,6 +581,7 @@ [Components.common] MdeModulePkg/Universal/EbcDxe/EbcDxe.inf MdeModulePkg/Universal/Acpi/BootGraphicsResourceTableDxe/BootGraphicsResourceTableDxe.inf Silicon/Socionext/SynQuacer/Stage2Tables/Stage2Tables.inf + MdeModulePkg/Bus/Pci/PciSioSerialDxe/PciSioSerialDxe.inf # # eMMC support diff --git a/Platform/Socionext/DeveloperBox/DeveloperBox.fdf b/Platform/Socionext/DeveloperBox/DeveloperBox.fdf index 9e06abb38682..c36104da3b46 100644 --- a/Platform/Socionext/DeveloperBox/DeveloperBox.fdf +++ b/Platform/Socionext/DeveloperBox/DeveloperBox.fdf @@ -149,6 +149,7 @@ [FV.FvMain] INF MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressDxe.inf INF MdeModulePkg/Universal/EbcDxe/EbcDxe.inf INF MdeModulePkg/Universal/Acpi/BootGraphicsResourceTableDxe/BootGraphicsResourceTableDxe.inf + INF MdeModulePkg/Bus/Pci/PciSioSerialDxe/PciSioSerialDxe.inf # # eMMC support From patchwork Wed May 23 14:14:43 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ard Biesheuvel X-Patchwork-Id: 136667 Delivered-To: patch@linaro.org Received: by 2002:a2e:9706:0:0:0:0:0 with SMTP id r6-v6csp953393lji; Wed, 23 May 2018 07:15:03 -0700 (PDT) X-Google-Smtp-Source: AB8JxZrKag0Zz2Mfy2ac2GsM+nN8AGj3cYND4rdoWMyj7auZrd0lDDh+BbljYzHsTvBTZ8xnMaF6 X-Received: by 2002:a17:902:1029:: with SMTP id b38-v6mr3140353pla.277.1527084902928; Wed, 23 May 2018 07:15:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527084902; cv=none; d=google.com; s=arc-20160816; b=OCjfo3bgXkzlIkATpTwE/3IwW+AIOFKSbmrOA7FANtEze0rtBiIm2Qm3AZbhPOBEtB 77noQ2xzzh49l2umXJdqBqUld+yXnPIlA1XVVyBKGJ+j71Mhuf9YuVilCW6ty7yoyOF+ f69I9EtSzH/ZMa6wxB4PPXSnuAU8LijktGHRufenu+4d095QNsPhgl0v7lc9lwJhcvA+ Jh68KrfCCkcndH8iWB5PUWqB9qtuM7/cxPka7Ru7Aq+sb5ViTgPvOOcEsRzMFWvcKNi3 Q0unMVOdPhjnrsRHOupCpt3ThbNwqbaT6eghdfy7JsI624QU4mpn6cFFHOrr+7cFsiAJ qQgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:cc :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:references:in-reply-to:message-id:date :to:from:dkim-signature:delivered-to:arc-authentication-results; bh=gNcikBMVtZAnYneMaGhisUYgNQSVkbSwxI3pms1V9EQ=; b=f8ZSELYUhCyDIYW6ClZs4nnkpRNug7AlQg8W+xiqK3hhx8CBQQ6NxR/6ne6U8yEn8R DZw9RkonIL+yn52VLcYbHUMGpkGzuQOn7rlJwvyQEakc6wlkjwF7/gfdvYXLD+aoX7OR UrT9mZvkAcSmUeKMhyHT5P792eEQ4oR8/EKpJRH+HIcf/NDxbJneHUH5RMLanfgjgaV8 /gu5ElTZ31PrHokcC5i91NCnWuAdCYh0K+xfmxZ7884lxORCVnEPbJY0mAYUtcNLEMOE Rcqgaftj9yXWLL7oycYfulHhFq5009Ebz4pWeU+QZGxgU6YtX9xw/AH3BvDzwxRTJT2F Ibxg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=dzjCFBgp; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from ml01.01.org (ml01.01.org. [198.145.21.10]) by mx.google.com with ESMTPS id b1-v6si19139232pla.570.2018.05.23.07.15.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 23 May 2018 07:15:02 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) client-ip=198.145.21.10; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=dzjCFBgp; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 5EEEF207E4E0D; Wed, 23 May 2018 07:14:56 -0700 (PDT) X-Original-To: edk2-devel@lists.01.org Delivered-To: edk2-devel@lists.01.org Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::229; helo=mail-wm0-x229.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x229.google.com (mail-wm0-x229.google.com [IPv6:2a00:1450:400c:c09::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 3C2F7207E4E08 for ; Wed, 23 May 2018 07:14:55 -0700 (PDT) Received: by mail-wm0-x229.google.com with SMTP id f6-v6so9447815wmc.4 for ; Wed, 23 May 2018 07:14:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=AQfo1d25l5GT30MinW14eghgpvnu6/jTsIYPWYReWB0=; b=dzjCFBgp1Gjk2Ys61q0lXxjboSVlsSXnyR34TJ4wovx/Xl7aZmuJxZzIBMa9KoyQxv Stau/gmCnUvtf7uR4APF6IPkF6Hekg8DXiOIlF28mBHBgm/J3fXPicR6lTHdIQIPgcf2 bx/z2+RGc0TV2JpeNN/wC3kYRLogJfP4kUjOk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=AQfo1d25l5GT30MinW14eghgpvnu6/jTsIYPWYReWB0=; b=FPIHEJnnUDzWXKGS4y7nkVpg3D729qls77qt3IYcUjRFDnhKD5GCxsVJuJPnc3jJru ToDBaKbytXgTTELmZ/5jNiLmG5vp5M8XZ+T9TLCtAGMeAeYs1Dmj6/JnNOenxHXH5cBN wnnFqPYbfgRgwlDmbT5Rhs0FNLNEfiupZeO2vqAdx47lOus4+QXxchQdspzups3ebJTw ajjIEgEAOUzoSYc0DbR+KH46y9+6NL2MImwa8jUemXzwFDIVvkTX1rsAKMQd4spp/fd3 Rzletn9rxqABCRYyf5MyzoQRUobuKpIibewMEPMiSfjCr9P++qMQ5QzH14dTDzLwcVJx nnqw== X-Gm-Message-State: ALKqPwdKKY/1HFmy1GuDVoGbTP9KBvCqhN8EGAMenirnNp4yW/dP1fIx qlGHMAMBOGTjGaKJTMcdK8BXDwwHdho= X-Received: by 2002:a1c:8a03:: with SMTP id m3-v6mr3984939wmd.135.1527084893279; Wed, 23 May 2018 07:14:53 -0700 (PDT) Received: from localhost.localdomain ([2a01:e35:3995:5470:200:1aff:fe1b:b328]) by smtp.gmail.com with ESMTPSA id o12-v6sm27347774wrf.31.2018.05.23.07.14.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 23 May 2018 07:14:52 -0700 (PDT) From: Ard Biesheuvel To: edk2-devel@lists.01.org Date: Wed, 23 May 2018 16:14:43 +0200 Message-Id: <20180523141444.20033-4-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180523141444.20033-1-ard.biesheuvel@linaro.org> References: <20180523141444.20033-1-ard.biesheuvel@linaro.org> Subject: [edk2] [PATCH edk2-platforms 3/4] Platform/DeveloperBox: switch to protocol based DevicePathLib X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: leif.lindholm@linaro.org, Ard Biesheuvel MIME-Version: 1.0 Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" We already include DevicePathDxe, which exposes a protocol that implements DevicePathLib in a way that can be shared across modules, avoiding the need for multiple copies of UefiDevicePathLib, which is rather heavy weight. However, we are not actually using it, and all DevicePathLib users carry a private copy of UefiDevicePathLib. So wire up all modules except DxeCore and DevicePathDxe itself, which cannot use the protocol for obvious reasons. Also, avoid creating a cyclic dependency between PcdDxe and DevicePathDxe by using PcdLibNull in the latter. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- Platform/Socionext/DeveloperBox/DeveloperBox.dsc | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) -- 2.17.0 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel diff --git a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc index 1bfe7fcaca01..3decc22e25b1 100644 --- a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc +++ b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc @@ -93,7 +93,7 @@ [LibraryClasses.common] UefiLib|MdePkg/Library/UefiLib/UefiLib.inf HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf UefiRuntimeServicesTableLib|MdePkg/Library/UefiRuntimeServicesTableLib/UefiRuntimeServicesTableLib.inf - DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf + DevicePathLib|MdePkg/Library/UefiDevicePathLibDevicePathProtocol/UefiDevicePathLibDevicePathProtocol.inf UefiBootServicesTableLib|MdePkg/Library/UefiBootServicesTableLib/UefiBootServicesTableLib.inf DxeServicesTableLib|MdePkg/Library/DxeServicesTableLib/DxeServicesTableLib.inf UefiDriverEntryPoint|MdePkg/Library/UefiDriverEntryPoint/UefiDriverEntryPoint.inf @@ -475,6 +475,7 @@ [Components.common] MdeModulePkg/Core/Dxe/DxeMain.inf { NULL|MdeModulePkg/Library/DxeCrc32GuidedSectionExtractLib/DxeCrc32GuidedSectionExtractLib.inf + DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErrorLevel|0x8000000F } @@ -497,7 +498,12 @@ [Components.common] ArmPkg/Drivers/GenericWatchdogDxe/GenericWatchdogDxe.inf MdeModulePkg/Universal/CapsuleRuntimeDxe/CapsuleRuntimeDxe.inf - MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf + MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf { + + DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf + PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf + } + MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf MdeModulePkg/Universal/SerialDxe/SerialDxe.inf MdeModulePkg/Universal/Console/ConPlatformDxe/ConPlatformDxe.inf From patchwork Wed May 23 14:14:44 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ard Biesheuvel X-Patchwork-Id: 136668 Delivered-To: patch@linaro.org Received: by 2002:a2e:9706:0:0:0:0:0 with SMTP id r6-v6csp953510lji; Wed, 23 May 2018 07:15:07 -0700 (PDT) X-Google-Smtp-Source: AB8JxZoWqm29ggiOKvtFC99+4Zm7OtzP+zMe5Qnd3g0B3/zUbU8JkW8NjLd9ze6Wx8FT5ywZ9YUa X-Received: by 2002:a63:43c6:: with SMTP id q189-v6mr2574912pga.123.1527084907766; Wed, 23 May 2018 07:15:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527084907; cv=none; d=google.com; s=arc-20160816; b=kiHy031jY1P4WzttKpy1l6A2u9RJ7xYTIA+mC415vmBc+IdQ4TfbZvgTGuXxa6IN1B E9C8BgoY8Jps5lrF6Szw7VaTJ6v021rRoWFF6N6y2uoMNt/Dx+OEsjwy+5KKwOlPkXei wzXhUKFL1ky0xGHjybpt1NUtqfEaEvztlBxB0cKB8TPw1MNlvx7SitNb9nxzQwY2y2m/ 5wmrUlWXbtjnoXmYx5+Lg8odNiImh7jtkfKRrcXzGgK0iCSsVsqMX+11mNql8pQI/pSD fr+yLOSvPuXFx7PgZgjsNChPJqv+ZiWAJyFvHNMPDR6v7/viEbIjHaNlX28eUoG4pL9c dZNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:cc :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:references:in-reply-to:message-id:date :to:from:dkim-signature:delivered-to:arc-authentication-results; bh=Lm3xuB1bVlB6rOeBkzNS+z9gdbVmi6TgociwZloX9KM=; b=wpbEc7wQThiXybkCrMKpxhADc1BQ6FUpNSrHJZJaSAh0N6boj6HTUF7gu3IK2GesqW gm6pCY1a15mvTwrGUXioqgERK6pZtCEMUDbV7rUlS7Ceb9gOIF1oZlCVJzXO0y3MtkjZ P73EEabOaHLLSqrKa9FfS4aDHNugjIAIl9qK6D7Tyluk8oqvtW25ALTViw6f3aPpJm4Q oTVi88nel6yI3q9KYyDEovmjCCZaluYl/ILQjvZm6hMqEue/Tl8UobUmFM7SpyaeXxCP 9okcT1ydYqZ/xWRPin6/kr64aBKLgycyD3nfxTR+WVFlUVsI9pZm4Xhzd4/BnxRjShSm 5Cqw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=iNKcaKix; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from ml01.01.org (ml01.01.org. [198.145.21.10]) by mx.google.com with ESMTPS id m7-v6si17874439pfh.92.2018.05.23.07.15.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 23 May 2018 07:15:07 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) client-ip=198.145.21.10; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=iNKcaKix; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 89D53207E4DF9; Wed, 23 May 2018 07:14:58 -0700 (PDT) X-Original-To: edk2-devel@lists.01.org Delivered-To: edk2-devel@lists.01.org Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::243; helo=mail-wm0-x243.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x243.google.com (mail-wm0-x243.google.com [IPv6:2a00:1450:400c:c09::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id AE15121BADAB3 for ; Wed, 23 May 2018 07:14:56 -0700 (PDT) Received: by mail-wm0-x243.google.com with SMTP id j4-v6so9495106wme.1 for ; Wed, 23 May 2018 07:14:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=zylwOThWLC6+BZg2zQj0xxj/D1VVPY1uE9KFH0QRV2Q=; b=iNKcaKix5yluU+frkSHflYf+uAN1wv+2N4ILjvzbZ07G0CzkkZbd6xLEcTrvl9VVzc cvF5Aoji4o4prEIJb0o4HZZOw/OzzXHUz0IqwPLNvzZ/msk49sZY/1kHzJbvsZyWOaKW zcAqQEPq9IK3uEebgxbV6RA19IfAWiuWmyQIA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=zylwOThWLC6+BZg2zQj0xxj/D1VVPY1uE9KFH0QRV2Q=; b=KygbN8ma+KZuQ9f3Er3tVYnhWgMG3OADeiu1bVHI3x+f/c7xklqbPHVy9udNJKyZNn JAlN/VmWxrhE+vc+HHs61cPKqOViXcIcTPJWof70uDJUH0mqGOMSpUOxNRhMMCAxFpJ8 D1tOShdNXoEYZuPjqeloyjclhzXEZEB6OL74KDuNzgLKeJH31pOPPv1JTJNPPYUlzfgT GFXN+FiL/eb4Sz2GestwHz7SU6fbgAfkkyOuS6WbOIntN5QfBYcisjAz07QTT5n3L/yK XgG1QCCeJnnxmJKFueBsrHUYuO5PoXDAbjDAP8eRbn0BZ5W9IRTINk3XFsXoz84py9Eu o3yw== X-Gm-Message-State: ALKqPwcbkdDWaSIPr6LaLz40EX/lQKUqP6nKgtIrnvA67qGprk2EpCtY Wxhjj9ICnL7KM+a/xTOTirIZ6FzCsvw= X-Received: by 2002:a1c:7a0b:: with SMTP id v11-v6mr4723447wmc.58.1527084894896; Wed, 23 May 2018 07:14:54 -0700 (PDT) Received: from localhost.localdomain ([2a01:e35:3995:5470:200:1aff:fe1b:b328]) by smtp.gmail.com with ESMTPSA id o12-v6sm27347774wrf.31.2018.05.23.07.14.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 23 May 2018 07:14:54 -0700 (PDT) From: Ard Biesheuvel To: edk2-devel@lists.01.org Date: Wed, 23 May 2018 16:14:44 +0200 Message-Id: <20180523141444.20033-5-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180523141444.20033-1-ard.biesheuvel@linaro.org> References: <20180523141444.20033-1-ard.biesheuvel@linaro.org> Subject: [edk2] [PATCH edk2-platforms 4/4] Silicon/Socionext/SynQuacerPciHostBridgeLib: DEPEX on variable protocol X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: leif.lindholm@linaro.org, Ard Biesheuvel MIME-Version: 1.0 Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" As discussed on-list [0], dynamic HII PCDs are backed by EFI variables, but having PcdDxe DEPEXing on gEfiVariableArchProtocolGuid in general is too restrictive, and so it is up to the platforms themselves to DEPEX on gEfiVariableArchProtocolGuid in modules that use PCDs that the platform may declare as dynamic HII. This also applies to the PCD gSynQuacerTokenSpaceGuid.PcdPlatformSettings on the SynQuacer platform, which is used by its PciHostBridgeLib implementation. So add the DEPEX to make this dependency explicit. [0] https://lists.01.org/pipermail/edk2-devel/2018-April/023700.html Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- Silicon/Socionext/SynQuacer/Library/SynQuacerPciHostBridgeLib/SynQuacerPciHostBridgeLib.inf | 5 +++++ 1 file changed, 5 insertions(+) -- 2.17.0 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel diff --git a/Silicon/Socionext/SynQuacer/Library/SynQuacerPciHostBridgeLib/SynQuacerPciHostBridgeLib.inf b/Silicon/Socionext/SynQuacer/Library/SynQuacerPciHostBridgeLib/SynQuacerPciHostBridgeLib.inf index e475529eaf58..8b8bb5df57d3 100644 --- a/Silicon/Socionext/SynQuacer/Library/SynQuacerPciHostBridgeLib/SynQuacerPciHostBridgeLib.inf +++ b/Silicon/Socionext/SynQuacer/Library/SynQuacerPciHostBridgeLib/SynQuacerPciHostBridgeLib.inf @@ -54,3 +54,8 @@ [FixedPcd] [Pcd] gSynQuacerTokenSpaceGuid.PcdPcieEnableMask gSynQuacerTokenSpaceGuid.PcdPlatformSettings + +[Depex] + # gSynQuacerTokenSpaceGuid.PcdPlatformSettings may be of the dynamic HII + # variety, which are backed by EFI variables + gEfiVariableArchProtocolGuid