From patchwork Wed Mar 31 16:33:51 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lukasz Luba X-Patchwork-Id: 413229 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89AFAC43600 for ; Wed, 31 Mar 2021 16:35:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6001E6101A for ; Wed, 31 Mar 2021 16:35:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234054AbhCaQec (ORCPT ); Wed, 31 Mar 2021 12:34:32 -0400 Received: from foss.arm.com ([217.140.110.172]:46494 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233747AbhCaQeW (ORCPT ); Wed, 31 Mar 2021 12:34:22 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 66D3411D4; Wed, 31 Mar 2021 09:34:21 -0700 (PDT) Received: from e123648.arm.com (unknown [10.57.22.51]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id BA5213F792; Wed, 31 Mar 2021 09:34:19 -0700 (PDT) From: Lukasz Luba To: linux-kernel@vger.kernel.org, daniel.lezcano@linaro.org Cc: linux-pm@vger.kernel.org, amitk@kernel.org, rui.zhang@intel.com, lukasz.luba@arm.com Subject: [PATCH 1/2] thermal: power_allocator: maintain the device statistics from going stale Date: Wed, 31 Mar 2021 17:33:51 +0100 Message-Id: <20210331163352.32416-2-lukasz.luba@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210331163352.32416-1-lukasz.luba@arm.com> References: <20210331163352.32416-1-lukasz.luba@arm.com> Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org When the temperature is below the first activation trip point the cooling devices are not checked, so they cannot maintain fresh statistics. It leads into the situation, when temperature crosses first trip point, the statistics are stale and show state for very long period. This has impact on IPA algorithm calculation and wrong decisions. Thus, check the cooling devices even when the temperature is low, to refresh these statistics. Signed-off-by: Lukasz Luba --- drivers/thermal/gov_power_allocator.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/drivers/thermal/gov_power_allocator.c b/drivers/thermal/gov_power_allocator.c index 2802a0e13c88..0cbd10cab193 100644 --- a/drivers/thermal/gov_power_allocator.c +++ b/drivers/thermal/gov_power_allocator.c @@ -575,15 +575,27 @@ static void allow_maximum_power(struct thermal_zone_device *tz) { struct thermal_instance *instance; struct power_allocator_params *params = tz->governor_data; + u32 req_power; mutex_lock(&tz->lock); list_for_each_entry(instance, &tz->thermal_instances, tz_node) { + struct thermal_cooling_device *cdev = instance->cdev; + if ((instance->trip != params->trip_max_desired_temperature) || (!cdev_is_power_actor(instance->cdev))) continue; instance->target = 0; mutex_lock(&instance->cdev->lock); + /* + * Call for updating the cooling devices local stats and avoid + * periods of dozen of seconds when those have not been + * maintained. The long period would come into the first check + * when lower threshold is crossed. Thus, limit it to single + * one longer polling period. + */ + cdev->ops->get_requested_power(cdev, &req_power); + instance->cdev->updated = false; mutex_unlock(&instance->cdev->lock); thermal_cdev_update(instance->cdev); From patchwork Wed Mar 31 16:33:52 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lukasz Luba X-Patchwork-Id: 414050 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76DDDC43460 for ; Wed, 31 Mar 2021 16:35:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 416F961057 for ; Wed, 31 Mar 2021 16:35:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234206AbhCaQed (ORCPT ); Wed, 31 Mar 2021 12:34:33 -0400 Received: from foss.arm.com ([217.140.110.172]:46504 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233830AbhCaQeY (ORCPT ); Wed, 31 Mar 2021 12:34:24 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5B1FAD6E; Wed, 31 Mar 2021 09:34:23 -0700 (PDT) Received: from e123648.arm.com (unknown [10.57.22.51]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id AE1883F792; Wed, 31 Mar 2021 09:34:21 -0700 (PDT) From: Lukasz Luba To: linux-kernel@vger.kernel.org, daniel.lezcano@linaro.org Cc: linux-pm@vger.kernel.org, amitk@kernel.org, rui.zhang@intel.com, lukasz.luba@arm.com Subject: [PATCH 2/2] thermal: power_allocator: update once cooling devices when temp is low Date: Wed, 31 Mar 2021 17:33:52 +0100 Message-Id: <20210331163352.32416-3-lukasz.luba@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210331163352.32416-1-lukasz.luba@arm.com> References: <20210331163352.32416-1-lukasz.luba@arm.com> Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org The cooling device state change generates an event, also when there is no need, because temperature is low and device is not throttled. Avoid to unnecessary update the cooling device which means also not sending event. The cooling device state has not changed because the temperature is still below the first activation trip point value, so we can do this. Add a tracking mechanism if the update was triggered and makes sure it will be done only once when the temperature continue to stay below first trip point. Reported-by: Daniel Lezcano Signed-off-by: Lukasz Luba --- drivers/thermal/gov_power_allocator.c | 21 +++++++++++++++++++-- 1 file changed, 19 insertions(+), 2 deletions(-) diff --git a/drivers/thermal/gov_power_allocator.c b/drivers/thermal/gov_power_allocator.c index 0cbd10cab193..6085b6661b8b 100644 --- a/drivers/thermal/gov_power_allocator.c +++ b/drivers/thermal/gov_power_allocator.c @@ -65,6 +65,8 @@ static inline s64 div_frac(s64 x, s64 y) * controlling for. * @sustainable_power: Sustainable power (heat) that this thermal zone can * dissipate + * @updated: Keeps track if the framework was updated when the + * temperature went below the first trip point. */ struct power_allocator_params { bool allocated_tzp; @@ -73,6 +75,7 @@ struct power_allocator_params { int trip_switch_on; int trip_max_desired_temperature; u32 sustainable_power; + bool updated; }; /** @@ -395,6 +398,12 @@ static int allocate_power(struct thermal_zone_device *tz, mutex_lock(&tz->lock); + /* + * The temperature has crossed the first trip point, so next time + * when it drops below, update cooling devices and framework. + */ + params->updated = false; + num_actors = 0; total_weight = 0; list_for_each_entry(instance, &tz->thermal_instances, tz_node) { @@ -596,10 +605,18 @@ static void allow_maximum_power(struct thermal_zone_device *tz) */ cdev->ops->get_requested_power(cdev, &req_power); - instance->cdev->updated = false; + if (!params->updated) + instance->cdev->updated = false; + mutex_unlock(&instance->cdev->lock); - thermal_cdev_update(instance->cdev); + + if (!params->updated) + thermal_cdev_update(instance->cdev); } + + /* Don't send updates next time when temperature is low. */ + params->updated = true; + mutex_unlock(&tz->lock); }