From patchwork Mon Jun 4 07:10:49 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Fam Zheng X-Patchwork-Id: 137618 Delivered-To: patch@linaro.org Received: by 2002:a2e:970d:0:0:0:0:0 with SMTP id r13-v6csp1167375lji; Mon, 4 Jun 2018 00:13:26 -0700 (PDT) X-Google-Smtp-Source: ADUXVKLBRj88TyhAI7c+ByCwfUMnoUWKJARLdwUcZsDQttG+e5IyGMS1H8bjW7QRBkVcpyGYCecp X-Received: by 2002:a0c:c592:: with SMTP id a18-v6mr18817405qvj.227.1528096406391; Mon, 04 Jun 2018 00:13:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1528096406; cv=none; d=google.com; s=arc-20160816; b=zWIRR95fIJma8gR+xvNz7jdhifyjE3OracFiVYgIu1MaAA/88tEVyEZMnfvNh9r3gB wA0tR0+VV+vwgDLRH+a0peVraQTJXycQ0ewWeaiWPbOTg/9OQS2vY9zY3DnWcYsoiI3C kIz/MA/+USkLE9QWsN57gatggvNNkpZ1n9KW7QxMoFKXel2pX4zSGwT8s+T7c6O/rfVi khjVkkOz8HsYG0fyfhK3zG4I8S9gT/6UBZvyHrDhrw1g/n4fpFYzgI3evSZvf4v5M/7T aUAALV8EM+Pj1ynSPht5wHNOs7xdcsLszyAzi5aKmMi9EAI0VJO16PdavPmIhAwXzCEm c9Pw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:arc-authentication-results; bh=uu+TttmVWULeHQtJiaU/1pCZC3exxa2qZjUr/n9QZKY=; b=HDN+kR0tEQivkHUNxAvgYmHH1J+M0nUk7zVHVlAUdMichyq3OONDUF0yT76Gn25fHa ru+NxdC7nST9QBvwh8v3ZOz4zRHSUGFO9PqUB0CxnIXdbCEtpJeUsaNcd7U9blVo3TG/ R4g6aOVoCDqowQCgWF6BY18JmeYLw+qM6Y+csYZs+Sid2qqs9Zp+7az0519uDIriHDGT gcqezVgTPF8trMri9ZKdArv6hVI9oMjGbfjSnP0bDwzQyZX5FnAaeWvNBgG0CIghyyhs ILeF5eIp05PVXZ1RazB4Rm9oCYKv5a02WjeYFsylcUQcf1lwIGzn5MLcJRQ9wCO5DXJI W7zw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id g41-v6si1701104qtk.195.2018.06.04.00.13.26 for (version=TLS1 cipher=AES128-SHA bits=128/128); Mon, 04 Jun 2018 00:13:26 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1]:37948 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fPjgD-0007G4-QC for patch@linaro.org; Mon, 04 Jun 2018 03:13:25 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41431) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fPjdw-0006Uh-07 for qemu-devel@nongnu.org; Mon, 04 Jun 2018 03:11:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fPjdt-0003JS-JO for qemu-devel@nongnu.org; Mon, 04 Jun 2018 03:11:03 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:54624 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fPjdt-0003JG-EO for qemu-devel@nongnu.org; Mon, 04 Jun 2018 03:11:01 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 14501401EF0F; Mon, 4 Jun 2018 07:11:01 +0000 (UTC) Received: from lemon.usersys.redhat.com (ovpn-12-26.pek2.redhat.com [10.72.12.26]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9914A2026DEF; Mon, 4 Jun 2018 07:10:59 +0000 (UTC) From: Fam Zheng To: qemu-devel@nongnu.org Date: Mon, 4 Jun 2018 15:10:49 +0800 Message-Id: <20180604071050.12492-2-famz@redhat.com> In-Reply-To: <20180604071050.12492-1-famz@redhat.com> References: <20180604071050.12492-1-famz@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Mon, 04 Jun 2018 07:11:01 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Mon, 04 Jun 2018 07:11:01 +0000 (UTC) for IP:'10.11.54.4' DOMAIN:'int-mx04.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'famz@redhat.com' RCPT:'' X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 66.187.233.73 Subject: [Qemu-devel] [PULL 1/2] tests/docker/Makefile.include: handle empty TARGET_LIST X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Alex Bennée If the user doesn't specify a TARGET_LIST they get the current configuration but with spaces and hilarity ensues. This adds some make magic to turn the TARGET_LIST back into a comma separated list. Signed-off-by: Alex Bennée Message-Id: <20180521103504.26432-1-alex.bennee@linaro.org> Signed-off-by: Fam Zheng --- rules.mak | 3 +++ tests/docker/Makefile.include | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) -- 2.17.0 diff --git a/rules.mak b/rules.mak index 04c7f74d07..bbb2667928 100644 --- a/rules.mak +++ b/rules.mak @@ -1,4 +1,7 @@ +# These are used when we want to do substitutions without confusing Make +NULL := +SPACE := $(NULL) # COMMA := , # Don't use implicit rules or variables diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include index 31f21a43f5..9d5749887a 100644 --- a/tests/docker/Makefile.include +++ b/tests/docker/Makefile.include @@ -140,7 +140,7 @@ docker-run: docker-qemu-src $(if $V,,--rm) \ $(if $(DEBUG),-ti,) \ $(if $(NETWORK),$(if $(subst $(NETWORK),,1),--net=$(NETWORK)),--net=none) \ - -e TARGET_LIST=$(TARGET_LIST) \ + -e TARGET_LIST=$(subst $(SPACE),$(COMMA),$(TARGET_LIST)) \ -e EXTRA_CONFIGURE_OPTS="$(EXTRA_CONFIGURE_OPTS)" \ -e V=$V -e J=$J -e DEBUG=$(DEBUG) \ -e SHOW_ENV=$(SHOW_ENV) \