From patchwork Wed May 5 13:59:37 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 431323 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B75EC433B4 for ; Wed, 5 May 2021 14:01:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0910D613AA for ; Wed, 5 May 2021 14:01:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233641AbhEEOCx (ORCPT ); Wed, 5 May 2021 10:02:53 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:54816 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233639AbhEEOCx (ORCPT ); Wed, 5 May 2021 10:02:53 -0400 Received: from mail-qk1-f199.google.com ([209.85.222.199]) by youngberry.canonical.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1leI67-0008Pp-Gf for devicetree@vger.kernel.org; Wed, 05 May 2021 14:01:55 +0000 Received: by mail-qk1-f199.google.com with SMTP id d15-20020a05620a136fb02902e9e93c69c8so1161749qkl.23 for ; Wed, 05 May 2021 07:01:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=oHaAGMQCQ1pAj//qWoQI8DKNyR6P/lkpmRo6s3ewDIo=; b=XNO3cBMHgiQF8oiueuolJL9Svodf5rTFWo2qZ9Gu5cZWh792BSk5g8fSdJOMSyH8xq sCFOZDAhOLopVqOnJ2AqfNWPHu/i42lhoN8GszPVctuzXOejAsgEA/bgLjYR2Rk/yz+q uIh7ckniBligoXNDdLE2Ar8w/Hh8OayzEGov4sjWKummLeT2R7I2IhntNE7L6fyPEdw1 ITqN5r0J7Vf2aWsHOk4Tke+fQXWYptzpYGNXFrE7n6qivK1SXstR5TBl7bxTb16hKB8U lYLXWA0tXG9Wn4YIb6l8WBjTpl3+D+fqRfmdEKVvUKY1PxBhTWvGhJRjlfiWGWrzd7Z/ OCsA== X-Gm-Message-State: AOAM531LURhG4MYYHFQsrIEtnreUtTKvbAxrR9npW6NYwrtYstc5g5D3 KTPvXlytsltQUINSFIxokYlOybmq1Wb+1781Zp1k3uNafax4ZPzHrEjOH9Dbgbn38Ak1u8aR5ID BCVpIo8LXKqiST0ywbnx6n2t+Yl3ogt0sPkNZ1WA= X-Received: by 2002:a37:a6c6:: with SMTP id p189mr22057992qke.161.1620223314629; Wed, 05 May 2021 07:01:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzU763cPQ1xdHbff6dt62YRnHTN6UDqkMUU+zw0J+G/5UkccrdKaat1ubNv8PZ2xanVeRFnkw== X-Received: by 2002:a37:a6c6:: with SMTP id p189mr22057979qke.161.1620223314451; Wed, 05 May 2021 07:01:54 -0700 (PDT) Received: from localhost.localdomain ([45.237.49.2]) by smtp.gmail.com with ESMTPSA id 97sm5016632qte.20.2021.05.05.07.01.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 May 2021 07:01:53 -0700 (PDT) From: Krzysztof Kozlowski To: Rob Herring , Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/5] ARM: dts: exynos: align Broadcom WiFi with dtschema Date: Wed, 5 May 2021 09:59:37 -0400 Message-Id: <20210505135941.59898-1-krzysztof.kozlowski@canonical.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org The Broadcom BCM4329 family dtschema expects devices to be compatible also with brcm,bcm4329-fmac: arch/arm/boot/dts/exynos3250-rinato.dt.yaml: wifi@1: compatible: 'oneOf' conditional failed, one must be fixed: ['brcm,bcm4334-fmac'] is too short 'brcm,bcm4329-fmac' was expected Signed-off-by: Krzysztof Kozlowski --- arch/arm/boot/dts/exynos3250-rinato.dts | 2 +- arch/arm/boot/dts/exynos4210-i9100.dts | 2 +- arch/arm/boot/dts/exynos4210-trats.dts | 2 +- arch/arm/boot/dts/exynos4210-universal_c210.dts | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot/dts/exynos3250-rinato.dts b/arch/arm/boot/dts/exynos3250-rinato.dts index c52b9cf4f74c..f6ba5e426040 100644 --- a/arch/arm/boot/dts/exynos3250-rinato.dts +++ b/arch/arm/boot/dts/exynos3250-rinato.dts @@ -653,7 +653,7 @@ &mshc_1 { mmc-pwrseq = <&wlan_pwrseq>; brcmf: wifi@1 { - compatible = "brcm,bcm4334-fmac"; + compatible = "brcm,bcm4334-fmac", "brcm,bcm4329-fmac"; reg = <1>; interrupt-parent = <&gpx1>; diff --git a/arch/arm/boot/dts/exynos4210-i9100.dts b/arch/arm/boot/dts/exynos4210-i9100.dts index 525ff3d2fac3..db70f62cc08f 100644 --- a/arch/arm/boot/dts/exynos4210-i9100.dts +++ b/arch/arm/boot/dts/exynos4210-i9100.dts @@ -806,7 +806,7 @@ &sdhci_3 { pinctrl-0 = <&sd3_clk>, <&sd3_cmd>, <&sd3_bus4>; brcmf: wifi@1 { - compatible = "brcm,bcm4330-fmac"; + compatible = "brcm,bcm4330-fmac", "brcm,bcm4329-fmac"; reg = <1>; interrupt-parent = <&gpx2>; diff --git a/arch/arm/boot/dts/exynos4210-trats.dts b/arch/arm/boot/dts/exynos4210-trats.dts index d2406c9146b8..3eb8df319246 100644 --- a/arch/arm/boot/dts/exynos4210-trats.dts +++ b/arch/arm/boot/dts/exynos4210-trats.dts @@ -521,7 +521,7 @@ &sdhci_3 { pinctrl-0 = <&sd3_clk>, <&sd3_cmd>, <&sd3_bus4>; brcmf: wifi@1 { - compatible = "brcm,bcm4330-fmac"; + compatible = "brcm,bcm4330-fmac", "brcm,bcm4329-fmac"; reg = <1>; interrupt-parent = <&gpx2>; diff --git a/arch/arm/boot/dts/exynos4210-universal_c210.dts b/arch/arm/boot/dts/exynos4210-universal_c210.dts index dd44ad2c6ad6..f052853244a4 100644 --- a/arch/arm/boot/dts/exynos4210-universal_c210.dts +++ b/arch/arm/boot/dts/exynos4210-universal_c210.dts @@ -614,7 +614,7 @@ &sdhci_3 { pinctrl-0 = <&sd3_clk>, <&sd3_cmd>, <&sd3_bus4>; brcmf: wifi@1 { - compatible = "brcm,bcm4330-fmac"; + compatible = "brcm,bcm4330-fmac", "brcm,bcm4329-fmac"; reg = <1>; interrupt-parent = <&gpx2>; interrupts = <5 IRQ_TYPE_LEVEL_HIGH>; From patchwork Wed May 5 13:59:39 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 431322 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C797C433B4 for ; Wed, 5 May 2021 14:02:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 57C87613AA for ; Wed, 5 May 2021 14:02:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233717AbhEEODN (ORCPT ); Wed, 5 May 2021 10:03:13 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:54837 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233690AbhEEODL (ORCPT ); Wed, 5 May 2021 10:03:11 -0400 Received: from mail-qk1-f199.google.com ([209.85.222.199]) by youngberry.canonical.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1leI6Q-0008Sa-1X for devicetree@vger.kernel.org; Wed, 05 May 2021 14:02:14 +0000 Received: by mail-qk1-f199.google.com with SMTP id i62-20020a3786410000b02902e4f9ff4af8so1188486qkd.8 for ; Wed, 05 May 2021 07:02:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=PTU4LvKoIv4gbIfQl210SnqkxjG4gaXmVLweqPSDUqI=; b=oc0IamVtswVHKQJzS0SAKayk6hjpAr3BoS0Lov0NqcRftWL6S5X43cp54LqoA1BuCI o5JFSdiJHjv/2iOdbYdywdJyllwQ0MFUD7NKBnp5LRlvMHoYympOlsF9B0bFecx6yDRX NJonPIv+geQsk3chysqbRizNqFX9Xz59NziQvLWp3yNqdxPuWn1AaJgmkzHNsoFNR66j q6jnEGY1pykfGYE2vgBP6J36LiE6hub1wPTkcUVHv5k9j58aJSbaBRYRWb9TX8E+/01G MqBgTkEBvVjrAKue+ad8rbvHLGtL6xwopJLasSUHMkTRwVTyeZ2A7zvAWJlOWpCtIQlj YkQg== X-Gm-Message-State: AOAM530Lp2CnES5jXsEH+h0d2L8kx4yb8Hcf9UJtA/rBMHyjooXw04RP BwcYyHShr3JALtZHi3jAVRvj2/cPvq8wbETgwwDcZbrBsTOfILhn+ft8QB5DN9wZzzLBeCJzVLa rBdTZvct8qmRnw8InUVpopfv+DqWx4TqOq09iRJA= X-Received: by 2002:a37:a6c6:: with SMTP id p189mr22059577qke.161.1620223333157; Wed, 05 May 2021 07:02:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwNcZdZr9OarCUN7JS5MpdDZOe89c0ANjh7iN+CrZx0Za+sQThYLZ0fXL8V4Op7GS3d+n0c6Q== X-Received: by 2002:a37:a6c6:: with SMTP id p189mr22059565qke.161.1620223333014; Wed, 05 May 2021 07:02:13 -0700 (PDT) Received: from localhost.localdomain ([45.237.49.2]) by smtp.gmail.com with ESMTPSA id 97sm5016632qte.20.2021.05.05.07.02.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 May 2021 07:02:12 -0700 (PDT) From: Krzysztof Kozlowski To: Rob Herring , Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/5] ARM: dts: exynos: fix PWM LED max brightness on Odroid XU/XU3 Date: Wed, 5 May 2021 09:59:39 -0400 Message-Id: <20210505135941.59898-3-krzysztof.kozlowski@canonical.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210505135941.59898-1-krzysztof.kozlowski@canonical.com> References: <20210505135941.59898-1-krzysztof.kozlowski@canonical.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org There is no "max_brightness" property. This brings the intentional brightness reduce of green LED and dtschema checks as well: arch/arm/boot/dts/exynos5410-odroidxu.dt.yaml: led-controller-1: led-1: 'max-brightness' is a required property Fixes: 719f39fec586 ("ARM: dts: exynos5422-odroidxu3: Hook up PWM and use it for LEDs") Signed-off-by: Krzysztof Kozlowski --- arch/arm/boot/dts/exynos54xx-odroidxu-leds.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/exynos54xx-odroidxu-leds.dtsi b/arch/arm/boot/dts/exynos54xx-odroidxu-leds.dtsi index 2fc3e86dc5f7..982752e1df24 100644 --- a/arch/arm/boot/dts/exynos54xx-odroidxu-leds.dtsi +++ b/arch/arm/boot/dts/exynos54xx-odroidxu-leds.dtsi @@ -22,7 +22,7 @@ led-1 { * Green LED is much brighter than the others * so limit its max brightness */ - max_brightness = <127>; + max-brightness = <127>; linux,default-trigger = "mmc0"; }; @@ -30,7 +30,7 @@ led-2 { label = "blue:heartbeat"; pwms = <&pwm 2 2000000 0>; pwm-names = "pwm2"; - max_brightness = <255>; + max-brightness = <255>; linux,default-trigger = "heartbeat"; }; }; From patchwork Wed May 5 13:59:41 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 431321 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C14DCC433ED for ; Wed, 5 May 2021 14:02:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 99FF6613AA for ; Wed, 5 May 2021 14:02:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233706AbhEEODd (ORCPT ); Wed, 5 May 2021 10:03:33 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:54856 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233745AbhEEODU (ORCPT ); Wed, 5 May 2021 10:03:20 -0400 Received: from mail-qk1-f199.google.com ([209.85.222.199]) by youngberry.canonical.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1leI6Z-0008Uz-A0 for devicetree@vger.kernel.org; Wed, 05 May 2021 14:02:23 +0000 Received: by mail-qk1-f199.google.com with SMTP id n2-20020a37a4020000b02902e9aef597f7so1160036qke.21 for ; Wed, 05 May 2021 07:02:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=aFybNoYvXXuMhUMueJoFGIOzsnT8VCCuO9x/0O6WW3Q=; b=e/rb8P4DkcCgvENmQl+P2pyl0XVIaX7zjZsGSw7PEKj2ZCl5l6v1r4M2amgkCuHUaM m9lrunnbue6bRfxXrAAXE8jYHwKkSOn7AKnBm54HeWRgGHGFcM1lL0+VzDFHHZpP66/E sISIQVE1Gb3Pl3pFA+RWXV4dTrfDwj3aAzk5j06+vb0VXFVK6SfEcBlQpSp8z0PMvaQW 7g0KA0yHiDK7ssfHtJXEBzlgTncJo0z/bFmjd/aC8wFPbaLut2ImIIWN1PC6s4P3GR2G YZ+9CsRup86KJVSSUO+CGTzhQRZlEKiALjuw9nyC7coZ8WqcU1FI6kqtsYalhyX49FIy pcaw== X-Gm-Message-State: AOAM532BCCWDFURWgeyXZvFm9lndBYVTpORvpncnF5Ia058QAxC8y+L9 ljRTbYSOClOSdl+++Jp1deY72N8Qo2HwS9U6b2FVpx9EiRXyN984RbO2ADnhhSA/QNyGPJIjKUl tncmbqWLhvCHy8Zpbey9m6DzbSSWatBtnysBFBW4= X-Received: by 2002:a05:620a:4008:: with SMTP id h8mr30402488qko.366.1620223339500; Wed, 05 May 2021 07:02:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxIh64S24rt8pIj4QLk85n1rPZ1rAb4wDfcLPTkMNb4AjA8b8DYcHICmN8fDtMnm0CAKo0PHQ== X-Received: by 2002:a05:620a:4008:: with SMTP id h8mr30402338qko.366.1620223337602; Wed, 05 May 2021 07:02:17 -0700 (PDT) Received: from localhost.localdomain ([45.237.49.2]) by smtp.gmail.com with ESMTPSA id 97sm5016632qte.20.2021.05.05.07.02.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 May 2021 07:02:16 -0700 (PDT) From: Krzysztof Kozlowski To: Rob Herring , Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 5/5] ARM: dts: exynos: fix PWM LED max brightness on Odroid XU4 Date: Wed, 5 May 2021 09:59:41 -0400 Message-Id: <20210505135941.59898-5-krzysztof.kozlowski@canonical.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210505135941.59898-1-krzysztof.kozlowski@canonical.com> References: <20210505135941.59898-1-krzysztof.kozlowski@canonical.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org There is no "max_brightness" property as pointed out by dtschema: arch/arm/boot/dts/exynos5422-odroidxu4.dt.yaml: led-controller: led-1: 'max-brightness' is a required property Fixes: 6658356014cb ("ARM: dts: Add support Odroid XU4 board for exynos5422-odroidxu4") Signed-off-by: Krzysztof Kozlowski --- arch/arm/boot/dts/exynos5422-odroidxu4.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/exynos5422-odroidxu4.dts b/arch/arm/boot/dts/exynos5422-odroidxu4.dts index ede782257643..1c24f9b35973 100644 --- a/arch/arm/boot/dts/exynos5422-odroidxu4.dts +++ b/arch/arm/boot/dts/exynos5422-odroidxu4.dts @@ -24,7 +24,7 @@ led-1 { label = "blue:heartbeat"; pwms = <&pwm 2 2000000 0>; pwm-names = "pwm2"; - max_brightness = <255>; + max-brightness = <255>; linux,default-trigger = "heartbeat"; }; };