From patchwork Thu Jul 5 12:55:50 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christophe Lyon X-Patchwork-Id: 141118 Delivered-To: patch@linaro.org Received: by 2002:a2e:9754:0:0:0:0:0 with SMTP id f20-v6csp1907333ljj; Thu, 5 Jul 2018 05:56:19 -0700 (PDT) X-Google-Smtp-Source: AAOMgpeMAkly1bdISo+yLrP0n+e1CaohuJqiXyjtRObUjKJkUADwiRBQxMrILEUhUXcT8ZpG2LlN X-Received: by 2002:a65:5c83:: with SMTP id a3-v6mr5573553pgt.164.1530795379181; Thu, 05 Jul 2018 05:56:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530795379; cv=none; d=google.com; s=arc-20160816; b=aDX8jFuVLxOZdXOnK27gzJrOADT7hHpwff0eL02kTiiiA+11mtvr0R9B5kNa7IPy2H wFj56LNxpWb4LtxIJGzYqG0bO3yW548p9CybtpbS0o/SM68iVaWuWoNaGlX1VVqw02rt osv4o7yEeYOpkDNOQP637+icf0BFng23GT8eFIo6R0oFj1Z1c9O3SQLmAP0xZ5ZKM62Y UT5v5zb4oGb9xqY/c+hoHlM7oXHJR+gHTMOhW9S7KI276oC6+JANIyLSqo2Ok00TLsDm IhAoMQTyermH7KxKZa1/bRaS+JpFvNTCAO4vN+ZEOjSmKJxW8GVkuWMMhu1cyT/AFZat PzJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=to:subject:message-id:date:from:mime-version:dkim-signature :delivered-to:sender:list-help:list-post:list-archive:list-subscribe :list-unsubscribe:list-id:precedence:mailing-list:dkim-signature :domainkey-signature:arc-authentication-results; bh=3DXCq74l1fO+aw7fYvpuhtbZT30vsCD2V6BsfeZhDXA=; b=uBqTjFQjVnPSdxkS2QfMXgnFCp6sV63oep+ELlBM0sTBll3Y4kTQ0yCcthBfF+I4lv Ne5Ec5UcLlPXjkVHJjVwk7KZuI38W7uy8P99pkVtFtxpm8zKTVXL5SKTfq5UODUGdOmn CeuIkjDwU0uiuTp/B9cfo3f6rgyxjaMsPYxHdsfS/B8qZVGJRkeVoQ+43l4Sinsi0/XL 0L4Vkip069pxEA+/LKsqLJg4m1cN3BnvUAHofp4yqYyhcGGAZXdkIeTWR2JaBresVyPW 5tcNvYLYh5fAnMYXA1h2jPWly3SkOdA9AKyVpKmbB1UbFx/81UoKgVGR4GnfQoyGykOd aZ+Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=mba+U0Dw; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=X4uWrjy6; spf=pass (google.com: domain of binutils-return-102349-patch=linaro.org@sourceware.org designates 209.132.180.131 as permitted sender) smtp.mailfrom="binutils-return-102349-patch=linaro.org@sourceware.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from sourceware.org (server1.sourceware.org. [209.132.180.131]) by mx.google.com with ESMTPS id t13-v6si5693510pgs.661.2018.07.05.05.56.18 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 05 Jul 2018 05:56:19 -0700 (PDT) Received-SPF: pass (google.com: domain of binutils-return-102349-patch=linaro.org@sourceware.org designates 209.132.180.131 as permitted sender) client-ip=209.132.180.131; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=mba+U0Dw; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=X4uWrjy6; spf=pass (google.com: domain of binutils-return-102349-patch=linaro.org@sourceware.org designates 209.132.180.131 as permitted sender) smtp.mailfrom="binutils-return-102349-patch=linaro.org@sourceware.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:mime-version:from:date:message-id:subject:to :content-type; q=dns; s=default; b=BsENChvJUq2kA3sGgFsIjEkfGakAv beAyxVwFkcTXTuU/fr3GoA5z5rDKz4lhigq1tmeUxFB7A+GS/dH3LNfgOXXscM+0 FD4FBOyKeMUXhEhGqOkei3sxDOWmCccreYqUNxsssF4nMDxLjGMHExyMF6HBv8F0 mTMUoOk/oUC6CM= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:mime-version:from:date:message-id:subject:to :content-type; s=default; bh=waQ1oqeYyeqJiNMYbpamh3TxFvU=; b=mba +U0Dwo1wfGzB9IZwOnJ0pkrUnZmh51C811kqjjzrHFweZSuPe9wRxkaxQKVS+p4x ap5PtTcuG94nDjTtkM5SD9uJ5hen711XbsZkMLujwScWp5l0MwC9E1OIJxBJdNG2 F932NY+b2s3eL3bXrz+sHvdLkkLx7SoTFysjBxBU= Received: (qmail 127709 invoked by alias); 5 Jul 2018 12:56:06 -0000 Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org Delivered-To: mailing list binutils@sourceware.org Received: (qmail 127592 invoked by uid 89); 5 Jul 2018 12:56:05 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-25.2 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-ua0-f180.google.com Received: from mail-ua0-f180.google.com (HELO mail-ua0-f180.google.com) (209.85.217.180) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 05 Jul 2018 12:56:04 +0000 Received: by mail-ua0-f180.google.com with SMTP id v15-v6so5325116ual.11 for ; Thu, 05 Jul 2018 05:56:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:from:date:message-id:subject:to; bh=ldechH/kTgMPxovShfau/ksC0QsLKI9x9ZQsHQ8ZG6w=; b=X4uWrjy6xacRiZnjR0HxlbSIHEr/h7AAz8EXwtcD//mI9YVg9cGyAEiuFCnm+6GrJx 2yas0xX9EGnCcgGq/68GD8JBeHmBvwCjLYGTmeLve9dTujl5Z401egQmwqc+X9TRtYiy +Q0duuorU8rKyFNC5zH3q9gRRtVFz/33sKteA= MIME-Version: 1.0 From: Christophe Lyon Date: Thu, 5 Jul 2018 14:55:50 +0200 Message-ID: Subject: [ARM] Fix warning cannot find thumb start symbol To: binutils X-IsSubscribed: yes Hi, In case params.thumb_entry_symbol has its default NULL value, using it to print a warning in gld${EMULATION_NAME}_finish results in a crash. Use h->root.string instead which either points to params.thumb_entry_symbol name or to entry_symbol name. OK? Thanks, Christophe 2018-07-05 Christophe Lyon * emultempl/armelf.em (gld${EMULATION_NAME}_finish): Use the right symbol name in case of warning. diff --git a/ld/emultempl/armelf.em b/ld/emultempl/armelf.em index 2d98064..8ceceda 100644 --- a/ld/emultempl/armelf.em +++ b/ld/emultempl/armelf.em @@ -499,7 +499,7 @@ gld${EMULATION_NAME}_finish (void) } else einfo (_("%P: warning: cannot find thumb start symbol %s\n"), - params.thumb_entry_symbol); + h->root.string); } /* This is a convenient point to tell BFD about target specific flags.