From patchwork Thu May 4 14:00:07 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Github ODP bot X-Patchwork-Id: 98541 Delivered-To: patch@linaro.org Received: by 10.140.89.200 with SMTP id v66csp602187qgd; Thu, 4 May 2017 07:01:02 -0700 (PDT) X-Received: by 10.237.61.28 with SMTP id g28mr10449869qtf.279.1493906462017; Thu, 04 May 2017 07:01:02 -0700 (PDT) Return-Path: Received: from lists.linaro.org (lists.linaro.org. [54.225.227.206]) by mx.google.com with ESMTP id q32si1958288qtf.42.2017.05.04.07.01.01; Thu, 04 May 2017 07:01:01 -0700 (PDT) Received-SPF: pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) client-ip=54.225.227.206; Authentication-Results: mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=yandex.ru Received: by lists.linaro.org (Postfix, from userid 109) id 1B77560764; Thu, 4 May 2017 14:01:01 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ip-10-142-244-252 X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW autolearn=disabled version=3.4.0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id 92FDE60839; Thu, 4 May 2017 14:00:31 +0000 (UTC) X-Original-To: lng-odp@lists.linaro.org Delivered-To: lng-odp@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id 481446068C; Thu, 4 May 2017 14:00:27 +0000 (UTC) Received: from forward2o.cmail.yandex.net (forward2o.cmail.yandex.net [37.9.109.243]) by lists.linaro.org (Postfix) with ESMTPS id 3CF736068C for ; Thu, 4 May 2017 14:00:25 +0000 (UTC) Received: from smtp1p.mail.yandex.net (smtp1p.mail.yandex.net [IPv6:2a02:6b8:0:1472:2741:0:8b6:6]) by forward2o.cmail.yandex.net (Yandex) with ESMTP id 1F2FA2101E for ; Thu, 4 May 2017 17:00:24 +0300 (MSK) Received: from smtp1p.mail.yandex.net (localhost.localdomain [127.0.0.1]) by smtp1p.mail.yandex.net (Yandex) with ESMTP id BAF831780965 for ; Thu, 4 May 2017 17:00:23 +0300 (MSK) Received: by smtp1p.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id tLSuFTTX2g-0MBeAqXK; Thu, 04 May 2017 17:00:22 +0300 (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (Client certificate not present) X-Yandex-Suid-Status: 1 0 From: Github ODP bot To: lng-odp@lists.linaro.org Date: Thu, 4 May 2017 17:00:07 +0300 Message-Id: <1493906407-1542-3-git-send-email-odpbot@yandex.ru> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1493906407-1542-1-git-send-email-odpbot@yandex.ru> References: <1493906407-1542-1-git-send-email-odpbot@yandex.ru> Github-pr-num: 13 Subject: [lng-odp] [PATCH API-NEXT v1 1/2] api: ipsec: mark odp_ipsec_sa_create argument as constant X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: "The OpenDataPlane \(ODP\) List" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: lng-odp-bounces@lists.linaro.org Sender: "lng-odp" From: Dmitry Eremin-Solenikov odp_ipsec_sa_create() should not change its argument. Thus mark it as a constant. Signed-off-by: Dmitry Eremin-Solenikov --- /** Email created from pull request 13 (lumag:ipsec-api) ** https://github.com/Linaro/odp/pull/13 ** Patch: https://github.com/Linaro/odp/pull/13.patch ** Base sha: 0707c974ed19c859fb92778c35a2f92bf7cd9fc6 ** Merge commit sha: 8c3d82b1d53b887105589a72b247f5808bceb132 **/ include/odp/api/spec/ipsec.h | 2 +- platform/linux-generic/odp_ipsec.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/odp/api/spec/ipsec.h b/include/odp/api/spec/ipsec.h index cccb3b3..4f746f6 100644 --- a/include/odp/api/spec/ipsec.h +++ b/include/odp/api/spec/ipsec.h @@ -773,7 +773,7 @@ void odp_ipsec_sa_param_init(odp_ipsec_sa_param_t *param); * * @see odp_ipsec_sa_param_init() */ -odp_ipsec_sa_t odp_ipsec_sa_create(odp_ipsec_sa_param_t *param); +odp_ipsec_sa_t odp_ipsec_sa_create(const odp_ipsec_sa_param_t *param); /** * Disable IPSEC SA diff --git a/platform/linux-generic/odp_ipsec.c b/platform/linux-generic/odp_ipsec.c index 5eb1be3..10918df 100644 --- a/platform/linux-generic/odp_ipsec.c +++ b/platform/linux-generic/odp_ipsec.c @@ -52,7 +52,7 @@ void odp_ipsec_sa_param_init(odp_ipsec_sa_param_t *param) memset(param, 0, sizeof(odp_ipsec_sa_param_t)); } -odp_ipsec_sa_t odp_ipsec_sa_create(odp_ipsec_sa_param_t *param) +odp_ipsec_sa_t odp_ipsec_sa_create(const odp_ipsec_sa_param_t *param) { (void)param; From patchwork Thu May 4 14:00:06 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Github ODP bot X-Patchwork-Id: 98542 Delivered-To: patch@linaro.org Received: by 10.140.89.200 with SMTP id v66csp602637qgd; Thu, 4 May 2017 07:01:37 -0700 (PDT) X-Received: by 10.55.161.14 with SMTP id k14mr8360315qke.33.1493906497401; Thu, 04 May 2017 07:01:37 -0700 (PDT) Return-Path: Received: from lists.linaro.org (lists.linaro.org. [54.225.227.206]) by mx.google.com with ESMTP id x127si1888376qkb.45.2017.05.04.07.01.37; Thu, 04 May 2017 07:01:37 -0700 (PDT) Received-SPF: pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) client-ip=54.225.227.206; Authentication-Results: mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=yandex.ru Received: by lists.linaro.org (Postfix, from userid 109) id 01AEC60A31; Thu, 4 May 2017 14:01:36 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ip-10-142-244-252 X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW autolearn=disabled version=3.4.0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id CEE2E60A0A; Thu, 4 May 2017 14:00:32 +0000 (UTC) X-Original-To: lng-odp@lists.linaro.org Delivered-To: lng-odp@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id 0D0AB60A08; Thu, 4 May 2017 14:00:30 +0000 (UTC) Received: from forward2o.cmail.yandex.net (forward2o.cmail.yandex.net [37.9.109.243]) by lists.linaro.org (Postfix) with ESMTPS id 329C360731 for ; Thu, 4 May 2017 14:00:24 +0000 (UTC) Received: from smtp1p.mail.yandex.net (smtp1p.mail.yandex.net [77.88.29.84]) by forward2o.cmail.yandex.net (Yandex) with ESMTP id A001F2076A for ; Thu, 4 May 2017 17:00:22 +0300 (MSK) Received: from smtp1p.mail.yandex.net (localhost.localdomain [127.0.0.1]) by smtp1p.mail.yandex.net (Yandex) with ESMTP id 0A7781780795 for ; Thu, 4 May 2017 17:00:21 +0300 (MSK) Received: by smtp1p.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id tLSuFTTX2g-0LB4jZQj; Thu, 04 May 2017 17:00:21 +0300 (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (Client certificate not present) X-Yandex-Suid-Status: 1 0 From: Github ODP bot To: lng-odp@lists.linaro.org Date: Thu, 4 May 2017 17:00:06 +0300 Message-Id: <1493906407-1542-2-git-send-email-odpbot@yandex.ru> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1493906407-1542-1-git-send-email-odpbot@yandex.ru> References: <1493906407-1542-1-git-send-email-odpbot@yandex.ru> Github-pr-num: 13 Subject: [lng-odp] [PATCH API-NEXT v1 2/2] api: ipsec: make num_pkt/out/sa/opt unsigned X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: "The OpenDataPlane \(ODP\) List" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: lng-odp-bounces@lists.linaro.org Sender: "lng-odp" From: Dmitry Eremin-Solenikov It does not make sense to specify negative amount inside num_*. Make respective fields unsigned instead. Signed-off-by: Dmitry Eremin-Solenikov --- /** Email created from pull request 13 (lumag:ipsec-api) ** https://github.com/Linaro/odp/pull/13 ** Patch: https://github.com/Linaro/odp/pull/13.patch ** Base sha: 0707c974ed19c859fb92778c35a2f92bf7cd9fc6 ** Merge commit sha: 8c3d82b1d53b887105589a72b247f5808bceb132 **/ include/odp/api/spec/ipsec.h | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/include/odp/api/spec/ipsec.h b/include/odp/api/spec/ipsec.h index e83494d..cccb3b3 100644 --- a/include/odp/api/spec/ipsec.h +++ b/include/odp/api/spec/ipsec.h @@ -910,7 +910,7 @@ typedef struct odp_ipsec_op_status_t { */ typedef struct odp_ipsec_op_param_t { /** Number of packets to be processed */ - int num_pkt; + unsigned num_pkt; /** Number of SAs * @@ -919,7 +919,7 @@ typedef struct odp_ipsec_op_param_t { * * 1: Single SA for all packets * * num_pkt: SA per packet */ - int num_sa; + unsigned num_sa; /** Number of operation options * @@ -928,7 +928,7 @@ typedef struct odp_ipsec_op_param_t { * * 1: Single option for all packets * * num_pkt: An option per packet */ - int num_opt; + unsigned num_opt; /** Pointer to an array of packets * @@ -1000,7 +1000,7 @@ typedef struct odp_ipsec_packet_result_t { * fragments. All the fragments (of the same source packet) are stored * consecutively in the 'pkt' array. */ - int num_out; + unsigned num_out; /** IPSEC SA that was used to create the packet * @@ -1041,7 +1041,7 @@ typedef struct odp_ipsec_op_result_t { * The operation updates it with the actual number of packets * outputted. */ - int num_pkt; + unsigned num_pkt; /** Pointer to an array of packets *