From patchwork Wed Jul 25 09:55:57 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Anders Roxell X-Patchwork-Id: 142852 Delivered-To: patch@linaro.org Received: by 2002:a2e:9754:0:0:0:0:0 with SMTP id f20-v6csp606123ljj; Wed, 25 Jul 2018 02:56:10 -0700 (PDT) X-Google-Smtp-Source: AAOMgpfifFoo+T/ZrcCAjww3dYq/UzRz9Toedo6KvyHXhB18wfnoPeLYD5ksfDvyy3+EXdR51hzv X-Received: by 2002:a17:902:1703:: with SMTP id i3-v6mr20057751pli.263.1532512569975; Wed, 25 Jul 2018 02:56:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532512569; cv=none; d=google.com; s=arc-20160816; b=AxgiXFC5ZX33fhm48fnkLZ0An9nWk8HWh0l5thoovJKHBKmhpfDuSJNPNYgKqW74qC ZwnGVEi6bS4nzz3NY7/LGGqBaU1UqGv6r3GbypPXEol+JyMJnVpcN/+91qradhi84CAv gkC2dSugJfCw++E0pggozRu66pNS/Inc3Q6VoJzHoaLlIVc1eIO2hzdtrJDiz9rkCVdd jvNXiis724u+uBmbrxNboVgHOPyIp5Q2adZ7NKT9oI0zGq0AHJf+IwaaJ6s/BMEpcZRN IYeetk1ad5XsXgcq4Dhn5EjSdDerZkEPZLGyC4LAr/CucioViR04/8bd88IxBuB57yf2 zljA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=Cgw709ofsERJ+D62PUlElyHEPGhEDBMyoUL1H2Y3XZE=; b=g/ljcq9sPgKc1jlnFNSVCWZl9pv7so39Ulpah+dEHV02OxJR9Y0MTzai3dw/hG65n7 agZHNK5rwZwrWEC16Wmzzdgn1RLopa67/dogJ2KQunj0Ri3zu+BjfawHqEvbS2Q8nz3x yA45Os9LtHtrfTTMUKnioAdAabFrPiH2Ij/XOet63krVR/zxugIMt5Tg+4nE1ou4Nrv1 rbsUuWg03oiOR2LwiNv8X1xLBRMN6qwNFFxi+BeHxi2OeJ2tNJqPvAuDAOmwJYLsBPwc K5SAaVmaZAHIghMwDQPHP607ACba/OO/9wY6DHdQP9ww+UtlWUILHgl0u11Crvj3ZB6b jrng== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=SKCJWjnI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i184-v6si14272452pfg.250.2018.07.25.02.56.09; Wed, 25 Jul 2018 02:56:09 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=SKCJWjnI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728729AbeGYLHD (ORCPT + 31 others); Wed, 25 Jul 2018 07:07:03 -0400 Received: from mail-lj1-f196.google.com ([209.85.208.196]:36714 "EHLO mail-lj1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728527AbeGYLHC (ORCPT ); Wed, 25 Jul 2018 07:07:02 -0400 Received: by mail-lj1-f196.google.com with SMTP id u7-v6so6143638lji.3 for ; Wed, 25 Jul 2018 02:56:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Cgw709ofsERJ+D62PUlElyHEPGhEDBMyoUL1H2Y3XZE=; b=SKCJWjnIU3lyq4FYlmI7Zcr3CaG3RLKyCQt7Fdd1/0qKo/s0CYhN6Q5dhRQgVyK/VK gTHbR7WJZ/8W4O+7ETql2for2UZRuZnjSPW6+Boi3vL+uLVXXgyvOgnulpVxkoJUY6u8 5vBSc06QPEMTSjecbMk61N4XmES75ExnaR4TY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Cgw709ofsERJ+D62PUlElyHEPGhEDBMyoUL1H2Y3XZE=; b=daDYSu2TOkhXDP8WQMPftOAPvPdVxBpxZgfP0PmvWPQd2ksTiyO68gLIG3vKtkkU0/ KOc8ONCBr51tj1g7gK3uPEPb/2aObFoe3f1qkk+Hvn5dzUD5wkx147gvwxGouiJl0DZd NdjWU62G+4C4jrg3aBySff7KN7UZqODFucHhSBGzINaQe2eM1E9PulJ80mJLsTTfIPv1 bQbHqKa+UaavYUaN0ELlbDr0Zyis6oX0H3SrmwuUCrhfCYJ0gVHiV27I6agPGOsZa0sl wYUpkz0ibno6JBFM7vRyy8Q9jVV8n2VafDk0+jRRzZ/4r2yuZ7FbHcXJEqdHqdNsFMst 3PuA== X-Gm-Message-State: AOUpUlHXGXDOImoHfIWkVJ3cATVgSWBXItWR4jjX57y16c1l+X50/gVl QimuiLbcX0yr0Oq3tUL5zHckdw== X-Received: by 2002:a2e:4701:: with SMTP id u1-v6mr15487858lja.54.1532512564825; Wed, 25 Jul 2018 02:56:04 -0700 (PDT) Received: from localhost (c-2c3d70d5.07-21-73746f28.bbcust.telenor.se. [213.112.61.44]) by smtp.gmail.com with ESMTPSA id 20-v6sm2675198ljs.32.2018.07.25.02.56.03 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 25 Jul 2018 02:56:04 -0700 (PDT) From: Anders Roxell To: riel@surriel.com, peterz@infradead.org, mingo@kernel.org, songliubraving@fb.com, linux@armlinux.org.uk, dave.hansen@intel.com, x86@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Anders Roxell Subject: [PATCH] arm: asm/tlb.h: Fix build error implicit func declaration Date: Wed, 25 Jul 2018 11:55:57 +0200 Message-Id: <20180725095557.19668-1-anders.roxell@linaro.org> X-Mailer: git-send-email 2.18.0 MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Building on arm 32 with LPAE enabled we don't include asm-generic/tlb.h, where we have tlb_flush_remove_tables_local and tlb_flush_remove_tables defined. mm/memory.c: In function ‘tlb_remove_table_smp_sync’: mm/memory.c:339:2: error: implicit declaration of function ‘tlb_flush_remove_tables_local’; did you mean ‘tlb_remove_table’? [-Werror=implicit-function-declaration] tlb_flush_remove_tables_local(mm); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ tlb_remove_table mm/memory.c: In function ‘tlb_table_flush’: mm/memory.c:372:2: error: implicit declaration of function ‘tlb_flush_remove_tables’; did you mean ‘tlb_remove_table’? [-Werror=implicit-function-declaration] tlb_flush_remove_tables(tlb->mm); ^~~~~~~~~~~~~~~~~~~~~~~ tlb_remove_table To fix this issue we define them in arm 32's specific asm/tlb.h file. Fixes: 2ff6ddf19c0e ("x86/mm/tlb: Leave lazy TLB mode at page table free time") Signed-off-by: Anders Roxell --- Ingo, would it make sense for you to pick it up into the x86 tree since that contains the bug ? Cheers, Anders arch/arm/include/asm/tlb.h | 8 ++++++++ 1 file changed, 8 insertions(+) -- 2.18.0 diff --git a/arch/arm/include/asm/tlb.h b/arch/arm/include/asm/tlb.h index d5562f9ce600..f854148c8d7c 100644 --- a/arch/arm/include/asm/tlb.h +++ b/arch/arm/include/asm/tlb.h @@ -292,5 +292,13 @@ static inline void tlb_remove_check_page_size_change(struct mmu_gather *tlb, { } +static inline void tlb_flush_remove_tables(struct mm_struct *mm) +{ +} + +static inline void tlb_flush_remove_tables_local(void *arg) +{ +} + #endif /* CONFIG_MMU */ #endif