From patchwork Tue Jul 31 15:42:40 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cole Robinson X-Patchwork-Id: 143190 Delivered-To: patch@linaro.org Received: by 2002:a2e:9754:0:0:0:0:0 with SMTP id f20-v6csp5488317ljj; Tue, 31 Jul 2018 08:43:00 -0700 (PDT) X-Google-Smtp-Source: AAOMgpf8gmor/EvcG/6iUob7bFvRogrL52WZhCZdlHa6LkAPfG5sFziDrIEniTiWziqrPGdc9Tsc X-Received: by 2002:ac8:28bb:: with SMTP id i56-v6mr21143329qti.140.1533051780890; Tue, 31 Jul 2018 08:43:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533051780; cv=none; d=google.com; s=arc-20160816; b=lZc379t8CjtArGL11047d9qZCeht7YjLUtqaYmk7Wxt1SxSHXHv+yAXhQp0krPzyze Br7IJtYKlocN2dn8eyYYQpw7CsdmroZgWqX6qMzXqGjSrINTvDk3rM2BYcGEZyY8+3NY ohr2UIs+0w/U2Z+uJB8p2VqOPWrpsxLYa2XIRgW2zN1n23O4uZfHQxxgb14uYBBEVcxU 4p5iRagj8jnpUq9cuydg7/7vbXZTShrKHSGm8tkCVDmjZfgX6XDOG2WM1gBnYO5tXuz7 mypUhDAQPAEeq00nukAbg/biiH8pblAxfhmsFDPhOHpXIx20sLgbL00rWtx6HMzaHq/D sBXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:sender:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:message-id:date:to:from:delivered-to :arc-authentication-results; bh=ZYdnk+NK/IgRZksFwa2rkSn4Lwz+ZsIko8MnG5e102Q=; b=CG+ykod/GafGwh2wBtxhu7AQ86hHpwp5Jw2Oenegh83KJoIsJD8IDDnBGqZo7ZLUlW /cvhwpYIqtiLLqvnow+xSX8xukzDj4wjJQjj473VIu0hGm/dITeAjzSMNI4JvZEnqcdB qF9OQirFSs3N6ChfVC5op7xPWdQWALTNN0tjzMUYkpSp/0qGrmMmAcGp90LHmx1B6lb+ w/aKUbhPPfy78EvgZjEXraX3cdv0eWTnEw3OxXtUJTRj9vaPcRB2WmyF5wmXG1W068bc ICVM97LP4AyTYAb4OsU6xAoP42Gl9TndN05iAMlGpG2XVljk+nkfG2L2ab+ddgnLM0tY MVfA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of libvir-list-bounces@redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com. [209.132.183.28]) by mx.google.com with ESMTPS id w3-v6si14674341qth.350.2018.07.31.08.43.00 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 31 Jul 2018 08:43:00 -0700 (PDT) Received-SPF: pass (google.com: domain of libvir-list-bounces@redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; Authentication-Results: mx.google.com; spf=pass (google.com: domain of libvir-list-bounces@redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9AD98A4FA0; Tue, 31 Jul 2018 15:42:47 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3A5C5308BDD1; Tue, 31 Jul 2018 15:42:47 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 536D23F7FA; Tue, 31 Jul 2018 15:42:45 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w6VFghVr027290 for ; Tue, 31 Jul 2018 11:42:43 -0400 Received: by smtp.corp.redhat.com (Postfix) id 58F4810F1BE2; Tue, 31 Jul 2018 15:42:43 +0000 (UTC) Delivered-To: libvirt-list@redhat.com Received: from worklaptop.bos.redhat.com (dhcp-17-157.bos.redhat.com [10.18.17.157]) by smtp.corp.redhat.com (Postfix) with ESMTP id 36DE310F1BE0; Tue, 31 Jul 2018 15:42:41 +0000 (UTC) From: Cole Robinson To: libvirt-list@redhat.com Date: Tue, 31 Jul 2018 11:42:40 -0400 Message-Id: X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH] spec: Use %make_install X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.24 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Tue, 31 Jul 2018 15:43:00 +0000 (UTC) It's on RHEL7, saves a bit of typing, and lets us drop the comment Signed-off-by: Cole Robinson --- There's also a %make_build macro which handles smp_mflags, but it uses make -O which makes build output noisier at least libvirt.spec.in | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) -- 2.17.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list Reviewed-by: Martin Kletzander diff --git a/libvirt.spec.in b/libvirt.spec.in index 4113579e47..01f4e07b1c 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -1255,10 +1255,7 @@ rm -fr %{buildroot} export SOURCE_DATE_EPOCH=$(stat --printf='%Y' %{_specdir}/%{name}.spec) -# Avoid using makeinstall macro as it changes prefixes rather than setting -# DESTDIR. Newer make_install macro would be better but it's not available -# on RHEL 5, thus we need to expand it here. -make %{?_smp_mflags} install DESTDIR=%{?buildroot} SYSTEMD_UNIT_DIR=%{_unitdir} V=1 +%make_install %{?_smp_mflags} SYSTEMD_UNIT_DIR=%{_unitdir} V=1 make %{?_smp_mflags} -C examples distclean V=1