From patchwork Fri Aug 3 17:01:31 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Brown X-Patchwork-Id: 143427 Delivered-To: patch@linaro.org Received: by 2002:a2e:9754:0:0:0:0:0 with SMTP id f20-v6csp386434ljj; Fri, 3 Aug 2018 10:01:37 -0700 (PDT) X-Google-Smtp-Source: AAOMgpcfz1JxC5dN/JjB7NOhziVMIXlhlA5nEto6Os+3j4NvxLTC/WnN+aUzDYlBKXHA71gywaFx X-Received: by 2002:a5d:66c4:: with SMTP id k4-v6mr3105076wrw.154.1533315697666; Fri, 03 Aug 2018 10:01:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533315697; cv=none; d=google.com; s=arc-20160816; b=klxvtM2FeSfZisreFH5a2f200O+MKTMjsgbe1BDvZNq2Fp7Sg5Yb/92vTYt34jiN9O Ir05e8xj+AY1lqSTp2lq7mKesak5geLyPjLJlEeT33iPxZ+n4Atsbw1UyIhJc36+bbyF abagGsHAWqwvTvi2kMC4PH+W8h1zq1905UH+SgEM7JCiN1+SrSA45hot/QwdOUO2vpS0 fhOT4cBrsMvA7PWxfqC+NwESEUcup5DmXM7fHipFw1kHnKJil7/RVVDC3BSjfRqVK+Yi 9HGer8BERkvoAwnt2fexLPpJOH19LBnMv35rXWY519x3PGI/++vK4eFe96fGdHFpsbtq 0xgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:cc:date:message-id:in-reply-to:to:from :dkim-signature:delivered-to:arc-authentication-results; bh=KHNxI6+ohFqOfuJaZSqtpgWQB1SvfpbszJsTT3TWgR0=; b=C1d2mDR3Ssnp43NHPWd4JBBnXZk9fMweME9Qtqrps9PLZe4SptmC6qFNlZaR5qO7Wh 0ZvxCvd9E1I0k8XuzXn/TSgUIy4EaHppZQhhtqflSzR/+hWY223E1tjyy5gzwNkPc5GO qUewGRbhonmiXdBo29pXCdvDFhyeBkWhQ+HnUvJX/aQmEMyN9ZHlyZDqMMuLFePrRtLJ YwTXEahW+b+Tq4L7g6EEpb/1YKO1gZNF+nK9veRBcJrp6CuFxlDcZH4QGA9r6Rb0eZC8 6ezJBM4p2P35Q0QS4jl4VmRG1Lrij0AQdz74wtlWiU0idrEWss9H4GCgwF2VCIeiTZrG +lkw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=siT3K2Oz; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from alsa0.perex.cz (alsa0.perex.cz. [77.48.224.243]) by mx.google.com with ESMTP id w82-v6si3830318wma.109.2018.08.03.10.01.37; Fri, 03 Aug 2018 10:01:37 -0700 (PDT) Received-SPF: pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) client-ip=77.48.224.243; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=siT3K2Oz; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 7B2E32677D0; Fri, 3 Aug 2018 19:01:36 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 51B062677DA; Fri, 3 Aug 2018 19:01:34 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail1.perex.cz X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=disabled version=3.4.0 Received: from heliosphere.sirena.org.uk (heliosphere.sirena.org.uk [172.104.155.198]) by alsa0.perex.cz (Postfix) with ESMTP id D289A2677DA for ; Fri, 3 Aug 2018 19:01:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=Date:Message-Id:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner: List-Archive; bh=nL7EuD9xAS7MrYau10z2r8J97g6HU3cnA4NWXUAgAfA=; b=siT3K2Ozlxj8 E4VoVFyegV6ArBfzNNtMg3+Rhk9Pqc1RuRBCNU5+oqmDDgkz98F3QaH0nDEMbpZKvHeKnfxTilPvb If5aOZwaKdYsX7OO4r/vRr/CKqun5TdM6QlENMW/trPJyZEZyNm/rNV+hNneT/D4BBCXHlJCCe+os sVsi4=; Received: from cpc102320-sgyl38-2-0-cust46.18-2.cable.virginm.net ([82.37.168.47] helo=debutante.sirena.org.uk) by heliosphere.sirena.org.uk with esmtpa (Exim 4.89) (envelope-from ) id 1fldSG-0003mO-6m; Fri, 03 Aug 2018 17:01:32 +0000 Received: by debutante.sirena.org.uk (Postfix, from userid 1000) id EC7431123AA1; Fri, 3 Aug 2018 18:01:31 +0100 (BST) From: Mark Brown To: Gustavo A. R. Silva In-Reply-To: <720fbf880f4edfb57379278056f45fc639775ad3.1533312229.git.gustavo@embeddedor.com> Message-Id: <20180803170131.EC7431123AA1@debutante.sirena.org.uk> Date: Fri, 3 Aug 2018 18:01:31 +0100 (BST) Cc: alsa-devel@alsa-project.org, "Gustavo A. R. Silva" , Takashi Iwai , linux-kernel@vger.kernel.org, Liam Girdwood , Peter Ujfalusi , Mark Brown , linux-omap@vger.kernel.org, Jarkko Nikula Subject: [alsa-devel] Applied "ASoC: omap-mcpdm: Mark expected switch fall-throughs" to the asoc tree X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org The patch ASoC: omap-mcpdm: Mark expected switch fall-throughs has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From 85c81941d5033fc8a68646823d3157840c9de8b3 Mon Sep 17 00:00:00 2001 From: "Gustavo A. R. Silva" Date: Fri, 3 Aug 2018 11:32:52 -0500 Subject: [PATCH] ASoC: omap-mcpdm: Mark expected switch fall-throughs In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Addresses-Coverity-ID: 1369526 ("Missing break in switch") Addresses-Coverity-ID: 1369529 ("Missing break in switch") Addresses-Coverity-ID: 1451415 ("Missing break in switch") Addresses-Coverity-ID: 115103 ("Missing break in switch") Signed-off-by: Gustavo A. R. Silva Signed-off-by: Mark Brown --- sound/soc/omap/omap-mcpdm.c | 4 ++++ 1 file changed, 4 insertions(+) -- 2.18.0 _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel diff --git a/sound/soc/omap/omap-mcpdm.c b/sound/soc/omap/omap-mcpdm.c index 0e97360f9890..4c1be36c2207 100644 --- a/sound/soc/omap/omap-mcpdm.c +++ b/sound/soc/omap/omap-mcpdm.c @@ -310,15 +310,19 @@ static int omap_mcpdm_dai_hw_params(struct snd_pcm_substream *substream, /* up to 3 channels for capture */ return -EINVAL; link_mask |= 1 << 4; + /* fall through */ case 4: if (stream == SNDRV_PCM_STREAM_CAPTURE) /* up to 3 channels for capture */ return -EINVAL; link_mask |= 1 << 3; + /* fall through */ case 3: link_mask |= 1 << 2; + /* fall through */ case 2: link_mask |= 1 << 1; + /* fall through */ case 1: link_mask |= 1 << 0; break;