From patchwork Mon Aug 2 14:38:14 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 490356 Delivered-To: patch@linaro.org Received: by 2002:a05:6638:1185:0:0:0:0 with SMTP id f5csp1985248jas; Mon, 2 Aug 2021 07:38:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzQ9IzpACWij+hXOGoKydkCEix9h+cYvJGByJhmAld2ZL6UReS8QDs9asX8AJ7pL97gajCJ X-Received: by 2002:aa7:da4f:: with SMTP id w15mr19432699eds.9.1627915115027; Mon, 02 Aug 2021 07:38:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627915115; cv=none; d=google.com; s=arc-20160816; b=WLiSYSTYo1DjHNABx5GpVZRx5ZeMv2ObpviG1UdlNjeD4fZYRfkfQfsruRrPl0/nGK hK11HEkgfWVkMXYOCUK6WtkyXOLczIyCga9KfsHEVgD/BD1zufHoM+eb7gSOsgW8kZ/p UA1obt0mcR1h0xM+Gd98oG/SsY8i5mb/KK9dwxkcCm5/WaqUNRfSzlSN2MpmCypWXo1j xBkkCAAg8CVaDVKPnVONG4SaJcjgZfvIuWfboj5dYzpLliTX2e4eD/1//HB2wz54SWfk 2Oxzec9DF3Sqk4t+VOe/CbVGBL8wRIA5BWQAv6gH0ErAPmObolOV2qAHs7iRTe/1RCee aSZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=L/X9zu0v+HYF6F4h8k/7sbgWktrxMJsMfGJZ1OtMnvc=; b=L8BmAniJJGiicplxZHeNbgPIJwW97BNv4v9voBpk2vcDw8JVA7agiIecm7N+qdBoG1 4pt8Ih0J1lRDtfXHFbw21Bu6ooJtoOZbLxe90cBtvKM+tP/9PuuP4tkOHxYQdmkxqAV4 d0fIk5fLr5V5J/6f1OHy3+O7KdeqPiVwa8NvgZ1AH//UEJjnuWTb5B/905XS2aaO3k4D a5S0llKWOeH/LVFbOY2DEbtHgbbIZx8zAR/AM5Fv2k5wNzJ41DWqPhVU+5skKbJxJuN0 ashnfssc5offy39fo+JA/qOp2Q9LKastIaYvnT7o9OXEVaz6A5xIgEhyuSFhjfrK4BRW 6H2A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=K15vMR6a; spf=pass (google.com: domain of linux-media-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-media-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bz23si9718534ejc.155.2021.08.02.07.38.34; Mon, 02 Aug 2021 07:38:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-media-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=K15vMR6a; spf=pass (google.com: domain of linux-media-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-media-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234254AbhHBOih (ORCPT + 4 others); Mon, 2 Aug 2021 10:38:37 -0400 Received: from mail.kernel.org ([198.145.29.99]:45194 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233925AbhHBOie (ORCPT ); Mon, 2 Aug 2021 10:38:34 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id A9EE160E97; Mon, 2 Aug 2021 14:38:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1627915105; bh=3ZYcZPQjEjSEHTb9HiRMek+879amZ+MVRhxp83xQ/aE=; h=From:To:Cc:Subject:Date:From; b=K15vMR6aQfsjYku1iI3zkke3uUJv9wqJwhmpNAzgXCJuguiFVcHa7naHaxUlMY9Di 5CDEm7Pyzfde09ceAUVOmYZ1JvLGJquVpTnLySEaxY2U5Uyd+rS46oIMi0vj7hgOmC IkVNgkQVTe85/PKOoOutEN4/t9KhN3E0erRJGitAuXI2Dg/G49ESf3WSedqTfNy4WS aRLd1JOU+1zrlFr+fDXLiqQEiZs/rsehYRSuWMw4i97dmxhSZeL+G/YK+UUNx+tCqQ gecn7oSAdyXjP1y50j0kaRYp/bRAyDIxEtOdlEsHFQh1w8GSiMxOWMwe9f7S17q9TJ j6k4hXj4cRgzQ== From: Arnd Bergmann To: Mauro Carvalho Chehab , Greg Kroah-Hartman , Pavel Skripkin Cc: Arnd Bergmann , Sakari Ailus , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH] media: atomisp: restore missing 'return' statement Date: Mon, 2 Aug 2021 16:38:14 +0200 Message-Id: <20210802143820.1150099-1-arnd@kernel.org> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org From: Arnd Bergmann The input_system_configure_channel_sensor() function lost its final return code in a previous patch: drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c: In function 'input_system_configure_channel_sensor': drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c:1649:1: error: control reaches end of non-void function [-Werror=return-type] Restore what was there originally. Fixes: 728a5c64ae5f ("media: atomisp: remove dublicate code") Signed-off-by: Arnd Bergmann --- .../media/atomisp/pci/hive_isp_css_common/host/input_system.c | 2 ++ 1 file changed, 2 insertions(+) -- 2.29.2 Acked-by: Sakari Ailus Reviewed-by: Kees Cook Tested-by: Andy Shevchenko Reviewed-by: Andy Shevchenko diff --git a/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c b/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c index 8e085dda0c18..712e01c37870 100644 --- a/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c +++ b/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c @@ -1646,6 +1646,8 @@ static input_system_err_t input_system_configure_channel_sensor( default: return INPUT_SYSTEM_ERR_PARAMETER_NOT_SUPPORTED; } + + return INPUT_SYSTEM_ERR_NO_ERROR; } // Test flags and set structure.