From patchwork Wed Sep 26 12:58:21 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 147579 Delivered-To: patch@linaro.org Received: by 2002:a2e:8595:0:0:0:0:0 with SMTP id b21-v6csp690156lji; Wed, 26 Sep 2018 05:58:48 -0700 (PDT) X-Google-Smtp-Source: ACcGV60sShp8AljtcfhhtZYV6F7i2PmIX7gj2pgQ9UVCHERfW7n1Q7xt9CXQK8tWTqmEbsZuL0Y3 X-Received: by 2002:a62:5b85:: with SMTP id p127-v6mr6250371pfb.33.1537966728699; Wed, 26 Sep 2018 05:58:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537966728; cv=none; d=google.com; s=arc-20160816; b=yaQUy+xaoeYo4+OeAHI2ILvDs0rk0cIVwubiNF9EvWFJMbV7jwm+chsP7Qwbp59XEP bY/sPgO4C/hBTzUevBQwKtYwY6E5A30Z4DNPZu16ZY3VaOyO22Q59XRWh5ftp2W5bBwM kqnd1QrihMEgJQDc2F3KTsGXMGSdH0lZaq/+vy6CsUFQmE6vKciMmqJDGmhoNguV6/7J z3i2mWZCepSZY9WTAj61PB3qM/h3Ul5vsb8XdBp3LdUetNjmDB5AV9Bf/BirkDSWKY5i 1PSaVv2af98Yqq5WK4iGv8I6Y7X0yc3oEcz8zMktlJrALOid634IcqoSFRc7qLpAe/1p S6Hg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from; bh=uX1nIB1lQtVAWmYq6KhfXGi1h6EYgTbdVOFKPh6n/fs=; b=q8yGzBFUXT0glZePxgZ66jMfbej355ti7lzgzRrTmKHSzyO/geCo1PCAwkxIlIejDu DDbIRClN04FsMPsWgN8DQjc8qCydK2YeOyWGvS15UoaEx0kBqvYZAaHwMnDhHM8M9eDL q1ZjS/t/vBEooIbdN3fEfGplFM9ys3kNUGcnN61rJ8rji+Dt+y6bKZ1Ww1DHl4aG8axM APU2gLGr1T1BHL4bNvzC+5i4X2oE/BU0b59xIxhQ2SiEJeT2aYo21jaGxPzy3Z/tjaXa 6badwnvWOd9YCFlMXQNrrTDHauhnkuOBOjFXidAWRkEV0Zq33ZcRhBVYHtGuO+5LODQi Rj0Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-spi-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-spi-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 8-v6si5238886pgu.519.2018.09.26.05.58.48; Wed, 26 Sep 2018 05:58:48 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-spi-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-spi-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-spi-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726880AbeIZTLj (ORCPT + 1 other); Wed, 26 Sep 2018 15:11:39 -0400 Received: from mout.kundenserver.de ([212.227.126.130]:38261 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726841AbeIZTLj (ORCPT ); Wed, 26 Sep 2018 15:11:39 -0400 Received: from wuerfel.lan ([109.193.40.16]) by mrelayeu.kundenserver.de (mreue011 [212.227.15.129]) with ESMTPA (Nemesis) id 1MIMOy-1g1uGN49kC-00EMbd; Wed, 26 Sep 2018 14:58:36 +0200 From: Arnd Bergmann To: Mark Brown , Orson Zhai , Baolin Wang , Chunyan Zhang Cc: Arnd Bergmann , Lanqing Liu , linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] spi: sprd: don't mark remove function as __exit Date: Wed, 26 Sep 2018 14:58:21 +0200 Message-Id: <20180926125833.2225931-1-arnd@arndb.de> X-Mailer: git-send-email 2.18.0 X-Provags-ID: V03:K1:fNKgtJWj17TIxjEo3MAKRXHvevG7DRPgoBRViWCEWdGYz2znHdG 7mzJDyXzjqchK03K6wyAd8tNk78aGTFOE6IyNMlZZYy1yw2HmLQH1hT/QAs6tm4To7n8+Fm nEmISL09Bf0pu+yue9G4uyn8OIsNqFky78358YwSoVyOY4gU3GiGNwd0fVUOKahludsiIXM 4CbN0PF2PG6q41cBGRpPQ== X-UI-Out-Filterresults: notjunk:1; V01:K0:dS/1xTYKdkY=:Kl2FRuZLFERXC4mfcSbENJ l99WhwLkcidBYR+ybcWL7b16HCw+vu5seI1LwN/F//+0W7qGslGqIvI/VDqidMjRT5cK00niq mfwcq5w06MN42+a8LI5BusjGb8rLx6Zxo2ejtiGuepqNoWZCtUS3o/PyI7wj+T2WIcRvZ9c95 KjwL58V7KKHF78bKRph983NtcuiQ57zPF8BDuUJvcyT8BO+olDnFGMjoIV20QHOp94ZxTFlOH g0sKrebYKtU750TNeOKEtdiGNSFf1ablq73jZX+QJplFBwUHEHuJfXkrVpif0KltkxIcCF7gX /TxAyMQ+Zczr/AJ6KO7vBCr8nlt5/EPACZ9F8P24UQzTr0fV1pTCcNbiZU/VTai3SieVlvIPg 2Csllu70KdJK+8ytmlmJsgzpKul5hFIviMXI7cKipgZSkuaH3eRLsO4jTfkC5bFq91BNs5B3j y0on/Bvd7z4Ehzjg0eInTyvrdwFvJm3uVRkf/a3+bFMLUjT3waQgsSTSCtyl2wqdEetrlqKEU pXMtZgw4yY0depIRs8/6P4OBZSiGCsYrdj4wsUxytOKemGJwRlRY3T1Vm3xSZ0cCAfWLB1V/s RefLPMM7F5pVljXpJLVms/nwQ/ib5kUt5FjQ3nLlJ6x1IntfMsSpXv52ewwTmPEeTM+eqYZG/ 4RQwTpVImwd+9JAD58aKFNgR+onI7olLZKEJO6Onr9Qm5W6Q6lk/odMGY8xtrkW7vjlA= Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org The __exit section is left out for built-in drivers, so a 'remove' callback must not be marked as such to avoid breaking when we unbind a device at runtime. This was pointed out by kbuild: `sprd_spi_remove' referenced in section `.data' of drivers/spi/spi-sprd.o: defined in discarded section `.exit.text' of drivers/spi/spi-sprd.o Fixes: e7d973a31c24 ("spi: sprd: Add SPI driver for Spreadtrum SC9860") Signed-off-by: Arnd Bergmann --- drivers/spi/spi-sprd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.18.0 Acked-by: Baolin Wang diff --git a/drivers/spi/spi-sprd.c b/drivers/spi/spi-sprd.c index a9a6c5ed443f..8daa24eec624 100644 --- a/drivers/spi/spi-sprd.c +++ b/drivers/spi/spi-sprd.c @@ -676,7 +676,7 @@ static int sprd_spi_probe(struct platform_device *pdev) return ret; } -static int __exit sprd_spi_remove(struct platform_device *pdev) +static int sprd_spi_remove(struct platform_device *pdev) { struct spi_controller *sctlr = platform_get_drvdata(pdev); struct sprd_spi *ss = spi_controller_get_devdata(sctlr);