From patchwork Fri Nov 26 20:17:07 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florian Fainelli X-Patchwork-Id: 518653 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A51DC433F5 for ; Sat, 27 Nov 2021 17:40:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1355778AbhK0Rn5 (ORCPT ); Sat, 27 Nov 2021 12:43:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49888 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244168AbhK0Rl4 (ORCPT ); Sat, 27 Nov 2021 12:41:56 -0500 Received: from mail-pg1-x52c.google.com (mail-pg1-x52c.google.com [IPv6:2607:f8b0:4864:20::52c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7F23CC06173E; Sat, 27 Nov 2021 09:38:41 -0800 (PST) Received: by mail-pg1-x52c.google.com with SMTP id c29so200539pgl.12; Sat, 27 Nov 2021 09:38:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=G1gqFj3clXWd81d+tagIDoTyLSEKgRKuTjgTMfvLzXU=; b=NkYTIZ/0gzM3E0FWu98BncXqLTfzHa42nEejDVPwGAXpP/HAgxrMTc4+aR0yMY5qSJ OVyvH90/xXXuvksqazEgkjUyua3hpGrCtCN8zt+STMmaqoxYDxe5QmKeJL9AAgC07+vi BDLm9knf8v1xlBM9CRaSfN6h2Aig2BJFMlIJQgkiex9R1HswYYBW8/JboTQjs6ufIyxI hArghoWWB+gz+Y3wB1FDEEZRJVXFRfPRArjn+TKwKKplJO9JMJ5tS34RACn42aaQIf1W D8+U6Qu3rxSIk13xji4qRakjKHMVDSMupXYW863GDwrCfduN8x4EFvwF4To8VFROxwz5 HK4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=G1gqFj3clXWd81d+tagIDoTyLSEKgRKuTjgTMfvLzXU=; b=E1GVo6EKo/ew0g/vSlTTwFwRKRlm/rj1K4VT5Mbceb/g7+/n0AnS2qnfAY9TAHRdbg QJAnXUBKVtggRJehvkkBYB0nGOtDsmxEQimkDTSsQeyEsUT1E3TOVv7gclPqLhtBpnGL dKDrN78joWIjmQvsWvoIVamCbaw8lxnrOUQukGQzUY7N9h7BLAxUkP0UE8lZJf/Ale1H 5QfIhoNbhkQjoGeIGKHzIpCMG1o+etmqTB+L477NzHy893AY4uKJmI5qDBujiOo9zHgq k6YLA/65dStx340tiqeyhCP1uOYDeTjZ3mEwtinnzpEXCmHYht5aizyyoct/zv8jMfmY RwDg== X-Gm-Message-State: AOAM531MFYQ1SEAPEmIBxzb4T+vomjTuMi2QxOHLB6HCJV/ZcdDd1Dl0 zyf+zDRR+hz/kkKluGn/UUmAYRXaRNrQTQ== X-Google-Smtp-Source: ABdhPJzBjLoGgoqXbfxqcwqxqaJSsG8xONXeqLp9O2K2KP3UmGTNh5MCWtFXU8DS4MY80cYcbILVGA== X-Received: by 2002:a63:ef03:: with SMTP id u3mr15761534pgh.74.1638034720702; Sat, 27 Nov 2021 09:38:40 -0800 (PST) Received: from 7YHHR73.igp.broadcom.net (70-36-60-214.dyn.novuscom.net. [70.36.60.214]) by smtp.gmail.com with ESMTPSA id t19sm8051776pgn.7.2021.11.27.09.38.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 27 Nov 2021 09:38:40 -0800 (PST) From: Florian Fainelli To: linux-kernel@vger.kernel.org Cc: Florian Fainelli , kernel test robot , Manish Rangankar , Nilesh Javali , GR-QLogic-Storage-Upstream@marvell.com (supporter:QLOGIC QL41xxx ISCSI DRIVER), "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org (open list:QLOGIC QL41xxx ISCSI DRIVER) Subject: [PATCH v2 1/2] scsi: qedi: Remove set but unused 'page' variable Date: Fri, 26 Nov 2021 12:17:07 -0800 Message-Id: <20211126201708.27140-2-f.fainelli@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211126201708.27140-1-f.fainelli@gmail.com> References: <20211126201708.27140-1-f.fainelli@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org The variable page is set but never used throughout qedi_alloc_bdq() therefore remove it. Reported-by: kernel test robot Acked-by: Manish Rangankar Signed-off-by: Florian Fainelli --- drivers/scsi/qedi/qedi_main.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/scsi/qedi/qedi_main.c b/drivers/scsi/qedi/qedi_main.c index 1dec814d8788..f1c933070884 100644 --- a/drivers/scsi/qedi/qedi_main.c +++ b/drivers/scsi/qedi/qedi_main.c @@ -1538,7 +1538,6 @@ static int qedi_alloc_bdq(struct qedi_ctx *qedi) int i; struct scsi_bd *pbl; u64 *list; - dma_addr_t page; /* Alloc dma memory for BDQ buffers */ for (i = 0; i < QEDI_BDQ_NUM; i++) { @@ -1608,11 +1607,9 @@ static int qedi_alloc_bdq(struct qedi_ctx *qedi) qedi->bdq_pbl_list_num_entries = qedi->bdq_pbl_mem_size / QEDI_PAGE_SIZE; list = (u64 *)qedi->bdq_pbl_list; - page = qedi->bdq_pbl_list_dma; for (i = 0; i < qedi->bdq_pbl_list_num_entries; i++) { *list = qedi->bdq_pbl_dma; list++; - page += QEDI_PAGE_SIZE; } return 0; From patchwork Fri Nov 26 20:17:08 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florian Fainelli X-Patchwork-Id: 517512 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F3BBC433F5 for ; Sat, 27 Nov 2021 17:40:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1355792AbhK0Rn5 (ORCPT ); Sat, 27 Nov 2021 12:43:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49894 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234533AbhK0Rl5 (ORCPT ); Sat, 27 Nov 2021 12:41:57 -0500 Received: from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com [IPv6:2607:f8b0:4864:20::1032]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 90520C061746; Sat, 27 Nov 2021 09:38:42 -0800 (PST) Received: by mail-pj1-x1032.google.com with SMTP id fv9-20020a17090b0e8900b001a6a5ab1392so10334385pjb.1; Sat, 27 Nov 2021 09:38:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=muEV41oGv4dCXu6T0pBAwtMsCi0zA6yAWl0ncN03ssw=; b=ELNJTmDbhtdH+T48RrB+KCCm2X/Ky075szsYsS+ZAZv8JCLapZFv9iCiqsNRy/sQFZ ghW1tvD9A4x50zkAPuWYfdJGsVnkz/CU6S8/IDpSYtYfIqWiUkHw5yS+aFdckm843CnV Kstt4wXRdvvhR8Q9iaF9rsR3xKBY2viNw2QU/UPVHrE175KgEZ+MzK424N3Br+mMVx91 VpgWTn968HG35ery5EGB+JFYCd6EyHUtuzJz4pLH4Hlp43ZV5U1eWNtCsv3ZOhVS1wBT fW4PrVijiUFiSc8m8RVm8lLre4g7m+MgfTuRb0b0gn6wmSEW6a9j10w50Eec30PZKjKg zH7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=muEV41oGv4dCXu6T0pBAwtMsCi0zA6yAWl0ncN03ssw=; b=kmi6Hzvr1qTh+ags570tjbVu8M73iIBuiaFSNyl5OnphtSGFTbAV8YxVHIF8lrOO4j 1IhAtwEwPIlTK+0oPbj8fLjkYZGFw/tVXBJIEMx5Uhpjfjs86lZF0Xvp2Ix1rm2jR/Ng 1HnVq0d7iuXkPnJ9hfK2NVqKg+Nm88ifnUJAu2xCMhE6/juYLYlsbiI/svtCEXZxzczx R0EGi43Zt84Ahg5G96BRU91URIq07BUpYF+wAYUsvx7sU1YmCTsz3wt98YHxdN449c5Q wCJT16BA14y8DDffTTFlKZzXuDElSe9OxKAuAGAz7XoEJtk2kDc9h/j/3kwwrBtlkSET yWIQ== X-Gm-Message-State: AOAM531tss9DX1VGWQ6a09bAZmNJBy4akmZgW1CoYh23srMo5YNOK+sc oJEQu/0zvpEc3QAnZKX0ndf9D+OctTTGJA== X-Google-Smtp-Source: ABdhPJzTLlK8vbWzwyWP4NjwL6Fds42LHIYpXygP2nvsOPHZkzR79c0EvoWrDhBvYexSBb8bkqdPOw== X-Received: by 2002:a17:90b:1bcb:: with SMTP id oa11mr24815160pjb.140.1638034721764; Sat, 27 Nov 2021 09:38:41 -0800 (PST) Received: from 7YHHR73.igp.broadcom.net (70-36-60-214.dyn.novuscom.net. [70.36.60.214]) by smtp.gmail.com with ESMTPSA id t19sm8051776pgn.7.2021.11.27.09.38.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 27 Nov 2021 09:38:41 -0800 (PST) From: Florian Fainelli To: linux-kernel@vger.kernel.org Cc: Florian Fainelli , kernel test robot , Nilesh Javali , Manish Rangankar , GR-QLogic-Storage-Upstream@marvell.com (supporter:QLOGIC QL41xxx ISCSI DRIVER), "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org (open list:QLOGIC QL41xxx ISCSI DRIVER) Subject: [PATCH v2 2/2] scsi: qedi: Fix SYSFS_FLAG_FW_SEL_BOOT formatting Date: Fri, 26 Nov 2021 12:17:08 -0800 Message-Id: <20211126201708.27140-3-f.fainelli@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211126201708.27140-1-f.fainelli@gmail.com> References: <20211126201708.27140-1-f.fainelli@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org The format used for formatting SYSFS_FLAG_FW_SEL_BOOT creates the following warning: drivers/scsi/qedi/qedi_main.c:2259:35: warning: format specifies type 'char' but the argument has type 'int' [-Wformat] rc = snprintf(buf, 3, "%hhd\n", SYSFS_FLAG_FW_SEL_BOOT); Fix this to cast the constant as an u8 since the intention is to print it via sysfs as a byte. Reported-by: kernel test robot Signed-off-by: Florian Fainelli --- drivers/scsi/qedi/qedi.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/qedi/qedi.h b/drivers/scsi/qedi/qedi.h index ce199a7a16b8..421b3a69fd37 100644 --- a/drivers/scsi/qedi/qedi.h +++ b/drivers/scsi/qedi/qedi.h @@ -358,7 +358,7 @@ struct qedi_ctx { bool use_fast_sge; atomic_t num_offloads; -#define SYSFS_FLAG_FW_SEL_BOOT 2 +#define SYSFS_FLAG_FW_SEL_BOOT (u8)2 #define IPV6_LEN 41 #define IPV4_LEN 17 struct iscsi_boot_kset *boot_kset;