From patchwork Tue Nov 6 17:58:15 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ard Biesheuvel X-Patchwork-Id: 150303 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp4191840ljp; Tue, 6 Nov 2018 09:58:54 -0800 (PST) X-Google-Smtp-Source: AJdET5dX0PTTimNXggfN6G/YyHoPEfpj9DPFfzl+SMB2EZw+0R1WKDZ8TAp4NKGKeWNMAVMQ5fzA X-Received: by 2002:a62:3046:: with SMTP id w67-v6mr27278446pfw.177.1541527134216; Tue, 06 Nov 2018 09:58:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1541527134; cv=none; d=google.com; s=arc-20160816; b=xBkPxXRsByM5odCnkDb/RCKCiUnS0tnZhFq/OlPNUlB1/DA/QJIGU0xYBwHq5x0s7f XOGDFUvvQOazrlO0dox9YturlVBybtbnxsm7T+HOnLVGsZEymzHAkgz+PW/iSLB/lbUb VNCVpCeG4jVcd+JozAyxP/ua7rird+dnrJW+aUlNYFfocPyJHwu/eB0+G59eXfDWUuFm Et7PTAHB7QF3GlQ9E1YKyMkE2zZYZ2+mbP7pMAatJMBPBqCSuoTTCio6aNJzjltW3lL0 Dh+0fb0DMkpEXSJCtOrzJ98qa4HwiTBkwOOHFfMfZS6bjOGRTcY7HMbjlSqb59ZWKLe3 pKBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:references:in-reply-to:message-id :date:to:from:dkim-signature:delivered-to; bh=UzQfqulGTQuItkyZU1uG7ttgPx7ubcyuf3aXrIv+bto=; b=St/v4f/bAnCn4IQIHzetpgjGO/mOWngNI+dAuuw+WMQgKyC3aLJM782PjksXzSs796 Vi3PUH7LWkQFuDW2VTwydmd4vhd3a7//fFJUCtKmE6cx9SBdZdOiaTcuWPEq9GNBNkRl yrQ63Eg4Ks0J1iDTnq7+93R9asHmFWbYNZ/fB3gN4cW3/Gx5I4o0gaYkduegA/KXGwV8 fGRKdjDkRq05FIsW+DE+yZsooAXwha4OmRX9YmXiPXqwNXWZoCCWOYiKgNJDdxy5kCcp BCXAbOrbrBa/NDH/4Td3rI2alwYYkiW3dTckpbxSTVUy+IuixivJhSVpabNtqf1IHHi2 EEVQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b="O6/CNLfH"; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from ml01.01.org (ml01.01.org. [198.145.21.10]) by mx.google.com with ESMTPS id 3-v6si27026939plp.388.2018.11.06.09.58.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Nov 2018 09:58:54 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) client-ip=198.145.21.10; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b="O6/CNLfH"; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 736F82118C4EE; Tue, 6 Nov 2018 09:58:52 -0800 (PST) X-Original-To: edk2-devel@lists.01.org Delivered-To: edk2-devel@lists.01.org Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::441; helo=mail-wr1-x441.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 64D4C21188C31 for ; Tue, 6 Nov 2018 09:58:51 -0800 (PST) Received: by mail-wr1-x441.google.com with SMTP id z13-v6so12187170wrs.3 for ; Tue, 06 Nov 2018 09:58:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=J+nvnyUd426dY1Yge8WOzRAyCl5VJiLyRIrJYwXrR64=; b=O6/CNLfH7GVv6PuxWgftvx0tiMgRJf4D/y3a97QpWXvnwSl/dQJP0bsGkeFDzTXMWM d3vA8R+/9CyAgo4oRdcwXeTxtBgUENgVfJlyVQ24hiyUsQH/qokcflED9tI+mxGDFxru X2PPxSRaxaFUK7FJWMM/noo+RRluho1whYFoc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=J+nvnyUd426dY1Yge8WOzRAyCl5VJiLyRIrJYwXrR64=; b=P7suVuxc1jpINTrmgXAlvzxYjkpI0TfHzPKEb8tbPefKGO2wRqVKMdTGiBDKJiKY6c nSk65czV0V6mCxva27dqNBpf8lIc7aTwn8iOhnsBkjoIiNr/zaLHGG6G/K8rMiWxqOEk cA+j5r6NP0sk19dGaNiK8xgyp9Lji0AB++xwgS0obP9rt2EEFwdJocQsJ2bJImPJ6fRI EgVAFWsNoPFp2ZId8g+FmCwEBMJk6oiqXWHUEq1zbP3FU5KJiYx5AqzTAcZbRUX1I2Ev BJfHtAa+xUM+qtvIW5hWFnv8KYzVmN4/SyjJUokcQbYe46mGd1GZuNwijKcXqTgs5KRf 5LHg== X-Gm-Message-State: AGRZ1gLTk3XGhHDaKs7rQORJSI1cWejqlLjAykVMaGRttIVgAUpk/Mlt rxVhStur9MK+HGs1pCR4hfVKR+pC0ms= X-Received: by 2002:adf:ec41:: with SMTP id w1-v6mr24444784wrn.266.1541527129535; Tue, 06 Nov 2018 09:58:49 -0800 (PST) Received: from localhost.localdomain (laubervilliers-657-1-83-120.w92-154.abo.wanadoo.fr. [92.154.90.120]) by smtp.gmail.com with ESMTPSA id 134-v6sm2971522wmp.6.2018.11.06.09.58.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Nov 2018 09:58:48 -0800 (PST) From: Ard Biesheuvel To: edk2-devel@lists.01.org Date: Tue, 6 Nov 2018 18:58:15 +0100 Message-Id: <20181106175833.26964-2-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181106175833.26964-1-ard.biesheuvel@linaro.org> References: <20181106175833.26964-1-ard.biesheuvel@linaro.org> MIME-Version: 1.0 Subject: [edk2] [PATCH edk2-staging 01/19] IntelOpenSourceUndiPkg.dsc: add AARCH64 and ARM to supported architectures X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: michael.d.kinney@intel.com, eric.jin@intel.com Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- IntelUndiPkg/IntelOpenSourceUndiPkg.dsc | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) -- 2.19.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel Reviewed-by: Ryszard Knop diff --git a/IntelUndiPkg/IntelOpenSourceUndiPkg.dsc b/IntelUndiPkg/IntelOpenSourceUndiPkg.dsc index 21b1fb27984e..ca440bde2cb4 100644 --- a/IntelUndiPkg/IntelOpenSourceUndiPkg.dsc +++ b/IntelUndiPkg/IntelOpenSourceUndiPkg.dsc @@ -29,7 +29,7 @@ PLATFORM_VERSION = 0.1 DSC_SPECIFICATION = 0x00010005 OUTPUT_DIRECTORY = Build/IntelUndiPkg - SUPPORTED_ARCHITECTURES = IA32|IPF|X64 + SUPPORTED_ARCHITECTURES = IA32|IPF|X64|ARM|AARCH64 BUILD_TARGETS = DEBUG|RELEASE|DEV SKUID_IDENTIFIER = DEFAULT @@ -62,6 +62,17 @@ SynchronizationLib|MdePkg/Library/BaseSynchronizationLib/BaseSynchronizationLib.inf DebugPrintErrorLevelLib|MdePkg/Library/BaseDebugPrintErrorLevelLib/BaseDebugPrintErrorLevelLib.inf +[LibraryClasses.ARM, LibraryClasses.AARCH64] + # + # It is not possible to prevent the ARM compiler from inserting calls to + # intrinsic functions. This library provides the instrinsic functions such + # a compiler may generate calls to. + # + NULL|ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf + + # Add support for GCC stack protector + NULL|MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf + ################################################################################ # # Pcd Section - list of all EDK II PCD Entries defined by this Platform From patchwork Tue Nov 6 17:58:16 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Ard Biesheuvel X-Patchwork-Id: 150304 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp4191892ljp; Tue, 6 Nov 2018 09:58:57 -0800 (PST) X-Google-Smtp-Source: AJdET5cFtHi5eQopyBn/DHl2r+0tpnCyXQrw+FGw69I/qW+IfDhk1a0XJ+sa5CaZ0psREEHWlW36 X-Received: by 2002:a63:f006:: with SMTP id k6mr24730646pgh.259.1541527137097; Tue, 06 Nov 2018 09:58:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1541527137; cv=none; d=google.com; s=arc-20160816; b=Hdt7WvVStW8Wy4KCSmka8fej31myUHXfgJO40DNFZlK+O+nRH87KKWW+Xo9D9xC34g lkRdym8nJoGFZHazCjbM7RQPzRG0Ur4BSD4mH+kAgPCEtfxubhD0Xlt3+qelVlEEn+Tr WXzsnBmmPrsNLpfIZscD/3pknRCD17rkK71p7bw1nR+Ufbm7G4GbuyMzPNlzagpbZCeA VQ/ZPFvo/dOq6hH4Edg9pIKReJR7OZygi57TDb2M393IG6NmKcnqZIb1YG2fZ8EeuIYG yV6H+mVmkWamhyLyTcffM/V3NeFzvsTFmjHcNwZ/6++9uANjSnWBF23M+DsA+tfQAWbn iaHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:references:in-reply-to:message-id :date:to:from:dkim-signature:delivered-to; bh=SQfH7pqNnCxNYq/4zZ13Il3qU0rsTN9DlPEtCtcaVQM=; b=qGyainAWrV+MiK14/XIw+y/NGg7PMon3iYgg9bPYpMWzhCp+duQSqeKvG/nNjtWiSA ZnLBP7JW9YJgDrZ7rl4YSuvxa7W43WmetoKqN4s2SwLYLx7ky6mluWih5o5j6LOJdv9K uTLuKXv3CrKclRtatyy4BFlL9iVQUXlTpsyJUaRcUmpAUES0qXDI160Qn+G/WGy6arZR 6YIZ5yaBzR53ZN02TR4JZNRZvwbfde/4E1fyzAZxjArU3jkNAqoXwV9Cg43lAfe0z70P WhBWTyZ1B1KzIu+2Rpmo+8mGxCWU9b+L6cpAzXE72peJwbaPM69hxSQBvx9K8+C4VFW1 O/yw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b="LPY/Y45/"; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from ml01.01.org (ml01.01.org. [2001:19d0:306:5::1]) by mx.google.com with ESMTPS id c68-v6si2372384pfa.267.2018.11.06.09.58.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Nov 2018 09:58:57 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) client-ip=2001:19d0:306:5::1; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b="LPY/Y45/"; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id B05862118C4F6; Tue, 6 Nov 2018 09:58:56 -0800 (PST) X-Original-To: edk2-devel@lists.01.org Delivered-To: edk2-devel@lists.01.org Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::441; helo=mail-wr1-x441.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 972332194D3B9 for ; Tue, 6 Nov 2018 09:58:54 -0800 (PST) Received: by mail-wr1-x441.google.com with SMTP id z16-v6so14590529wrv.2 for ; Tue, 06 Nov 2018 09:58:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+05dYNK9BHp8vuIT11yFcQ4J6cRB1JlbJFkOhlZkl1s=; b=LPY/Y45/KNBOOEaAqh5sAgAl5X73igbe119lk/5gwKTSRrqIQrcpo7oYTrhrE4kBok qMALV7/BQCb3CImBNkOE9AO4/YvDKtdVsstFJOIggPReWNRePVt56IfjK8xZLn7h1TKG 6VtVLmvbx15yQY+yGgcBjul1/bHB7ptdQ6NE4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+05dYNK9BHp8vuIT11yFcQ4J6cRB1JlbJFkOhlZkl1s=; b=reap1Ws0jike54rimpGE6g6X0xtug2jncCtmsQ/B+0SYDL+hBvXadt6RPrW0CdyXAG hI1Q5mSMcKrdx7/CdkfkvuVr0xgZhBHTm47L6PnPCA9OWPxtOXfaHwBFo1gxVtB/SQjO 2twTSRlM/bRFcx32ezbAv+iIwICOX+F8NhMFQD5ODVOQdUipKXmzZ+EzU9M0X9XbCGCS lzbQF8s4oS9pvnEV4kuEsLu2QiPNYIpxzxpppuiyRsO3xaoXh43olllFBQUqNS6fQWKW HBb6wpHdj/mOCP6B4C5melQCn1pO6LXIcA1IDDsDjYAU7zmWH9k0lDNUhW8phGPBnjet DN1Q== X-Gm-Message-State: AGRZ1gINhUAZ28Yts93KR87FN77yIHdlqAFPgGw6W9aoDd1CIWeApXgK WJStggEij7xw7z2xxi87XqzZLp7szVk= X-Received: by 2002:adf:83a4:: with SMTP id 33-v6mr23768841wre.13.1541527131358; Tue, 06 Nov 2018 09:58:51 -0800 (PST) Received: from localhost.localdomain (laubervilliers-657-1-83-120.w92-154.abo.wanadoo.fr. [92.154.90.120]) by smtp.gmail.com with ESMTPSA id 134-v6sm2971522wmp.6.2018.11.06.09.58.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Nov 2018 09:58:50 -0800 (PST) From: Ard Biesheuvel To: edk2-devel@lists.01.org Date: Tue, 6 Nov 2018 18:58:16 +0100 Message-Id: <20181106175833.26964-3-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181106175833.26964-1-ard.biesheuvel@linaro.org> References: <20181106175833.26964-1-ard.biesheuvel@linaro.org> MIME-Version: 1.0 Subject: [edk2] [PATCH edk2-staging 02/19] IntelUndiPkg: remove EOF markers X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: michael.d.kinney@intel.com, eric.jin@intel.com Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" Remove the Ctrl-Z markers at the end of each file: these break the GCC build on Linux. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- IntelUndiPkg/GigUndiDxe/AdapterInformation.c | 1 - IntelUndiPkg/GigUndiDxe/AdapterInformation.h | 1 - IntelUndiPkg/GigUndiDxe/Brand.c | 1 - IntelUndiPkg/GigUndiDxe/ComponentName.c | 1 - IntelUndiPkg/GigUndiDxe/ComponentName.h | 1 - IntelUndiPkg/GigUndiDxe/Decode.c | 1 - IntelUndiPkg/GigUndiDxe/Decode.h | 1 - IntelUndiPkg/GigUndiDxe/DeviceSupport.c | 1 - IntelUndiPkg/GigUndiDxe/DeviceSupport.h | 1 - IntelUndiPkg/GigUndiDxe/Dma.c | 1 - IntelUndiPkg/GigUndiDxe/Dma.h | 1 - IntelUndiPkg/GigUndiDxe/DriverConfiguration.c | 1 - IntelUndiPkg/GigUndiDxe/DriverConfiguration.h | 1 - IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c | 1 - IntelUndiPkg/GigUndiDxe/DriverDiagnostics.h | 1 - IntelUndiPkg/GigUndiDxe/DriverHealth.c | 1 - IntelUndiPkg/GigUndiDxe/E1000.c | 1 - IntelUndiPkg/GigUndiDxe/E1000.h | 1 - IntelUndiPkg/GigUndiDxe/E1000_osdep.c | 1 - IntelUndiPkg/GigUndiDxe/E1000_osdep.h | 1 - IntelUndiPkg/GigUndiDxe/EepromConfig.c | 1 - IntelUndiPkg/GigUndiDxe/EepromConfig.h | 1 - IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf | 1 - IntelUndiPkg/GigUndiDxe/Hii.c | 1 - IntelUndiPkg/GigUndiDxe/Hii.h | 1 - IntelUndiPkg/GigUndiDxe/HiiInternalLib.c | 1 - IntelUndiPkg/GigUndiDxe/HiiInternalLib.h | 1 - IntelUndiPkg/GigUndiDxe/Init.c | 1 - IntelUndiPkg/GigUndiDxe/Init.h | 1 - IntelUndiPkg/GigUndiDxe/Inventory.vfr | 1 - IntelUndiPkg/GigUndiDxe/NVDataStruc.h | 1 - IntelUndiPkg/GigUndiDxe/StartStop.c | 1 - IntelUndiPkg/GigUndiDxe/StartStop.h | 1 - IntelUndiPkg/GigUndiDxe/Version.h | 1 - IntelUndiPkg/GigUndiDxe/e1000_80003es2lan.c | 1 - IntelUndiPkg/GigUndiDxe/e1000_80003es2lan.h | 1 - IntelUndiPkg/GigUndiDxe/e1000_82571.c | 1 - IntelUndiPkg/GigUndiDxe/e1000_82571.h | 1 - IntelUndiPkg/GigUndiDxe/e1000_82575.c | 1 - IntelUndiPkg/GigUndiDxe/e1000_82575.h | 1 - IntelUndiPkg/GigUndiDxe/e1000_api.c | 1 - IntelUndiPkg/GigUndiDxe/e1000_api.h | 1 - IntelUndiPkg/GigUndiDxe/e1000_defines.h | 1 - IntelUndiPkg/GigUndiDxe/e1000_hw.h | 1 - IntelUndiPkg/GigUndiDxe/e1000_i210.c | 1 - IntelUndiPkg/GigUndiDxe/e1000_i210.h | 1 - IntelUndiPkg/GigUndiDxe/e1000_ich8lan.c | 1 - IntelUndiPkg/GigUndiDxe/e1000_ich8lan.h | 1 - IntelUndiPkg/GigUndiDxe/e1000_mac.c | 1 - IntelUndiPkg/GigUndiDxe/e1000_mac.h | 1 - IntelUndiPkg/GigUndiDxe/e1000_manage.c | 1 - IntelUndiPkg/GigUndiDxe/e1000_manage.h | 1 - IntelUndiPkg/GigUndiDxe/e1000_nvm.c | 1 - IntelUndiPkg/GigUndiDxe/e1000_nvm.h | 1 - IntelUndiPkg/GigUndiDxe/e1000_phy.c | 1 - IntelUndiPkg/GigUndiDxe/e1000_phy.h | 1 - IntelUndiPkg/GigUndiDxe/e1000_regs.h | 1 - IntelUndiPkg/GigUndiDxe/wol/wol.c | 1 - IntelUndiPkg/GigUndiDxe/wol/wol.h | 1 - IntelUndiPkg/GigUndiDxe/wol/wol_1G.c | 1 - IntelUndiPkg/GigUndiDxe/wol/wolfamily.c | 1 - IntelUndiPkg/GigUndiDxe/wol/wolimpl.c | 1 - IntelUndiPkg/GigUndiDxe/wol/wolimpl.h | 1 - IntelUndiPkg/GigUndiDxe/wol/wolinfo.c | 1 - IntelUndiPkg/I40eUndiDxe/AdapterInformation.c | 1 - IntelUndiPkg/I40eUndiDxe/AdapterInformation.h | 1 - IntelUndiPkg/I40eUndiDxe/Brand.c | 1 - IntelUndiPkg/I40eUndiDxe/ComponentName.c | 1 - IntelUndiPkg/I40eUndiDxe/ComponentName.h | 1 - IntelUndiPkg/I40eUndiDxe/Decode.c | 1 - IntelUndiPkg/I40eUndiDxe/Decode.h | 1 - IntelUndiPkg/I40eUndiDxe/DeviceSupport.c | 1 - IntelUndiPkg/I40eUndiDxe/DeviceSupport.h | 1 - IntelUndiPkg/I40eUndiDxe/Dma.c | 1 - IntelUndiPkg/I40eUndiDxe/Dma.h | 1 - IntelUndiPkg/I40eUndiDxe/DriverDiagnostics.c | 1 - IntelUndiPkg/I40eUndiDxe/DriverDiagnostics.h | 1 - IntelUndiPkg/I40eUndiDxe/DriverHealth.c | 1 - IntelUndiPkg/I40eUndiDxe/DriverHealthCommon.h | 1 - IntelUndiPkg/I40eUndiDxe/EepromConfig.c | 1 - IntelUndiPkg/I40eUndiDxe/EepromConfig.h | 1 - IntelUndiPkg/I40eUndiDxe/Hii.c | 1 - IntelUndiPkg/I40eUndiDxe/Hii.h | 1 - IntelUndiPkg/I40eUndiDxe/HiiInternalLib.c | 1 - IntelUndiPkg/I40eUndiDxe/HiiInternalLib.h | 1 - IntelUndiPkg/I40eUndiDxe/I40e.c | 1 - IntelUndiPkg/I40eUndiDxe/I40e.h | 1 - IntelUndiPkg/I40eUndiDxe/I40eUndiDxe.inf | 1 - IntelUndiPkg/I40eUndiDxe/I40e_osdep.h | 1 - IntelUndiPkg/I40eUndiDxe/Init.c | 1 - IntelUndiPkg/I40eUndiDxe/Init.h | 1 - IntelUndiPkg/I40eUndiDxe/Inventory.vfr | 1 - IntelUndiPkg/I40eUndiDxe/NVDataStruc.h | 1 - IntelUndiPkg/I40eUndiDxe/StartStop.c | 1 - IntelUndiPkg/I40eUndiDxe/StartStop.h | 1 - IntelUndiPkg/I40eUndiDxe/Version.h | 1 - IntelUndiPkg/I40eUndiDxe/i40e_adminq.c | 1 - IntelUndiPkg/I40eUndiDxe/i40e_adminq.h | 1 - IntelUndiPkg/I40eUndiDxe/i40e_adminq_cmd.h | 1 - IntelUndiPkg/I40eUndiDxe/i40e_alloc.h | 1 - IntelUndiPkg/I40eUndiDxe/i40e_common.c | 1 - IntelUndiPkg/I40eUndiDxe/i40e_devids.h | 1 - IntelUndiPkg/I40eUndiDxe/i40e_diag.c | 1 - IntelUndiPkg/I40eUndiDxe/i40e_diag.h | 1 - IntelUndiPkg/I40eUndiDxe/i40e_hmc.c | 1 - IntelUndiPkg/I40eUndiDxe/i40e_hmc.h | 1 - IntelUndiPkg/I40eUndiDxe/i40e_lan_hmc.c | 1 - IntelUndiPkg/I40eUndiDxe/i40e_lan_hmc.h | 1 - IntelUndiPkg/I40eUndiDxe/i40e_nvm.c | 1 - IntelUndiPkg/I40eUndiDxe/i40e_prototype.h | 1 - IntelUndiPkg/I40eUndiDxe/i40e_register.h | 1 - IntelUndiPkg/I40eUndiDxe/i40e_status.h | 1 - IntelUndiPkg/I40eUndiDxe/i40e_type.h | 1 - IntelUndiPkg/I40eUndiDxe/i40e_virtchnl.h | 1 - IntelUndiPkg/XGigUndiDxe/AdapterInformation.c | 1 - IntelUndiPkg/XGigUndiDxe/AdapterInformation.h | 1 - IntelUndiPkg/XGigUndiDxe/Brand.c | 1 - IntelUndiPkg/XGigUndiDxe/ComponentName.c | 1 - IntelUndiPkg/XGigUndiDxe/ComponentName.h | 1 - IntelUndiPkg/XGigUndiDxe/Decode.c | 1 - IntelUndiPkg/XGigUndiDxe/Decode.h | 1 - IntelUndiPkg/XGigUndiDxe/DeviceSupport.c | 1 - IntelUndiPkg/XGigUndiDxe/DeviceSupport.h | 1 - IntelUndiPkg/XGigUndiDxe/Dma.c | 1 - IntelUndiPkg/XGigUndiDxe/Dma.h | 1 - IntelUndiPkg/XGigUndiDxe/DriverDiagnostics.c | 1 - IntelUndiPkg/XGigUndiDxe/DriverDiagnostics.h | 1 - IntelUndiPkg/XGigUndiDxe/DriverHealth.c | 1 - IntelUndiPkg/XGigUndiDxe/DriverHealthCommon.h | 1 - IntelUndiPkg/XGigUndiDxe/EepromConfig.c | 1 - IntelUndiPkg/XGigUndiDxe/EepromConfig.h | 1 - IntelUndiPkg/XGigUndiDxe/Hii.c | 1 - IntelUndiPkg/XGigUndiDxe/Hii.h | 1 - IntelUndiPkg/XGigUndiDxe/HiiInternalLib.c | 1 - IntelUndiPkg/XGigUndiDxe/HiiInternalLib.h | 1 - IntelUndiPkg/XGigUndiDxe/Init.c | 1 - IntelUndiPkg/XGigUndiDxe/Init.h | 1 - IntelUndiPkg/XGigUndiDxe/Inventory.vfr | 1 - IntelUndiPkg/XGigUndiDxe/NVDataStruc.h | 1 - IntelUndiPkg/XGigUndiDxe/StartStop.c | 1 - IntelUndiPkg/XGigUndiDxe/StartStop.h | 1 - IntelUndiPkg/XGigUndiDxe/Version.h | 1 - IntelUndiPkg/XGigUndiDxe/XGigUndiDxe.inf | 1 - IntelUndiPkg/XGigUndiDxe/Xgbe.c | 1 - IntelUndiPkg/XGigUndiDxe/Xgbe.h | 1 - IntelUndiPkg/XGigUndiDxe/ixgbe_82598.c | 1 - IntelUndiPkg/XGigUndiDxe/ixgbe_82598.h | 1 - IntelUndiPkg/XGigUndiDxe/ixgbe_82599.c | 1 - IntelUndiPkg/XGigUndiDxe/ixgbe_82599.h | 1 - IntelUndiPkg/XGigUndiDxe/ixgbe_api.c | 1 - IntelUndiPkg/XGigUndiDxe/ixgbe_api.h | 1 - IntelUndiPkg/XGigUndiDxe/ixgbe_common.c | 1 - IntelUndiPkg/XGigUndiDxe/ixgbe_common.h | 1 - IntelUndiPkg/XGigUndiDxe/ixgbe_dcb.h | 1 - IntelUndiPkg/XGigUndiDxe/ixgbe_dcb_82599.h | 1 - IntelUndiPkg/XGigUndiDxe/ixgbe_osdep.h | 1 - IntelUndiPkg/XGigUndiDxe/ixgbe_phy.c | 1 - IntelUndiPkg/XGigUndiDxe/ixgbe_phy.h | 1 - IntelUndiPkg/XGigUndiDxe/ixgbe_type.h | 1 - IntelUndiPkg/XGigUndiDxe/ixgbe_x540.c | 1 - IntelUndiPkg/XGigUndiDxe/ixgbe_x540.h | 1 - IntelUndiPkg/XGigUndiDxe/ixgbe_x550.c | 1 - IntelUndiPkg/XGigUndiDxe/ixgbe_x550.h | 1 - IntelUndiPkg/XGigUndiDxe/wol/wol.c | 1 - IntelUndiPkg/XGigUndiDxe/wol/wol.h | 1 - IntelUndiPkg/XGigUndiDxe/wol/wol_10G.c | 1 - IntelUndiPkg/XGigUndiDxe/wol/wolfamily.c | 1 - IntelUndiPkg/XGigUndiDxe/wol/wolimpl.c | 1 - IntelUndiPkg/XGigUndiDxe/wol/wolimpl.h | 1 - IntelUndiPkg/XGigUndiDxe/wol/wolinfo.c | 1 - 170 files changed, 170 deletions(-) -- 2.19.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Ryszard Knop diff --git a/IntelUndiPkg/GigUndiDxe/AdapterInformation.c b/IntelUndiPkg/GigUndiDxe/AdapterInformation.c index 8268f0da5e9b..b0320b11839b 100644 --- a/IntelUndiPkg/GigUndiDxe/AdapterInformation.c +++ b/IntelUndiPkg/GigUndiDxe/AdapterInformation.c @@ -409,4 +409,3 @@ EFI_ADAPTER_INFORMATION_PROTOCOL gUndiAdapterInfo = { SetInformation, GetSupportedTypes }; - \ No newline at end of file diff --git a/IntelUndiPkg/GigUndiDxe/AdapterInformation.h b/IntelUndiPkg/GigUndiDxe/AdapterInformation.h index 72d08a891d06..3b2039bc5cb2 100644 --- a/IntelUndiPkg/GigUndiDxe/AdapterInformation.h +++ b/IntelUndiPkg/GigUndiDxe/AdapterInformation.h @@ -101,4 +101,3 @@ UninstallAdapterInformationProtocol ( #endif /* ADAPTER_INFORMATION_H_ */ - \ No newline at end of file diff --git a/IntelUndiPkg/GigUndiDxe/Brand.c b/IntelUndiPkg/GigUndiDxe/Brand.c index 2aba217eb4c5..b29ebce16c71 100644 --- a/IntelUndiPkg/GigUndiDxe/Brand.c +++ b/IntelUndiPkg/GigUndiDxe/Brand.c @@ -213,4 +213,3 @@ BRAND_STRUCT mBrandingTable[] = { }; UINTN mBrandingTableSize = (sizeof (mBrandingTable) / sizeof (mBrandingTable[0])); - \ No newline at end of file diff --git a/IntelUndiPkg/GigUndiDxe/ComponentName.c b/IntelUndiPkg/GigUndiDxe/ComponentName.c index 6ee0dd991505..1473bfbed0af 100644 --- a/IntelUndiPkg/GigUndiDxe/ComponentName.c +++ b/IntelUndiPkg/GigUndiDxe/ComponentName.c @@ -272,4 +272,3 @@ EFI_DRIVER_SUPPORTED_EFI_VERSION_PROTOCOL gUndiSupportedEfiVersion = { sizeof (EFI_DRIVER_SUPPORTED_EFI_VERSION_PROTOCOL), EFI_2_70_SYSTEM_TABLE_REVISION }; - \ No newline at end of file diff --git a/IntelUndiPkg/GigUndiDxe/ComponentName.h b/IntelUndiPkg/GigUndiDxe/ComponentName.h index e3a386ea66f3..5a3d414c6970 100644 --- a/IntelUndiPkg/GigUndiDxe/ComponentName.h +++ b/IntelUndiPkg/GigUndiDxe/ComponentName.h @@ -72,4 +72,3 @@ ComponentNameGetDriverName ( ); #endif /* COMPONENT_NAME_H_ */ - \ No newline at end of file diff --git a/IntelUndiPkg/GigUndiDxe/Decode.c b/IntelUndiPkg/GigUndiDxe/Decode.c index f858abe10785..88e8be315bd1 100644 --- a/IntelUndiPkg/GigUndiDxe/Decode.c +++ b/IntelUndiPkg/GigUndiDxe/Decode.c @@ -1866,4 +1866,3 @@ BadCdb: CdbPtr->StatFlags = PXE_STATFLAGS_COMMAND_FAILED; CdbPtr->StatCode = PXE_STATCODE_INVALID_CDB; } - \ No newline at end of file diff --git a/IntelUndiPkg/GigUndiDxe/Decode.h b/IntelUndiPkg/GigUndiDxe/Decode.h index b00670f4d290..fb01267d0b2f 100644 --- a/IntelUndiPkg/GigUndiDxe/Decode.h +++ b/IntelUndiPkg/GigUndiDxe/Decode.h @@ -46,4 +46,3 @@ E1000UndiApiEntry ( ); #endif /* DECODE_H_ */ - \ No newline at end of file diff --git a/IntelUndiPkg/GigUndiDxe/DeviceSupport.c b/IntelUndiPkg/GigUndiDxe/DeviceSupport.c index 47c2a07a0f16..3ffc25d58a3f 100644 --- a/IntelUndiPkg/GigUndiDxe/DeviceSupport.c +++ b/IntelUndiPkg/GigUndiDxe/DeviceSupport.c @@ -189,4 +189,3 @@ IsDeviceIdSupported ( } return FALSE; } - \ No newline at end of file diff --git a/IntelUndiPkg/GigUndiDxe/DeviceSupport.h b/IntelUndiPkg/GigUndiDxe/DeviceSupport.h index a0d6b613285d..f309044d9b9d 100644 --- a/IntelUndiPkg/GigUndiDxe/DeviceSupport.h +++ b/IntelUndiPkg/GigUndiDxe/DeviceSupport.h @@ -81,4 +81,3 @@ IsDeviceIdSupported ( UINT16 DeviceId ); #endif /* DEVICE_SUPPORT_H_ */ - \ No newline at end of file diff --git a/IntelUndiPkg/GigUndiDxe/Dma.c b/IntelUndiPkg/GigUndiDxe/Dma.c index 7f32361ef678..76a3fcf69601 100644 --- a/IntelUndiPkg/GigUndiDxe/Dma.c +++ b/IntelUndiPkg/GigUndiDxe/Dma.c @@ -282,4 +282,3 @@ UndiDmaUnmapMemory ( return Status; } - \ No newline at end of file diff --git a/IntelUndiPkg/GigUndiDxe/Dma.h b/IntelUndiPkg/GigUndiDxe/Dma.h index 6763c83dca39..3422acd500de 100644 --- a/IntelUndiPkg/GigUndiDxe/Dma.h +++ b/IntelUndiPkg/GigUndiDxe/Dma.h @@ -132,4 +132,3 @@ UndiDmaUnmapMemory ( ); #endif /* _DMA_H_ */ - \ No newline at end of file diff --git a/IntelUndiPkg/GigUndiDxe/DriverConfiguration.c b/IntelUndiPkg/GigUndiDxe/DriverConfiguration.c index 9aec9422f1d6..118c1b2b9b04 100644 --- a/IntelUndiPkg/GigUndiDxe/DriverConfiguration.c +++ b/IntelUndiPkg/GigUndiDxe/DriverConfiguration.c @@ -571,4 +571,3 @@ EFI_DRIVER_CONFIGURATION_PROTOCOL gGigUndiDriverConfiguration = { GigUndiDriverConfigurationForceDefaults, "eng" }; - \ No newline at end of file diff --git a/IntelUndiPkg/GigUndiDxe/DriverConfiguration.h b/IntelUndiPkg/GigUndiDxe/DriverConfiguration.h index 9464cddbb756..a15a3a0a2745 100644 --- a/IntelUndiPkg/GigUndiDxe/DriverConfiguration.h +++ b/IntelUndiPkg/GigUndiDxe/DriverConfiguration.h @@ -38,4 +38,3 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. #define MENU_EXIT 6 #endif /* DRIVER_CONFIGURATION_H_ */ - \ No newline at end of file diff --git a/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c b/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c index 19b63b6059f6..a9f176ce5324 100644 --- a/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c +++ b/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c @@ -1548,4 +1548,3 @@ EFI_DRIVER_DIAGNOSTICS2_PROTOCOL gGigUndiDriverDiagnostics2 = { (EFI_DRIVER_DIAGNOSTICS2_RUN_DIAGNOSTICS) GigUndiDriverDiagnosticsRunDiagnostics, "en-US" }; - \ No newline at end of file diff --git a/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.h b/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.h index 2a3fe772e80a..c0f984953065 100644 --- a/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.h +++ b/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.h @@ -82,4 +82,3 @@ typedef struct { #pragma pack() #endif /* DRIVER_DIAGNOSTICS_H_ */ - \ No newline at end of file diff --git a/IntelUndiPkg/GigUndiDxe/DriverHealth.c b/IntelUndiPkg/GigUndiDxe/DriverHealth.c index 83de9e89ab66..b1af371e06db 100644 --- a/IntelUndiPkg/GigUndiDxe/DriverHealth.c +++ b/IntelUndiPkg/GigUndiDxe/DriverHealth.c @@ -134,4 +134,3 @@ EFI_DRIVER_HEALTH_PROTOCOL gUndiDriverHealthProtocol = { GetHealthStatus, Repair }; - \ No newline at end of file diff --git a/IntelUndiPkg/GigUndiDxe/E1000.c b/IntelUndiPkg/GigUndiDxe/E1000.c index 842778a70d01..fad20d988441 100644 --- a/IntelUndiPkg/GigUndiDxe/E1000.c +++ b/IntelUndiPkg/GigUndiDxe/E1000.c @@ -2455,4 +2455,3 @@ WaitForEnter ( gST->ConIn->ReadKeyStroke (gST->ConIn, &Key); } while (Key.UnicodeChar != 0xD); } - \ No newline at end of file diff --git a/IntelUndiPkg/GigUndiDxe/E1000.h b/IntelUndiPkg/GigUndiDxe/E1000.h index 38e88f0fd56d..71fe4591af05 100644 --- a/IntelUndiPkg/GigUndiDxe/E1000.h +++ b/IntelUndiPkg/GigUndiDxe/E1000.h @@ -1212,4 +1212,3 @@ WaitForEnter ( #endif /* E1000_H_ */ - \ No newline at end of file diff --git a/IntelUndiPkg/GigUndiDxe/E1000_osdep.c b/IntelUndiPkg/GigUndiDxe/E1000_osdep.c index 4761e7dde99e..0d0047a93048 100644 --- a/IntelUndiPkg/GigUndiDxe/E1000_osdep.c +++ b/IntelUndiPkg/GigUndiDxe/E1000_osdep.c @@ -639,4 +639,3 @@ e1000_pci_clear_mwi ( } - \ No newline at end of file diff --git a/IntelUndiPkg/GigUndiDxe/E1000_osdep.h b/IntelUndiPkg/GigUndiDxe/E1000_osdep.h index 2b5562f21e47..01c0843a2c9a 100644 --- a/IntelUndiPkg/GigUndiDxe/E1000_osdep.h +++ b/IntelUndiPkg/GigUndiDxe/E1000_osdep.h @@ -575,4 +575,3 @@ typedef BOOLEAN boolean_t; #endif /* E1000_OSDEP_H_ */ - \ No newline at end of file diff --git a/IntelUndiPkg/GigUndiDxe/EepromConfig.c b/IntelUndiPkg/GigUndiDxe/EepromConfig.c index 8a5cb62190f9..19d867ee58af 100644 --- a/IntelUndiPkg/GigUndiDxe/EepromConfig.c +++ b/IntelUndiPkg/GigUndiDxe/EepromConfig.c @@ -861,4 +861,3 @@ EepromUpdateChecksum ( return EFI_SUCCESS; } - \ No newline at end of file diff --git a/IntelUndiPkg/GigUndiDxe/EepromConfig.h b/IntelUndiPkg/GigUndiDxe/EepromConfig.h index bd9fa5c0afb2..e0d31f6a151d 100644 --- a/IntelUndiPkg/GigUndiDxe/EepromConfig.h +++ b/IntelUndiPkg/GigUndiDxe/EepromConfig.h @@ -204,4 +204,3 @@ EepromUpdateChecksum ( ); #endif /* EEPROM_CONFIG_H_ */ - \ No newline at end of file diff --git a/IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf b/IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf index e52a78723cbf..2d2d0707a686 100644 --- a/IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf +++ b/IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf @@ -163,4 +163,3 @@ wol\wol_1G.c gEfiIfrTianoGuid ## CONSUMES ## Guid gEfiEventExitBootServicesGuid ## PRODUCES ## Event gEfiEventVirtualAddressChangeGuid ## PRODUCES ## Event - \ No newline at end of file diff --git a/IntelUndiPkg/GigUndiDxe/Hii.c b/IntelUndiPkg/GigUndiDxe/Hii.c index 85818fe964c5..43c184cb03c8 100644 --- a/IntelUndiPkg/GigUndiDxe/Hii.c +++ b/IntelUndiPkg/GigUndiDxe/Hii.c @@ -1238,4 +1238,3 @@ EFI_HII_CONFIG_ACCESS_PROTOCOL gUndiHiiConfigAccess = { RouteConfig, DriverCallback }; - \ No newline at end of file diff --git a/IntelUndiPkg/GigUndiDxe/Hii.h b/IntelUndiPkg/GigUndiDxe/Hii.h index aa39eae7faea..5afdfc8cd174 100644 --- a/IntelUndiPkg/GigUndiDxe/Hii.h +++ b/IntelUndiPkg/GigUndiDxe/Hii.h @@ -90,4 +90,3 @@ HiiUnload ( ); #endif /* HII_H_ */ - \ No newline at end of file diff --git a/IntelUndiPkg/GigUndiDxe/HiiInternalLib.c b/IntelUndiPkg/GigUndiDxe/HiiInternalLib.c index 21ec03193e26..2aacb63ca158 100644 --- a/IntelUndiPkg/GigUndiDxe/HiiInternalLib.c +++ b/IntelUndiPkg/GigUndiDxe/HiiInternalLib.c @@ -485,4 +485,3 @@ AsciiStrToUnicodeStrWrapper ( return EFI_BUFFER_TOO_SMALL; } } - \ No newline at end of file diff --git a/IntelUndiPkg/GigUndiDxe/HiiInternalLib.h b/IntelUndiPkg/GigUndiDxe/HiiInternalLib.h index 49abbd280c01..28298652403a 100644 --- a/IntelUndiPkg/GigUndiDxe/HiiInternalLib.h +++ b/IntelUndiPkg/GigUndiDxe/HiiInternalLib.h @@ -162,4 +162,3 @@ AsciiStrToUnicodeStrWrapper ( ); #endif /* HII_INTERNAL_LIB_H_ */ - \ No newline at end of file diff --git a/IntelUndiPkg/GigUndiDxe/Init.c b/IntelUndiPkg/GigUndiDxe/Init.c index dad31a5f0844..47ed03eb0849 100644 --- a/IntelUndiPkg/GigUndiDxe/Init.c +++ b/IntelUndiPkg/GigUndiDxe/Init.c @@ -1876,4 +1876,3 @@ EFI_DRIVER_BINDING_PROTOCOL gUndiDriverBinding = { NULL, // ImageHandle NULL // Driver Binding Handle }; - \ No newline at end of file diff --git a/IntelUndiPkg/GigUndiDxe/Init.h b/IntelUndiPkg/GigUndiDxe/Init.h index 308f003ce038..409cb7082340 100644 --- a/IntelUndiPkg/GigUndiDxe/Init.h +++ b/IntelUndiPkg/GigUndiDxe/Init.h @@ -45,4 +45,3 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. #define MAC_ADDRESS_SIZE_IN_BYTES 6 #endif /* INIT_H_ */ - \ No newline at end of file diff --git a/IntelUndiPkg/GigUndiDxe/Inventory.vfr b/IntelUndiPkg/GigUndiDxe/Inventory.vfr index 2c59c380fc09..a6cacaff4e17 100644 --- a/IntelUndiPkg/GigUndiDxe/Inventory.vfr +++ b/IntelUndiPkg/GigUndiDxe/Inventory.vfr @@ -370,4 +370,3 @@ formset endformset; - \ No newline at end of file diff --git a/IntelUndiPkg/GigUndiDxe/NVDataStruc.h b/IntelUndiPkg/GigUndiDxe/NVDataStruc.h index 50945f37437c..bd7d4defc9a3 100644 --- a/IntelUndiPkg/GigUndiDxe/NVDataStruc.h +++ b/IntelUndiPkg/GigUndiDxe/NVDataStruc.h @@ -136,4 +136,3 @@ typedef struct { #define QUESTION_ID_TMP_SUPPORT_ALT_MAC_ADDR 0x1407 #define QUESTION_ID_TMP_SUPPORT_LINK_SPD_STATUS 0x1408 #endif /* NV_DATA_STRUC_H_ */ - \ No newline at end of file diff --git a/IntelUndiPkg/GigUndiDxe/StartStop.c b/IntelUndiPkg/GigUndiDxe/StartStop.c index 8b17507ebf4d..10ab4e51bf44 100644 --- a/IntelUndiPkg/GigUndiDxe/StartStop.c +++ b/IntelUndiPkg/GigUndiDxe/StartStop.c @@ -103,4 +103,3 @@ EFI_DRIVER_STOP_PROTOCOL gUndiDriverStop = { StopDriver, StartDriver }; - \ No newline at end of file diff --git a/IntelUndiPkg/GigUndiDxe/StartStop.h b/IntelUndiPkg/GigUndiDxe/StartStop.h index fdc0d5b6c1f6..24304d6cc3a7 100644 --- a/IntelUndiPkg/GigUndiDxe/StartStop.h +++ b/IntelUndiPkg/GigUndiDxe/StartStop.h @@ -67,4 +67,3 @@ struct EFI_DRIVER_STOP_PROTOCOL_S { }; #endif /* START_STOP_H_ */ - \ No newline at end of file diff --git a/IntelUndiPkg/GigUndiDxe/Version.h b/IntelUndiPkg/GigUndiDxe/Version.h index 11d9a607c4fa..b3019889634b 100644 --- a/IntelUndiPkg/GigUndiDxe/Version.h +++ b/IntelUndiPkg/GigUndiDxe/Version.h @@ -29,4 +29,3 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. #define MAJORVERSION 4 /* GigUndi major version */ #define MINORVERSION 9 /* GigUndi minor version */ #define BUILDNUMBER 99 /* GigUndi build version */ - \ No newline at end of file diff --git a/IntelUndiPkg/GigUndiDxe/e1000_80003es2lan.c b/IntelUndiPkg/GigUndiDxe/e1000_80003es2lan.c index c1ffc814236e..4264f2470f02 100644 --- a/IntelUndiPkg/GigUndiDxe/e1000_80003es2lan.c +++ b/IntelUndiPkg/GigUndiDxe/e1000_80003es2lan.c @@ -1532,4 +1532,3 @@ STATIC void e1000_clear_hw_cntrs_80003es2lan(struct e1000_hw *hw) E1000_READ_REG(hw, E1000_ICTXQMTC); E1000_READ_REG(hw, E1000_ICRXDMTC); } - \ No newline at end of file diff --git a/IntelUndiPkg/GigUndiDxe/e1000_80003es2lan.h b/IntelUndiPkg/GigUndiDxe/e1000_80003es2lan.h index a37545399c97..df2c53318ce5 100644 --- a/IntelUndiPkg/GigUndiDxe/e1000_80003es2lan.h +++ b/IntelUndiPkg/GigUndiDxe/e1000_80003es2lan.h @@ -93,4 +93,3 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. #define GG82563_ICR_DIS_PADDING 0x0010 /* Disable Padding */ #endif - \ No newline at end of file diff --git a/IntelUndiPkg/GigUndiDxe/e1000_82571.c b/IntelUndiPkg/GigUndiDxe/e1000_82571.c index 463e8c6eaa87..d970ce7292b8 100644 --- a/IntelUndiPkg/GigUndiDxe/e1000_82571.c +++ b/IntelUndiPkg/GigUndiDxe/e1000_82571.c @@ -2079,4 +2079,3 @@ STATIC void e1000_clear_hw_cntrs_82571(struct e1000_hw *hw) E1000_READ_REG(hw, E1000_ICTXQMTC); E1000_READ_REG(hw, E1000_ICRXDMTC); } - \ No newline at end of file diff --git a/IntelUndiPkg/GigUndiDxe/e1000_82571.h b/IntelUndiPkg/GigUndiDxe/e1000_82571.h index 8862e3e17dce..3df568892529 100644 --- a/IntelUndiPkg/GigUndiDxe/e1000_82571.h +++ b/IntelUndiPkg/GigUndiDxe/e1000_82571.h @@ -60,4 +60,3 @@ bool e1000_get_laa_state_82571(struct e1000_hw *hw); void e1000_set_laa_state_82571(struct e1000_hw *hw, bool state); #endif - \ No newline at end of file diff --git a/IntelUndiPkg/GigUndiDxe/e1000_82575.c b/IntelUndiPkg/GigUndiDxe/e1000_82575.c index f6ad91d4a2d5..b052a38f5d80 100644 --- a/IntelUndiPkg/GigUndiDxe/e1000_82575.c +++ b/IntelUndiPkg/GigUndiDxe/e1000_82575.c @@ -3342,4 +3342,3 @@ void e1000_write_vfta_i350(struct e1000_hw *hw, u32 offset, u32 value) } #endif /* NO_82580_SUPPORT */ - \ No newline at end of file diff --git a/IntelUndiPkg/GigUndiDxe/e1000_82575.h b/IntelUndiPkg/GigUndiDxe/e1000_82575.h index 39c1b38324ed..5e6be621ec13 100644 --- a/IntelUndiPkg/GigUndiDxe/e1000_82575.h +++ b/IntelUndiPkg/GigUndiDxe/e1000_82575.h @@ -433,4 +433,3 @@ s32 e1000_initialize_M88E1512_phy(struct e1000_hw *hw); s32 e1000_initialize_M88E1543_phy(struct e1000_hw *hw); #endif /* NO_82580_SUPPORT */ #endif /* _E1000_82575_H_ */ - \ No newline at end of file diff --git a/IntelUndiPkg/GigUndiDxe/e1000_api.c b/IntelUndiPkg/GigUndiDxe/e1000_api.c index 1a8e45a2e86f..195992d46a34 100644 --- a/IntelUndiPkg/GigUndiDxe/e1000_api.c +++ b/IntelUndiPkg/GigUndiDxe/e1000_api.c @@ -1280,4 +1280,3 @@ void e1000_shutdown_fiber_serdes_link(struct e1000_hw *hw) } #endif /* NO_82575_SUPPORT */ - \ No newline at end of file diff --git a/IntelUndiPkg/GigUndiDxe/e1000_api.h b/IntelUndiPkg/GigUndiDxe/e1000_api.h index c35c366f5e91..6a75ec899a07 100644 --- a/IntelUndiPkg/GigUndiDxe/e1000_api.h +++ b/IntelUndiPkg/GigUndiDxe/e1000_api.h @@ -176,4 +176,3 @@ s32 e1000_mng_write_dhcp_info(struct e1000_hw *hw, u8 *buffer, u16 length); #define E1000_DIVIDE_ROUND_UP(a, b) (((a) + (b) - 1) / (b)) /* ceil(a/b) */ #endif #endif /* _E1000_API_H_ */ - \ No newline at end of file diff --git a/IntelUndiPkg/GigUndiDxe/e1000_defines.h b/IntelUndiPkg/GigUndiDxe/e1000_defines.h index 5052b7925c3b..1d07d30aa18e 100644 --- a/IntelUndiPkg/GigUndiDxe/e1000_defines.h +++ b/IntelUndiPkg/GigUndiDxe/e1000_defines.h @@ -1636,4 +1636,3 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. #define ERROR_REPORT(fmt) do { } while (0) #endif /* ERROR_REPORT */ #endif /* _E1000_DEFINES_H_ */ - \ No newline at end of file diff --git a/IntelUndiPkg/GigUndiDxe/e1000_hw.h b/IntelUndiPkg/GigUndiDxe/e1000_hw.h index 86d163e57906..27e34f5ae824 100644 --- a/IntelUndiPkg/GigUndiDxe/e1000_hw.h +++ b/IntelUndiPkg/GigUndiDxe/e1000_hw.h @@ -969,4 +969,3 @@ void e1000_write_pci_cfg(struct e1000_hw *hw, u32 reg, u16 *value); #endif #endif - \ No newline at end of file diff --git a/IntelUndiPkg/GigUndiDxe/e1000_i210.c b/IntelUndiPkg/GigUndiDxe/e1000_i210.c index b485e739a434..5d05e3853361 100644 --- a/IntelUndiPkg/GigUndiDxe/e1000_i210.c +++ b/IntelUndiPkg/GigUndiDxe/e1000_i210.c @@ -869,4 +869,3 @@ s32 e1000_init_hw_i210(struct e1000_hw *hw) ret_val = e1000_init_hw_82575(hw); return ret_val; } - \ No newline at end of file diff --git a/IntelUndiPkg/GigUndiDxe/e1000_i210.h b/IntelUndiPkg/GigUndiDxe/e1000_i210.h index 3532126852b1..bde07d357ed6 100644 --- a/IntelUndiPkg/GigUndiDxe/e1000_i210.h +++ b/IntelUndiPkg/GigUndiDxe/e1000_i210.h @@ -97,4 +97,3 @@ enum E1000_INVM_STRUCTURE_TYPE { #define E1000_INVM_PLL_WO_VAL 0x0010 #endif - \ No newline at end of file diff --git a/IntelUndiPkg/GigUndiDxe/e1000_ich8lan.c b/IntelUndiPkg/GigUndiDxe/e1000_ich8lan.c index e3a3606f8527..7669630a5c03 100644 --- a/IntelUndiPkg/GigUndiDxe/e1000_ich8lan.c +++ b/IntelUndiPkg/GigUndiDxe/e1000_ich8lan.c @@ -5684,4 +5684,3 @@ release: } } - \ No newline at end of file diff --git a/IntelUndiPkg/GigUndiDxe/e1000_ich8lan.h b/IntelUndiPkg/GigUndiDxe/e1000_ich8lan.h index 26fe0200e5a4..a435418078d2 100644 --- a/IntelUndiPkg/GigUndiDxe/e1000_ich8lan.h +++ b/IntelUndiPkg/GigUndiDxe/e1000_ich8lan.h @@ -290,4 +290,3 @@ s32 e1000_read_emi_reg_locked(struct e1000_hw *hw, u16 addr, u16 *data); s32 e1000_write_emi_reg_locked(struct e1000_hw *hw, u16 addr, u16 data); s32 e1000_set_eee_pchlan(struct e1000_hw *hw); #endif /* _E1000_ICH8LAN_H_ */ - \ No newline at end of file diff --git a/IntelUndiPkg/GigUndiDxe/e1000_mac.c b/IntelUndiPkg/GigUndiDxe/e1000_mac.c index a0a13da26316..f3727b9bc0de 100644 --- a/IntelUndiPkg/GigUndiDxe/e1000_mac.c +++ b/IntelUndiPkg/GigUndiDxe/e1000_mac.c @@ -2293,4 +2293,3 @@ s32 e1000_write_8bit_ctrl_reg_generic(struct e1000_hw *hw, u32 reg, return E1000_SUCCESS; } #endif /* NO_82575_SUPPORT */ - \ No newline at end of file diff --git a/IntelUndiPkg/GigUndiDxe/e1000_mac.h b/IntelUndiPkg/GigUndiDxe/e1000_mac.h index 95fb00f3dc87..b8990d908b45 100644 --- a/IntelUndiPkg/GigUndiDxe/e1000_mac.h +++ b/IntelUndiPkg/GigUndiDxe/e1000_mac.h @@ -97,4 +97,3 @@ void e1000_update_adaptive_generic(struct e1000_hw *hw); void e1000_write_vfta_generic(struct e1000_hw *hw, u32 offset, u32 value); #endif - \ No newline at end of file diff --git a/IntelUndiPkg/GigUndiDxe/e1000_manage.c b/IntelUndiPkg/GigUndiDxe/e1000_manage.c index 4bf703b2de4a..5fc7fa5704ac 100644 --- a/IntelUndiPkg/GigUndiDxe/e1000_manage.c +++ b/IntelUndiPkg/GigUndiDxe/e1000_manage.c @@ -582,4 +582,3 @@ s32 e1000_load_firmware(struct e1000_hw *hw, u8 *buffer, u32 length) #endif /* NO_I210_SUPPORT */ - \ No newline at end of file diff --git a/IntelUndiPkg/GigUndiDxe/e1000_manage.h b/IntelUndiPkg/GigUndiDxe/e1000_manage.h index c9002a244a46..090a9a25de63 100644 --- a/IntelUndiPkg/GigUndiDxe/e1000_manage.h +++ b/IntelUndiPkg/GigUndiDxe/e1000_manage.h @@ -100,4 +100,3 @@ enum e1000_mng_mode { #define E1000_IAMT_SIGNATURE 0x544D4149 #endif - \ No newline at end of file diff --git a/IntelUndiPkg/GigUndiDxe/e1000_nvm.c b/IntelUndiPkg/GigUndiDxe/e1000_nvm.c index 26244874f4e3..e46130186223 100644 --- a/IntelUndiPkg/GigUndiDxe/e1000_nvm.c +++ b/IntelUndiPkg/GigUndiDxe/e1000_nvm.c @@ -1310,4 +1310,3 @@ STATIC void e1000_reload_nvm_generic(struct e1000_hw *hw) } - \ No newline at end of file diff --git a/IntelUndiPkg/GigUndiDxe/e1000_nvm.h b/IntelUndiPkg/GigUndiDxe/e1000_nvm.h index 06a668f5e912..ef84c51dbeb9 100644 --- a/IntelUndiPkg/GigUndiDxe/e1000_nvm.h +++ b/IntelUndiPkg/GigUndiDxe/e1000_nvm.h @@ -92,4 +92,3 @@ void e1000_release_nvm_generic(struct e1000_hw *hw); #define E1000_STM_OPCODE 0xDB00 #endif - \ No newline at end of file diff --git a/IntelUndiPkg/GigUndiDxe/e1000_phy.c b/IntelUndiPkg/GigUndiDxe/e1000_phy.c index b1c66d263183..765fcf387d7e 100644 --- a/IntelUndiPkg/GigUndiDxe/e1000_phy.c +++ b/IntelUndiPkg/GigUndiDxe/e1000_phy.c @@ -4465,4 +4465,3 @@ s32 e1000_write_xmdio_reg(struct e1000_hw *hw, u16 addr, u8 dev_addr, u16 data) false); } #endif /* NO_XMDIO_SUPPORT */ - \ No newline at end of file diff --git a/IntelUndiPkg/GigUndiDxe/e1000_phy.h b/IntelUndiPkg/GigUndiDxe/e1000_phy.h index de82fde1f035..3efc73b006ee 100644 --- a/IntelUndiPkg/GigUndiDxe/e1000_phy.h +++ b/IntelUndiPkg/GigUndiDxe/e1000_phy.h @@ -349,4 +349,3 @@ struct sfp_e1000_flags { #endif /* NO_82575_SUPPORT */ #endif - \ No newline at end of file diff --git a/IntelUndiPkg/GigUndiDxe/e1000_regs.h b/IntelUndiPkg/GigUndiDxe/e1000_regs.h index 8568edc310a5..d6c66b92e94e 100644 --- a/IntelUndiPkg/GigUndiDxe/e1000_regs.h +++ b/IntelUndiPkg/GigUndiDxe/e1000_regs.h @@ -772,4 +772,3 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. #endif /* NO_I210_SUPPORT */ #endif - \ No newline at end of file diff --git a/IntelUndiPkg/GigUndiDxe/wol/wol.c b/IntelUndiPkg/GigUndiDxe/wol/wol.c index 79100219b85b..74ffeafd787a 100644 --- a/IntelUndiPkg/GigUndiDxe/wol/wol.c +++ b/IntelUndiPkg/GigUndiDxe/wol/wol.c @@ -341,4 +341,3 @@ WolEnableWakeOnLanEx( return WolGetWakeOnLanStatusEx(Handle); } - \ No newline at end of file diff --git a/IntelUndiPkg/GigUndiDxe/wol/wol.h b/IntelUndiPkg/GigUndiDxe/wol/wol.h index 5ac38d6a3602..4f3140e152f8 100644 --- a/IntelUndiPkg/GigUndiDxe/wol/wol.h +++ b/IntelUndiPkg/GigUndiDxe/wol/wol.h @@ -84,4 +84,3 @@ WolEnableApmPme( #endif /* __WOL_H */ - \ No newline at end of file diff --git a/IntelUndiPkg/GigUndiDxe/wol/wol_1G.c b/IntelUndiPkg/GigUndiDxe/wol/wol_1G.c index bba2393d6ff3..02eff0957976 100644 --- a/IntelUndiPkg/GigUndiDxe/wol/wol_1G.c +++ b/IntelUndiPkg/GigUndiDxe/wol/wol_1G.c @@ -183,4 +183,3 @@ WOL_STATUS _WolEnableLaser(WOL_ADAPTER_HANDLE_TYPE Handle, BOOLEAN Enable) return WOL_FEATURE_NOT_SUPPORTED; } - \ No newline at end of file diff --git a/IntelUndiPkg/GigUndiDxe/wol/wolfamily.c b/IntelUndiPkg/GigUndiDxe/wol/wolfamily.c index 49d901defd4d..2c35be00f36a 100644 --- a/IntelUndiPkg/GigUndiDxe/wol/wolfamily.c +++ b/IntelUndiPkg/GigUndiDxe/wol/wolfamily.c @@ -163,4 +163,3 @@ WOL_MAC_TYPE const WOL_LASER_TABLE[] = { 0 }; - \ No newline at end of file diff --git a/IntelUndiPkg/GigUndiDxe/wol/wolimpl.c b/IntelUndiPkg/GigUndiDxe/wol/wolimpl.c index a5d536ee99c2..311930372f8b 100644 --- a/IntelUndiPkg/GigUndiDxe/wol/wolimpl.c +++ b/IntelUndiPkg/GigUndiDxe/wol/wolimpl.c @@ -166,4 +166,3 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. return Handle->NicInfo.Function; } - \ No newline at end of file diff --git a/IntelUndiPkg/GigUndiDxe/wol/wolimpl.h b/IntelUndiPkg/GigUndiDxe/wol/wolimpl.h index 84863eddc54e..ed2ffc427093 100644 --- a/IntelUndiPkg/GigUndiDxe/wol/wolimpl.h +++ b/IntelUndiPkg/GigUndiDxe/wol/wolimpl.h @@ -77,4 +77,3 @@ WOL_STATUS _WolEepromWrite16(WOL_ADAPTER_HANDLE_TYPE Handle, UINT16 Offset, UINT WOL_STATUS _WolEepromUpdateChecksum(WOL_ADAPTER_HANDLE_TYPE Handle); #endif /* __WOLIMPL_H */ - \ No newline at end of file diff --git a/IntelUndiPkg/GigUndiDxe/wol/wolinfo.c b/IntelUndiPkg/GigUndiDxe/wol/wolinfo.c index c99667a25f8e..4df14ce2abf6 100644 --- a/IntelUndiPkg/GigUndiDxe/wol/wolinfo.c +++ b/IntelUndiPkg/GigUndiDxe/wol/wolinfo.c @@ -334,4 +334,3 @@ _WOL_DEVICE_INFO_t const WOL_DEVICE_INFO_TABLE[] = { { 0, 0, 0, 0, 0 } /* Last entry */ }; - \ No newline at end of file diff --git a/IntelUndiPkg/I40eUndiDxe/AdapterInformation.c b/IntelUndiPkg/I40eUndiDxe/AdapterInformation.c index 7b8b78daf29b..b2801a673d6e 100644 --- a/IntelUndiPkg/I40eUndiDxe/AdapterInformation.c +++ b/IntelUndiPkg/I40eUndiDxe/AdapterInformation.c @@ -410,4 +410,3 @@ EFI_ADAPTER_INFORMATION_PROTOCOL gUndiAdapterInfo = { SetInformation, GetSupportedTypes }; - \ No newline at end of file diff --git a/IntelUndiPkg/I40eUndiDxe/AdapterInformation.h b/IntelUndiPkg/I40eUndiDxe/AdapterInformation.h index d5d5d52697c1..1401fbdb92fe 100644 --- a/IntelUndiPkg/I40eUndiDxe/AdapterInformation.h +++ b/IntelUndiPkg/I40eUndiDxe/AdapterInformation.h @@ -102,4 +102,3 @@ UninstallAdapterInformationProtocol ( #endif /* ADAPTER_INFORMATION_H_ */ - \ No newline at end of file diff --git a/IntelUndiPkg/I40eUndiDxe/Brand.c b/IntelUndiPkg/I40eUndiDxe/Brand.c index 250184d8b3ca..22629a933174 100644 --- a/IntelUndiPkg/I40eUndiDxe/Brand.c +++ b/IntelUndiPkg/I40eUndiDxe/Brand.c @@ -210,4 +210,3 @@ BRAND_STRUCT mBrandingTable[] = { UINTN mBrandingTableSize = (sizeof (mBrandingTable) / sizeof (mBrandingTable[0])); - \ No newline at end of file diff --git a/IntelUndiPkg/I40eUndiDxe/ComponentName.c b/IntelUndiPkg/I40eUndiDxe/ComponentName.c index cb83d3a79dd9..1241862adb81 100644 --- a/IntelUndiPkg/I40eUndiDxe/ComponentName.c +++ b/IntelUndiPkg/I40eUndiDxe/ComponentName.c @@ -275,4 +275,3 @@ EFI_DRIVER_SUPPORTED_EFI_VERSION_PROTOCOL gUndiSupportedEfiVersion = { sizeof (EFI_DRIVER_SUPPORTED_EFI_VERSION_PROTOCOL), EFI_2_70_SYSTEM_TABLE_REVISION }; - \ No newline at end of file diff --git a/IntelUndiPkg/I40eUndiDxe/ComponentName.h b/IntelUndiPkg/I40eUndiDxe/ComponentName.h index ed26dcb81b5b..dca634039b66 100644 --- a/IntelUndiPkg/I40eUndiDxe/ComponentName.h +++ b/IntelUndiPkg/I40eUndiDxe/ComponentName.h @@ -73,4 +73,3 @@ ComponentNameGetDriverName ( ); #endif /* COMPONENT_NAME_H_ */ - \ No newline at end of file diff --git a/IntelUndiPkg/I40eUndiDxe/Decode.c b/IntelUndiPkg/I40eUndiDxe/Decode.c index d84255be0f6c..e47979e59126 100644 --- a/IntelUndiPkg/I40eUndiDxe/Decode.c +++ b/IntelUndiPkg/I40eUndiDxe/Decode.c @@ -1881,4 +1881,3 @@ BadCdb: CdbPtr->StatCode = PXE_STATCODE_INVALID_CDB; } - \ No newline at end of file diff --git a/IntelUndiPkg/I40eUndiDxe/Decode.h b/IntelUndiPkg/I40eUndiDxe/Decode.h index 59f79e0abf5e..555d35620474 100644 --- a/IntelUndiPkg/I40eUndiDxe/Decode.h +++ b/IntelUndiPkg/I40eUndiDxe/Decode.h @@ -48,4 +48,3 @@ UndiApiEntry ( #endif /* DECODE_H_ */ - \ No newline at end of file diff --git a/IntelUndiPkg/I40eUndiDxe/DeviceSupport.c b/IntelUndiPkg/I40eUndiDxe/DeviceSupport.c index 4d1061a794e4..007d651d126f 100644 --- a/IntelUndiPkg/I40eUndiDxe/DeviceSupport.c +++ b/IntelUndiPkg/I40eUndiDxe/DeviceSupport.c @@ -202,4 +202,3 @@ IsDeviceIdSupported ( } return FALSE; } - \ No newline at end of file diff --git a/IntelUndiPkg/I40eUndiDxe/DeviceSupport.h b/IntelUndiPkg/I40eUndiDxe/DeviceSupport.h index b26f0ff0ec8c..b0de9f40c572 100644 --- a/IntelUndiPkg/I40eUndiDxe/DeviceSupport.h +++ b/IntelUndiPkg/I40eUndiDxe/DeviceSupport.h @@ -82,4 +82,3 @@ IsDeviceIdSupported ( UINT16 DeviceId ); #endif /* DEVICE_SUPPORT_H_ */ - \ No newline at end of file diff --git a/IntelUndiPkg/I40eUndiDxe/Dma.c b/IntelUndiPkg/I40eUndiDxe/Dma.c index 17f14bd043f1..9efa705cb6f0 100644 --- a/IntelUndiPkg/I40eUndiDxe/Dma.c +++ b/IntelUndiPkg/I40eUndiDxe/Dma.c @@ -283,4 +283,3 @@ UndiDmaUnmapMemory ( return Status; } - \ No newline at end of file diff --git a/IntelUndiPkg/I40eUndiDxe/Dma.h b/IntelUndiPkg/I40eUndiDxe/Dma.h index 58a1f234b5df..d0d00463aa63 100644 --- a/IntelUndiPkg/I40eUndiDxe/Dma.h +++ b/IntelUndiPkg/I40eUndiDxe/Dma.h @@ -133,4 +133,3 @@ UndiDmaUnmapMemory ( ); #endif /* _DMA_H_ */ - \ No newline at end of file diff --git a/IntelUndiPkg/I40eUndiDxe/DriverDiagnostics.c b/IntelUndiPkg/I40eUndiDxe/DriverDiagnostics.c index 536ff7a65522..de07eb0f254f 100644 --- a/IntelUndiPkg/I40eUndiDxe/DriverDiagnostics.c +++ b/IntelUndiPkg/I40eUndiDxe/DriverDiagnostics.c @@ -1131,4 +1131,3 @@ EFI_DRIVER_DIAGNOSTICS2_PROTOCOL gUndiDriverDiagnostics2 = { "en-US" }; - \ No newline at end of file diff --git a/IntelUndiPkg/I40eUndiDxe/DriverDiagnostics.h b/IntelUndiPkg/I40eUndiDxe/DriverDiagnostics.h index a6a725c33aa9..c3414f3897fe 100644 --- a/IntelUndiPkg/I40eUndiDxe/DriverDiagnostics.h +++ b/IntelUndiPkg/I40eUndiDxe/DriverDiagnostics.h @@ -80,4 +80,3 @@ typedef struct { #endif /* DRIVER_DIAGNOSTICS_H_ */ - \ No newline at end of file diff --git a/IntelUndiPkg/I40eUndiDxe/DriverHealth.c b/IntelUndiPkg/I40eUndiDxe/DriverHealth.c index 500ca3685cfc..30df2f3ec7d0 100644 --- a/IntelUndiPkg/I40eUndiDxe/DriverHealth.c +++ b/IntelUndiPkg/I40eUndiDxe/DriverHealth.c @@ -161,4 +161,3 @@ EFI_DRIVER_HEALTH_PROTOCOL gUndiDriverHealthProtocol = { GetHealthStatus, Repair }; - \ No newline at end of file diff --git a/IntelUndiPkg/I40eUndiDxe/DriverHealthCommon.h b/IntelUndiPkg/I40eUndiDxe/DriverHealthCommon.h index c32302879390..da1d22057dcb 100644 --- a/IntelUndiPkg/I40eUndiDxe/DriverHealthCommon.h +++ b/IntelUndiPkg/I40eUndiDxe/DriverHealthCommon.h @@ -35,4 +35,3 @@ typedef enum { MODULE_UNSUPPORTED, } MODULE_QUALIFICATION_STATUS; #endif /* DRIVER_HEALTH_COMMON_H_ */ - \ No newline at end of file diff --git a/IntelUndiPkg/I40eUndiDxe/EepromConfig.c b/IntelUndiPkg/I40eUndiDxe/EepromConfig.c index cc47e0437e80..4772715b3979 100644 --- a/IntelUndiPkg/I40eUndiDxe/EepromConfig.c +++ b/IntelUndiPkg/I40eUndiDxe/EepromConfig.c @@ -1254,4 +1254,3 @@ EepromReadPortnumValues ( } - \ No newline at end of file diff --git a/IntelUndiPkg/I40eUndiDxe/EepromConfig.h b/IntelUndiPkg/I40eUndiDxe/EepromConfig.h index e547d88b82b4..97e8be1ae80e 100644 --- a/IntelUndiPkg/I40eUndiDxe/EepromConfig.h +++ b/IntelUndiPkg/I40eUndiDxe/EepromConfig.h @@ -556,4 +556,3 @@ EepromReadPortnumValues ( #endif /* EEPROM_CONFIG_H_ */ - \ No newline at end of file diff --git a/IntelUndiPkg/I40eUndiDxe/Hii.c b/IntelUndiPkg/I40eUndiDxe/Hii.c index e411f23d14ce..404e3672aa87 100644 --- a/IntelUndiPkg/I40eUndiDxe/Hii.c +++ b/IntelUndiPkg/I40eUndiDxe/Hii.c @@ -1254,4 +1254,3 @@ EFI_HII_CONFIG_ACCESS_PROTOCOL gUndiHiiConfigAccess = { RouteConfig, DriverCallback }; - \ No newline at end of file diff --git a/IntelUndiPkg/I40eUndiDxe/Hii.h b/IntelUndiPkg/I40eUndiDxe/Hii.h index e8e916a5ee90..8ab5108e2c8b 100644 --- a/IntelUndiPkg/I40eUndiDxe/Hii.h +++ b/IntelUndiPkg/I40eUndiDxe/Hii.h @@ -91,4 +91,3 @@ HiiUnload ( ); #endif /* HII_H_ */ - \ No newline at end of file diff --git a/IntelUndiPkg/I40eUndiDxe/HiiInternalLib.c b/IntelUndiPkg/I40eUndiDxe/HiiInternalLib.c index 4e6e28fdb5c0..365ed7f2da80 100644 --- a/IntelUndiPkg/I40eUndiDxe/HiiInternalLib.c +++ b/IntelUndiPkg/I40eUndiDxe/HiiInternalLib.c @@ -486,4 +486,3 @@ AsciiStrToUnicodeStrWrapper ( return EFI_BUFFER_TOO_SMALL; } } - \ No newline at end of file diff --git a/IntelUndiPkg/I40eUndiDxe/HiiInternalLib.h b/IntelUndiPkg/I40eUndiDxe/HiiInternalLib.h index 16655f384db3..b5ee09c49c9b 100644 --- a/IntelUndiPkg/I40eUndiDxe/HiiInternalLib.h +++ b/IntelUndiPkg/I40eUndiDxe/HiiInternalLib.h @@ -163,4 +163,3 @@ AsciiStrToUnicodeStrWrapper ( ); #endif /* HII_INTERNAL_LIB_H_ */ - \ No newline at end of file diff --git a/IntelUndiPkg/I40eUndiDxe/I40e.c b/IntelUndiPkg/I40eUndiDxe/I40e.c index ecf83ebc86df..c2501e4222f5 100644 --- a/IntelUndiPkg/I40eUndiDxe/I40e.c +++ b/IntelUndiPkg/I40eUndiDxe/I40e.c @@ -3461,4 +3461,3 @@ I40eGetTxRxDescriptorsCount ( return I40E_DEF_NUM_TX_RX_DESCRIPTORS; } } - \ No newline at end of file diff --git a/IntelUndiPkg/I40eUndiDxe/I40e.h b/IntelUndiPkg/I40eUndiDxe/I40e.h index c5aabf6d7d69..9b994c5ec1c9 100644 --- a/IntelUndiPkg/I40eUndiDxe/I40e.h +++ b/IntelUndiPkg/I40eUndiDxe/I40e.h @@ -1504,4 +1504,3 @@ I40eGetTxRxDescriptorsCount ( ); #endif /* I40E_H_ */ - \ No newline at end of file diff --git a/IntelUndiPkg/I40eUndiDxe/I40eUndiDxe.inf b/IntelUndiPkg/I40eUndiDxe/I40eUndiDxe.inf index 76df7898bef1..caff5262f6e6 100644 --- a/IntelUndiPkg/I40eUndiDxe/I40eUndiDxe.inf +++ b/IntelUndiPkg/I40eUndiDxe/I40eUndiDxe.inf @@ -157,4 +157,3 @@ MSFT:*_*_*_CC_FLAGS = /FAcs gEfiIfrTianoGuid ## CONSUMES ## Guid gEfiEventExitBootServicesGuid ## PRODUCES ## Event gEfiEventVirtualAddressChangeGuid ## PRODUCES ## Event - \ No newline at end of file diff --git a/IntelUndiPkg/I40eUndiDxe/I40e_osdep.h b/IntelUndiPkg/I40eUndiDxe/I40e_osdep.h index 88a9547fc45b..ddd4449ad65c 100644 --- a/IntelUndiPkg/I40eUndiDxe/I40e_osdep.h +++ b/IntelUndiPkg/I40eUndiDxe/I40e_osdep.h @@ -601,4 +601,3 @@ DelayInMicroseconds ( #endif /* I40E_OSDEP_H_ */ - \ No newline at end of file diff --git a/IntelUndiPkg/I40eUndiDxe/Init.c b/IntelUndiPkg/I40eUndiDxe/Init.c index d45d669887d8..68a1699b00ba 100644 --- a/IntelUndiPkg/I40eUndiDxe/Init.c +++ b/IntelUndiPkg/I40eUndiDxe/Init.c @@ -2300,4 +2300,3 @@ EFI_DRIVER_BINDING_PROTOCOL gUndiDriverBinding = { NULL, NULL }; - \ No newline at end of file diff --git a/IntelUndiPkg/I40eUndiDxe/Init.h b/IntelUndiPkg/I40eUndiDxe/Init.h index 217ed75cd179..899eeda1e6df 100644 --- a/IntelUndiPkg/I40eUndiDxe/Init.h +++ b/IntelUndiPkg/I40eUndiDxe/Init.h @@ -87,4 +87,3 @@ UndiGetDriverHealthStatus ( ); #endif /* INIT_H_ */ - \ No newline at end of file diff --git a/IntelUndiPkg/I40eUndiDxe/Inventory.vfr b/IntelUndiPkg/I40eUndiDxe/Inventory.vfr index a64b9297291b..ea48aad2bc85 100644 --- a/IntelUndiPkg/I40eUndiDxe/Inventory.vfr +++ b/IntelUndiPkg/I40eUndiDxe/Inventory.vfr @@ -369,4 +369,3 @@ formset endformset; - \ No newline at end of file diff --git a/IntelUndiPkg/I40eUndiDxe/NVDataStruc.h b/IntelUndiPkg/I40eUndiDxe/NVDataStruc.h index 8387a99ae5bc..412cbf4833c7 100644 --- a/IntelUndiPkg/I40eUndiDxe/NVDataStruc.h +++ b/IntelUndiPkg/I40eUndiDxe/NVDataStruc.h @@ -138,4 +138,3 @@ typedef struct { #define QUESTION_ID_TMP_SUPPORT_ALT_MAC_ADDR 0x1407 #define QUESTION_ID_TMP_SUPPORT_LINK_SPD_STATUS 0x1408 #endif /* NV_DATA_STRUC_H_ */ - \ No newline at end of file diff --git a/IntelUndiPkg/I40eUndiDxe/StartStop.c b/IntelUndiPkg/I40eUndiDxe/StartStop.c index 32c9c5e09655..b375b52fe882 100644 --- a/IntelUndiPkg/I40eUndiDxe/StartStop.c +++ b/IntelUndiPkg/I40eUndiDxe/StartStop.c @@ -169,4 +169,3 @@ EFI_DRIVER_STOP_PROTOCOL gUndiDriverStop = { StartDriver }; - \ No newline at end of file diff --git a/IntelUndiPkg/I40eUndiDxe/StartStop.h b/IntelUndiPkg/I40eUndiDxe/StartStop.h index 5ebf063e4913..d80fe79cbc3a 100644 --- a/IntelUndiPkg/I40eUndiDxe/StartStop.h +++ b/IntelUndiPkg/I40eUndiDxe/StartStop.h @@ -79,4 +79,3 @@ struct EFI_DRIVER_STOP_PROTOCOL_S { #endif /* START_STOP_H_ */ - \ No newline at end of file diff --git a/IntelUndiPkg/I40eUndiDxe/Version.h b/IntelUndiPkg/I40eUndiDxe/Version.h index dfb94cedd04c..e5a47633ddf1 100644 --- a/IntelUndiPkg/I40eUndiDxe/Version.h +++ b/IntelUndiPkg/I40eUndiDxe/Version.h @@ -30,4 +30,3 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. #define MAJORVERSION 4 /* I40eUndi major version */ #define MINORVERSION 9 /* I40eUndi minor version */ #define BUILDNUMBER 99 /* I40eUndi build version */ - \ No newline at end of file diff --git a/IntelUndiPkg/I40eUndiDxe/i40e_adminq.c b/IntelUndiPkg/I40eUndiDxe/i40e_adminq.c index af443b398bb9..7d11d1ce4d6a 100644 --- a/IntelUndiPkg/I40eUndiDxe/i40e_adminq.c +++ b/IntelUndiPkg/I40eUndiDxe/i40e_adminq.c @@ -1095,4 +1095,3 @@ clean_arq_element_err: return ret_code; } - \ No newline at end of file diff --git a/IntelUndiPkg/I40eUndiDxe/i40e_adminq.h b/IntelUndiPkg/I40eUndiDxe/i40e_adminq.h index d17fe42cae96..51f0af909516 100644 --- a/IntelUndiPkg/I40eUndiDxe/i40e_adminq.h +++ b/IntelUndiPkg/I40eUndiDxe/i40e_adminq.h @@ -118,4 +118,3 @@ void i40e_fill_default_direct_cmd_desc(struct i40e_aq_desc *desc, u16 opcode); #endif /* _I40E_ADMINQ_H_ */ - \ No newline at end of file diff --git a/IntelUndiPkg/I40eUndiDxe/i40e_adminq_cmd.h b/IntelUndiPkg/I40eUndiDxe/i40e_adminq_cmd.h index 8c0c6665ee55..78ec00252201 100644 --- a/IntelUndiPkg/I40eUndiDxe/i40e_adminq_cmd.h +++ b/IntelUndiPkg/I40eUndiDxe/i40e_adminq_cmd.h @@ -2974,4 +2974,3 @@ struct i40e_aqc_debug_modify_internals { I40E_CHECK_CMD_LENGTH(i40e_aqc_debug_modify_internals); #endif /* _I40E_ADMINQ_CMD_H_ */ - \ No newline at end of file diff --git a/IntelUndiPkg/I40eUndiDxe/i40e_alloc.h b/IntelUndiPkg/I40eUndiDxe/i40e_alloc.h index 2f82f8dd72a5..51d83526207b 100644 --- a/IntelUndiPkg/I40eUndiDxe/i40e_alloc.h +++ b/IntelUndiPkg/I40eUndiDxe/i40e_alloc.h @@ -60,4 +60,3 @@ enum i40e_status_code i40e_free_virt_mem(struct i40e_hw *hw, struct i40e_virt_mem *mem); #endif /* _I40E_ALLOC_H_ */ - \ No newline at end of file diff --git a/IntelUndiPkg/I40eUndiDxe/i40e_common.c b/IntelUndiPkg/I40eUndiDxe/i40e_common.c index 01bcfeed279c..faa7b8d7483e 100644 --- a/IntelUndiPkg/I40eUndiDxe/i40e_common.c +++ b/IntelUndiPkg/I40eUndiDxe/i40e_common.c @@ -7631,4 +7631,3 @@ i40e_add_pinfo_to_list(struct i40e_hw *hw, track_id, &offset, &info, NULL); return status; } - \ No newline at end of file diff --git a/IntelUndiPkg/I40eUndiDxe/i40e_devids.h b/IntelUndiPkg/I40eUndiDxe/i40e_devids.h index 143c3b10c025..64aa672e0004 100644 --- a/IntelUndiPkg/I40eUndiDxe/i40e_devids.h +++ b/IntelUndiPkg/I40eUndiDxe/i40e_devids.h @@ -68,4 +68,3 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. (d) == I40E_DEV_ID_25G_SFP28) #endif /* _I40E_DEVIDS_H_ */ - \ No newline at end of file diff --git a/IntelUndiPkg/I40eUndiDxe/i40e_diag.c b/IntelUndiPkg/I40eUndiDxe/i40e_diag.c index f57fc65f60e0..62e8f8428aaa 100644 --- a/IntelUndiPkg/I40eUndiDxe/i40e_diag.c +++ b/IntelUndiPkg/I40eUndiDxe/i40e_diag.c @@ -193,4 +193,3 @@ enum i40e_status_code i40e_diag_fw_alive_test(struct i40e_hw *hw) UNREFERENCED_1PARAMETER(hw); return I40E_SUCCESS; } - \ No newline at end of file diff --git a/IntelUndiPkg/I40eUndiDxe/i40e_diag.h b/IntelUndiPkg/I40eUndiDxe/i40e_diag.h index 322cefb45732..4cda8b3444e6 100644 --- a/IntelUndiPkg/I40eUndiDxe/i40e_diag.h +++ b/IntelUndiPkg/I40eUndiDxe/i40e_diag.h @@ -56,4 +56,3 @@ enum i40e_status_code i40e_diag_reg_test(struct i40e_hw *hw); enum i40e_status_code i40e_diag_eeprom_test(struct i40e_hw *hw); #endif /* _I40E_DIAG_H_ */ - \ No newline at end of file diff --git a/IntelUndiPkg/I40eUndiDxe/i40e_hmc.c b/IntelUndiPkg/I40eUndiDxe/i40e_hmc.c index 28ff0ace4680..b5c084bf3372 100644 --- a/IntelUndiPkg/I40eUndiDxe/i40e_hmc.c +++ b/IntelUndiPkg/I40eUndiDxe/i40e_hmc.c @@ -366,4 +366,3 @@ enum i40e_status_code i40e_remove_pd_page_new(struct i40e_hw *hw, return i40e_free_dma_mem(hw, &(sd_entry->u.pd_table.pd_page_addr)); } - \ No newline at end of file diff --git a/IntelUndiPkg/I40eUndiDxe/i40e_hmc.h b/IntelUndiPkg/I40eUndiDxe/i40e_hmc.h index c7844edcb7ba..97ff0724729c 100644 --- a/IntelUndiPkg/I40eUndiDxe/i40e_hmc.h +++ b/IntelUndiPkg/I40eUndiDxe/i40e_hmc.h @@ -240,4 +240,3 @@ enum i40e_status_code i40e_remove_pd_page_new(struct i40e_hw *hw, u32 idx, bool is_pf); #endif /* _I40E_HMC_H_ */ - \ No newline at end of file diff --git a/IntelUndiPkg/I40eUndiDxe/i40e_lan_hmc.c b/IntelUndiPkg/I40eUndiDxe/i40e_lan_hmc.c index 93f477d0268d..4720d9f0cc83 100644 --- a/IntelUndiPkg/I40eUndiDxe/i40e_lan_hmc.c +++ b/IntelUndiPkg/I40eUndiDxe/i40e_lan_hmc.c @@ -1610,4 +1610,3 @@ enum i40e_status_code i40e_set_lan_rx_queue_context_directly(struct i40e_hw *hw, return i40e_write_queue_context_directly(hw, queue, context_bytes, I40E_HMC_LAN_RX); } - \ No newline at end of file diff --git a/IntelUndiPkg/I40eUndiDxe/i40e_lan_hmc.h b/IntelUndiPkg/I40eUndiDxe/i40e_lan_hmc.h index a5d59679af17..8842ac04470d 100644 --- a/IntelUndiPkg/I40eUndiDxe/i40e_lan_hmc.h +++ b/IntelUndiPkg/I40eUndiDxe/i40e_lan_hmc.h @@ -206,4 +206,3 @@ enum i40e_status_code i40e_delete_lan_hmc_object(struct i40e_hw *hw, struct i40e_hmc_lan_delete_obj_info *info); #endif /* _I40E_LAN_HMC_H_ */ - \ No newline at end of file diff --git a/IntelUndiPkg/I40eUndiDxe/i40e_nvm.c b/IntelUndiPkg/I40eUndiDxe/i40e_nvm.c index ef1774c8cc2e..0187d6ecb522 100644 --- a/IntelUndiPkg/I40eUndiDxe/i40e_nvm.c +++ b/IntelUndiPkg/I40eUndiDxe/i40e_nvm.c @@ -758,4 +758,3 @@ enum i40e_status_code i40e_validate_nvm_checksum(struct i40e_hw *hw, return ret_code; } - \ No newline at end of file diff --git a/IntelUndiPkg/I40eUndiDxe/i40e_prototype.h b/IntelUndiPkg/I40eUndiDxe/i40e_prototype.h index a85d80093a61..3bf01eaf1f55 100644 --- a/IntelUndiPkg/I40eUndiDxe/i40e_prototype.h +++ b/IntelUndiPkg/I40eUndiDxe/i40e_prototype.h @@ -593,4 +593,3 @@ i40e_add_pinfo_to_list(struct i40e_hw *hw, struct i40e_profile_segment *profile, u8 *profile_info_sec, u32 track_id); #endif /* _I40E_PROTOTYPE_H_ */ - \ No newline at end of file diff --git a/IntelUndiPkg/I40eUndiDxe/i40e_register.h b/IntelUndiPkg/I40eUndiDxe/i40e_register.h index 0d8d1cfde13a..4eb955b8eeb5 100644 --- a/IntelUndiPkg/I40eUndiDxe/i40e_register.h +++ b/IntelUndiPkg/I40eUndiDxe/i40e_register.h @@ -5357,4 +5357,3 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. #define I40E_VFPE_WQEALLOC1_WQE_DESC_INDEX_MASK I40E_MASK(0xFFF, I40E_VFPE_WQEALLOC1_WQE_DESC_INDEX_SHIFT) #endif /* _I40E_REGISTER_H_ */ - \ No newline at end of file diff --git a/IntelUndiPkg/I40eUndiDxe/i40e_status.h b/IntelUndiPkg/I40eUndiDxe/i40e_status.h index bd03a486d1ae..b5d9c71a37b0 100644 --- a/IntelUndiPkg/I40eUndiDxe/i40e_status.h +++ b/IntelUndiPkg/I40eUndiDxe/i40e_status.h @@ -103,4 +103,3 @@ enum i40e_status_code { }; #endif /* _I40E_STATUS_H_ */ - \ No newline at end of file diff --git a/IntelUndiPkg/I40eUndiDxe/i40e_type.h b/IntelUndiPkg/I40eUndiDxe/i40e_type.h index 521315c5459e..a2114db104e6 100644 --- a/IntelUndiPkg/I40eUndiDxe/i40e_type.h +++ b/IntelUndiPkg/I40eUndiDxe/i40e_type.h @@ -1840,4 +1840,3 @@ struct i40e_profile_info { u8 name[I40E_DDP_NAME_SIZE]; }; #endif /* _I40E_TYPE_H_ */ - \ No newline at end of file diff --git a/IntelUndiPkg/I40eUndiDxe/i40e_virtchnl.h b/IntelUndiPkg/I40eUndiDxe/i40e_virtchnl.h index 2c25a79ae96a..4fb7e2428f1a 100644 --- a/IntelUndiPkg/I40eUndiDxe/i40e_virtchnl.h +++ b/IntelUndiPkg/I40eUndiDxe/i40e_virtchnl.h @@ -28,4 +28,3 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. ***************************************************************************/ - \ No newline at end of file diff --git a/IntelUndiPkg/XGigUndiDxe/AdapterInformation.c b/IntelUndiPkg/XGigUndiDxe/AdapterInformation.c index cb5c28b052f9..26556e284381 100644 --- a/IntelUndiPkg/XGigUndiDxe/AdapterInformation.c +++ b/IntelUndiPkg/XGigUndiDxe/AdapterInformation.c @@ -409,4 +409,3 @@ EFI_ADAPTER_INFORMATION_PROTOCOL gUndiAdapterInfo = { SetInformation, GetSupportedTypes }; - \ No newline at end of file diff --git a/IntelUndiPkg/XGigUndiDxe/AdapterInformation.h b/IntelUndiPkg/XGigUndiDxe/AdapterInformation.h index 72d08a891d06..3b2039bc5cb2 100644 --- a/IntelUndiPkg/XGigUndiDxe/AdapterInformation.h +++ b/IntelUndiPkg/XGigUndiDxe/AdapterInformation.h @@ -101,4 +101,3 @@ UninstallAdapterInformationProtocol ( #endif /* ADAPTER_INFORMATION_H_ */ - \ No newline at end of file diff --git a/IntelUndiPkg/XGigUndiDxe/Brand.c b/IntelUndiPkg/XGigUndiDxe/Brand.c index 9c97bb063df9..c65e57345f22 100644 --- a/IntelUndiPkg/XGigUndiDxe/Brand.c +++ b/IntelUndiPkg/XGigUndiDxe/Brand.c @@ -173,4 +173,3 @@ BRAND_STRUCT mBrandingTable[] = { }; UINTN mBrandingTableSize = (sizeof (mBrandingTable) / sizeof (mBrandingTable[0])); - \ No newline at end of file diff --git a/IntelUndiPkg/XGigUndiDxe/ComponentName.c b/IntelUndiPkg/XGigUndiDxe/ComponentName.c index c136bd7fb436..2972c28bda4e 100644 --- a/IntelUndiPkg/XGigUndiDxe/ComponentName.c +++ b/IntelUndiPkg/XGigUndiDxe/ComponentName.c @@ -276,4 +276,3 @@ EFI_DRIVER_SUPPORTED_EFI_VERSION_PROTOCOL gUndiSupportedEfiVersion = { sizeof (EFI_DRIVER_SUPPORTED_EFI_VERSION_PROTOCOL), EFI_2_70_SYSTEM_TABLE_REVISION }; - \ No newline at end of file diff --git a/IntelUndiPkg/XGigUndiDxe/ComponentName.h b/IntelUndiPkg/XGigUndiDxe/ComponentName.h index c538ea629e50..f63d58b8a18c 100644 --- a/IntelUndiPkg/XGigUndiDxe/ComponentName.h +++ b/IntelUndiPkg/XGigUndiDxe/ComponentName.h @@ -74,4 +74,3 @@ ComponentNameGetDriverName ( ); #endif /* COMPONENT_NAME_H_ */ - \ No newline at end of file diff --git a/IntelUndiPkg/XGigUndiDxe/Decode.c b/IntelUndiPkg/XGigUndiDxe/Decode.c index 675f0efca34a..70fbce64c64f 100644 --- a/IntelUndiPkg/XGigUndiDxe/Decode.c +++ b/IntelUndiPkg/XGigUndiDxe/Decode.c @@ -1851,4 +1851,3 @@ BadCdb: CdbPtr->StatFlags = PXE_STATFLAGS_COMMAND_FAILED; CdbPtr->StatCode = PXE_STATCODE_INVALID_CDB; } - \ No newline at end of file diff --git a/IntelUndiPkg/XGigUndiDxe/Decode.h b/IntelUndiPkg/XGigUndiDxe/Decode.h index c0a068716a8b..18cb4e4b1ecf 100644 --- a/IntelUndiPkg/XGigUndiDxe/Decode.h +++ b/IntelUndiPkg/XGigUndiDxe/Decode.h @@ -45,4 +45,3 @@ UndiApiEntry ( ); #endif /* DECODE_H_ */ - \ No newline at end of file diff --git a/IntelUndiPkg/XGigUndiDxe/DeviceSupport.c b/IntelUndiPkg/XGigUndiDxe/DeviceSupport.c index 65f35269eff1..c9878f997c96 100644 --- a/IntelUndiPkg/XGigUndiDxe/DeviceSupport.c +++ b/IntelUndiPkg/XGigUndiDxe/DeviceSupport.c @@ -189,4 +189,3 @@ IsDeviceIdSupported ( } return FALSE; } - \ No newline at end of file diff --git a/IntelUndiPkg/XGigUndiDxe/DeviceSupport.h b/IntelUndiPkg/XGigUndiDxe/DeviceSupport.h index e834201b5305..e997983ba3e7 100644 --- a/IntelUndiPkg/XGigUndiDxe/DeviceSupport.h +++ b/IntelUndiPkg/XGigUndiDxe/DeviceSupport.h @@ -81,4 +81,3 @@ IsDeviceIdSupported ( UINT16 DeviceId ); #endif /* DEVICE_SUPPORT_H_ */ - \ No newline at end of file diff --git a/IntelUndiPkg/XGigUndiDxe/Dma.c b/IntelUndiPkg/XGigUndiDxe/Dma.c index b8df5d387eb2..c8588df96ef5 100644 --- a/IntelUndiPkg/XGigUndiDxe/Dma.c +++ b/IntelUndiPkg/XGigUndiDxe/Dma.c @@ -282,4 +282,3 @@ UndiDmaUnmapMemory ( return Status; } - \ No newline at end of file diff --git a/IntelUndiPkg/XGigUndiDxe/Dma.h b/IntelUndiPkg/XGigUndiDxe/Dma.h index 6763c83dca39..3422acd500de 100644 --- a/IntelUndiPkg/XGigUndiDxe/Dma.h +++ b/IntelUndiPkg/XGigUndiDxe/Dma.h @@ -132,4 +132,3 @@ UndiDmaUnmapMemory ( ); #endif /* _DMA_H_ */ - \ No newline at end of file diff --git a/IntelUndiPkg/XGigUndiDxe/DriverDiagnostics.c b/IntelUndiPkg/XGigUndiDxe/DriverDiagnostics.c index 348abc8a9b91..66dc67a5400e 100644 --- a/IntelUndiPkg/XGigUndiDxe/DriverDiagnostics.c +++ b/IntelUndiPkg/XGigUndiDxe/DriverDiagnostics.c @@ -525,4 +525,3 @@ EFI_DRIVER_DIAGNOSTICS2_PROTOCOL gXgbeUndiDriverDiagnostics2 = { (EFI_DRIVER_DIAGNOSTICS2_RUN_DIAGNOSTICS) XgbeUndiDriverDiagnosticsRunDiagnostics, "en-US" }; - \ No newline at end of file diff --git a/IntelUndiPkg/XGigUndiDxe/DriverDiagnostics.h b/IntelUndiPkg/XGigUndiDxe/DriverDiagnostics.h index aafd7e65344a..4da70b1c122b 100644 --- a/IntelUndiPkg/XGigUndiDxe/DriverDiagnostics.h +++ b/IntelUndiPkg/XGigUndiDxe/DriverDiagnostics.h @@ -46,4 +46,3 @@ typedef struct { #pragma pack() #endif /* DRIVER_DIAGNOSTICS_H_ */ - \ No newline at end of file diff --git a/IntelUndiPkg/XGigUndiDxe/DriverHealth.c b/IntelUndiPkg/XGigUndiDxe/DriverHealth.c index 31a9dfc9adad..df6cfdf8a123 100644 --- a/IntelUndiPkg/XGigUndiDxe/DriverHealth.c +++ b/IntelUndiPkg/XGigUndiDxe/DriverHealth.c @@ -160,4 +160,3 @@ EFI_DRIVER_HEALTH_PROTOCOL gUndiDriverHealthProtocol = { GetHealthStatus, Repair }; - \ No newline at end of file diff --git a/IntelUndiPkg/XGigUndiDxe/DriverHealthCommon.h b/IntelUndiPkg/XGigUndiDxe/DriverHealthCommon.h index a1542333837f..6bc36d784d1e 100644 --- a/IntelUndiPkg/XGigUndiDxe/DriverHealthCommon.h +++ b/IntelUndiPkg/XGigUndiDxe/DriverHealthCommon.h @@ -34,4 +34,3 @@ typedef enum { MODULE_UNSUPPORTED, } MODULE_QUALIFICATION_STATUS; #endif /* DRIVER_HEALTH_COMMON_H_ */ - \ No newline at end of file diff --git a/IntelUndiPkg/XGigUndiDxe/EepromConfig.c b/IntelUndiPkg/XGigUndiDxe/EepromConfig.c index 4c8d8e0a70e4..deae76cab0e3 100644 --- a/IntelUndiPkg/XGigUndiDxe/EepromConfig.c +++ b/IntelUndiPkg/XGigUndiDxe/EepromConfig.c @@ -404,4 +404,3 @@ EepromUpdateChecksum ( return EFI_SUCCESS; } - \ No newline at end of file diff --git a/IntelUndiPkg/XGigUndiDxe/EepromConfig.h b/IntelUndiPkg/XGigUndiDxe/EepromConfig.h index b1aa113eb4c8..0b53f86ddd69 100644 --- a/IntelUndiPkg/XGigUndiDxe/EepromConfig.h +++ b/IntelUndiPkg/XGigUndiDxe/EepromConfig.h @@ -209,4 +209,3 @@ EepromUpdateChecksum ( #endif /* EEPROM_CONFIG_H_ */ - \ No newline at end of file diff --git a/IntelUndiPkg/XGigUndiDxe/Hii.c b/IntelUndiPkg/XGigUndiDxe/Hii.c index 7a4f5489225f..857a475622f7 100644 --- a/IntelUndiPkg/XGigUndiDxe/Hii.c +++ b/IntelUndiPkg/XGigUndiDxe/Hii.c @@ -1199,4 +1199,3 @@ EFI_HII_CONFIG_ACCESS_PROTOCOL gUndiHiiConfigAccess = { RouteConfig, DriverCallback }; - \ No newline at end of file diff --git a/IntelUndiPkg/XGigUndiDxe/Hii.h b/IntelUndiPkg/XGigUndiDxe/Hii.h index 1de4b1b3cc53..8dbc6ec854b4 100644 --- a/IntelUndiPkg/XGigUndiDxe/Hii.h +++ b/IntelUndiPkg/XGigUndiDxe/Hii.h @@ -90,4 +90,3 @@ HiiUnload ( ); #endif /* HII_H_ */ - \ No newline at end of file diff --git a/IntelUndiPkg/XGigUndiDxe/HiiInternalLib.c b/IntelUndiPkg/XGigUndiDxe/HiiInternalLib.c index 21ec03193e26..2aacb63ca158 100644 --- a/IntelUndiPkg/XGigUndiDxe/HiiInternalLib.c +++ b/IntelUndiPkg/XGigUndiDxe/HiiInternalLib.c @@ -485,4 +485,3 @@ AsciiStrToUnicodeStrWrapper ( return EFI_BUFFER_TOO_SMALL; } } - \ No newline at end of file diff --git a/IntelUndiPkg/XGigUndiDxe/HiiInternalLib.h b/IntelUndiPkg/XGigUndiDxe/HiiInternalLib.h index 49abbd280c01..28298652403a 100644 --- a/IntelUndiPkg/XGigUndiDxe/HiiInternalLib.h +++ b/IntelUndiPkg/XGigUndiDxe/HiiInternalLib.h @@ -162,4 +162,3 @@ AsciiStrToUnicodeStrWrapper ( ); #endif /* HII_INTERNAL_LIB_H_ */ - \ No newline at end of file diff --git a/IntelUndiPkg/XGigUndiDxe/Init.c b/IntelUndiPkg/XGigUndiDxe/Init.c index 4b03f0f72d5d..bffe3c165866 100644 --- a/IntelUndiPkg/XGigUndiDxe/Init.c +++ b/IntelUndiPkg/XGigUndiDxe/Init.c @@ -2173,4 +2173,3 @@ EFI_DRIVER_BINDING_PROTOCOL gUndiDriverBinding = { NULL, // ImageHandle NULL // Driver Binding Handle }; - \ No newline at end of file diff --git a/IntelUndiPkg/XGigUndiDxe/Init.h b/IntelUndiPkg/XGigUndiDxe/Init.h index 591c5fabefc4..28efcd905379 100644 --- a/IntelUndiPkg/XGigUndiDxe/Init.h +++ b/IntelUndiPkg/XGigUndiDxe/Init.h @@ -77,4 +77,3 @@ UndiGetDriverHealthStatus ( ); #endif /* INIT_H_ */ - \ No newline at end of file diff --git a/IntelUndiPkg/XGigUndiDxe/Inventory.vfr b/IntelUndiPkg/XGigUndiDxe/Inventory.vfr index 3443f460caa3..45fc887d77cb 100644 --- a/IntelUndiPkg/XGigUndiDxe/Inventory.vfr +++ b/IntelUndiPkg/XGigUndiDxe/Inventory.vfr @@ -368,4 +368,3 @@ formset endformset; - \ No newline at end of file diff --git a/IntelUndiPkg/XGigUndiDxe/NVDataStruc.h b/IntelUndiPkg/XGigUndiDxe/NVDataStruc.h index c8cd6fc42779..e5e669681b07 100644 --- a/IntelUndiPkg/XGigUndiDxe/NVDataStruc.h +++ b/IntelUndiPkg/XGigUndiDxe/NVDataStruc.h @@ -137,4 +137,3 @@ typedef struct { #define QUESTION_ID_TMP_SUPPORT_ALT_MAC_ADDR 0x1407 #define QUESTION_ID_TMP_SUPPORT_LINK_SPD_STATUS 0x1408 #endif /* NV_DATA_STRUC_H_ */ - \ No newline at end of file diff --git a/IntelUndiPkg/XGigUndiDxe/StartStop.c b/IntelUndiPkg/XGigUndiDxe/StartStop.c index e49e6c7a92ae..156e927a35c6 100644 --- a/IntelUndiPkg/XGigUndiDxe/StartStop.c +++ b/IntelUndiPkg/XGigUndiDxe/StartStop.c @@ -113,4 +113,3 @@ EFI_DRIVER_STOP_PROTOCOL gUndiDriverStop = { StopDriver, StartDriver }; - \ No newline at end of file diff --git a/IntelUndiPkg/XGigUndiDxe/StartStop.h b/IntelUndiPkg/XGigUndiDxe/StartStop.h index 97ab9f5da23e..03ad3dc9cecc 100644 --- a/IntelUndiPkg/XGigUndiDxe/StartStop.h +++ b/IntelUndiPkg/XGigUndiDxe/StartStop.h @@ -68,4 +68,3 @@ struct EFI_DRIVER_STOP_PROTOCOL_S { }; #endif /* START_STOP_H_ */ - \ No newline at end of file diff --git a/IntelUndiPkg/XGigUndiDxe/Version.h b/IntelUndiPkg/XGigUndiDxe/Version.h index 0ddd9ed7b1ce..78cc7809a16a 100644 --- a/IntelUndiPkg/XGigUndiDxe/Version.h +++ b/IntelUndiPkg/XGigUndiDxe/Version.h @@ -29,4 +29,3 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. #define MAJORVERSION 4 /* XGigUndi major version */ #define MINORVERSION 9 /* XGigUndi minor version */ #define BUILDNUMBER 99 /* XGigUndi build version */ - \ No newline at end of file diff --git a/IntelUndiPkg/XGigUndiDxe/XGigUndiDxe.inf b/IntelUndiPkg/XGigUndiDxe/XGigUndiDxe.inf index 899310735fdf..9e0e4aff0885 100644 --- a/IntelUndiPkg/XGigUndiDxe/XGigUndiDxe.inf +++ b/IntelUndiPkg/XGigUndiDxe/XGigUndiDxe.inf @@ -152,4 +152,3 @@ UNLOAD_IMAGE = UnloadXGigUndiDriver gEfiIfrTianoGuid ## CONSUMES ## Guid gEfiEventExitBootServicesGuid ## PRODUCES ## Event gEfiEventVirtualAddressChangeGuid ## PRODUCES ## Event - \ No newline at end of file diff --git a/IntelUndiPkg/XGigUndiDxe/Xgbe.c b/IntelUndiPkg/XGigUndiDxe/Xgbe.c index b8c4f6077ecc..9e3ee862fb4e 100644 --- a/IntelUndiPkg/XGigUndiDxe/Xgbe.c +++ b/IntelUndiPkg/XGigUndiDxe/Xgbe.c @@ -2401,4 +2401,3 @@ WaitForEnter ( } while (Key.UnicodeChar != 0xD); } - \ No newline at end of file diff --git a/IntelUndiPkg/XGigUndiDxe/Xgbe.h b/IntelUndiPkg/XGigUndiDxe/Xgbe.h index 27ae1470d48c..5ab088362f90 100644 --- a/IntelUndiPkg/XGigUndiDxe/Xgbe.h +++ b/IntelUndiPkg/XGigUndiDxe/Xgbe.h @@ -1172,4 +1172,3 @@ WaitForEnter ( (BUILDNUMBER / 10 << 12) + (BUILDNUMBER % 10 << 8)) #endif /* XGBE_H_ */ - \ No newline at end of file diff --git a/IntelUndiPkg/XGigUndiDxe/ixgbe_82598.c b/IntelUndiPkg/XGigUndiDxe/ixgbe_82598.c index e6828519e4f1..adb62177a272 100644 --- a/IntelUndiPkg/XGigUndiDxe/ixgbe_82598.c +++ b/IntelUndiPkg/XGigUndiDxe/ixgbe_82598.c @@ -1536,4 +1536,3 @@ s32 ixgbe_enable_rx_dma_82598(struct ixgbe_hw *hw, u32 regval) return IXGBE_SUCCESS; } - \ No newline at end of file diff --git a/IntelUndiPkg/XGigUndiDxe/ixgbe_82598.h b/IntelUndiPkg/XGigUndiDxe/ixgbe_82598.h index 297d880c621c..75ca431239d2 100644 --- a/IntelUndiPkg/XGigUndiDxe/ixgbe_82598.h +++ b/IntelUndiPkg/XGigUndiDxe/ixgbe_82598.h @@ -52,4 +52,3 @@ void ixgbe_set_lan_id_multi_port_pcie_82598(struct ixgbe_hw *hw); void ixgbe_set_pcie_completion_timeout(struct ixgbe_hw *hw); s32 ixgbe_enable_rx_dma_82598(struct ixgbe_hw *hw, u32 regval); #endif /* _IXGBE_82598_H_ */ - \ No newline at end of file diff --git a/IntelUndiPkg/XGigUndiDxe/ixgbe_82599.c b/IntelUndiPkg/XGigUndiDxe/ixgbe_82599.c index 34e9e5273b75..2fb101ea49f8 100644 --- a/IntelUndiPkg/XGigUndiDxe/ixgbe_82599.c +++ b/IntelUndiPkg/XGigUndiDxe/ixgbe_82599.c @@ -2783,4 +2783,3 @@ release_i2c_access: return status; } - \ No newline at end of file diff --git a/IntelUndiPkg/XGigUndiDxe/ixgbe_82599.h b/IntelUndiPkg/XGigUndiDxe/ixgbe_82599.h index 3187c369acc7..aff0481f2612 100644 --- a/IntelUndiPkg/XGigUndiDxe/ixgbe_82599.h +++ b/IntelUndiPkg/XGigUndiDxe/ixgbe_82599.h @@ -65,4 +65,3 @@ s32 ixgbe_get_protected_blocks_82599(struct ixgbe_hw *hw, s32 prot_autoc_read_82599(struct ixgbe_hw *hw, bool *locked, u32 *reg_val); s32 prot_autoc_write_82599(struct ixgbe_hw *hw, u32 reg_val, bool locked); #endif /* _IXGBE_82599_H_ */ - \ No newline at end of file diff --git a/IntelUndiPkg/XGigUndiDxe/ixgbe_api.c b/IntelUndiPkg/XGigUndiDxe/ixgbe_api.c index c026024d8e10..88e10ca9c49f 100644 --- a/IntelUndiPkg/XGigUndiDxe/ixgbe_api.c +++ b/IntelUndiPkg/XGigUndiDxe/ixgbe_api.c @@ -1779,4 +1779,3 @@ void ixgbe_set_rate_select_speed(struct ixgbe_hw *hw, ixgbe_link_speed speed) if (hw->mac.ops.set_rate_select_speed) hw->mac.ops.set_rate_select_speed(hw, speed); } - \ No newline at end of file diff --git a/IntelUndiPkg/XGigUndiDxe/ixgbe_api.h b/IntelUndiPkg/XGigUndiDxe/ixgbe_api.h index 10604eca92d0..6bcf5dc1ebc6 100644 --- a/IntelUndiPkg/XGigUndiDxe/ixgbe_api.h +++ b/IntelUndiPkg/XGigUndiDxe/ixgbe_api.h @@ -242,4 +242,3 @@ s32 ixgbe_negotiate_fc(struct ixgbe_hw *hw, u32 adv_reg, u32 lp_reg, u32 adv_sym, u32 adv_asm, u32 lp_sym, u32 lp_asm); #endif /* _IXGBE_API_H_ */ - \ No newline at end of file diff --git a/IntelUndiPkg/XGigUndiDxe/ixgbe_common.c b/IntelUndiPkg/XGigUndiDxe/ixgbe_common.c index 4c6c79c67a24..62bdde1e1f9e 100644 --- a/IntelUndiPkg/XGigUndiDxe/ixgbe_common.c +++ b/IntelUndiPkg/XGigUndiDxe/ixgbe_common.c @@ -6064,4 +6064,3 @@ void ixgbe_set_soft_rate_select_speed(struct ixgbe_hw *hw, out: return; } - \ No newline at end of file diff --git a/IntelUndiPkg/XGigUndiDxe/ixgbe_common.h b/IntelUndiPkg/XGigUndiDxe/ixgbe_common.h index 8557565344f5..4444e8b1eb27 100644 --- a/IntelUndiPkg/XGigUndiDxe/ixgbe_common.h +++ b/IntelUndiPkg/XGigUndiDxe/ixgbe_common.h @@ -238,4 +238,3 @@ s32 ixgbe_setup_mac_link_multispeed_fiber(struct ixgbe_hw *hw, void ixgbe_set_soft_rate_select_speed(struct ixgbe_hw *hw, ixgbe_link_speed speed); #endif /* IXGBE_COMMON */ - \ No newline at end of file diff --git a/IntelUndiPkg/XGigUndiDxe/ixgbe_dcb.h b/IntelUndiPkg/XGigUndiDxe/ixgbe_dcb.h index fbc75e3f37f9..291059da8f5b 100644 --- a/IntelUndiPkg/XGigUndiDxe/ixgbe_dcb.h +++ b/IntelUndiPkg/XGigUndiDxe/ixgbe_dcb.h @@ -167,4 +167,3 @@ u8 ixgbe_dcb_get_tc_from_up(struct ixgbe_dcb_config *, int, u8); s32 ixgbe_dcb_hw_config(struct ixgbe_hw *, u16 *, u16 *, u8 *, u8 *, u8 *); s32 ixgbe_dcb_hw_config_cee(struct ixgbe_hw *, struct ixgbe_dcb_config *); #endif /* _IXGBE_DCB_H_ */ - \ No newline at end of file diff --git a/IntelUndiPkg/XGigUndiDxe/ixgbe_dcb_82599.h b/IntelUndiPkg/XGigUndiDxe/ixgbe_dcb_82599.h index 4aa05b8049e9..d5b4fc309f92 100644 --- a/IntelUndiPkg/XGigUndiDxe/ixgbe_dcb_82599.h +++ b/IntelUndiPkg/XGigUndiDxe/ixgbe_dcb_82599.h @@ -146,4 +146,3 @@ s32 ixgbe_dcb_config_82599(struct ixgbe_hw *, s32 ixgbe_dcb_hw_config_82599(struct ixgbe_hw *, int, u16 *, u16 *, u8 *, u8 *, u8 *); #endif /* _IXGBE_DCB_82959_H_ */ - \ No newline at end of file diff --git a/IntelUndiPkg/XGigUndiDxe/ixgbe_osdep.h b/IntelUndiPkg/XGigUndiDxe/ixgbe_osdep.h index a7d4af9bcd6e..6fa0d1605c7c 100644 --- a/IntelUndiPkg/XGigUndiDxe/ixgbe_osdep.h +++ b/IntelUndiPkg/XGigUndiDxe/ixgbe_osdep.h @@ -553,4 +553,3 @@ typedef BOOLEAN boolean_t; #define IXGBE_BE16_TO_CPU(a) IxgbeReverseWord (a) #endif /* IXGBE_OSDEP_H_ */ - \ No newline at end of file diff --git a/IntelUndiPkg/XGigUndiDxe/ixgbe_phy.c b/IntelUndiPkg/XGigUndiDxe/ixgbe_phy.c index 843ea3ce2856..5d748b0603f2 100644 --- a/IntelUndiPkg/XGigUndiDxe/ixgbe_phy.c +++ b/IntelUndiPkg/XGigUndiDxe/ixgbe_phy.c @@ -2742,4 +2742,3 @@ s32 ixgbe_set_copper_phy_power(struct ixgbe_hw *hw, bool on) reg); return status; } - \ No newline at end of file diff --git a/IntelUndiPkg/XGigUndiDxe/ixgbe_phy.h b/IntelUndiPkg/XGigUndiDxe/ixgbe_phy.h index c317dfcb3e6b..f79d48b64c3f 100644 --- a/IntelUndiPkg/XGigUndiDxe/ixgbe_phy.h +++ b/IntelUndiPkg/XGigUndiDxe/ixgbe_phy.h @@ -214,4 +214,3 @@ s32 ixgbe_read_i2c_combined_generic_int(struct ixgbe_hw *, u8 addr, u16 reg, s32 ixgbe_write_i2c_combined_generic_int(struct ixgbe_hw *, u8 addr, u16 reg, u16 val, bool lock); #endif /* _IXGBE_PHY_H_ */ - \ No newline at end of file diff --git a/IntelUndiPkg/XGigUndiDxe/ixgbe_type.h b/IntelUndiPkg/XGigUndiDxe/ixgbe_type.h index e11bf564dac4..e3bb1a8a313e 100644 --- a/IntelUndiPkg/XGigUndiDxe/ixgbe_type.h +++ b/IntelUndiPkg/XGigUndiDxe/ixgbe_type.h @@ -4539,4 +4539,3 @@ struct ixgbe_hw { #endif /* IXGBE_OSDEP2 */ #endif /* _IXGBE_TYPE_H_ */ - \ No newline at end of file diff --git a/IntelUndiPkg/XGigUndiDxe/ixgbe_x540.c b/IntelUndiPkg/XGigUndiDxe/ixgbe_x540.c index 6d89d8f4f440..f7f75ac52daf 100644 --- a/IntelUndiPkg/XGigUndiDxe/ixgbe_x540.c +++ b/IntelUndiPkg/XGigUndiDxe/ixgbe_x540.c @@ -1147,4 +1147,3 @@ s32 ixgbe_get_protected_blocks_X540(struct ixgbe_hw *hw, return status; } - \ No newline at end of file diff --git a/IntelUndiPkg/XGigUndiDxe/ixgbe_x540.h b/IntelUndiPkg/XGigUndiDxe/ixgbe_x540.h index 40b6715ed37a..aa919940141f 100644 --- a/IntelUndiPkg/XGigUndiDxe/ixgbe_x540.h +++ b/IntelUndiPkg/XGigUndiDxe/ixgbe_x540.h @@ -67,4 +67,3 @@ s32 ixgbe_get_protected_blocks_X540(struct ixgbe_hw *hw, u16 *eeprom_buffer, u32 eeprom_size); #endif /* _IXGBE_X540_H_ */ - \ No newline at end of file diff --git a/IntelUndiPkg/XGigUndiDxe/ixgbe_x550.c b/IntelUndiPkg/XGigUndiDxe/ixgbe_x550.c index 92df8322f1ed..d49eb94732c3 100644 --- a/IntelUndiPkg/XGigUndiDxe/ixgbe_x550.c +++ b/IntelUndiPkg/XGigUndiDxe/ixgbe_x550.c @@ -4795,4 +4795,3 @@ s32 ixgbe_get_protected_blocks_X550(struct ixgbe_hw *hw, return status; } - \ No newline at end of file diff --git a/IntelUndiPkg/XGigUndiDxe/ixgbe_x550.h b/IntelUndiPkg/XGigUndiDxe/ixgbe_x550.h index 45303564fd8d..209a2b5bec0f 100644 --- a/IntelUndiPkg/XGigUndiDxe/ixgbe_x550.h +++ b/IntelUndiPkg/XGigUndiDxe/ixgbe_x550.h @@ -126,4 +126,3 @@ s32 ixgbe_get_protected_blocks_X550(struct ixgbe_hw *hw, u16 *blocks_size, u32 block_type_mask, u16 *eeprom_buffer, u32 eeprom_size); #endif /* _IXGBE_X550_H_ */ - \ No newline at end of file diff --git a/IntelUndiPkg/XGigUndiDxe/wol/wol.c b/IntelUndiPkg/XGigUndiDxe/wol/wol.c index 6baf345fb8ee..c4b708d56e46 100644 --- a/IntelUndiPkg/XGigUndiDxe/wol/wol.c +++ b/IntelUndiPkg/XGigUndiDxe/wol/wol.c @@ -316,4 +316,3 @@ WolEnableWakeOnLanEx( return WolGetWakeOnLanStatusEx(Handle); } - \ No newline at end of file diff --git a/IntelUndiPkg/XGigUndiDxe/wol/wol.h b/IntelUndiPkg/XGigUndiDxe/wol/wol.h index edcc250f3140..dfafbe6f4a1d 100644 --- a/IntelUndiPkg/XGigUndiDxe/wol/wol.h +++ b/IntelUndiPkg/XGigUndiDxe/wol/wol.h @@ -79,4 +79,3 @@ WolEnableApmPme( #endif /* __WOL_H */ - \ No newline at end of file diff --git a/IntelUndiPkg/XGigUndiDxe/wol/wol_10G.c b/IntelUndiPkg/XGigUndiDxe/wol/wol_10G.c index c61de75970e9..6446ab0f7f77 100644 --- a/IntelUndiPkg/XGigUndiDxe/wol/wol_10G.c +++ b/IntelUndiPkg/XGigUndiDxe/wol/wol_10G.c @@ -69,4 +69,3 @@ BOOLEAN _WolGetInfoFromEeprom_10G(WOL_ADAPTER_HANDLE_TYPE Handle) return FALSE; } - \ No newline at end of file diff --git a/IntelUndiPkg/XGigUndiDxe/wol/wolfamily.c b/IntelUndiPkg/XGigUndiDxe/wol/wolfamily.c index 866a8330c0a1..4affb3aadb16 100644 --- a/IntelUndiPkg/XGigUndiDxe/wol/wolfamily.c +++ b/IntelUndiPkg/XGigUndiDxe/wol/wolfamily.c @@ -81,4 +81,3 @@ WOL_MAC_TYPE const WOL_LASER_TABLE[] = { 0 }; - \ No newline at end of file diff --git a/IntelUndiPkg/XGigUndiDxe/wol/wolimpl.c b/IntelUndiPkg/XGigUndiDxe/wol/wolimpl.c index d00eb5d82820..f280f7adcbb7 100644 --- a/IntelUndiPkg/XGigUndiDxe/wol/wolimpl.c +++ b/IntelUndiPkg/XGigUndiDxe/wol/wolimpl.c @@ -83,4 +83,3 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. return Handle->NicInfo.Function; } - \ No newline at end of file diff --git a/IntelUndiPkg/XGigUndiDxe/wol/wolimpl.h b/IntelUndiPkg/XGigUndiDxe/wol/wolimpl.h index eaea7675138d..d3dc0e268bd3 100644 --- a/IntelUndiPkg/XGigUndiDxe/wol/wolimpl.h +++ b/IntelUndiPkg/XGigUndiDxe/wol/wolimpl.h @@ -76,4 +76,3 @@ WOL_STATUS _WolEepromWrite16(WOL_ADAPTER_HANDLE_TYPE Handle, UINT16 Offset, UINT WOL_STATUS _WolEepromUpdateChecksum(WOL_ADAPTER_HANDLE_TYPE Handle); #endif /* __WOLIMPL_H */ - \ No newline at end of file diff --git a/IntelUndiPkg/XGigUndiDxe/wol/wolinfo.c b/IntelUndiPkg/XGigUndiDxe/wol/wolinfo.c index 7e49225c451d..ad12ddb1af37 100644 --- a/IntelUndiPkg/XGigUndiDxe/wol/wolinfo.c +++ b/IntelUndiPkg/XGigUndiDxe/wol/wolinfo.c @@ -175,4 +175,3 @@ _WOL_DEVICE_INFO_t const WOL_DEVICE_INFO_TABLE[] = { { 0, 0, 0, 0, 0 } /* Last entry */ }; - \ No newline at end of file From patchwork Tue Nov 6 17:58:17 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Ard Biesheuvel X-Patchwork-Id: 150305 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp4191947ljp; Tue, 6 Nov 2018 09:59:00 -0800 (PST) X-Google-Smtp-Source: AJdET5cG0YyjLARYgNCTVcITaA1IvQfYY22izUAiUt6e7xn+WlGKs2r9RcasFu6BoViaZrpDAjDY X-Received: by 2002:a17:902:3103:: with SMTP id w3-v6mr27908865plb.51.1541527140327; Tue, 06 Nov 2018 09:59:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1541527140; cv=none; d=google.com; s=arc-20160816; b=o7wLKVkiVTEXa+tjAnOmUxG4HU9OG2LBHzZrvMNAo3siDMCpiz0it7//F2nIP7kTXx qdMz31PaiRj6IYv+ahT1XXfQSM6kAtCD0coOAlYQ7sGq9SZ7ZqhzTiOCj6CatiF7dVOq iXd32pICyvEet6Mfc9ni0KIBf3Ae0GDVTXOLzpuQ+8wXuRsN8fuj3QEN7zfDCDNcCdQ3 GZr09VUycDV7G51M1uvjYfKuF4s/1F/jnf0j6nqX3FHCacYyAOY1pR89RECxtltXUZQS ZMnIdsZSZsXmkFZhM22aePIvRReoSXheBSQaH43Nbg76doq3eBmnH5Elup925iBYOx9f cHOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:references:in-reply-to:message-id :date:to:from:dkim-signature:delivered-to; bh=kUiBcuLkUgtBnvXH4GV/t1/t9TAY5rogZ/sVlIgu+Yo=; b=pnJgq+c/D1I91JfzncgKw5eOht2EozCd7gdTU6u10bbT8R+Q/SnDk2pnAqRpX8wVBj YvE79mOQLU2Fr7SSMScS/Z+OoUNIaqG2wo967j/6SWBKLqCzAZvvJaZWXyRv/zuua1S1 Xf1Q+3qXd8sB/ObRvG8f/NUo3lRIPwOyLHD3oLHKCc3O5+x9aoJNTHkRvFxqEBtcXUmJ 0Wm8JHIAaE+DMG0D4LrmyjcUfiVOUdiBNmSDiKx6BS6ISRL4vuzDG6sVUFdTw2ianfIF J+aA73Du/oz2H6sQFi8Wtvuk3FFazrq1XsavsHxXU8OtoFv8xvTqpCQN9X5+rQ4+E0Yk v1kA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=kRt8QoLI; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from ml01.01.org (ml01.01.org. [198.145.21.10]) by mx.google.com with ESMTPS id 31-v6si15973586plc.140.2018.11.06.09.59.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Nov 2018 09:59:00 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) client-ip=198.145.21.10; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=kRt8QoLI; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id E031B2194D3B9; Tue, 6 Nov 2018 09:58:56 -0800 (PST) X-Original-To: edk2-devel@lists.01.org Delivered-To: edk2-devel@lists.01.org Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::442; helo=mail-wr1-x442.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id EA72821189FB2 for ; Tue, 6 Nov 2018 09:58:54 -0800 (PST) Received: by mail-wr1-x442.google.com with SMTP id d10-v6so14574199wrs.5 for ; Tue, 06 Nov 2018 09:58:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=tmkY+Ed6geKo4LsJR8xXXPCh8sZb1dYgekdo91NdCTU=; b=kRt8QoLIblAtluIfIm/RdhGLD8vMDn6gf8qrZaWTsA5ME/zlp97tPWuiSzU0WlGNNt U+FYxFxZuS8GGl7KMW6rfG7zarwoSywVPSF8f3+5xqXHf4+aWkRSZihopgLbrNSU2plz 0+LtPfIoQIJBevvVhWyxfqIP0zK0/Nx+h+mGQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=tmkY+Ed6geKo4LsJR8xXXPCh8sZb1dYgekdo91NdCTU=; b=XJ6GbkfKjHe+nd0v1xmOdkNeTMHlPaIW2/0OPqIhjMbmqBWoHFKcqUOAJ+U19mnPbu CSg9iYvgKMiFTyv+fOBMLFocjWkd/HOcHqcbEDEFoYRiEW2CPySdGkBhSf4+NaXfhHWm ou53rXykgY0y7BoKOHAS2NHdYRJvyTohuXwxePEKG1eIhUBBZ4YAmYhGniRqSZ5t+4YY LVEzReOqAngX0KOtTF1vmWU0NAvRoZCuGmhlGbvBM88QyS59LgyykkISxglb7nxluxg4 t6j4lFjPoaTQt3JmbF6QCHDlK4XVmVj7xW8wNtGM/iz4Ih/PnaMEKHihgFC1cOtTk/gY eJjA== X-Gm-Message-State: AGRZ1gLq4X2ErT2oO8zTPh9x9YZQlnIREHYm2+eQ7dPusPMrKeeafh9/ Ibg8QmpzAkw65kVURDgp6h58CUJfz5E= X-Received: by 2002:adf:fb4b:: with SMTP id c11-v6mr23687021wrs.117.1541527132750; Tue, 06 Nov 2018 09:58:52 -0800 (PST) Received: from localhost.localdomain (laubervilliers-657-1-83-120.w92-154.abo.wanadoo.fr. [92.154.90.120]) by smtp.gmail.com with ESMTPSA id 134-v6sm2971522wmp.6.2018.11.06.09.58.51 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Nov 2018 09:58:51 -0800 (PST) From: Ard Biesheuvel To: edk2-devel@lists.01.org Date: Tue, 6 Nov 2018 18:58:17 +0100 Message-Id: <20181106175833.26964-4-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181106175833.26964-1-ard.biesheuvel@linaro.org> References: <20181106175833.26964-1-ard.biesheuvel@linaro.org> MIME-Version: 1.0 Subject: [edk2] [PATCH edk2-staging 03/19] IntelUndiPkg/GigUndiDxe: consistently use lowercase for e1000 in filenames X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: michael.d.kinney@intel.com, eric.jin@intel.com Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" Rename E1000.[ch] and E1000_osdep.[ch] to all lowercase, and replace all #include references with lowercase ones as well. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- IntelUndiPkg/GigUndiDxe/AdapterInformation.c | 2 +- IntelUndiPkg/GigUndiDxe/ComponentName.c | 2 +- IntelUndiPkg/GigUndiDxe/Decode.c | 2 +- IntelUndiPkg/GigUndiDxe/DeviceSupport.h | 2 +- IntelUndiPkg/GigUndiDxe/Dma.c | 2 +- IntelUndiPkg/GigUndiDxe/DriverConfiguration.c | 2 +- IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c | 2 +- IntelUndiPkg/GigUndiDxe/DriverHealth.c | 2 +- IntelUndiPkg/GigUndiDxe/EepromConfig.h | 2 +- IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf | 8 ++++---- IntelUndiPkg/GigUndiDxe/Init.c | 2 +- IntelUndiPkg/GigUndiDxe/StartStop.c | 2 +- IntelUndiPkg/GigUndiDxe/StartStop.h | 2 +- IntelUndiPkg/GigUndiDxe/{E1000.c => e1000.c} | 2 +- IntelUndiPkg/GigUndiDxe/{E1000.h => e1000.h} | 0 IntelUndiPkg/GigUndiDxe/{E1000_osdep.c => e1000_osdep.c} | 2 +- IntelUndiPkg/GigUndiDxe/{E1000_osdep.h => e1000_osdep.h} | 0 IntelUndiPkg/GigUndiDxe/wol/wolimpl.h | 2 +- 18 files changed, 19 insertions(+), 19 deletions(-) -- 2.19.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Ryszard Knop diff --git a/IntelUndiPkg/GigUndiDxe/AdapterInformation.c b/IntelUndiPkg/GigUndiDxe/AdapterInformation.c index b0320b11839b..8918c538e447 100644 --- a/IntelUndiPkg/GigUndiDxe/AdapterInformation.c +++ b/IntelUndiPkg/GigUndiDxe/AdapterInformation.c @@ -28,7 +28,7 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. ***************************************************************************/ #include "Uefi.h" -#include "E1000.h" +#include "e1000.h" #include "AdapterInformation.h" diff --git a/IntelUndiPkg/GigUndiDxe/ComponentName.c b/IntelUndiPkg/GigUndiDxe/ComponentName.c index 1473bfbed0af..70baf00f4a5d 100644 --- a/IntelUndiPkg/GigUndiDxe/ComponentName.c +++ b/IntelUndiPkg/GigUndiDxe/ComponentName.c @@ -26,7 +26,7 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. ***************************************************************************/ -#include "E1000.h" +#include "e1000.h" #include "ComponentName.h" #include "DeviceSupport.h" diff --git a/IntelUndiPkg/GigUndiDxe/Decode.c b/IntelUndiPkg/GigUndiDxe/Decode.c index 88e8be315bd1..14060db0d050 100644 --- a/IntelUndiPkg/GigUndiDxe/Decode.c +++ b/IntelUndiPkg/GigUndiDxe/Decode.c @@ -26,7 +26,7 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. ***************************************************************************/ -#include "E1000.h" +#include "e1000.h" #include /** This routine determines the operational state of the UNDI. It updates the state flags in the diff --git a/IntelUndiPkg/GigUndiDxe/DeviceSupport.h b/IntelUndiPkg/GigUndiDxe/DeviceSupport.h index f309044d9b9d..e156b587f6a7 100644 --- a/IntelUndiPkg/GigUndiDxe/DeviceSupport.h +++ b/IntelUndiPkg/GigUndiDxe/DeviceSupport.h @@ -29,7 +29,7 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. #ifndef DEVICE_SUPPORT_H_ #define DEVICE_SUPPORT_H_ -#include "E1000.h" +#include "e1000.h" typedef struct BRAND_STRUCT_S BRAND_STRUCT; diff --git a/IntelUndiPkg/GigUndiDxe/Dma.c b/IntelUndiPkg/GigUndiDxe/Dma.c index 76a3fcf69601..bf94c1e2fd54 100644 --- a/IntelUndiPkg/GigUndiDxe/Dma.c +++ b/IntelUndiPkg/GigUndiDxe/Dma.c @@ -27,7 +27,7 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. ***************************************************************************/ -#include "E1000.h" +#include "e1000.h" #include "Dma.h" diff --git a/IntelUndiPkg/GigUndiDxe/DriverConfiguration.c b/IntelUndiPkg/GigUndiDxe/DriverConfiguration.c index 118c1b2b9b04..20d40ab672ef 100644 --- a/IntelUndiPkg/GigUndiDxe/DriverConfiguration.c +++ b/IntelUndiPkg/GigUndiDxe/DriverConfiguration.c @@ -26,7 +26,7 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. ***************************************************************************/ -#include "E1000.h" +#include "e1000.h" #include "DriverConfiguration.h" /* Protocol structure tentative definition */ diff --git a/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c b/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c index a9f176ce5324..559f2133281e 100644 --- a/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c +++ b/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c @@ -26,7 +26,7 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. ***************************************************************************/ -#include "E1000.h" +#include "e1000.h" #include "DriverDiagnostics.h" /* Protocol structures tentative definitions */ diff --git a/IntelUndiPkg/GigUndiDxe/DriverHealth.c b/IntelUndiPkg/GigUndiDxe/DriverHealth.c index b1af371e06db..b5b7db5fd814 100644 --- a/IntelUndiPkg/GigUndiDxe/DriverHealth.c +++ b/IntelUndiPkg/GigUndiDxe/DriverHealth.c @@ -26,7 +26,7 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. ***************************************************************************/ -#include "E1000.h" +#include "e1000.h" /** Retrieves the health status of a controller in the platform. diff --git a/IntelUndiPkg/GigUndiDxe/EepromConfig.h b/IntelUndiPkg/GigUndiDxe/EepromConfig.h index e0d31f6a151d..272292d107e1 100644 --- a/IntelUndiPkg/GigUndiDxe/EepromConfig.h +++ b/IntelUndiPkg/GigUndiDxe/EepromConfig.h @@ -29,7 +29,7 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. #ifndef EEPROM_CONFIG_H_ #define EEPROM_CONFIG_H_ -#include "E1000.h" +#include "e1000.h" // EEPROM power management bit definitions #define E1000_INIT_CONTROL_WORD1 0x0A diff --git a/IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf b/IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf index 2d2d0707a686..0e4462733df6 100644 --- a/IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf +++ b/IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf @@ -72,8 +72,8 @@ DriverConfiguration.c DriverConfiguration.h DriverDiagnostics.c DriverDiagnostics.h -E1000.h -E1000.c +e1000.h +e1000.c e1000_80003es2lan.h e1000_80003es2lan.c e1000_82571.h @@ -92,8 +92,8 @@ e1000_manage.h e1000_manage.c e1000_nvm.h e1000_nvm.c -E1000_osdep.h -E1000_osdep.c +e1000_osdep.h +e1000_osdep.c e1000_phy.h e1000_phy.c e1000_regs.h diff --git a/IntelUndiPkg/GigUndiDxe/Init.c b/IntelUndiPkg/GigUndiDxe/Init.c index 47ed03eb0849..74b933674589 100644 --- a/IntelUndiPkg/GigUndiDxe/Init.c +++ b/IntelUndiPkg/GigUndiDxe/Init.c @@ -26,7 +26,7 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. ***************************************************************************/ -#include "E1000.h" +#include "e1000.h" #include "Init.h" #include "DeviceSupport.h" #include "Decode.h" diff --git a/IntelUndiPkg/GigUndiDxe/StartStop.c b/IntelUndiPkg/GigUndiDxe/StartStop.c index 10ab4e51bf44..32bed7ce288d 100644 --- a/IntelUndiPkg/GigUndiDxe/StartStop.c +++ b/IntelUndiPkg/GigUndiDxe/StartStop.c @@ -26,7 +26,7 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. ***************************************************************************/ -#include "E1000.h" +#include "e1000.h" #include "StartStop.h" EFI_GUID gEfiStartStopProtocolGuid = EFI_DRIVER_STOP_PROTOCOL_GUID; diff --git a/IntelUndiPkg/GigUndiDxe/StartStop.h b/IntelUndiPkg/GigUndiDxe/StartStop.h index 24304d6cc3a7..255f17aabaa4 100644 --- a/IntelUndiPkg/GigUndiDxe/StartStop.h +++ b/IntelUndiPkg/GigUndiDxe/StartStop.h @@ -29,7 +29,7 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. #ifndef START_STOP_H_ #define START_STOP_H_ -#include "E1000.h" +#include "e1000.h" #define EFI_DRIVER_STOP_PROTOCOL_GUID \ { 0x34d59603, 0x1428, 0x4429, 0xa4, 0x14, 0xe6, 0xb3, \ diff --git a/IntelUndiPkg/GigUndiDxe/E1000.c b/IntelUndiPkg/GigUndiDxe/e1000.c similarity index 99% rename from IntelUndiPkg/GigUndiDxe/E1000.c rename to IntelUndiPkg/GigUndiDxe/e1000.c index fad20d988441..6f8529abf046 100644 --- a/IntelUndiPkg/GigUndiDxe/E1000.c +++ b/IntelUndiPkg/GigUndiDxe/e1000.c @@ -26,7 +26,7 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. ***************************************************************************/ -#include "E1000.h" +#include "e1000.h" #include "DeviceSupport.h" diff --git a/IntelUndiPkg/GigUndiDxe/E1000.h b/IntelUndiPkg/GigUndiDxe/e1000.h similarity index 100% rename from IntelUndiPkg/GigUndiDxe/E1000.h rename to IntelUndiPkg/GigUndiDxe/e1000.h diff --git a/IntelUndiPkg/GigUndiDxe/E1000_osdep.c b/IntelUndiPkg/GigUndiDxe/e1000_osdep.c similarity index 99% rename from IntelUndiPkg/GigUndiDxe/E1000_osdep.c rename to IntelUndiPkg/GigUndiDxe/e1000_osdep.c index 0d0047a93048..3aa18e735dee 100644 --- a/IntelUndiPkg/GigUndiDxe/E1000_osdep.c +++ b/IntelUndiPkg/GigUndiDxe/e1000_osdep.c @@ -26,7 +26,7 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. ***************************************************************************/ -#include "E1000.h" +#include "e1000.h" /** Reads from the PCI capabality region. diff --git a/IntelUndiPkg/GigUndiDxe/E1000_osdep.h b/IntelUndiPkg/GigUndiDxe/e1000_osdep.h similarity index 100% rename from IntelUndiPkg/GigUndiDxe/E1000_osdep.h rename to IntelUndiPkg/GigUndiDxe/e1000_osdep.h diff --git a/IntelUndiPkg/GigUndiDxe/wol/wolimpl.h b/IntelUndiPkg/GigUndiDxe/wol/wolimpl.h index ed2ffc427093..ec67d000e9ae 100644 --- a/IntelUndiPkg/GigUndiDxe/wol/wolimpl.h +++ b/IntelUndiPkg/GigUndiDxe/wol/wolimpl.h @@ -29,7 +29,7 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. #ifndef __WOLIMPL_H #define __WOLIMPL_H -#include +#include #define WOL_1G 2 typedef UNDI_PRIVATE_DATA *WOL_ADAPTER_HANDLE_TYPE; From patchwork Tue Nov 6 17:58:18 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Ard Biesheuvel X-Patchwork-Id: 150306 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp4192011ljp; Tue, 6 Nov 2018 09:59:04 -0800 (PST) X-Google-Smtp-Source: AJdET5eQZ/t3ojuXVwOV8azilQK0sWfU7LJUW7UjwOjuvzM7gUNbcfWfxfRgsrBysMjO0p3CbIvT X-Received: by 2002:a63:2214:: with SMTP id i20mr17048338pgi.83.1541527143875; Tue, 06 Nov 2018 09:59:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1541527143; cv=none; d=google.com; s=arc-20160816; b=KhAGymTvAKMFwbYgheqP1CSBfwDZ7LacYLqVv046rkM1ki0X2QuH2IaqWqrGTizloX 6+RRxShbmRr3m4Wv+DvoCO6vbK6LaQNPsz1dL5WL3kjJTqaSZNfLI8bHwQK2szj6rnIt rkxBCOGpEEpS9iIGTCWQ4vt6Kjn5/SynT+PrNWdbxysOBI9liFR5rhWkEyoQ36YCjPvC 5LtvIIo7iTKkWlxSTlYpIk2gJMx6mA/DbvlfOlyy1ksgRHdfJ9BEZBs73P9HouRMPU06 OjCQen5zNvFtRUs0QOJmP0U8JN9EgXKxXjHScR1fcn0c3637n9gYRdFToogzV3t0PGtB mfaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:references:in-reply-to:message-id :date:to:from:dkim-signature:delivered-to; bh=9t0S6SsjE3QeOZO450Omu+HiBzaXwrwXtrMJI+qHSH8=; b=x27uY1hKqXr8xvPmVU3qTHHwrIC3MgjeGG7uQZP8r+vZZ9gn3eU0vf8dWueEBEmn9b OaHjlcIjw6AmayWIpJvVJrRq6Fv6v0VdJJr3w/7QD8itMITrJNC7qNfMFR7UzI/j9hKZ gU3wxNr6gYbIw91IJ2uZqpu87364+6hQ4TST5b2qRnfq5N2l2Gxm+2B2d/w0uRz0Zx5h /4P7D1mdOmBwZzl6eo+UxsgB3IVbF7zHtW8jnnDkg4d5shrIRgDwm16PQQUjFF2XUDIK CBiaeN3RdYweMCHsB6CzLkxaPXOfCimXGb9WKb422Vr78EIiRgASiM4br12XYFJtqGRW 7yfQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=V4qHjIW3; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from ml01.01.org (ml01.01.org. [198.145.21.10]) by mx.google.com with ESMTPS id x124-v6si45401136pfb.154.2018.11.06.09.59.03 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Nov 2018 09:59:03 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) client-ip=198.145.21.10; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=V4qHjIW3; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 1DD652118C4FC; Tue, 6 Nov 2018 09:58:58 -0800 (PST) X-Original-To: edk2-devel@lists.01.org Delivered-To: edk2-devel@lists.01.org Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::444; helo=mail-wr1-x444.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 475EC21BADAB2 for ; Tue, 6 Nov 2018 09:58:56 -0800 (PST) Received: by mail-wr1-x444.google.com with SMTP id u9-v6so4227536wrr.0 for ; Tue, 06 Nov 2018 09:58:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=4Eo+TF3XCmuTssZs5IV1JVTLJwyzJYyKeHrAlujHoUc=; b=V4qHjIW3kcJq6ruj4qbcS+pVRnIgZ/a14yh1Yy5RVbx3l1i0J0wgBHrMRVycRiy/KW K8IPYsnfS9GSmDIeMYegrDayV+VaLD+b+iUGWhvDVuGUyQRHN7VrCRC5Re9q7il+/0V8 AgTEejehZH0dWIUakINESSHioAMSKCMm0X+U0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=4Eo+TF3XCmuTssZs5IV1JVTLJwyzJYyKeHrAlujHoUc=; b=pNlisbuWv+5+u41/+tRpkn6q38cxt88cgxJLL9tp61XGzuLQmOaIWWXWg3qCXnhck9 F/JUtz6ybTqawnD6pWjZYtdT+XCCxk13XM5zZDPKOfqSA1oNC0HWMRYd+jIVjN6jNbaX BDcApWM+RStJWGK0DlNNYK9C2/xNCQM4yYy38/xp8uhYC/u0Zk5wDbgwFem5AI9qh0N0 SZ22MOL1J40wtQiRXNDL5QxzE2VLUdYi4BLLWpmiA2JuH6xFGZe4QZenNzhz9jpui6tE D9cJJLA30MxLaay/MBqw2n/8KcUOeNWfChaZMa5xwXQb0UoGDmoSdn8uMnU8QwDqUNLR JIjA== X-Gm-Message-State: AGRZ1gJK4sBPioQcty00uKvQbA3BKTHNt3EQTUb2JboWgxn7Ki5GRZyv gKdgpcI1SVxjIT4BbbyQLRw6VBX7FAE= X-Received: by 2002:adf:a409:: with SMTP id d9-v6mr23923936wra.190.1541527134310; Tue, 06 Nov 2018 09:58:54 -0800 (PST) Received: from localhost.localdomain (laubervilliers-657-1-83-120.w92-154.abo.wanadoo.fr. [92.154.90.120]) by smtp.gmail.com with ESMTPSA id 134-v6sm2971522wmp.6.2018.11.06.09.58.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Nov 2018 09:58:53 -0800 (PST) From: Ard Biesheuvel To: edk2-devel@lists.01.org Date: Tue, 6 Nov 2018 18:58:18 +0100 Message-Id: <20181106175833.26964-5-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181106175833.26964-1-ard.biesheuvel@linaro.org> References: <20181106175833.26964-1-ard.biesheuvel@linaro.org> MIME-Version: 1.0 Subject: [edk2] [PATCH edk2-staging 04/19] IntelUndiPkg/GigUndiDxe: consistently use forward slashes as path separators X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: michael.d.kinney@intel.com, eric.jin@intel.com Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" Replace backslashes in paths with forward slashes to be compatible with non-Windows OSes. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- IntelUndiPkg/GigUndiDxe/Decode.c | 2 +- IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf | 14 +++++++------- IntelUndiPkg/GigUndiDxe/e1000_osdep.h | 4 ++-- 3 files changed, 10 insertions(+), 10 deletions(-) -- 2.19.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Ryszard Knop diff --git a/IntelUndiPkg/GigUndiDxe/Decode.c b/IntelUndiPkg/GigUndiDxe/Decode.c index 14060db0d050..9f8a5a8c1c81 100644 --- a/IntelUndiPkg/GigUndiDxe/Decode.c +++ b/IntelUndiPkg/GigUndiDxe/Decode.c @@ -27,7 +27,7 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. ***************************************************************************/ #include "e1000.h" -#include +#include /** This routine determines the operational state of the UNDI. It updates the state flags in the Command Descriptor Block based on information derived from the GigAdapter instance data. diff --git a/IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf b/IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf index 0e4462733df6..6c195872c00f 100644 --- a/IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf +++ b/IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf @@ -115,13 +115,13 @@ AdapterInformation.c AdapterInformation.h Version.h -wol\wol.h -wol\wol.c -wol\wolimpl.h -wol\wolimpl.c -wol\wolfamily.c -wol\wolinfo.c -wol\wol_1G.c +wol/wol.h +wol/wol.c +wol/wolimpl.h +wol/wolimpl.c +wol/wolfamily.c +wol/wolinfo.c +wol/wol_1G.c [sources.X64] diff --git a/IntelUndiPkg/GigUndiDxe/e1000_osdep.h b/IntelUndiPkg/GigUndiDxe/e1000_osdep.h index 01c0843a2c9a..4408b409a445 100644 --- a/IntelUndiPkg/GigUndiDxe/e1000_osdep.h +++ b/IntelUndiPkg/GigUndiDxe/e1000_osdep.h @@ -31,8 +31,8 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. #include #include -#include -#include +#include +#include #pragma warning(disable : 4244) #pragma warning(disable : 4206) From patchwork Tue Nov 6 17:58:19 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ard Biesheuvel X-Patchwork-Id: 150307 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp4192068ljp; Tue, 6 Nov 2018 09:59:07 -0800 (PST) X-Google-Smtp-Source: AJdET5eABHFTaF0xjdufiyIQpmUSNJt0dZ1PaSNZYzzqU7bzmtxYk5xMA1dGV6gS09MZHom05an+ X-Received: by 2002:a17:902:9a07:: with SMTP id v7-v6mr26598953plp.14.1541527147355; Tue, 06 Nov 2018 09:59:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1541527147; cv=none; d=google.com; s=arc-20160816; b=QB5l3Q/ELqyTz17tp9YlgeI8jxOju7TQlfW6DpU5c5JI0SpPyqS3hxaPq3PvZLafmQ ebI/6nNmCiQJY9Er5h4NzP1EhZnNKKkNXhtIwbuEKlEW14PuSryjy4qd3HPDbC+g49oy CRIGcGRAAGSsQ81SlJQIwd/U6gMv+/m7uGBZXhQOcvQGlH+4hg6NtGxPp+cqNlHbjCJW 1s9PY5jR11UK8Z/a0qA9GGgOHnJKzqmtlS0M3QJOhShjplf0aJI/WaUa4ZXL4GBHwmP5 0Rjeb9FkBc1dLvKoLxLLiSUje9W5Z0uGKoXiCzqmqOAwRE14ot2xXFaNicmBJNS/GBwo ntDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:references:in-reply-to:message-id :date:to:from:dkim-signature:delivered-to; bh=LteKYw5K0l/RswBhe18gLa1epgX0hBl/7rER4SCF3sY=; b=LvsYZa0W2T8+w66dpHjPF9qa9yFOIufetSj5DRzfYlagql6Co2T8U2RVtw1ZoLwwJz iVg6vR5Fc93o2FHi6VCwdgEQyv6AVP6KE+D5B8x2SWYlmAw3xbuG86icWbfKpEowcxGq plWTvyv+K2uWYeBitpPASMzQzRXWAtuiUgAa6G1YLEjEQ253AvXNgwITx3zAFdM1agF6 7p/7WtY18L+nxXeCFC+RYwwpPlaU2FQ4vfVy5rB3kw0FlLp3yU3IW1IN1kL4gieE525B GcvjNIKik/ycZBdwjgusYiYbJxdIoCd6kjtlw0jmT9zJgX6InO6YZ2kvJZSh4Bk4kngT 1yAA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=BxTVKxNi; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from ml01.01.org (ml01.01.org. [198.145.21.10]) by mx.google.com with ESMTPS id b124-v6si40838134pfa.135.2018.11.06.09.59.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Nov 2018 09:59:07 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) client-ip=198.145.21.10; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=BxTVKxNi; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 4BA3A21189FB2; Tue, 6 Nov 2018 09:58:59 -0800 (PST) X-Original-To: edk2-devel@lists.01.org Delivered-To: edk2-devel@lists.01.org Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::441; helo=mail-wr1-x441.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 8414D2118C4FA for ; Tue, 6 Nov 2018 09:58:57 -0800 (PST) Received: by mail-wr1-x441.google.com with SMTP id u9-v6so4227628wrr.0 for ; Tue, 06 Nov 2018 09:58:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=LKCg71hc67qbpgYH56ba3TJFCRV9OF6rKrar8mNKZd0=; b=BxTVKxNi4UVeARkxRPZiP3osaONmIs9oRDqbxsAgkkVC4w8ac1hCSo+w1NaJLUWI1I poD08GJ/9Uo4Yxoqab4rC2RUYRKaePneUeYx1pYQBNl2cC0oIECCJAXZqur0d4ld3Dla hcHOmK1kcyXjP9ECNswCc2c14GJJbT89XbXwY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=LKCg71hc67qbpgYH56ba3TJFCRV9OF6rKrar8mNKZd0=; b=pKDd3saAu10QsCheJC74TvURhFiAlRh0L2LXqDtUTvHXyI8zVk+gUWu43vlpEl/4Oh N0vYqKUwBiAosuvlnue+iVHf075vIloMpBl+cJ51XjI9L4SbqXRd3mWh8U4t077iptR4 1fFyZ+Q4VQRybcgVLIUZ4fPCA2wog8QgnSJMGKW2gmcNooUcpjeaKG3d4C6GVldTWQ/w w0iV0dv+rwXzVya6nWdRQIBOy9m2QL5h5Z/qHRzIt2oGQiItP6VcdLE2+OpMsve1CaO4 H8F4LgLevvGmxKMASOjKyfoQGI/dXl83xkkO69jZ1CYEu6lYNHD/hG9Jh7ipN1FalQu7 C5MQ== X-Gm-Message-State: AGRZ1gKajCh6fabl0mCTKgt14ud+b/BZ8J6EIOJe0mH/mPOT1Jooi/V5 bH32IVVHxRF/5qO6OLUaYNhS6UsT5zo= X-Received: by 2002:adf:f941:: with SMTP id q1-v6mr23649264wrr.151.1541527135781; Tue, 06 Nov 2018 09:58:55 -0800 (PST) Received: from localhost.localdomain (laubervilliers-657-1-83-120.w92-154.abo.wanadoo.fr. [92.154.90.120]) by smtp.gmail.com with ESMTPSA id 134-v6sm2971522wmp.6.2018.11.06.09.58.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Nov 2018 09:58:54 -0800 (PST) From: Ard Biesheuvel To: edk2-devel@lists.01.org Date: Tue, 6 Nov 2018 18:58:19 +0100 Message-Id: <20181106175833.26964-6-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181106175833.26964-1-ard.biesheuvel@linaro.org> References: <20181106175833.26964-1-ard.biesheuvel@linaro.org> MIME-Version: 1.0 Subject: [edk2] [PATCH edk2-staging 05/19] IntelUndiPkg/GigUndiDxe: move BRAND_STRUCT declaration after type definition X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: michael.d.kinney@intel.com, eric.jin@intel.com Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" Move the extern declaration of mBrandingTable[] after the definition of the type. This solves a build issue with GCC. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- IntelUndiPkg/GigUndiDxe/DeviceSupport.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- 2.19.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel Reviewed-by: Ryszard Knop diff --git a/IntelUndiPkg/GigUndiDxe/DeviceSupport.h b/IntelUndiPkg/GigUndiDxe/DeviceSupport.h index e156b587f6a7..e2b730131f8e 100644 --- a/IntelUndiPkg/GigUndiDxe/DeviceSupport.h +++ b/IntelUndiPkg/GigUndiDxe/DeviceSupport.h @@ -33,9 +33,6 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. typedef struct BRAND_STRUCT_S BRAND_STRUCT; -extern BRAND_STRUCT mBrandingTable[]; -extern UINTN mBrandingTableSize; - /* Defines */ #define INVALID_VENDOR_ID 0xFFFF #define INVALID_SUBVENDOR_ID 0xFFFF @@ -53,6 +50,9 @@ struct BRAND_STRUCT_S { CHAR16 *BrandString; }; +extern BRAND_STRUCT mBrandingTable[]; +extern UINTN mBrandingTableSize; + /* Function declarations */ /** Returns pointer to current device's branding string (looks for best match) From patchwork Tue Nov 6 17:58:20 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ard Biesheuvel X-Patchwork-Id: 150308 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp4192111ljp; Tue, 6 Nov 2018 09:59:11 -0800 (PST) X-Google-Smtp-Source: AJdET5dtZfkJixspjFh2neLQ9XVpVTzMwcSoNH3/iS1wWeW8keZtUp5B6NCtwkcSwNXIH9vPGc5l X-Received: by 2002:a17:902:67:: with SMTP id 94-v6mr15514548pla.225.1541527151011; Tue, 06 Nov 2018 09:59:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1541527151; cv=none; d=google.com; s=arc-20160816; b=dB7u0E7yENo/C/2a5GvIyBhHcn3Ivd4HylS+j5pMdA1NU2qDQhv69f6H2C/HzXJzPP 5EfgI+5mQF7rtq31aUG89lbPtUqvhlG4DEvOQ9R28+cCOMF3s8wNeOuILVGMFExMEB3R y/qLcyAV5B2YXD71DxKeLUUW0H8SK7X83p6MsscWI7p+dJ3U3ieZbo5dpAlB5q5h7vyZ OoiuAym2fyH7XkdWMNqmI7B2a0f2QF0mG5XadyWjKoGxgbMAur3tWNO49ip7oCY+a25h xMBlo+YNboR1nuV9I15Dar/MIDHIuaX2XQTwpA4NlH5FrMoV33d1kTHG4BLPKzIk4xip LYqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:references:in-reply-to:message-id :date:to:from:dkim-signature:delivered-to; bh=F1hAUd5yqByZco52kmPVT6Kc1ts6oAmUalSJAe5OA1M=; b=WKqrGJCQC9DK0QUCSOw9PLWG/mvPvWZfAoANiPCaOa7J4tvKsuGbtREGjWhvFhra8h Zj7BQshwak1Mf6iqbPI3bS7Y9ooXSOAws7zr8OTZjN1yxdLLfiIMDTHdDYYJBtXYC78j Q12MguVHEMlxiWN3Jomc21/LlcGvtmgaPO/gkmSkwYvOWRbGBTDHbC/cCfiW51MzFxD+ hW8aH/bNbu+GIbtr0j0umdVJuj4o5fnmiUfgJkx5cLrVlCDnNvHAvLwS7EICmVkmkUKc 7CONG7qAY0mLs+UTcQksJJifZN/9x9bHG4JiDfq+LCeG+qPRdMYOGTeg17U5PIWm4k1t myjQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=JqkdFoel; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from ml01.01.org (ml01.01.org. [2001:19d0:306:5::1]) by mx.google.com with ESMTPS id o125-v6si45984167pgo.302.2018.11.06.09.59.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Nov 2018 09:59:10 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) client-ip=2001:19d0:306:5::1; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=JqkdFoel; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 7AD772118C503; Tue, 6 Nov 2018 09:59:00 -0800 (PST) X-Original-To: edk2-devel@lists.01.org Delivered-To: edk2-devel@lists.01.org Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::442; helo=mail-wr1-x442.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D362B2118C500 for ; Tue, 6 Nov 2018 09:58:58 -0800 (PST) Received: by mail-wr1-x442.google.com with SMTP id u9-v6so4227684wrr.0 for ; Tue, 06 Nov 2018 09:58:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=FS2K71xcx8etC4DojXEHB4gP06/JTl6yWsJVA1N5Vr0=; b=JqkdFoelIeLDGjZ6r5NlT7G5Z7pUBBU2aIEr9bYj7oIzn2nA2ovN/2fBgqfn36H323 f0RR1tMhbWduz2k6oS4dEfHERxZVjRbiNN6zXa82hs1PNQXiY68BIPZELV0U/DpPxsEX A7GT9KyGKg/aJTY2mmKZV4nI45crPGr9+vnSo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=FS2K71xcx8etC4DojXEHB4gP06/JTl6yWsJVA1N5Vr0=; b=pdSs/6RjYnO0HYb9lTAtNvr7EOQBLSuEmLr/K/rgp2UilPKVMIpTxR888tjH1WtupA A0CBY9A2wqytPcMbfq+yK0UoV7N6aRm/1s8fJ5LMzczBhz+6/pgo+2yix1byDnsYXb5y AQpViTmRGXpcnIB7YgE7SGRVp9kOG0saT0Z2y4It+o9f2O5FuY22bSXmEpV1y2Cy3v49 T2lWTiU4tAnP5mky9OVAi8atBR3jOhTRx51B7QSPe+2Vok0xs/Woq9xqqzu928S8jWUz ayeUufflh+u/AYB+1U0BfOHWA+8QBol65aOpcCcXWRzZTf+gUjId9TBXlHz7Q/InKMpE puWg== X-Gm-Message-State: AGRZ1gLYjmD9ljtaz8np6Ar6f54wZ/AEjmGJwea1LAxdeEciQaCrRDET dbdbQwz/F7YqJk9xlAhiqCK/qDX8xF8= X-Received: by 2002:adf:9c90:: with SMTP id d16-v6mr23808080wre.11.1541527137109; Tue, 06 Nov 2018 09:58:57 -0800 (PST) Received: from localhost.localdomain (laubervilliers-657-1-83-120.w92-154.abo.wanadoo.fr. [92.154.90.120]) by smtp.gmail.com with ESMTPSA id 134-v6sm2971522wmp.6.2018.11.06.09.58.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Nov 2018 09:58:56 -0800 (PST) From: Ard Biesheuvel To: edk2-devel@lists.01.org Date: Tue, 6 Nov 2018 18:58:20 +0100 Message-Id: <20181106175833.26964-7-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181106175833.26964-1-ard.biesheuvel@linaro.org> References: <20181106175833.26964-1-ard.biesheuvel@linaro.org> MIME-Version: 1.0 Subject: [edk2] [PATCH edk2-staging 06/19] IntelUndiPkg/GigUndiDxe: use intermediate UINTN casts for pointers X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: michael.d.kinney@intel.com, eric.jin@intel.com Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" Use intermediate (UINTN) casts when casting pointers to UINT64. This is needed to be able to build this code for 32-bit architectures such as ARM or IA32. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- IntelUndiPkg/GigUndiDxe/Dma.c | 8 ++++---- IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c | 6 +++--- IntelUndiPkg/GigUndiDxe/Init.c | 6 +++--- IntelUndiPkg/GigUndiDxe/e1000.c | 10 +++++----- IntelUndiPkg/GigUndiDxe/e1000.h | 4 ++-- 5 files changed, 17 insertions(+), 17 deletions(-) -- 2.19.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel Reviewed-by: Ryszard Knop diff --git a/IntelUndiPkg/GigUndiDxe/Dma.c b/IntelUndiPkg/GigUndiDxe/Dma.c index bf94c1e2fd54..eee2aa8a1ce3 100644 --- a/IntelUndiPkg/GigUndiDxe/Dma.c +++ b/IntelUndiPkg/GigUndiDxe/Dma.c @@ -127,7 +127,7 @@ FREE_BUF_ON_ERROR: PciIo->FreeBuffer ( PciIo, BytesToPages (DmaMapping->Size), - (VOID *) DmaMapping->UnmappedAddress + (VOID *)(UINTN)DmaMapping->UnmappedAddress ); DmaMapping->Size = 0; DmaMapping->UnmappedAddress = 0; @@ -173,7 +173,7 @@ UndiDmaFreeCommonBuffer ( PciIo->FreeBuffer ( PciIo, BytesToPages (DmaMapping->Size), - (VOID *) DmaMapping->UnmappedAddress + (VOID *)(UINTN)DmaMapping->UnmappedAddress ); DmaMapping->UnmappedAddress = 0; @@ -209,7 +209,7 @@ UndiDmaMapCommonBuffer ( return PciIo->Map ( PciIo, EfiPciIoOperationBusMasterCommonBuffer, - (VOID *) DmaMapping->UnmappedAddress, + (VOID *)(UINTN)DmaMapping->UnmappedAddress, &DmaMapping->Size, &DmaMapping->PhysicalAddress, &DmaMapping->Mapping @@ -243,7 +243,7 @@ UndiDmaMapMemoryRead ( return PciIo->Map ( PciIo, EfiPciIoOperationBusMasterRead, - (VOID *) DmaMapping->UnmappedAddress, + (VOID *)(UINTN)DmaMapping->UnmappedAddress, &DmaMapping->Size, &DmaMapping->PhysicalAddress, &DmaMapping->Mapping diff --git a/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c b/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c index 559f2133281e..aceb015e480f 100644 --- a/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c +++ b/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c @@ -1132,7 +1132,7 @@ GigUndiRunPhyLoopback ( while (j < PHY_LOOPBACK_ITERATIONS) { Status = E1000Transmit ( GigAdapterInfo, - (UINT64) &PxeCpbTransmit, + (UINT64)(UINTN)&PxeCpbTransmit, PXE_OPFLAGS_TRANSMIT_WHOLE ); _DisplayBuffersAndDescriptors (GigAdapterInfo); @@ -1161,8 +1161,8 @@ GigUndiRunPhyLoopback ( for (i = 0; i <= 100000; i++) { Status = E1000Receive ( GigAdapterInfo, - (UINT64) &CpbReceive, - (UINT64) &DbReceive + (UINT64)(UINTN)&CpbReceive, + (UINT64)(UINTN)&DbReceive ); gBS->Stall (10); diff --git a/IntelUndiPkg/GigUndiDxe/Init.c b/IntelUndiPkg/GigUndiDxe/Init.c index 74b933674589..f99734d72823 100644 --- a/IntelUndiPkg/GigUndiDxe/Init.c +++ b/IntelUndiPkg/GigUndiDxe/Init.c @@ -301,7 +301,7 @@ GigUndiPxeStructInit ( PXE_ROMID_IMP_TX_COMPLETE_INT_SUPPORTED | PXE_ROMID_IMP_PACKET_RX_INT_SUPPORTED; - PxePtr->EntryPoint = (UINT64) E1000UndiApiEntry; + PxePtr->EntryPoint = (UINT64)(UINTN)E1000UndiApiEntry; PxePtr->reserved2[0] = 0; PxePtr->reserved2[1] = 0; PxePtr->reserved2[2] = 0; @@ -842,7 +842,7 @@ InitNiiProtocol ( return EFI_INVALID_PARAMETER; } - NiiProtocol31->Id = (UINT64) (mE1000Pxe31); + NiiProtocol31->Id = (UINT64)(UINTN)mE1000Pxe31; NiiProtocol31->IfNum = mE1000Pxe31->IFcnt; NiiProtocol31->Revision = EFI_NETWORK_INTERFACE_IDENTIFIER_PROTOCOL_REVISION_31; @@ -938,7 +938,7 @@ InitUndiCallbackFunctions ( NicInfo->MapMem = (VOID *) 0; NicInfo->UnMapMem = (VOID *) 0; NicInfo->SyncMem = (VOID *) 0; - NicInfo->UniqueId = (UINT64) NicInfo; + NicInfo->UniqueId = (UINT64)(UINTN)NicInfo; NicInfo->VersionFlag = 0x31; } diff --git a/IntelUndiPkg/GigUndiDxe/e1000.c b/IntelUndiPkg/GigUndiDxe/e1000.c index 6f8529abf046..1f08a5d67b2d 100644 --- a/IntelUndiPkg/GigUndiDxe/e1000.c +++ b/IntelUndiPkg/GigUndiDxe/e1000.c @@ -128,7 +128,7 @@ E1000MapMem ( VirtualAddress, Size, TO_DEVICE, - (UINT64) MappedAddress + (UINT64)(UINTN)MappedAddress ); if (*MappedAddress == 0) { @@ -1079,7 +1079,7 @@ E1000TxRxConfigure ( ZeroMem (GigAdapter->TxBufferMappings, sizeof (GigAdapter->TxBufferMappings)); - RxBuffer = (LOCAL_RX_BUFFER *) GigAdapter->RxBufferMapping.PhysicalAddress; + RxBuffer = (LOCAL_RX_BUFFER *)(UINTN)GigAdapter->RxBufferMapping.PhysicalAddress; DEBUGPRINT ( E1000, ("Tx Ring %x Added %x\n", @@ -1578,17 +1578,17 @@ E1000Inititialize ( TempBar = NULL; ZeroMem ( - (VOID *) GigAdapter->RxRing.UnmappedAddress, + (VOID *)(UINTN)GigAdapter->RxRing.UnmappedAddress, RX_RING_SIZE ); ZeroMem ( - (VOID *) GigAdapter->TxRing.UnmappedAddress, + (VOID *)(UINTN)GigAdapter->TxRing.UnmappedAddress, TX_RING_SIZE ); ZeroMem ( - (VOID *) GigAdapter->RxBufferMapping.UnmappedAddress, + (VOID *)(UINTN)GigAdapter->RxBufferMapping.UnmappedAddress, RX_BUFFERS_SIZE ); diff --git a/IntelUndiPkg/GigUndiDxe/e1000.h b/IntelUndiPkg/GigUndiDxe/e1000.h index 71fe4591af05..a44fe3fa2ec8 100644 --- a/IntelUndiPkg/GigUndiDxe/e1000.h +++ b/IntelUndiPkg/GigUndiDxe/e1000.h @@ -233,7 +233,7 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. @return Descriptor retrieved **/ #define E1000_RX_DESC(R, i) \ - (&(((struct e1000_rx_desc *) ((R)->UnmappedAddress))[i])) + (&(((struct e1000_rx_desc *)(UINTN)((R)->UnmappedAddress))[i])) /** Retrieves TX descriptor from TX ring structure @@ -243,7 +243,7 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. @return Descriptor retrieved **/ #define E1000_TX_DESC(R, i) \ - (&(((struct e1000_tx_desc *) ((R)->UnmappedAddress))[i])) + (&(((struct e1000_tx_desc *)(UINTN)((R)->UnmappedAddress))[i])) /** Retrieves UNDI_PRIVATE_DATA structure using NII Protocol 3.1 instance From patchwork Tue Nov 6 17:58:21 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ard Biesheuvel X-Patchwork-Id: 150309 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp4192153ljp; Tue, 6 Nov 2018 09:59:14 -0800 (PST) X-Google-Smtp-Source: AJdET5fxKkOpi4jX0aY2a4paUusGBd0B8GRuyb0vUcR1p1PzlGcd6tKS9/qwq8gHgRdz0PVT1Mc/ X-Received: by 2002:aa7:8603:: with SMTP id p3-v6mr27257068pfn.247.1541527154566; Tue, 06 Nov 2018 09:59:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1541527154; cv=none; d=google.com; s=arc-20160816; b=znmcng7quk9HLeIPVJrIzx1gVl+tKpYRsTIanLUs0GY1D8vQO2vkVxlINZz/f+g1Ai wnDqGsKHqAe+yNOd/laxYnnG40TpMVHr4y4TC00Ht7QBLhmlxdHX/hnD+d4C3o8hIT2j OD3PqBNUiAGyc+w3UE9V7P2WrspOrJV3mTiW6Zc8eg61cysqKvmPfU1QJgYrN7nMszYA o5Bodky73gJh/lJghTIREU80WVFDjAv8dFw1G6IzgTJczf4bTzlikY2eyZjW8ZP9ZfZw vOe8WIaSzoT4HlPUjzTHyBwZcRLmQ6Ol/JAWLRRcBL9AxyUu9lP4gqrcnonkhQx2jjVV DfHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:references:in-reply-to:message-id :date:to:from:dkim-signature:delivered-to; bh=nwVOIw6/1spuF4+T/THz4cu+cH+q2qw1BclcQ3YTk1A=; b=BZGbDvavg1oSAp/JthI6AZKzVPTU8d2ECXBXwrM+VEsXl5XycLdrMtSdQSXghbT4m3 faPj0EGe+gmieU8ot7TQvwy7mBqPfKRPj3fU15Jg6jruCk/kQtfb9VTeGy8kuzRucL5v yIin4nfHQ+PH7Q6ZyxFj80guRcKMRE19e/i03yH3Ms1S5VDwIpoZLMAYaVVSMBXrwmfj x2G1WJUHbqgDFc/5SrprH+qnXFEPtivb6pcYuHdWC41W7e9uY7kd6hWHINDTHXjwfPyH V43fE4amGMAuKEdonrLib14y1dgGcR/QuIHBwkt2jMZmVjczIgKhFEzhIPZqMC6VCgPs CQGw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=gZTTsiZc; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from ml01.01.org (ml01.01.org. [198.145.21.10]) by mx.google.com with ESMTPS id r29si18188857pga.477.2018.11.06.09.59.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Nov 2018 09:59:14 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) client-ip=198.145.21.10; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=gZTTsiZc; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id AB6532118C509; Tue, 6 Nov 2018 09:59:02 -0800 (PST) X-Original-To: edk2-devel@lists.01.org Delivered-To: edk2-devel@lists.01.org Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::444; helo=mail-wr1-x444.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D404A2118C503 for ; Tue, 6 Nov 2018 09:58:59 -0800 (PST) Received: by mail-wr1-x444.google.com with SMTP id r10-v6so14563179wrv.6 for ; Tue, 06 Nov 2018 09:58:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=KbmYC/RVSxTrYzhnrAiaF10+p4qCXiX2RiK2HL376G4=; b=gZTTsiZc+hMIAygbNUrlaeKne+b87K1SCqUOvCvUZuMF770xJtVpqok8eI6BE5LYN4 h/rTgBMbTLEqSTfj4dh869SVpw0EjO+rqmWj5PYlzkgmS1Gs6y8jYraEFcyDzRMDYU9h d9roJBXd4weeShMOWjya0ur2RxA8d4/pt0S1A= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=KbmYC/RVSxTrYzhnrAiaF10+p4qCXiX2RiK2HL376G4=; b=srnKw4UnXiAJkc+7bk9dUs0dniDLcJ1tvAaNwUVF70qOiMlsGSoVoH9GE3OQQhzdwq voNHYeoFnrLpt2rOf1FaOva2PKkKILNBAoM25RdZc2ySaHiUiu4JNCGhlzy8IAI7G6xA qjxqJcOweM3/AhuPEBt11R2aLjaNB/DNfpRSV8XtPZp0yYMrcIZf+ETIggVHJkxAwS6A wUw/FpzPYwuACYEaqLZLlQ/dsRBr2zOyQPoq3bi0kA8PmzO6s/EFyX1ZmbcnyNhz1raR xeKH3cU63kitFLt1SFx7nPjLM8kpOxr/gxWOq2ekxH4HsdPkHr+EyopL+U9Qxd6FHOLE nRzg== X-Gm-Message-State: AGRZ1gLS6fpQHKmNoXSQjG5P5fcro28Ag146utXReFVQMJV5TV50Whyv V6CzwySmeBtzU+VG4kluOFaiWMEduVg= X-Received: by 2002:adf:fb4b:: with SMTP id c11-v6mr23687279wrs.117.1541527138224; Tue, 06 Nov 2018 09:58:58 -0800 (PST) Received: from localhost.localdomain (laubervilliers-657-1-83-120.w92-154.abo.wanadoo.fr. [92.154.90.120]) by smtp.gmail.com with ESMTPSA id 134-v6sm2971522wmp.6.2018.11.06.09.58.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Nov 2018 09:58:57 -0800 (PST) From: Ard Biesheuvel To: edk2-devel@lists.01.org Date: Tue, 6 Nov 2018 18:58:21 +0100 Message-Id: <20181106175833.26964-8-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181106175833.26964-1-ard.biesheuvel@linaro.org> References: <20181106175833.26964-1-ard.biesheuvel@linaro.org> MIME-Version: 1.0 Subject: [edk2] [PATCH edk2-staging 07/19] IntelUndiPkg/GigUndiDxe: create GCC alternatives for MSFT build options X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: michael.d.kinney@intel.com, eric.jin@intel.com Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" Prefix the existing MSFT only build option overrides with MSFT: and create the GCC: counterparts so we can build this code with GCC as well. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) -- 2.19.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel Reviewed-by: Ryszard Knop diff --git a/IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf b/IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf index 6c195872c00f..19dae9a0987a 100644 --- a/IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf +++ b/IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf @@ -41,20 +41,20 @@ ENTRY_POINT = InitializeGigUNDIDriver UNLOAD_IMAGE = GigUndiUnload [BuildOptions.common] - -*_*_*_CC_FLAGS = /FAcs /D MDEPKG_NDEBUG + MSFT:*_*_*_CC_FLAGS = /FAcs /D MDEPKG_NDEBUG + GCC:RELEASE_*_*_CC_FLAGS = -D MDEPKG_NDEBUG [BuildOptions.X64] - -*_*_*_CC_FLAGS = /D EFIX64 + MSFT:*_*_*_CC_FLAGS = /D EFIX64 + GCC:*_*_*_CC_FLAGS = -D EFIX64 [BuildOptions.IPF] - -*_*_*_CC_FLAGS = /D EFI64 + MSFT:*_*_*_CC_FLAGS = /D EFI64 + GCC:*_*_*_CC_FLAGS = -D EFI64 [BuildOptions.IA32] - -*_*_*_CC_FLAGS = /D EFI32 + MSFT:*_*_*_CC_FLAGS = /D EFI32 + GCC:*_*_*_CC_FLAGS = -D EFI32 [sources.common] InventoryStrings.uni From patchwork Tue Nov 6 17:58:22 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Ard Biesheuvel X-Patchwork-Id: 150310 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp4192215ljp; Tue, 6 Nov 2018 09:59:18 -0800 (PST) X-Google-Smtp-Source: AJdET5cMOYRVgU35m58NG8SfsHHAYQkt7EAYL+g89ePjTDSFHlGDJ7L2CQxBc/PqQr5xCgdt/vGy X-Received: by 2002:a63:8549:: with SMTP id u70mr24610649pgd.401.1541527158290; Tue, 06 Nov 2018 09:59:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1541527158; cv=none; d=google.com; s=arc-20160816; b=WzW9EX55zieqYTqmCUmpj3UuKB5LowFtxeAl3IQZ3YJyCt1fV3a/p2l6n2HJ0hoAvv kEyeBMOWYVyTefOBcC4bpk/41rRtyvfucXC+UEbiRzrg4cS2NHGO49DB8+G7LXVLdlyl 8xOYxHnbGP1z89DaD17QR5Pngm5+NyyFIx/+CG67ZiEbeQ4crrcBfQQhvqPUXc3E/A5c UiUBDAVvCVuFZ02YXcXlmRpBuc9p7WNTX4r7SKI21OsbuRbhP7dMLoK7LddwfUSNsZxx JWAhkapc6zu7Yai8LIhMy+cyKpLy7FUsK29RgFsZX7BzjWDPmWzS2+XV+XnZ3akQ89uk NPqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:references:in-reply-to:message-id :date:to:from:dkim-signature:delivered-to; bh=Vz0PaysZIgNyUTAr+VeebnLP1ySqRAwa5r1+YQdLPUI=; b=rBnC6NzyeZy76fSNWHouIRxzUgWmNF2IBaT30py5McL4LmplK1c5nbAZyj58+aK5vH dtDvwXPY4/saRa8fAPiBIGWhuWItqKGcfFJyBuZS5QI56EZn4tuL5lplw5oqERNga6pU t3owaXkjktsRuFz5u2RS8YC0bZg8xEjhZpUhYBDMcTjHcZjokiEqftwMAXbIZ2IDjRqJ XUWXyxFGMFCD/Z5MMF+MLYFO0sN+hWsNgUw2fnpfxuVqwhEh+WvfT27Wb61GiTUJ9pmo 64/RgISSNiUgeWeA6Y3Kn58f+hCt86TyXqvrDIMFEXl7W0kx7MNHHHp2+8kFymoUM1lU 8Liw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=UavHifYP; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from ml01.01.org (ml01.01.org. [198.145.21.10]) by mx.google.com with ESMTPS id 33-v6si17786906pls.173.2018.11.06.09.59.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Nov 2018 09:59:18 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) client-ip=198.145.21.10; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=UavHifYP; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id DE33521BADAB3; Tue, 6 Nov 2018 09:59:02 -0800 (PST) X-Original-To: edk2-devel@lists.01.org Delivered-To: edk2-devel@lists.01.org Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::443; helo=mail-wr1-x443.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 516D921188C31 for ; Tue, 6 Nov 2018 09:59:01 -0800 (PST) Received: by mail-wr1-x443.google.com with SMTP id j17-v6so9427947wrq.11 for ; Tue, 06 Nov 2018 09:59:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ImGXwIRUD5Exq0PxIb5UQ5CGAlV6iJYdbCC4RQV3BII=; b=UavHifYPJPE4ErEDofxIRh83UMGJ5a8eVVjHBoP/C03wZJgbr8Uh718meVmSrT2sOC IQrAfJ17elpCAbNhRjcAN+u+AIt0LxGKXfxfPeH4m7QEyT3TZK2/WcgIZNVL5Rrun0e5 dEteIG18T+Z8n5ffSdNAOTZDYiIBQbs9m6SAo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ImGXwIRUD5Exq0PxIb5UQ5CGAlV6iJYdbCC4RQV3BII=; b=sNi8LuFT1wHkcppbI60dhTBiBRGhBNpPBD92vehfabgqdxOrY1MUuPkf6MAUQWS/pU NbS5WXbcmzN8qVKIx+ELLggZfLKCVNdtQUrDTZrT3vHdenKeC7DjGV3nMt7fBRi1gaQV 0r3npUKeFfcrq30AXxP/34rsiHWLmP3qj8N3rv+q4A1DQa0dwsJZ7FfZWpeR5+pyDZ8O e8VSj9UO3hG7AR8RO5/5rEhAYPLbanscmBbgxRzswyxdS8yDlFOQwUYguuonZYCqGkxw i739Tlvk0rAajL/StbmtcRKv4GoPHRZOZVdBVdu6bTRMlZh5TYuEl798YSV0MxJD7ere kSuA== X-Gm-Message-State: AGRZ1gIeCsE7AIoKf12XJ0F2Xc68CFINMPSbovsNMv6hETxmTYa2fOrC UFgvclfFfeadU7o/G70GD4EWaH+A0zo= X-Received: by 2002:adf:8c09:: with SMTP id z9-v6mr24151256wra.82.1541527139646; Tue, 06 Nov 2018 09:58:59 -0800 (PST) Received: from localhost.localdomain (laubervilliers-657-1-83-120.w92-154.abo.wanadoo.fr. [92.154.90.120]) by smtp.gmail.com with ESMTPSA id 134-v6sm2971522wmp.6.2018.11.06.09.58.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Nov 2018 09:58:58 -0800 (PST) From: Ard Biesheuvel To: edk2-devel@lists.01.org Date: Tue, 6 Nov 2018 18:58:22 +0100 Message-Id: <20181106175833.26964-9-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181106175833.26964-1-ard.biesheuvel@linaro.org> References: <20181106175833.26964-1-ard.biesheuvel@linaro.org> MIME-Version: 1.0 Subject: [edk2] [PATCH edk2-staging 08/19] IntelUndiPkg/GigUndiDxe: add missing VOID** cast X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: michael.d.kinney@intel.com, eric.jin@intel.com Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" Unlike Visual Studio, GCC does not permit implicit conversion between a pointer-to-void-pointer and pointer to a typed pointer. So add the explicit casts where necessary. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- IntelUndiPkg/GigUndiDxe/Hii.c | 8 ++++---- IntelUndiPkg/GigUndiDxe/Init.c | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) -- 2.19.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Ryszard Knop diff --git a/IntelUndiPkg/GigUndiDxe/Hii.c b/IntelUndiPkg/GigUndiDxe/Hii.c index 43c184cb03c8..a5d8ae207819 100644 --- a/IntelUndiPkg/GigUndiDxe/Hii.c +++ b/IntelUndiPkg/GigUndiDxe/Hii.c @@ -459,7 +459,7 @@ HiiOpenProtocol ( Status = gBS->LocateProtocol ( &gEfiHiiDatabaseProtocolGuid, NULL, - &UndiPrivateData->HiiDatabase + (VOID **)&UndiPrivateData->HiiDatabase ); if (EFI_ERROR (Status)) { DEBUGPRINT (CRITICAL, ("Error finding HII protocol: %r\n", Status)); @@ -472,7 +472,7 @@ HiiOpenProtocol ( Status = gBS->LocateProtocol ( &gEfiHiiStringProtocolGuid, NULL, - &UndiPrivateData->HiiString + (VOID **)&UndiPrivateData->HiiString ); if (EFI_ERROR (Status)) { DEBUGPRINT (CRITICAL, ("Error finding HII String protocol: %r\n", Status)); @@ -485,7 +485,7 @@ HiiOpenProtocol ( Status = gBS->LocateProtocol ( &gEfiFormBrowser2ProtocolGuid, NULL, - &UndiPrivateData->FormBrowser2 + (VOID **)&UndiPrivateData->FormBrowser2 ); if (EFI_ERROR (Status)) { DEBUGPRINT (CRITICAL, ("Error finding HII form browser protocol: %r\n", Status)); @@ -498,7 +498,7 @@ HiiOpenProtocol ( Status = gBS->LocateProtocol ( &gEfiHiiConfigRoutingProtocolGuid, NULL, - &UndiPrivateData->HiiConfigRouting + (VOID **)&UndiPrivateData->HiiConfigRouting ); if (EFI_ERROR (Status)) { DEBUGPRINT (CRITICAL, ("Error finding HII ConfigRouting protocol: %r\n", Status)); diff --git a/IntelUndiPkg/GigUndiDxe/Init.c b/IntelUndiPkg/GigUndiDxe/Init.c index f99734d72823..1de424c26fe2 100644 --- a/IntelUndiPkg/GigUndiDxe/Init.c +++ b/IntelUndiPkg/GigUndiDxe/Init.c @@ -177,7 +177,7 @@ GigAppendMac2DevPath ( Status = gBS->AllocatePool ( EfiBootServicesData, // EfiRuntimeServicesData, TotalPathLen, - &DevicePtr + (VOID **)&DevicePtr ); if (Status != EFI_SUCCESS) { From patchwork Tue Nov 6 17:58:23 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Ard Biesheuvel X-Patchwork-Id: 150311 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp4192286ljp; Tue, 6 Nov 2018 09:59:22 -0800 (PST) X-Google-Smtp-Source: AJdET5ceBaizA6PidKJJV79lktI7ojLAFx+dYMPr2sCK5PcHyRAGnHnyrzXRK9vMr/TAyv0O1ox1 X-Received: by 2002:a63:b16:: with SMTP id 22mr24473674pgl.306.1541527162271; Tue, 06 Nov 2018 09:59:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1541527162; cv=none; d=google.com; s=arc-20160816; b=PljYHi/+dQ9OwZsMnMTPtQbcjEGvlMZaPNDlSRPObNDsaxAktDg4qm1hPt1E6NUuXL BGOLx90/VVUnhLXqz03f4u8SbdWY2cO5FHyScLFeUx6ddG4sUxeEX680xMlzHiUNamSs 9p9aP5BQhiKnsE98RlKkodffRVar24ESuQ6rjdeVCYRlaUvxf1C1bb1Y/rJ8jGQuEzCZ BNa8uJlzv5uX9yGhpfvOe793mZL8OioxtgRjvzeXQjgrKzu1u7Qpe7TPS3i1lW5GrubM AdMJM/EazAHTlp5rP/XdEadqKgqop9YnhDMegPrcN4CeR5sbjp0fmzGJhnXw1KQlqRld VTCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:references:in-reply-to:message-id :date:to:from:dkim-signature:delivered-to; bh=lwlc6NpLMYfr0YVQ7QwssB0zjmiePy72HpXEwAjYoQ0=; b=BVUG58ryy4VnnkUjZmtmpiKZAOHnz28Dn6KvdkNVzi1rQ5iM6IgKOBdHZ9sfh4HiUY 4rWikV8QWZ31Y+J1TGidNvWzn7Y6lIIbspePOSQqpBkIbI5QYkddJAt2iCG/Yk9l5iiF CA5IW25VrE57vJyOa603t1UZpOpvTHmXMdu/iArWIdc2MEqHY6kwCskb/UDXjDrylD+p gDItit+1/2PNzpfGU+qi4r36uFypRnawFcAMTk9tquDds7sEYI+V7905nESCavKU9p/z 9lHcN/5n0pq2iRxnup+TXSsqQg538HYRt46UMHMjRdMK/6FtmdtuNsJRlWTVtv63PB4O OyTQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=BIxyi1nS; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from ml01.01.org (ml01.01.org. [198.145.21.10]) by mx.google.com with ESMTPS id m7-v6si52266048pfi.286.2018.11.06.09.59.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Nov 2018 09:59:22 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) client-ip=198.145.21.10; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=BIxyi1nS; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 132812118C50C; Tue, 6 Nov 2018 09:59:04 -0800 (PST) X-Original-To: edk2-devel@lists.01.org Delivered-To: edk2-devel@lists.01.org Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::441; helo=mail-wr1-x441.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id AA0972118C4FA for ; Tue, 6 Nov 2018 09:59:02 -0800 (PST) Received: by mail-wr1-x441.google.com with SMTP id 74-v6so14547671wrb.13 for ; Tue, 06 Nov 2018 09:59:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=hrcCYljH+TbckY78HpCWneipT/OVTaYSEjjVl1xANbk=; b=BIxyi1nSjT49cl5E67SGJ1f6mw07xBTO0suzWjgs03S+q4xUgOfm4Xud1b4A7whhBR i9ue1pggX8AU89RERFfjPv6vnnmZ7olpxVyB4WqnjnaIH7IC86EPWn0Q6ZlaIXeastbf M7bCXiDF1PYOYBGAA+SMNMg+IvUFP7mfw1f+g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=hrcCYljH+TbckY78HpCWneipT/OVTaYSEjjVl1xANbk=; b=gtnn2SWptQGFQ9B3ywpZLT/6IhMPLpgn6vPnYhmYY3zrLVHheJ02ClQnxo3UVsIFTI BKVTz6K08mAG5SsS7o+obpOqSOykF4ftN/wPHKYfqJL3Ta3vKFiL3A8WCqnMl7zQ8kb8 q4ynFNzqG8WGox/HGN3BgnTzlHbrUWfv5pZGDVYpnMwT51QCC/Ptclk8EgD/Snd1HU/X 5EjzjjAG2aylBCKR2Tf69aLmGQBnx3+sxZcI0sUqw6G7nrmIc6v6/BqdLBKtxzaip8En ZrAg0WyJI5a3sqoAhpoYRIFeH5TolgtRV58VhofE3DhU0KVouEeqdcKWkl4QJVwblPt6 iJEg== X-Gm-Message-State: AGRZ1gKmj31Z3067UzLLgSFpyA4ygk9wPaArMgi3E8EQG9uBgbTUPiWs 8GdEb1z7GyJro5DC7dxi9DSNG6QRCdw= X-Received: by 2002:adf:a2cc:: with SMTP id t12-v6mr23901226wra.100.1541527141002; Tue, 06 Nov 2018 09:59:01 -0800 (PST) Received: from localhost.localdomain (laubervilliers-657-1-83-120.w92-154.abo.wanadoo.fr. [92.154.90.120]) by smtp.gmail.com with ESMTPSA id 134-v6sm2971522wmp.6.2018.11.06.09.58.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Nov 2018 09:59:00 -0800 (PST) From: Ard Biesheuvel To: edk2-devel@lists.01.org Date: Tue, 6 Nov 2018 18:58:23 +0100 Message-Id: <20181106175833.26964-10-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181106175833.26964-1-ard.biesheuvel@linaro.org> References: <20181106175833.26964-1-ard.biesheuvel@linaro.org> MIME-Version: 1.0 Subject: [edk2] [PATCH edk2-staging 09/19] IntelUndiPkg/GigUndiDxe: add missing UINT8* cast X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: michael.d.kinney@intel.com, eric.jin@intel.com Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" UINT8 and CHAR8 are not the same underlying type on all architectures, so add an explicit cast where necessary. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- IntelUndiPkg/GigUndiDxe/Hii.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.19.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Ryszard Knop diff --git a/IntelUndiPkg/GigUndiDxe/Hii.c b/IntelUndiPkg/GigUndiDxe/Hii.c index a5d8ae207819..737a59fbbbac 100644 --- a/IntelUndiPkg/GigUndiDxe/Hii.c +++ b/IntelUndiPkg/GigUndiDxe/Hii.c @@ -817,7 +817,7 @@ HiiSetMenuStrings ( Status = ReadPbaString ( &UndiPrivateData->NicInfo, - PBAString8, + (UINT8 *)PBAString8, MAX_PBA_STR_LENGTH ); if (Status == EFI_SUCCESS) { From patchwork Tue Nov 6 17:58:24 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Ard Biesheuvel X-Patchwork-Id: 150312 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp4192362ljp; Tue, 6 Nov 2018 09:59:25 -0800 (PST) X-Google-Smtp-Source: AJdET5cm8prslxGOB9QLzY1G1uICrN4k76ekTpHmOQ5yTRVRydPQ1RQjd9249CUp+BaBjHTW0a7v X-Received: by 2002:a17:902:b784:: with SMTP id e4-v6mr26776442pls.45.1541527165841; Tue, 06 Nov 2018 09:59:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1541527165; cv=none; d=google.com; s=arc-20160816; b=fChWJK+ruG9ZB+Dsu8+FonLrTgWqg4OlevzgaVJNVshehBYCsNhrE+WSJAPmmRT6Om sNn0HqHZVImdVoYvkPvc9KYcosL7E4QZ0wdc7xzAszFPTJgHlu8+nYJcTIlXYV5kipwA FSmUR1Ir50+VF23vlk1uLP5wPcOD96CjTTcF5/0mUCcauzx2478eYcRk/GZ/BKCcAPLC 76xAkClD+lEmBjARL6W7zTX1sTJgZSAXutpJdVCTjacIqLNv3yGuqaBptq/06hNf1sxD Z7c7ZherACo1CoM2XdVJAooJUjeRrEJlSUkUHA41OoAlT8y0C2VGGzETO1UyBRekQhM6 emLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:references:in-reply-to:message-id :date:to:from:dkim-signature:delivered-to; bh=fqa5MK4iZWV2KGoc8DUvV+4Jo2gMUWTm0zRowtLSjgA=; b=xat4kovPXt99npLztgXY5Rz9VR4IMIqV51xQbo9FEFhqiFT6++Nz44hL+DLQLs42Cu VK4h2/9UKsVCvpsOARraDjbDktYtRrhmXxJSqQ7+5j5n1tlN8jv+KOEzhYvNDysb1Wlx w4rzfziVxuZGxgoFT+RnCWfkW7WtRr+3Y1dYnI5ooi+tFMT1O3/Qe9LIGMf5PzJkjdmn H/4x0UJqmHVmBxK3+eaaOhvv08I+FkFW6nc74T3NjylQGc3uhWFia+QGOaZKVeK2oHpp zZ5yKAHxhk6CdC0xJUoMR/havHYaadcS5/EmGVYh91x9jLNsBZfdBQkPSmP4v/p6OPh6 OSNw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=bArKgPMi; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from ml01.01.org (ml01.01.org. [198.145.21.10]) by mx.google.com with ESMTPS id o24-v6si43550301pgv.242.2018.11.06.09.59.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Nov 2018 09:59:25 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) client-ip=198.145.21.10; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=bArKgPMi; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 3F2722118C50E; Tue, 6 Nov 2018 09:59:05 -0800 (PST) X-Original-To: edk2-devel@lists.01.org Delivered-To: edk2-devel@lists.01.org Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::443; helo=mail-wr1-x443.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1B0662118C50E for ; Tue, 6 Nov 2018 09:59:04 -0800 (PST) Received: by mail-wr1-x443.google.com with SMTP id j26-v6so14595180wre.1 for ; Tue, 06 Nov 2018 09:59:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=lC9G8GB6g7sqN4TkV/0PFsdLWl9a11sNpopG25QtG8w=; b=bArKgPMir5ONUlZS2ASt3nOOTvfSXBECLj3NhJzqcEFjLTkDiaijTiGAJgrJG1ONV8 xu5BlqFQoFaC2G1P/YeEBz/uTmpVLKNxTSe0r/wJxfJWs7i997rhhjDMI3tndwWBaKfL G3MWUaBlUxtyDI9EigqeopWLYy9CTZXSviyfg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=lC9G8GB6g7sqN4TkV/0PFsdLWl9a11sNpopG25QtG8w=; b=Avk0A+UOughjQ0zPZRaW/+c2PZXxTGcjZA3P08W2OVTehZr6jxIFQPWj08cOhfKrge 2huB2MGpzqBA9DRXvSnr9Gf1G4hFfmrqv0lHf/gLEZOj68kGmHD+oxJi+JbkFC/b/tNU WimkWO24Xel5vcgI7qxTOUWT8j84rraEVQJFP09Tmh7HPw5k50izunVokCs13TZ+FJEC 6bsuQhQt9E5wa566Qh/DOUZHv7uYu1JXMU1CTI9+rr9HVPszp71pn29ySAtNmKlW2BUe 8d8tSnXquJsgRePtW4xjYysNrDYkYkLDV2YEmR4fNsBROBbTc2GhSOfAwb78zMYndkZ+ rcaA== X-Gm-Message-State: AGRZ1gKLBQzV5IZdjgX6CCI5pgipENsls27BJ7Bq/GexnzDc0fMfWsF+ nMDd2r/F5yEZ2ugmMN/Mow2N9I9Kr9w= X-Received: by 2002:adf:ec41:: with SMTP id w1-v6mr24445354wrn.266.1541527142352; Tue, 06 Nov 2018 09:59:02 -0800 (PST) Received: from localhost.localdomain (laubervilliers-657-1-83-120.w92-154.abo.wanadoo.fr. [92.154.90.120]) by smtp.gmail.com with ESMTPSA id 134-v6sm2971522wmp.6.2018.11.06.09.59.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Nov 2018 09:59:01 -0800 (PST) From: Ard Biesheuvel To: edk2-devel@lists.01.org Date: Tue, 6 Nov 2018 18:58:24 +0100 Message-Id: <20181106175833.26964-11-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181106175833.26964-1-ard.biesheuvel@linaro.org> References: <20181106175833.26964-1-ard.biesheuvel@linaro.org> MIME-Version: 1.0 Subject: [edk2] [PATCH edk2-staging 10/19] IntelUndiPkg/GigUndiDxe: add missing braces to GUID literals X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: michael.d.kinney@intel.com, eric.jin@intel.com Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" The Data4 member of the GUID/EFI_GUID struct type is an array of UINT8, so literals require two sets of { } braces. Add them where missing. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- IntelUndiPkg/GigUndiDxe/NVDataStruc.h | 4 ++-- IntelUndiPkg/GigUndiDxe/StartStop.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) -- 2.19.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Ryszard Knop diff --git a/IntelUndiPkg/GigUndiDxe/NVDataStruc.h b/IntelUndiPkg/GigUndiDxe/NVDataStruc.h index bd7d4defc9a3..72f6a95ccb6d 100644 --- a/IntelUndiPkg/GigUndiDxe/NVDataStruc.h +++ b/IntelUndiPkg/GigUndiDxe/NVDataStruc.h @@ -34,12 +34,12 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. #define E1000_HII_FORM_GUID \ { \ - 0x77f2ea2f, 0x4312, 0x4569, 0x85, 0xc4, 0x58, 0x3a, 0xcd, 0x8d, 0xb7, 0xe2 \ + 0x77f2ea2f, 0x4312, 0x4569, { 0x85, 0xc4, 0x58, 0x3a, 0xcd, 0x8d, 0xb7, 0xe2 } \ } #define E1000_HII_DATA_GUID \ { \ - 0xa31abb16, 0xc627, 0x475b, 0x98, 0x8e, 0x7e, 0xe0, 0x77, 0x67, 0x40, 0xf3 \ + 0xa31abb16, 0xc627, 0x475b, { 0x98, 0x8e, 0x7e, 0xe0, 0x77, 0x67, 0x40, 0xf3 } \ } diff --git a/IntelUndiPkg/GigUndiDxe/StartStop.h b/IntelUndiPkg/GigUndiDxe/StartStop.h index 255f17aabaa4..b29a5002bb8e 100644 --- a/IntelUndiPkg/GigUndiDxe/StartStop.h +++ b/IntelUndiPkg/GigUndiDxe/StartStop.h @@ -32,8 +32,8 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. #include "e1000.h" #define EFI_DRIVER_STOP_PROTOCOL_GUID \ -{ 0x34d59603, 0x1428, 0x4429, 0xa4, 0x14, 0xe6, 0xb3, \ -0xb5, 0xfd, 0x7d, 0xc1 } +{ 0x34d59603, 0x1428, 0x4429, { 0xa4, 0x14, 0xe6, 0xb3, \ +0xb5, 0xfd, 0x7d, 0xc1 } } typedef struct EFI_DRIVER_STOP_PROTOCOL_S EFI_DRIVER_STOP_PROTOCOL; From patchwork Tue Nov 6 17:58:25 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ard Biesheuvel X-Patchwork-Id: 150313 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp4192403ljp; Tue, 6 Nov 2018 09:59:29 -0800 (PST) X-Google-Smtp-Source: AJdET5dVgbnFx2CqRuKEq1GO8h/oynCeV5DyabXo1ba6O1t5+El261t0vS6JQ9KSt5V3g4rO1Yfk X-Received: by 2002:a17:902:6bc9:: with SMTP id m9-v6mr27874403plt.106.1541527169789; Tue, 06 Nov 2018 09:59:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1541527169; cv=none; d=google.com; s=arc-20160816; b=XTScrrZ9BsljEQoOyLxUHPWOjzU5lnpDhdy5vc1pXqBXQB7R7RbhCGreyVKTo2xSBi s6s8CqsXwBil5GmUwAHZGbwpa0ykmJaWTO0LjMvtwqosj82+Q8cMAVtc1lGxip+V8Hvl PgKXAviTN2h8ErGDui3SSFQvioTLOfAAyqgiZglvBUdX7y9L4j/IPSUpQ+rN33jFQafy NeIpBfvqTSBBYpUHvcjHC8GLVRy83tDkeLlGxoXjbqJcxGdoXwQ+RpVHqIP8bcPKdLWR PXDIy+A73jTLf/X+/XWEg10WuQZv2wWRafMLu99l/2TIi8Dba1h7EmORVAz4JcS/a9Pf HsdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:references:in-reply-to:message-id :date:to:from:dkim-signature:delivered-to; bh=3dN1Zs9d1Jpx4EyuGdz91tu8hhz7iaF8zwHXYwMuDwc=; b=YWcK6QkI3K51FGcVm+TzVHY2m6bUhXcqWFrLu/6A931ZVp+bZTeDMLOAOysX3wxllp o9gFr0t1o2yoQctG/pZnGiF9eJHXr2Ij2slzp4i6MFT0pi6X3ifzkPpS8OgiwTs3ArEV uXLxeP09bGYDHx8r3Sg1UAx9Ep3pzYP7Y6lwcaHMeJba8TaKEQkwaIFNphwuyB0PXJIk QJ2XI6u89EloL26tiphBiQ6iMqjjM4lbq7CLzKXaP27Whhn9tAmz7iQWj4j3mOve9eAZ qjaHdZYIxWUQ5RYqrNnwGTYqhTDkW+gKlOsoyjRQZkunGyjYhVHo2pmAg0YuQudZaACw NGdw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=RNZKPiot; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from ml01.01.org (ml01.01.org. [2001:19d0:306:5::1]) by mx.google.com with ESMTPS id i76-v6si6167634pfi.288.2018.11.06.09.59.29 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Nov 2018 09:59:29 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) client-ip=2001:19d0:306:5::1; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=RNZKPiot; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 6B9012118C50B; Tue, 6 Nov 2018 09:59:06 -0800 (PST) X-Original-To: edk2-devel@lists.01.org Delivered-To: edk2-devel@lists.01.org Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::344; helo=mail-wm1-x344.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id A5FEC21131DCF for ; Tue, 6 Nov 2018 09:59:05 -0800 (PST) Received: by mail-wm1-x344.google.com with SMTP id b203-v6so13102486wme.5 for ; Tue, 06 Nov 2018 09:59:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=w+e4mWTLa/0AxeelXA/FlAtta90qVZB3G6fo0JGI1q8=; b=RNZKPiotEB81TdqMinUliNEaeI75vyOBA29eZayeTZDeBFuT/nFuFG+GQ5slqYbf+r 4ou+ntfeEQpyLG3oEsnNkbhb7HrvmOveo7LV2Ok9FgviPk94D6L5d4RLS9lJPw60t4Ne +VqR5mJP8qtBCXSRKaPqHqaBQWrUNDKw1W/fY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=w+e4mWTLa/0AxeelXA/FlAtta90qVZB3G6fo0JGI1q8=; b=uGfDVFBk3TUdCAzn3qSiLFHSj1St7RYMh0X1Dq+7voqbcdWi1fGcvgDYrlBQKO2tob PJ72Enc+9/k226+/j9pQUdVvuUSxCLkpz8kdg+PuUQFuJRtJPJ4r0TcyV4TSYT/44VhM yfEHW/2u2RKtuG7Oq0VBiNNAQh8gfHK8Uf62+ck5cleATxNMxayK0JPrksYHC6jrVp2M Su9QDOslm0Kr4J8/aaw9ZAUrDxd7ztY3mP8zWitoHToPdiXCcrS7soAcZi02KAprmV7P ui2HHjebsFpjtsID2I7F+eQmpFx7dYwqDiHPwSIWYQKA+07bEMzNTrA4R3ALlV58IaWo O0Jw== X-Gm-Message-State: AGRZ1gI3OinyXWXtpEzPVWy86PkxeI6TWw4JK46XDRis62FjXJpRZuI3 a8Vn2Ib6Zndnw96UPeo5Fs9jwgqcePY= X-Received: by 2002:a1c:d181:: with SMTP id i123-v6mr2869449wmg.124.1541527143487; Tue, 06 Nov 2018 09:59:03 -0800 (PST) Received: from localhost.localdomain (laubervilliers-657-1-83-120.w92-154.abo.wanadoo.fr. [92.154.90.120]) by smtp.gmail.com with ESMTPSA id 134-v6sm2971522wmp.6.2018.11.06.09.59.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Nov 2018 09:59:02 -0800 (PST) From: Ard Biesheuvel To: edk2-devel@lists.01.org Date: Tue, 6 Nov 2018 18:58:25 +0100 Message-Id: <20181106175833.26964-12-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181106175833.26964-1-ard.biesheuvel@linaro.org> References: <20181106175833.26964-1-ard.biesheuvel@linaro.org> MIME-Version: 1.0 Subject: [edk2] [PATCH edk2-staging 11/19] IntelUndiPkg/GigUndiDxe: fix incorrect use of CPP token pasting X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: michael.d.kinney@intel.com, eric.jin@intel.com Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" The ## CPP token pasting operator is used to paste *tokens*, which is not the same thing as pasting arbitrary macro arguments. Since a token cannot contain . or ) characters in the first place, using the ## operator here is wrong and unnecessary, so just remove it. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- IntelUndiPkg/GigUndiDxe/NVDataStruc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.19.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel Reviewed-by: Ryszard Knop diff --git a/IntelUndiPkg/GigUndiDxe/NVDataStruc.h b/IntelUndiPkg/GigUndiDxe/NVDataStruc.h index 72f6a95ccb6d..04f08b41c842 100644 --- a/IntelUndiPkg/GigUndiDxe/NVDataStruc.h +++ b/IntelUndiPkg/GigUndiDxe/NVDataStruc.h @@ -112,7 +112,7 @@ typedef struct { @return Width of given field is returned **/ -#define UNDI_CONFIG_WIDTH(Field) sizeof (UndiPrivateData->Configuration. ## Field ## ) +#define UNDI_CONFIG_WIDTH(Field) sizeof (UndiPrivateData->Configuration.Field) // General parameters #define QUESTION_ID_EFI_DRIVER_VER 0x1100 From patchwork Tue Nov 6 17:58:26 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Ard Biesheuvel X-Patchwork-Id: 150314 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp4192479ljp; Tue, 6 Nov 2018 09:59:34 -0800 (PST) X-Google-Smtp-Source: AJdET5dfgb3RDN2KXfPiB3/1hS2k8kIxWciZUAdIUwGrxH/PXOdeO0tKoWjFDKmst02+PyHNwU+C X-Received: by 2002:a63:2744:: with SMTP id n65mr24386652pgn.65.1541527173913; Tue, 06 Nov 2018 09:59:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1541527173; cv=none; d=google.com; s=arc-20160816; b=khQ/flaNQJ6y/JToBoJKiBsCfu/12P6fhvE6OzLheraKdqge/cdVJv+HXyq9QeDvbY eRiD6ja8dfsgIexov+T9oJbXGIM1MQ4c040wAryfy75riJjL+amQfI6KETvXotzcZ3Hw PNS4aJCyJH1JWJa/bVvLnEbnsb2uwPpO9WqzDF91ABxDpGaRcKyxjTqCvX3vgFkay/7j 3jGfRHttZaQDoWJAtX8GFv1maWAW0PX0uwUAH0n2tXUyD0dlwrgk+be5M8z2NntN0U/B zA5ldFoYGCbMoZUlCPCAVR+61XlsnxMbaVq+heSRIBfdim3u60CBcU+25YCaDmrzbzXX YoWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:references:in-reply-to:message-id :date:to:from:dkim-signature:delivered-to; bh=Vp3krQs7UWG7X+kirV0OxNPcjYWRej/+mjnVgk/2QRg=; b=rYGFKENwQVDzHKaSVZUDRks+9VhbVOSnSey1fW4pgpbRw9CdZ5ensHADwN0Vls6hEU k2d4DOJf4GT7gcuF2HVSN5/c9YOsIejmQcodFDZhBWVU5eYKnM24PFziSt/9ylODyjZ8 NaNNdTSi69KAiaemOCIkDHlsgZfO5yKnWPomb8juBiNOgY5Jo7Oz09hOJDuscxWXbrNd GKhSOHG6qexu7uXG6sTHOfT4JlWfpq5AN2FWdOppHEgtsCv/uLY/cSb04bLpfxomYL7i eegCBaqmuXOh0WBefmAL2YZKFpn8//IQZDq1hSjvCYJxRNkk7nxO4qWvSjAH7X/Wu9fW 0pjg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=aeBz1jJr; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from ml01.01.org (ml01.01.org. [2001:19d0:306:5::1]) by mx.google.com with ESMTPS id g18-v6si33302434pfb.278.2018.11.06.09.59.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Nov 2018 09:59:33 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) client-ip=2001:19d0:306:5::1; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=aeBz1jJr; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 987982118C513; Tue, 6 Nov 2018 09:59:08 -0800 (PST) X-Original-To: edk2-devel@lists.01.org Delivered-To: edk2-devel@lists.01.org Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::341; helo=mail-wm1-x341.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C29B121131DCF for ; Tue, 6 Nov 2018 09:59:06 -0800 (PST) Received: by mail-wm1-x341.google.com with SMTP id b203-v6so13102570wme.5 for ; Tue, 06 Nov 2018 09:59:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=FQNwVrxColf3im5HyB5B9ss03ZGtYg/KcQPivxs41X4=; b=aeBz1jJrQ+g1sf+6rboOABBCvuvCeL3EI7W2/hXnkoapPeq7WmCS2veT3+NHWhzOFV +Pas+nf9O9L/NFWfyFCw0e5r77pz9iuiUUfZriGBqmNP76IBP5bxqxLtPvYjb39Al0ql P6AYJAheljh4BBpnB/bvxyiaHwsHe6soayxHo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=FQNwVrxColf3im5HyB5B9ss03ZGtYg/KcQPivxs41X4=; b=UCeA+aHB3uCx73KkbbjiCMPpxBA3//t1yWkH5M5I82f50lkQIpUMjqFwd2/DhZt72t RqahnOAy4w4kRWadTLKG5uVXGE47uhkwht1j+7LS1ipD8wb1ArqRDQXEpObFbhO8c69v QFwKK0fHSc8tzKaTqd68n/Kwd0nYHyEecA4e6tFvLyuwnvvUu+c6EofSOVgRBFYlZSkw 2W/1SXl+1ussCBeS9qJmGWmwuW0sE7rHBDvAmAsPuIvkg3fdZu2KN02H3lZqk7C/L7Au UsbMEF9vKRdIEmn9rs/Iq4vduQRpBNSOFEucyjuIkzhY8JQpRgmjVuIRODiTwiYOyV36 wzmA== X-Gm-Message-State: AGRZ1gKhu3G/Xg2wlj9ZlfTN4o83voYkHugKtVagMk/1lKpb4Bl/qchz ldBrUmw4w91H83XGloiA7DlC4FjfX7I= X-Received: by 2002:a1c:2345:: with SMTP id j66-v6mr2808812wmj.79.1541527145002; Tue, 06 Nov 2018 09:59:05 -0800 (PST) Received: from localhost.localdomain (laubervilliers-657-1-83-120.w92-154.abo.wanadoo.fr. [92.154.90.120]) by smtp.gmail.com with ESMTPSA id 134-v6sm2971522wmp.6.2018.11.06.09.59.03 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Nov 2018 09:59:04 -0800 (PST) From: Ard Biesheuvel To: edk2-devel@lists.01.org Date: Tue, 6 Nov 2018 18:58:26 +0100 Message-Id: <20181106175833.26964-13-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181106175833.26964-1-ard.biesheuvel@linaro.org> References: <20181106175833.26964-1-ard.biesheuvel@linaro.org> MIME-Version: 1.0 Subject: [edk2] [PATCH edk2-staging 12/19] IntelUndiPkg/GigUndiDxe: cast E1000MemCopy () args to correct pointer type X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: michael.d.kinney@intel.com, eric.jin@intel.com Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" E1000MemCopy () takes UINT8 pointers not INT8 pointers, so cast the arguments to the correct type. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- IntelUndiPkg/GigUndiDxe/e1000.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.19.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Ryszard Knop diff --git a/IntelUndiPkg/GigUndiDxe/e1000.c b/IntelUndiPkg/GigUndiDxe/e1000.c index 1f08a5d67b2d..4c9a06b8cf73 100644 --- a/IntelUndiPkg/GigUndiDxe/e1000.c +++ b/IntelUndiPkg/GigUndiDxe/e1000.c @@ -674,8 +674,8 @@ E1000Receive ( // Copy the packet from our list to the EFI buffer. E1000MemCopy ( - (INT8 *) (UINTN) CpbReceive->BufferAddr, - (INT8 *) (UINTN) ReceiveDescriptor->buffer_addr, + (UINT8 *) (UINTN) CpbReceive->BufferAddr, + (UINT8 *) (UINTN) ReceiveDescriptor->buffer_addr, TempLen ); From patchwork Tue Nov 6 17:58:27 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Ard Biesheuvel X-Patchwork-Id: 150315 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp4192556ljp; Tue, 6 Nov 2018 09:59:38 -0800 (PST) X-Google-Smtp-Source: AJdET5cKowcoocCXg0rsiXIFTdv4HivBAxzGFuaiXWLuBLswn9/eMT3E8/Vmw1VFcxelRS9px61f X-Received: by 2002:a63:db02:: with SMTP id e2mr15000899pgg.419.1541527178251; Tue, 06 Nov 2018 09:59:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1541527178; cv=none; d=google.com; s=arc-20160816; b=FxVXh4PTWyxnG5RBIscTc5W2PdzYnLlcjq9sjJRRcLQYQoWjD5Wv6yWcnOa0GxyCjR twlFLMI+QWgdkZN4T4CnrJ2a9KoPzYFDXIddXQW67HXIL0ZrOHVdu0c59F+CHBhnd4/h f1/U/EgTZk6h2CfmxcCyZyLBSRy00pJv0kwV+l5kcsEYXS9IKS4YxxFJT3XNAK6qo6+z fnaw5jRd75fVOY+e9H6hwcndWZ3XMu3KXmhetwutC5apA6Kk2tVfNwicwxL/05biIfCk WugUoI3rW/VhuI+1Rq50yVvcCY2I+z9oh5K40R7NpBcx8waYpYpO9c8+OU1zBEkflVsF 8lKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:references:in-reply-to:message-id :date:to:from:dkim-signature:delivered-to; bh=hFFd8YkmvxGY99ZW1hJa3Cl540qolYsUhik/TTRGxRg=; b=doXU/q3XwwmR8fTUYiKyafBPND0RSw8qLYGrQq/PqQFxpyJx1W28kyp4Ji774vbtOC T3iqP0VLBhRZ6v/B3XVDxCM20N5XFAO7+HltoERLCt6huvsYSfIUcyfcfckzRjlyoSuj 1Y6ZTMBY2tXdqkoIhg023dQZPLSz4qqeN6tORj9DYoGWsmeMhP+RF0vkAoILb40ycmo/ EGzqc1TZzdGqF7D8bNPCFk4CuTy6t24MqYgMg/9SaEs5eyOTDMO3xxFcofOrV8iPiVG6 zCwu/XKtqtkUaBPfRqe8C0XSIzwAs504HTlkNtoorWRVE8nz8PtHY4rAAx0e9xHjMdCc YRNw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b="aWR/qQOw"; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from ml01.01.org (ml01.01.org. [198.145.21.10]) by mx.google.com with ESMTPS id 16si22173914pgh.58.2018.11.06.09.59.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Nov 2018 09:59:38 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) client-ip=198.145.21.10; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b="aWR/qQOw"; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id C852B2118C516; Tue, 6 Nov 2018 09:59:09 -0800 (PST) X-Original-To: edk2-devel@lists.01.org Delivered-To: edk2-devel@lists.01.org Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::444; helo=mail-wr1-x444.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 09F8621131DCF for ; Tue, 6 Nov 2018 09:59:08 -0800 (PST) Received: by mail-wr1-x444.google.com with SMTP id y3-v6so14263033wrh.10 for ; Tue, 06 Nov 2018 09:59:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=kfAlwte03sNvPk5cgq3Y0fCYXpgLbvJxTdtNLfht1kA=; b=aWR/qQOwNKWzkdHf5U8YuMPa50aeAhHIl7G5jlaMdzwWqyF68+x4+SxFR42BcEuZhl WGPOO0VbLx5PdqnLkKPt+h/1zT6X/LnWQRmi1C53FO6zmCC3alhp2cmCvyufJO8j7ggO EQToGyKr35TlDkn09SYRH03RCXHQfMboVTAlo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=kfAlwte03sNvPk5cgq3Y0fCYXpgLbvJxTdtNLfht1kA=; b=TEonoWiKbzry/gWCsgqouebBd3AH6l59JfmlVu447GLTkkWKxYxSxzqYYbJH+EnpY0 OumSG7Cg9kMth9eG0THuB3RjuYYKdk5tPK0MCbpzhTg7lYrFp3wXCkeA3cjYOEbIhK2w zTdiQvPNoIUd8Grm+ia71fwBN3eWAvp2ewb91etdiEynQ63Qz/JecQgPb0xacmO3AjBK lf+ZeY37+fn0BQ0NYigiBDnwKGdOebmNdXT1j4OWYVsYfZHkUHdp7zJTQCmcj0nQzumJ qXXOv4Q7imkAnOaHAthDjrg0R+LxO5fQyDYRBEDnC70UM8/5d+4TaAo73Gp2K+gn4DA6 z+Pw== X-Gm-Message-State: AGRZ1gKrf/wSf5RZMnDTm/W2JXIzVXV7BvRGqx2MFFbnrGFciqXywo1E q9Hkip1sGQeUiTsC8upG8LeVFgxVghw= X-Received: by 2002:adf:a409:: with SMTP id d9-v6mr23924515wra.190.1541527146145; Tue, 06 Nov 2018 09:59:06 -0800 (PST) Received: from localhost.localdomain (laubervilliers-657-1-83-120.w92-154.abo.wanadoo.fr. [92.154.90.120]) by smtp.gmail.com with ESMTPSA id 134-v6sm2971522wmp.6.2018.11.06.09.59.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Nov 2018 09:59:05 -0800 (PST) From: Ard Biesheuvel To: edk2-devel@lists.01.org Date: Tue, 6 Nov 2018 18:58:27 +0100 Message-Id: <20181106175833.26964-14-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181106175833.26964-1-ard.biesheuvel@linaro.org> References: <20181106175833.26964-1-ard.biesheuvel@linaro.org> MIME-Version: 1.0 Subject: [edk2] [PATCH edk2-staging 13/19] IntelUndiPkg/GigUndiDxe: don't take address of cast expression X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: michael.d.kinney@intel.com, eric.jin@intel.com Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" Taking the address of a cast expression is not permitted in C. Instead, take the address of the variable, and cast the pointer to the desired pointer type. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- IntelUndiPkg/GigUndiDxe/e1000.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.19.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Ryszard Knop diff --git a/IntelUndiPkg/GigUndiDxe/e1000.c b/IntelUndiPkg/GigUndiDxe/e1000.c index 4c9a06b8cf73..28c900e3ad63 100644 --- a/IntelUndiPkg/GigUndiDxe/e1000.c +++ b/IntelUndiPkg/GigUndiDxe/e1000.c @@ -1107,7 +1107,7 @@ E1000TxRxConfigure ( // Set the MemPtr to the high dword of the rx_ring so we can store it in RDBAH0. // Right shifts do not seem to work with the EFI compiler so we do it like this for now. MemAddr = (UINT64) (UINTN) GigAdapter->RxRing.PhysicalAddress; - MemPtr = &((UINT32) MemAddr); + MemPtr = (UINT32 *)&MemAddr; MemPtr++; E1000_WRITE_REG (&GigAdapter->Hw, E1000_RDBAH (0), *MemPtr); @@ -1185,7 +1185,7 @@ E1000TxRxConfigure ( E1000_WRITE_REG (&GigAdapter->Hw, E1000_TDBAL (0), (UINT32) (UINTN) (GigAdapter->TxRing.PhysicalAddress)); MemAddr = (UINT64) (UINTN) GigAdapter->TxRing.PhysicalAddress; - MemPtr = &((UINT32) MemAddr); + MemPtr = (UINT32 *)&MemAddr; MemPtr++; E1000_WRITE_REG (&GigAdapter->Hw, E1000_TDBAH (0), *MemPtr); DEBUGPRINT (E1000, ("TdBah0 %X\n", *MemPtr)); From patchwork Tue Nov 6 17:58:28 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ard Biesheuvel X-Patchwork-Id: 150316 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp4192625ljp; Tue, 6 Nov 2018 09:59:43 -0800 (PST) X-Google-Smtp-Source: AJdET5eRWmsfrpG8fYGkecilI3o7AmnvcqDIcsX2Kk5b7JgEdFcusAk/WDS3HqBu6noZUcYfeTvM X-Received: by 2002:a62:d084:: with SMTP id p126-v6mr28376981pfg.147.1541527182890; Tue, 06 Nov 2018 09:59:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1541527182; cv=none; d=google.com; s=arc-20160816; b=vPtLUGQ3dEgxQvy1d3Y4NCACBVY7e6Q0JI1i2K2gpOvmOF8uL0QSBIvqbLaS15r7ez fUPjcU77NFjC7T1bcXyeb9mAW/ioFC7tZ7xfJ6zSsxXX3TZd7MZ7bOpSLody6Jpx+5UK fMpdLvY8IdtvTP+1O9JNefJvGB2kMwLtk7Qmj3tic5M/D3pY9NfLUBoJN/9Sbjbb3xSe fnwwYriXMZYexY7lDyX3d9LfsRGTxF5RfWlN6ysEqGtWQltI1XdL4py1qx65Gc0cTTxC JhNHpoySrsXPzG3pyMC/Agnv//uI6bEX74dHwUY89maega1Vvfbx/P9pQ9a7vPL8yvbh PoHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:references:in-reply-to:message-id :date:to:from:dkim-signature:delivered-to; bh=x4pUIq4/SsoHgGQMaxgu4HOJp5mhmvbyCQ/hCLvIm7g=; b=EaC+ShpHPnKpfSIsgLdJKIUl7p8TBj6EPAeYnZjtvqQUaJxEQ5ycw/mKC7vO7K6w4+ tFUL/kMJX+cHAPad1d2qFKX7bElwQ07CEOLox1+dpeawGAKe2uu5E0YhjjggnF/7bVdt cDd7176tuYskLAYCbvdDWG7A06zM4qCBqJK/0d4I26TlEUVF3D57/C84p3PV+UHiZfni mzqZ1ndzWmR6mlO7NfeoaDFLD3vAmCl4dOHX6cpEm15qLBDQZnkN+YTrYE4GVmUBL2rd P0u6jwj/a/H+/qBTfi+OFEeFBgzpWxUqCyey1uOta4/Q/u6fn9X5HGj5CuVH9qGPjZUw QSLA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=L5vL5cXs; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from ml01.01.org (ml01.01.org. [2001:19d0:306:5::1]) by mx.google.com with ESMTPS id q61-v6si40415348plb.418.2018.11.06.09.59.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Nov 2018 09:59:42 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) client-ip=2001:19d0:306:5::1; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=L5vL5cXs; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 06DCA2118C517; Tue, 6 Nov 2018 09:59:11 -0800 (PST) X-Original-To: edk2-devel@lists.01.org Delivered-To: edk2-devel@lists.01.org Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::444; helo=mail-wr1-x444.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 4B5622118C516 for ; Tue, 6 Nov 2018 09:59:09 -0800 (PST) Received: by mail-wr1-x444.google.com with SMTP id y15-v6so14562040wru.9 for ; Tue, 06 Nov 2018 09:59:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=OgpzoA439HzBv4Gk62XxgoT41vrsXnWZozzW5XcyJhk=; b=L5vL5cXsFT5VzyIyKjwmyPXbk2nFFjQH/eY3wwqvxQtD4JCEVt1V9f1wrUxIUlyskT dkDQZQPNY4jT8NNn1FLdey+fUT+bYDL7ma6lcC3tfGE6tFRg0QC7JxZzg7kVStS8T3v4 B4WABJZU2nM+JqKmwEpAM1i0mCTTanb/rz53w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=OgpzoA439HzBv4Gk62XxgoT41vrsXnWZozzW5XcyJhk=; b=BfOKewtbiAUZhcdBSeQQnUfAm4HsXniCrm5Sq+6FCxa/h0NMMB9Y7uv+U1lSSOm3Wr RzWG/QCpY1YsPArfJ3xVx+Ydaa0njdx8nS7AoOharTSHuDqjkLCVpL2/GBui51tiwRYM 7J6XrFRPuSmj3cQL2Cu2VZUrd+/qoBRaOi5cqRKNx+oc8rVVNgNc6NMAgDSVDNup0PXa uI3HvhavYJgD63XFCtnrlqGKOnF+yh/5mhdj9PeH/3+DLNxziuW9O0gSCVDnoTpeAaOS 2I8Cr3GlcokDZxD9+Z6ykqlZNU1hhBChb2oKbpdfArkCD0g6xeH3FUj3DPzBkSw0RU+v 8UvA== X-Gm-Message-State: AGRZ1gLHCP+D0tCFwGYe5PlNzo6YL/IG6kYP1TCkHcSC4OxfZ3GdCVwu uvnDLPRBixIxd7+WSHcyePzqAaWqf5U= X-Received: by 2002:adf:e84e:: with SMTP id d14-v6mr21357656wrn.51.1541527147669; Tue, 06 Nov 2018 09:59:07 -0800 (PST) Received: from localhost.localdomain (laubervilliers-657-1-83-120.w92-154.abo.wanadoo.fr. [92.154.90.120]) by smtp.gmail.com with ESMTPSA id 134-v6sm2971522wmp.6.2018.11.06.09.59.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Nov 2018 09:59:06 -0800 (PST) From: Ard Biesheuvel To: edk2-devel@lists.01.org Date: Tue, 6 Nov 2018 18:58:28 +0100 Message-Id: <20181106175833.26964-15-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181106175833.26964-1-ard.biesheuvel@linaro.org> References: <20181106175833.26964-1-ard.biesheuvel@linaro.org> MIME-Version: 1.0 Subject: [edk2] [PATCH edk2-staging 14/19] IntelUndiPkg/GigUndiDxe: redefine UNREFERENCED_nPARAMETER macros for GCC X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: michael.d.kinney@intel.com, eric.jin@intel.com Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" Use (VOID) casts to silence unreferenced parameter warnings on GCC. The existing macros generate 'statement with no effect' warnings instead, which does not really help. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- IntelUndiPkg/GigUndiDxe/e1000_defines.h | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) -- 2.19.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel diff --git a/IntelUndiPkg/GigUndiDxe/e1000_defines.h b/IntelUndiPkg/GigUndiDxe/e1000_defines.h index 1d07d30aa18e..b9ce1e5e6339 100644 --- a/IntelUndiPkg/GigUndiDxe/e1000_defines.h +++ b/IntelUndiPkg/GigUndiDxe/e1000_defines.h @@ -1622,12 +1622,19 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. #endif /* NO_82575_SUPPORT */ #ifndef UNREFERENCED_XPARAMETER -#define UNREFERENCED_XPARAMETER +#ifdef _MSC_VER #define UNREFERENCED_1PARAMETER(_p) (_p) #define UNREFERENCED_2PARAMETER(_p, _q) (_p); (_q); #define UNREFERENCED_3PARAMETER(_p, _q, _r) (_p); (_q); (_r); #define UNREFERENCED_4PARAMETER(_p, _q, _r, _s) (_p); (_q); (_r); (_s); #define UNREFERENCED_5PARAMETER(_p, _q, _r, _s, _t) (_p); (_q); (_r); (_s); (_t); +#else +#define UNREFERENCED_1PARAMETER(_p) (VOID)(_p) +#define UNREFERENCED_2PARAMETER(_p, _q) (VOID)(_p); (VOID)(_q); +#define UNREFERENCED_3PARAMETER(_p, _q, _r) (VOID)(_p); (VOID)(_q); (VOID)(_r); +#define UNREFERENCED_4PARAMETER(_p, _q, _r, _s) (VOID)(_p); (VOID)(_q); (VOID)(_r); (VOID)(_s); +#define UNREFERENCED_5PARAMETER(_p, _q, _r, _s, _t) (VOID)(_p); (VOID)(_q); (VOID)(_r); (VOID)(_s); (VOID)(_t); +#endif #endif /* UNREFERENCED_XPARAMETER */ #ifndef E1000_UNUSEDARG #define E1000_UNUSEDARG From patchwork Tue Nov 6 17:58:29 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Ard Biesheuvel X-Patchwork-Id: 150317 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp4192708ljp; Tue, 6 Nov 2018 09:59:48 -0800 (PST) X-Google-Smtp-Source: AJdET5fYZAI/OMC4L/cyBtrNJhM8qg+ywHKfdjlJv3fmgAHTI8z3p73Rm+mOHHh5O7ndHuzl9uGx X-Received: by 2002:a63:d10b:: with SMTP id k11-v6mr24873365pgg.80.1541527188042; Tue, 06 Nov 2018 09:59:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1541527188; cv=none; d=google.com; s=arc-20160816; b=qAXk1izAecompwPnT+gXRni79Iam+pcARtKAVbOt/1VVrbKoHIwvc1mLxEIN0451XR r1xNSDREcG+ZANQA4tB67cxsnQZwjpskbDrm2P79sRkWv3TEfqcDbescGsc9/h+IN8k6 8XcAmIt9RoODTyFPXpYdqeiQ43C4FX3np7oGJru1GPZsfuPqEJ3/yUE1xcqgUstpCNHd xzCFvxPHiA6K3wqXDjcj03AkdW/tmfVfqFB3QuHexF7uxVTvDZS2PvN+gM3Sg8cl08Pm QLhEe08jXtPFuxq5ViWgxm7qD7BIHwYUeDFp96McyX0Er3NJz3tWo2OyDabFNzsKQ6E8 ZD9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:references:in-reply-to:message-id :date:to:from:dkim-signature:delivered-to; bh=L6PrE6oMLXPfLWU2+Y0QVwCKpDyvz4KlAZ1gl4H0Grs=; b=tRsEcZPAP1/OL2vkz2OR55yD9rp9yGMfImQu/b841H59QB6wxjy1uV8DZHfOUkFbyb dycF34RT8WzFQYnPDnCSTHGQ+ZVROn1A2hwKTiljCaSD0M/QZjgGJG+gljMG6+O1SziH 8TpsxjYBZ6t7ccr9pe1DIrmgCLXu1UKv4JKVNMrrKcZPnaaXC6g2a7MHQGP6WvLWSjxi xo/T2YXhMhJDU0Z5TIF9q0EOJOeZYve3T38dX8EcQ5nf083tVHsXCffPrGD1zUHm2ueC pQLBifT1XxM4olOqJC+KeIjl533DR5U8FaJ06R12rz1DkTawmCY1UB024fZal1mqI/44 NJJg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=gSE1WmAr; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from ml01.01.org (ml01.01.org. [198.145.21.10]) by mx.google.com with ESMTPS id k8-v6si38396906pgj.192.2018.11.06.09.59.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Nov 2018 09:59:48 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) client-ip=198.145.21.10; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=gSE1WmAr; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 34EC02118C51F; Tue, 6 Nov 2018 09:59:12 -0800 (PST) X-Original-To: edk2-devel@lists.01.org Delivered-To: edk2-devel@lists.01.org Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::441; helo=mail-wr1-x441.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 742242118C517 for ; Tue, 6 Nov 2018 09:59:10 -0800 (PST) Received: by mail-wr1-x441.google.com with SMTP id z16-v6so14591418wrv.2 for ; Tue, 06 Nov 2018 09:59:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=UqfAv1zKb4MG092pY9tMguraKJN6j/tv+A0sxgxcHqs=; b=gSE1WmArAw4eEuSf8ATnefuzDjk2S3ihfdaqZ5PD7iHN5udViix3WcZLoz3SDhT9lK 0qlnEkwW5nSHEqpmAL7xlRKcWXmcQ+Jh7yThQ3x80jc1iDDmX/rHdXZfpmqd1oY65Y/L IyDONLeGpsQADbF34gr/ti2KXrCwDs5c0QkAM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=UqfAv1zKb4MG092pY9tMguraKJN6j/tv+A0sxgxcHqs=; b=sQaLyujygCWU7Afsr9JqzkNuT/gCFrz4lwiWrlPtyMcOGIhxgjW1g9OQpAOKkCpt2M WBF2s8ajg1IGdQ35DK88JERLqozGaENo/8SnIFd32q4yve1hc286nMMFJxMLKP68ytDy zsrIkShuWOYZXC4XENKY+r6nCMyQfxPLtllYliR76X2+RyTzsqpgQ+ROoSQzWUZv86Kq 0xoyHl7/ohxQwkTOFSynfih5usWV6P9kJBzvjvItXSnVPcODD+zdt641+CdjJjYbAdgc AzVr4Idl0iJJVyKz8ZQ9FsvTz+AyJrhnLmPdOz9fKtQpKt0+5P7Ze7imjR5Q13VX8MUF DjAg== X-Gm-Message-State: AGRZ1gK0wcxzKCSq1kiLjv1LOEHdTMSqlc8akhtH8ITyTxJ1FcCpLz9J 8cwQrXQqOqK+uL6PSvj5h+PZJPTSRNY= X-Received: by 2002:a5d:564f:: with SMTP id j15-v6mr23538656wrw.228.1541527148864; Tue, 06 Nov 2018 09:59:08 -0800 (PST) Received: from localhost.localdomain (laubervilliers-657-1-83-120.w92-154.abo.wanadoo.fr. [92.154.90.120]) by smtp.gmail.com with ESMTPSA id 134-v6sm2971522wmp.6.2018.11.06.09.59.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Nov 2018 09:59:08 -0800 (PST) From: Ard Biesheuvel To: edk2-devel@lists.01.org Date: Tue, 6 Nov 2018 18:58:29 +0100 Message-Id: <20181106175833.26964-16-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181106175833.26964-1-ard.biesheuvel@linaro.org> References: <20181106175833.26964-1-ard.biesheuvel@linaro.org> MIME-Version: 1.0 Subject: [edk2] [PATCH edk2-staging 15/19] IntelUndiPkg/GigUndiDxe: remove forward declaration of non-existent function X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: michael.d.kinney@intel.com, eric.jin@intel.com Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" Remove the forward declaration of e1000_disable_ulp_lpt_lp (), which is never defined anywhere in the code. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- IntelUndiPkg/GigUndiDxe/e1000_ich8lan.c | 3 --- 1 file changed, 3 deletions(-) -- 2.19.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Reviewed-by: Ryszard Knop diff --git a/IntelUndiPkg/GigUndiDxe/e1000_ich8lan.c b/IntelUndiPkg/GigUndiDxe/e1000_ich8lan.c index 7669630a5c03..e9fc5394ab28 100644 --- a/IntelUndiPkg/GigUndiDxe/e1000_ich8lan.c +++ b/IntelUndiPkg/GigUndiDxe/e1000_ich8lan.c @@ -103,9 +103,6 @@ STATIC s32 e1000_reset_hw_ich8lan(struct e1000_hw *hw); STATIC s32 e1000_init_hw_ich8lan(struct e1000_hw *hw); STATIC s32 e1000_setup_link_ich8lan(struct e1000_hw *hw); STATIC s32 e1000_setup_copper_link_ich8lan(struct e1000_hw *hw); -#if !defined(NO_ULP_IN_S5_SUPPORT) -STATIC s32 e1000_disable_ulp_lpt_lp(struct e1000_hw *hw, bool force); -#endif /* !NO_ULP_IN_S5_SUPPORT && !ULP_IN_D0_SUPPORT */ STATIC s32 e1000_setup_copper_link_pch_lpt(struct e1000_hw *hw); STATIC s32 e1000_get_link_up_info_ich8lan(struct e1000_hw *hw, u16 *speed, u16 *duplex); From patchwork Tue Nov 6 17:58:30 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Ard Biesheuvel X-Patchwork-Id: 150318 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp4192795ljp; Tue, 6 Nov 2018 09:59:52 -0800 (PST) X-Google-Smtp-Source: AJdET5dwSYwW07KykyUaBqIwyOf1VuX7COS4aUfnlYfyr7A6QkBXraD3i1DImpShg8uDEcOZO0XH X-Received: by 2002:a65:520a:: with SMTP id o10mr25369454pgp.276.1541527192752; Tue, 06 Nov 2018 09:59:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1541527192; cv=none; d=google.com; s=arc-20160816; b=MtgJ+7eUa4mkt8lqBCOE5/3WkCwG/b0FduLCvP8A3KB76woxhYX699Yy/GiqOf1//k ifwsSZQUdm9gpiJIxcphct6GO20n0KwXBYjGdQ6xbBEAKHXBtMF+0Ab1nC1XblQPSzQO IjHXYHRr6SAp+9US/3g19fULX/c3mRltIBGYm90odHFla8zgRlr27Hu9IbeRrWtKk//X RMSjP0WPw70hr1gvCIoRo23CkVjbTUFvb4HXCsW8SqvUh6eLby8IxNwO+mHCIqlwY2Jp hSJ/naeaTqlLsgW5IPCnbrv4pUXvW7DsEzX6fmPfX5E3fsScg/JvJ7krjQ0wVoj7hSaM WV7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:references:in-reply-to:message-id :date:to:from:dkim-signature:delivered-to; bh=V0TZTIzxbBGK+AmixpuZs0fG8PD+yjTckFhCmZuOVfQ=; b=jynmQmeJDbJcPok4uT1XzOsooJS1DXsCwUOaHdLXw/Okb/OWc67HaBm3JHQI3KZeiW 3TWOrTuL+F9RwQeaQvScSlfGHFeZllTw8jpxvEa/DU+cVdeTxfFwUdfbQo430XGIkFK+ R3f45Nkdbi/IEy3wjeW5t2yYPf57sz7/xSrowaeu9r9s5OIY6xBtwOQXBJIliFjBLSSg DBynVSMa1YPW9ASDIsRdhk3bEsF/EEUwp+XbOoePTGUamlVP8omm6yNB4Su7DrRVhnnc 8KWw/Rg1pDR+tQWlDuKsEO/K1K6HXq6BUmeV7vYaY+/r6zyE9rzFRnlq1WdSo05NJdA5 BGHQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=DT4uLTCz; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from ml01.01.org (ml01.01.org. [198.145.21.10]) by mx.google.com with ESMTPS id r26-v6si26666761pgb.372.2018.11.06.09.59.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Nov 2018 09:59:52 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) client-ip=198.145.21.10; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=DT4uLTCz; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 6588E2118D925; Tue, 6 Nov 2018 09:59:13 -0800 (PST) X-Original-To: edk2-devel@lists.01.org Delivered-To: edk2-devel@lists.01.org Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::444; helo=mail-wr1-x444.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id CC9A32118C51E for ; Tue, 6 Nov 2018 09:59:11 -0800 (PST) Received: by mail-wr1-x444.google.com with SMTP id i17-v6so14564135wre.7 for ; Tue, 06 Nov 2018 09:59:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=MD5l3RndVRwqNwW1ijPEUy5GkuOVbnlm0RMjFz9QHm4=; b=DT4uLTCzyVYHg42FlhaPobmVvfsP3tueiArxxmaE/0nQPj6dicnt90hH6SlLsh0/bK wor2c57Bi/O+V2dbpRVUKI7OXWByJLPTnZASp5SP3ouqcFmyL8wgFnk5IGIj5qiPOOIA BhMEd0YBnnnJ3+L2kjqynLQnI2cjaMQOLCVTo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=MD5l3RndVRwqNwW1ijPEUy5GkuOVbnlm0RMjFz9QHm4=; b=Oo6azFhVgbZjMi6dV98wjHfQac/a0uDJtAt5vxJWpNxHetkp10ZUf6pDkqRSrlyiyW 4yeBbyNlzSxktjmCuf4QxZNg6RicfCpgdAXACMvXk7if0YwsXM+49UqFYrDp7nIYxY3f RexIjes4gbZq8afv/KbIwiKnPZw2KXFkXBPOqYbJfG4vWMH8AGD/4Tn27MwZX1ANt6Jp gm/5n3QdvfD8io+kNI7UvbGZVH64uePMTKTGO5/e6rGyS0dJ4JSusgLIaEy07+w21H1N fDE2QUbk4WIGDWAsNmtIf/AQ7qQoXmJHl0u0gAXmQBLEk/DDXMdnB2k7Mz6MZDU3eYi2 yopQ== X-Gm-Message-State: AGRZ1gKARitpRdbg/+uYToRlWzV/27C0WiVP5NbGVqt6IuvlihCgJSKg YgFbqEIjPxk2IfEkNgkrFBY2Tc0ECto= X-Received: by 2002:adf:9051:: with SMTP id h75-v6mr16301526wrh.65.1541527150053; Tue, 06 Nov 2018 09:59:10 -0800 (PST) Received: from localhost.localdomain (laubervilliers-657-1-83-120.w92-154.abo.wanadoo.fr. [92.154.90.120]) by smtp.gmail.com with ESMTPSA id 134-v6sm2971522wmp.6.2018.11.06.09.59.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Nov 2018 09:59:09 -0800 (PST) From: Ard Biesheuvel To: edk2-devel@lists.01.org Date: Tue, 6 Nov 2018 18:58:30 +0100 Message-Id: <20181106175833.26964-17-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181106175833.26964-1-ard.biesheuvel@linaro.org> References: <20181106175833.26964-1-ard.biesheuvel@linaro.org> MIME-Version: 1.0 Subject: [edk2] [PATCH edk2-staging 16/19] IntelUndiPkg/GigUndiDxe: fix incorrect indentation X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: michael.d.kinney@intel.com, eric.jin@intel.com Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" Silence a 'misleading indentation' GCC warning by fixing the incorrect indentation. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- IntelUndiPkg/GigUndiDxe/e1000_ich8lan.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) -- 2.19.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé diff --git a/IntelUndiPkg/GigUndiDxe/e1000_ich8lan.c b/IntelUndiPkg/GigUndiDxe/e1000_ich8lan.c index e9fc5394ab28..6ce9ac3c5195 100644 --- a/IntelUndiPkg/GigUndiDxe/e1000_ich8lan.c +++ b/IntelUndiPkg/GigUndiDxe/e1000_ich8lan.c @@ -1102,13 +1102,13 @@ STATIC s32 e1000_check_for_copper_link_ich8lan(struct e1000_hw *hw) if (!mac->get_link_status) return E1000_SUCCESS; - /* First we want to see if the MII Status Register reports - * link. If so, then we want to get the current speed/duplex - * of the PHY. - */ - ret_val = e1000_phy_has_link_generic(hw, 1, 0, &link); - if (ret_val) - return ret_val; + /* First we want to see if the MII Status Register reports + * link. If so, then we want to get the current speed/duplex + * of the PHY. + */ + ret_val = e1000_phy_has_link_generic(hw, 1, 0, &link); + if (ret_val) + return ret_val; if (hw->mac.type == e1000_pchlan) { ret_val = e1000_k1_gig_workaround_hv(hw, link); From patchwork Tue Nov 6 17:58:31 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ard Biesheuvel X-Patchwork-Id: 150319 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp4192901ljp; Tue, 6 Nov 2018 09:59:58 -0800 (PST) X-Google-Smtp-Source: AJdET5fkSbSPnp6y1zdrAOkEk72/FPzoT2Sg3H0sbPxllUKOo8VnKaZSPtcbtWiI45BluXZH9XyQ X-Received: by 2002:a17:902:9a94:: with SMTP id w20-v6mr27346121plp.115.1541527198314; Tue, 06 Nov 2018 09:59:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1541527198; cv=none; d=google.com; s=arc-20160816; b=08UfWK0hVfzZPX1+ZvSyOCI96KrZwXIvgtilaX7kjv+JynzU5ZBz8glnDEh+6MHOYG hKRot8O9zxzTxMG0pYvEypyoD2AA7VtEtgpQ1gNl5BeEzaNtzv+SWME/MjwX/SdD17A4 D+8+YZDdsQpRShBXwj04nJZ7adHKL+3RrM8vPecbNkn8sQXRdOOa5aPcivce/IN4quIX dF0DmueZBiepgnffcD36PXiuDB3kMUbAHlzumJAkerOw3k1T70yvUUWkD8eW0J8/5o75 qyhJoXbGvnfj/LMfKFYORt4Z5HWOhHPBkX3CDfIAY/sXNUTOmkXTkc1F11JoONfSRpLK aUYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:references:in-reply-to:message-id :date:to:from:dkim-signature:delivered-to; bh=LeQ/2iS/KL82W8L/ZF9Tm6xoiVU5s5QDQwpT3SdF8r4=; b=mFYEbVsx4VBvb8EeyHPk2btTls51M6U8Q9t1lgTko046uK4o/5Ipei/mI7Vi0CQLEK 4oWksoLPDuBBAktNe3nq1iJ9y7M9AQJ01+B8E9+dAlLNFoZTSKQMjQhXQ5Bj2aYpN+/R 5yMp9T0U5PEt7Jhfys3pfNriPQOcJ6wZwAoagOYdrui9hBB9MxYfXF6njOndkcdyNpGt T/9zNZV+Xr2ZqijyUF8NbHRJht5NqSEjw8++MrSphyknbvMJV/KnVfctwjM/DmAb8tQ8 m26bef3GMs+uOTODLq/YZbJX+o9+vlRl9rLQUxqlySlYVpgIc+5/ouBHfETqBoCxMV2m BNQg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=UoLDmYK2; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from ml01.01.org (ml01.01.org. [198.145.21.10]) by mx.google.com with ESMTPS id z3-v6si46360922pgh.250.2018.11.06.09.59.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Nov 2018 09:59:58 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) client-ip=198.145.21.10; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=UoLDmYK2; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 92E612118D927; Tue, 6 Nov 2018 09:59:14 -0800 (PST) X-Original-To: edk2-devel@lists.01.org Delivered-To: edk2-devel@lists.01.org Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::443; helo=mail-wr1-x443.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 36D4E2118C515 for ; Tue, 6 Nov 2018 09:59:13 -0800 (PST) Received: by mail-wr1-x443.google.com with SMTP id o15-v6so10943587wrv.4 for ; Tue, 06 Nov 2018 09:59:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=44qpO25RhPILFn5/JlKD5YNcPuymL4qRqgGRmkGXxmc=; b=UoLDmYK2gLo7Z8B9t3n1hyYUo1xQFJcL92eRRI0qrpA3vCQZ/lNx25vxd+x/JXx56s NiiXr1LkAUqkUobzVthEWSzkClONi6BcXalZY5pnjvboUYqvA3bPknifrTcME5IQJfrA WWevOA0YPViBzBcOEy7oKtc+VuktYLFxG5Qpk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=44qpO25RhPILFn5/JlKD5YNcPuymL4qRqgGRmkGXxmc=; b=YzNfz/K+i0nI1/sMCeOT+Y9/ghEjRp678azGE6Ku74/VhrXEe3KCu/9Do+WuZMD9eS WFrvIAaYt8ni0RZMIzxRyuc8U/77X8h8oKzSbOkw0E02a2scVnPFg4dq8w9w5CyhPKIL je/BZvPRav1cxuz44DzQsKuPyupNFbw+yMhZXE/fmC63ZODhrkvShuUlKaVkEQzPaaZj IZQ+lk/BvzhVQjqEnFTArzeNC9urXZzxCzc+6p/w7uJZeb0eTf9qUDe+iER7QhSdVuq5 BYPuvJ2Mm2k3f0sMmwucFUjiZzrStk1EfEI5ZFoDZodO/VlSWrgKOYlHYqjyLwgf9pm4 4sxA== X-Gm-Message-State: AGRZ1gKHPreUxiE/zQjOY5JwTQbBLU8BwcSXNjY413kEhMMqzbAaqQFG MiEbvPc9tNDt+16aK5DsZXm3A+nNzD0= X-Received: by 2002:adf:fb4b:: with SMTP id c11-v6mr23687900wrs.117.1541527151489; Tue, 06 Nov 2018 09:59:11 -0800 (PST) Received: from localhost.localdomain (laubervilliers-657-1-83-120.w92-154.abo.wanadoo.fr. [92.154.90.120]) by smtp.gmail.com with ESMTPSA id 134-v6sm2971522wmp.6.2018.11.06.09.59.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Nov 2018 09:59:10 -0800 (PST) From: Ard Biesheuvel To: edk2-devel@lists.01.org Date: Tue, 6 Nov 2018 18:58:31 +0100 Message-Id: <20181106175833.26964-18-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181106175833.26964-1-ard.biesheuvel@linaro.org> References: <20181106175833.26964-1-ard.biesheuvel@linaro.org> MIME-Version: 1.0 Subject: [edk2] [PATCH edk2-staging 17/19] IntelUndiPkg/GigUndiDxe: move MSFT warning overrides to INF file X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: michael.d.kinney@intel.com, eric.jin@intel.com Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" GCC chokes on the unknown MSVC specific #pragmas used for suppressing warnings, so remove them and use the INF BuildOptions section instead. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf | 2 +- IntelUndiPkg/GigUndiDxe/e1000_osdep.h | 3 --- 2 files changed, 1 insertion(+), 4 deletions(-) -- 2.19.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel Reviewed-by: Ryszard Knop diff --git a/IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf b/IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf index 19dae9a0987a..9159e826ec45 100644 --- a/IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf +++ b/IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf @@ -41,7 +41,7 @@ ENTRY_POINT = InitializeGigUNDIDriver UNLOAD_IMAGE = GigUndiUnload [BuildOptions.common] - MSFT:*_*_*_CC_FLAGS = /FAcs /D MDEPKG_NDEBUG + MSFT:*_*_*_CC_FLAGS = /FAcs /D MDEPKG_NDEBUG /wd4244 /wd4206 GCC:RELEASE_*_*_CC_FLAGS = -D MDEPKG_NDEBUG [BuildOptions.X64] diff --git a/IntelUndiPkg/GigUndiDxe/e1000_osdep.h b/IntelUndiPkg/GigUndiDxe/e1000_osdep.h index 4408b409a445..70f33811dd04 100644 --- a/IntelUndiPkg/GigUndiDxe/e1000_osdep.h +++ b/IntelUndiPkg/GigUndiDxe/e1000_osdep.h @@ -34,9 +34,6 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. #include #include -#pragma warning(disable : 4244) -#pragma warning(disable : 4206) - #ifndef EFI_SPECIFICATION_VERSION #define EFI_SPECIFICATION_VERSION 0x00020000 #endif /* EFI_SPECIFICATION_VERSION */ From patchwork Tue Nov 6 17:58:32 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ard Biesheuvel X-Patchwork-Id: 150320 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp4192989ljp; Tue, 6 Nov 2018 10:00:02 -0800 (PST) X-Google-Smtp-Source: AJdET5eTUpjfuzU8yv33SL8Y61GVkk1mja5cVXvsNSeZfTsM6SmxYr4nhECPOPddEbjcJuALXWv2 X-Received: by 2002:a62:1954:: with SMTP id 81-v6mr27216866pfz.237.1541527202837; Tue, 06 Nov 2018 10:00:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1541527202; cv=none; d=google.com; s=arc-20160816; b=fzDW12bbPelBiALNHEvQ4fENYvZNtXwL9HgV82fpQQaKHNwQxSxRgHJBuKpRDDTxr/ MFbprslHgdWVXapYabtS7hYSafWrhWeMfuGe35ZqNp1tOGdycJJH5rMw+7tO6P4y+CAE +q6UkNDEpFxuX7W9YebWJtsM/n2oyWqKDjExcvwgdpXQvQgrmrxUbtfofPTTVeftyITS pse5DAR5oobmEQKuoTXLSjfMOJKgmK8VI63+setidGGub2V2i/A6L//wnw5Vvc+Slvk/ u144PBrZ68Xtlb9eghbLKOuCiLHwq3Rqgx6Jy0hy2AQDOWeHuXtk+M0LlBOGhlmLiuW0 i3YQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:references:in-reply-to:message-id :date:to:from:dkim-signature:delivered-to; bh=/rXDfuPfUNmWLoMyGKqlswOltmlG2TJJrDtBMyKNwjM=; b=nScDEU8gSuspIW3DNt1hArbEzKpkQYKZcSCG0YSe6z3fV49sWPi1Cq66f1adxQ5j7u oGCo4mINiHuerBH7wufTuBzSx9sQl54o/gPwvAfJXZo4tGAwyUgSKQu4MEgmGuEyasY8 rvqA1/w3ZEYfT8+8oY/G1mrRHzlfiHwVbX33gha/AYgFl2dfhagbF4qtfLZjCKbpwi7v DIeMMRcpjKqSt4q2tUfzwOurVWS/OfHIvWOwsIF2haFsIHG8T6om5/5G2YHW1pKb/hQZ 8b2u2NbIDw3r+HKjRRt2zo8Nw7pi0eWYWeH6s5eqs4hYfkxwLuWir7NTKAKaR36ePe8l d4kA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=Qd5cI8JN; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from ml01.01.org (ml01.01.org. [198.145.21.10]) by mx.google.com with ESMTPS id h71-v6si49028369pfa.261.2018.11.06.10.00.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Nov 2018 10:00:02 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) client-ip=198.145.21.10; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=Qd5cI8JN; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id BD8912118D92B; Tue, 6 Nov 2018 09:59:15 -0800 (PST) X-Original-To: edk2-devel@lists.01.org Delivered-To: edk2-devel@lists.01.org Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::442; helo=mail-wr1-x442.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 757822118D923 for ; Tue, 6 Nov 2018 09:59:14 -0800 (PST) Received: by mail-wr1-x442.google.com with SMTP id k15-v6so11595055wre.12 for ; Tue, 06 Nov 2018 09:59:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=taSk5R2Jst74hTMPa/m4SIFWRe/HGuvABbklkoONmPc=; b=Qd5cI8JN/WvnUn+Mle4c6BaebEVTd1rHguKjqth2dQYU8/alVuMiwv2c9Q4NFvwW2V YzamMQaV/4qLM54g1RcLx5NaUbcEtJrNq5z2vSHpebq/c5vAoAxmd9LglRFmcYiYt+U4 PQiN6FmEziqjQOU3m/GITmvMunLVrQAfRA488= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=taSk5R2Jst74hTMPa/m4SIFWRe/HGuvABbklkoONmPc=; b=ZkSMZ98BtzBoijRRguJyUIvUz+jUN3R9gV6d+z+s+z8FE2yN+c0u8jLZ9PCj1OMlOg MsUUZ1ywrqzpio7OhZRRwbLfAvzbRyaRSXqzz2W1LcWRUHt/pi/8NO0TCfDV1FcrehWJ IYo658jvLW7TnZzx5+e/IM1V17kQstDet20VVdanEonr1O5hAPdX8Q3BD3gD9jizy7AQ CIMXfsPqEW7fvfdXTA3UjOo4gY9Uf5fp81b7FvGbTokYnZ+Hy03T84OCKXJN6JmJaP18 jlc8xxsx5w4froZhdcy0lATiumnfldrvaam2HgSiktodrJXxzI8P5MUeISNJBP136LaD 3V5w== X-Gm-Message-State: AGRZ1gJEFGwvwq8fnCmsSKpQg17Xr1omucwyiL/fRDuUC1v7jh/EMN7Y 7fZi5Akzl21aBo0KoABDdwWXrn+gSn8= X-Received: by 2002:adf:e651:: with SMTP id b17-v6mr24454148wrn.254.1541527152710; Tue, 06 Nov 2018 09:59:12 -0800 (PST) Received: from localhost.localdomain (laubervilliers-657-1-83-120.w92-154.abo.wanadoo.fr. [92.154.90.120]) by smtp.gmail.com with ESMTPSA id 134-v6sm2971522wmp.6.2018.11.06.09.59.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Nov 2018 09:59:11 -0800 (PST) From: Ard Biesheuvel To: edk2-devel@lists.01.org Date: Tue, 6 Nov 2018 18:58:32 +0100 Message-Id: <20181106175833.26964-19-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181106175833.26964-1-ard.biesheuvel@linaro.org> References: <20181106175833.26964-1-ard.biesheuvel@linaro.org> MIME-Version: 1.0 Subject: [edk2] [PATCH edk2-staging 18/19] IntelUndiPkg/GigUndiDxe: add missing EFIAPI modifiers X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: michael.d.kinney@intel.com, eric.jin@intel.com Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- IntelUndiPkg/GigUndiDxe/AdapterInformation.c | 3 +++ IntelUndiPkg/GigUndiDxe/ComponentName.c | 2 ++ IntelUndiPkg/GigUndiDxe/ComponentName.h | 1 + IntelUndiPkg/GigUndiDxe/DriverConfiguration.c | 3 +++ IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c | 1 + IntelUndiPkg/GigUndiDxe/DriverHealth.c | 2 ++ IntelUndiPkg/GigUndiDxe/StartStop.c | 2 ++ 7 files changed, 14 insertions(+) -- 2.19.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel Reviewed-by: Ryszard Knop diff --git a/IntelUndiPkg/GigUndiDxe/AdapterInformation.c b/IntelUndiPkg/GigUndiDxe/AdapterInformation.c index 8918c538e447..1cece79911b1 100644 --- a/IntelUndiPkg/GigUndiDxe/AdapterInformation.c +++ b/IntelUndiPkg/GigUndiDxe/AdapterInformation.c @@ -123,6 +123,7 @@ GetIpv6SupportInformationBlock ( **/ STATIC EFI_STATUS +EFIAPI GetInformation ( IN EFI_ADAPTER_INFORMATION_PROTOCOL *This, IN EFI_GUID * InformationType, @@ -188,6 +189,7 @@ GetInformation ( **/ STATIC EFI_STATUS +EFIAPI SetInformation ( IN EFI_ADAPTER_INFORMATION_PROTOCOL *This, IN EFI_GUID * InformationType, @@ -234,6 +236,7 @@ SetInformation ( **/ STATIC EFI_STATUS +EFIAPI GetSupportedTypes ( IN EFI_ADAPTER_INFORMATION_PROTOCOL *This, OUT EFI_GUID ** InfoTypesBuffer, diff --git a/IntelUndiPkg/GigUndiDxe/ComponentName.c b/IntelUndiPkg/GigUndiDxe/ComponentName.c index 70baf00f4a5d..2bf9bbfbe0e4 100644 --- a/IntelUndiPkg/GigUndiDxe/ComponentName.c +++ b/IntelUndiPkg/GigUndiDxe/ComponentName.c @@ -112,6 +112,7 @@ ComponentNameInitializeControllerName ( language specified by Language. **/ EFI_STATUS +EFIAPI ComponentNameGetDriverName ( IN EFI_COMPONENT_NAME_PROTOCOL *This, IN CHAR8 * Language, @@ -182,6 +183,7 @@ ComponentNameGetDriverName ( language specified by Language. **/ EFI_STATUS +EFIAPI ComponentNameGetControllerName ( IN EFI_COMPONENT_NAME_PROTOCOL * This, IN EFI_HANDLE ControllerHandle, diff --git a/IntelUndiPkg/GigUndiDxe/ComponentName.h b/IntelUndiPkg/GigUndiDxe/ComponentName.h index 5a3d414c6970..0b93a5410fc0 100644 --- a/IntelUndiPkg/GigUndiDxe/ComponentName.h +++ b/IntelUndiPkg/GigUndiDxe/ComponentName.h @@ -65,6 +65,7 @@ ComponentNameInitializeControllerName ( language specified by Language. **/ EFI_STATUS +EFIAPI ComponentNameGetDriverName ( IN EFI_COMPONENT_NAME_PROTOCOL *This, IN CHAR8 * Language, diff --git a/IntelUndiPkg/GigUndiDxe/DriverConfiguration.c b/IntelUndiPkg/GigUndiDxe/DriverConfiguration.c index 20d40ab672ef..99e086d81044 100644 --- a/IntelUndiPkg/GigUndiDxe/DriverConfiguration.c +++ b/IntelUndiPkg/GigUndiDxe/DriverConfiguration.c @@ -310,6 +310,7 @@ GigUndiDriverConfigurationDisplayMenu ( @retval EFI_SUCCESS Configuration was successful **/ EFI_STATUS +EFIAPI GigUndiDriverConfigurationSetOptions ( IN EFI_DRIVER_CONFIGURATION_PROTOCOL * This, IN EFI_HANDLE ControllerHandle, @@ -418,6 +419,7 @@ GigUndiDriverConfigurationSetOptions ( @retval EFI_SUCCESS Always returned **/ EFI_STATUS +EFIAPI GigUndiDriverConfigurationOptionsValid ( IN EFI_DRIVER_CONFIGURATION_PROTOCOL * This, IN EFI_HANDLE ControllerHandle, @@ -442,6 +444,7 @@ GigUndiDriverConfigurationOptionsValid ( @retval EFI_SUCCESS Configuration was successful **/ EFI_STATUS +EFIAPI GigUndiDriverConfigurationForceDefaults ( IN EFI_DRIVER_CONFIGURATION_PROTOCOL * This, IN EFI_HANDLE ControllerHandle, diff --git a/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c b/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c index aceb015e480f..f6152cd24c59 100644 --- a/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c +++ b/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c @@ -1394,6 +1394,7 @@ Error: ChildHandle did not pass the diagnostic. **/ EFI_STATUS +EFIAPI GigUndiDriverDiagnosticsRunDiagnostics ( IN EFI_DRIVER_DIAGNOSTICS_PROTOCOL * This, IN EFI_HANDLE ControllerHandle, diff --git a/IntelUndiPkg/GigUndiDxe/DriverHealth.c b/IntelUndiPkg/GigUndiDxe/DriverHealth.c index b5b7db5fd814..ea306843679a 100644 --- a/IntelUndiPkg/GigUndiDxe/DriverHealth.c +++ b/IntelUndiPkg/GigUndiDxe/DriverHealth.c @@ -44,6 +44,7 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. @retval !EFI_SUCCESS Failure to retrieve health status **/ EFI_STATUS +EFIAPI GetHealthStatus ( IN EFI_DRIVER_HEALTH_PROTOCOL * This, IN EFI_HANDLE ControllerHandle, OPTIONAL @@ -119,6 +120,7 @@ GetHealthStatus ( @retval EFI_UNSUPPORTED This function is unsupported **/ EFI_STATUS +EFIAPI Repair ( IN EFI_DRIVER_HEALTH_PROTOCOL *This, IN EFI_HANDLE ControllerHandle, diff --git a/IntelUndiPkg/GigUndiDxe/StartStop.c b/IntelUndiPkg/GigUndiDxe/StartStop.c index 32bed7ce288d..a788da247e6d 100644 --- a/IntelUndiPkg/GigUndiDxe/StartStop.c +++ b/IntelUndiPkg/GigUndiDxe/StartStop.c @@ -38,6 +38,7 @@ EFI_GUID gEfiStartStopProtocolGuid = EFI_DRIVER_STOP_PROTOCOL_GUID; @retval EFI_SUCCESS Driver is stopped successfully **/ EFI_STATUS +EFIAPI StopDriver ( IN EFI_DRIVER_STOP_PROTOCOL *This ) @@ -62,6 +63,7 @@ StopDriver ( @retval EFI_SUCCESS If driver has restarted successfully **/ EFI_STATUS +EFIAPI StartDriver ( IN EFI_DRIVER_STOP_PROTOCOL *This ) From patchwork Tue Nov 6 17:58:33 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Ard Biesheuvel X-Patchwork-Id: 150321 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp4193080ljp; Tue, 6 Nov 2018 10:00:06 -0800 (PST) X-Google-Smtp-Source: AJdET5cP9zq2ZB9XrqLV8Kh/KcVvsxqUoks0R1jqXss60rAauJSHH16n/i0GetU4TKFGIT9YnAjo X-Received: by 2002:a63:2bc9:: with SMTP id r192mr25088939pgr.172.1541527206801; Tue, 06 Nov 2018 10:00:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1541527206; cv=none; d=google.com; s=arc-20160816; b=Rrj/FuDMAJ39ROxnmeHHFXjVrEfpul1RDCLrKdoDDpi9ZPyYMj6zOdsqhfz6dKZYXq phwoidaMUW/TpGpixE8bmD90/3x4S6J+bHSeOxQuG5oe8dZIdKU0fvlB9fveQ6ccTfet f/KpIWn98mrCCzQlKpholhhNJsyD9FtTWB8ttYS9uexQ24HNe3pqG85m7S9vqPYk5q79 S10jC4F2S3z/0blqibRsgGD34PKryzkcKCYpJ46OAU/fVX8qOt8MW1iJ/6jc1divUZzT jEfMzg4YSbih1TcbzG5O/PC3naIqR01bmYirEbGJLbk1SQpGxQj4uzgrkpE7SnGDbLV9 lwSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:references:in-reply-to:message-id :date:to:from:dkim-signature:delivered-to; bh=XD47XTtGiC0Yx5gxEUQZqpCCpSTWwdPJeKJZZiqc8OE=; b=fUjvtwO9MntKkDZ4NYlrfXy5Q5O5U1Qa56I4d4xs73zNknpwjFZLN97oWqYPOLjv3C e4Nya6VkUAOg3+6lCF2ScRYsIGgOW/KeQHLa7FI43e+zpnBStPNZA8Xd/4JLmLyyOaEO 8IqHg0y1nkbJp5sD1kIuWorgRhjYTGKmhvcFqBBvcjtifOTbwVMyuPaIkeqDpy41p9Ly 2QgOdP4GgEz927umAFJnP1JvBqT8YB5L+EBsFMujHe9G4qi0C4wdY2Yb76SDF9znzGjf UjY3z6FtrcesET8btLgKh7Qm2eL1BipslQjjfOFlTBNTTu7UxtU+ATQ2IsiruJE2gBI6 ualg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=PK0MvVFv; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from ml01.01.org (ml01.01.org. [2001:19d0:306:5::1]) by mx.google.com with ESMTPS id az12-v6si2452283plb.166.2018.11.06.10.00.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Nov 2018 10:00:06 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) client-ip=2001:19d0:306:5::1; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=PK0MvVFv; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id E9DFB2118D924; Tue, 6 Nov 2018 09:59:17 -0800 (PST) X-Original-To: edk2-devel@lists.01.org Delivered-To: edk2-devel@lists.01.org Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::42a; helo=mail-wr1-x42a.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0B08F2118D923 for ; Tue, 6 Nov 2018 09:59:16 -0800 (PST) Received: by mail-wr1-x42a.google.com with SMTP id z13-v6so12188568wrs.3 for ; Tue, 06 Nov 2018 09:59:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=aEOcVCBKAYXiJbHb6DkbbjDsarByTZ6OFYsEVeldKak=; b=PK0MvVFv7gVhJMPPrLIrahg6a/P/aiXi4xSHfgRS3+qFnqGft7oGvcY4576/9yHV/8 aaNYmtwa5mDqvLNHCMNt6hx3GrT1heV3+wQjWI6uvBq98MfSYc0/4cRWbNXu8MGxkeCy qGUU6pTsqRxDolfNvf8/xFjPP26wQ7AbRb644= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=aEOcVCBKAYXiJbHb6DkbbjDsarByTZ6OFYsEVeldKak=; b=mcOO/HWkjHrJ6NoHzuoNQN+r21jGW6KI9VI9EqtzDaviZdmEC9pgAUh81lW1Ve3fpm DsOd84eLU3IK97922eLG8KUMRN+GkQThlYZwDHQgda+CT13rc5YlE0ihYKTUr6Zg5jA8 gEDhncXrulwIkx+sIfq70dtweS6iQd6eI7QXIh5nE+iH7PQPR400Lr9vH6M/GNP8l3/t df/w1C5txbtvp0BiA8h918wtu2ymKebJxrrtbpWK1XVCl8n28DX+1BTr80etfb6bhXAZ sZtE1qnUPznEXt45vL50w4QBtSf06M0YVoMBLPwa+hBWrPo/fvMCMC0UrLXqSCsASg9e iDIg== X-Gm-Message-State: AGRZ1gKg3h17spvERRCSgKzAHct3yO2g6X1unF9mDZYFDIR4Wa6sehZp XHfi1salaEvf6Mc9rPzQeQWVSUGW6U0= X-Received: by 2002:adf:94e2:: with SMTP id 89-v6mr23951548wrr.25.1541527154095; Tue, 06 Nov 2018 09:59:14 -0800 (PST) Received: from localhost.localdomain (laubervilliers-657-1-83-120.w92-154.abo.wanadoo.fr. [92.154.90.120]) by smtp.gmail.com with ESMTPSA id 134-v6sm2971522wmp.6.2018.11.06.09.59.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Nov 2018 09:59:13 -0800 (PST) From: Ard Biesheuvel To: edk2-devel@lists.01.org Date: Tue, 6 Nov 2018 18:58:33 +0100 Message-Id: <20181106175833.26964-20-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181106175833.26964-1-ard.biesheuvel@linaro.org> References: <20181106175833.26964-1-ard.biesheuvel@linaro.org> MIME-Version: 1.0 Subject: [edk2] [PATCH edk2-staging 19/19] IntelUndiPkg/GigUndiDxe: remove or reorganize unused variables X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: michael.d.kinney@intel.com, eric.jin@intel.com Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" Drop variables that are assigned but never used, or move them into a conditional preprocessor block if the only references occur from such code. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c | 2 -- IntelUndiPkg/GigUndiDxe/HiiInternalLib.c | 2 -- IntelUndiPkg/GigUndiDxe/e1000.c | 16 +++++++--------- 3 files changed, 7 insertions(+), 13 deletions(-) -- 2.19.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Ryszard Knop diff --git a/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c b/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c index f6152cd24c59..af8aaa797e68 100644 --- a/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c +++ b/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c @@ -1123,11 +1123,9 @@ GigUndiRunPhyLoopback ( UINT64 FreeTxBuffer[DEFAULT_TX_DESCRIPTORS]; UINT32 j; UINT32 i; - struct e1000_hw *Hw; Status = EFI_SUCCESS; j = 0; - Hw = &GigAdapterInfo->Hw; while (j < PHY_LOOPBACK_ITERATIONS) { Status = E1000Transmit ( diff --git a/IntelUndiPkg/GigUndiDxe/HiiInternalLib.c b/IntelUndiPkg/GigUndiDxe/HiiInternalLib.c index 2aacb63ca158..690d8314be74 100644 --- a/IntelUndiPkg/GigUndiDxe/HiiInternalLib.c +++ b/IntelUndiPkg/GigUndiDxe/HiiInternalLib.c @@ -197,7 +197,6 @@ GetNextRequestElement ( ) { EFI_STRING StringPtr; - EFI_STRING TmpPtr; EFI_STATUS Status; UINTN Length; UINT8 * TmpBuffer; @@ -227,7 +226,6 @@ GetNextRequestElement ( } // Back up the header of one - TmpPtr = StringPtr; StringPtr += StrLen (L"OFFSET="); diff --git a/IntelUndiPkg/GigUndiDxe/e1000.c b/IntelUndiPkg/GigUndiDxe/e1000.c index 28c900e3ad63..3d4a21c62d77 100644 --- a/IntelUndiPkg/GigUndiDxe/e1000.c +++ b/IntelUndiPkg/GigUndiDxe/e1000.c @@ -412,7 +412,6 @@ E1000Transmit ( E1000_TRANSMIT_DESCRIPTOR *TransmitDescriptor; UINT32 i; INT16 WaitMsec; - EFI_STATUS Status; UNDI_DMA_MAPPING *TxBufMapping; TxBufMapping = &GigAdapter->TxBufferMappings[GigAdapter->CurTxInd]; @@ -483,7 +482,7 @@ E1000Transmit ( TxBufMapping->Size = TxBuffer->DataLen + TxBuffer->MediaheaderLen; // Make the Tx buffer accessible for adapter over DMA - Status = UndiDmaMapMemoryRead ( + UndiDmaMapMemoryRead ( GigAdapter->PciIo, TxBufMapping ); @@ -594,20 +593,21 @@ E1000Receive ( E1000_RECEIVE_DESCRIPTOR *ReceiveDescriptor; ETHER_HEADER * EtherHeader; PXE_STATCODE StatCode; - UINT16 i; UINT16 TempLen; +#if (DBG_LVL & RX) + UINT16 i; UINT8 * PacketPtr; #if (DBG_LVL & CRITICAL) -#if (DBG_LVL & RX) UINT32 Rdh; UINT32 Rdt; -#endif /* (DBG_LVL & RX) */ + #endif /* (DBG_LVL & CRITICAL) */ + i = 0; +#endif /* (DBG_LVL & RX) */ PacketType = PXE_FRAME_TYPE_NONE; StatCode = PXE_STATCODE_NO_DATA; - i = 0; // acknowledge the interrupts E1000_READ_REG (&GigAdapter->Hw, E1000_ICR); @@ -679,9 +679,9 @@ E1000Receive ( TempLen ); +#if (DBG_LVL & RX) PacketPtr = (UINT8 *) (UINTN) CpbReceive->BufferAddr; -#if (DBG_LVL & RX) DEBUGPRINT (RX, ("Packet Data \n")); for (i = 0; i < TempLen; i++) { DEBUGPRINT (RX, ("%x ", PacketPtr[i])); @@ -1569,13 +1569,11 @@ E1000Inititialize ( GIG_DRIVER_DATA *GigAdapter ) { - UINT32 * TempBar; PXE_STATCODE PxeStatcode; DEBUGPRINT (E1000, ("E1000Inititialize\n")); PxeStatcode = PXE_STATCODE_SUCCESS; - TempBar = NULL; ZeroMem ( (VOID *)(UINTN)GigAdapter->RxRing.UnmappedAddress,