From patchwork Fri Dec 3 14:01:24 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dinh Nguyen X-Patchwork-Id: 520333 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA431C433F5 for ; Fri, 3 Dec 2021 14:02:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242940AbhLCOFo (ORCPT ); Fri, 3 Dec 2021 09:05:44 -0500 Received: from ams.source.kernel.org ([145.40.68.75]:43052 "EHLO ams.source.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237277AbhLCOFn (ORCPT ); Fri, 3 Dec 2021 09:05:43 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 01706B82749 for ; Fri, 3 Dec 2021 14:02:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EFF9BC53FC7; Fri, 3 Dec 2021 14:02:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1638540137; bh=9ajHpeS6kr3mi4mButVxzrRJqooaAZz5lVZTMgrfIdE=; h=From:To:Cc:Subject:Date:From; b=oBf7g3sx+du98LupFj9XhTxc8xs2AW4cxskQZ6ZYofOPqDntsJRBxVIX/RlLhbEkY lHTIRivhobiC3o7AjVWm0xcSxOaWWRImNJpvyFehmTnVTfE1IfjuVYjFMTfLRtddxV +CreVabvjyWRJM6w7GKBU19Js9PD2XZzb8hS/DLrCw/9bBUPIicefZA65uQuw9j3UH db6ndjaNqr6aT+myIRfsa0RKZJGetia6C7XG3krF2ivPps94yp2fru02FptTHVNUcm MchCxptsF0DMGajCeoTY5wJITrQklwZvz7dnCc0S1c7DjnUBpWPxFy9b3GLqYBXwaK XOdQ9rzFQnVwg== From: Dinh Nguyen To: devicetree@vger.kernel.org Cc: dinguyen@kernel.org, broonie@kernel.org, robh+dt@kernel.org, p.yadav@ti.com Subject: [PATCHv2 1/3] dt-bindings: spi: cadence-quadspi: document "cdns,qspi-nor-ver-00-10" Date: Fri, 3 Dec 2021 08:01:24 -0600 Message-Id: <20211203140126.3132770-1-dinguyen@kernel.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org The QSPI controller on Intel's SoCFPGA platform does not implement the CQSPI_REG_WR_COMPLETION_CTRL register, thus a write to this register results in a crash. The module/revision ID is written in the MODULE_ID register. For this variance, bits 23-8 is 0x0010. Introduce the dts binding "cdns,qspi-nor-ver-00-10" to differentiate the hardware. Signed-off-by: Dinh Nguyen --- v2: change binding to "cdns,qspi-nor-0010" to be more generic for other platforms --- Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml b/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml index ca155abbda7a..2833e1c8841d 100644 --- a/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml +++ b/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml @@ -29,6 +29,7 @@ properties: - ti,am654-ospi - intel,lgm-qspi - xlnx,versal-ospi-1.0 + - cdns,qspi-nor-ver-00-10 - const: cdns,qspi-nor - const: cdns,qspi-nor From patchwork Fri Dec 3 14:01:26 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dinh Nguyen X-Patchwork-Id: 520332 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3355EC433F5 for ; Fri, 3 Dec 2021 14:02:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244951AbhLCOGN (ORCPT ); Fri, 3 Dec 2021 09:06:13 -0500 Received: from dfw.source.kernel.org ([139.178.84.217]:43658 "EHLO dfw.source.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237277AbhLCOGN (ORCPT ); Fri, 3 Dec 2021 09:06:13 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0610D6297D for ; Fri, 3 Dec 2021 14:02:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1BB95C53FD1; Fri, 3 Dec 2021 14:02:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1638540168; bh=MGGz4LzAd5ENeWdQOOQPgQCNDIKuzr0L5DZ/mTQ2pyY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KSY70bFMLaMuqzaXe6SJNHQpqSsbyifRkl0TvjmdSw2AEe5R7W3MjoD5KEwZwsnrY Xmq9kroOmIacmvaG//KjYvzPe3MRGor8bPECKXwRXVG8V7Jv0szmyRflM2Ydr4iPjT 4hR9ZvaB0tqaXUZoM9+s0LQZFOJjN3jErAwqE1QV1xj5mP8VzIVV3f6hoSv56s/CJj bj0fmHAyLspnnZc+phVmOLveFxhqdBZf6VInGnbrHF7Fx11UkJOZAcBXSGSyrDtzt5 5gdBBqm6Ld0iRPbzR4pQMElYDd9WKXFfm4braNHwvnubxRjpU3SpCN5zoJ8/h/FYEu I4hi6t116ksjg== From: Dinh Nguyen To: devicetree@vger.kernel.org Cc: dinguyen@kernel.org, broonie@kernel.org, robh+dt@kernel.org, p.yadav@ti.com Subject: [PATCH 3/3] spi: cadence-quadspi: change socfpga-qspi to "cdns,qspi-nor-ver-00-10" Date: Fri, 3 Dec 2021 08:01:26 -0600 Message-Id: <20211203140126.3132770-3-dinguyen@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211203140126.3132770-1-dinguyen@kernel.org> References: <20211203140126.3132770-1-dinguyen@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org To make the "intel,socfpga-qspi" more generic, change the binding to "cdns,qspi-nor-ver-00-10". The "0010" represents the Module/Revision ID number that is in the MODULE_ID register. Fixes: f0234e62e4 ("spi: cadence-quadspi: fix write completion support") Signed-off-by: Dinh Nguyen --- drivers/spi/spi-cadence-quadspi.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/spi/spi-cadence-quadspi.c b/drivers/spi/spi-cadence-quadspi.c index b808c94641fa..b1421bcce67f 100644 --- a/drivers/spi/spi-cadence-quadspi.c +++ b/drivers/spi/spi-cadence-quadspi.c @@ -1869,7 +1869,7 @@ static const struct cqspi_driver_platdata intel_lgm_qspi = { .quirks = CQSPI_DISABLE_DAC_MODE, }; -static const struct cqspi_driver_platdata socfpga_qspi = { +static const struct cqspi_driver_platdata cdns_qspi_0010 = { .quirks = CQSPI_NO_SUPPORT_WR_COMPLETION, }; @@ -1902,8 +1902,8 @@ static const struct of_device_id cqspi_dt_ids[] = { .data = (void *)&versal_ospi, }, { - .compatible = "intel,socfpga-qspi", - .data = (void *)&socfpga_qspi, + .compatible = "cdns,qspi-nor-ver-00-10", + .data = (void *)&cdns_qspi_0010, }, { /* end of table */ } };