From patchwork Mon Feb 14 08:36:57 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 542707 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F9A6C433F5 for ; Mon, 14 Feb 2022 08:37:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242075AbiBNIhr (ORCPT ); Mon, 14 Feb 2022 03:37:47 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:34042 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240112AbiBNIhq (ORCPT ); Mon, 14 Feb 2022 03:37:46 -0500 Received: from smtp-relay-internal-0.canonical.com (smtp-relay-internal-0.canonical.com [185.125.188.122]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9709FDF6A for ; Mon, 14 Feb 2022 00:37:38 -0800 (PST) Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 41FFA3F071 for ; Mon, 14 Feb 2022 08:37:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1644827857; bh=UeS9MvqP+4XVHpHzzOg6ayahqyEHPitjbY58dkpAMu0=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=NSjk2lG0p10BZUmenmlcPDzGQ8q5zoAeU6qrz5jfY3klFki7z2tdZJqA5oMyBAcU+ txrN5ghpRoS6QzFdiZGhk5cgmMc4i1hgGHLAoaAfVu11AT52wajDEaMWk+1gHqMHoy LgRFJS0p9QWhvlvR+fN7C+rl0VF2c9l7OzA53QyhnaJpxjaR1cs9jRagA2r4KwEw8b dhY5lYP3y1i/ki/ERc5VPpes9kW8laje3Br/HjVq20nZyVIRGPAWXt76IMUAfCG2yZ c3xCBcfvRTmytWDs7UREgXmWfpHXfDm/q6In9BEEr84KHauJFojpfyr4+TI2pUX7fa 3qHdJG990LpTA== Received: by mail-ed1-f69.google.com with SMTP id l3-20020a50cbc3000000b0041083c11173so4465599edi.4 for ; Mon, 14 Feb 2022 00:37:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=UeS9MvqP+4XVHpHzzOg6ayahqyEHPitjbY58dkpAMu0=; b=B1Tyk1eVF5aWmy95CduYlYrhn4rQQ96HQ2sehqVK6CsBeZAIf1LAham3NQILuvnmT5 6eDWo32We2QE6M0GeJcg8gqMYwg7l5nh+g6sVSR5S0a1NXQyJBR+mxg4345AonDXlYXz DW4zk5Y4nZg7C37PqhByxU5glYfQCHaGBUscvI0ET/IUCoffErxcptb6TmslLSORMMSL f/+1any5T1IB6Urq3xzUFtjJTZBsBmoWb1b/uDCxMXMEFdMhwUTE951KYFMdwUN51ume xdkV/gYBpGHBTMgRRGKpMoQi5TxRwjrd/sCMAHzS3dnn6VXC7pYCZsrBwk3/TPc995Xa /VtQ== X-Gm-Message-State: AOAM530jwEV5q7pf7t4JAJF51TagUtG5LU/SgR7MKhOjNi5Tm/58VoZw UNXF4rR+AtTiIbwQbihAXs6yFybLBx4DlWNJg9W6IAuWhxaaPJCYjYm+AxP6sVU9DcPs2x86p57 Whh1r+sWMLydKWYpoWirQqV9FeFB234LSqFo42PbL4aGV X-Received: by 2002:a05:6402:4313:: with SMTP id m19mr14313665edc.320.1644827857013; Mon, 14 Feb 2022 00:37:37 -0800 (PST) X-Google-Smtp-Source: ABdhPJx9hR1XFJB05UFJug9MAC7FCA5IP+wUp4mjQ048N34QgP+jdO/yTjWnA6oWYkRX7X+tyG4Qzg== X-Received: by 2002:a05:6402:4313:: with SMTP id m19mr14313649edc.320.1644827856877; Mon, 14 Feb 2022 00:37:36 -0800 (PST) Received: from localhost.localdomain (xdsl-188-155-168-84.adslplus.ch. [188.155.168.84]) by smtp.gmail.com with ESMTPSA id er9sm10310087edb.77.2022.02.14.00.37.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Feb 2022 00:37:36 -0800 (PST) From: Krzysztof Kozlowski To: Steven Rostedt , Ingo Molnar , Shuah Khan , Krzysztof Kozlowski , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org, joseph.salisbury@canonical.com Cc: Sebastian Andrzej Siewior , Shuah Khan Subject: [PATCH v3] selftests/ftrace: Do not trace do_softirq because of PREEMPT_RT Date: Mon, 14 Feb 2022 09:36:57 +0100 Message-Id: <20220214083657.165921-1-krzysztof.kozlowski@canonical.com> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-rt-users@vger.kernel.org The PREEMPT_RT patchset does not use do_softirq() function thus trying to filter for do_softirq fails for such kernel: echo do_softirq ftracetest: 81: echo: echo: I/O error Choose some other visible function for the test. The function does not have to be actually executed during the test, because it is only testing filter API interface. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Shuah Khan Reviewed-by: Steven Rostedt (VMware) --- Changes since v2: 1. Rephrase commit msg, after comments from Sebastian. 2. Add review tag. Changes since v1: 1. Use scheduler_tick. 2. Add review tag. Notes: I understand that the failure does not exist on mainline kernel (only with PREEMPT_RT patchset) but the change does not harm it. If it is not suitable alone, please consider it for RT patchset. --- .../selftests/ftrace/test.d/ftrace/func_set_ftrace_file.tc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/ftrace/test.d/ftrace/func_set_ftrace_file.tc b/tools/testing/selftests/ftrace/test.d/ftrace/func_set_ftrace_file.tc index e96e279e0533..25432b8cd5bd 100644 --- a/tools/testing/selftests/ftrace/test.d/ftrace/func_set_ftrace_file.tc +++ b/tools/testing/selftests/ftrace/test.d/ftrace/func_set_ftrace_file.tc @@ -19,7 +19,7 @@ fail() { # mesg FILTER=set_ftrace_filter FUNC1="schedule" -FUNC2="do_softirq" +FUNC2="scheduler_tick" ALL_FUNCS="#### all functions enabled ####"