From patchwork Mon Dec 3 20:35:14 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ross Burton X-Patchwork-Id: 152734 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp7264912ljp; Mon, 3 Dec 2018 12:35:25 -0800 (PST) X-Google-Smtp-Source: AFSGD/WJwoJjmyvXei4FtlER7B/mXtRhn1ugIxzV8HXtTNFIgQe6esmR+8fqphyDBf62pN4rpYyw X-Received: by 2002:a17:902:a710:: with SMTP id w16mr17004197plq.95.1543869325815; Mon, 03 Dec 2018 12:35:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543869325; cv=none; d=google.com; s=arc-20160816; b=xcbm1qLhV5w9zrgX3jfzT6uoiz6Zy5/Lhub9dD9Xjw/LulaEZgiEHKcRVS6i+w3vsv QmwlKR1RReq8UJzmRglOXur9DXJNxo6YexmgR3gnJOYCvzgq52xiIv26io09bdqcIfgU mVoWG9QQtNjjx9BkZxxl/pLZPxE1QZ+9nVbsTfMr6paLW5f5+z3Y74MADVpttuX5Htk+ UPdWlSMdDximbl/4kYlR6KOx9YCj3DZ5xb3gSL2T7fIwImEVQbQJ7L6UJHBG4LyStmYJ MsO6LrbFInIjjEmLTUpkWK7mWrSw6vus21AXNSb14CbekI7i7opP8cDTSl6Wl7UYcGHp 11Rg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:sender:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:message-id:date:to:from:dkim-signature :delivered-to; bh=KFXEUw+heTCinwfEo1tjxcBM3242IxeHG4h6kclE+HU=; b=MHNGQu3sHc4Ct6/0UfhaY1bCFPBQdjHoAEq8PjSRHmwBr4+P3oBfXOKH7NGpHaMLlm OHtm20WJEPvQOW3d/48ku4hfZUyFuhys88lW16AWaAybLbUBftE+MMpDEjWoKdf0cH3Z t69QbwaeX03aqAa5Z7hn1S5Zckk7ECLrnmnYa9jGM2cwQocQDPZjmudRt3aDuyZCLGI9 lX2RhykP3cTtlwSIuh+If5zyGwkRL/8xxjg1IK9hTDCkUtU6Dz1r6oYUkv5nI1N8MPL5 fm6CTD1nXOSKrtiSljUwjdtIKY8kl+8svDA1pr173x3416BFgli0PZoGAa7pll3qOrgU MyDw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@intel-com.20150623.gappssmtp.com header.s=20150623 header.b=DlmrKc+q; spf=pass (google.com: best guess record for domain of openembedded-core-bounces@lists.openembedded.org designates 140.211.169.62 as permitted sender) smtp.mailfrom=openembedded-core-bounces@lists.openembedded.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from mail.openembedded.org (mail.openembedded.org. [140.211.169.62]) by mx.google.com with ESMTP id 34si8266835pgt.455.2018.12.03.12.35.24; Mon, 03 Dec 2018 12:35:25 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of openembedded-core-bounces@lists.openembedded.org designates 140.211.169.62 as permitted sender) client-ip=140.211.169.62; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@intel-com.20150623.gappssmtp.com header.s=20150623 header.b=DlmrKc+q; spf=pass (google.com: best guess record for domain of openembedded-core-bounces@lists.openembedded.org designates 140.211.169.62 as permitted sender) smtp.mailfrom=openembedded-core-bounces@lists.openembedded.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from 165.28.230.35.bc.googleusercontent.com (localhost [127.0.0.1]) by mail.openembedded.org (Postfix) with ESMTP id 2A7CD6C590; Mon, 3 Dec 2018 20:35:21 +0000 (UTC) X-Original-To: openembedded-core@lists.openembedded.org Delivered-To: openembedded-core@lists.openembedded.org Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by mail.openembedded.org (Postfix) with ESMTP id DE7876C543 for ; Mon, 3 Dec 2018 20:35:19 +0000 (UTC) Received: by mail-wm1-f66.google.com with SMTP id y1so7276112wmi.3 for ; Mon, 03 Dec 2018 12:35:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=from:to:subject:date:message-id; bh=MckTPQe0gDBiTt+2lEsjgxc5g/sSQfHSeW52NJWUSM4=; b=DlmrKc+qRcZXS1KxKWTmagc54XAIwD6x91x4QEIxORDOFUOJGIFl+/4BzdqoTp9uoO SgRSVjqBFuj8FDW2Fz+uAxnIUlnhOUevEuhM47khhWg6kmrZXZFlIaq8Iyay8ipyN+s+ ptH9mEBSPlFkfReMVwitjwYgijAvysZt/D+KMJ98n3UCF4IMfgJtlwoNlGtRIoYb/0H3 Q4TUBUwoD9dSO2JaqVjgbkmZ8ITNkLWk1m2eiquoH8g5VFDme0HZgqjguZoqcWT+oSkW d3gW+m53YUhnHTTcMzJs7Lsk47Ok2cusMA3UePW9f2/QuK9P5q/DARkkKyc+hNLc2f2v 7KXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id; bh=MckTPQe0gDBiTt+2lEsjgxc5g/sSQfHSeW52NJWUSM4=; b=kr6aLUMqV+ibJkprw/atEJP5ubIBKrOsMC2C6mQMjVXR72UPV4Pw3QbexgQXeIshVf yBSvrD2ALyx4RIWlBd4ZCbq+3OmKA8HTzhX3oQ6ZRNfmSQSsBnoRFpNVXozwD/LPBm66 9eR9c72ghfkMbZ73f6Wkqvs3aphSFTlhbO7MeNeEX1BHoYW/V2JlerXTMjhveMNz6GFZ DUFJ7b2n427Vs4o1gQ/JeesqqsKoCI6ZVu4QviT95OtVqj32L+7XMlrSnt9+tWfh3BMm aA5SFSPfDwPl0bLwyLO0pJxVHZZeK+9EO/AYwB70rFv3sfTzTg9Ck0vDX5VCXnjpjHc6 LBuA== X-Gm-Message-State: AA+aEWbda6+nObt+4uR/X7xrsbtKlIqfhYjlVdkRzeOIYknGU9PnXjHz +UfkFCOjqWinmGRT/8/2+FjIZXuoUC8= X-Received: by 2002:a1c:c543:: with SMTP id v64mr9219711wmf.123.1543869320165; Mon, 03 Dec 2018 12:35:20 -0800 (PST) Received: from flashheart.burtonini.com (35.106.2.81.in-addr.arpa. [81.2.106.35]) by smtp.gmail.com with ESMTPSA id q2sm15361570wru.56.2018.12.03.12.35.19 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 03 Dec 2018 12:35:19 -0800 (PST) From: Ross Burton To: openembedded-core@lists.openembedded.org Date: Mon, 3 Dec 2018 20:35:14 +0000 Message-Id: <20181203203516.26461-1-ross.burton@intel.com> X-Mailer: git-send-email 2.11.0 Subject: [OE-core] [PATCH 1/3] oeqa: don't litter /tmp with temporary directories X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: openembedded-core-bounces@lists.openembedded.org Errors-To: openembedded-core-bounces@lists.openembedded.org If we need to create a temporary directory in targetbuild or buildproject use tempfile.TemporaryDirectory so that when the test case is finished, the directory is deleted. Also synchronise the logic and don't possibly store the temporary directory in self.tmpdir as nothing uses that. Signed-off-by: Ross Burton --- meta/lib/oeqa/utils/buildproject.py | 5 ++++- meta/lib/oeqa/utils/targetbuild.py | 5 +++-- 2 files changed, 7 insertions(+), 3 deletions(-) -- 2.11.0 -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core diff --git a/meta/lib/oeqa/utils/buildproject.py b/meta/lib/oeqa/utils/buildproject.py index 7e9b84955f5..524015ede4b 100644 --- a/meta/lib/oeqa/utils/buildproject.py +++ b/meta/lib/oeqa/utils/buildproject.py @@ -17,7 +17,10 @@ class BuildProject(metaclass=ABCMeta): self.uri = uri self.archive = os.path.basename(uri) if not tmpdir: - tmpdir = tempfile.mkdtemp(prefix='buildproject') + tmpdir = self.d.getVar('WORKDIR') + if not tmpdir: + self.tempdirobj = tempfile.TemporaryDirectory(prefix='buildproject-') + tmpdir = self.tempdirobj.name self.localarchive = os.path.join(tmpdir, self.archive) self.dl_dir = dl_dir if foldername: diff --git a/meta/lib/oeqa/utils/targetbuild.py b/meta/lib/oeqa/utils/targetbuild.py index 1202d579fb0..b8db7b2aca0 100644 --- a/meta/lib/oeqa/utils/targetbuild.py +++ b/meta/lib/oeqa/utils/targetbuild.py @@ -20,8 +20,9 @@ class BuildProject(metaclass=ABCMeta): if not tmpdir: tmpdir = self.d.getVar('WORKDIR') if not tmpdir: - tmpdir = tempfile.mkdtemp(prefix='buildproject') - self.localarchive = os.path.join(tmpdir,self.archive) + self.tempdirobj = tempfile.TemporaryDirectory(prefix='buildproject-') + tmpdir = self.tempdirobj.name + self.localarchive = os.path.join(tmpdir, self.archive) if foldername: self.fname = foldername else: From patchwork Mon Dec 3 20:35:15 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ross Burton X-Patchwork-Id: 152735 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp7265073ljp; Mon, 3 Dec 2018 12:35:33 -0800 (PST) X-Google-Smtp-Source: AFSGD/UUPHwW9uMoQmHd/+pnOqOWfmRfGgkpj34S8u/IOVa6lBH7AR6rsQqHkGXprj3/lXfhHssX X-Received: by 2002:a62:4e83:: with SMTP id c125mr17495092pfb.101.1543869333829; Mon, 03 Dec 2018 12:35:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543869333; cv=none; d=google.com; s=arc-20160816; b=PFhe8B/D47AikqBQO0DEtN02t6wML7JKC3vkBwFgfqAutTAbt2NkPFxByp5UjM5vdK Pp4RbQPpxC/d6lskXxJv7D7lRFLKNPQR2cnrnxgdyOVGjevqzHd2VAS+guDYxzf0ss/B hW5/q4N7PPVngWVelv0QwlyuDppgAg1QEeX7txSN5qwlvwXbKnSRi/16SJXKtvkwGak+ l4DCjHFVvLtEQh4c7yN+VdagNjV1NQZ//d/lMJGvvrf0mdm7LX+aPlxVQ/18sGzFrPSR lZ4IT3IpeWnQ38y0cp8O+lxCqnbSzdAbO8BoJid3XVDEzWR8bGsbHLPeOo2O7qJQRuWm 7J/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:sender:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:references:in-reply-to:message-id:date :to:from:dkim-signature:delivered-to; bh=cmJx+oui/+9qzz9EPu+e8Pe7jpKyIL6Euoc70Ur+KlY=; b=M6NmpBLNA32Yu1BZa0sxXAS5Va+/huP4+Cx2Ho/GjUAGq7JMJ8RfKROy52OAS72CWw EZzwMoiJ3sa/otVO3Sa6uk4RkhYvHFpKxEeiLBzJW8EaEeQcFwaCNjpxuvKWXHVDMT90 asu/S3vCQtelLGZmK2WuH8AZxIkriZQjvvmgLSbgTXhL2F0QCY0Cn6/JenW2cgK2SJpt NMGNWEK0pnNcqDSQ5VGOVtcfoCcTj+6c4s7uWFgQn1kwR93HE0WrmY4lVERkFDliHdAM K0JHyzptuadSsVov3yYEwQYXBQyvCBN89tLgkRqn7qfe7TAklppXVKNvmUBM8cA0nWuh r6Yw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@intel-com.20150623.gappssmtp.com header.s=20150623 header.b=z1VJRRVc; spf=pass (google.com: best guess record for domain of openembedded-core-bounces@lists.openembedded.org designates 140.211.169.62 as permitted sender) smtp.mailfrom=openembedded-core-bounces@lists.openembedded.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from mail.openembedded.org (mail.openembedded.org. [140.211.169.62]) by mx.google.com with ESMTP id 61si15626418plz.117.2018.12.03.12.35.33; Mon, 03 Dec 2018 12:35:33 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of openembedded-core-bounces@lists.openembedded.org designates 140.211.169.62 as permitted sender) client-ip=140.211.169.62; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@intel-com.20150623.gappssmtp.com header.s=20150623 header.b=z1VJRRVc; spf=pass (google.com: best guess record for domain of openembedded-core-bounces@lists.openembedded.org designates 140.211.169.62 as permitted sender) smtp.mailfrom=openembedded-core-bounces@lists.openembedded.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from 165.28.230.35.bc.googleusercontent.com (localhost [127.0.0.1]) by mail.openembedded.org (Postfix) with ESMTP id BBEB06C5CC; Mon, 3 Dec 2018 20:35:30 +0000 (UTC) X-Original-To: openembedded-core@lists.openembedded.org Delivered-To: openembedded-core@lists.openembedded.org Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by mail.openembedded.org (Postfix) with ESMTP id ACFB56C543 for ; Mon, 3 Dec 2018 20:35:20 +0000 (UTC) Received: by mail-wm1-f67.google.com with SMTP id y139so7278124wmc.5 for ; Mon, 03 Dec 2018 12:35:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=from:to:subject:date:message-id:in-reply-to:references; bh=7uDvxSV36YkH4+WLU5sGeUx2rJAqW9e+YGSZ/dxmZJ4=; b=z1VJRRVcXp0wTKN4r7cEE4YkhHd9PxH8HBcP7YoD6Yun1XzXw6EtD10w93esnupKjK 6qoRiw07Qh3MkhV3qFIftzmwQ0iFs6yak1kVEAsUi6nmO8lHoPwn4Jk5Gk/LlGWgT53F AfZSQQd6RAz+t3FYi9VKtonR9RbjGrfdEHJ6NBjpfAmQ/vgQjxR+S2y10Jcid3emenMr wI+PZR1juOBIGapixPUY/YQ3ikxsZaA8CXbk3vtBO1O+EZwbegqbWBoIRMATtKW566Bj cQh+DEh8/xeR2XHw9tPihLTfVhFa/uqauiWNFFdZ3/0gAc02qX8eTSrOzAwKy7BDatPG tY1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=7uDvxSV36YkH4+WLU5sGeUx2rJAqW9e+YGSZ/dxmZJ4=; b=VE09KQ+ukm9d9bCumj6kGvxjeNlRxr0XZT6nZR9TIfwRY9nTQtu5uKrFnTwvEQHfv1 pakckD8S1RCrGXKbkUboAijKKZ4p3oma3uVBDDdpMpiqly4UUDlAw+x52qY+M+DrnSfr 4EYnXh9VF/tYdPvV9i8h4SJiiJSNR0MoGSobGuLLzhEiBKo/nrYER6yEAYXh/EG2T8/3 OSoYltFd1qCjpAESIUEG38RUP+1qcm97CKh879aXJF+1UzeGme5oBxPJi5wpmFNDX5YC 0QUK+StcOFM5FkWjmzFzkgryty1p931gwBF0f3CUH5FMVF4adFtSSezwGA3rMjfLPVQb IOFQ== X-Gm-Message-State: AA+aEWYkwame9WHjoMezu1X0yVFZ+uVGK/UUp7vsFzfOVTgpFuC1Cwd5 OsqBFKnIJ7+U29XUHEak3YpWQvRJoXE= X-Received: by 2002:a1c:1348:: with SMTP id 69mr10253049wmt.71.1543869321136; Mon, 03 Dec 2018 12:35:21 -0800 (PST) Received: from flashheart.burtonini.com (35.106.2.81.in-addr.arpa. [81.2.106.35]) by smtp.gmail.com with ESMTPSA id q2sm15361570wru.56.2018.12.03.12.35.20 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 03 Dec 2018 12:35:20 -0800 (PST) From: Ross Burton To: openembedded-core@lists.openembedded.org Date: Mon, 3 Dec 2018 20:35:15 +0000 Message-Id: <20181203203516.26461-2-ross.burton@intel.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20181203203516.26461-1-ross.burton@intel.com> References: <20181203203516.26461-1-ross.burton@intel.com> Subject: [OE-core] [PATCH 2/3] oeqa/selftest/esdk: run selftest inside workdir not /tmp X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: openembedded-core-bounces@lists.openembedded.org Errors-To: openembedded-core-bounces@lists.openembedded.org Signed-off-by: Ross Burton --- meta/lib/oeqa/selftest/cases/eSDK.py | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) -- 2.11.0 -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core diff --git a/meta/lib/oeqa/selftest/cases/eSDK.py b/meta/lib/oeqa/selftest/cases/eSDK.py index d03188f2f75..14f75d8c09a 100644 --- a/meta/lib/oeqa/selftest/cases/eSDK.py +++ b/meta/lib/oeqa/selftest/cases/eSDK.py @@ -70,11 +70,12 @@ CORE_IMAGE_EXTRA_INSTALL = "perl" @classmethod def setUpClass(cls): super(oeSDKExtSelfTest, cls).setUpClass() - cls.tmpdir_eSDKQA = tempfile.mkdtemp(prefix='eSDKQA') + cls.image = 'core-image-minimal' - sstate_dir = get_bb_var('SSTATE_DIR') + bb_vars = get_bb_vars(['SSTATE_DIR', 'WORKDIR'], cls.image) + cls.tmpdirobj = tempfile.TemporaryDirectory(prefix="selftest-esdk-", dir=bb_vars["WORKDIR"]) + cls.tmpdir_eSDKQA = cls.tempdirobj.name - cls.image = 'core-image-minimal' oeSDKExtSelfTest.generate_eSDK(cls.image) # Install eSDK @@ -87,14 +88,14 @@ CORE_IMAGE_EXTRA_INSTALL = "perl" sstate_config=""" SDK_LOCAL_CONF_WHITELIST = "SSTATE_MIRRORS" SSTATE_MIRRORS = "file://.* file://%s/PATH" - """ % sstate_dir + """ % bb_vars["SSTATE_DIR"] with open(os.path.join(cls.tmpdir_eSDKQA, 'conf', 'local.conf'), 'a+') as f: f.write(sstate_config) @classmethod def tearDownClass(cls): - shutil.rmtree(cls.tmpdir_eSDKQA, ignore_errors=True) - super(oeSDKExtSelfTest, cls).tearDownClass() + cls.tmpdirobj.cleanup() + super().tearDownClass() @OETestID(1602) def test_install_libraries_headers(self): From patchwork Mon Dec 3 20:35:16 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ross Burton X-Patchwork-Id: 152736 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp7265146ljp; Mon, 3 Dec 2018 12:35:38 -0800 (PST) X-Google-Smtp-Source: AFSGD/UrLjwWN1LIQ9NG0Kf6NHgp2ts2STPbrkY/kiW73GFBaZ90RlS0IYmFmgLg+Q7Ptigazsdz X-Received: by 2002:a63:c00b:: with SMTP id h11mr14754706pgg.429.1543869338813; Mon, 03 Dec 2018 12:35:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543869338; cv=none; d=google.com; s=arc-20160816; b=w640F14TB1RZdrOqcmduJkGcb3fwyzaaKUq8vk6ZGyW8CMiR5+5bFqsNjFPC4DqlsD V05UBNRBEuECOxiS9d89O+co3CGZ5aASPrPbILj+MwoRtXNRznvKbz4TY/LV8fO19n46 UWv7Fk1coVhtxPKYUdPQsaOBBl9CXjaFn/7ccv+3P3idGpxoRfJhB3mbbz5mJYfck+y3 Or6UYv0dQr7OS7YbMxT4+ppR/j868WK3RcH0KQoLZrxfVS6u/C5fYC+MsMqitROsz/iP NrobJMbmlvPcdlScWnT4B58j1HhsCzc8pd/D+ZFBw4EKn0VkLkAYQbgkg0BoxDBGsyPh gw0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:sender:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:references:in-reply-to:message-id:date :to:from:dkim-signature:delivered-to; bh=BlkVzpL55N2ZksvgpCV+JLWpp24/p6SMhLT38yq3+hs=; b=gck+ED0bCrpeZlyrPiZxWyJP8Zo6EHNd+U5Et3bR3pbEK3sbQeMe9+7pryFZ6qiPKz PWGmQ7P7t+a3A0gPsuqDy9zCVJdS3z2DHOHDnkqXuB/Wa52w0emnn+9ND8jX8w/yrzwp 0K3yjXBAKGox3FAFq15x/cIzzFvEV8hhil7YKIJLinwl/d2MLyxskL7TfdsisvfBPd1N lyqJEZlNOV8cF/zkyUbKuy2GCspibgLiCo9onHIhwQk+x4ug/TX8li+SYDzqYOHi9NNf tf8J0509stXHrzqKzVZZyIq+yaeHMTtVHAEPplXSfxlSLRuQ5hp2o4xiRl3dpBFQjX6+ ZfAw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@intel-com.20150623.gappssmtp.com header.s=20150623 header.b=gweT0fFt; spf=pass (google.com: best guess record for domain of openembedded-core-bounces@lists.openembedded.org designates 140.211.169.62 as permitted sender) smtp.mailfrom=openembedded-core-bounces@lists.openembedded.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from mail.openembedded.org (mail.openembedded.org. [140.211.169.62]) by mx.google.com with ESMTP id d23si13008683pgj.558.2018.12.03.12.35.38; Mon, 03 Dec 2018 12:35:38 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of openembedded-core-bounces@lists.openembedded.org designates 140.211.169.62 as permitted sender) client-ip=140.211.169.62; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@intel-com.20150623.gappssmtp.com header.s=20150623 header.b=gweT0fFt; spf=pass (google.com: best guess record for domain of openembedded-core-bounces@lists.openembedded.org designates 140.211.169.62 as permitted sender) smtp.mailfrom=openembedded-core-bounces@lists.openembedded.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from 165.28.230.35.bc.googleusercontent.com (localhost [127.0.0.1]) by mail.openembedded.org (Postfix) with ESMTP id 399906C5DA; Mon, 3 Dec 2018 20:35:32 +0000 (UTC) X-Original-To: openembedded-core@lists.openembedded.org Delivered-To: openembedded-core@lists.openembedded.org Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by mail.openembedded.org (Postfix) with ESMTP id 9EFE36C57C for ; Mon, 3 Dec 2018 20:35:21 +0000 (UTC) Received: by mail-wm1-f67.google.com with SMTP id n190so4858961wmd.0 for ; Mon, 03 Dec 2018 12:35:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=from:to:subject:date:message-id:in-reply-to:references; bh=Ao+lfe25arfG1xPlnPveryvUUIsHbWgQ1ajr9Q8Egys=; b=gweT0fFt05mpdqm6GkAcQnJ7m+GanarltKduZhT737KxTQCOtDtpDRgIbZO3m2+c3M t8Ree6Ppoh31wJW0LHspTA9rWymOCn4gBm7L61bK/vOJLaUdvMgT4LrGZZOhdL204+ll LSfmCMMZSNfpP4MDVtI8dJNi5lBoLgqLJP3owszU9SqPPCgpyARfyFf1ctvRlGWmw46h VjpXIIRaX03Db++1mZEcjV3D11y3t0oG0l+pTy6G8GxDG2fXKuWR5f6iAQ/NC1K9NJFw ENyr4GTJCkEHabqZGosKflYAmLWSSAgCli9wVCd9RXj0XnOvjIPUVG3fSWdCJIY9SYpB fh3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=Ao+lfe25arfG1xPlnPveryvUUIsHbWgQ1ajr9Q8Egys=; b=qcgJMsfzSxNP+SyoeV4JDim5qZTj/1lkBDnlhcoi2UmqVOxXYMHW6oH4dmgV2+9eYl FhQ1kfO28jjC7bYe5E3/zm73pu5SroZ369nlIpI5jR83GJeoaPHcyz2TnL5dRtJkIYCe uDLX2O9Uos0HvKd9XoYFf+DWvYfPwrX3mvRxdRS7x9a749xbWG0a/Cm1KU2uN3Q/zLJG hS5JTjuFwGTmhpzMxkck8sb7OXqMGv6GE7YNBQxbx19P5y9bodKEPfuL9UE4O/F7LuSM Pk5zAG9tlAPDSRtKe97qzcdP8EiL/nmhL9JtNggkDXx4jtPfpQ1vvkTDSSEQsZR0jCXH UPRQ== X-Gm-Message-State: AA+aEWZUDYpQxHJZF46tw+kFFvz1rAHbMFwEYlQYaZFcRetm8tmGMsoC M6aVcWzRxM2WnSSDaTFU494t1ttyQf8= X-Received: by 2002:a1c:2104:: with SMTP id h4-v6mr9200416wmh.130.1543869322272; Mon, 03 Dec 2018 12:35:22 -0800 (PST) Received: from flashheart.burtonini.com (35.106.2.81.in-addr.arpa. [81.2.106.35]) by smtp.gmail.com with ESMTPSA id q2sm15361570wru.56.2018.12.03.12.35.21 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 03 Dec 2018 12:35:21 -0800 (PST) From: Ross Burton To: openembedded-core@lists.openembedded.org Date: Mon, 3 Dec 2018 20:35:16 +0000 Message-Id: <20181203203516.26461-3-ross.burton@intel.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20181203203516.26461-1-ross.burton@intel.com> References: <20181203203516.26461-1-ross.burton@intel.com> Subject: [OE-core] [PATCH 3/3] insane: clarify GNU_HASH warning X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: openembedded-core-bounces@lists.openembedded.org Errors-To: openembedded-core-bounces@lists.openembedded.org We have a fatal error if ELF objects don't have GNU_HASH segments don't don't explain what the problem is. At least give a hint to users by suggesting that LDFLAGS wasn't passed to the compiler. Signed-off-by: Ross Burton --- meta/classes/insane.bbclass | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.11.0 -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass index 4644221bc6b..6718feb3af5 100644 --- a/meta/classes/insane.bbclass +++ b/meta/classes/insane.bbclass @@ -383,7 +383,7 @@ def package_qa_hash_style(path, name, d, elf, messages): sane = True if has_syms and not sane: - package_qa_add_message(messages, "ldflags", "No GNU_HASH in the elf binary: '%s'" % path) + package_qa_add_message(messages, "ldflags", "No GNU_HASH in the ELF binary %s, didn't pass LDFLAGS?" % path) QAPATHTEST[buildpaths] = "package_qa_check_buildpaths"