From patchwork Sat May 21 20:47:25 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Rix X-Patchwork-Id: 576887 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F8B8C433EF for ; Sat, 21 May 2022 20:47:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345991AbiEUUrg (ORCPT ); Sat, 21 May 2022 16:47:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53990 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345356AbiEUUrf (ORCPT ); Sat, 21 May 2022 16:47:35 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 0C8EE3FBEB for ; Sat, 21 May 2022 13:47:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1653166053; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=Q7KKV9nEc1O8xO71RHJAseDwiXENbXZxnjAzbqBmERg=; b=HRVf4zVvWcIOoiM32MjsSxlronjRM6snQIzPw0mrLLYWZbcfFfAnBwJ6c8fodmA4CLCEXE YTw5yOZyoFW6MRuvHwDAsl9rhdv8AH+zIAzvtVWh7dQuFPmcsNHzKJzzAq/eYXJt95KjhR O4tdq8MmUjybZ9Mb1Koyeqs2GGu+xdY= Received: from mail-ot1-f70.google.com (mail-ot1-f70.google.com [209.85.210.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-524-cj_D3BGeNGOs115Sa_v0DA-1; Sat, 21 May 2022 16:47:29 -0400 X-MC-Unique: cj_D3BGeNGOs115Sa_v0DA-1 Received: by mail-ot1-f70.google.com with SMTP id c20-20020a056830349400b0060659610972so3382129otu.3 for ; Sat, 21 May 2022 13:47:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Q7KKV9nEc1O8xO71RHJAseDwiXENbXZxnjAzbqBmERg=; b=U1fZFsSCmXJAH0QjECo1J58d+jKkMb+IMrVeBbXu1C54IFQj/K9FzvRyPPS/PUzMcy Gghc06BLcAOtr0973W1kLtF5OBBNEoSqL/D3UUasjzCXi60Q3epx2PkhCrcbDcW9tgUh nrBeB3ywNCCwxecXxlb0Ih6sfkjbTafjrh4Uorzqt5xADwnALE8yaTqpfSlVO50Qgxrh CjSdTnsewKdf/WiZojYO6mekEk/wgcEHP46QXltQCkncEoK3bzptfBmkTEfQ9jQugWSR euIqS6Db7tZbPrMujQWo2TwtRU25MMY+LkOQVg3RdGrCcbLnryIgYAogQH2EZTCK8uVs NGtA== X-Gm-Message-State: AOAM530jQsfOR5i5wWSStdc39CuuOIL4xvVMclywhCAOgOrBv4rMcs/u vgW3Pw1VLUWmEAClYOGggBB00/6244lznhCSUYLz/msrhFiDMO5ApaieTnrHV+RhegVvyyxUuUn 6GbtT8eiC4jzQjd5ltYkHwPkZano= X-Received: by 2002:a05:6870:5694:b0:f2:2ad8:a0ae with SMTP id p20-20020a056870569400b000f22ad8a0aemr2596748oao.71.1653166049068; Sat, 21 May 2022 13:47:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxXZGmjsHsgboy8HLVJI93WiKGJ0RPTYTp8bJj+9c19UnhE7jTtNQ/lroFEhDPgmTztujXLFg== X-Received: by 2002:a05:6870:5694:b0:f2:2ad8:a0ae with SMTP id p20-20020a056870569400b000f22ad8a0aemr2596738oao.71.1653166048917; Sat, 21 May 2022 13:47:28 -0700 (PDT) Received: from dell-per740-01.7a2m.lab.eng.bos.redhat.com (nat-pool-bos-t.redhat.com. [66.187.233.206]) by smtp.gmail.com with ESMTPSA id d44-20020a056870d2ac00b000f218150563sm1751520oae.10.2022.05.21.13.47.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 May 2022 13:47:28 -0700 (PDT) From: Tom Rix To: toke@toke.dk, kvalo@kernel.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Tom Rix Subject: [PATCH] ath9k: remove setting of 'is_ext' parameter Date: Sat, 21 May 2022 16:47:25 -0400 Message-Id: <20220521204725.2539952-1-trix@redhat.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org cppcheck reports [drivers/net/wireless/ath/ath9k/dfs.c:93]: (style) Assignment of function parameter has no effect outside the function. Both the is_ctl and the is_ext parameters are set in the if-else statement. But only is_ctl is used later, so setting is_ext is not needed and can be removed. Signed-off-by: Tom Rix --- drivers/net/wireless/ath/ath9k/dfs.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/wireless/ath/ath9k/dfs.c b/drivers/net/wireless/ath/ath9k/dfs.c index acb9602aa464..47cdfb584eb0 100644 --- a/drivers/net/wireless/ath/ath9k/dfs.c +++ b/drivers/net/wireless/ath/ath9k/dfs.c @@ -89,8 +89,6 @@ static int ath9k_get_max_index_ht40(struct ath9k_dfs_fft_40 *fft, int mag_upper = fft_max_magnitude(fft->upper_bins); if (mag_upper > mag_lower) is_ctl = false; - else - is_ext = false; } } if (is_ctl)