From patchwork Fri Jan 18 14:35:29 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Rob Herring \(Arm\)" X-Patchwork-Id: 155940 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp3327287jaa; Fri, 18 Jan 2019 06:35:33 -0800 (PST) X-Google-Smtp-Source: ALg8bN4eyGTt23o/79liHgybxxEaqFxmSRAG3YHEh1N2g9Hj7f3P8rkpfGJeX9ifb35lpOgi4fPk X-Received: by 2002:a63:2849:: with SMTP id o70mr17605015pgo.155.1547822133713; Fri, 18 Jan 2019 06:35:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547822133; cv=none; d=google.com; s=arc-20160816; b=VJ/Qk84oOwi0wo9RFrsvSUN9bARG/quFQfUVUTPAWD73muiL+jKtIR0Du7WIPYpygv LRz2cuZ/d1F9AenBEYRkJzSeyAlczGLfyXB+YVaqIuMWg2JtIuy6ylNsBFhlP5KzPdvj DPbkBOIyKmMJGLHkW9+lEAqKgUOwSOHA+FPz0n+MyJAuEzjKux1cDNdOIqhzUNwM7Au7 RJwRQ48RfhuX0XVqA3lrluO4gdW1bKJ1Et5UIezGvyvWgr5stnj20wvf41YTAe/no5cw wV6H4AHwt8AP3pZrApfHMi77qoZxlpbELZNNTJ0DVaOcHbQDTs1jVy64qj6jK2acgHgG co2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=DVGhT6BU39gUhAH6M0jr+uNLemL95swoAvyl8eRJ6FI=; b=PjlQT/2ekyVzI9A3ByN36u6/gmvLF2EdygFTmDp7DUMcykkXVA1zuqnfVxPKhsoCL0 2mLJoGzoIn8zGwwbl7qGCmbWOOW2Zxfg7UnkDjEFC11nTuXe0sqmkJ3UsED6jpzkqjjc gkIpwdLDn0KbAgEs9skNm889KKtEv/jtj8KCyxsxh8viiYtOQ+GjoOeOIyQrlVeQ10eG It2rn0LT9aNPhmysMJbIj/gC9N8eCEj8qYTC3F0WqKKAsiw/gsx9T8ZaFflRz1KVCjt3 AliN7cacBGTaFKvXzZWLwnUOb89QQiLXxQlBn87slgrf6R4m4BaptKiONJLMFEspoCJJ gXXg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f10si930699pgl.528.2019.01.18.06.35.33; Fri, 18 Jan 2019 06:35:33 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727681AbfAROfb (ORCPT + 12 others); Fri, 18 Jan 2019 09:35:31 -0500 Received: from mail-ot1-f65.google.com ([209.85.210.65]:42036 "EHLO mail-ot1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727342AbfAROfb (ORCPT ); Fri, 18 Jan 2019 09:35:31 -0500 Received: by mail-ot1-f65.google.com with SMTP id v23so14511964otk.9 for ; Fri, 18 Jan 2019 06:35:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=DVGhT6BU39gUhAH6M0jr+uNLemL95swoAvyl8eRJ6FI=; b=eR0p+o9ai3AcTn29+nA6iZ37R92D9HhUHyonmNgYrg1Omcftq01+hEbK2O6kLwHUBO gzToJYY00EeNrK/QXm3GXoLGp6GiFRaagZ3xM9b0RxQf/nGxnrYHooYhTZKQG0nLaZvM Hr0VaNUrb9QbOEt9Ieqpm24JfF26ezYPaXIbjd8hK5Oeut75ddSllnoaqurx2Fudmxia hUuLrwM/zWZxGHd863Oh3i5YSXLGcF06UjLZpmglUSUzAgKyT7hqMYmLJNcPodJEnUsT e6dlfZocrQST0xjN6RjYCSOrMGUdTm5nFTveqNY27yJ7u+gc+zpbrxA/HZhrfF7gIEOx RFCQ== X-Gm-Message-State: AJcUukceXFkSQI8RcCsK/5ed2MT56cThp2wYpMw6b5fi4r3pSYM+xoDa s5t5UYggFqV9vQeNK/4F+2wfXDU= X-Received: by 2002:a9d:6a1a:: with SMTP id g26mr12418915otn.172.1547822130556; Fri, 18 Jan 2019 06:35:30 -0800 (PST) Received: from xps15.herring.priv (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.googlemail.com with ESMTPSA id k13sm2101711otj.19.2019.01.18.06.35.29 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 18 Jan 2019 06:35:30 -0800 (PST) From: Rob Herring To: Michael Ellerman Cc: linux-kernel@vger.kernel.org, Benjamin Herrenschmidt , Paul Mackerras , linuxppc-dev@lists.ozlabs.org, kbuild test robot Subject: [PATCH] powerpc: chrp: Use of_node_is_type to access device_type Date: Fri, 18 Jan 2019 08:35:29 -0600 Message-Id: <20190118143529.13347-1-robh@kernel.org> X-Mailer: git-send-email 2.19.1 MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit 8ce5f8415753 ("of: Remove struct device_node.type pointer") removed struct device_node.type pointer, but the conversion to use of_node_is_type() accessor was missed in chrp_init_IRQ(). Fixes: 8ce5f8415753 ("of: Remove struct device_node.type pointer") Reported-by: kbuild test robot Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Michael Ellerman Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Rob Herring --- Michael, I see you just sent a PR of fixes. I can send this to Linus if you prefer. arch/powerpc/platforms/chrp/setup.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) -- 2.19.1 Acked-by: Michael Ellerman diff --git a/arch/powerpc/platforms/chrp/setup.c b/arch/powerpc/platforms/chrp/setup.c index e66644e0fb40..9438fa0fc355 100644 --- a/arch/powerpc/platforms/chrp/setup.c +++ b/arch/powerpc/platforms/chrp/setup.c @@ -538,8 +538,7 @@ static void __init chrp_init_IRQ(void) /* see if there is a keyboard in the device tree with a parent of type "adb" */ for_each_node_by_name(kbd, "keyboard") - if (kbd->parent && kbd->parent->type - && strcmp(kbd->parent->type, "adb") == 0) + if (of_node_is_type(kbd->parent, "adb")) break; of_node_put(kbd); if (kbd)