From patchwork Wed Aug 17 12:03:49 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 597916 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2AF7CC3F6B0 for ; Wed, 17 Aug 2022 12:04:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239202AbiHQMEV (ORCPT ); Wed, 17 Aug 2022 08:04:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36972 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239192AbiHQMEU (ORCPT ); Wed, 17 Aug 2022 08:04:20 -0400 Received: from mail-lj1-x232.google.com (mail-lj1-x232.google.com [IPv6:2a00:1450:4864:20::232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B292D4D241 for ; Wed, 17 Aug 2022 05:04:15 -0700 (PDT) Received: by mail-lj1-x232.google.com with SMTP id x25so13349199ljm.5 for ; Wed, 17 Aug 2022 05:04:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=ReOjLSRdM73U3T0jSSkVf1kkbc1X9kpMxiIghbKwlM0=; b=z0TsarAxIowZ9kSH9JdfzT94ayGy1+6y9CBhIAvRIXYPpHTdcOP2rigvWy3itZufME R0TagUtnAhzsaNXXZGhTU/b7hPmV/r50VgkD0Du020fiGzIJi/tjt9ivXGzNOMqL04vZ 8Wjm3HK5lgRcW5JryJas9fiPVVEc+jtjecO1I9BtrYCxZM9pGvtCksp3+cmPfFqwfZ3x nqxKnPrq8YbmUtV28KGB5vNetemnGIYXsP3IYzORMDW1GqPgT8TBcWib4MBWX5WM4Nsl AbhGOzqQ0OwmWs4tGwE8KdRKtj/38oSsBXzWP3rKcfg9rQvidJJgIxtw3UC0GXv1ACV/ 9mww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=ReOjLSRdM73U3T0jSSkVf1kkbc1X9kpMxiIghbKwlM0=; b=vuykb3J5ijiSP6QQKLJlCLHfhSTvIN1LDjQwaGT2erFrYhrUCeEHblPWeb3fxL+u+6 RmLKI/wacrr7MXWKbBUtIrW5DjoNT83jXfaj8frW8Ev5K9acwXV/iTjTbCFMuKFrBgkL LeYGebSx9l7dOV78l3D2vtX6tvake/ExHNMpouQOcGlAUFBujx76/GzeOuFohAbDlG4Z k9B3Kt/xTIEmGwIJIPv9MqaRpxQKqs01l1/YBXMWHJh2munY1m2qMgx839A8aQf1YjCh j9U9Wmg+Dx1SL7te3/J27DcEY0aRnb1v++BKgP2QGnJlUQYY5VnSSYTVD9Tfh6vKc9Vh vYmw== X-Gm-Message-State: ACgBeo3PoAFZ3k2qEd8h54QQbOSpL8lhKIBROAIOkJPNeY1bmmnxSu+a aOz5FxuK4eDnpGFyMk43OPB6Fw== X-Google-Smtp-Source: AA6agR4HaRuQaKBpbYd2r7g/Qd0i+GDhUEFiJdCWvdd78tKYkxTUqpJzc2jYZuh9mukaJIWD0s2AIA== X-Received: by 2002:a2e:b911:0:b0:261:8189:64e7 with SMTP id b17-20020a2eb911000000b00261818964e7mr5077716ljb.179.1660737853970; Wed, 17 Aug 2022 05:04:13 -0700 (PDT) Received: from krzk-bin.. (d15l54h48cw7vbh-qr4-4.rev.dnainternet.fi. [2001:14bb:ae:539c:1b1c:14b7:109b:ed76]) by smtp.gmail.com with ESMTPSA id d15-20020a05651221cf00b0048a97042251sm1670496lft.22.2022.08.17.05.04.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Aug 2022 05:04:13 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Lee Jones , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH 01/14] dt-bindings: mfd: qcom,tcsr: add SC7180, SC7280, SDM845 and MSM8998 Date: Wed, 17 Aug 2022 15:03:49 +0300 Message-Id: <20220817120403.458000-2-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220817120403.458000-1-krzysztof.kozlowski@linaro.org> References: <20220817120403.458000-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Document existing (SC7280) and new compatibles for TCSR syscon registers. Signed-off-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml b/Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml index 2f816fd0c9ec..849295b058b6 100644 --- a/Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml +++ b/Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml @@ -18,6 +18,10 @@ properties: oneOf: - items: - enum: + - qcom,sc7180-tcsr + - qcom,sc7280-tcsr + - qcom,sdm845-tcsr + - qcom,msm8998-tcsr - qcom,tcsr-apq8064 - qcom,tcsr-apq8084 - qcom,tcsr-ipq8064 From patchwork Wed Aug 17 12:03:51 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 598208 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB5A4C32773 for ; Wed, 17 Aug 2022 12:04:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239222AbiHQME3 (ORCPT ); Wed, 17 Aug 2022 08:04:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37472 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239206AbiHQME1 (ORCPT ); Wed, 17 Aug 2022 08:04:27 -0400 Received: from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com [IPv6:2a00:1450:4864:20::22d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8DC9248EBD for ; Wed, 17 Aug 2022 05:04:18 -0700 (PDT) Received: by mail-lj1-x22d.google.com with SMTP id bx38so13322770ljb.10 for ; Wed, 17 Aug 2022 05:04:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=7xLpyvjcjxtFjBdq2TnMTpFX2axCPt8X9rBvt8vK73g=; b=OCl7RP5B3diVVIlZ1sxJjymAcMtuFqHzkuw+8yc3snwyOed1ZRJArA+IcW+HOA9oEQ f+ratGG0lP05xhtuZF7AXUso/5Wk9CTIpfEa5U9b/5Jntj6Cn9YKqyaoLEEAN/bkXfjL LPSASlUxzjjGKsJe1/Uw0HObPUepsMzaJHO2AqwyWMQ4JhkMUwSkAcq/3u2sMYnDyWRX qq2kAMMYaI2yFimpgYDtfNzmRVW7B9ZQg4hdMxyFZeyEmMcw7Vz3AQQ3xstDhU55vtxP NdBz0C3oRDgZ6X1/nf8OuxNNA7LYoF1mYy3tA5cXk7OQKrX7pDtZoKeHTgEsluYdyAqj m6KA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=7xLpyvjcjxtFjBdq2TnMTpFX2axCPt8X9rBvt8vK73g=; b=EUc9haHW9R4qLmHJVOsvEm8isCRpoWrB4ngpzijXMDVi9/YEQ6JI7Us5ClxYTZdSsx yH8RXMjy91nnu7Wortc3Ez20CHtQxvw/WR1eHR4ofBtDiAvMqzyoEl66swUBiw9jfSZ9 QDmvNhz6nBc1InPh11ROd5j1+MmpeXAfCHAtWCewEm69o8Zpq4CZACGGDmvztTo1T7Jl pncfzdOI8haKfWcCKgbcURhbta6muSjupF9RnxjiaxZowrhS4aAeNcpJeEESsHAOUXGK cXYPth1Kl8x5PgOi5TECaBYAenkIXP3fy65xfXjZX2vHvNogZwhXqhel5eC4wzuSRJZC m8AQ== X-Gm-Message-State: ACgBeo3D2z/1lNiyGo3y0/TYvQwsL5eIjGUQAl9T+lo2VePHr8ph5aA0 fTUsyhCjI8bBbz2z/ukBh2/2+A== X-Google-Smtp-Source: AA6agR5r2qyeSvJtZI4WU8K3RqHXaRKZJMrxzhGEoQa7yoh9SaWiOmc56Mb8c6MEpg1WwJ1mGXbGHg== X-Received: by 2002:a2e:a552:0:b0:25e:6fa1:a6c4 with SMTP id e18-20020a2ea552000000b0025e6fa1a6c4mr7374386ljn.90.1660737856798; Wed, 17 Aug 2022 05:04:16 -0700 (PDT) Received: from krzk-bin.. (d15l54h48cw7vbh-qr4-4.rev.dnainternet.fi. [2001:14bb:ae:539c:1b1c:14b7:109b:ed76]) by smtp.gmail.com with ESMTPSA id d15-20020a05651221cf00b0048a97042251sm1670496lft.22.2022.08.17.05.04.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Aug 2022 05:04:16 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Lee Jones , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH 02/14] arm64: dts: qcom: msm8996: split TCSR halt regs out of mutex Date: Wed, 17 Aug 2022 15:03:51 +0300 Message-Id: <20220817120403.458000-4-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220817120403.458000-1-krzysztof.kozlowski@linaro.org> References: <20220817120403.458000-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org The TCSR halt regs are next to TCSR mutex, so before converting the TCSR mutex into device with address space, we need to split the halt regs to its own syscon device. This also describes more accurately the devices and their IO address space. Signed-off-by: Krzysztof Kozlowski --- arch/arm64/boot/dts/qcom/msm8996.dtsi | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi index 742eac4ce9b3..3411ced96db6 100644 --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi @@ -359,7 +359,7 @@ opp-2150400000 { firmware { scm { compatible = "qcom,scm-msm8996", "qcom,scm"; - qcom,dload-mode = <&tcsr 0x13000>; + qcom,dload-mode = <&tcsr_2 0x13000>; }; }; @@ -840,10 +840,15 @@ pnoc: interconnect@5c0000 { tcsr_mutex_regs: syscon@740000 { compatible = "syscon"; - reg = <0x00740000 0x40000>; + reg = <0x00740000 0x20000>; }; - tcsr: syscon@7a0000 { + tcsr_1: sycon@760000 { + compatible = "qcom,tcsr-msm8996", "syscon"; + reg = <0x00760000 0x20000>; + }; + + tcsr_2: syscon@7a0000 { compatible = "qcom,tcsr-msm8996", "syscon"; reg = <0x007a0000 0x18000>; }; @@ -2413,7 +2418,7 @@ mss_pil: remoteproc@2080000 { qcom,smem-states = <&mpss_smp2p_out 0>; qcom,smem-state-names = "stop"; - qcom,halt-regs = <&tcsr_mutex_regs 0x23000 0x25000 0x24000>; + qcom,halt-regs = <&tcsr_1 0x3000 0x5000 0x4000>; status = "disabled"; From patchwork Wed Aug 17 12:03:52 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 597915 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7017AC32789 for ; Wed, 17 Aug 2022 12:04:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239227AbiHQMEa (ORCPT ); Wed, 17 Aug 2022 08:04:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37220 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239204AbiHQMEX (ORCPT ); Wed, 17 Aug 2022 08:04:23 -0400 Received: from mail-lj1-x22c.google.com (mail-lj1-x22c.google.com [IPv6:2a00:1450:4864:20::22c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CCD914D164 for ; Wed, 17 Aug 2022 05:04:19 -0700 (PDT) Received: by mail-lj1-x22c.google.com with SMTP id z20so13361775ljq.3 for ; Wed, 17 Aug 2022 05:04:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=DmgjoU3ZwmShD+iuLbm/N6H6WPhywoNwmKzID5e5568=; b=j/QnFP4W4/aHt9WeYXXpq/i3mE8ytEu0XXcD6vrAlm/2ebp/72isn/wHDJpyGGZySm INKCpl1NSLTrfpDYofC4eskzicQo8glDFvPt1YDtdU+/lWVTqd0knSXiG50CkvQM/kui oYcX936jAbvkqP3TFwny0FKcFoAk6WgUpVqRptwBt74Fg9rNK2p3z5j7uKq5XYLjR2qR 111dk7lQzoH3wo+b8QJLBvnFopMMXOoy0iRFhLYjmGqzKic664AWx507p12to5fhwsT7 kIs/QRuLCraUolYhQmqsAGemb/ySIX/CoW5kzBuxDelUee5k6sv6xm3lM10njXwI1Hyy Ddvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=DmgjoU3ZwmShD+iuLbm/N6H6WPhywoNwmKzID5e5568=; b=TVP7QH8TtcDR5POKcHeXPN6Erbr7/+/J+349mBpphD/MGjKnXfuJyTJlEk5NSQxVVq PaP8yZBg3gUmRYLLScwMtHadH1vrc1frS64A8ONzMlpWg7pKJoN/6hUZbEz42fK0q363 F7C5vSeDf9WCmIlejLvOZArFl73rAyDlidNVMG2mmVD/s2ZHh5EZ4IEDdNgcXmLF88Jk raZGC9e2AZAUxjpOgDPKlQJWD9SQ5klyfbhTXt0HlfSuWxw8ZyWuhjm2bue0BwJ8/XfX NEq49rDCFcTQqmhFpZgwbi+Nrj4w8h/Of/MxPdMu0lCo4tayS+B2dyaVrAKwlqKHUEuk 4V3A== X-Gm-Message-State: ACgBeo3p8WnLrXqfWltbHT1iXc/WPmQ1baAb1rTbD2Wh8G8/ncbgzVeV CrWDbEuL89pakQM/J0wfBmy/lQ== X-Google-Smtp-Source: AA6agR6I1w5MNcoo7t8sGOgTtQ9uIgjNN68nM8xwTvZCFW+XbogVVwEdriDsOLVKVlwF05vdl3PWsQ== X-Received: by 2002:a2e:8188:0:b0:25e:4ae6:5503 with SMTP id e8-20020a2e8188000000b0025e4ae65503mr7460455ljg.412.1660737858207; Wed, 17 Aug 2022 05:04:18 -0700 (PDT) Received: from krzk-bin.. (d15l54h48cw7vbh-qr4-4.rev.dnainternet.fi. [2001:14bb:ae:539c:1b1c:14b7:109b:ed76]) by smtp.gmail.com with ESMTPSA id d15-20020a05651221cf00b0048a97042251sm1670496lft.22.2022.08.17.05.04.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Aug 2022 05:04:17 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Lee Jones , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH 03/14] arm64: dts: qcom: msm8996: switch TCSR mutex to MMIO Date: Wed, 17 Aug 2022 15:03:52 +0300 Message-Id: <20220817120403.458000-5-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220817120403.458000-1-krzysztof.kozlowski@linaro.org> References: <20220817120403.458000-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org The TCSR mutex bindings allow device to be described only with address space (so it uses MMIO, not syscon regmap). This seems reasonable as TCSR mutex is actually a dedicated IO address space and it also fixes DT schema checks: qcom/msm8996-xiaomi-natrium.dtb: hwlock: 'reg' is a required property qcom/msm8996-xiaomi-natrium.dtb: hwlock: 'syscon' does not match any of the regexes: 'pinctrl-[0-9]+' Signed-off-by: Krzysztof Kozlowski --- arch/arm64/boot/dts/qcom/msm8996.dtsi | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi index 3411ced96db6..166374566a49 100644 --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi @@ -363,12 +363,6 @@ scm { }; }; - tcsr_mutex: hwlock { - compatible = "qcom,tcsr-mutex"; - syscon = <&tcsr_mutex_regs 0 0x1000>; - #hwlock-cells = <1>; - }; - memory@80000000 { device_type = "memory"; /* We expect the bootloader to fill in the reg */ @@ -838,9 +832,10 @@ pnoc: interconnect@5c0000 { <&rpmcc RPM_SMD_PCNOC_A_CLK>; }; - tcsr_mutex_regs: syscon@740000 { - compatible = "syscon"; + tcsr_mutex: hwlock@740000 { + compatible = "qcom,tcsr-mutex"; reg = <0x00740000 0x20000>; + #hwlock-cells = <1>; }; tcsr_1: sycon@760000 { From patchwork Wed Aug 17 12:03:53 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 597914 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33EA7C32772 for ; Wed, 17 Aug 2022 12:04:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239204AbiHQMEb (ORCPT ); Wed, 17 Aug 2022 08:04:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37534 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239212AbiHQME2 (ORCPT ); Wed, 17 Aug 2022 08:04:28 -0400 Received: from mail-lj1-x231.google.com (mail-lj1-x231.google.com [IPv6:2a00:1450:4864:20::231]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A10B64D25B for ; Wed, 17 Aug 2022 05:04:21 -0700 (PDT) Received: by mail-lj1-x231.google.com with SMTP id z20so13361848ljq.3 for ; Wed, 17 Aug 2022 05:04:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=d81NAUVI3O6mHh9rRCLTkzFGlVQOgUX55hJVWZukNlg=; b=O5fDAXAHPeoUaYrEtDaUax7G81BrEIS1GD2raYLyy2z0UnXG590QYeBcIpPci5Hfwi y8XODPOEh0iIZJqhxkVQCQYxsknov/nV2qf+XO9QB/MVZLuu6W5URKsFK48qhYxm+PNd ZyLMG4TzoVTUD/w+47OlgaBNByS43kUYyc4qSRJ97kgiZbINhTTwsPZUL3iYU28x86BU NECJa2pnRKa0S/e8inilSWhA6NUvZFAUvdKJz9jOAQpMRN3y2xkW8mmylpZ1JbN3wUr4 gMpEmdMTejgyNT/oJqTu7NW1NfeYaOtmHzzxWuuXGfvinl1qYAr1Snq8OPUtejGAJwLF Vo0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=d81NAUVI3O6mHh9rRCLTkzFGlVQOgUX55hJVWZukNlg=; b=aoKOEbmaSH3uX2iRcFBfbmaapQIceIO320A1u5LHZXOVLtMX682lSRcWsWmhf1kQET PwkwX31FPmu1QcbYRg9LIrRjo7OI/ZvsYXTUKFsYRRUR9S2HtKM/Pqf2v91+n1N0i0ko HQBFMJiWpZjb1GuBAY3RHvLD0z6f/FoV+t6xOYWYhVZ6KjqRvuUjrGgzQz/1p1R5bUAl 6zUmX5u5/qYXcyCnIlztMc9R935z1v9XVu1Xx3UTG9dtE9kwKKPcWeLM8NbvDfourWB8 lzaVGbSmvhRy+lLgi6dhDbZVJZVV25Cnkue13JtfyvfTg97EGqBRmyyiC9kUQKyIsNks YKIA== X-Gm-Message-State: ACgBeo2Jyr6rFU4L1CHBVHvRN893ctohmJgo82994IxhFmxfnDyQGQuz Hhy9V0QNSoRLvGxwbso0lS6hsA== X-Google-Smtp-Source: AA6agR6u79wvYDGUZO0tZdytxlWZ5j1jtPZwx3ppR2OhdecQ870NyUimRspfcWf/hGog/YX78QVQuw== X-Received: by 2002:a05:651c:1149:b0:25e:6918:22bf with SMTP id h9-20020a05651c114900b0025e691822bfmr7770720ljo.258.1660737859951; Wed, 17 Aug 2022 05:04:19 -0700 (PDT) Received: from krzk-bin.. (d15l54h48cw7vbh-qr4-4.rev.dnainternet.fi. [2001:14bb:ae:539c:1b1c:14b7:109b:ed76]) by smtp.gmail.com with ESMTPSA id d15-20020a05651221cf00b0048a97042251sm1670496lft.22.2022.08.17.05.04.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Aug 2022 05:04:19 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Lee Jones , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH 04/14] arm64: dts: qcom: msm8998: split TCSR halt regs out of mutex Date: Wed, 17 Aug 2022 15:03:53 +0300 Message-Id: <20220817120403.458000-6-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220817120403.458000-1-krzysztof.kozlowski@linaro.org> References: <20220817120403.458000-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org The TCSR halt regs are next to TCSR mutex, so before converting the TCSR mutex into device with address space, we need to split the halt regs to its own syscon device. This also describes more accurately the devices and their IO address space. Signed-off-by: Krzysztof Kozlowski --- arch/arm64/boot/dts/qcom/msm8998.dtsi | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi b/arch/arm64/boot/dts/qcom/msm8998.dtsi index 02d21bff2198..f0806ed103f1 100644 --- a/arch/arm64/boot/dts/qcom/msm8998.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8998.dtsi @@ -1049,7 +1049,12 @@ ufsphy_lanes: phy@1da7400 { tcsr_mutex_regs: syscon@1f40000 { compatible = "syscon"; - reg = <0x01f40000 0x40000>; + reg = <0x01f40000 0x20000>; + }; + + tcsr_regs_1: sycon@1f60000 { + compatible = "qcom,msm8998-tcsr", "syscon"; + reg = <0x01f60000 0x20000>; }; tlmm: pinctrl@3400000 { @@ -1340,7 +1345,7 @@ remoteproc_mss: remoteproc@4080000 { resets = <&gcc GCC_MSS_RESTART>; reset-names = "mss_restart"; - qcom,halt-regs = <&tcsr_mutex_regs 0x23000 0x25000 0x24000>; + qcom,halt-regs = <&tcsr_regs_1 0x3000 0x5000 0x4000>; power-domains = <&rpmpd MSM8998_VDDCX>, <&rpmpd MSM8998_VDDMX>; From patchwork Wed Aug 17 12:03:54 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 598205 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03ECBC32789 for ; Wed, 17 Aug 2022 12:04:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239192AbiHQMEd (ORCPT ); Wed, 17 Aug 2022 08:04:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37534 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239225AbiHQMEa (ORCPT ); Wed, 17 Aug 2022 08:04:30 -0400 Received: from mail-lj1-x235.google.com (mail-lj1-x235.google.com [IPv6:2a00:1450:4864:20::235]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 427534D4DF for ; Wed, 17 Aug 2022 05:04:23 -0700 (PDT) Received: by mail-lj1-x235.google.com with SMTP id x10so13352588ljq.4 for ; Wed, 17 Aug 2022 05:04:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=Oc1vz9/DWeA4ULM94yDKxE44YQvZ9a9JuzHX3olMNuY=; b=JOw7aJug/ittMZM397qQMP7PNTssn5birDsiYlSxKAIqKhSQbv6lAKSCuZs95wxO7u 8FDAG0U7R8LOo9kZ7FFgm9Q9JuT7uHTTFwzZ9oAwMAtJJHrHXYlgKkcPW3/AkUN0Ujf2 Wr6TLPgDUKOUfj7nXJvmDzUt1/IXwFXHvsecnB3oeQ/Os3tazhB4kdHZQQgotF1G3Ngz 99fq5R5bD2+xvF+cL1hXtUV+2f9iB4f6E00rg+b9g+fpkS7Mt1W0bd6isEXx1ppHrpYZ ncJeSD7TfMTnBdzzNGgvaIKyYEEbfaNHXeFqE0C+aGkAJEGSJn2Zk26nhCAZax9vyn95 SCPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=Oc1vz9/DWeA4ULM94yDKxE44YQvZ9a9JuzHX3olMNuY=; b=XZyZrBdGAODT4afLFpT06vC39fO1KPAirByNH8CY8/wUSKFmnA8uulbzdWN8XGw4Mp r0gKZhPWM6Dg6cTe2RNfMIBRa5X8L3Wlw8bOA2WoTCvCFY7GXyPGChgBvX06lfntAwuh i+LMZbs+oEjRQfiWEmHOVOA08a3n2zukveZQMQvsl1b4AtyYtLtalDK/AFuWJ5NLE08/ /w5e42+PmOmfPhd4r6uZw6DanHvPY2zbZcOCxx6Agkfx0iuXPbVOM7czEJRQnqxqGhWU 95yNjr2MSbOs+VIZeqblSnNmVoxwwB5VSP2qDJwpCD8iCaO/X5FN/ejrVAS3SepyKHlW dvww== X-Gm-Message-State: ACgBeo3W0ZLAKjPl6+AwgCRU20ZnrneG06FlOtlFOvNnQIk+N26Bra7M RGkMpDFUYFGy341ybUic7R5RXw== X-Google-Smtp-Source: AA6agR76QSaUVvbpXrRlU59d3Q0u7kPWVrRH4iu47NsubtYBm+HnQouPetdXzqwxfxU/2nye1BF8+w== X-Received: by 2002:a2e:90d8:0:b0:261:7ffd:2783 with SMTP id o24-20020a2e90d8000000b002617ffd2783mr5628856ljg.59.1660737861398; Wed, 17 Aug 2022 05:04:21 -0700 (PDT) Received: from krzk-bin.. (d15l54h48cw7vbh-qr4-4.rev.dnainternet.fi. [2001:14bb:ae:539c:1b1c:14b7:109b:ed76]) by smtp.gmail.com with ESMTPSA id d15-20020a05651221cf00b0048a97042251sm1670496lft.22.2022.08.17.05.04.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Aug 2022 05:04:20 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Lee Jones , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH 05/14] arm64: dts: qcom: msm8998: switch TCSR mutex to MMIO Date: Wed, 17 Aug 2022 15:03:54 +0300 Message-Id: <20220817120403.458000-7-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220817120403.458000-1-krzysztof.kozlowski@linaro.org> References: <20220817120403.458000-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org The TCSR mutex bindings allow device to be described only with address space (so it uses MMIO, not syscon regmap). This seems reasonable as TCSR mutex is actually a dedicated IO address space and it also fixes DT schema checks: qcom/msm8998-asus-novago-tp370ql.dtb: hwlock: 'reg' is a required property qcom/msm8998-asus-novago-tp370ql.dtb: hwlock: 'syscon' does not match any of the regexes: 'pinctrl-[0-9]+' Signed-off-by: Krzysztof Kozlowski --- arch/arm64/boot/dts/qcom/msm8998.dtsi | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi b/arch/arm64/boot/dts/qcom/msm8998.dtsi index f0806ed103f1..22b2da74d105 100644 --- a/arch/arm64/boot/dts/qcom/msm8998.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8998.dtsi @@ -308,12 +308,6 @@ scm { }; }; - tcsr_mutex: hwlock { - compatible = "qcom,tcsr-mutex"; - syscon = <&tcsr_mutex_regs 0 0x1000>; - #hwlock-cells = <1>; - }; - psci { compatible = "arm,psci-1.0"; method = "smc"; @@ -1047,9 +1041,10 @@ ufsphy_lanes: phy@1da7400 { }; }; - tcsr_mutex_regs: syscon@1f40000 { - compatible = "syscon"; + tcsr_mutex: hwlock@1f40000 { + compatible = "qcom,tcsr-mutex"; reg = <0x01f40000 0x20000>; + #hwlock-cells = <1>; }; tcsr_regs_1: sycon@1f60000 { From patchwork Wed Aug 17 12:03:55 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 597913 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58288C2BB41 for ; Wed, 17 Aug 2022 12:04:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239208AbiHQMEc (ORCPT ); Wed, 17 Aug 2022 08:04:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37524 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239192AbiHQMEa (ORCPT ); Wed, 17 Aug 2022 08:04:30 -0400 Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com [IPv6:2a00:1450:4864:20::12c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6C8C64D82F for ; Wed, 17 Aug 2022 05:04:24 -0700 (PDT) Received: by mail-lf1-x12c.google.com with SMTP id w5so18733574lfq.5 for ; Wed, 17 Aug 2022 05:04:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=vdE5nDV3qdB6mAn0Qwup5zvvjj6Xy+e1DVZdaTpFju4=; b=MothkAULivGE5t/I0REdZsq/qGcfROwwWXGp3na9KFPPN4Zy+AkQjk+a0Y/7uxdNOK y/rd68UEDiJfDd0k1X+s/+W6B3oJ5LIBi1a9jWW+YazHaXqsR3/YUGwwQBjXpbAe26uP nE0ccEQodw2lbJNqg1kVJ/yaAQ+A21DtE8dwpVhuwiu6exZ0hTA8CqOiV4sZrK4KAzwP 66VRRSHWybNDC+CrLzUjRS/OdXMY8VbZCML6lXC5+LWyToW6/2AN9MPoeJ8KWZcH6Foo 3HkrBrZdUgQ/09M2nvkN0Mo6EDYAi3fjdXf1H31qUq0lD1Phz3ECJx5937M6XEQGIgc1 Q+1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=vdE5nDV3qdB6mAn0Qwup5zvvjj6Xy+e1DVZdaTpFju4=; b=OqgrwHp3WDO5+t58MkURMRxtMXErMNQJ2kKun8M3NIOAmwkGkoJKRi4Ll+/jECYeU7 BI3NNL3vtzwKQrpq0/49jdEKDww1fwHdWsjOpgS0WNwJIYroZ4oaFoGuxNocvjz08ZSY ZJ752wl5oluhGBc2XCu6b2zNqBPW7WshT8UJ2VHTx+gPd9C5OvmZ/ivzBjhyyy7lRuQs BAU257JirM8aWaatQbG5uP0Ckw6et3eNmSSSvQtt5eXvsYCghhpUE5G0bpyFogQd3LOm pC7pkJdRSu8sz1AsEv+Ti1fe+dYbSEF3LM5Xi5GW1LCIPnsX8QNxkK3PDtsqWgz5bmRP f/RA== X-Gm-Message-State: ACgBeo0POvRO/tsT0m+iRfYb6NQqJtirkhhpPcrdGapybH3i2lvvpK+m /EHGieKTU6nck211k5gy++Ckkg== X-Google-Smtp-Source: AA6agR5OKAEP8ghN+km9ORmOMDn8PGCxJIGdj0PByz2HcfuUHt9EcrDunP64yn9/DfeV3R372TNFNA== X-Received: by 2002:a05:6512:3c8b:b0:48c:ffd4:a8ce with SMTP id h11-20020a0565123c8b00b0048cffd4a8cemr7954884lfv.628.1660737862807; Wed, 17 Aug 2022 05:04:22 -0700 (PDT) Received: from krzk-bin.. (d15l54h48cw7vbh-qr4-4.rev.dnainternet.fi. [2001:14bb:ae:539c:1b1c:14b7:109b:ed76]) by smtp.gmail.com with ESMTPSA id d15-20020a05651221cf00b0048a97042251sm1670496lft.22.2022.08.17.05.04.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Aug 2022 05:04:22 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Lee Jones , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH 06/14] arm64: dts: qcom: sc7180: add missing TCSR syscon compatible Date: Wed, 17 Aug 2022 15:03:55 +0300 Message-Id: <20220817120403.458000-8-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220817120403.458000-1-krzysztof.kozlowski@linaro.org> References: <20220817120403.458000-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org TCSR syscon node should come with dedicated compatible. Signed-off-by: Krzysztof Kozlowski --- arch/arm64/boot/dts/qcom/sc7180.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi index b82c335c25af..49f28cb531f6 100644 --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi @@ -1468,7 +1468,7 @@ tcsr_mutex_regs: syscon@1f40000 { }; tcsr_regs: syscon@1fc0000 { - compatible = "syscon"; + compatible = "qcom,sc7180-tcsr", "syscon"; reg = <0 0x01fc0000 0 0x40000>; }; From patchwork Wed Aug 17 12:03:56 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 598206 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F7E9C32773 for ; Wed, 17 Aug 2022 12:04:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239233AbiHQMEb (ORCPT ); Wed, 17 Aug 2022 08:04:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37108 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239208AbiHQMEa (ORCPT ); Wed, 17 Aug 2022 08:04:30 -0400 Received: from mail-lj1-x22c.google.com (mail-lj1-x22c.google.com [IPv6:2a00:1450:4864:20::22c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 175174DB0B for ; Wed, 17 Aug 2022 05:04:24 -0700 (PDT) Received: by mail-lj1-x22c.google.com with SMTP id z20so13362001ljq.3 for ; Wed, 17 Aug 2022 05:04:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=DL4opHqld4qCjVSblJBLt63Edv/Ob11xgTM5Drh1lj4=; b=U2Jpcx+6tKXhMdjtMZqfWrRNWoL3zSXnFX/6QxN/18h95toNTTH0X4ig3QhdDQyqWd TU1N5xdIDsBxDLNUElGF1XL0Tp+oUdOHqnqv+ltREiWU2qV6wQ25QqOE6CDDmrGAuRDP e3Yba/VEDsWHH6WydK5P1D0XZ0VE/KJK0Dw7F5FgjwFp88k7+xYZgH44HGzUJqDQ+2o6 pEvwwifG4hcqO223C8431alSDRFQ9A2GT7024e0XUL9tFS+A7tzNONQIxufkGIsv/foL r9bDtpQXHUCddwgce7Uho+0jmP02j39CD4Kf8Yc1V/VZRWwXyQ4NgA5B3mm+3WudcK7a qi7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=DL4opHqld4qCjVSblJBLt63Edv/Ob11xgTM5Drh1lj4=; b=M/4wk1D/agNcAHnaRt8M6xW6LwgCNpT9S9eGw9tEw39Npg+eZELf6quPAtNFxj5O8M mGET2xyE51DeLmtmbBXkV6LW8sQYtu2+wuc9blFIboYYYWlSnvPVgK+rJuPqiZzP/1Zi 93si2cr2ubm4dmO+LAEulenFWL+b4pPIBiEnvPSBtgMpKgnSGlC/87PzcDGUZA5YkKlM TQkDkX2XFEefOxyXEuhr+iuCFUioXg+SuwPA/rlIwH4s0dzuBZfPwbidlmsSSwvWexF0 0tSxVdMaGXJIX9MLf+Nprws5Bdj/OSDF7JP6oyXvmoyakMY7lS/XZ7aV8+JbWOl4skk6 CtkA== X-Gm-Message-State: ACgBeo0SZkv8F9P2WhsdmsnOv09Nq4TD0aYg8o4vPYS5CHpw/KwAN94u GUPz09OYP2BIhU+BBQD2bpbMnw== X-Google-Smtp-Source: AA6agR4EfDgBjPb1aBWDeDqMamM4ROl/UhQom14B0yGPr97jZN5jxsD8NtrDo1Hl9u/Rw4HQgueDmg== X-Received: by 2002:a2e:597:0:b0:25e:4a64:1628 with SMTP id 145-20020a2e0597000000b0025e4a641628mr7626153ljf.378.1660737864392; Wed, 17 Aug 2022 05:04:24 -0700 (PDT) Received: from krzk-bin.. (d15l54h48cw7vbh-qr4-4.rev.dnainternet.fi. [2001:14bb:ae:539c:1b1c:14b7:109b:ed76]) by smtp.gmail.com with ESMTPSA id d15-20020a05651221cf00b0048a97042251sm1670496lft.22.2022.08.17.05.04.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Aug 2022 05:04:23 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Lee Jones , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH 07/14] arm64: dts: qcom: sc7180: split TCSR halt regs out of mutex Date: Wed, 17 Aug 2022 15:03:56 +0300 Message-Id: <20220817120403.458000-9-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220817120403.458000-1-krzysztof.kozlowski@linaro.org> References: <20220817120403.458000-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org The TCSR halt regs are next to TCSR mutex, so before converting the TCSR mutex into device with address space, we need to split the halt regs to its own syscon device. This also describes more accurately the devices and their IO address space. Signed-off-by: Krzysztof Kozlowski --- arch/arm64/boot/dts/qcom/sc7180.dtsi | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi index 49f28cb531f6..5d2dd21da79c 100644 --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi @@ -1464,10 +1464,15 @@ ipa: ipa@1e40000 { tcsr_mutex_regs: syscon@1f40000 { compatible = "syscon"; - reg = <0 0x01f40000 0 0x40000>; + reg = <0 0x01f40000 0 0x20000>; }; - tcsr_regs: syscon@1fc0000 { + tcsr_regs_1: sycon@1f60000 { + compatible = "qcom,sc7180-tcsr", "syscon"; + reg = <0 0x01f60000 0 0x20000>; + }; + + tcsr_regs_2: syscon@1fc0000 { compatible = "qcom,sc7180-tcsr", "syscon"; reg = <0 0x01fc0000 0 0x40000>; }; @@ -1932,8 +1937,8 @@ remoteproc_mpss: remoteproc@4080000 { <&pdc_reset PDC_MODEM_SYNC_RESET>; reset-names = "mss_restart", "pdc_reset"; - qcom,halt-regs = <&tcsr_mutex_regs 0x23000 0x25000 0x24000>; - qcom,spare-regs = <&tcsr_regs 0xb3e4>; + qcom,halt-regs = <&tcsr_regs_1 0x3000 0x5000 0x4000>; + qcom,spare-regs = <&tcsr_regs_2 0xb3e4>; status = "disabled"; From patchwork Wed Aug 17 12:03:57 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 597912 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E420AC25B08 for ; Wed, 17 Aug 2022 12:04:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239264AbiHQMEl (ORCPT ); Wed, 17 Aug 2022 08:04:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38012 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239242AbiHQMEg (ORCPT ); Wed, 17 Aug 2022 08:04:36 -0400 Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [IPv6:2a00:1450:4864:20::132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 657FF4F646 for ; Wed, 17 Aug 2022 05:04:27 -0700 (PDT) Received: by mail-lf1-x132.google.com with SMTP id e15so18784318lfs.0 for ; Wed, 17 Aug 2022 05:04:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=DbSnvFkY9bvjJ+mlDkzyxC4/7mNnK/XqOObaGJH93/Q=; b=VMufVlr3u+pUoXDgiGfPz3XPbBKafmaGKzn6bmaiKba1I9hURUbjKqgBD+zt+6qIze mfMFjg368kc1fsOcLA9OOX9n2WPX7rdgGCNIH8zYVuacBApl820j5gHk5HmoLYZEER97 G890T7nHXRfei3vKzNwaeJ9chudhIKO9FSjEDLZp6eFNMKP4PXp7j+M6tNzR4iHB09hs RT8kt3uhjfvG6Ib6KqlmOsiwXjJp7p3kpS6LvLD/mjTwGp0syZBVuhaBSFlUVgT9rJC3 3oOMQmK2vGBr4Wxd/v++GFjJbylPmlfrhWbV7spBctETRf84nJh2hyAXrmUxgbnPclNL tBDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=DbSnvFkY9bvjJ+mlDkzyxC4/7mNnK/XqOObaGJH93/Q=; b=jApiSWHnsfqHJIAqK4+zSfWv17B5qzwbrxrUOYG2Hjqhwi216xvxUYNUhDvkFbdSgw Dr3rFwGMa4RSJ4KTkPd50owX9d0d85fwlGp3m1TLAuAroQ8PukAhbkGQDGh2QtW5WMZa ddnFijU1ym8Hff4nkDP/WgFlEwVRCjF9BIlT4NQBQzHzvx4SrbgKM0LuasqNzWCy+ONb /qBNL9ajcB1PIsvOX2+k7eUgPZOBVZ/CGiy2NQ6PFs1WyU3THbJoolmohOTyF9gYkWIf BRK6+LRjDyHmsDW57qZhV5T6dOPnm3JWAdYmh8MyKMx2lZqXLp1eLmpTShAfNEkuZQCr uygA== X-Gm-Message-State: ACgBeo06fr03kot5DJy7QyPpfN3Y493OGYOCQsSBkYTDIgCxIaa1C51n +NWGzT0yPhL7+MkKFFAzjD2RVA== X-Google-Smtp-Source: AA6agR5iQBUte+94JslVCBUtz7QXQfDuFjA1iFoSnomMCkgrjB2XEOCZ7NyAh6iO+SvCaj0s605HRw== X-Received: by 2002:ac2:499a:0:b0:48a:e96b:9f66 with SMTP id f26-20020ac2499a000000b0048ae96b9f66mr8259895lfl.12.1660737865730; Wed, 17 Aug 2022 05:04:25 -0700 (PDT) Received: from krzk-bin.. (d15l54h48cw7vbh-qr4-4.rev.dnainternet.fi. [2001:14bb:ae:539c:1b1c:14b7:109b:ed76]) by smtp.gmail.com with ESMTPSA id d15-20020a05651221cf00b0048a97042251sm1670496lft.22.2022.08.17.05.04.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Aug 2022 05:04:25 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Lee Jones , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH 08/14] arm64: dts: qcom: sc7180: switch TCSR mutex to MMIO Date: Wed, 17 Aug 2022 15:03:57 +0300 Message-Id: <20220817120403.458000-10-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220817120403.458000-1-krzysztof.kozlowski@linaro.org> References: <20220817120403.458000-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org The TCSR mutex bindings allow device to be described only with address space (so it uses MMIO, not syscon regmap). This seems reasonable as TCSR mutex is actually a dedicated IO address space and it also fixes DT schema checks: qcom/sc7180-trogdor-wormdingler-rev1-inx.dtb: hwlock: 'reg' is a required property qcom/sc7180-trogdor-wormdingler-rev1-inx.dtb: hwlock: 'syscon' does not match any of the regexes: 'pinctrl-[0-9]+' Signed-off-by: Krzysztof Kozlowski --- arch/arm64/boot/dts/qcom/sc7180.dtsi | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi index 5d2dd21da79c..e8debb0da411 100644 --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi @@ -555,12 +555,6 @@ scm { }; }; - tcsr_mutex: hwlock { - compatible = "qcom,tcsr-mutex"; - syscon = <&tcsr_mutex_regs 0 0x1000>; - #hwlock-cells = <1>; - }; - smem { compatible = "qcom,smem"; memory-region = <&smem_mem>; @@ -1462,9 +1456,10 @@ ipa: ipa@1e40000 { status = "disabled"; }; - tcsr_mutex_regs: syscon@1f40000 { - compatible = "syscon"; + tcsr_mutex: hwlock@1f40000 { + compatible = "qcom,tcsr-mutex"; reg = <0 0x01f40000 0 0x20000>; + #hwlock-cells = <1>; }; tcsr_regs_1: sycon@1f60000 { From patchwork Wed Aug 17 12:03:58 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 598204 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBE5EC25B08 for ; Wed, 17 Aug 2022 12:04:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239272AbiHQMEo (ORCPT ); Wed, 17 Aug 2022 08:04:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38066 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239245AbiHQMEh (ORCPT ); Wed, 17 Aug 2022 08:04:37 -0400 Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com [IPv6:2a00:1450:4864:20::12c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B32DB4F661 for ; Wed, 17 Aug 2022 05:04:28 -0700 (PDT) Received: by mail-lf1-x12c.google.com with SMTP id z6so18718462lfu.9 for ; Wed, 17 Aug 2022 05:04:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=QCMHKhkVunzbtGiMJ/wq/fYfBgDNCThjx88/COvHDls=; b=jMVMljrAXcYn6hVHQqGcd6DmXZC3bnx+dOnbvpw03W+hSQ1yLtV0yLSF4E0K/vW1PH oalzUaSW36/TGpx1jvmKYfJnOc4cgVr4qtZeIyKFcSEM2D+P81umCkxaU2W3uAXwr6uh ee/qbI/7n8m0SzL5Foh+yEM0axQYOjoy0oTPG1c65x8yk5pvaDFmBuBgJ5U6/X4Havsr mnSeAsv5VFRGZr88sBTI7F7D3sawGuq8j48d28YDpkyobzHE/kJrD/7xJmTB3MjKGsu6 ToSYcvWwkrQufRZReX2PNGrqdAhOI1W52Om5OJriqZj3FC7u++OGv1HXos0EixfwxHaD 2NGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=QCMHKhkVunzbtGiMJ/wq/fYfBgDNCThjx88/COvHDls=; b=nvqrB8NwZ9DjsXI465w2z5tiJMYLjCXWOJ+MnlxnB4oPER2/NeoeheOdpBZ5uVm0uH R9UBAK7Xz1OVDWoUgzix2FTz3WLSN8WtiMsf2T8DVYD4KjGbwvv4KqQWXsTkFCdVA8fE WeipbBaccQ/uSFzSGGCB6b9zeTQY9VoGiR+7re5ez14zCuYNN0sRl/HbwUlWp+851FmB oTDYNR4qBZfMrxxKnQpFi1Hp4zDBkiP9VE0tfIrg9goKBs+AqzbYiHjOtt//o0agM4kO aruTLUB2IuvRYAiZfgE/RxsEnxLhh3qkkpqq4d2Yj/09qNPZw1OOTZhKdXR2w7gofigx mijA== X-Gm-Message-State: ACgBeo0dijxKHWP/Am8sw6WIcjeJr9/Cr59kGODdl2LzFGktnRfkvSLg r08HkgxOEWCvepY4F7aAcGKs1Q== X-Google-Smtp-Source: AA6agR5S+APZgwcw+bIIDVGoAnuC/13B7ipF5b8+EdFoYAALnaA5p2FIyrCTjzHmbNXDwKwD1Go7xg== X-Received: by 2002:a05:6512:238c:b0:48b:132:8392 with SMTP id c12-20020a056512238c00b0048b01328392mr8117244lfv.658.1660737867059; Wed, 17 Aug 2022 05:04:27 -0700 (PDT) Received: from krzk-bin.. (d15l54h48cw7vbh-qr4-4.rev.dnainternet.fi. [2001:14bb:ae:539c:1b1c:14b7:109b:ed76]) by smtp.gmail.com with ESMTPSA id d15-20020a05651221cf00b0048a97042251sm1670496lft.22.2022.08.17.05.04.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Aug 2022 05:04:26 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Lee Jones , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH 09/14] arm64: dts: qcom: sc7280: split TCSR halt regs out of mutex Date: Wed, 17 Aug 2022 15:03:58 +0300 Message-Id: <20220817120403.458000-11-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220817120403.458000-1-krzysztof.kozlowski@linaro.org> References: <20220817120403.458000-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org The TCSR halt regs are next to TCSR mutex, so before converting the TCSR mutex into device with address space, we need to split the halt regs to its own syscon device. This also describes more accurately the devices and their IO address space, and allows to remove incorrect syscon compatible from TCSR mutex: qcom/sc7280-herobrine-crd.dtb: hwlock@1f40000: compatible: ['qcom,tcsr-mutex', 'syscon'] is too long Signed-off-by: Krzysztof Kozlowski --- arch/arm64/boot/dts/qcom/sc7280.dtsi | 19 ++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi index 13d7f267b289..89a8e6b9822a 100644 --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi @@ -2155,12 +2155,17 @@ ipa: ipa@1e40000 { }; tcsr_mutex: hwlock@1f40000 { - compatible = "qcom,tcsr-mutex", "syscon"; - reg = <0 0x01f40000 0 0x40000>; + compatible = "qcom,tcsr-mutex"; + reg = <0 0x01f40000 0 0x20000>; #hwlock-cells = <1>; }; - tcsr: syscon@1fc0000 { + tcsr_1: sycon@1f60000 { + compatible = "qcom,sc7280-tcsr", "syscon"; + reg = <0 0x01f60000 0 0x20000>; + }; + + tcsr_2: syscon@1fc0000 { compatible = "qcom,sc7280-tcsr", "syscon"; reg = <0 0x01fc0000 0 0x30000>; }; @@ -2522,9 +2527,9 @@ remoteproc_mpss: remoteproc@4080000 { <&pdc_reset PDC_MODEM_SYNC_RESET>; reset-names = "mss_restart", "pdc_reset"; - qcom,halt-regs = <&tcsr_mutex 0x23000 0x25000 0x28000 0x33000>; - qcom,ext-regs = <&tcsr 0x10000 0x10004 &tcsr_mutex 0x26004 0x26008>; - qcom,qaccept-regs = <&tcsr_mutex 0x23030 0x23040 0x23020>; + qcom,halt-regs = <&tcsr_1 0x3000 0x5000 0x8000 0x13000>; + qcom,ext-regs = <&tcsr_2 0x10000 0x10004 &tcsr_1 0x6004 0x6008>; + qcom,qaccept-regs = <&tcsr_1 0x3030 0x3040 0x3020>; status = "disabled"; @@ -3259,7 +3264,7 @@ remoteproc_wpss: remoteproc@8a00000 { <&pdc_reset PDC_WPSS_SYNC_RESET>; reset-names = "restart", "pdc_sync"; - qcom,halt-regs = <&tcsr_mutex 0x37000>; + qcom,halt-regs = <&tcsr_1 0x17000>; status = "disabled"; From patchwork Wed Aug 17 12:03:59 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 598203 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 666FCC3F6B0 for ; Wed, 17 Aug 2022 12:04:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239300AbiHQMEx (ORCPT ); Wed, 17 Aug 2022 08:04:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38296 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239261AbiHQMEl (ORCPT ); Wed, 17 Aug 2022 08:04:41 -0400 Received: from mail-lj1-x230.google.com (mail-lj1-x230.google.com [IPv6:2a00:1450:4864:20::230]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EFD4E48EBD for ; Wed, 17 Aug 2022 05:04:28 -0700 (PDT) Received: by mail-lj1-x230.google.com with SMTP id l21so13359617ljj.2 for ; Wed, 17 Aug 2022 05:04:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=G5Gw9O1HRC2HZ2RUee8k0rPKQP+uhhOAxZLOGmh5CkQ=; b=FO6pkLjUvDS7GG3+dFzSYGZfDf/jqiKePe8B9y9yiDTDJCtSzPJYtScOvXgGTpYxSJ HcEJ3tBn34XbI4eHscrmAQDRaytwwXOYG8L6DZdN0DLsoH3lD3sYvRvXjDf7tsDL3Lxu mi3KXPa4mN4j45quv0b0nLakPgll63tmV4JvhICcJ/FAhwDp0f40wCuaha7fK9ASEhUa oDEs/yUILjgjgokjrVY5qO9R7reBi0+FeisMvr9nJ/2XHe6nBDtBNbwRcMJOZmeRlOOH r816zprWZiMRQ7b4Xm/LZIre1x7ldNzaEKEtqjPi51XiK5JkRGZmyy2zwvbCt3hfh2Le +e2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=G5Gw9O1HRC2HZ2RUee8k0rPKQP+uhhOAxZLOGmh5CkQ=; b=m/lvOhggGJh3shjTg3IFXF36cLwKPTmcbfI+Ki2hagadUAcIk1W2IVKY87UMc1cKIG 7NXaZiXmE6LfoK54r9vwY6ApctAUkJT5OgDAO9y6dM22sxKIV3XaPGasPHaCPeYzyGuA 6BEV1YgIfBQxeUFtAvgec5QibaYV2+07NnSbP5VxbmOb0EQxxT2TEl1NLiBE/rykzFKC KxbacmL2Q0qGw0XAWAx9I0eFehPTGr/EnfSSJWSL5iuGh+etb1/uNd2FmMlADAN3Dd3J EgMa7wBpea8MPfzCkwWYwH8kOAo3vxe8z6z8OchsMveJzCB48bu0hlDBANCg+IOw1FAe 7KXQ== X-Gm-Message-State: ACgBeo2rHgd5SnCEx4gMD0qgWHbWPA+upUEW0m265DlFEGgzQvX8FTTj zfa0OGkuxTAds5YtFFHnRw42lw== X-Google-Smtp-Source: AA6agR4IHiOubNO+AQY3O5FQFJEvUcmjobZ70PRwztSjlcEHmpGYy8OKKZMrZ78HD0ApkyktFlQN8Q== X-Received: by 2002:a05:651c:19a7:b0:25f:dcbb:c9d1 with SMTP id bx39-20020a05651c19a700b0025fdcbbc9d1mr8064112ljb.450.1660737868505; Wed, 17 Aug 2022 05:04:28 -0700 (PDT) Received: from krzk-bin.. (d15l54h48cw7vbh-qr4-4.rev.dnainternet.fi. [2001:14bb:ae:539c:1b1c:14b7:109b:ed76]) by smtp.gmail.com with ESMTPSA id d15-20020a05651221cf00b0048a97042251sm1670496lft.22.2022.08.17.05.04.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Aug 2022 05:04:27 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Lee Jones , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH 10/14] arm64: dts: qcom: sdm845: split TCSR halt regs out of mutex Date: Wed, 17 Aug 2022 15:03:59 +0300 Message-Id: <20220817120403.458000-12-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220817120403.458000-1-krzysztof.kozlowski@linaro.org> References: <20220817120403.458000-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org The TCSR halt regs are next to TCSR mutex, so before converting the TCSR mutex into device with address space, we need to split the halt regs to its own syscon device. This also describes more accurately the devices and their IO address space. Signed-off-by: Krzysztof Kozlowski --- arch/arm64/boot/dts/qcom/sdm845.dtsi | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi index f0e286715d1b..21ed14200986 100644 --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi @@ -2590,7 +2590,12 @@ ipa: ipa@1e40000 { tcsr_mutex_regs: syscon@1f40000 { compatible = "syscon"; - reg = <0 0x01f40000 0 0x40000>; + reg = <0 0x01f40000 0 0x20000>; + }; + + tcsr_regs_1: sycon@1f60000 { + compatible = "qcom,sdm845-tcsr", "syscon"; + reg = <0 0x01f60000 0 0x20000>; }; tlmm: pinctrl@3400000 { @@ -3207,7 +3212,7 @@ mss_pil: remoteproc@4080000 { <&pdc_reset PDC_MODEM_SYNC_RESET>; reset-names = "mss_restart", "pdc_reset"; - qcom,halt-regs = <&tcsr_mutex_regs 0x23000 0x25000 0x24000>; + qcom,halt-regs = <&tcsr_regs_1 0x3000 0x5000 0x4000>; power-domains = <&rpmhpd SDM845_CX>, <&rpmhpd SDM845_MX>, From patchwork Wed Aug 17 12:04:00 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 597911 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBEDEC25B08 for ; Wed, 17 Aug 2022 12:04:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239296AbiHQMEv (ORCPT ); Wed, 17 Aug 2022 08:04:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38288 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239259AbiHQMEl (ORCPT ); Wed, 17 Aug 2022 08:04:41 -0400 Received: from mail-lj1-x234.google.com (mail-lj1-x234.google.com [IPv6:2a00:1450:4864:20::234]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 612A74DB0B for ; Wed, 17 Aug 2022 05:04:30 -0700 (PDT) Received: by mail-lj1-x234.google.com with SMTP id z20so13362211ljq.3 for ; Wed, 17 Aug 2022 05:04:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=v+CAkv8Hlyo2PxpwLaCJcPFqOS7vWYe9QQHHKSYzECU=; b=BIe1yai8AxnqH1xCULHo/Dm0+9wX5oQHpkNKEW9N3FM0YIpnB/eekBBEHoyu/2fQHj D0NNjM2bh4MnJ13IH1XqBpBGk2GF+GzuwC8HqnzO+tLFDZvtLdUa2zS8712eV6VzhKQm c6SBILRw31/pIPY20qUe/F979IN7p+CDxXxmHScjgmVFn7x1TuJGkAF26VsyoOkMq5Qr +SOOwqtpGKa8LCHiBAQq5XON3nPIyYOIsg5b5Rf35m7k4EbZtNYHYSciV/XLTjKFZ6xP +2J1TpzZALOZoAKaHsm+Gykzbm6wSCq6kpXhpfJ1Qbgo3fu3NVoFajTCep27Mz6W7rEA 5C4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=v+CAkv8Hlyo2PxpwLaCJcPFqOS7vWYe9QQHHKSYzECU=; b=DHrm5vnF9ZmbuQhz8Teo6aS3XWX+t3N+b4hD0XGMtjUwitDyelkxWBr7FAeDwLORna nzA5EPRwMXiJnVx30dII9UL1sxr5sIJR5ytw0/NH49DbwKwe7Qs+B6iidU+VY+1KOCoI GYfjKvyTUISKlvgdmeRB4dzc07O1cNic5CycDezP9nPnH6mb0cDSekaoORofqGu1nVx0 QS5iHJiby79PT7S0K8dnxFkps+e5LDNgpbK2Q7RzfQp3XGO/sCTrKShIsPUYGF6pTram mbSjferJXMpDxTB4qbBlMaV4YdeVlRIaFJ2FPXaqc8O9fHxGVnNr2EYYB6hmj+2MqGsH Ew5w== X-Gm-Message-State: ACgBeo2qKtEjACHjT4SQVH7zcGewuA2AZFJ8ADcIZzqZrluhZZ7MbCT+ XOwLS3kaCBNGECEt2Xz/zhumNg== X-Google-Smtp-Source: AA6agR4TQRBWxy15ymqHuWCuBX5sSHPtGTKsjhtaZQ1BFvzFN58HPIlUMcLKM7hU3iREL5h32T6BCQ== X-Received: by 2002:a2e:9e56:0:b0:261:7544:d79d with SMTP id g22-20020a2e9e56000000b002617544d79dmr1640455ljk.296.1660737869972; Wed, 17 Aug 2022 05:04:29 -0700 (PDT) Received: from krzk-bin.. (d15l54h48cw7vbh-qr4-4.rev.dnainternet.fi. [2001:14bb:ae:539c:1b1c:14b7:109b:ed76]) by smtp.gmail.com with ESMTPSA id d15-20020a05651221cf00b0048a97042251sm1670496lft.22.2022.08.17.05.04.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Aug 2022 05:04:29 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Lee Jones , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH 11/14] arm64: dts: qcom: sdm845: switch TCSR mutex to MMIO Date: Wed, 17 Aug 2022 15:04:00 +0300 Message-Id: <20220817120403.458000-13-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220817120403.458000-1-krzysztof.kozlowski@linaro.org> References: <20220817120403.458000-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org The TCSR mutex bindings allow device to be described only with address space (so it uses MMIO, not syscon regmap). This seems reasonable as TCSR mutex is actually a dedicated IO address space and it also fixes DT schema checks: qcom/sdm845-shift-axolotl.dtb: hwlock: 'reg' is a required property qcom/sdm845-shift-axolotl.dtb: hwlock: 'syscon' does not match any of the regexes: 'pinctrl-[0-9]+' Signed-off-by: Krzysztof Kozlowski --- arch/arm64/boot/dts/qcom/sdm845.dtsi | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi index 21ed14200986..bd0ec0664283 100644 --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi @@ -919,12 +919,6 @@ compute-cb@8 { }; }; - tcsr_mutex: hwlock { - compatible = "qcom,tcsr-mutex"; - syscon = <&tcsr_mutex_regs 0 0x1000>; - #hwlock-cells = <1>; - }; - smp2p-cdsp { compatible = "qcom,smp2p"; qcom,smem = <94>, <432>; @@ -2588,9 +2582,10 @@ ipa: ipa@1e40000 { status = "disabled"; }; - tcsr_mutex_regs: syscon@1f40000 { - compatible = "syscon"; + tcsr_mutex: hwlock@1f40000 { + compatible = "qcom,tcsr-mutex"; reg = <0 0x01f40000 0 0x20000>; + #hwlock-cells = <1>; }; tcsr_regs_1: sycon@1f60000 { From patchwork Wed Aug 17 12:04:01 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 597910 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CBA8C25B08 for ; Wed, 17 Aug 2022 12:04:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239308AbiHQMEz (ORCPT ); Wed, 17 Aug 2022 08:04:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38088 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239248AbiHQMEo (ORCPT ); Wed, 17 Aug 2022 08:04:44 -0400 Received: from mail-lj1-x22a.google.com (mail-lj1-x22a.google.com [IPv6:2a00:1450:4864:20::22a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2942F52E40 for ; Wed, 17 Aug 2022 05:04:33 -0700 (PDT) Received: by mail-lj1-x22a.google.com with SMTP id w15so13365367ljw.1 for ; Wed, 17 Aug 2022 05:04:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=uPnkJ9CZ7fbXWgaAUcfcWBXaeXKUW7FCT3L0V3onDIA=; b=IDHaSU6pyLGf+5+N3yvRmfRgyJcjMsogzmLS081dmkCfeis8uKnxylfpfJAA8NJXId /XJuDrlcaCU2jMog5sXRjQPaeuX7qOIPFRHnRej6IrbbfsKYLalESvxEwD+jslWDH7IB 3c0+P6nLvaCIcKm3/mowwdy3X1wv9mRbJyMxtihUDHL5pwTkojV6qtLrXhSY3clPW4lg LOxac6hQryRoJbvyJQRaQeIDs4EXY7FjRj+oJQV+72CsfVktzDuW0LzFHfFyKaCM/Ag5 r0gu8lY5HwkAp7JrWSBF9WuD+3gdZmHhyy5/HrUrxu/mUx8hD9NuQGrLxi7MMjlonET0 y/Wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=uPnkJ9CZ7fbXWgaAUcfcWBXaeXKUW7FCT3L0V3onDIA=; b=JGEb7GiqwxJPMwhfWBM1Z4DGZ0YDLyfV1kbLaBDfqG6Y5Ihc2tMyXqS7YACl3qcEwE 1Ad4w8BNkL/A1vbgoI9MrKmoYMIkRl54EMtkYqoNk69lLCuwSg2/3v7zUlP/Tlu79d/+ fJfqizr/jSqq9xr/w7g2LsWG8uta8Tj6OqmY53e0gx6V5t6KHFL76aMRe0n9xwFQoYwc ADwSFpgkkUcLwKRM93Um2ZQK1YTu4K23CG7pZj3EZBNyNb8sn4/+ynnd+YqK2nU3BlbA +V1FN/VJieMomwO6t+/pD2U1Eop24mvQgL7hhVguwANvTgGZSo1aiyXhIssuZTZrTOfU S/OA== X-Gm-Message-State: ACgBeo2XcDStXsicg198Sh2ajJ1NWxHDIso7ei60mDXN+3ydJ2bogNcL miI9sYMS8IXsNjuFrIDM/bHLog== X-Google-Smtp-Source: AA6agR7bIZTAKEEfgXGTIR/qHFIgh5ti3RzKbK9pp9MhdH2pDL2oT/6qOvRuC3eCe51dEpLa8LqWJQ== X-Received: by 2002:a2e:850f:0:b0:25e:67a8:4e11 with SMTP id j15-20020a2e850f000000b0025e67a84e11mr8067779lji.30.1660737871488; Wed, 17 Aug 2022 05:04:31 -0700 (PDT) Received: from krzk-bin.. (d15l54h48cw7vbh-qr4-4.rev.dnainternet.fi. [2001:14bb:ae:539c:1b1c:14b7:109b:ed76]) by smtp.gmail.com with ESMTPSA id d15-20020a05651221cf00b0048a97042251sm1670496lft.22.2022.08.17.05.04.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Aug 2022 05:04:30 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Lee Jones , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH 12/14] arm64: dts: qcom: qcs404: switch TCSR mutex to MMIO Date: Wed, 17 Aug 2022 15:04:01 +0300 Message-Id: <20220817120403.458000-14-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220817120403.458000-1-krzysztof.kozlowski@linaro.org> References: <20220817120403.458000-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org The TCSR mutex bindings allow device to be described only with address space (so it uses MMIO, not syscon regmap). This seems reasonable as TCSR mutex is actually a dedicated IO address space and it also fixes DT schema checks: qcom/qcs404-evb-4000.dtb: hwlock: 'reg' is a required property qcom/qcs404-evb-4000.dtb: hwlock: 'syscon' does not match any of the regexes: 'pinctrl-[0-9]+' Signed-off-by: Krzysztof Kozlowski --- arch/arm64/boot/dts/qcom/qcs404.dtsi | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/qcs404.dtsi b/arch/arm64/boot/dts/qcom/qcs404.dtsi index 9ab990061522..3a94eb2cc448 100644 --- a/arch/arm64/boot/dts/qcom/qcs404.dtsi +++ b/arch/arm64/boot/dts/qcom/qcs404.dtsi @@ -295,12 +295,6 @@ smem { hwlocks = <&tcsr_mutex 3>; }; - tcsr_mutex: hwlock { - compatible = "qcom,tcsr-mutex"; - syscon = <&tcsr_mutex_regs 0 0x1000>; - #hwlock-cells = <1>; - }; - soc: soc@0 { #address-cells = <1>; #size-cells = <1>; @@ -726,9 +720,10 @@ gcc: clock-controller@1800000 { assigned-clock-rates = <19200000>; }; - tcsr_mutex_regs: syscon@1905000 { - compatible = "syscon"; + tcsr_mutex: hwlock@1905000 { + compatible = "qcom,tcsr-mutex"; reg = <0x01905000 0x20000>; + #hwlock-cells = <1>; }; tcsr: syscon@1937000 { From patchwork Wed Aug 17 12:04:02 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 597909 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5DC7C32774 for ; Wed, 17 Aug 2022 12:04:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239282AbiHQME6 (ORCPT ); Wed, 17 Aug 2022 08:04:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38792 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239288AbiHQMEt (ORCPT ); Wed, 17 Aug 2022 08:04:49 -0400 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BF0F1558DB for ; Wed, 17 Aug 2022 05:04:34 -0700 (PDT) Received: by mail-lf1-x12f.google.com with SMTP id a9so18700991lfm.12 for ; Wed, 17 Aug 2022 05:04:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=DqeinnIMS7tnZ1s/F5WbYXe7dS10PhHD2RlaXqtenk4=; b=HA4YX3lATWHZy1PycT9JEiDmaVCC74tJ89+lBTjqcQesxYBXT6y37LEBBk9hjQE1m1 cLisYJI+duLjN0FEqQH0R7h53RyPZLxgcA0Q1AyY/3SmYfsCb4pwk5SGe3yj7MlNk8Bo MiZzcOHR0qLkntxsOPVC9RGn7CoXNqkSgV9gR55uucH3vSASXDp6THl3sZhPsAjAT/fM SiTFRsRTpd0Lm1W+OLhQbbuN0HuZ6VOnWsXoYcluoSbtEuraU07JaVqhYXXvZo6JXKy8 lWIsDaWTsLtcg5m+WyVoXINwchBoMIRMLYJ3b4yNj7IgMl9rfFKThNOTCDjFhNfdSa0G zt7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=DqeinnIMS7tnZ1s/F5WbYXe7dS10PhHD2RlaXqtenk4=; b=JbHCwel5nImE2wbfU9omhtmbH0jZmnF+V/zoRDYdcl34ujsIK/dgHDxL69S5SSv+F7 JLyxgxKh8dVwAWaMnIg5XNU0nptlkv0oiM+ufIa/jgssLpNzK2Gd2mmdvBhq/zG8rh/H u9De+qcnuZBDExZDJ35OykUJb5YbWtfKHbK3jtiZy0KC/3ydbQpYSGuZSDSochzo9Fdc pQlkcYXKpfXAWrsw/zt6iPjLKeNJh685k+GqG7VGtm48H0tUsFu6aYCHCOLkinUEfYxj xcNto5iaDFhD8cjaC39IgH2ekUPkm52IAWBA89aVZ3kgxcwGcbvB6cuGVck1Zd8F0lkQ jDAg== X-Gm-Message-State: ACgBeo1uFBxzqYghS8DSrLlfidZHMUEkab6OLVcQyFaefz+jpVRkFoDu A2F1sOiq7ccl/auZGUdncIvgrQ== X-Google-Smtp-Source: AA6agR6Ad+YVXQ2ESPuMzul02yuxva58dgnkUgd2uhe5MsvfrsJV4vu40ijZIXllqyCSouRi1YOZtA== X-Received: by 2002:a05:6512:6c4:b0:491:c8f9:1994 with SMTP id u4-20020a05651206c400b00491c8f91994mr5822628lff.179.1660737872906; Wed, 17 Aug 2022 05:04:32 -0700 (PDT) Received: from krzk-bin.. (d15l54h48cw7vbh-qr4-4.rev.dnainternet.fi. [2001:14bb:ae:539c:1b1c:14b7:109b:ed76]) by smtp.gmail.com with ESMTPSA id d15-20020a05651221cf00b0048a97042251sm1670496lft.22.2022.08.17.05.04.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Aug 2022 05:04:32 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Lee Jones , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH 13/14] arm64: dts: qcom: sdm630: switch TCSR mutex to MMIO Date: Wed, 17 Aug 2022 15:04:02 +0300 Message-Id: <20220817120403.458000-15-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220817120403.458000-1-krzysztof.kozlowski@linaro.org> References: <20220817120403.458000-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org The TCSR mutex bindings allow device to be described only with address space (so it uses MMIO, not syscon regmap). This seems reasonable as TCSR mutex is actually a dedicated IO address space and it also fixes DT schema checks: qcom/sdm636-sony-xperia-ganges-mermaid.dtb: hwlock: 'reg' is a required property qcom/sdm636-sony-xperia-ganges-mermaid.dtb: hwlock: 'syscon' does not match any of the regexes: 'pinctrl-[0-9]+' Signed-off-by: Krzysztof Kozlowski --- arch/arm64/boot/dts/qcom/sdm630.dtsi | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sdm630.dtsi b/arch/arm64/boot/dts/qcom/sdm630.dtsi index 1bc9091cad2a..40a40d00eae4 100644 --- a/arch/arm64/boot/dts/qcom/sdm630.dtsi +++ b/arch/arm64/boot/dts/qcom/sdm630.dtsi @@ -697,9 +697,10 @@ tsens: thermal-sensor@10ae000 { #thermal-sensor-cells = <1>; }; - tcsr_mutex_regs: syscon@1f40000 { - compatible = "syscon"; - reg = <0x01f40000 0x40000>; + tcsr_mutex: hwlock@1f40000 { + compatible = "qcom,tcsr-mutex"; + reg = <0x01f40000 0x20000>; + #hwlock-cells = <1>; }; tlmm: pinctrl@3100000 { @@ -2351,12 +2352,6 @@ intc: interrupt-controller@17a00000 { }; }; - tcsr_mutex: hwlock { - compatible = "qcom,tcsr-mutex"; - syscon = <&tcsr_mutex_regs 0 0x1000>; - #hwlock-cells = <1>; - }; - sound: sound { }; From patchwork Wed Aug 17 12:04:03 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 598202 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEE15C25B08 for ; Wed, 17 Aug 2022 12:04:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239240AbiHQME4 (ORCPT ); Wed, 17 Aug 2022 08:04:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38658 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239282AbiHQMEr (ORCPT ); Wed, 17 Aug 2022 08:04:47 -0400 Received: from mail-lj1-x22f.google.com (mail-lj1-x22f.google.com [IPv6:2a00:1450:4864:20::22f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D926B57202 for ; Wed, 17 Aug 2022 05:04:34 -0700 (PDT) Received: by mail-lj1-x22f.google.com with SMTP id z20so13362446ljq.3 for ; Wed, 17 Aug 2022 05:04:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=GGC6/FAtFLtsPec3v0Z//ulLsaLmio7LVXcsIKWCfDM=; b=miMj+avNVe2LIWr1HvJA4rGseGDIOeygunPdCMBN6CSnZr4fZvx1MS7rw6GUgMhxyg nSN1YKLeXmDvVX8VfYcgxDVCZNdAmWzyqwCfgEtSYumifD1B2mrenI0UyZJNw09CXFEk 5SzgDvS6O5xTedd1yXhWCDDr4y6LLmMmvYYEZ/MpUCubbVcM911wrnIicI/IWgI7FO4q 7VaEcQiKliQ6RyNkAcm5vDWX3vwAjSHG8dW5QPjlDOQwvcJTUk4njD+QpsWG2qwo26pA id3OXB7qggMKuwKb57RbdptQkVxbBZwBxHOBbpqEh9wW8kIEpVrmv0FY5kNYa4rvdS+Y oiIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=GGC6/FAtFLtsPec3v0Z//ulLsaLmio7LVXcsIKWCfDM=; b=ws6gDcWH0uZ75WIlW4xiVn1UKeRmNg/E+STJgr7zBrSA6xsyyIMlNoDHhe5VVty0J8 yZ0ffxpsY9Rb3DmulVo7lVRwxPdPBEHd0bj8cJP3X4kGXHhtVsK2ZGbtHGvbAwD3WS6a MdfE0qukAaUdY2eG30U8RqfSjabzrH7XOp4zyJTWNzbPzLBqdC8Se3EhhXQMeoOgLPZ6 TtcIQ7CZ8z4qGuPfROWhfQTqAo8HWm8K6Sf8um35zazErH7nPfZmVB+xS2QSYyKwKT81 6eJTwZAjHvdInaS065hxOb+4ZYY0ArbHIan24QeuNH/zRKz3nL9megeT1fpbMkp/xWFI NUXQ== X-Gm-Message-State: ACgBeo3g0vZKIxuwI/z+vCm5Ozylu+Wo53b/LVtAJ2xSk3whi3Tlb5z9 KE/xFtT6X5P0bbWGU1r6Cn6/pXGaw508RDk2 X-Google-Smtp-Source: AA6agR7gyE2mBf2oCkQu9AfMIjk25LfntH6SuRYtq8dw+mhllXqptMMvleWmyxNwiDl4Z/Wens5vAA== X-Received: by 2002:a2e:bea8:0:b0:25f:e9ab:5a1b with SMTP id a40-20020a2ebea8000000b0025fe9ab5a1bmr7549871ljr.448.1660737874403; Wed, 17 Aug 2022 05:04:34 -0700 (PDT) Received: from krzk-bin.. (d15l54h48cw7vbh-qr4-4.rev.dnainternet.fi. [2001:14bb:ae:539c:1b1c:14b7:109b:ed76]) by smtp.gmail.com with ESMTPSA id d15-20020a05651221cf00b0048a97042251sm1670496lft.22.2022.08.17.05.04.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Aug 2022 05:04:33 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Lee Jones , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH 14/14] arm64: dts: qcom: sm8150: switch TCSR mutex to MMIO Date: Wed, 17 Aug 2022 15:04:03 +0300 Message-Id: <20220817120403.458000-16-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220817120403.458000-1-krzysztof.kozlowski@linaro.org> References: <20220817120403.458000-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org The TCSR mutex bindings allow device to be described only with address space (so it uses MMIO, not syscon regmap). This seems reasonable as TCSR mutex is actually a dedicated IO address space and it also fixes DT schema checks: qcom/sm8150-mtp.dtb: hwlock: 'reg' is a required property qcom/sm8150-mtp.dtb: hwlock: 'syscon' does not match any of the regexes: 'pinctrl-[0-9]+' Signed-off-by: Krzysztof Kozlowski --- arch/arm64/boot/dts/qcom/sm8150.dtsi | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi index 7d509ecd44da..dc6770391813 100644 --- a/arch/arm64/boot/dts/qcom/sm8150.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi @@ -585,12 +585,6 @@ scm: scm { }; }; - tcsr_mutex: hwlock { - compatible = "qcom,tcsr-mutex"; - syscon = <&tcsr_mutex_regs 0 0x1000>; - #hwlock-cells = <1>; - }; - memory@80000000 { device_type = "memory"; /* We expect the bootloader to fill in the size */ @@ -2054,9 +2048,10 @@ ipa_virt: interconnect@1e00000 { qcom,bcm-voters = <&apps_bcm_voter>; }; - tcsr_mutex_regs: syscon@1f40000 { - compatible = "syscon"; - reg = <0x0 0x01f40000 0x0 0x40000>; + tcsr_mutex: hwlock@1f40000 { + compatible = "qcom,tcsr-mutex"; + reg = <0 0x01f40000 0 0x20000>; + #hwlock-cells = <1>; }; remoteproc_slpi: remoteproc@2400000 {