From patchwork Wed Feb 6 23:36:46 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cole Robinson X-Patchwork-Id: 157669 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp7002371jaa; Wed, 6 Feb 2019 15:37:08 -0800 (PST) X-Google-Smtp-Source: AHgI3IbLhMNhKw0IEZLuvCLDgXDCSndMA2uieYtZ/pnIEEs51WuaoT6pmxKDySie7tNIjVXkuaJR X-Received: by 2002:a37:b405:: with SMTP id d5mr9295375qkf.162.1549496228245; Wed, 06 Feb 2019 15:37:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549496228; cv=none; d=google.com; s=arc-20160816; b=ZXF8uLiHAiFSM1ed8cHovHP69b3WFj7GMhCPzFPe3cR2KtArruU6kQs2ELh0lyM+SQ nR9K/mI43N6pFeVBVqk7wW6/wSgDB5C96ahO2qCwMNLnAaWClAVHn9fk9c1314Qb1Khj nJ3uN9q0CntJ8JhNIC8lKjuomncw+A3GkMfUORGnLhYMK36VyRwYcRDInhJ4xoVVL228 YfgVg1VOBCj/9xtBameeC6Co4Ty9SIXdqkiL59SyHeL70XJD0H7+h1Iq+K7lD6PMEale JQNKPve2B7hiqHHv0s892/6/O+yWl+u4aBlI7Ic2TiNlJmU0CYKB57CGfTHMWTyxI0Y1 mn8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:sender:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:message-id:date:to:from:delivered-to; bh=xNoXAiwTfl4oFIkhTCVE7+WKOsoChstRu3epvGmRCIQ=; b=Q2Xd/JdSOfG1p98oYPp/Umh44ZQpmbDPulC9M641TvtxxqajU0Rz/bprCRN1WLmX93 N9wvirjuBSs3vm1xw4JutKWK6QY9c4n4DyDRbdBtEgLj78c5KtAujmWNiZzGNamF2NxK FN5HgrPy7GbIscnsAtUiKMNqZvUYo4dnjLa/TmBKHDTfYSz4siPEGH3jheqAjG+PbaeS 7m7sdOQQjN9tkRqnUPyiG86/U788bJsGmVphwg36OVpd299kpyyh78SJkQlAvaz3JU4t Sd1YklYUr1pU6iog6u1bAbZpSjL+2/v2aUkmnpnoCofpBDXs1EY6n2mhOcNYBqhxGdyS tu7g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of libvir-list-bounces@redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com. [209.132.183.28]) by mx.google.com with ESMTPS id e3si559406qtj.41.2019.02.06.15.37.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 06 Feb 2019 15:37:08 -0800 (PST) Received-SPF: pass (google.com: domain of libvir-list-bounces@redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; Authentication-Results: mx.google.com; spf=pass (google.com: domain of libvir-list-bounces@redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 78E9B2D7F8; Wed, 6 Feb 2019 23:37:05 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8986E451C; Wed, 6 Feb 2019 23:37:03 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id E94B118033A7; Wed, 6 Feb 2019 23:36:59 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x16Nawjf029350 for ; Wed, 6 Feb 2019 18:36:58 -0500 Received: by smtp.corp.redhat.com (Postfix) id 5E289660D4; Wed, 6 Feb 2019 23:36:58 +0000 (UTC) Delivered-To: libvirt-list@redhat.com Received: from worklaptop.redhat.com (ovpn-124-233.rdu2.redhat.com [10.10.124.233]) by smtp.corp.redhat.com (Postfix) with ESMTP id A25A85C5FD; Wed, 6 Feb 2019 23:36:54 +0000 (UTC) From: Cole Robinson To: libvirt-list@redhat.com Date: Wed, 6 Feb 2019 18:36:46 -0500 Message-Id: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH] docs: storage: owner/group default to libvirtd UID/GID X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Wed, 06 Feb 2019 23:37:07 +0000 (UTC) Commit fafcc818f changed the docs to say that when creating a pool directory or file volume with no owner/group specified, they will be inherited from the parent directory. This isn't correct now and doesn't seem to have ever been correct In reality default owner/group is whatever UID/GID libvirtd is running as Signed-off-by: Cole Robinson --- docs/formatstorage.html.in | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) -- 2.20.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list diff --git a/docs/formatstorage.html.in b/docs/formatstorage.html.in index 6ebd23549f..968651330f 100644 --- a/docs/formatstorage.html.in +++ b/docs/formatstorage.html.in @@ -478,8 +478,8 @@ The owner element contains the numeric user ID. The group element contains the numeric group ID. If owner or group aren't specified when - creating a directory, the values are inherited from the parent - directory. The label element contains the MAC (eg SELinux) + creating a directory, the UID and GID of the libvirtd process are used. + The label element contains the MAC (eg SELinux) label string. Since 0.4.1 For running directory or filesystem based pools, these fields @@ -776,8 +776,8 @@ The owner element contains the numeric user ID. The group element contains the numeric group ID. If owner or group aren't specified when - creating a supported volume, the values are inherited from the parent - directory. The label element contains the MAC (eg SELinux) + creating a supported volume, the UID and GID of the libvirtd process + are used. The label element contains the MAC (eg SELinux) label string. For existing directory or filesystem based volumes, these fields will be filled with the values used by the existing file.