From patchwork Fri Feb 22 06:05:03 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 158982 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp1365047jaa; Thu, 21 Feb 2019 22:23:28 -0800 (PST) X-Google-Smtp-Source: AHgI3IbdsvOeqSnEPZnNIDqNwK1d+YnZYa3t++bdTyOfUOiHjQngKxdy/4++dE/Cjs4XXdB4hLtt X-Received: by 2002:a81:a047:: with SMTP id x68mr1886114ywg.349.1550816608021; Thu, 21 Feb 2019 22:23:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550816608; cv=none; d=google.com; s=arc-20160816; b=ecMjPsrDnHatw0YDjMronZIC2L+SsjPdv2RnMD2owbIpydjy+lVmyPWo6aMBkLBaM0 z8ZkA9MWfZt5ywPxfF8GM26PXifes9Wr8oBSoqACwebwk0mwybEzL2yTMxuJP5JhAXge YJyWR4WG9Yi0pR3Cgz1P01YHz07Kv7rYdXG/phtMYNOFImRUTsstNP9S4reVpPvUIK49 gwgxuP9vxiRK/CCk7qUNuOdKj6bsP3Xn5L274nRu5np0jGu/0QLwb21TeW/ehHJ5Bino /fmf7hE5G00KYzXRsOftm9vcyxHfC0oG6UaLb5tj/TefNRuoFliyN3jJBuYKw+o+2yFw 8LYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=1flVDEQCS0M6/uS6G96UIV9P7m5civ+pa52oxRwu3L0=; b=nzw9kSCPD0ZHeUePx2hMIOlrhR56L+jbyQ96YPwd2yL0HdyCja0AUPmqB8vQnuCaxU xW7FaplZGE5IMMwSB5w994djKeJ72ER87PwJ0uqzty24Wc2P1wxc9cCmIisyp014kobw Lrkkf/FfsSdvq13vG/zeLVBh71lkp+srm86o0huTZ+dGrTy/hVK/1tbjIvwQRSJDDRVJ ovbLkW1877Avf39mVLDgc7sXMtxCijWT/d6hE741KQOCAW56UifJ/E33Bz9EB/diILQ/ WYirLK5NW2kjYZX0M7Nm9eSg/G73DIgGlLNXd++k2AuP2VTleci2775Vy7j05GSFaSXP P0VA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=JVmcuZmW; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d63si335953ybh.33.2019.02.21.22.23.27 for (version=TLS1 cipher=AES128-SHA bits=128/128); Thu, 21 Feb 2019 22:23:28 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=JVmcuZmW; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([127.0.0.1]:44963 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gx4F5-0005gJ-B8 for patch@linaro.org; Fri, 22 Feb 2019 01:23:27 -0500 Received: from eggs.gnu.org ([209.51.188.92]:42254) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gx4Aq-0002zB-RD for qemu-devel@nongnu.org; Fri, 22 Feb 2019 01:19:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gx3xs-0003H2-7m for qemu-devel@nongnu.org; Fri, 22 Feb 2019 01:05:40 -0500 Received: from mail-pl1-x641.google.com ([2607:f8b0:4864:20::641]:46009) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gx3xr-00030H-St for qemu-devel@nongnu.org; Fri, 22 Feb 2019 01:05:40 -0500 Received: by mail-pl1-x641.google.com with SMTP id r14so580125pls.12 for ; Thu, 21 Feb 2019 22:05:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references; bh=1flVDEQCS0M6/uS6G96UIV9P7m5civ+pa52oxRwu3L0=; b=JVmcuZmW4H8YZO42q6SHDUquYl3VMB3zvjlBomUqDHUV7c+pxVpaWeXMoVyZD3Fl/c 1HQGhWYopMLNFhuBpWC5G0AD98pP/9REql+Nv2tA584mKTt4ZhhoMVm2fnUfTFo4Z70E u0EEipKExex8pkQaxtK2WtxQx8dyv1R69voY+JgT5KAMv+K+/xQ7AGjMA3F0q42JI0gQ 4O/vmW8hVY/HthrX8Q63L3KXBM1Fi0Ct1LGHPb4zbJE5GmGkJU7HXzfocgrk9LISEiVf kG+xKW0Tv9XaWYlR3HL9gpAq/dlNXyRBjzXtZtT3ysdYePknYC0uScY6WJOZpsW74cHT HLTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=1flVDEQCS0M6/uS6G96UIV9P7m5civ+pa52oxRwu3L0=; b=lSBBkMMrDMheXBJ/CvvxGfK00gdQB0B8C37FyvPk3yzQlpp515cZ8o3WK2W5rvujql cKI1M5sAk6UX/aeEdweKZyraMcF5+18vBta0ZSbnMZFuoVMA3Vke/obqe38bQzuHlJyx YHYkIWKCc9UdG2qH9V8HuiflyiMUuh0815hYpD0nTsmtG12EGS8G+TOWk5B5j7pEHLzb i0hwRYojEvmCJmRuJqwjMsv7ScDJlSpcTobtzCOEgfF5hOZ84BAh809gXd5VvGg0EHIm dEF/lsKyBUtRziNw1Y+af/yvASYNwFMtQb1S3j1i6gY855HKCWoJPITSculPfVGGFqsO RsRg== X-Gm-Message-State: AHQUAuZKod9/zc1ggbkTR7wzO4xk8UnyO/0/36xHr9dcPIMrDffx9m+y tYfMHE6VSwsHQR+1HpLd8MgDrnmng2Q= X-Received: by 2002:a17:902:2aaa:: with SMTP id j39mr2546073plb.335.1550815507888; Thu, 21 Feb 2019 22:05:07 -0800 (PST) Received: from cloudburst.twiddle.net (97-113-188-82.tukw.qwest.net. [97.113.188.82]) by smtp.gmail.com with ESMTPSA id f67sm1452522pfc.141.2019.02.21.22.05.06 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 21 Feb 2019 22:05:07 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Date: Thu, 21 Feb 2019 22:05:03 -0800 Message-Id: <20190222060504.17715-2-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20190222060504.17715-1-richard.henderson@linaro.org> References: <20190222060504.17715-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::641 Subject: [Qemu-devel] [PATCH 1/2] target/hppa: Do not return freed temporary X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" For priv levels 1 & 2, we were doing so from do_ibranch_priv. Signed-off-by: Richard Henderson --- target/hppa/translate.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) -- 2.17.2 Reviewed-by: Philippe Mathieu-Daudé diff --git a/target/hppa/translate.c b/target/hppa/translate.c index b4fd307b77..dad8ce563c 100644 --- a/target/hppa/translate.c +++ b/target/hppa/translate.c @@ -2007,16 +2007,15 @@ static TCGv_reg do_ibranch_priv(DisasContext *ctx, TCGv_reg offset) /* Privilege 0 is maximum and is allowed to decrease. */ return offset; case 3: - /* Privilege 3 is minimum and is never allowed increase. */ + /* Privilege 3 is minimum and is never allowed to increase. */ dest = get_temp(ctx); tcg_gen_ori_reg(dest, offset, 3); break; default: - dest = tcg_temp_new(); + dest = get_temp(ctx); tcg_gen_andi_reg(dest, offset, -4); tcg_gen_ori_reg(dest, dest, ctx->privilege); tcg_gen_movcond_reg(TCG_COND_GTU, dest, dest, offset, dest, offset); - tcg_temp_free(dest); break; } return dest; From patchwork Fri Feb 22 06:05:04 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 158980 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp1363487jaa; Thu, 21 Feb 2019 22:21:05 -0800 (PST) X-Google-Smtp-Source: AHgI3IYFq5E5T34KxCYYKkT8v/7vF8hOqRQk64qJ9iT0GKcGD6IszED8DHQw3pjCkCwNeHtDnd5X X-Received: by 2002:a81:5683:: with SMTP id k125mr1837073ywb.436.1550816465171; Thu, 21 Feb 2019 22:21:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550816465; cv=none; d=google.com; s=arc-20160816; b=KMzSIe1CoJ6pZHwwsCrXzm1PIZ7VlG/mdCfG3e8kbRUZ6lg3FH3wrahTvBheqzN7qk eL+7IwYA8psEb2BQpI30CVi4mQRCay2sS9geiQ4HrtFz4V7VKKjlh9wZnZqZqryYMFNV DrJu+5ulkU3xMtJ8Ge9lwg23KHSCpOUn2A8m10271AmuvRnzV9W3DR3F3mb6eelecBgD G7xw++/H4ZtyDSihCdAiSvbqC1pwiIEYyr9PKOyJGr+2YJ1L2fOCq3LAni3ZCV7CyKEe jTEjPoGM2h4mJZgWrtuL29uv0EP17Bh7wEptegKFCuS3peTOSX7eGbtfJZFBTXJ5W1o3 vOrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=bcf2IQqo75AMjcdI4rvvJF4BoU4PKjmYFCofFsd1Jww=; b=GeZQ7zablpdXguCIyymI1A7rekNCitUkliXYvYHiO/fU6nIqAAfc7pDb4HFbp42MqY DgbtzTiyjIMrLAFICc7HbEsXr7gLQlwNOB6edbouXY/y94XTwIlG+fopn/AtPbkzxZnj 4Fn3f+2R12ETOuhMHY+9V+pMDd6oDbCBCdUBwz2zrgLMxZrO5Xxn+l7ytvoEoKoNxn9t b6JObut/NrQfrrOwh/ckbShCscu4FMDOACayV2eU3Jm0zLeW+TrFF9sEkyVap4uV6vTd yuf5ONAgLETvlLhcBKwWiqjouJZ++jsPt8XqNyVFwzOTJ+8VM2WoURmiESLDWUPtIpNy jXXA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=GGHEg5e+; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id g15si335887ybk.482.2019.02.21.22.21.05 for (version=TLS1 cipher=AES128-SHA bits=128/128); Thu, 21 Feb 2019 22:21:05 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=GGHEg5e+; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([127.0.0.1]:44927 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gx4Cm-0003eD-NC for patch@linaro.org; Fri, 22 Feb 2019 01:21:04 -0500 Received: from eggs.gnu.org ([209.51.188.92]:42254) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gx4Ap-0002zB-T0 for qemu-devel@nongnu.org; Fri, 22 Feb 2019 01:19:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gx3xt-0003Ie-Ab for qemu-devel@nongnu.org; Fri, 22 Feb 2019 01:05:42 -0500 Received: from mail-pg1-x536.google.com ([2607:f8b0:4864:20::536]:32983) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gx3xt-00031b-1Q for qemu-devel@nongnu.org; Fri, 22 Feb 2019 01:05:41 -0500 Received: by mail-pg1-x536.google.com with SMTP id h11so634340pgl.0 for ; Thu, 21 Feb 2019 22:05:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references; bh=bcf2IQqo75AMjcdI4rvvJF4BoU4PKjmYFCofFsd1Jww=; b=GGHEg5e+fgpMcgNo52Qi1W4ZWdn6oH17+0pxBmE9tkA4ui0sGng6dqseuwlt4fx3mg WqUfkO6ojZfQ0gEJH097ak3T30qiIVIYsEqYFGqD8QFW8h0AoeUxn/yBabz7V3wqEbMp yi5DFBIjcz13QivIi6KZyz9eVriiqMLPFevi0oiHKAXyMm5h6apyWm8aO0GvyIw/PqSv Tt/upNKRTGi7S3DW1zfaI8OlBJ15U5VwHlVxyp3JVnx3krknrxGo/eUEDMuEqtZcQB/o Vgo1KJ7bA1wBjcNOR3MpWS3iSjmCnYmeyUG+0uE7G86nuZp47264fabOPYcFo/P+vLUL dbxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=bcf2IQqo75AMjcdI4rvvJF4BoU4PKjmYFCofFsd1Jww=; b=ZsXgOqgScs89/Qzz5zZEMID+JtuUc8y9iX9IOKhTTDUKPrsNnLN0RLMay7kxkOi8Nq amzRhFNkY4vpe58rUwl2yTBUQiPGJ/WwgayDASum6uZetiiJsoYMQziY7etvTPC4FFQm IPTie/rb8X9Ef1JKhKaSOpBMy9TDGdZU8uiVnVYfrALHiXz8uc2xhALUA0vzzrLAESx6 cKOjp9QOELtPPbTGFkKmMxeiQx/4D0s+ttkg4CpMGkYw8RDde2LTuM8A2Si3n/BnKp4r 9e9mdXhq0JZ4r6Nk0DJkL85DL5Ibq62npjNDJ2lE5r1Jqa1u3sG/Q8kyoc4YSbijTW3u rKsg== X-Gm-Message-State: AHQUAuY90W1O6IubhPuOfsZuvSGWiPwSzIXb6F+QvnTnHF/kncoutMz5 Boxyj/rhl5IkBl823pMEHJDA/qYGtGY= X-Received: by 2002:a63:6a47:: with SMTP id f68mr2398141pgc.82.1550815508977; Thu, 21 Feb 2019 22:05:08 -0800 (PST) Received: from cloudburst.twiddle.net (97-113-188-82.tukw.qwest.net. [97.113.188.82]) by smtp.gmail.com with ESMTPSA id f67sm1452522pfc.141.2019.02.21.22.05.07 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 21 Feb 2019 22:05:08 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Date: Thu, 21 Feb 2019 22:05:04 -0800 Message-Id: <20190222060504.17715-3-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20190222060504.17715-1-richard.henderson@linaro.org> References: <20190222060504.17715-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::536 Subject: [Qemu-devel] [PATCH 2/2] target/hppa: Optimize blr r0,rn X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" We can eliminate an extra TB in this case, which merely loads a "return address" into rn. Signed-off-by: Richard Henderson --- target/hppa/translate.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) -- 2.17.2 diff --git a/target/hppa/translate.c b/target/hppa/translate.c index dad8ce563c..dc5636fe94 100644 --- a/target/hppa/translate.c +++ b/target/hppa/translate.c @@ -3488,12 +3488,16 @@ static bool trans_b_gate(DisasContext *ctx, arg_b_gate *a) static bool trans_blr(DisasContext *ctx, arg_blr *a) { - TCGv_reg tmp = get_temp(ctx); - - tcg_gen_shli_reg(tmp, load_gpr(ctx, a->x), 3); - tcg_gen_addi_reg(tmp, tmp, ctx->iaoq_f + 8); - /* The computation here never changes privilege level. */ - return do_ibranch(ctx, tmp, a->l, a->n); + if (a->x) { + TCGv_reg tmp = get_temp(ctx); + tcg_gen_shli_reg(tmp, load_gpr(ctx, a->x), 3); + tcg_gen_addi_reg(tmp, tmp, ctx->iaoq_f + 8); + /* The computation here never changes privilege level. */ + return do_ibranch(ctx, tmp, a->l, a->n); + } else { + /* BLR R0,RX is a good way to load PC+8 into RX. */ + return do_dbranch(ctx, ctx->iaoq_f + 8, a->l, a->n); + } } static bool trans_bv(DisasContext *ctx, arg_bv *a)