From patchwork Mon Oct 10 12:07:35 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cezary Rojewski X-Patchwork-Id: 614247 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 05B1DC433F5 for ; Mon, 10 Oct 2022 11:53:03 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 1F62728EB; Mon, 10 Oct 2022 13:52:11 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 1F62728EB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1665402781; bh=4YdFMjhM1DtFAFfOtuD42QSIi2KGcULvygjiUYi2suk=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=fYPVq5fJSPNB1xeWBO8uXVUGkhT4SL8PMZU/EZkCyVnBcD81tnWnc6m0elB3QHQrH /C4+M1xEfBHz6s51fLqMYacPdasSHdHDKFu4KaZnVp141k5gT5Y4VPbhwYfXxbkZQD PR7w/dRYg/9pY28vRgCDtzF8eWgKIv86EZeP83R0= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id F1F83F80542; Mon, 10 Oct 2022 13:51:47 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 798FEF80155; Mon, 10 Oct 2022 13:51:46 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id E9B36F80155 for ; Mon, 10 Oct 2022 13:51:39 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz E9B36F80155 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="FFim7i2l" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665402701; x=1696938701; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=4YdFMjhM1DtFAFfOtuD42QSIi2KGcULvygjiUYi2suk=; b=FFim7i2lFUiljPC+hetTFfmLHpKtrfbwDeGcNaIffuxfJWMmOMvK+t8H uHSh/fwHGkLX/1E5sHHtOedkLnbezdgqodxOdEof9Nhtncf6h/RZwEqQx UpaMZpXQCQCwX3OqcvDy196tPuewLfZPLPrC4iPYK7FN92MKN7RollbQj MPLduhNczrKTmiFI73o77bFeW0lNuQdj+SfKKjAWUdDYVma5ZZGrp+Ix2 tDqL9C/Y6oW9vhWANqwVFd2Io20DZ7zY3cBdQBvsvedAWKW7MWzrri2+t E+EM/ngFxhvXalkCz4/hHcSuo3x2S1I9AC0jvG1lZSJQRoGHx0Oow6WIo g==; X-IronPort-AV: E=McAfee;i="6500,9779,10495"; a="390513204" X-IronPort-AV: E=Sophos;i="5.95,173,1661842800"; d="scan'208";a="390513204" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Oct 2022 04:51:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10495"; a="954889035" X-IronPort-AV: E=Sophos;i="5.95,173,1661842800"; d="scan'208";a="954889035" Received: from crojewsk-ctrl.igk.intel.com ([10.102.9.28]) by fmsmga005.fm.intel.com with ESMTP; 10 Oct 2022 04:51:36 -0700 From: Cezary Rojewski To: alsa-devel@alsa-project.org, broonie@kernel.org Subject: [PATCH 01/15] ASoC: Intel: avs: Fix DMA mask assignment Date: Mon, 10 Oct 2022 14:07:35 +0200 Message-Id: <20221010120749.716499-2-cezary.rojewski@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221010120749.716499-1-cezary.rojewski@intel.com> References: <20221010120749.716499-1-cezary.rojewski@intel.com> MIME-Version: 1.0 Cc: Cezary Rojewski , pierre-louis.bossart@linux.intel.com, tiwai@suse.com, hdegoede@redhat.com, amadeuszx.slawinski@linux.intel.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Spelling error leads to incorrect behavior when setting up DMA mask. Fixes: a5bbbde2b81e ("ASoC: Intel: avs: Use helper function to set up DMA") Signed-off-by: Cezary Rojewski --- sound/soc/intel/avs/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/intel/avs/core.c b/sound/soc/intel/avs/core.c index c50c20fd681a..58db13374166 100644 --- a/sound/soc/intel/avs/core.c +++ b/sound/soc/intel/avs/core.c @@ -440,7 +440,7 @@ static int avs_pci_probe(struct pci_dev *pci, const struct pci_device_id *id) if (bus->mlcap) snd_hdac_ext_bus_get_ml_capabilities(bus); - if (!dma_set_mask_and_coherent(dev, DMA_BIT_MASK(64))) + if (dma_set_mask_and_coherent(dev, DMA_BIT_MASK(64))) dma_set_mask_and_coherent(dev, DMA_BIT_MASK(32)); dma_set_max_seg_size(dev, UINT_MAX); From patchwork Mon Oct 10 12:07:36 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cezary Rojewski X-Patchwork-Id: 613794 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 08062C433FE for ; Mon, 10 Oct 2022 11:53:10 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 2B9D028DD; Mon, 10 Oct 2022 13:52:18 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 2B9D028DD DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1665402788; bh=WITP0r5AgZxlVo1fQXrFXmw6o2iVJQ0gaMwaR+xtqFY=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=LA3Li4HJX7YcnNjJwXy9nSYkOm0fXqn7x69nWts78SNPAszLrVSNS/bAQaw/Llt2m dtmhan/9030xA15AJsxySQWXYfz6asoYfnaWCGk9gYtobZYNpwkqIF8bEQ+8hKvrU4 DhCUHNxvfqojIPJQHw/B2ql34qmRrhLlkD2CzPKM= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id E7C79F80548; Mon, 10 Oct 2022 13:51:49 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 69A7DF80543; Mon, 10 Oct 2022 13:51:47 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 98628F800B8 for ; Mon, 10 Oct 2022 13:51:40 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 98628F800B8 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="KHR8eOTj" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665402701; x=1696938701; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=WITP0r5AgZxlVo1fQXrFXmw6o2iVJQ0gaMwaR+xtqFY=; b=KHR8eOTjDeHsE4p/ZCdLj3fpxwhELcfOZy9WZoHgOmEA7NsykXrlXr4P PK7azGaq66ol6Ao64Aw0Li/LHP4wdqhw+M/EWau5Iq9jw2GD+iW89sLcE i5w456vaCyecwYcpNutFNWs0eHCdgihoztD8i2aUolDEBm3Zl0KWp2aFQ lUIXDYZl/kgZ8kjBfWya7jwWBldem6CVztFF/J/CDWa6/Rjn+Y3q3cAeR teYxUF+5K6eX6aWS3H1oyoPdK80ggvkLvtwFukql6tn0VPBkuT/mBtPag AKepem49wNfulVyEKqtVSOe1E3Ue9KSQTNxbX9G/CgfyyGhDgIOJuDB3J A==; X-IronPort-AV: E=McAfee;i="6500,9779,10495"; a="390513215" X-IronPort-AV: E=Sophos;i="5.95,173,1661842800"; d="scan'208";a="390513215" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Oct 2022 04:51:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10495"; a="954889042" X-IronPort-AV: E=Sophos;i="5.95,173,1661842800"; d="scan'208";a="954889042" Received: from crojewsk-ctrl.igk.intel.com ([10.102.9.28]) by fmsmga005.fm.intel.com with ESMTP; 10 Oct 2022 04:51:38 -0700 From: Cezary Rojewski To: alsa-devel@alsa-project.org, broonie@kernel.org Subject: [PATCH 02/15] ASoC: Intel: avs: Fix potential RX buffer overflow Date: Mon, 10 Oct 2022 14:07:36 +0200 Message-Id: <20221010120749.716499-3-cezary.rojewski@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221010120749.716499-1-cezary.rojewski@intel.com> References: <20221010120749.716499-1-cezary.rojewski@intel.com> MIME-Version: 1.0 Cc: Cezary Rojewski , CoolStar , pierre-louis.bossart@linux.intel.com, tiwai@suse.com, hdegoede@redhat.com, amadeuszx.slawinski@linux.intel.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" If an event caused firmware to return invalid RX size for LARGE_CONFIG_GET, memcpy_fromio() could end up copying too many bytes. Fix by utilizing min_t(). Reported-by: CoolStar Fixes: f14a1c5a9f83 ("ASoC: Intel: avs: Add module management requests") Signed-off-by: Cezary Rojewski --- sound/soc/intel/avs/ipc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sound/soc/intel/avs/ipc.c b/sound/soc/intel/avs/ipc.c index 020d85c7520d..77da206f7dbb 100644 --- a/sound/soc/intel/avs/ipc.c +++ b/sound/soc/intel/avs/ipc.c @@ -192,7 +192,8 @@ static void avs_dsp_receive_rx(struct avs_dev *adev, u64 header) /* update size in case of LARGE_CONFIG_GET */ if (msg.msg_target == AVS_MOD_MSG && msg.global_msg_type == AVS_MOD_LARGE_CONFIG_GET) - ipc->rx.size = msg.ext.large_config.data_off_size; + ipc->rx.size = min_t(u32, AVS_MAILBOX_SIZE, + msg.ext.large_config.data_off_size); memcpy_fromio(ipc->rx.data, avs_uplink_addr(adev), ipc->rx.size); trace_avs_msg_payload(ipc->rx.data, ipc->rx.size); From patchwork Mon Oct 10 12:07:37 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Cezary Rojewski X-Patchwork-Id: 613793 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 83DE5C433F5 for ; Mon, 10 Oct 2022 11:53:43 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id AAB822909; Mon, 10 Oct 2022 13:52:51 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz AAB822909 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1665402821; bh=QilF8Z7n8eLNvp+KakVg1PclRY0/AM3rUFbAPwChosc=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=NcKp0lS2ZlnBKAy/IOtlumk0zibLGhm8lTXQg2i/h0A8Gw4+6esH1aIttdYyxRILN WvP5LfQUpaO8y02H+j1YdmERhRQzfbUEJQMr8hbwtaczMn0XbY5OVpD5yFibSXk8zk rQXnYQlmnjdxg5/tL/jr3rQipNJfoUTZuMyTmBTY= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 136B2F8055B; Mon, 10 Oct 2022 13:51:54 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 342A9F80553; Mon, 10 Oct 2022 13:51:52 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 408A1F80256 for ; Mon, 10 Oct 2022 13:51:42 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 408A1F80256 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="D866FxD2" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665402703; x=1696938703; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=QilF8Z7n8eLNvp+KakVg1PclRY0/AM3rUFbAPwChosc=; b=D866FxD2ymIyevi4hiOKIXQ4VoOVZWTRZVD9F3SIJ/+FPcoNVtQyP4zE 6IHNp5wfyBVBV2ShE9U/n885xtk3dfFfxXBXhQ44Vd08kJhmQrizZemX8 BuqK4RfSLHltu8bHiAYKxlU7YfkczwQy/Oj5Z3mLwvWYfKiESSVK2JRDw XGLBTW4KxJZ9IQydkt0QCVW5AgZWL/V2dCuxP0dmxYMRZ+W8AOnXNXkZk dm3Cql8Xm1gEW7Zs6edowbPERcBDy0mejD5UOybX322qXDdrEyt6QERAh vJlFFlA9KCWsqioO/TNXkIPIXMQU4LUIx5PXdqgERZcGTMA8O8iiI2E/o Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10495"; a="390513221" X-IronPort-AV: E=Sophos;i="5.95,173,1661842800"; d="scan'208";a="390513221" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Oct 2022 04:51:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10495"; a="954889043" X-IronPort-AV: E=Sophos;i="5.95,173,1661842800"; d="scan'208";a="954889043" Received: from crojewsk-ctrl.igk.intel.com ([10.102.9.28]) by fmsmga005.fm.intel.com with ESMTP; 10 Oct 2022 04:51:40 -0700 From: Cezary Rojewski To: alsa-devel@alsa-project.org, broonie@kernel.org Subject: [PATCH 03/15] ASoC: codecs: rt298: Add quirk for KBL-R RVP platform Date: Mon, 10 Oct 2022 14:07:37 +0200 Message-Id: <20221010120749.716499-4-cezary.rojewski@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221010120749.716499-1-cezary.rojewski@intel.com> References: <20221010120749.716499-1-cezary.rojewski@intel.com> MIME-Version: 1.0 Cc: pierre-louis.bossart@linux.intel.com, hdegoede@redhat.com, amadeuszx.slawinski@linux.intel.com, tiwai@suse.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" From: Amadeusz Sławiński KBL-R RVP platforms also use combojack, so we need to enable that configuration for them. Signed-off-by: Amadeusz Sławiński --- sound/soc/codecs/rt298.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/sound/soc/codecs/rt298.c b/sound/soc/codecs/rt298.c index b0b53d4f07df..5f36064ed6e6 100644 --- a/sound/soc/codecs/rt298.c +++ b/sound/soc/codecs/rt298.c @@ -1166,6 +1166,13 @@ static const struct dmi_system_id force_combo_jack_table[] = { DMI_MATCH(DMI_PRODUCT_NAME, "Geminilake") } }, + { + .ident = "Intel Kabylake R RVP", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "Intel Corporation"), + DMI_MATCH(DMI_PRODUCT_NAME, "Kabylake Client platform") + } + }, { } }; From patchwork Mon Oct 10 12:07:38 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Cezary Rojewski X-Patchwork-Id: 614246 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DB662C433F5 for ; Mon, 10 Oct 2022 11:53:25 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 16FDB290F; Mon, 10 Oct 2022 13:52:34 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 16FDB290F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1665402804; bh=TrKv6NRrxHHjyhpDrmqB2VIl8onuWqb8Ctjnn4P1ik4=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=hS59bol/42TqZfnMIewqC0tdeSz0bLCFRytV4aiGIF3Y5Av50pi2A6rFiX5LIGtbI jwmUbrZElQw6xDR+kAkp0ftMzvqsDzosOfz7R7Wih2KU5PzPe3IwrTnmE6O9j8wCXG kI4hJE9FhuANV9xUYjf2Z+Kgw2wKEHPJ26YYoFNc= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 6D58BF80256; Mon, 10 Oct 2022 13:51:52 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id D047CF80559; Mon, 10 Oct 2022 13:51:51 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 0A43AF801D5 for ; Mon, 10 Oct 2022 13:51:43 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 0A43AF801D5 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="BIBzwle/" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665402705; x=1696938705; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=TrKv6NRrxHHjyhpDrmqB2VIl8onuWqb8Ctjnn4P1ik4=; b=BIBzwle/VGuew5LX9zZ2G3mS0uY34XThTL7XozNZFeQzU1Bipzk5ApxJ CruXJhqLYCW7CucJha9ZstUH5sXOfkjuF5IEuCOBPdLq/4zqgWM+It4+6 zf+CAz7wk3ItkX/jbFZelgZU0tBubmh6gxFdjSylnTsnB3J7OHCIM6tDC 65x8a+LwojQceX2fjxq2ZFSEnMFjhikbCxDZlPxVdc1WHvkTACbJNVPXR Yd5C7J9m69JZF5c62DKO6PYZJBHlFhZ6sTMrKC3XCeEoxvTr+w+ivEXe0 aBdx6DxFNZyo9B/GOUXPCr0t8sWg6Q6Ph7zz3nthAX1WNyIf3cmNbPXXR w==; X-IronPort-AV: E=McAfee;i="6500,9779,10495"; a="390513228" X-IronPort-AV: E=Sophos;i="5.95,173,1661842800"; d="scan'208";a="390513228" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Oct 2022 04:51:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10495"; a="954889044" X-IronPort-AV: E=Sophos;i="5.95,173,1661842800"; d="scan'208";a="954889044" Received: from crojewsk-ctrl.igk.intel.com ([10.102.9.28]) by fmsmga005.fm.intel.com with ESMTP; 10 Oct 2022 04:51:41 -0700 From: Cezary Rojewski To: alsa-devel@alsa-project.org, broonie@kernel.org Subject: [PATCH 04/15] ASoC: Intel: avs: Add quirk for KBL-R RVP platform Date: Mon, 10 Oct 2022 14:07:38 +0200 Message-Id: <20221010120749.716499-5-cezary.rojewski@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221010120749.716499-1-cezary.rojewski@intel.com> References: <20221010120749.716499-1-cezary.rojewski@intel.com> MIME-Version: 1.0 Cc: pierre-louis.bossart@linux.intel.com, hdegoede@redhat.com, amadeuszx.slawinski@linux.intel.com, tiwai@suse.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" From: Amadeusz Sławiński KBL-R RVPs contain built-in rt298 codec which requires different PLL clock and .dai_fmt configuration than seen on other boards. Signed-off-by: Amadeusz Sławiński --- sound/soc/intel/avs/boards/rt298.c | 24 ++++++++++++++++++++++-- 1 file changed, 22 insertions(+), 2 deletions(-) diff --git a/sound/soc/intel/avs/boards/rt298.c b/sound/soc/intel/avs/boards/rt298.c index b28d36872dcb..58c9d9edecf0 100644 --- a/sound/soc/intel/avs/boards/rt298.c +++ b/sound/soc/intel/avs/boards/rt298.c @@ -6,6 +6,7 @@ // Amadeusz Slawinski // +#include #include #include #include @@ -14,6 +15,16 @@ #include #include "../../../codecs/rt298.h" +static const struct dmi_system_id kblr_dmi_table[] = { + { + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "Intel Corporation"), + DMI_MATCH(DMI_BOARD_NAME, "Kabylake R DDR4 RVP"), + }, + }, + {} +}; + static const struct snd_kcontrol_new card_controls[] = { SOC_DAPM_PIN_SWITCH("Headphone Jack"), SOC_DAPM_PIN_SWITCH("Mic Jack"), @@ -96,9 +107,15 @@ avs_rt298_hw_params(struct snd_pcm_substream *substream, struct snd_pcm_hw_param { struct snd_soc_pcm_runtime *rtd = substream->private_data; struct snd_soc_dai *codec_dai = asoc_rtd_to_codec(rtd, 0); + unsigned int clk_freq; int ret; - ret = snd_soc_dai_set_sysclk(codec_dai, RT298_SCLK_S_PLL, 19200000, SND_SOC_CLOCK_IN); + if (dmi_first_match(kblr_dmi_table)) + clk_freq = 24000000; + else + clk_freq = 19200000; + + ret = snd_soc_dai_set_sysclk(codec_dai, RT298_SCLK_S_PLL, clk_freq, SND_SOC_CLOCK_IN); if (ret < 0) dev_err(rtd->dev, "Set codec sysclk failed: %d\n", ret); @@ -139,7 +156,10 @@ static int avs_create_dai_link(struct device *dev, const char *platform_name, in dl->platforms = platform; dl->num_platforms = 1; dl->id = 0; - dl->dai_fmt = SND_SOC_DAIFMT_DSP_A | SND_SOC_DAIFMT_NB_NF | SND_SOC_DAIFMT_CBS_CFS; + if (dmi_first_match(kblr_dmi_table)) + dl->dai_fmt = SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF | SND_SOC_DAIFMT_CBS_CFS; + else + dl->dai_fmt = SND_SOC_DAIFMT_DSP_A | SND_SOC_DAIFMT_NB_NF | SND_SOC_DAIFMT_CBS_CFS; dl->init = avs_rt298_codec_init; dl->be_hw_params_fixup = avs_rt298_be_fixup; dl->ops = &avs_rt298_ops; From patchwork Mon Oct 10 12:07:39 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cezary Rojewski X-Patchwork-Id: 614245 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E0B3CC433F5 for ; Mon, 10 Oct 2022 11:53:56 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 15E63291B; Mon, 10 Oct 2022 13:53:05 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 15E63291B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1665402835; bh=oy7fyKyoRPLZLsmhmobDVfYUc2SCjHIvJ0wTkN7LYcY=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=AX1DKZZuworSGfQg9+isxlPiw0Rj+a5kPt0isL6OtkHbDJJTz9keR2cGZ9BvZjFxu PVUcd26UE8ctrKUzuyDn7OewW1OAJHHEbbtTRNCl/PCX9rD3z/MwDt2u0YkqJiSxL7 DnaXNIH6uKCKXU2+zNq1qQlrKJgg8xOF3U8xmqAE= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id A64C8F80567; Mon, 10 Oct 2022 13:51:54 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 0C870F80155; Mon, 10 Oct 2022 13:51:53 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id DC8B4F80155 for ; Mon, 10 Oct 2022 13:51:45 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz DC8B4F80155 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="WZMunh4F" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665402707; x=1696938707; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=oy7fyKyoRPLZLsmhmobDVfYUc2SCjHIvJ0wTkN7LYcY=; b=WZMunh4Fs2D8Y0J7CW5PCZv5efWtUGULaaJglsgi9l+9RmelDVs0ampj DH3WEz7W35FhMPCZf83GQEzGJGs2TQHqaQ/Sll9bJAn06PSm7oYW/wkss 1syq18RhPEt25jQP6crpK1D5Vg/R0lv8YN0JJtG9vQ96t1peBCdkpP8AN KkUDkpxirwhQ351Xe6v81jjQvkCuOgWEuhuRQWJ7buVkUh/zP1BxbmZdl cU5lPhnTfA1RfQNPdxfDOIz9Vj4aTDQIm6s6Aa5o8u/Ps/S2dfX/DW550 dlBv8Ijfs0WK1JwjSIkU9DsNywts/NUa5Kw7HJDH2m0vkVZ7ihkjFhtM6 A==; X-IronPort-AV: E=McAfee;i="6500,9779,10495"; a="390513233" X-IronPort-AV: E=Sophos;i="5.95,173,1661842800"; d="scan'208";a="390513233" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Oct 2022 04:51:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10495"; a="954889052" X-IronPort-AV: E=Sophos;i="5.95,173,1661842800"; d="scan'208";a="954889052" Received: from crojewsk-ctrl.igk.intel.com ([10.102.9.28]) by fmsmga005.fm.intel.com with ESMTP; 10 Oct 2022 04:51:43 -0700 From: Cezary Rojewski To: alsa-devel@alsa-project.org, broonie@kernel.org Subject: [PATCH 05/15] ASoC: Intel: avs: Support AML with rt286 configuration Date: Mon, 10 Oct 2022 14:07:39 +0200 Message-Id: <20221010120749.716499-6-cezary.rojewski@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221010120749.716499-1-cezary.rojewski@intel.com> References: <20221010120749.716499-1-cezary.rojewski@intel.com> MIME-Version: 1.0 Cc: Cezary Rojewski , pierre-louis.bossart@linux.intel.com, tiwai@suse.com, hdegoede@redhat.com, amadeuszx.slawinski@linux.intel.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" ACPI ID of INT343A signals rt286 device for SKL, KBL and AML platforms. Add the missing AML entry. Signed-off-by: Cezary Rojewski --- sound/soc/intel/avs/board_selection.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/sound/soc/intel/avs/board_selection.c b/sound/soc/intel/avs/board_selection.c index 87f9c18be238..95afbac0f358 100644 --- a/sound/soc/intel/avs/board_selection.c +++ b/sound/soc/intel/avs/board_selection.c @@ -29,6 +29,12 @@ static const struct dmi_system_id kbl_dmi_table[] = { DMI_MATCH(DMI_BOARD_NAME, "Skylake Y LPDDR3 RVP3"), }, }, + { + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "Intel Corporation"), + DMI_MATCH(DMI_BOARD_NAME, "AmberLake Y"), + }, + }, {} }; From patchwork Mon Oct 10 12:07:40 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Cezary Rojewski X-Patchwork-Id: 614244 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 37869C433FE for ; Mon, 10 Oct 2022 11:54:23 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 698532926; Mon, 10 Oct 2022 13:53:31 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 698532926 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1665402861; bh=OgygjgFOLQ+lJxPo5N6olQTmtthRmOt/SHG8C643xTo=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=gwct4eegvJVKbJsqDtY+95BJMLSn4cVoSDlgON0A5bSf9hjR5N0POg1GOxp4l+T+I ia2pHWZSMOUyrcZAdLpOI89/XRc1Snu3erBZmX2O0qaVjl5OHHkCzZX2bhgW2kIFmo VVkupRbm7vOeDj+j4Z1GDa7dhkhSJccZ3EqShZl8= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id A1234F80568; Mon, 10 Oct 2022 13:51:58 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id F23EFF80571; Mon, 10 Oct 2022 13:51:56 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id C6E83F80557 for ; Mon, 10 Oct 2022 13:51:49 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz C6E83F80557 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="NdhyEMeD" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665402711; x=1696938711; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=OgygjgFOLQ+lJxPo5N6olQTmtthRmOt/SHG8C643xTo=; b=NdhyEMeDhK9ccV1V9TPx5+vyp1rNl2tcb2Xewi27by+n+yF1MiGOTtWW YaRIwmQlrnp/P/jmtxa/XTwhC+IgGzL9f+b8ptKByUKPJf6ZUSU5QDvHg N9N2bNfEIDmyTDp26YKw/uOhrudw6MHyBA9zWXwn/i2iDmRfkgB9coqK4 JzYL3BlYHTPjFjxg2PsAjZDt2Y9d5/AOoJSGGza6zzZUtz6MwMpTivKy2 3aq86QC8Ml2jLJXDkq10dilN2Q2BO3hWeWd3FcoYlFWuZIlECj5NsbmAX Mbm1t4p1o3wwhxfZsUrDddyWIZqRSH+ZI/nhVYUTwcD2h+9R1eJ2uZotY A==; X-IronPort-AV: E=McAfee;i="6500,9779,10495"; a="390513237" X-IronPort-AV: E=Sophos;i="5.95,173,1661842800"; d="scan'208";a="390513237" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Oct 2022 04:51:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10495"; a="954889053" X-IronPort-AV: E=Sophos;i="5.95,173,1661842800"; d="scan'208";a="954889053" Received: from crojewsk-ctrl.igk.intel.com ([10.102.9.28]) by fmsmga005.fm.intel.com with ESMTP; 10 Oct 2022 04:51:45 -0700 From: Cezary Rojewski To: alsa-devel@alsa-project.org, broonie@kernel.org Subject: [PATCH 06/15] ASoC: Intel: avs: Support da7219 on both KBL and APL Date: Mon, 10 Oct 2022 14:07:40 +0200 Message-Id: <20221010120749.716499-7-cezary.rojewski@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221010120749.716499-1-cezary.rojewski@intel.com> References: <20221010120749.716499-1-cezary.rojewski@intel.com> MIME-Version: 1.0 Cc: pierre-louis.bossart@linux.intel.com, hdegoede@redhat.com, amadeuszx.slawinski@linux.intel.com, tiwai@suse.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" From: Amadeusz Sławiński KBL and APL devices use same codec but have different clock, so it must be set appropriately depending on device. Signed-off-by: Amadeusz Sławiński --- sound/soc/intel/avs/boards/da7219.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/sound/soc/intel/avs/boards/da7219.c b/sound/soc/intel/avs/boards/da7219.c index 02ae542ad779..503a967a1c3a 100644 --- a/sound/soc/intel/avs/boards/da7219.c +++ b/sound/soc/intel/avs/boards/da7219.c @@ -6,6 +6,7 @@ // #include +#include #include #include #include @@ -80,7 +81,10 @@ static int avs_da7219_codec_init(struct snd_soc_pcm_runtime *runtime) int ret; jack = snd_soc_card_get_drvdata(card); - clk_freq = 19200000; + if (soc_intel_is_apl()) + clk_freq = 19200000; + else /* kbl */ + clk_freq = 24576000; ret = snd_soc_dai_set_sysclk(codec_dai, DA7219_CLKSRC_MCLK, clk_freq, SND_SOC_CLOCK_IN); if (ret) { From patchwork Mon Oct 10 12:07:41 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cezary Rojewski X-Patchwork-Id: 613792 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 60C5EC433FE for ; Mon, 10 Oct 2022 11:54:15 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 812FE290A; Mon, 10 Oct 2022 13:53:23 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 812FE290A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1665402853; bh=jtW0eXebvQ2OpHqjN+yasCvxH7LVfYklxPV1iT6TSJo=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=SknSGuYjyZV/7T7n/6qfdBvXP2rEmuj3COM/2yfg1OkLA+42YAg9B2cINGuJrD/A2 Ew2VOWpV2rZvK2ogVPIaUfoKSG1KER4sAvr5a4JtsmLzySii7tAJplVPsqIFxvn8cO D4ydzkFttXUqLo3XOGg1NSxNALN2oqDw+s91fCgk= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 20E13F8054A; Mon, 10 Oct 2022 13:51:58 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 33BD9F8054A; Mon, 10 Oct 2022 13:51:56 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id A301AF8054A for ; Mon, 10 Oct 2022 13:51:49 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz A301AF8054A Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="lGF2N9R+" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665402710; x=1696938710; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=jtW0eXebvQ2OpHqjN+yasCvxH7LVfYklxPV1iT6TSJo=; b=lGF2N9R+O4sznmzSyRjIFWFVF9OKNZ4UDVZNqbbmgOExLMNr+Kdkf/ev IatkT49YRYmZP4ejnrx6mqqEMbE+3tZPgIBn5JOOxsXwHFN/PWy+epPic OQGXWE5GmtTpLHfTyjsYxHHpzfjYardRuNtc4+vIWnwGCc0t17fhrt5Nc FQaFTIGJPVNslXDk8Fx48XVS1f+01KdXmYccYYaU8F+nH5owj2zqJR0Pe hZ7fVbHOQMCT4c4VYtJAQlbGahtOOZr4u5juaos+5/SUj4Nt85C8r+le/ Vnw3SX4sIBSp5b00fWcehhA2qE8j6T0vwVLaZuZ8ZsHJ6l5WLZtqYU5n9 A==; X-IronPort-AV: E=McAfee;i="6500,9779,10495"; a="390513241" X-IronPort-AV: E=Sophos;i="5.95,173,1661842800"; d="scan'208";a="390513241" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Oct 2022 04:51:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10495"; a="954889062" X-IronPort-AV: E=Sophos;i="5.95,173,1661842800"; d="scan'208";a="954889062" Received: from crojewsk-ctrl.igk.intel.com ([10.102.9.28]) by fmsmga005.fm.intel.com with ESMTP; 10 Oct 2022 04:51:47 -0700 From: Cezary Rojewski To: alsa-devel@alsa-project.org, broonie@kernel.org Subject: [PATCH 07/15] ASoC: Intel: avs: Add missing SKL-based device IDs Date: Mon, 10 Oct 2022 14:07:41 +0200 Message-Id: <20221010120749.716499-8-cezary.rojewski@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221010120749.716499-1-cezary.rojewski@intel.com> References: <20221010120749.716499-1-cezary.rojewski@intel.com> MIME-Version: 1.0 Cc: Cezary Rojewski , pierre-louis.bossart@linux.intel.com, tiwai@suse.com, hdegoede@redhat.com, amadeuszx.slawinski@linux.intel.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Enable additional SKL-based configurations by filling device ID table with new entries. Signed-off-by: Cezary Rojewski --- sound/soc/intel/avs/core.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/sound/soc/intel/avs/core.c b/sound/soc/intel/avs/core.c index 58db13374166..6503c5bfd63d 100644 --- a/sound/soc/intel/avs/core.c +++ b/sound/soc/intel/avs/core.c @@ -667,7 +667,11 @@ static const struct avs_spec apl_desc = { static const struct pci_device_id avs_ids[] = { { PCI_VDEVICE(INTEL, 0x9d70), (unsigned long)&skl_desc }, /* SKL */ + { PCI_VDEVICE(INTEL, 0xa170), (unsigned long)&skl_desc }, /* SKL-H */ { PCI_VDEVICE(INTEL, 0x9d71), (unsigned long)&skl_desc }, /* KBL */ + { PCI_VDEVICE(INTEL, 0xa171), (unsigned long)&skl_desc }, /* KBL-H */ + { PCI_VDEVICE(INTEL, 0xa2f0), (unsigned long)&skl_desc }, /* KBL-S */ + { PCI_VDEVICE(INTEL, 0xa3f0), (unsigned long)&skl_desc }, /* CML-V */ { PCI_VDEVICE(INTEL, 0x5a98), (unsigned long)&apl_desc }, /* APL */ { PCI_VDEVICE(INTEL, 0x3198), (unsigned long)&apl_desc }, /* GML */ { 0 } From patchwork Mon Oct 10 12:07:42 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cezary Rojewski X-Patchwork-Id: 613791 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9B53FC433FE for ; Mon, 10 Oct 2022 11:54:49 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id C39462927; Mon, 10 Oct 2022 13:53:57 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz C39462927 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1665402887; bh=xN+Dl4IyK8wO1+W3xgwz+tpP2k/nEyWk0uXkXJasap8=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=kn1tM7ui1GyCOS3OlE0wO0YleHXdMFXus2MRPlO/y4nGquGm/fqTy2ayWMT4ZAVH2 0NnXOh164jDwexEbaCOF34u13CFDIirKDKsrWU84kp5xewBFaidCOSq3HS8Bu2aCTK XO10YfJGUX+AjZC+31SS1bxBmZnWU7jKP/SWpudE= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 810ACF8057F; Mon, 10 Oct 2022 13:51:59 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 2A48EF80578; Mon, 10 Oct 2022 13:51:58 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id B3E39F80559 for ; Mon, 10 Oct 2022 13:51:51 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz B3E39F80559 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Mlw995p8" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665402712; x=1696938712; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=xN+Dl4IyK8wO1+W3xgwz+tpP2k/nEyWk0uXkXJasap8=; b=Mlw995p8uZ+jNesXUKdfXPl/yZ0WsrHMEwDy5drkVK+dL8rFXwi59N2f oNSTlqxfb9LTbedaCz4ivA8vY0M7JCj3iE8g5qDkx/BaRwVBpZNP80j5r Cq0OSGhPWU1bgakIFb0FQTKmz76t35jRheQWibCRdaFwvnWLoxcurSvfd 24Sfb+o3jtGPdceOODKvG02mik84JFTcP/sUSU9bD56SIliILakhS+uDQ f6y0z7b0sJZUMHX4le/IQdHLqe5j94mrvLd70l4xmWFEl1sGUHoduoKgN xdr3G8Getdpd//H6zOvO4j5MTEaI3X3rYQ8VH6FMJkt2kaCjv3W+T1prz w==; X-IronPort-AV: E=McAfee;i="6500,9779,10495"; a="390513246" X-IronPort-AV: E=Sophos;i="5.95,173,1661842800"; d="scan'208";a="390513246" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Oct 2022 04:51:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10495"; a="954889068" X-IronPort-AV: E=Sophos;i="5.95,173,1661842800"; d="scan'208";a="954889068" Received: from crojewsk-ctrl.igk.intel.com ([10.102.9.28]) by fmsmga005.fm.intel.com with ESMTP; 10 Oct 2022 04:51:49 -0700 From: Cezary Rojewski To: alsa-devel@alsa-project.org, broonie@kernel.org Subject: [PATCH 08/15] ASoC: Intel: avs: Simplify d0ix disabling routine Date: Mon, 10 Oct 2022 14:07:42 +0200 Message-Id: <20221010120749.716499-9-cezary.rojewski@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221010120749.716499-1-cezary.rojewski@intel.com> References: <20221010120749.716499-1-cezary.rojewski@intel.com> MIME-Version: 1.0 Cc: Cezary Rojewski , pierre-louis.bossart@linux.intel.com, tiwai@suse.com, hdegoede@redhat.com, amadeuszx.slawinski@linux.intel.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" No need to atomic_add_return(1) when there is atomic_inc_return() available. Signed-off-by: Cezary Rojewski --- sound/soc/intel/avs/ipc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/intel/avs/ipc.c b/sound/soc/intel/avs/ipc.c index 77da206f7dbb..152f8d0bdf8e 100644 --- a/sound/soc/intel/avs/ipc.c +++ b/sound/soc/intel/avs/ipc.c @@ -74,7 +74,7 @@ int avs_dsp_disable_d0ix(struct avs_dev *adev) struct avs_ipc *ipc = adev->ipc; /* Prevent PG only on the first disable. */ - if (atomic_add_return(1, &ipc->d0ix_disable_depth) == 1) { + if (atomic_inc_return(&ipc->d0ix_disable_depth) == 1) { cancel_delayed_work_sync(&ipc->d0ix_work); return avs_dsp_set_d0ix(adev, false); } From patchwork Mon Oct 10 12:07:43 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Cezary Rojewski X-Patchwork-Id: 613790 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2A837C433FE for ; Mon, 10 Oct 2022 11:55:15 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 5393E292F; Mon, 10 Oct 2022 13:54:23 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 5393E292F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1665402913; bh=JG21J30E303QnCQzzTe0eJs1KhMOT0sa2wtynx1Q1TM=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=psAzvcsxnNYhZs42AYUFErkRqlq9wvwAR7IVY7lWhJf1X38XtfFZNOdT8mAoBu6pf qN1670hVauPTlKewCIemj7AT1H/wzNxDsEmOOoG6C2q8xugyj/PW5a9ruGASEb9ap/ 2Up0bPMuxd7nFstbIOU6IzIg65cR0171o641dX4A= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 6BCC8F805A9; Mon, 10 Oct 2022 13:52:01 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 05B19F8059F; Mon, 10 Oct 2022 13:52:00 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 93AEDF8055C for ; Mon, 10 Oct 2022 13:51:53 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 93AEDF8055C Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="cBhCxfC1" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665402714; x=1696938714; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=JG21J30E303QnCQzzTe0eJs1KhMOT0sa2wtynx1Q1TM=; b=cBhCxfC1c3oOCavoaQz79POhf6fBahe5aBFxyuJh2Q/+tlXubIU9bomS RGdbrkd0UBlw+TFgPLf4KTYAQY1L2irJEVn9oizDaMOJ8UOGjtuggf2IP 6POICaOmXlmPmTI2o9sG8Y6qcIpHxv6OuJfxg+G9RBgYHKZ0pJA3qjel0 Nh1wrXiT2t/OjcwQuUWq0h+iv6cFsF40HRX3IYOtHjGyP5AP+AMxsUpON Ds1ePtyYl4m2WokxyGx7936i1tDzCyk3mp6X5MgvBd6Jj5EZykTaeRkZH UP3n5hSPF3N+UTOXLq8376ho7dpQOVmTq7K13haXdcLFM2TIOOcaTtjRd Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10495"; a="390513249" X-IronPort-AV: E=Sophos;i="5.95,173,1661842800"; d="scan'208";a="390513249" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Oct 2022 04:51:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10495"; a="954889069" X-IronPort-AV: E=Sophos;i="5.95,173,1661842800"; d="scan'208";a="954889069" Received: from crojewsk-ctrl.igk.intel.com ([10.102.9.28]) by fmsmga005.fm.intel.com with ESMTP; 10 Oct 2022 04:51:51 -0700 From: Cezary Rojewski To: alsa-devel@alsa-project.org, broonie@kernel.org Subject: [PATCH 09/15] ASoC: Intel: avs: Add missing include to HDA board Date: Mon, 10 Oct 2022 14:07:43 +0200 Message-Id: <20221010120749.716499-10-cezary.rojewski@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221010120749.716499-1-cezary.rojewski@intel.com> References: <20221010120749.716499-1-cezary.rojewski@intel.com> MIME-Version: 1.0 Cc: pierre-louis.bossart@linux.intel.com, hdegoede@redhat.com, amadeuszx.slawinski@linux.intel.com, tiwai@suse.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" From: Amadeusz Sławiński In some configurations board fails to compile due to missing header. Add it to fix build. Signed-off-by: Amadeusz Sławiński --- sound/soc/intel/avs/boards/hdaudio.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/intel/avs/boards/hdaudio.c b/sound/soc/intel/avs/boards/hdaudio.c index 073663ba140d..e68c4c7aa2ba 100644 --- a/sound/soc/intel/avs/boards/hdaudio.c +++ b/sound/soc/intel/avs/boards/hdaudio.c @@ -6,6 +6,7 @@ // Amadeusz Slawinski // +#include #include #include #include From patchwork Mon Oct 10 12:07:44 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cezary Rojewski X-Patchwork-Id: 614243 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 781A4C433FE for ; Mon, 10 Oct 2022 11:55:01 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 9B1472916; Mon, 10 Oct 2022 13:54:09 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 9B1472916 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1665402899; bh=QCz5bxo15VEkNJsvIJ4sTJx/idRityrxqBRwaMhJiHI=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=MHk15Zo7+t4pxINGlddCSYla/AKx97YoeQTizOeNhqEPdFzBFpWeIHa9Hi97ADJO1 81qpQzrEqMsb67GGTYcO4Bo/axCDIUnlIdx9vYUSQS1TzGV8Dg8p5ziuMUpvFoMw0X k/DqeFMdboBDtLwPKB5fPYmbU7aHdpjolDsIf7zw= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id E78DEF805A0; Mon, 10 Oct 2022 13:51:59 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 69B8FF80579; Mon, 10 Oct 2022 13:51:58 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 7103BF80568 for ; Mon, 10 Oct 2022 13:51:55 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 7103BF80568 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="bGUAKprr" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665402716; x=1696938716; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=QCz5bxo15VEkNJsvIJ4sTJx/idRityrxqBRwaMhJiHI=; b=bGUAKprrX+im57jOs2Igh8dvEx4Z6WA/RLcjMZ/6+iFAyi58f+pYO4zI Omx7k+lEL1ftW6mqNmP6bXI4v3oRFZeDGLVf1jCVzuxswDGJCwpZTaENh HM47Zz8cwR3D1tD0uQk8NH3lIX5aXbO6NS3vUbxZQJoFqYD7x7STK3bTU aNdZ03/2sKMSuKP9Sxoyw6vzAKKyZw1wKdrPSbhqFm4f9H5sgd6XZEJXk FzLBe5WqmpegtLqtdWnzRKZ0mXb3yOLBeIfvOnC9FzkyHC7Sdtd5JcPSj 3YBc6t9oTyoB6BnKFA4Ca9F0+cmBndyhSUYq2uq4sED0IdJEtJOsHsGVf g==; X-IronPort-AV: E=McAfee;i="6500,9779,10495"; a="390513251" X-IronPort-AV: E=Sophos;i="5.95,173,1661842800"; d="scan'208";a="390513251" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Oct 2022 04:51:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10495"; a="954889083" X-IronPort-AV: E=Sophos;i="5.95,173,1661842800"; d="scan'208";a="954889083" Received: from crojewsk-ctrl.igk.intel.com ([10.102.9.28]) by fmsmga005.fm.intel.com with ESMTP; 10 Oct 2022 04:51:53 -0700 From: Cezary Rojewski To: alsa-devel@alsa-project.org, broonie@kernel.org Subject: [PATCH 10/15] ASoC: Intel: avs: Do not reuse msg between different IPC handlers Date: Mon, 10 Oct 2022 14:07:44 +0200 Message-Id: <20221010120749.716499-11-cezary.rojewski@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221010120749.716499-1-cezary.rojewski@intel.com> References: <20221010120749.716499-1-cezary.rojewski@intel.com> MIME-Version: 1.0 Cc: Cezary Rojewski , pierre-louis.bossart@linux.intel.com, tiwai@suse.com, hdegoede@redhat.com, amadeuszx.slawinski@linux.intel.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" While LOG_BUFFER_STATUS is a simple notification with only one meaningful field, same message ptr shall not be reused for two different handlers. Signed-off-by: Cezary Rojewski --- sound/soc/intel/avs/apl.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/sound/soc/intel/avs/apl.c b/sound/soc/intel/avs/apl.c index b8e2b23c9f64..7c8ce98eda9d 100644 --- a/sound/soc/intel/avs/apl.c +++ b/sound/soc/intel/avs/apl.c @@ -133,12 +133,14 @@ static int apl_coredump(struct avs_dev *adev, union avs_notify_msg *msg) buf = apl_log_payload_addr(addr); memcpy_fromio(&layout, addr, sizeof(layout)); if (!apl_is_entry_stackdump(buf + layout.read_ptr)) { + union avs_notify_msg lbs_msg = AVS_NOTIFICATION(LOG_BUFFER_STATUS); + /* * DSP awaits the remaining logs to be * gathered before dumping stack */ - msg->log.core = msg->ext.coredump.core_id; - avs_dsp_op(adev, log_buffer_status, msg); + lbs_msg.log.core = msg->ext.coredump.core_id; + avs_dsp_op(adev, log_buffer_status, &lbs_msg); } pos = dump + AVS_FW_REGS_SIZE; From patchwork Mon Oct 10 12:07:45 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cezary Rojewski X-Patchwork-Id: 613789 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 17366C433FE for ; Mon, 10 Oct 2022 11:55:47 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 4F8482935; Mon, 10 Oct 2022 13:54:55 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 4F8482935 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1665402945; bh=aS5WA8WlMd5hWmep+lOPzVMTSzxAIOkf840xYz3U/KM=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=i2mfWsAlIYuTdnvPiGOw5/uhVl39BCAPkuHvqnajiQ0lZXWFDh40RTkKFhRUxfIDT 2ir3mLNdL8iTj3JlH8qmbmMZ9PneqYEIhOXEzbGXNmxDVLIReYDoy/QDNMb2X6SR0S MHP0s7HvSyHd0C6i93KoCwUyC2MvS/54EvlI9dak= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id C0AE4F8058C; Mon, 10 Oct 2022 13:52:05 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 4F4CFF805B1; Mon, 10 Oct 2022 13:52:05 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id C37A0F8058C for ; Mon, 10 Oct 2022 13:51:58 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz C37A0F8058C Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="m2CH0kj1" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665402720; x=1696938720; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=aS5WA8WlMd5hWmep+lOPzVMTSzxAIOkf840xYz3U/KM=; b=m2CH0kj17AVHjzLZ4gae6FcXynunh1t61aw/ZA9YthXGfpCGv+Z0SbFH hXox8gIO/vN68vdTf26Yd4FjQh+JC0Xz4AaPa/GNB4ZCc7ckyy6qfAyTC uC7gnlSsintUzbeB3TwkLmqYzo7+b+6zW//UyavjtEayhvzzeLXJBNL20 wHvGKBE/MIVqiKHaqeUCGxtgRd+oW5/HNZrUtXzypQLvDDxtHd6M6kcpD 1L8m25bH7yZ7HZH9CReDYxG9NCl9QNmm0jJJNgFrx2/LE8Incmk0uSTQH gknHqwVdRDWuX8oFVnzGmXoCDKrXFQ8zWjP4V2fjhRDNogQmX8x6WDoF5 g==; X-IronPort-AV: E=McAfee;i="6500,9779,10495"; a="390513255" X-IronPort-AV: E=Sophos;i="5.95,173,1661842800"; d="scan'208";a="390513255" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Oct 2022 04:51:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10495"; a="954889093" X-IronPort-AV: E=Sophos;i="5.95,173,1661842800"; d="scan'208";a="954889093" Received: from crojewsk-ctrl.igk.intel.com ([10.102.9.28]) by fmsmga005.fm.intel.com with ESMTP; 10 Oct 2022 04:51:55 -0700 From: Cezary Rojewski To: alsa-devel@alsa-project.org, broonie@kernel.org Subject: [PATCH 11/15] ASoC: Intel: avs: Do not treat unsupported IPCs as invalid Date: Mon, 10 Oct 2022 14:07:45 +0200 Message-Id: <20221010120749.716499-12-cezary.rojewski@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221010120749.716499-1-cezary.rojewski@intel.com> References: <20221010120749.716499-1-cezary.rojewski@intel.com> MIME-Version: 1.0 Cc: Cezary Rojewski , pierre-louis.bossart@linux.intel.com, tiwai@suse.com, hdegoede@redhat.com, amadeuszx.slawinski@linux.intel.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Utilize NOT_SUPPORTED status code to differentiate between unsupported and invalid requests. Skip over error paths if it is the former that is communicated by the base firmware. Signed-off-by: Cezary Rojewski --- sound/soc/intel/avs/avs.h | 4 +++- sound/soc/intel/avs/messages.h | 2 ++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/sound/soc/intel/avs/avs.h b/sound/soc/intel/avs/avs.h index 92e37722d280..91f78eb11bc1 100644 --- a/sound/soc/intel/avs/avs.h +++ b/sound/soc/intel/avs/avs.h @@ -220,8 +220,10 @@ static inline void avs_ipc_err(struct avs_dev *adev, struct avs_ipc_msg *tx, /* * If IPC channel is blocked e.g.: due to ongoing recovery, * -EPERM error code is expected and thus it's not an actual error. + * + * Unsupported IPCs are of no harm either. */ - if (error == -EPERM) + if (error == -EPERM || error == AVS_IPC_NOT_SUPPORTED) dev_dbg(adev->dev, "%s 0x%08x 0x%08x failed: %d\n", name, tx->glb.primary, tx->glb.ext.val, error); else diff --git a/sound/soc/intel/avs/messages.h b/sound/soc/intel/avs/messages.h index c0f90dba9af8..02b3b7a74783 100644 --- a/sound/soc/intel/avs/messages.h +++ b/sound/soc/intel/avs/messages.h @@ -150,6 +150,8 @@ union avs_module_msg { }; } __packed; +#define AVS_IPC_NOT_SUPPORTED 15 + union avs_reply_msg { u64 val; struct { From patchwork Mon Oct 10 12:07:46 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cezary Rojewski X-Patchwork-Id: 614242 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1F77BC433F5 for ; Mon, 10 Oct 2022 11:55:32 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 3F7F0292B; Mon, 10 Oct 2022 13:54:40 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 3F7F0292B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1665402930; bh=Kzbz2//MEbFomVYT3Je8Ry2vhVhj4UV2as/D/dMydqQ=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=Vbu/YSEy2yDjfJTXCVR2yBNO6tJOZk3ExEYPKCH8cwxMvTlNAGfNHqwupRuJgqA6G QQymZE6+6skV9vSGUj3fup7wqFY6T59N+Fk2zrSUTEybufUKoTuuWyIvXB8CAM9gto +UDSGOP/OGzzeAUNSmh3Sng1UWpHtizOZnSlHISc= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 4DF67F805AE; Mon, 10 Oct 2022 13:52:03 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 2F194F805B1; Mon, 10 Oct 2022 13:52:02 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 692E1F805A8 for ; Mon, 10 Oct 2022 13:51:59 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 692E1F805A8 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="RTAAdybq" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665402720; x=1696938720; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Kzbz2//MEbFomVYT3Je8Ry2vhVhj4UV2as/D/dMydqQ=; b=RTAAdybqIHQErsleRGIREzXCcoNw/9mH6zk5HgTxWrILE+PIF/rXsru2 +zwnV/gQuuVSltd+Fxvoo6Endf1dDQWnhEMGgctvTdaY9Ti+w1QtaQCKv Q0OcLr97zk7sNyk5mHL99kGCU2FrzrxIGFLpczGOu+Ie/eT9zJpNJgDl4 +ksSd208KXRFMYYdU2HBE/Q9r9DWLxS8IyAnCv6XVty5Y3BqxkE3gs2D4 Z0lvkACFnO5Uxsv1h6g/QkWHmYzUTPfcNY1GAfTwyYxriDTnVea7pNvER z5FFe+JFQcr2r4BIVmrTYq/xa3auaQ3uhq+A9iZfRC5vQKTB1xqORom2H g==; X-IronPort-AV: E=McAfee;i="6500,9779,10495"; a="390513259" X-IronPort-AV: E=Sophos;i="5.95,173,1661842800"; d="scan'208";a="390513259" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Oct 2022 04:51:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10495"; a="954889101" X-IronPort-AV: E=Sophos;i="5.95,173,1661842800"; d="scan'208";a="954889101" Received: from crojewsk-ctrl.igk.intel.com ([10.102.9.28]) by fmsmga005.fm.intel.com with ESMTP; 10 Oct 2022 04:51:57 -0700 From: Cezary Rojewski To: alsa-devel@alsa-project.org, broonie@kernel.org Subject: [PATCH 12/15] ASoC: Intel: avs: Do not print IPC error message twice Date: Mon, 10 Oct 2022 14:07:46 +0200 Message-Id: <20221010120749.716499-13-cezary.rojewski@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221010120749.716499-1-cezary.rojewski@intel.com> References: <20221010120749.716499-1-cezary.rojewski@intel.com> MIME-Version: 1.0 Cc: Cezary Rojewski , pierre-louis.bossart@linux.intel.com, tiwai@suse.com, hdegoede@redhat.com, amadeuszx.slawinski@linux.intel.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" ENABLE_LOGS and SYSTEM_TIME IPCs call LARGE_CONFIG_SET internally which dumps an error message in case of an error. There is no need to repeat the process in the top level handler. Signed-off-by: Cezary Rojewski --- sound/soc/intel/avs/messages.c | 19 ++++--------------- 1 file changed, 4 insertions(+), 15 deletions(-) diff --git a/sound/soc/intel/avs/messages.c b/sound/soc/intel/avs/messages.c index d4bcee1aabcf..6b0fecbf07c3 100644 --- a/sound/soc/intel/avs/messages.c +++ b/sound/soc/intel/avs/messages.c @@ -687,20 +687,13 @@ int avs_ipc_get_modules_info(struct avs_dev *adev, struct avs_mods_info **info) int avs_ipc_set_enable_logs(struct avs_dev *adev, u8 *log_info, size_t size) { - int ret; - - ret = avs_ipc_set_large_config(adev, AVS_BASEFW_MOD_ID, AVS_BASEFW_INST_ID, - AVS_BASEFW_ENABLE_LOGS, log_info, size); - if (ret) - dev_err(adev->dev, "enable logs failed: %d\n", ret); - - return ret; + return avs_ipc_set_large_config(adev, AVS_BASEFW_MOD_ID, AVS_BASEFW_INST_ID, + AVS_BASEFW_ENABLE_LOGS, log_info, size); } int avs_ipc_set_system_time(struct avs_dev *adev) { struct avs_sys_time sys_time; - int ret; u64 us; /* firmware expects UTC time in micro seconds */ @@ -708,12 +701,8 @@ int avs_ipc_set_system_time(struct avs_dev *adev) sys_time.val_l = us & UINT_MAX; sys_time.val_u = us >> 32; - ret = avs_ipc_set_large_config(adev, AVS_BASEFW_MOD_ID, AVS_BASEFW_INST_ID, - AVS_BASEFW_SYSTEM_TIME, (u8 *)&sys_time, sizeof(sys_time)); - if (ret) - dev_err(adev->dev, "set system time failed: %d\n", ret); - - return ret; + return avs_ipc_set_large_config(adev, AVS_BASEFW_MOD_ID, AVS_BASEFW_INST_ID, + AVS_BASEFW_SYSTEM_TIME, (u8 *)&sys_time, sizeof(sys_time)); } int avs_ipc_copier_set_sink_format(struct avs_dev *adev, u16 module_id, From patchwork Mon Oct 10 12:07:47 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cezary Rojewski X-Patchwork-Id: 614241 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3F4ADC433F5 for ; Mon, 10 Oct 2022 11:56:01 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 681132923; Mon, 10 Oct 2022 13:55:09 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 681132923 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1665402959; bh=1B2hUD1j7bRc11+vDf5SX1yy256UWJMaQb7ipbR3I5g=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=AtEZe4C2PSp0gsIXB0JN6DLx+QodsfWloXn+dFgslUN0V+WQgoXsjJhlW7n1Xv6xu KoN2llPzbw8XijlAOtHH1isQ0CFl7wYWj6rWbdJPAvzCTDfuLDGAx25iA6DlzARju1 MHa8NZW5nFP2aqiQlxa1nniGNNY2039/Ern8ilik= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 36C91F805AF; Mon, 10 Oct 2022 13:52:09 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 914B6F805BD; Mon, 10 Oct 2022 13:52:07 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 2DFB4F805AF for ; Mon, 10 Oct 2022 13:52:01 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 2DFB4F805AF Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="UYhPrYgt" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665402722; x=1696938722; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=1B2hUD1j7bRc11+vDf5SX1yy256UWJMaQb7ipbR3I5g=; b=UYhPrYgtrkO90+z81KwIoMkEAcHJ1iOtyz5QEivpGCKXMl6oRNG+Hgty aqa4/3LjooZY6yr0+nDckTBCjz7F6hFvz5ON8PqVH+yhskr3t7aTTSt0o j3qu0HpNpWwBTqdkc5JJ5cDAvXJ1lHqm5SQ+cZZXW7+i8vOo9cJJds+l8 RS7cNXDJYMHZy2+jgdOfGItbJal19t9R9oYre/uF736i4qTJqtQW+Qtjb rFbWxUDWGa1YMrZii+lxgd7LbQOqoHb4GHp14kI2EY/tEFQqmpG09OGnJ 7tZDLPL074FoTjS5Ovku8BewdXA0xhWHxXthD04GTU7lWBAy5GElxB1LS g==; X-IronPort-AV: E=McAfee;i="6500,9779,10495"; a="390513262" X-IronPort-AV: E=Sophos;i="5.95,173,1661842800"; d="scan'208";a="390513262" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Oct 2022 04:52:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10495"; a="954889118" X-IronPort-AV: E=Sophos;i="5.95,173,1661842800"; d="scan'208";a="954889118" Received: from crojewsk-ctrl.igk.intel.com ([10.102.9.28]) by fmsmga005.fm.intel.com with ESMTP; 10 Oct 2022 04:51:59 -0700 From: Cezary Rojewski To: alsa-devel@alsa-project.org, broonie@kernel.org Subject: [PATCH 13/15] ASoC: Intel: avs: Simplify ignore_fw_version description Date: Mon, 10 Oct 2022 14:07:47 +0200 Message-Id: <20221010120749.716499-14-cezary.rojewski@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221010120749.716499-1-cezary.rojewski@intel.com> References: <20221010120749.716499-1-cezary.rojewski@intel.com> MIME-Version: 1.0 Cc: Cezary Rojewski , pierre-louis.bossart@linux.intel.com, tiwai@suse.com, hdegoede@redhat.com, amadeuszx.slawinski@linux.intel.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Reword the parameter description to drop any confusion regarding its purpose. Signed-off-by: Cezary Rojewski --- sound/soc/intel/avs/loader.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/intel/avs/loader.c b/sound/soc/intel/avs/loader.c index 9e3f8ff33a87..2d80a271eb50 100644 --- a/sound/soc/intel/avs/loader.c +++ b/sound/soc/intel/avs/loader.c @@ -43,7 +43,7 @@ /* Occasionally, engineering (release candidate) firmware is provided for testing. */ static bool debug_ignore_fw_version; module_param_named(ignore_fw_version, debug_ignore_fw_version, bool, 0444); -MODULE_PARM_DESC(ignore_fw_version, "Verify FW version 0=yes (default), 1=no"); +MODULE_PARM_DESC(ignore_fw_version, "Ignore firmware version check 0=no (default), 1=yes"); #define AVS_LIB_NAME_SIZE 8 From patchwork Mon Oct 10 12:07:48 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cezary Rojewski X-Patchwork-Id: 614240 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9F927C433F5 for ; Mon, 10 Oct 2022 11:56:38 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id D0AEA290F; Mon, 10 Oct 2022 13:55:46 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz D0AEA290F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1665402996; bh=y30PTgU8msnrWFzBoNM3GWxnpWoJ49lG31Ykkyf5N+k=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=D01sz2eLHPW5OK3oyQ6s6PI9EaJbMjSNbO/Xfrf2ElcbEGPae3bN0W+u6fmGiGbMO 93dXFSe0c1EImfe89GT1ZKt4eFaxAoYfNuFHQXrnA6D8ndtR9lyQzNQZoGhMxxvvv7 rcHpGahOP4z9rLyqizvuk91DF4haL8uQnGFrOCdo= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 8CAF2F805C3; Mon, 10 Oct 2022 13:52:12 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 2C07DF805C3; Mon, 10 Oct 2022 13:52:11 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id A4341F805B1 for ; Mon, 10 Oct 2022 13:52:04 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz A4341F805B1 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="SMe4wBWq" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665402725; x=1696938725; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=y30PTgU8msnrWFzBoNM3GWxnpWoJ49lG31Ykkyf5N+k=; b=SMe4wBWqF20YJR0zEWpgWbELsXSKfpqwUacE9pWIui/HY1v259uO40ps 5E17tYb7ShPD/9YYhqkJX+AQuEy6/UDgOhccJYvFo2RK5xkWihVPywUQS YBzs0KipF5B5oBfh0kA8Sh1conWQIuHTMRYWp+SIYjflX0sVoU42oEGQl 5uS2UnVxc72NthMwYgaA6cYwzBOZ1fmwm4vD5jdmcoS3DVnkALtlu2abY pnnc5Ta/wTy0pbt3q1Myo6+xcvKOLpoItP6vIq4JxEvdTxor2ylIpbX1M whljuQn18EmKAScuimb/mc2MeGbxPj+43Q9dwMzgsb4LCL0UwsO/N+izz Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10495"; a="390513265" X-IronPort-AV: E=Sophos;i="5.95,173,1661842800"; d="scan'208";a="390513265" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Oct 2022 04:52:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10495"; a="954889161" X-IronPort-AV: E=Sophos;i="5.95,173,1661842800"; d="scan'208";a="954889161" Received: from crojewsk-ctrl.igk.intel.com ([10.102.9.28]) by fmsmga005.fm.intel.com with ESMTP; 10 Oct 2022 04:52:00 -0700 From: Cezary Rojewski To: alsa-devel@alsa-project.org, broonie@kernel.org Subject: [PATCH 14/15] ASoC: Intel: avs: Simplify log control for SKL Date: Mon, 10 Oct 2022 14:07:48 +0200 Message-Id: <20221010120749.716499-15-cezary.rojewski@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221010120749.716499-1-cezary.rojewski@intel.com> References: <20221010120749.716499-1-cezary.rojewski@intel.com> MIME-Version: 1.0 Cc: Cezary Rojewski , pierre-louis.bossart@linux.intel.com, tiwai@suse.com, hdegoede@redhat.com, amadeuszx.slawinski@linux.intel.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Loop only till the actual number of AudioDSP cores, not the value of mask made from said number. Signed-off-by: Cezary Rojewski --- sound/soc/intel/avs/skl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/intel/avs/skl.c b/sound/soc/intel/avs/skl.c index bda5ec7510fe..dc98b5cf900f 100644 --- a/sound/soc/intel/avs/skl.c +++ b/sound/soc/intel/avs/skl.c @@ -28,12 +28,12 @@ static int skl_enable_logs(struct avs_dev *adev, enum avs_log_enable enable, u32 info->core_mask = resource_mask; if (enable) - for_each_set_bit(i, &resource_mask, GENMASK(num_cores, 0)) { + for_each_set_bit(i, &resource_mask, num_cores) { info->logs_core[i].enable = enable; info->logs_core[i].min_priority = *priorities++; } else - for_each_set_bit(i, &resource_mask, GENMASK(num_cores, 0)) + for_each_set_bit(i, &resource_mask, num_cores) info->logs_core[i].enable = enable; ret = avs_ipc_set_enable_logs(adev, (u8 *)info, size); From patchwork Mon Oct 10 12:07:49 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cezary Rojewski X-Patchwork-Id: 613788 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 67A05C433F5 for ; Mon, 10 Oct 2022 11:56:16 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 983F5293E; Mon, 10 Oct 2022 13:55:24 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 983F5293E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1665402974; bh=757jksTD/InYrlah3Xg03lR97thx/bEezOxBraQzLUY=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=BhkyhbYGJ1kYKst8bcHh6ADEDrMmITumVRbE/wF0rgIAtI14rY87nGuQ8ef4795z5 dMl4EXfWKqTqlCbrehxirujfdN+McisR/WayIUM07NEK/GwhlVhsPkj5XXNMbQoXyG ZZbmOraRVtcLTKRtTZCV7XN0ISPa307KnzSY/kEk= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id A34FEF805BD; Mon, 10 Oct 2022 13:52:10 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id B99C3F805AF; Mon, 10 Oct 2022 13:52:08 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 133A9F805BA for ; Mon, 10 Oct 2022 13:52:04 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 133A9F805BA Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="DLWXHOhC" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665402726; x=1696938726; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=757jksTD/InYrlah3Xg03lR97thx/bEezOxBraQzLUY=; b=DLWXHOhCOxYhyh7DUGVRlMdLIdsGH0y/Lhszy8N0Gd2KxyLyjilpImB0 RmGq9NrTOedebjSOEft8ALqOtY8dsOwT+HOz2RXbJBTb44YasBzTzd8xk bbpND+JLAsztw/7AT8gMaXVhZm3Oqlqoaz0v6nhLeeswcRGrATmLEPKki eU1QyTfDh8YOIzfhIgOBSCnyUQJ48joMAfhXbGtJFb4qv0WRdofLsANjw I/eGrpTrBnVcj0YIcNSK9bOOXfao0O3IRdP9aTiTdQu5bjBBvAdUQNlPg 4zjXEXBnfgQJRGKau02Oif44EYPhH6fKE77mDbOCVcNFGGN0gXNgkDX3B g==; X-IronPort-AV: E=McAfee;i="6500,9779,10495"; a="390513270" X-IronPort-AV: E=Sophos;i="5.95,173,1661842800"; d="scan'208";a="390513270" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Oct 2022 04:52:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10495"; a="954889196" X-IronPort-AV: E=Sophos;i="5.95,173,1661842800"; d="scan'208";a="954889196" Received: from crojewsk-ctrl.igk.intel.com ([10.102.9.28]) by fmsmga005.fm.intel.com with ESMTP; 10 Oct 2022 04:52:02 -0700 From: Cezary Rojewski To: alsa-devel@alsa-project.org, broonie@kernel.org Subject: [PATCH 15/15] ASoC: codecs: hda: Fix spelling error in log message Date: Mon, 10 Oct 2022 14:07:49 +0200 Message-Id: <20221010120749.716499-16-cezary.rojewski@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221010120749.716499-1-cezary.rojewski@intel.com> References: <20221010120749.716499-1-cezary.rojewski@intel.com> MIME-Version: 1.0 Cc: Cezary Rojewski , pierre-louis.bossart@linux.intel.com, tiwai@suse.com, hdegoede@redhat.com, amadeuszx.slawinski@linux.intel.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" To improve readability. Signed-off-by: Cezary Rojewski --- sound/soc/codecs/hda.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/hda.c b/sound/soc/codecs/hda.c index ad20a3dff9b7..712d8ba85f0e 100644 --- a/sound/soc/codecs/hda.c +++ b/sound/soc/codecs/hda.c @@ -213,7 +213,7 @@ static int hda_codec_probe(struct snd_soc_component *component) patch = (hda_codec_patch_t)codec->preset->driver_data; if (!patch) { - dev_err(&hdev->dev, "no patch specified?\n"); + dev_err(&hdev->dev, "no patch specified\n"); ret = -EINVAL; goto err; }