From patchwork Mon Nov 28 13:55:43 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hans Verkuil X-Patchwork-Id: 630115 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22E77C433FE for ; Mon, 28 Nov 2022 13:55:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231464AbiK1Nzs (ORCPT ); Mon, 28 Nov 2022 08:55:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52358 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231147AbiK1Nzr (ORCPT ); Mon, 28 Nov 2022 08:55:47 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B3183E95 for ; Mon, 28 Nov 2022 05:55:46 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4EB43610A7 for ; Mon, 28 Nov 2022 13:55:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3C336C433C1; Mon, 28 Nov 2022 13:55:45 +0000 (UTC) Message-ID: Date: Mon, 28 Nov 2022 14:55:43 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Content-Language: en-US To: Linux Media Mailing List Cc: Marco Felsch From: Hans Verkuil Subject: [PATCH] media: i2c: tc358746: make DEFINE_RUNTIME_DEV_PM_OPS static Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org DEFINE_RUNTIME_DEV_PM_OPS should be static. This fixes this sparse warning: drivers/media/i2c/tc358746.c:1671:1: warning: symbol 'tc358746_pm_ops' was not declared. Should it be static? Signed-off-by: Hans Verkuil diff --git a/drivers/media/i2c/tc358746.c b/drivers/media/i2c/tc358746.c index 171309c62bb8..d1f552bd81d4 100644 --- a/drivers/media/i2c/tc358746.c +++ b/drivers/media/i2c/tc358746.c @@ -1668,8 +1668,8 @@ static int tc358746_resume(struct device *dev) return err; } -DEFINE_RUNTIME_DEV_PM_OPS(tc358746_pm_ops, tc358746_suspend, - tc358746_resume, NULL); +static DEFINE_RUNTIME_DEV_PM_OPS(tc358746_pm_ops, tc358746_suspend, + tc358746_resume, NULL); static const struct of_device_id __maybe_unused tc358746_of_match[] = { { .compatible = "toshiba,tc358746" },