From patchwork Tue Jan 31 14:03:03 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Corentin Labbe X-Patchwork-Id: 649065 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AFF6C636CC for ; Tue, 31 Jan 2023 14:03:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229686AbjAaODS (ORCPT ); Tue, 31 Jan 2023 09:03:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39630 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230193AbjAaODO (ORCPT ); Tue, 31 Jan 2023 09:03:14 -0500 Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 80999658A for ; Tue, 31 Jan 2023 06:03:12 -0800 (PST) Received: by mail-wr1-x430.google.com with SMTP id h12so14286912wrv.10 for ; Tue, 31 Jan 2023 06:03:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=pUQAfjtzy6EHxBJwfhCl4n1J2zAjSrYnuYq1+Ya8AU8=; b=5EwBkRx2phRr/ZYJsMhNxJp2z4S/F3F98Kq/UdYpIR3RcPcor5lLTFXR1/fm07VojA zW5bwxslz2w40u2E9045YdCmf+hQ9FMtyG3jwT2TxvpKWsQ2plFY33sN5/0EovkDTFlq zOqLumxbaDqV/N1yKDKsuoq2/8INuGx87WOCyBwH9vR343msq4ZFOFZ+Nwd+5WwgYfFW W+ovpD29+RzBWaZCmFdt6Pv03+LkJP6cudNiGBIQibOdGgv6rnUDIzqpcHXGRUMuJwwM s81PM0sovgrdRLmQDf9OzhxedNbR3BAeF6Pqlt9oFrWreDt71G8iu/XFhfiRpcUTJgHh a81Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=pUQAfjtzy6EHxBJwfhCl4n1J2zAjSrYnuYq1+Ya8AU8=; b=5yX/vx6mumo20c8PNYHE94a61JJ3u7NoZvX6AIdeU+aLde67urVXnJoK5xYW0yxVlE 9JC46MtO3XSBFkFnDfpUcfLo070VcJ3RCjbQZ8hk5q8Dcxh29PdnjTCpekTNGrd2c+ud YGCTAQkc/vC9CrYbev0HvFQea9d4uITDT5guP03kFlRYO3mUh1EGKk/kUkayKphvhbvP vOztVhwPkH2vz0w8Nfy4UxC0IciuC8UzABdRikm7cd92TFkW6iJmPDU0SApbuIB+epwv 6Q3Zlfrmpd7gbZR5KPdKvQgCUydfnkOQwTNmPfrlMz2udw3fPZBK2ukVVLcSGJo0H+mz pzCA== X-Gm-Message-State: AO0yUKXudqQBe0rZXImYPTtZtMngQBdAl2kxlnT67ydDqqidsWS6tnzF +t7GM0iBy3+0lPGipjWlxI5u5A== X-Google-Smtp-Source: AK7set/1e9CI63BRGdwQ0kdmY/hhRzptTQlu8l+kfqIz/ymeJkNJepvsqjiXzfSIUu4MCudn8yt7dA== X-Received: by 2002:a5d:6549:0:b0:2bf:b5bd:8f60 with SMTP id z9-20020a5d6549000000b002bfb5bd8f60mr23116076wrv.61.1675173790523; Tue, 31 Jan 2023 06:03:10 -0800 (PST) Received: from localhost.localdomain (laubervilliers-658-1-213-31.w90-63.abo.wanadoo.fr. [90.63.244.31]) by smtp.googlemail.com with ESMTPSA id z12-20020adff74c000000b00291f1a5ced6sm14950847wrp.53.2023.01.31.06.03.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Jan 2023 06:03:09 -0800 (PST) From: Corentin Labbe To: lee@kernel.org, linus.walleij@linaro.org, pavel@ucw.cz, robh+dt@kernel.org, jacek.anaszewski@gmail.com, krzysztof.kozlowski+dt@linaro.org Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org, Corentin Labbe , Rob Herring Subject: [PATCH v5 1/2] dt-bindings: leds: common: add disk write/read and usb-host/usb-gadget Date: Tue, 31 Jan 2023 14:03:03 +0000 Message-Id: <20230131140304.626779-1-clabbe@baylibre.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org The triggers enum misses 3 cases used by gemini DT. usb-host was added via commit 0cfbd328d60f ("usb: Add LED triggers for USB activity") so we add also as valid trigger usb-gadget which was added along in this commit. disk-read/disk-write were added by commit d1ed7c558612 ("leds: Extends disk trigger for reads and writes") Reviewed-by: Linus Walleij Acked-by: Rob Herring Signed-off-by: Corentin Labbe Reviewed-by: Linus Walleij --- V1 can be seen at https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20210508193654.2596119-1-clabbe@baylibre.com/ Changes since v1: - rebased on recent tree Changes since v2: - rebased on recent tree Changes since v3: - rebased on recent tree Changes since v4: - rebased on recent tree Documentation/devicetree/bindings/leds/common.yaml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/leds/common.yaml b/Documentation/devicetree/bindings/leds/common.yaml index d34bb58c0037..60c8611c6611 100644 --- a/Documentation/devicetree/bindings/leds/common.yaml +++ b/Documentation/devicetree/bindings/leds/common.yaml @@ -90,6 +90,8 @@ properties: - heartbeat # LED indicates disk activity - disk-activity + - disk-read + - disk-write # LED indicates IDE disk activity (deprecated), in new implementations # use "disk-activity" - ide-disk @@ -98,6 +100,8 @@ properties: # LED alters the brightness for the specified duration with one software # timer (requires "led-pattern" property) - pattern + - usb-gadget + - usb-host - pattern: "^cpu[0-9]*$" - pattern: "^hci[0-9]+-power$" # LED is triggered by Bluetooth activity From patchwork Tue Jan 31 14:03:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Corentin Labbe X-Patchwork-Id: 650467 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C013BC636D4 for ; Tue, 31 Jan 2023 14:03:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231583AbjAaODT (ORCPT ); Tue, 31 Jan 2023 09:03:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39628 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231663AbjAaODP (ORCPT ); Tue, 31 Jan 2023 09:03:15 -0500 Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 89F7AFF26 for ; Tue, 31 Jan 2023 06:03:13 -0800 (PST) Received: by mail-wr1-x433.google.com with SMTP id h12so14286969wrv.10 for ; Tue, 31 Jan 2023 06:03:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lc8ed0h0ZvjQ5UirrcCDNDRepKtbVnO5U4g4adO99nk=; b=hWAOXV+eH0/DS4Hu76lBf7HOJPHyBrLevKwVWzylha4entBU1Yly4+uLlRKu05MBAz UYwDYw3EisDTl4Opu0YXG1f4BLhxYLOagWpcFbQsEe2E2QUDzXwIoQaQL5+BXAQtOtXb kzYzqe3xaU8zsFKoeZQ+N5HjRVMks5GK0X6YX1Qg/dMTwtlLUVnjC4QIrA5uBNL0qsMW BGsZLB9RGwdgnLQCOsFf8BAygt0Ojp28TqtZ3x0iRqB5JcLZtU37e4HOl2EV98DOYAZT S+LCcTEbUZyLrFOQ/NZePZZ63ucq8i5UN2YZzdlP3LizkIo7SO+HtqtgCBA9HdX/ySza ufOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lc8ed0h0ZvjQ5UirrcCDNDRepKtbVnO5U4g4adO99nk=; b=TTrv5bRg+SLdCihLqNL+uzYZYVgiLP2jFXRELW1RfTZXEfe542gnlhuuoRZi0jK0qz 08LLr7uFamBQGzVgdDXGS1FqrnG3Yy+B0dH21mwTfeEn+3Xzxyipvk7cgB23P5I2J8s4 c1izBwgCDeXMLkBuXsAIglOHSybvSV1kzcw3v8SAwLoIYXB9t1ZZDg5n7QZT1I8j1zLf OFRZwEDZqieYi6uzZeKg+kKHeeUtPehvPgEMnXOi4Pb3y69DkuScJJoToR2PV3waFMwf nX4veXW2HEKGd1pUA2bCSqTk2Go19r1FfJY7iT/qy6IwrLaT7xPfjw+j+5rxr0XIODHm jH0A== X-Gm-Message-State: AFqh2kqthQAksj1JBU81UJbkcl12GoHg7gkHVTRfXaf4KyxYAnvaGGYQ 2KHXRMaIUyK7FoDHH/kPiF8J1A== X-Google-Smtp-Source: AMrXdXv9M6VOOSiVMhMuDVUhPTRizSby4m22qg+uSqGL9zPq5nQ3Kv3RQkyMEqnq7/OxbkKiJufUMA== X-Received: by 2002:adf:f0c1:0:b0:2bc:67d:c018 with SMTP id x1-20020adff0c1000000b002bc067dc018mr46749979wro.48.1675173792075; Tue, 31 Jan 2023 06:03:12 -0800 (PST) Received: from localhost.localdomain (laubervilliers-658-1-213-31.w90-63.abo.wanadoo.fr. [90.63.244.31]) by smtp.googlemail.com with ESMTPSA id z12-20020adff74c000000b00291f1a5ced6sm14950847wrp.53.2023.01.31.06.03.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Jan 2023 06:03:11 -0800 (PST) From: Corentin Labbe To: lee@kernel.org, linus.walleij@linaro.org, pavel@ucw.cz, robh+dt@kernel.org, jacek.anaszewski@gmail.com, krzysztof.kozlowski+dt@linaro.org Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org, Corentin Labbe , Rob Herring Subject: [PATCH v5 2/2] leds: remove ide-disk trigger Date: Tue, 31 Jan 2023 14:03:04 +0000 Message-Id: <20230131140304.626779-2-clabbe@baylibre.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230131140304.626779-1-clabbe@baylibre.com> References: <20230131140304.626779-1-clabbe@baylibre.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org No user of ide-disk remains, so remove this deprecated trigger. Only a few platforms used this and were fixed in 2016. Acked-by: Rob Herring Signed-off-by: Corentin Labbe --- Change since v1: - remove also DEFINE_LED_TRIGGER(ledtrig_ide) Changes since v2: - Added the fact that few platforms used this and it was fixed old ago. - Added Rob's ack Change since v3: - Rebase on top of latest next Change since v4: - Rebase on top of latest next Documentation/devicetree/bindings/leds/common.yaml | 3 --- drivers/leds/trigger/ledtrig-disk.c | 4 ---- 2 files changed, 7 deletions(-) diff --git a/Documentation/devicetree/bindings/leds/common.yaml b/Documentation/devicetree/bindings/leds/common.yaml index 60c8611c6611..15e3f6645682 100644 --- a/Documentation/devicetree/bindings/leds/common.yaml +++ b/Documentation/devicetree/bindings/leds/common.yaml @@ -92,9 +92,6 @@ properties: - disk-activity - disk-read - disk-write - # LED indicates IDE disk activity (deprecated), in new implementations - # use "disk-activity" - - ide-disk # LED flashes at a fixed, configurable rate - timer # LED alters the brightness for the specified duration with one software diff --git a/drivers/leds/trigger/ledtrig-disk.c b/drivers/leds/trigger/ledtrig-disk.c index 0741910785bb..0b7dfbd04273 100644 --- a/drivers/leds/trigger/ledtrig-disk.c +++ b/drivers/leds/trigger/ledtrig-disk.c @@ -16,7 +16,6 @@ DEFINE_LED_TRIGGER(ledtrig_disk); DEFINE_LED_TRIGGER(ledtrig_disk_read); DEFINE_LED_TRIGGER(ledtrig_disk_write); -DEFINE_LED_TRIGGER(ledtrig_ide); void ledtrig_disk_activity(bool write) { @@ -24,8 +23,6 @@ void ledtrig_disk_activity(bool write) led_trigger_blink_oneshot(ledtrig_disk, &blink_delay, &blink_delay, 0); - led_trigger_blink_oneshot(ledtrig_ide, - &blink_delay, &blink_delay, 0); if (write) led_trigger_blink_oneshot(ledtrig_disk_write, &blink_delay, &blink_delay, 0); @@ -40,7 +37,6 @@ static int __init ledtrig_disk_init(void) led_trigger_register_simple("disk-activity", &ledtrig_disk); led_trigger_register_simple("disk-read", &ledtrig_disk_read); led_trigger_register_simple("disk-write", &ledtrig_disk_write); - led_trigger_register_simple("ide-disk", &ledtrig_ide); return 0; }