From patchwork Tue Feb 7 19:28:49 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 651640 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D612C636D3 for ; Tue, 7 Feb 2023 19:29:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229878AbjBGT3C (ORCPT ); Tue, 7 Feb 2023 14:29:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36162 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229699AbjBGT3B (ORCPT ); Tue, 7 Feb 2023 14:29:01 -0500 Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 818E63A859 for ; Tue, 7 Feb 2023 11:28:59 -0800 (PST) Received: by mail-wm1-x336.google.com with SMTP id m16-20020a05600c3b1000b003dc4050c94aso12297278wms.4 for ; Tue, 07 Feb 2023 11:28:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=U8Ap/R9bBCRwfbHGCfaOdQ/oi2hB1pqW05c0juFinY0=; b=vIkCoxnEwrDeI35wrzj+TX7KKyYN4lId+J+knK7tvaXmNVu51KlchE3CIKk8jqJ87j m6WF9XxXVGbT4qtTtlA0AMoH9z6CTaDulTx+iyEOznZMsylwv5gx8aNhG7a5ry3mJGc0 eAms2XPNv/3AzP9UzZlTHdDtJqAHSD0t8tsdqyH1RED455qvRWOd3LWWgGh8nHa10WfT ma5E1TnNN9+7C3vB9dg7B/eVLM4HQ2TFV3tl7JHF37T9GYcqs84Hh8rFoT+3EkrMT/Gk jGxF4LEc//YbaYLAGCGiB3ZM/8003BAGj/gVBPwOxPhHlW4sksXP44L89Aj6aonntgJ5 5e5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=U8Ap/R9bBCRwfbHGCfaOdQ/oi2hB1pqW05c0juFinY0=; b=G98eG7Qx4HwIsIQnozXZzy9V4XfHhPblnzWurjvaSBwbR0dKzLjJP3aLxVspdaM1Vc 6Ku9Sp8+XAk8+fap1tYHaUk3mGdT1WhOMJl5wyMgwiozsc5x7srEbkwyFSeTLpbVbL0M m1zOA4+NaStKOK4iExng984DGxRHT8CdBGffry3oc9sQJJMRDf2aXACGaP+9sNni8S5i pmepR05IH8oSj53RN8B7b78QsMA4wloRb8TTF+1JKXUvph4AXWWZBxQnQHF4LjKWKbRX iNvVUJdq6+VfPaNHJQWrmWUICahVBCjftJM9qtnWZzubhtpIj4RgFYukLYfEPirbcAFQ eWUA== X-Gm-Message-State: AO0yUKVodSd2OBXPRGN+rwsMBbBD9VlNotw6kk/EbsWr89XJFZXivJBG d13aQK6KcMlLvujBuO2ga1YC9A== X-Google-Smtp-Source: AK7set9k6ax9+8EqWLt6+WaYYhjredgB03dqiFMzkGrpCA7+tKGHv3HYgWBH0mSw6TVrdK7kotJ+DQ== X-Received: by 2002:a05:600c:a292:b0:3df:eb5d:fbf with SMTP id hu18-20020a05600ca29200b003dfeb5d0fbfmr4158930wmb.38.1675798138113; Tue, 07 Feb 2023 11:28:58 -0800 (PST) Received: from krzk-bin.. ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id j33-20020a05600c1c2100b003db0ad636d1sm22770818wms.28.2023.02.07.11.28.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Feb 2023 11:28:57 -0800 (PST) From: Krzysztof Kozlowski To: Rob Herring , Krzysztof Kozlowski , Alim Akhtar , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 1/3] dt-bindings: soc: samsung: exynos-pmu: allow phys as child on Exynos3 and Exynos4 Date: Tue, 7 Feb 2023 20:28:49 +0100 Message-Id: <20230207192851.549242-1-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org Just like on Exynos5250, Exynos5420 and Exynos5433 the MIPI phy is actually part of the Power Management Unit system controller thus allow it as PMU's child. Signed-off-by: Krzysztof Kozlowski Acked-by: Rob Herring --- .../bindings/soc/samsung/exynos-pmu.yaml | 23 +++++++++++++++++-- 1 file changed, 21 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml b/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml index f7c141dd11ec..5d8d9497f18e 100644 --- a/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml +++ b/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml @@ -48,6 +48,9 @@ properties: - const: syscon - items: - enum: + - samsung,exynos3250-pmu + - samsung,exynos4210-pmu + - samsung,exynos4412-pmu - samsung,exynos5250-pmu - samsung,exynos5420-pmu - samsung,exynos5433-pmu @@ -138,18 +141,34 @@ allOf: compatible: contains: enum: + - samsung,exynos3250-pmu + - samsung,exynos4210-pmu + - samsung,exynos4412-pmu - samsung,exynos5250-pmu - samsung,exynos5420-pmu - samsung,exynos5433-pmu then: properties: - dp-phy: true mipi-phy: true else: properties: - dp-phy: false mipi-phy: false + - if: + properties: + compatible: + contains: + enum: + - samsung,exynos5250-pmu + - samsung,exynos5420-pmu + - samsung,exynos5433-pmu + then: + properties: + dp-phy: true + else: + properties: + dp-phy: false + examples: - | #include From patchwork Tue Feb 7 19:28:50 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 652285 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08E8BC636CC for ; Tue, 7 Feb 2023 19:29:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230117AbjBGT3D (ORCPT ); Tue, 7 Feb 2023 14:29:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36194 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229699AbjBGT3C (ORCPT ); Tue, 7 Feb 2023 14:29:02 -0500 Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1916C3A855 for ; Tue, 7 Feb 2023 11:29:01 -0800 (PST) Received: by mail-wm1-x329.google.com with SMTP id q8so11786393wmo.5 for ; Tue, 07 Feb 2023 11:29:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=SZRz65dFGssUM9GWtmz6zrmKbHxxfil5UcSIAJSRpQY=; b=dpgWCIDZ0rvoh30EPHPjSzcl4l1h/f5+wcCj5cKLfX789BP/yGZrnufuq8PnnU7nIy 3Ky7v/lg+kxIPkhEpBkCXkipHKaXZyuDPBwtOuAM3QShmQR/GTIs46E47T+U4kSXXlQt CsoyjBRBDhR0MvwEpGS1Dh5IItlRqTKQogO8cK9Nu5o3pT8+31CgGYMQI0VNJeMgtpeY 1CgqZCK7pRWs+1il6GrL34ClI6vaZqJiFAwf/TuvX1Mc70MLpIBE4TvNJ3MLirjA1kP9 4bJ3LqcW4ynl1Q639/NqlPLbd/x2yAHkrXW1OVK0GIDHiFKmZhCJstjjEvVJ1AsYYhFr F45w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SZRz65dFGssUM9GWtmz6zrmKbHxxfil5UcSIAJSRpQY=; b=7EE3DpUEuwYfMGmv+aIPIBVs8LznQiZuZ1wQaE/uZVli09E7Q+atDvEzuZZX/RKyNl XvU4o1mNOAGcI04Qwyu6W9F9+6dN2jI6C+TZ0RTdr0+Kp8Mi1BpiC7Z2xaZe2SUjbNbG PqNi6epkmKBnI/l/hJ58obNOxzpbWwMdSdDQqjxeyhvaEImyr7ybN1X7EZj0NQEfqGGm 7K/RVvDM539yeVcT0zfGfKCJ8+PlP5CzY2/5PZvpccFW6TFyzF6fyv18hqHbjXGToQay tBP+glbgSZwYua+K27owOt7Wr6AwLvweOJD3v6dZARmLig8YJJD/vy7xqBQTSC0xeVUw fN8g== X-Gm-Message-State: AO0yUKVb0GLnuYr3LVg0AO28IXoGyXp5kx3IqxXNn/Ublzby1AHFuuh2 YWZO3TsRGWpjTa92J/WqvsOQ4A== X-Google-Smtp-Source: AK7set/fyw5j/FU5oFTP4iDfoRD2zN02IXizdaeNXRKwpLyjWgyPf4njKck75oJ1RRq7JlfQQ3wJoA== X-Received: by 2002:a05:600c:755:b0:3e0:6c4:6a3a with SMTP id j21-20020a05600c075500b003e006c46a3amr4026715wmn.22.1675798139649; Tue, 07 Feb 2023 11:28:59 -0800 (PST) Received: from krzk-bin.. ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id j33-20020a05600c1c2100b003db0ad636d1sm22770818wms.28.2023.02.07.11.28.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Feb 2023 11:28:59 -0800 (PST) From: Krzysztof Kozlowski To: Rob Herring , Krzysztof Kozlowski , Alim Akhtar , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 2/3] ARM: dts: exynos: move MIPI phy to PMU node in Exynos3250 Date: Tue, 7 Feb 2023 20:28:50 +0100 Message-Id: <20230207192851.549242-2-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230207192851.549242-1-krzysztof.kozlowski@linaro.org> References: <20230207192851.549242-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org The MIPI phy is actually part of the Power Management Unit system controller. It does not have its own address space, thus keeping the node under soc causes warnings: exynos3250-artik5-eval.dtb: soc: video-phy: {'compatible': ['samsung,s5pv210-mipi-video-phy'], '#phy-cells': [[1]], 'syscon': [[15]], 'phandle': [[23]]} should not be valid under {'type': 'object'} Signed-off-by: Krzysztof Kozlowski --- arch/arm/boot/dts/exynos3250.dtsi | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi index 28bb2ce8ccf7..cb2c59c98c4a 100644 --- a/arch/arm/boot/dts/exynos3250.dtsi +++ b/arch/arm/boot/dts/exynos3250.dtsi @@ -346,7 +346,7 @@ sys_reg: syscon@10010000 { }; pmu_system_controller: system-controller@10020000 { - compatible = "samsung,exynos3250-pmu", "syscon"; + compatible = "samsung,exynos3250-pmu", "simple-mfd", "syscon"; reg = <0x10020000 0x4000>; interrupt-controller; #interrupt-cells = <3>; @@ -354,12 +354,11 @@ pmu_system_controller: system-controller@10020000 { clock-names = "clkout8"; clocks = <&cmu CLK_FIN_PLL>; #clock-cells = <1>; - }; - mipi_phy: video-phy { - compatible = "samsung,s5pv210-mipi-video-phy"; - #phy-cells = <1>; - syscon = <&pmu_system_controller>; + mipi_phy: mipi-phy { + compatible = "samsung,s5pv210-mipi-video-phy"; + #phy-cells = <1>; + }; }; pd_cam: power-domain@10023c00 { From patchwork Tue Feb 7 19:28:51 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 651639 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6183C64EC4 for ; Tue, 7 Feb 2023 19:29:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230411AbjBGT3F (ORCPT ); Tue, 7 Feb 2023 14:29:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36226 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229662AbjBGT3D (ORCPT ); Tue, 7 Feb 2023 14:29:03 -0500 Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 75FD83B0C1 for ; Tue, 7 Feb 2023 11:29:02 -0800 (PST) Received: by mail-wm1-x32f.google.com with SMTP id m16-20020a05600c3b1000b003dc4050c94aso12297398wms.4 for ; Tue, 07 Feb 2023 11:29:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=PPt0d21EGc/jow/fpKXjyuyxRoi0vr0T/kgkjEZ24Nk=; b=Hen3NJo56OhW8DFZAq4lQYwYUmAbzFS5GJedAd8Sdq669L9i1UG3eQQOeb44CbNj++ 2Y73Igg8vusNGGf87qDyF7ISQ65fAjt8+57ROeYxRyNFRJUx+bcRsPRd6s3cOdw7tFxZ jQq7TqB/1yvjmY0Y4m6bfRo7HjM8cnFyYML+bkk3qD1beGYioGGG3QhcBjopb2OWNoeV flpfekOHUf1wQaoDfBGkl43WmYUfgsDta9lsRoT4rY+1XZCYXzVOiWUjIB5AlWOaNb93 C9capCo3nYoEjLIQftbRFSEKJFh31w/Bap2bro74dqmPJf5f4mOe748u6GQZOgbtFqBz HREQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PPt0d21EGc/jow/fpKXjyuyxRoi0vr0T/kgkjEZ24Nk=; b=Hn6PPcXU+dEWUQgKELSXMzg4VKFqPrf6drGOtXMcVUyzcSIto5KoA1sovGlFXl8BWz /4flcdd7TXsqXX435g0bdNTJCG5LTpqxOBclCCi27jqp7TCklDCvBMU7Fcr1tsemHeS+ MIb+PQ+g9pr/KdDGY6i051+DOFIxv19xUL96SO7jmVbeJYZryuamdOm6QoNy0qBO+3U4 v2ltBn8Ld5HAybfS2Eql6t+jvsS+igVpTCAbgNzU7/z1PF3U9sTKivsQxu2gYb5RL09g 3qbX5yKCgolR+VR27tSGooBdcQKzZUPbu7v9BJgCDPrOTaYr9lFqGvcbHPPbgKesRvr2 +25A== X-Gm-Message-State: AO0yUKUVSgXLjwFZup0lJJGTfBrvCgLMrvsJBmF6O14EW3Z7DXoVxm6g OSyU9u0WDKyG3MtRoXPSWQ5hpg== X-Google-Smtp-Source: AK7set9fz9HQsmLNOGzGZf/2oRs8JqN+jVQHS/qsjtqeFz0RSJPY2xc0aDbDxYtYUoOxixEXOHdJBg== X-Received: by 2002:a05:600c:3513:b0:3dc:c5c:b94f with SMTP id h19-20020a05600c351300b003dc0c5cb94fmr4084434wmq.39.1675798141001; Tue, 07 Feb 2023 11:29:01 -0800 (PST) Received: from krzk-bin.. ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id j33-20020a05600c1c2100b003db0ad636d1sm22770818wms.28.2023.02.07.11.28.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Feb 2023 11:29:00 -0800 (PST) From: Krzysztof Kozlowski To: Rob Herring , Krzysztof Kozlowski , Alim Akhtar , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 3/3] ARM: dts: exynos: move MIPI phy to PMU node in Exynos4 Date: Tue, 7 Feb 2023 20:28:51 +0100 Message-Id: <20230207192851.549242-3-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230207192851.549242-1-krzysztof.kozlowski@linaro.org> References: <20230207192851.549242-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org The MIPI phy is actually part of the Power Management Unit system controller. It does not have its own address space, thus keeping the node under soc causes warnings: xynos4412-i9305.dtb: soc: video-phy: {'compatible': ['samsung,s5pv210-mipi-video-phy'], '#phy-cells': [[1]], 'syscon': [[11]], 'phandle': [[13]]} should not be valid under {'type': 'object'} Signed-off-by: Krzysztof Kozlowski --- arch/arm/boot/dts/exynos4.dtsi | 13 ++++++------- arch/arm/boot/dts/exynos4412.dtsi | 2 +- 2 files changed, 7 insertions(+), 8 deletions(-) diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi index 44dcb1377475..8dd6976ab0a7 100644 --- a/arch/arm/boot/dts/exynos4.dtsi +++ b/arch/arm/boot/dts/exynos4.dtsi @@ -105,12 +105,6 @@ memory-controller@12570000 { reg = <0x12570000 0x14>; }; - mipi_phy: video-phy { - compatible = "samsung,s5pv210-mipi-video-phy"; - #phy-cells = <1>; - syscon = <&pmu_system_controller>; - }; - pd_mfc: power-domain@10023c40 { compatible = "samsung,exynos4210-pd"; reg = <0x10023c40 0x20>; @@ -181,11 +175,16 @@ sys_reg: syscon@10010000 { }; pmu_system_controller: system-controller@10020000 { - compatible = "samsung,exynos4210-pmu", "syscon"; + compatible = "samsung,exynos4210-pmu", "simple-mfd", "syscon"; reg = <0x10020000 0x4000>; interrupt-controller; #interrupt-cells = <3>; interrupt-parent = <&gic>; + + mipi_phy: mipi-phy { + compatible = "samsung,s5pv210-mipi-video-phy"; + #phy-cells = <1>; + }; }; dsi_0: dsi@11c80000 { diff --git a/arch/arm/boot/dts/exynos4412.dtsi b/arch/arm/boot/dts/exynos4412.dtsi index 11f9dd94b6b3..7fa3e5fd6801 100644 --- a/arch/arm/boot/dts/exynos4412.dtsi +++ b/arch/arm/boot/dts/exynos4412.dtsi @@ -798,7 +798,7 @@ &pmu { }; &pmu_system_controller { - compatible = "samsung,exynos4412-pmu", "syscon"; + compatible = "samsung,exynos4412-pmu", "simple-mfd", "syscon"; clock-names = "clkout0", "clkout1", "clkout2", "clkout3", "clkout4", "clkout8", "clkout9"; clocks = <&clock CLK_OUT_DMC>, <&clock CLK_OUT_TOP>,