From patchwork Sun Feb 26 05:39:49 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Randy Dunlap X-Patchwork-Id: 657398 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C648C7EE23 for ; Sun, 26 Feb 2023 05:40:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229618AbjBZFj7 (ORCPT ); Sun, 26 Feb 2023 00:39:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56642 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229558AbjBZFj6 (ORCPT ); Sun, 26 Feb 2023 00:39:58 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 51077136EB; Sat, 25 Feb 2023 21:39:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=jZDKgKykgJivmPlxfhgmYfxwzNIu4E7QMWQ1piQj3M0=; b=GjLoAa0RZXwFgvWheSIzYKnhB2 5q247ieUuUeaZQJRGP6uSVuJ0z+MR23HQ4AKgtll3atMiQzrt0MGLRewIVUp/N+87gq5CwD5t+CSZ SPzwJhki1nja2wyo1c1I/nYfYtcLDPzqhT2b7FzrOjtSthNTPYq205C7Lm/duIFaCs0CVMpj73kb6 a85pW3FGbjy1bQzW/9yY4edwPCKDval1gWADrnVnXeRG/JdtO7fC+ROpPvIfVpN6p3l4TFmdqiPIF AlVSY+I/EhretKFUVykVXdHyUXM5uftacbK70mIIHV8oleNfV5WrnmVTalSFof4UHvFbUsKyW2e66 H4tn0zvQ==; Received: from [2601:1c2:980:9ec0::df2f] (helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1pW9lM-006qYL-CI; Sun, 26 Feb 2023 05:39:56 +0000 From: Randy Dunlap To: linux-kernel@vger.kernel.org Cc: Randy Dunlap , Dan Murphy , Pavel Machek , Jacek Anaszewski , Lee Jones , linux-leds@vger.kernel.org Subject: [PATCH 4/8] leds: TI_LMU_COMMON: select REGMAP instead of depending on it Date: Sat, 25 Feb 2023 21:39:49 -0800 Message-Id: <20230226053953.4681-5-rdunlap@infradead.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230226053953.4681-1-rdunlap@infradead.org> References: <20230226053953.4681-1-rdunlap@infradead.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org REGMAP is a hidden (not user visible) symbol. Users cannot set it directly thru "make *config", so drivers should select it instead of depending on it if they need it. Consistently using "select" or "depends on" can also help reduce Kconfig circular dependency issues. Therefore, change the use of "depends on REGMAP" to "select REGMAP". Fixes: 3fce8e1eb994 ("leds: TI LMU: Add common code for TI LMU devices") Signed-off-by: Randy Dunlap Cc: Dan Murphy Cc: Pavel Machek Cc: Jacek Anaszewski Cc: Lee Jones Cc: linux-leds@vger.kernel.org Acked-by: Pavel Machek --- drivers/leds/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -- a/drivers/leds/Kconfig b/drivers/leds/Kconfig --- a/drivers/leds/Kconfig +++ b/drivers/leds/Kconfig @@ -795,7 +795,7 @@ config LEDS_SPI_BYTE config LEDS_TI_LMU_COMMON tristate "LED driver for TI LMU" depends on LEDS_CLASS - depends on REGMAP + select REGMAP help Say Y to enable the LED driver for TI LMU devices. This supports common features between the TI LM3532, LM3631, LM3632,