From patchwork Fri Jun 7 18:30:16 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 166188 Delivered-To: patch@linaro.org Received: by 2002:a92:9e1a:0:0:0:0:0 with SMTP id q26csp1040755ili; Fri, 7 Jun 2019 12:29:05 -0700 (PDT) X-Google-Smtp-Source: APXvYqx/pKG7dAhdCmgWHIC+hS37wWYLAWYPUtKHM+myA4KOVgxFkZ5Sm9C2fDVjB3XTe3cgzmFt X-Received: by 2002:ae9:f00a:: with SMTP id l10mr45995722qkg.349.1559935745096; Fri, 07 Jun 2019 12:29:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559935745; cv=none; d=google.com; s=arc-20160816; b=phwEUyxdrW4VbocDW1EXJA3nOvScHXU/mDgWf4Y2vxN01y9vtwhwqxani5cvnAub2w sr0W4ZJ8X5pxg30494SrZVTXSy4WHyRjKR2ge7FS8WhyJSz0VknTUcBejA8lDwh+3aj2 Fvr0RfriNF6uy0FwB/Whu9P2WDKl53CEGbuLdpJfZWxtgzFuTDOvBwFWnqMOWVXrLTKp w3Agu+hRWJKIQKJwvVZfi4Sg3S4Auwp/jkoOXzlzp6cYVZZ5DIRFQLovyx1alfFyaEGw O6KhPnJSrCNJ8hwpU/MkE/IbsPNqxUt4teRGVd/RSoMFNFgTQdoULD/QROmrpyYZPYIc pgxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:message-id:date:to:from :dkim-signature; bh=Gaowb1UdRjBy2Ja/xxobvWr0UDUJEDRhjYpKLZza8bQ=; b=HS8iMx0FmJg//7tVxIDIYSy/19DihV7ZNRlGCCeuNtDwMArV8kQQCOunLD/l5sKrOm aGmIWKEMo6HwJ8PuQf7Gc8MKq4Ree3UDc7duDhjALlEz+CccABdhPOremFyRvqEQjW04 ao+MnbsX076MKdWWLr0Ef4T5saMNMUwHYnsTzV6ZjrcZOnNFGTnxhraVVxIcUm9VN/Ev 42RWDLcGUF3MzEpPwUX18bCGGrUUBk9HM3hMIvBT6LJthFdsBTpsgIbSSDQ8+u8xPZW8 u7NK2Cpku/3ZWOWSm+JL4bMbZ/diCJ/1xFlMpsp2wcDdzApR2i0W92kfouItHpJbM81y thXw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=EpffRNTJ; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id z10si1798146qve.43.2019.06.07.12.29.04 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 07 Jun 2019 12:29:05 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=EpffRNTJ; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:51762 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hZKXw-0005L4-Mt for patch@linaro.org; Fri, 07 Jun 2019 15:29:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51324) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hZJdG-0004wn-5o for qemu-devel@nongnu.org; Fri, 07 Jun 2019 14:30:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hZJdD-00078G-CT for qemu-devel@nongnu.org; Fri, 07 Jun 2019 14:30:30 -0400 Received: from mail-oi1-x244.google.com ([2607:f8b0:4864:20::244]:41157) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hZJdA-0006yF-9I for qemu-devel@nongnu.org; Fri, 07 Jun 2019 14:30:26 -0400 Received: by mail-oi1-x244.google.com with SMTP id b21so2090958oic.8 for ; Fri, 07 Jun 2019 11:30:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=Gaowb1UdRjBy2Ja/xxobvWr0UDUJEDRhjYpKLZza8bQ=; b=EpffRNTJmjm1nFQ+NbkhcECJkPaytAKweaSVl+Ng5mF0SnvePnHNfHpr//dT3d/IVJ s0TFjMVn/Mfr9P6OPR6zTYQr/T6uy2qBv4X9oYD41Uv/bCLu74Lc5F+NekBJxM4nPILN jLvowT7QiYvIU4a87zLh/MXClhpBk3tyVVvcCljzr6WyZj+06th8BLBkR+VSwgIH6MDZ taukUefd2qz+FoYNK4EYYJuD3/8Mh2R9dW3ShxDlsQko93RN/LxHpYNNEjKIklxOT9dU 5JqB3I5YgD1xVtGdkVO5Zev+L9yIckuK1/dtZCQX0URSEvS3WeB7WgXOZwmeQjROXt1o mPCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=Gaowb1UdRjBy2Ja/xxobvWr0UDUJEDRhjYpKLZza8bQ=; b=ssdq1ZBFgRCCNbKVQlPCKjtV/vRbAXtKrhm2/ciFr0Kg6JyWIZRnvWfgDPoApQY8ZA ltBreN4HMrXZ3IigaVrGQ5iHmi1lQ7qAQ98KsmDw+bWJtPu6FCnWIHrKpeE/Tdj27G/G Lp7V9nMCDwUNwAGwLPW7oNuLSUuA8ABtRfMV868Fy/o/gIQcGl/RLedppZo1rnw9BS6a 9AdX6PUuh9wMP6Oq4GbdDTguwi8AvA/fivjb5lwrVgGHjVXLHRCi7NppQB0tyFJ7bsFC kx/HRvUKLx8qgh6vuDz+A3QXhadgIk3ps0OVN58ypZdgL/BW22rITijE0BEWLDMzgnwN ee2w== X-Gm-Message-State: APjAAAWlqDSPacHKmuYfWA8nEb7wQ1FCmSFtDvU+7XVuLWNrijbmSsj/ LzyDSJMAEwxVo0hfA2YFyYh70hDonveDPg== X-Received: by 2002:aca:4b96:: with SMTP id y144mr4722893oia.34.1559932220484; Fri, 07 Jun 2019 11:30:20 -0700 (PDT) Received: from localhost.localdomain (200-56-192-86-cable.cybercable.net.mx. [200.56.192.86]) by smtp.gmail.com with ESMTPSA id s4sm995043otp.3.2019.06.07.11.30.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 07 Jun 2019 11:30:19 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Fri, 7 Jun 2019 13:30:16 -0500 Message-Id: <20190607183016.8285-1-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.1 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::244 Subject: [Qemu-devel] [PATCH] tcg: Fix typos in helper_gvec_sar{8,32,64}v X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lvivier@redhat.com Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" The loop is written with scalars, not vectors. Use the correct type when incrementing. Fixes: 5ee5c14cacd Reported-by: Laurent Vivier Signed-off-by: Richard Henderson --- accel/tcg/tcg-runtime-gvec.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- 2.17.1 Tested-by: Laurent Vivier Reviewed-by: Laurent Vivier diff --git a/accel/tcg/tcg-runtime-gvec.c b/accel/tcg/tcg-runtime-gvec.c index 3b6052fe97..51cb29ca79 100644 --- a/accel/tcg/tcg-runtime-gvec.c +++ b/accel/tcg/tcg-runtime-gvec.c @@ -874,7 +874,7 @@ void HELPER(gvec_sar8v)(void *d, void *a, void *b, uint32_t desc) intptr_t oprsz = simd_oprsz(desc); intptr_t i; - for (i = 0; i < oprsz; i += sizeof(vec8)) { + for (i = 0; i < oprsz; i += sizeof(int8_t)) { uint8_t sh = *(uint8_t *)(b + i) & 7; *(int8_t *)(d + i) = *(int8_t *)(a + i) >> sh; } @@ -898,7 +898,7 @@ void HELPER(gvec_sar32v)(void *d, void *a, void *b, uint32_t desc) intptr_t oprsz = simd_oprsz(desc); intptr_t i; - for (i = 0; i < oprsz; i += sizeof(vec32)) { + for (i = 0; i < oprsz; i += sizeof(int32_t)) { uint8_t sh = *(uint32_t *)(b + i) & 31; *(int32_t *)(d + i) = *(int32_t *)(a + i) >> sh; } @@ -910,7 +910,7 @@ void HELPER(gvec_sar64v)(void *d, void *a, void *b, uint32_t desc) intptr_t oprsz = simd_oprsz(desc); intptr_t i; - for (i = 0; i < oprsz; i += sizeof(vec64)) { + for (i = 0; i < oprsz; i += sizeof(int64_t)) { uint8_t sh = *(uint64_t *)(b + i) & 63; *(int64_t *)(d + i) = *(int64_t *)(a + i) >> sh; }