From patchwork Mon Sep 11 08:23:49 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 721495 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D0309EE57DF for ; Mon, 11 Sep 2023 08:26:32 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id B5AE3DF6; Mon, 11 Sep 2023 10:25:40 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz B5AE3DF6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1694420790; bh=DaVdZlNoV3LCB5Kisv0pjeG9l55LN3YUTaDA9GCuIHc=; h=From:Date:Subject:References:In-Reply-To:To:Cc:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=ZZlUwJUEgWklH+RftIdicLK4yopmQPmlvPlBchuXNEGt5fD8n/UB31UvM7DPR2Zfv MtdNLF+p30EkOU95de5koJqMzy+TIa9Awm7YHVzraQdxQXyxOHo9CG2Zsy2vH/Xj30 APYgSYcOUscTmQIpPO9YumfAy5fwmZALmrdO0bAM= Received: by alsa1.perex.cz (Postfix, from userid 50401) id DA6C9F8059F; Mon, 11 Sep 2023 10:24:14 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 21C7DF805AB; Mon, 11 Sep 2023 10:24:14 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id D7123F8057B; Mon, 11 Sep 2023 10:24:04 +0200 (CEST) Received: from mail-lj1-x233.google.com (mail-lj1-x233.google.com [IPv6:2a00:1450:4864:20::233]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 2B438F80246 for ; Mon, 11 Sep 2023 10:23:52 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 2B438F80246 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=eGbum3XY Received: by mail-lj1-x233.google.com with SMTP id 38308e7fff4ca-2bcc14ea414so67292621fa.0 for ; Mon, 11 Sep 2023 01:23:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1694420631; x=1695025431; darn=alsa-project.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=dl5LD8wtUJwzoyPBhKwaRw4zVOgRkHeCisg4Hejkfc8=; b=eGbum3XYxGhQsGwGtGn2rZ8wyybL8wJ8zcxRr7Pz/DVL2+B6LznVNKByelwBmiAAPf 6jOZ1DGVp4BKClpzPB1CZySpIwccpeq+TxL0j6vaxEIF3/McBr1PXq+9AxND60iqXoQ3 4PVAfPwEs44U1z+Zs3rpTaLaYa+UpETeWNCHG3B1a5tj/Oa+cuxMc2cWWcJsHkZ0rYS2 ZqW4Fkf44HLK/QPS7/xNFLvK3gQ/L3BPelH10BGCXRzi89dMB5sJiGj1a9nQ27vpyBnz o8yWwU7N7HHtcs4Zdpe+Ty9GqHDe9n3GSrQAlgpuPM3A71lyQs/knGzdfFoUU9wtvigY obIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694420631; x=1695025431; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dl5LD8wtUJwzoyPBhKwaRw4zVOgRkHeCisg4Hejkfc8=; b=tTSFHqAlctPP4Smh/4o7EuawwttaDpIPRING20IAsYh8IyG9f8xT1WIm8oLrTP8UlV M3uhK+r4Q8C+iAM3CEICsQepAfS6hsGmkH5jY9QASAvbeicwYJ0RO5pN0jtSFh0cd+7n 9s4fe7bmorSvzwHRrX7UA5ne7Md/g4IhrnhFSuhAAbigvMEIRi56R0im031zC1C8wcAN 8Aq0Vj3A033+l8H7yy+Z4/tnF1dRHQrD0O3tR2L4rGmNqBBVPg0yy8C8oPdU8d1MCC8Q 3CLjrLqVnfKAEl9I0Yf6LmG47YqprsKQN71xVqkismwgTUMVB/g4Nl18CLZ9A4HvSnGp NOeg== X-Gm-Message-State: AOJu0YwFW85Jh9UePofi6c/z3ttahzdqX4sMUwSuwF+il67rd1dXrkrk +WOTOocNop9PpPS29cWZjXSTJQ== X-Google-Smtp-Source: AGHT+IFktZEGzVQ79iSZyPcJk9XOSRsrzr5WoeyEli+ACNX43xpOf0axceLlu9TSC+4tN8O7hIKwQw== X-Received: by 2002:a05:6512:6ca:b0:4f6:3677:54e with SMTP id u10-20020a05651206ca00b004f63677054emr8794627lff.36.1694420631650; Mon, 11 Sep 2023 01:23:51 -0700 (PDT) Received: from [127.0.1.1] ([85.235.12.238]) by smtp.gmail.com with ESMTPSA id a8-20020a19f808000000b00500968ddca9sm1247712lff.136.2023.09.11.01.23.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Sep 2023 01:23:51 -0700 (PDT) From: Linus Walleij Date: Mon, 11 Sep 2023 10:23:49 +0200 Subject: [PATCH v2 2/7] ASoC: max98357a: Drop pointless include MIME-Version: 1.0 Message-Id: <20230911-descriptors-asoc-max-v2-2-b9d793fb768e@linaro.org> References: <20230911-descriptors-asoc-max-v2-0-b9d793fb768e@linaro.org> In-Reply-To: <20230911-descriptors-asoc-max-v2-0-b9d793fb768e@linaro.org> To: Jaroslav Kysela , Takashi Iwai , Liam Girdwood , Mark Brown Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Linus Walleij X-Mailer: b4 0.12.3 Message-ID-Hash: DLSQ4ACBIZOF3BLIOW6YCISOZ3NGFYFQ X-Message-ID-Hash: DLSQ4ACBIZOF3BLIOW6YCISOZ3NGFYFQ X-MailFrom: linus.walleij@linaro.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: This driver is already using solely GPIO descriptors and do not need to include the legacy header . Drop it. Signed-off-by: Linus Walleij --- sound/soc/codecs/max98357a.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/soc/codecs/max98357a.c b/sound/soc/codecs/max98357a.c index 2a2b286f1747..cc811f58c9d2 100644 --- a/sound/soc/codecs/max98357a.c +++ b/sound/soc/codecs/max98357a.c @@ -8,7 +8,6 @@ #include #include #include -#include #include #include #include From patchwork Mon Sep 11 08:23:50 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 721496 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 02140EE57DF for ; Mon, 11 Sep 2023 08:25:52 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 3B8A0846; Mon, 11 Sep 2023 10:25:01 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 3B8A0846 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1694420751; bh=ZPOVoWflkn5ze/RL1vfcrWv4KndgatLnq+lpS515m1M=; h=From:Date:Subject:References:In-Reply-To:To:Cc:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=i90Cv8sezKZPIbAxRetPHXLyFIHdSKvWGNuEh1p8JGFI62ghbB+oGwRGvulWe//eh FeL6Oc5+4Zs3D9WIscZdP/0PkVPj6BfQkWSAAG5vUDc0r36JD/L+tWCTGf5cCs4JTz DlVycrKMGkUF0ygvmzAp9cyPnQlxHWscvwmAryoc= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 7953EF8057B; Mon, 11 Sep 2023 10:24:09 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id AF646F8057B; Mon, 11 Sep 2023 10:24:08 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id A6E7CF80570; Mon, 11 Sep 2023 10:24:03 +0200 (CEST) Received: from mail-lj1-x235.google.com (mail-lj1-x235.google.com [IPv6:2a00:1450:4864:20::235]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 9B18CF80431 for ; Mon, 11 Sep 2023 10:23:54 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 9B18CF80431 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=kTse9t7i Received: by mail-lj1-x235.google.com with SMTP id 38308e7fff4ca-2bce552508fso67712021fa.1 for ; Mon, 11 Sep 2023 01:23:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1694420632; x=1695025432; darn=alsa-project.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=NBbRRSYAQA5xmq25ubQ8kHHlKCIWtZeRLr/sb85xuNU=; b=kTse9t7iVJc5iq9wptlDVeVt/VUB7GMqnkRked5SlNfMx1+a89C+0qUrHkQOrtEOZf MItPfJFNvPDEFeitFiKVHFYJNdjXi0W8a+cMHvhtJ2xv69XQvYakaNnfbM2Wwfg7f7cY tWoU0I8AcpNTmyZwngPzg4qWUGB8Fh2dJy88AlXNNbO1X2WCEmpucU2Oj7hhIzjYYgGV nbyaKVW0w6Ahb7EFI9LCkkrUAdujKVtqEExbN8IVIlI7x3Jv0t9tEXxhJMGVjcbTR2hR 2ANltc9C3DiZSlSs/VK59s7NY441kIwJQPpAVHBVc94rb2dWrWjp935idssz7O4MmK1L tpTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694420632; x=1695025432; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NBbRRSYAQA5xmq25ubQ8kHHlKCIWtZeRLr/sb85xuNU=; b=RRWQ6wkS7+vo+DaJTTR3n5CZ9+V6JbeXT3bloc0YstY7bUG0m4Sg/KUnb2jd3xF75h dhoXE3iCzUfixcPg+a64kvOfsW4vD1gAWN6HwCfcGF2KZ+CRNDZgeDrou4Qk/Ej1JHOK Iu7AnFJgDrObWxEVhzsolno41064jOrMpG86jHKA+hskcgKRFEWs706Qv6MMJxAY7P2c On6Wy8EL94i+/3Y5vjObwVr9rz4s8c+q1DZz8zb3uoM8VV0sj/Kctg7FwLi0cwSKWvaB qHb/Hfyqzp6vz7BWd1xf3gjihlX5+m6yB8GsYYIlCIJliDPkLYSsc0aKa8fanCta0mDm aWzA== X-Gm-Message-State: AOJu0Yxb4eTVsVQrOqk7FZQQ24E9LkfTsf6eS7J6oTTkF4l3NB8SSiBY npux9jA6BN+yo+ONZyUy5x8zdg== X-Google-Smtp-Source: AGHT+IE795z4MeyvcfiIIYPz/bYjnDK/11+Ubx+DKYPxh6E6lvf7/Sxx7I8bOqlaNVa5jarhNcJo9w== X-Received: by 2002:a05:6512:398a:b0:4fd:d213:dfd4 with SMTP id j10-20020a056512398a00b004fdd213dfd4mr8795699lfu.20.1694420632485; Mon, 11 Sep 2023 01:23:52 -0700 (PDT) Received: from [127.0.1.1] ([85.235.12.238]) by smtp.gmail.com with ESMTPSA id a8-20020a19f808000000b00500968ddca9sm1247712lff.136.2023.09.11.01.23.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Sep 2023 01:23:52 -0700 (PDT) From: Linus Walleij Date: Mon, 11 Sep 2023 10:23:50 +0200 Subject: [PATCH v2 3/7] ASoC: max98373: Convert to use GPIO descriptors MIME-Version: 1.0 Message-Id: <20230911-descriptors-asoc-max-v2-3-b9d793fb768e@linaro.org> References: <20230911-descriptors-asoc-max-v2-0-b9d793fb768e@linaro.org> In-Reply-To: <20230911-descriptors-asoc-max-v2-0-b9d793fb768e@linaro.org> To: Jaroslav Kysela , Takashi Iwai , Liam Girdwood , Mark Brown Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Linus Walleij X-Mailer: b4 0.12.3 Message-ID-Hash: XNGZT6GCMVAIXZB657E2IR4E2DZ75RZN X-Message-ID-Hash: XNGZT6GCMVAIXZB657E2IR4E2DZ75RZN X-MailFrom: linus.walleij@linaro.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Instead of relying on legacy interfaces, convert the driver to use GPIO descriptors. This is a straight-forward conversion, we support also sdw devices providing GPIO descriptor tables if they so desire. Signed-off-by: Linus Walleij --- sound/soc/codecs/max98373-i2c.c | 17 ----------------- sound/soc/codecs/max98373.c | 35 +++++++++++++++++++---------------- sound/soc/codecs/max98373.h | 2 +- 3 files changed, 20 insertions(+), 34 deletions(-) diff --git a/sound/soc/codecs/max98373-i2c.c b/sound/soc/codecs/max98373-i2c.c index 0fa5ceca62a2..e7ec7875c4a9 100644 --- a/sound/soc/codecs/max98373-i2c.c +++ b/sound/soc/codecs/max98373-i2c.c @@ -3,12 +3,10 @@ #include #include -#include #include #include #include #include -#include #include #include #include @@ -560,21 +558,6 @@ static int max98373_i2c_probe(struct i2c_client *i2c) /* voltage/current slot & gpio configuration */ max98373_slot_config(&i2c->dev, max98373); - /* Power on device */ - if (gpio_is_valid(max98373->reset_gpio)) { - ret = devm_gpio_request(&i2c->dev, max98373->reset_gpio, - "MAX98373_RESET"); - if (ret) { - dev_err(&i2c->dev, "%s: Failed to request gpio %d\n", - __func__, max98373->reset_gpio); - return -EINVAL; - } - gpio_direction_output(max98373->reset_gpio, 0); - msleep(50); - gpio_direction_output(max98373->reset_gpio, 1); - msleep(20); - } - /* Check Revision ID */ ret = regmap_read(max98373->regmap, MAX98373_R21FF_REV_ID, ®); diff --git a/sound/soc/codecs/max98373.c b/sound/soc/codecs/max98373.c index fde055c6c894..33eb4576da23 100644 --- a/sound/soc/codecs/max98373.c +++ b/sound/soc/codecs/max98373.c @@ -12,9 +12,8 @@ #include #include #include -#include +#include #include -#include #include #include "max98373.h" @@ -478,20 +477,24 @@ void max98373_slot_config(struct device *dev, max98373->i_slot = value & 0xF; else max98373->i_slot = 1; - if (dev->of_node) { - max98373->reset_gpio = of_get_named_gpio(dev->of_node, - "maxim,reset-gpio", 0); - if (!gpio_is_valid(max98373->reset_gpio)) { - dev_err(dev, "Looking up %s property in node %s failed %d\n", - "maxim,reset-gpio", dev->of_node->full_name, - max98373->reset_gpio); - } else { - dev_dbg(dev, "maxim,reset-gpio=%d", - max98373->reset_gpio); - } - } else { - /* this makes reset_gpio as invalid */ - max98373->reset_gpio = -1; + + /* This will assert RESET */ + max98373->reset = devm_gpiod_get_optional(dev, + "maxim,reset", + GPIOD_OUT_HIGH); + if (IS_ERR(max98373->reset)) { + dev_err(dev, "error %ld looking up RESET GPIO line\n", + PTR_ERR(max98373->reset)); + return; + } + + /* Cycle reset */ + if (max98373->reset) { + gpiod_set_consumer_name(max98373->reset ,"MAX98373_RESET"); + gpiod_direction_output(max98373->reset, 1); + msleep(50); + gpiod_direction_output(max98373->reset, 0); + msleep(20); } if (!device_property_read_u32(dev, "maxim,spkfb-slot-no", &value)) diff --git a/sound/soc/codecs/max98373.h b/sound/soc/codecs/max98373.h index e1810b3b1620..af3b62217497 100644 --- a/sound/soc/codecs/max98373.h +++ b/sound/soc/codecs/max98373.h @@ -213,7 +213,7 @@ struct max98373_cache { struct max98373_priv { struct regmap *regmap; - int reset_gpio; + struct gpio_desc *reset; unsigned int v_slot; unsigned int i_slot; unsigned int spkfb_slot; From patchwork Mon Sep 11 08:23:52 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 721494 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 54EBBEE57DF for ; Mon, 11 Sep 2023 08:27:02 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 57052E73; Mon, 11 Sep 2023 10:26:10 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 57052E73 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1694420820; bh=Uz6E8HLxWI35ovCMD+J5so9kCTh/4AIEHtwt/doxIgs=; h=From:Date:Subject:References:In-Reply-To:To:Cc:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=IcMs8sWUz8bnsJ9aD4vRMjpUrr5T9mbShoCCqiMm5OsAx2z6pOsojseiU5tUPDuB+ 3/+L/ip1Xk10BG93jD6+eUDo5WZOe1EA3P0gipu9CwsRkbL7BsRi8hQnovu3Qd1AFs JALsJsPn20lao1Zt0JENa9kWg6jQfxalXr+Yafoc= Received: by alsa1.perex.cz (Postfix, from userid 50401) id EFEEFF805CB; Mon, 11 Sep 2023 10:24:18 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 60D08F805BF; Mon, 11 Sep 2023 10:24:18 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 9FFF3F8047D; Mon, 11 Sep 2023 10:24:06 +0200 (CEST) Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [IPv6:2a00:1450:4864:20::132]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 5BDADF80425 for ; Mon, 11 Sep 2023 10:23:55 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 5BDADF80425 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=OHKKqAGe Received: by mail-lf1-x132.google.com with SMTP id 2adb3069b0e04-5029ace4a28so3604690e87.1 for ; Mon, 11 Sep 2023 01:23:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1694420634; x=1695025434; darn=alsa-project.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=d/HhJkYfqyaXs9yIGYFPPzlpsmAC+qKTgrrYF36b8es=; b=OHKKqAGeqPhss5IfEpDGVr7WWjbmCKvsiTQ9XxiKyJvJKKRCkjmJHw3OL2aV8n8C8p N75Z+kQCiduc1eQX9GM5fCw8bSphkry5maVbLFbm20P74+FXPaSHdASk41zVYQ+l2bYy 4daHhjgRXhyCa8J0u/Z7KxAx+iTEOFEqCc9NXTy8M63FCQU0NQDYpItjZ3uhke4xyNi/ EUdYjLydc2sjRz8mu+xN5SNd/DVs4l4ZR2jt7HGFxjnkdiaKX6FU+SEZbmty1D8IozKb EX1H7/7evATt79snmn5mYow+lwXpUl+aVwDsiTD9KiPZub1xeBGeC6bqWztaIfnSQ0pq QDsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694420634; x=1695025434; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=d/HhJkYfqyaXs9yIGYFPPzlpsmAC+qKTgrrYF36b8es=; b=LFT0S6PS4Vm5+rsuWYTpid/WBWHuIhXunxbF5tVKd5ikl9JODzwkz9WIfEpQnsvOhD 4s+YV4ptDWYKMqdF2xRByB/xuzT9J51111Uu0udVtiW2b+QDCgu7r9jPA/aaTwu2DD2O BkQCqvf+pFuKsfqBFsR8DmBniccjWblFl7O4JMTLEXISZnvVxRAvVprY4wVIwv06/dnh O9wptP13uu0KH/m1JfbRmR4kwIxPXYybJAcu4ShGOiV7DgxcYGSCG6y/KV2fKNabyUMK Lkan+xBPUbql7EJz8pRfDzFOaDhkgnwYLWBR4dLX3Jdky/CoZC+gOpW/ajT9l0EbdkBI H+1w== X-Gm-Message-State: AOJu0Yxy6UoO1PbACVkiF97aV9z/jXAjeArx99rHYev3rXrGkXmobNRk mHl3G/WYXk0S8IqKQod9IvJqmw== X-Google-Smtp-Source: AGHT+IE6WCFsa0bFZLixppvL9WUrXFO38to59wdYHxNCXTqD4Xc/xeONINSL8v0RojtmsjmZbNdCFA== X-Received: by 2002:a05:6512:3f14:b0:500:d96e:f6eb with SMTP id y20-20020a0565123f1400b00500d96ef6ebmr3927961lfa.19.1694420634181; Mon, 11 Sep 2023 01:23:54 -0700 (PDT) Received: from [127.0.1.1] ([85.235.12.238]) by smtp.gmail.com with ESMTPSA id a8-20020a19f808000000b00500968ddca9sm1247712lff.136.2023.09.11.01.23.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Sep 2023 01:23:53 -0700 (PDT) From: Linus Walleij Date: Mon, 11 Sep 2023 10:23:52 +0200 Subject: [PATCH v2 5/7] ASoC: max98396: Drop pointless include MIME-Version: 1.0 Message-Id: <20230911-descriptors-asoc-max-v2-5-b9d793fb768e@linaro.org> References: <20230911-descriptors-asoc-max-v2-0-b9d793fb768e@linaro.org> In-Reply-To: <20230911-descriptors-asoc-max-v2-0-b9d793fb768e@linaro.org> To: Jaroslav Kysela , Takashi Iwai , Liam Girdwood , Mark Brown Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Linus Walleij X-Mailer: b4 0.12.3 Message-ID-Hash: 6UXVML3ZB4B3JGRK33IU5JZIFYOX5ICT X-Message-ID-Hash: 6UXVML3ZB4B3JGRK33IU5JZIFYOX5ICT X-MailFrom: linus.walleij@linaro.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: This driver is already using solely GPIO descriptors and do not need to include the legacy header . Drop it. Signed-off-by: Linus Walleij --- sound/soc/codecs/max98396.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/soc/codecs/max98396.c b/sound/soc/codecs/max98396.c index 3a1d8c211f3c..e52bb2266fa1 100644 --- a/sound/soc/codecs/max98396.c +++ b/sound/soc/codecs/max98396.c @@ -7,7 +7,6 @@ #include #include #include -#include #include #include "max98396.h"