From patchwork Fri Jul 26 11:28:12 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Anders Roxell X-Patchwork-Id: 169821 Delivered-To: patch@linaro.org Received: by 2002:a92:4782:0:0:0:0:0 with SMTP id e2csp12909549ilk; Fri, 26 Jul 2019 04:28:21 -0700 (PDT) X-Google-Smtp-Source: APXvYqyy2/9bWUfL03xCnRyrFSeTFWilIiR7/tk5S0j7FuWRbC8VRiIhPYi6hUVrnZ4nkfLgwEBU X-Received: by 2002:a63:fb14:: with SMTP id o20mr78907850pgh.136.1564140501352; Fri, 26 Jul 2019 04:28:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564140501; cv=none; d=google.com; s=arc-20160816; b=WiCgC/Jxpv2hv6CkLqzYpvKkvruTjzH0xxm/g5Ko0BUx/FU+EwjPKBizKUfI/UnZZB Q5xEUo3Fe4LSsTHV6SO80jM3EtOzUFhaATJgFfAhAEayavYRQkyPSX9HdoDoSvirNlB1 YVQh20/xojBQECyJCQOhzrDTia9mG8X8u1hTeAN7iWoPJVJ0hOQ/WoaG7ZMSkd1yvXkY mDCh/+fkS/rQrrggbS8+C/lP1XU8kuJwa4ZAlUWyeeypMW9jcdgpD3vBlN9JzgInMeup r5egKtqBStozvSBx/ZKPIq8uygsS6dm5OktxXElZXNXI5ZfXBUwM8WbSKAonVmaMuumb gJhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=yms7A0Dj/ss/bfob7fvSwoSoaN3YOnXapMDkDt2JkGk=; b=TSXZNMG+pAezdOd5gTAIFj2GznvHpb9AMKNiT2Mqipl+3AKin9P1q4KLqsH0Zb8xTL TpER6b/CquGcTzOvXqYSsRI0mS+dzXCYmTsW4j9HF+aylh2jqprJ/2H1eKgiTFmsSn0s cTStoqcgsZtN8I1tyX+jWwXJn7l5lMZIkVWNGsUm+R6RW+IxFVfmfJsT9Yk8h/zBdS9r ZG+3KB/tZvXp58RTaGGZIHTFuRmulbd1XRf7pTlPG9iPoZ4HU3Rg0qWS8xmH49JpLbb4 KgAVAQDkOzw0dAr0AQKcL83/FQD9mjXbwK8v0QqK2Z+DyuIPX7P0l/1GfVPuhvXSjbYS +xrw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=dI3W3+aY; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s6si18634212pgs.96.2019.07.26.04.28.21; Fri, 26 Jul 2019 04:28:21 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=dI3W3+aY; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726148AbfGZL2T (ORCPT + 29 others); Fri, 26 Jul 2019 07:28:19 -0400 Received: from mail-lf1-f65.google.com ([209.85.167.65]:41649 "EHLO mail-lf1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726535AbfGZL2S (ORCPT ); Fri, 26 Jul 2019 07:28:18 -0400 Received: by mail-lf1-f65.google.com with SMTP id 62so31972929lfa.8 for ; Fri, 26 Jul 2019 04:28:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=yms7A0Dj/ss/bfob7fvSwoSoaN3YOnXapMDkDt2JkGk=; b=dI3W3+aYZkRhr2cVhzUptcUM2pwVVATteZ4VZ3NtR71AqBqGIYfrf8yrxzStuM+3nE tya5Wiu6pzLKkBX88Pc9jxDP11Kp2Nb7gJvFfjHY3wHbyJTa9MjgkhXMMSLglyktzkm3 rtfP0GDsu4nDfg7oDxj6j5NfrKRKG9nFa1yKVgkG+vm4TleEGCA4h4MB8cJEZeWnFrVx 66ajVkJqxzTBxoq8QcMEGK7KzPudl9gdTSkKZ9JTKZKCDGv4Ao7DdYIPa5uPBiKKxwIV QUSwtaEwhzZ9sq1FGfEOxB2hVT7HFBdpqVMA8nbZVRahng8T1uE6i7OUfifFilHWGBbe be7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=yms7A0Dj/ss/bfob7fvSwoSoaN3YOnXapMDkDt2JkGk=; b=UKXOaJBd0Yd47GMBfu8MSWV2ACxtrx021KiZPc1Yz1YnJu/FxcOCqV61CL6YZYPCdG 0LmluNzkWLnnjfm4Vvg0CsOWVuPKCHR7zUV0Iquv3LmIRKj80rE4GKou9Krunpfs2kRX kVXdlUf2MuocZk8IhaK82awku5KjmJ4xadm7gvmje24A2+vHzwfs3gWsyuMjGxVX214e ivd/WH9td98hst3Xa+3Hk61rQuqqqz0Sc6dRBzquaa8Tj76+38PTuJ1DRT9fs8qqzsb8 5Jf2xlxb7T7KTS4TjsYEsnSx4+UjXGwZSZx9UdSkBdA5zTfa5VPIFVUlaaXFSiQUwbh7 s+Gg== X-Gm-Message-State: APjAAAV9qjbgdAd28/QTcaLkFCbI+cr5mNw+WRtw8O2LV90PrvI5GcJU wtyiShtKLrTvgoQ4HERaP07Jqg== X-Received: by 2002:a19:be03:: with SMTP id o3mr43992429lff.88.1564140496719; Fri, 26 Jul 2019 04:28:16 -0700 (PDT) Received: from localhost (c-243c70d5.07-21-73746f28.bbcust.telenor.se. [213.112.60.36]) by smtp.gmail.com with ESMTPSA id b27sm10020400ljb.11.2019.07.26.04.28.15 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 26 Jul 2019 04:28:16 -0700 (PDT) From: Anders Roxell To: linus.walleij@linaro.org, heiko@sntech.de Cc: bjorn.andersson@linaro.org, agross@kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Anders Roxell Subject: [PATCH 1/2] pinctrl: rockchip: Mark expected switch fall-through Date: Fri, 26 Jul 2019 13:28:12 +0200 Message-Id: <20190726112812.19665-1-anders.roxell@linaro.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When fall-through warnings was enabled by default the following warning was starting to show up: ../drivers/pinctrl/pinctrl-rockchip.c: In function ‘rockchip_gpio_set_config’: ../drivers/pinctrl/pinctrl-rockchip.c:2783:3: warning: this statement may fall through [-Wimplicit-fallthrough=] rockchip_gpio_set_debounce(gc, offset, true); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../drivers/pinctrl/pinctrl-rockchip.c:2795:2: note: here default: ^~~~~~~ Rework so that the compiler doesn't warn about fall-through. Add 'return -ENOTSUPP;' to match the comment. Fixes: d93512ef0f0e ("Makefile: Globally enable fall-through warning") Signed-off-by: Anders Roxell --- drivers/pinctrl/pinctrl-rockchip.c | 1 + 1 file changed, 1 insertion(+) -- 2.20.1 diff --git a/drivers/pinctrl/pinctrl-rockchip.c b/drivers/pinctrl/pinctrl-rockchip.c index 62a622159006..dc0bbf198cbc 100644 --- a/drivers/pinctrl/pinctrl-rockchip.c +++ b/drivers/pinctrl/pinctrl-rockchip.c @@ -2792,6 +2792,7 @@ static int rockchip_gpio_set_config(struct gpio_chip *gc, unsigned int offset, * still return -ENOTSUPP as before, to make sure the caller * of gpiod_set_debounce won't change its behaviour. */ + return -ENOTSUPP; default: return -ENOTSUPP; }