From patchwork Sat Oct 14 17:26:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Otto_Pfl=C3=BCger?= X-Patchwork-Id: 733900 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5EDFFCDB483 for ; Sun, 15 Oct 2023 13:47:27 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 2FF42836; Sun, 15 Oct 2023 15:46:35 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 2FF42836 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1697377645; bh=QP+XkK0m9P2yYvBKdtljbcAXsrYp/xyq9j9O8Q02ItU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=t3ikms39RZB+yEbomaC9C+60lqmxg1RRxzAIc04JGK4ERxnVPjAe2MfZFIo0isnTr Gsa+L8hdNxdx3ZWPfRIzfSrfL5fX+/jVvGPx37pkU6VlhXjaKoo9h5rlnx6Poq139m RopOsBRK9/NxjsUYFLvtpfcOeNcWSywt3dmcrcWU= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 0CF11F8055C; Sun, 15 Oct 2023 15:45:39 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 621BDF8055C; Sun, 15 Oct 2023 15:45:39 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 13CABF8027B; Sat, 14 Oct 2023 19:29:49 +0200 (CEST) Received: from srv01.abscue.de (abscue.de [IPv6:2a03:4000:63:bf5:4817:8eff:feeb:8ac7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 19D76F802E8 for ; Sat, 14 Oct 2023 19:28:52 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 19D76F802E8 Received: from srv01.abscue.de (localhost [127.0.0.1]) by spamfilter.srv.local (Postfix) with ESMTP id 874741C0728; Sat, 14 Oct 2023 19:28:51 +0200 (CEST) Received: from fluffy-mammal.fritz.box (dslb-088-078-204-065.088.078.pools.vodafone-ip.de [88.78.204.65]) by srv01.abscue.de (Postfix) with ESMTPSA id 2BA9F1C072A; Sat, 14 Oct 2023 19:28:51 +0200 (CEST) From: =?utf-8?q?Otto_Pfl=C3=BCger?= To: linux-arm-msm@vger.kernel.org Cc: Srinivas Kandagatla , Banajit Goswami , Liam Girdwood , Mark Brown , alsa-devel@alsa-project.org, ~postmarketos/upstreaming@lists.sr.ht, =?utf-8?q?Otto_Pfl=C3=BCger?= Subject: [PATCH 1/3] ASoC: qcom: q6core: expose ADSP core firmware version Date: Sat, 14 Oct 2023 19:26:22 +0200 Message-Id: <20231014172624.75301-2-otto.pflueger@abscue.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231014172624.75301-1-otto.pflueger@abscue.de> References: <20231014172624.75301-1-otto.pflueger@abscue.de> MIME-Version: 1.0 X-MailFrom: otto.pflueger@abscue.de X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1 Message-ID-Hash: SL43QPUIXMBWXKC2MYYCHR3BJQANE2WI X-Message-ID-Hash: SL43QPUIXMBWXKC2MYYCHR3BJQANE2WI X-Mailman-Approved-At: Sun, 15 Oct 2023 13:43:36 +0000 X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Add a q6core_get_adsp_version() function that returns the version of the ADSP firmware (2.6, 2.7 or 2.8), also known as the AVS version (see [1] in downstream kernel). Some APIs differ between these versions, e.g. the AFE clock APIs. [1]: https://github.com/msm8916-mainline/linux-downstream/blob/LA.BR.1.2.9.1_rb1.5/sound/soc/msm/qdsp6v2/q6core.c#L193 Signed-off-by: Otto Pflüger --- sound/soc/qcom/qdsp6/q6core.c | 61 +++++++++++++++++++++++++++++++++++ sound/soc/qcom/qdsp6/q6core.h | 9 ++++++ 2 files changed, 70 insertions(+) diff --git a/sound/soc/qcom/qdsp6/q6core.c b/sound/soc/qcom/qdsp6/q6core.c index 49cfb32cd209..ea6232645c80 100644 --- a/sound/soc/qcom/qdsp6/q6core.c +++ b/sound/soc/qcom/qdsp6/q6core.c @@ -20,6 +20,9 @@ #define AVCS_CMDRSP_ADSP_EVENT_GET_STATE 0x0001290D #define AVCS_GET_VERSIONS 0x00012905 #define AVCS_GET_VERSIONS_RSP 0x00012906 +#define AVCS_CMDRSP_Q6_ID_2_6 0x00040000 +#define AVCS_CMDRSP_Q6_ID_2_7 0x00040001 +#define AVCS_CMDRSP_Q6_ID_2_8 0x00040002 #define AVCS_CMD_GET_FWK_VERSION 0x001292c #define AVCS_CMDRSP_GET_FWK_VERSION 0x001292d @@ -63,6 +66,7 @@ struct q6core { bool get_state_supported; bool get_version_supported; bool is_version_requested; + enum q6core_version adsp_version; }; static struct q6core *g_core; @@ -108,6 +112,14 @@ static int q6core_callback(struct apr_device *adev, struct apr_resp_pkt *data) if (!core->fwk_version) return -ENOMEM; + /* + * Since GET_VERSIONS is not called when GET_FWK_VERSION + * is successful and these commands may return completely + * different versions, assume that the version is 2.8 here. + * Older versions do not support GET_FWK_VERSION and we do + * not care if the version is newer than 2.8. + */ + core->adsp_version = Q6_ADSP_VERSION_2_8; core->fwk_version_supported = true; core->resp_received = true; @@ -115,6 +127,7 @@ static int q6core_callback(struct apr_device *adev, struct apr_resp_pkt *data) } case AVCS_GET_VERSIONS_RSP: { struct avcs_cmdrsp_get_version *v; + int i; v = data->payload; @@ -125,6 +138,28 @@ static int q6core_callback(struct apr_device *adev, struct apr_resp_pkt *data) if (!core->svc_version) return -ENOMEM; + for (i = 0; i < g_core->svc_version->num_services; i++) { + struct avcs_svc_info *info; + + info = &g_core->svc_version->svc_api_info[i]; + if (info->service_id != APR_SVC_ADSP_CORE) + continue; + + switch (info->version) { + case AVCS_CMDRSP_Q6_ID_2_6: + core->adsp_version = Q6_ADSP_VERSION_2_6; + break; + case AVCS_CMDRSP_Q6_ID_2_7: + core->adsp_version = Q6_ADSP_VERSION_2_7; + break; + case AVCS_CMDRSP_Q6_ID_2_8: + core->adsp_version = Q6_ADSP_VERSION_2_8; + break; + } + + break; + } + core->get_version_supported = true; core->resp_received = true; @@ -293,6 +328,31 @@ int q6core_get_svc_api_info(int svc_id, struct q6core_svc_api_info *ainfo) } EXPORT_SYMBOL_GPL(q6core_get_svc_api_info); +/** + * q6core_get_adsp_version() - Get the core version number. + * + * Return: version code or Q6_ADSP_VERSION_UNKNOWN on failure + */ +enum q6core_version q6core_get_adsp_version(void) +{ + int ret; + + if (!g_core) + return Q6_ADSP_VERSION_UNKNOWN; + + mutex_lock(&g_core->lock); + if (!g_core->is_version_requested) { + if (q6core_get_fwk_versions(g_core) == -ENOTSUPP) + q6core_get_svc_versions(g_core); + g_core->is_version_requested = true; + } + ret = g_core->adsp_version; + mutex_unlock(&g_core->lock); + + return ret; +} +EXPORT_SYMBOL_GPL(q6core_get_adsp_version); + /** * q6core_is_adsp_ready() - Get status of adsp * @@ -334,6 +394,7 @@ static int q6core_probe(struct apr_device *adev) dev_set_drvdata(&adev->dev, g_core); mutex_init(&g_core->lock); + g_core->adsp_version = Q6_ADSP_VERSION_UNKNOWN; g_core->adev = adev; init_waitqueue_head(&g_core->wait); return 0; diff --git a/sound/soc/qcom/qdsp6/q6core.h b/sound/soc/qcom/qdsp6/q6core.h index 4105b1d730be..472e06bf8efc 100644 --- a/sound/soc/qcom/qdsp6/q6core.h +++ b/sound/soc/qcom/qdsp6/q6core.h @@ -9,7 +9,16 @@ struct q6core_svc_api_info { uint32_t api_branch_version; }; +/* Versions must be in order! */ +enum q6core_version { + Q6_ADSP_VERSION_UNKNOWN, + Q6_ADSP_VERSION_2_6, + Q6_ADSP_VERSION_2_7, + Q6_ADSP_VERSION_2_8, +}; + bool q6core_is_adsp_ready(void); +enum q6core_version q6core_get_adsp_version(void); int q6core_get_svc_api_info(int svc_id, struct q6core_svc_api_info *ainfo); #endif /* __Q6CORE_H__ */ From patchwork Sat Oct 14 17:26:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Otto_Pfl=C3=BCger?= X-Patchwork-Id: 734036 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EC18CCDB47E for ; Sun, 15 Oct 2023 13:47:24 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 7D8BFAE9; Sun, 15 Oct 2023 15:46:27 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 7D8BFAE9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1697377637; bh=X5fflmeN7u+e+b54FwITiS8qez2MICF1NpV7PsPk1QY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=VcoB0f/bRczuPlwgpzeU0SehEEz7Q7A9fU75FO7J46wAzddlGGNzGM4GzhXmG29eF kwaYMMtCRfYttN/D6ce6PWTvqRUiLU+HXNd8Vqvc6MP5ALUzRA3FTb5KGayBHjAdB5 gq49sUeYvUWZ9aQ5+AE+/UdZ/wO4TjyOvOD/m1kk= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 523E7F8055B; Sun, 15 Oct 2023 15:45:38 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id B8C54F8055B; Sun, 15 Oct 2023 15:45:37 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id D61EFF8027B; Sat, 14 Oct 2023 19:29:06 +0200 (CEST) Received: from srv01.abscue.de (abscue.de [89.58.28.240]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 15AACF802BE for ; Sat, 14 Oct 2023 19:28:52 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 15AACF802BE Received: from srv01.abscue.de (localhost [127.0.0.1]) by spamfilter.srv.local (Postfix) with ESMTP id EEDF61C072A; Sat, 14 Oct 2023 19:28:51 +0200 (CEST) Received: from fluffy-mammal.fritz.box (dslb-088-078-204-065.088.078.pools.vodafone-ip.de [88.78.204.65]) by srv01.abscue.de (Postfix) with ESMTPSA id 935741C072B; Sat, 14 Oct 2023 19:28:51 +0200 (CEST) From: =?utf-8?q?Otto_Pfl=C3=BCger?= To: linux-arm-msm@vger.kernel.org Cc: Srinivas Kandagatla , Banajit Goswami , Liam Girdwood , Mark Brown , alsa-devel@alsa-project.org, ~postmarketos/upstreaming@lists.sr.ht, =?utf-8?q?Otto_Pfl=C3=BCger?= Subject: [PATCH 2/3] ASoC: qcom: q6afe: check ADSP version when setting clocks Date: Sat, 14 Oct 2023 19:26:23 +0200 Message-Id: <20231014172624.75301-3-otto.pflueger@abscue.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231014172624.75301-1-otto.pflueger@abscue.de> References: <20231014172624.75301-1-otto.pflueger@abscue.de> MIME-Version: 1.0 X-MailFrom: otto.pflueger@abscue.de X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1 Message-ID-Hash: VIUQMVJWRDOA7TYL2OICZAMBNCBCYST5 X-Message-ID-Hash: VIUQMVJWRDOA7TYL2OICZAMBNCBCYST5 X-Mailman-Approved-At: Sun, 15 Oct 2023 13:43:36 +0000 X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: There are two APIs for setting clocks: the old one that uses AFE_PARAM_ID_INT_DIGITAL_CDC_CLK_CONFIG and AFE_PARAM_ID_LPAIF_CLK_CONFIG, and the new one which uses AFE_PARAM_ID_CLOCK_SET. ADSP firmware version 2.6 only provides the old API, while newer firmware versions only provide the new API. Implement LPAIF_BIT_CLK and LPAIF_DIG_CLK for both APIs so that users don't have to care about the firmware version. Also fall back to setting AFE_PARAM_ID_INT_DIGITAL_CDC_CLK_CONFIG in q6afe_set_lpass_clock when setting the new Q6AFE_LPASS_CLK_ID_INTERNAL_DIGITAL_CODEC_CORE clock is requested to allow specifying it in the device tree on older platforms too. Signed-off-by: Otto Pflüger --- sound/soc/qcom/qdsp6/q6afe.c | 81 ++++++++++++++++++++++++++++++++++++ 1 file changed, 81 insertions(+) diff --git a/sound/soc/qcom/qdsp6/q6afe.c b/sound/soc/qcom/qdsp6/q6afe.c index 91d39f6ad0bd..87bdf741e5f6 100644 --- a/sound/soc/qcom/qdsp6/q6afe.c +++ b/sound/soc/qcom/qdsp6/q6afe.c @@ -1111,6 +1111,32 @@ int q6afe_set_lpass_clock(struct device *dev, int clk_id, int attri, struct q6afe *afe = dev_get_drvdata(dev->parent); struct afe_clk_set cset = {0,}; + /* + * v2 clocks specified in the device tree may not be supported by the + * firmware. If this is the digital codec core clock, fall back to the + * old method for setting it. + */ + if (q6core_get_adsp_version() < Q6_ADSP_VERSION_2_7) { + struct q6afe_port *port; + struct afe_digital_clk_cfg dcfg = {0,}; + int ret; + + if (clk_id != Q6AFE_LPASS_CLK_ID_INTERNAL_DIGITAL_CODEC_CORE) + return -EINVAL; + + port = q6afe_port_get_from_id(dev, PRIMARY_MI2S_RX); + if (IS_ERR(port)) + return PTR_ERR(port); + + dcfg.i2s_cfg_minor_version = AFE_API_VERSION_I2S_CONFIG; + dcfg.clk_val = freq; + dcfg.clk_root = 5; + ret = q6afe_set_digital_codec_core_clock(port, &dcfg); + + q6afe_port_put(port); + return ret; + } + cset.clk_set_minor_version = AFE_API_VERSION_CLOCK_SET; cset.clk_id = clk_id; cset.clk_freq_in_hz = freq; @@ -1124,6 +1150,41 @@ int q6afe_set_lpass_clock(struct device *dev, int clk_id, int attri, } EXPORT_SYMBOL_GPL(q6afe_set_lpass_clock); +static int q6afe_get_v2_bit_clk_id(struct q6afe_port *port) +{ + switch (port->id) { + case AFE_PORT_ID_PRIMARY_MI2S_RX: + case AFE_PORT_ID_PRIMARY_MI2S_TX: + return Q6AFE_LPASS_CLK_ID_PRI_MI2S_IBIT; + case AFE_PORT_ID_SECONDARY_MI2S_RX: + case AFE_PORT_ID_SECONDARY_MI2S_TX: + return Q6AFE_LPASS_CLK_ID_SEC_MI2S_IBIT; + case AFE_PORT_ID_TERTIARY_MI2S_RX: + case AFE_PORT_ID_TERTIARY_MI2S_TX: + return Q6AFE_LPASS_CLK_ID_TER_MI2S_IBIT; + case AFE_PORT_ID_QUATERNARY_MI2S_RX: + case AFE_PORT_ID_QUATERNARY_MI2S_TX: + return Q6AFE_LPASS_CLK_ID_TER_MI2S_IBIT; + case AFE_PORT_ID_QUINARY_MI2S_RX: + case AFE_PORT_ID_QUINARY_MI2S_TX: + return Q6AFE_LPASS_CLK_ID_QUI_MI2S_IBIT; + + case AFE_PORT_ID_PRIMARY_TDM_RX ... AFE_PORT_ID_PRIMARY_TDM_TX_7: + return Q6AFE_LPASS_CLK_ID_PRI_TDM_IBIT; + case AFE_PORT_ID_SECONDARY_TDM_RX ... AFE_PORT_ID_SECONDARY_TDM_TX_7: + return Q6AFE_LPASS_CLK_ID_SEC_TDM_IBIT; + case AFE_PORT_ID_TERTIARY_TDM_RX ... AFE_PORT_ID_TERTIARY_TDM_TX_7: + return Q6AFE_LPASS_CLK_ID_TER_TDM_IBIT; + case AFE_PORT_ID_QUATERNARY_TDM_RX ... AFE_PORT_ID_QUATERNARY_TDM_TX_7: + return Q6AFE_LPASS_CLK_ID_QUAD_TDM_IBIT; + case AFE_PORT_ID_QUINARY_TDM_RX ... AFE_PORT_ID_QUINARY_TDM_TX_7: + return Q6AFE_LPASS_CLK_ID_QUIN_TDM_IBIT; + + default: + return -EINVAL; + } +} + int q6afe_port_set_sysclk(struct q6afe_port *port, int clk_id, int clk_src, int clk_root, unsigned int freq, int dir) @@ -1133,6 +1194,26 @@ int q6afe_port_set_sysclk(struct q6afe_port *port, int clk_id, struct afe_digital_clk_cfg dcfg = {0,}; int ret; + if (q6core_get_adsp_version() >= Q6_ADSP_VERSION_2_7) { + /* Always use the new clock API on newer platforms. */ + switch (clk_id) { + case LPAIF_DIG_CLK: + clk_src = Q6AFE_LPASS_CLK_ATTRIBUTE_COUPLE_NO; + clk_root = Q6AFE_LPASS_CLK_ROOT_DEFAULT; + clk_id = Q6AFE_LPASS_CLK_ID_INTERNAL_DIGITAL_CODEC_CORE; + break; + case LPAIF_BIT_CLK: + clk_src = Q6AFE_LPASS_CLK_ATTRIBUTE_COUPLE_NO; + clk_root = Q6AFE_LPASS_CLK_ROOT_DEFAULT; + clk_id = q6afe_get_v2_bit_clk_id(port); + if (clk_id < 0) + return clk_id; + break; + default: + break; + } + } + switch (clk_id) { case LPAIF_DIG_CLK: dcfg.i2s_cfg_minor_version = AFE_API_VERSION_I2S_CONFIG; From patchwork Sat Oct 14 17:26:24 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Otto_Pfl=C3=BCger?= X-Patchwork-Id: 733901 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1A9CFCDB47E for ; Sun, 15 Oct 2023 13:46:57 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 354D0857; Sun, 15 Oct 2023 15:46:05 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 354D0857 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1697377615; bh=LKohZblb+4Nfe37bgBE2mPB6PqvsaNPG2Hp2olGZHVo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=gpZRP6oZ2YW0jxUpfE9NGi6+6KNG9/LKil9qNLaZmgCCeE1BAU1oIaOUZlghyr9Qa z1SpcD12QSZI5wgKmJteedH43xe53hJuUWeQbEMc7ORzenQtJODgch2KVbOOT8MeVB qcjs8sLi0sKJhY8sHJKoSg8abgA6ZrtA5t7MW4DA= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 620E5F8032D; Sun, 15 Oct 2023 15:45:36 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 0EE46F8025F; Sun, 15 Oct 2023 15:45:36 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id B0EEFF80310; Sat, 14 Oct 2023 19:29:02 +0200 (CEST) Received: from srv01.abscue.de (abscue.de [89.58.28.240]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 12F48F8015B for ; Sat, 14 Oct 2023 19:28:52 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 12F48F8015B Received: from srv01.abscue.de (localhost [127.0.0.1]) by spamfilter.srv.local (Postfix) with ESMTP id 53B811C072B; Sat, 14 Oct 2023 19:28:52 +0200 (CEST) Received: from fluffy-mammal.fritz.box (dslb-088-078-204-065.088.078.pools.vodafone-ip.de [88.78.204.65]) by srv01.abscue.de (Postfix) with ESMTPSA id 058F31C072C; Sat, 14 Oct 2023 19:28:51 +0200 (CEST) From: =?utf-8?q?Otto_Pfl=C3=BCger?= To: linux-arm-msm@vger.kernel.org Cc: Srinivas Kandagatla , Banajit Goswami , Liam Girdwood , Mark Brown , alsa-devel@alsa-project.org, ~postmarketos/upstreaming@lists.sr.ht, =?utf-8?q?Otto_Pfl=C3=BCger?= Subject: [PATCH 3/3] ASoC: qcom: q6afe: remove "port already open" error Date: Sat, 14 Oct 2023 19:26:24 +0200 Message-Id: <20231014172624.75301-4-otto.pflueger@abscue.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231014172624.75301-1-otto.pflueger@abscue.de> References: <20231014172624.75301-1-otto.pflueger@abscue.de> MIME-Version: 1.0 X-MailFrom: otto.pflueger@abscue.de X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1 Message-ID-Hash: IPOGW7GAYAFKX3PSMCZPUPIRQ62NVA6T X-Message-ID-Hash: IPOGW7GAYAFKX3PSMCZPUPIRQ62NVA6T X-Mailman-Approved-At: Sun, 15 Oct 2023 13:43:30 +0000 X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The clock fallback for older firmware versions now represents a use case for having multiple references to a port. Stop logging an error when a port is requested more than once because this does not indicate a problem anymore and causes unnecessary spam in dmesg. Signed-off-by: Otto Pflüger --- sound/soc/qcom/qdsp6/q6afe.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/sound/soc/qcom/qdsp6/q6afe.c b/sound/soc/qcom/qdsp6/q6afe.c index 87bdf741e5f6..d60c7b48e118 100644 --- a/sound/soc/qcom/qdsp6/q6afe.c +++ b/sound/soc/qcom/qdsp6/q6afe.c @@ -1647,10 +1647,8 @@ struct q6afe_port *q6afe_port_get_from_id(struct device *dev, int id) /* if port is multiple times bind/unbind before callback finishes */ port = q6afe_find_port(afe, id); - if (port) { - dev_err(dev, "AFE Port already open\n"); + if (port) return port; - } port_id = port_maps[id].port_id;