From patchwork Wed Nov 8 10:43:27 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 742255 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5CFDBC4167D for ; Wed, 8 Nov 2023 10:46:11 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id BF0059F6; Wed, 8 Nov 2023 11:45:19 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz BF0059F6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1699440369; bh=5rXIoi1MXc6LTP4fHcAOGEl/eDq8k58Hr1UM0isKip4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=JLbqRwjwtC5nU34xKav6Ec98xTPefEf3FwAvejXFmcsRuPvxwCp1mE5ttycnkSrFs SjQJ8D4adLeeLRWhUyWV/JVUJaab11vQMJTG1Z2cWvyk/Wsam9vEQ07b5pk/f8KlUK nGu9gYKPy414AIm0FUZNsK1z7IJiKKZ1eTGTJW7o= Received: by alsa1.perex.cz (Postfix, from userid 50401) id EF93DF8057A; Wed, 8 Nov 2023 11:44:19 +0100 (CET) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 3672BF8057B; Wed, 8 Nov 2023 11:44:19 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id CE7E1F801F5; Wed, 8 Nov 2023 11:44:11 +0100 (CET) Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id BD536F80152 for ; Wed, 8 Nov 2023 11:43:59 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz BD536F80152 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=n3sU+2a/ Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-4083f61322fso48635175e9.1 for ; Wed, 08 Nov 2023 02:43:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1699440239; x=1700045039; darn=alsa-project.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=yAjfTJh92uvbCJqXeCi670gcjaUuY+h2OqROwS33rLc=; b=n3sU+2a/wtdo4lb2xZcb/lE12IEOwPFs3FYlYWfAZOnmuQDs3GVOpcGig1MP07PaL7 U1R4elZZsMtpuQ09ZMsXfjRp9KNnm2UixGPqk3LXgdl7Zvlf8CYiSYALxBk176QVqg5j oNCsSZDyR7JEVZpIVlMyJxzxJveH+XoUJ3vnKifbL0DU/g3wCOUn8JCUMgySdxSz7Fui cBZKclj+zQtzEmPFiAwjaTX3lrHIpC7Gl9uqEAv+XkaTGvT+mrKPzVombfgGN1H4PNRV Z5ZuJNont/u/xiE+3uOHkLL7rfUL3qzLHhTtpw+ou1h7+RO1Nu5F2VlAXSosMwK0+Ytz WDww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699440239; x=1700045039; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yAjfTJh92uvbCJqXeCi670gcjaUuY+h2OqROwS33rLc=; b=YKTr82DaFV1S4ORR2OcE4Gr6CSFJOQEetwD2PDxiSe8fUAbN0XLR00CM8s0p5FEKeh /7+YQwS9s0dBvi2tTu6ek9yUDKEpmnufuRruFJSyTnr2wugdhKUP0MIJDTUAxBJvDRCe q0SyNAzwcjAOYTws1LfavJMj/hi7LBZVWBV++UlllDECSmnibBpekqtaOba+fAsw0ay3 dztfVdNcY+Qd5SisduFJs24nVQHYQ8tn97NBTO774b1H+qB4Wl59BIzyXICFddeJwtuf CgW4Ziv0EpKWkBafYSEfcCtixWzGoX4uMQmumF19h4QhnTGu7lVe6wvuYUeWVQWvXe4y lXuQ== X-Gm-Message-State: AOJu0YwoItF5Pw0GvxE6QRrEcnSKPa2ScBpsqwQ61+VSblLv7rrV15Yc gJ/NwBpXIk/nIa+krONjuIHN/w== X-Google-Smtp-Source: AGHT+IHIdIU7uiCUR0CHcHyVefUtJ+PHqY1ijnjV387qyUxWKGaH50797907TE+JsncllGcRuZSEtA== X-Received: by 2002:a05:600c:3104:b0:406:3fda:962c with SMTP id g4-20020a05600c310400b004063fda962cmr1471144wmo.31.1699440238661; Wed, 08 Nov 2023 02:43:58 -0800 (PST) Received: from krzk-bin.. ([178.197.218.126]) by smtp.gmail.com with ESMTPSA id fj12-20020a05600c0c8c00b004094c5d92bdsm19377377wmb.31.2023.11.08.02.43.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Nov 2023 02:43:58 -0800 (PST) From: Krzysztof Kozlowski To: David Airlie , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , Andi Shyti , Jonathan Cameron , Lars-Peter Clausen , Lee Jones , Ulf Hansson , Tomasz Figa , Sylwester Nawrocki , Linus Walleij , Thierry Reding , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Alessandro Zummo , Alexandre Belloni , Greg Kroah-Hartman , Jiri Slaby , Liam Girdwood , Mark Brown , Jaehoon Chung , Sam Protsenko , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-i2c@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-pwm@vger.kernel.org, linux-rtc@vger.kernel.org, linux-serial@vger.kernel.org, alsa-devel@alsa-project.org, linux-sound@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 01/17] dt-bindings: hwinfo: samsung,exynos-chipid: add specific compatibles for existing SoC Date: Wed, 8 Nov 2023 11:43:27 +0100 Message-Id: <20231108104343.24192-2-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231108104343.24192-1-krzysztof.kozlowski@linaro.org> References: <20231108104343.24192-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Message-ID-Hash: IPOADZBMZTSAVDMBRJQQG4GOL4C7PBAU X-Message-ID-Hash: IPOADZBMZTSAVDMBRJQQG4GOL4C7PBAU X-MailFrom: krzysztof.kozlowski@linaro.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Samsung Exynos SoC reuses several devices from older designs, thus historically we kept the old (block's) compatible only. This works fine and there is no bug here, however guidelines expressed in Documentation/devicetree/bindings/writing-bindings.rst state that: 1. Compatibles should be specific. 2. We should add new compatibles in case of bugs or features. Add compatibles specific to each SoC in front of all old-SoC-like compatibles. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Alim Akhtar --- I propose to take the patch through Samsung SoC (me). See cover letter for explanation. --- .../bindings/hwinfo/samsung,exynos-chipid.yaml | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree/bindings/hwinfo/samsung,exynos-chipid.yaml b/Documentation/devicetree/bindings/hwinfo/samsung,exynos-chipid.yaml index 95cbdcb56efe..45f3d468db7c 100644 --- a/Documentation/devicetree/bindings/hwinfo/samsung,exynos-chipid.yaml +++ b/Documentation/devicetree/bindings/hwinfo/samsung,exynos-chipid.yaml @@ -11,9 +11,20 @@ maintainers: properties: compatible: - enum: - - samsung,exynos4210-chipid - - samsung,exynos850-chipid + oneOf: + - enum: + - samsung,exynos4210-chipid + - samsung,exynos850-chipid + - items: + - enum: + - samsung,exynos5433-chipid + - samsung,exynos7-chipid + - const: samsung,exynos4210-chipid + - items: + - enum: + - samsung,exynos7885-chipid + - samsung,exynosautov9-chipid + - const: samsung,exynos850-chipid reg: maxItems: 1 From patchwork Wed Nov 8 10:43:30 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 742254 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5FDB7C4332F for ; Wed, 8 Nov 2023 10:46:47 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 397C2DF; Wed, 8 Nov 2023 11:45:55 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 397C2DF DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1699440405; bh=0l5oupv5GSlL5ziWgOf990RPXYeZTsZB+XCuTzwqfIo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=j183T/7mGyPBX5xPavC9+GyW49rmgtHHl5mK/1qrxN7sk49K3PUt5CrfmhTlxQq2k XpzPecZeciTJc5utmpqUzGuN+93iRjtFBk5dVof/LQ+/rLjiSOzWUSi/0aTdfwBQnL wIk2LH/ry6TY4xk85GpHepT5zjh43SV5rNwufYII= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 068A0F805BB; Wed, 8 Nov 2023 11:44:24 +0100 (CET) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 5475AF805AC; Wed, 8 Nov 2023 11:44:24 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 8D5B8F80568; Wed, 8 Nov 2023 11:44:16 +0100 (CET) Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 5E596F80152 for ; Wed, 8 Nov 2023 11:44:12 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 5E596F80152 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=FMMeDMp3 Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-4083f613272so57233145e9.1 for ; Wed, 08 Nov 2023 02:44:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1699440250; x=1700045050; darn=alsa-project.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XAqMvg09lZkovg+Zu0r4p30xWSnUqCaJm0pKp8M4YOY=; b=FMMeDMp3A8AvtoYVT9XOh29pP4j00xr1Y5S/RFBJMYnPs17i3+zh1Q+tX7kARz4NCb DW/QafROXPp1k/xk7nRlJPTn74ykhCAb4CQlR9shENg6qpq059OtJxs+zrp0GSwZmaku WFrG5lMspaewDzmMy1RZoeQQZ8esNGl3z6HeyGNi1Tgtd6d51ZVr04ztVWHMpI75gSb2 Fw84AYCGwor5LrcbdV+A5FPvqI/2F77PgcDKE07n+JRxsDdSBb8A6GTJd6nsqK0uvwq9 XMZ8zXJHKeFdX/Kx5OeEozgqsm6DgM+HV5JITQcsMQOQYHUXh/y3qD+usxnFccelRflM f6pA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699440250; x=1700045050; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XAqMvg09lZkovg+Zu0r4p30xWSnUqCaJm0pKp8M4YOY=; b=JZeyymp6XlQuW8Zn/bAPPCMJ/c+FwY1R8On8xUj8r+JV/ND4JxFPMoS3l4B8E1BZP0 bDUW8/NoXdCBhyR67DxXBZqHm+0tUU+7SGtX2RPHGeXtntD2MODkJ7utGjslv7qxUjiA dM8Jij4wnEps5/AQHweFBDW3gKB00735/AbNmMff1Ci3kueNlClaiMgH3ggyIdueLhvu xEXOTkPFBajMB5vM7KU2LC4/61YCA9VzzwUVcbiYxbMf8CNDMOvkqKUOWnOmftFRsIUU YJnQYXt3lu6HqPHvcKNZFX7Iz5rYGCMtJolvaVMPw+4PqEDdjT804Qpn1yw0aFucjSg3 03DA== X-Gm-Message-State: AOJu0YyCEvVXLV57BATXG55GFxqyhaMI1yZQufTvFk01A/aBFz0+brPD cFalN6TW0j5NCHsPjnWyVgYAkQ== X-Google-Smtp-Source: AGHT+IFviUW0LhnhTYkLsi418du0JsS+pSDR7WBQ3E2YbqFPxwTGmVG55ROJ8WQ2QG79sMX8+5JXdw== X-Received: by 2002:a05:600c:a49:b0:409:5d7d:b26d with SMTP id c9-20020a05600c0a4900b004095d7db26dmr1253167wmq.15.1699440250466; Wed, 08 Nov 2023 02:44:10 -0800 (PST) Received: from krzk-bin.. ([178.197.218.126]) by smtp.gmail.com with ESMTPSA id fj12-20020a05600c0c8c00b004094c5d92bdsm19377377wmb.31.2023.11.08.02.44.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Nov 2023 02:44:09 -0800 (PST) From: Krzysztof Kozlowski To: David Airlie , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , Andi Shyti , Jonathan Cameron , Lars-Peter Clausen , Lee Jones , Ulf Hansson , Tomasz Figa , Sylwester Nawrocki , Linus Walleij , Thierry Reding , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Alessandro Zummo , Alexandre Belloni , Greg Kroah-Hartman , Jiri Slaby , Liam Girdwood , Mark Brown , Jaehoon Chung , Sam Protsenko , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-i2c@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-pwm@vger.kernel.org, linux-rtc@vger.kernel.org, linux-serial@vger.kernel.org, alsa-devel@alsa-project.org, linux-sound@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 04/17] dt-bindings: mmc: samsung, exynos-dw-mshc: add specific compatibles for existing SoC Date: Wed, 8 Nov 2023 11:43:30 +0100 Message-Id: <20231108104343.24192-5-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231108104343.24192-1-krzysztof.kozlowski@linaro.org> References: <20231108104343.24192-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Message-ID-Hash: OXGGMRYLLVJMBBGE2SXPMJJG7ATPIPF2 X-Message-ID-Hash: OXGGMRYLLVJMBBGE2SXPMJJG7ATPIPF2 X-MailFrom: krzysztof.kozlowski@linaro.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Samsung Exynos SoC reuses several devices from older designs, thus historically we kept the old (block's) compatible only. This works fine and there is no bug here, however guidelines expressed in Documentation/devicetree/bindings/writing-bindings.rst state that: 1. Compatibles should be specific. 2. We should add new compatibles in case of bugs or features. Add compatibles specific to each SoC in front of all old-SoC-like compatibles. While re-indenting the first enum, put also axis,artpec8-dw-mshc in alphabetical order. Signed-off-by: Krzysztof Kozlowski Acked-by: Rob Herring --- I propose to take the patch through Samsung SoC (me). See cover letter for explanation. --- .../bindings/mmc/samsung,exynos-dw-mshc.yaml | 25 ++++++++++++------- 1 file changed, 16 insertions(+), 9 deletions(-) diff --git a/Documentation/devicetree/bindings/mmc/samsung,exynos-dw-mshc.yaml b/Documentation/devicetree/bindings/mmc/samsung,exynos-dw-mshc.yaml index 6ee78a38bd74..5fe65795f796 100644 --- a/Documentation/devicetree/bindings/mmc/samsung,exynos-dw-mshc.yaml +++ b/Documentation/devicetree/bindings/mmc/samsung,exynos-dw-mshc.yaml @@ -14,15 +14,22 @@ maintainers: properties: compatible: - enum: - - samsung,exynos4210-dw-mshc - - samsung,exynos4412-dw-mshc - - samsung,exynos5250-dw-mshc - - samsung,exynos5420-dw-mshc - - samsung,exynos5420-dw-mshc-smu - - samsung,exynos7-dw-mshc - - samsung,exynos7-dw-mshc-smu - - axis,artpec8-dw-mshc + oneOf: + - enum: + - axis,artpec8-dw-mshc + - samsung,exynos4210-dw-mshc + - samsung,exynos4412-dw-mshc + - samsung,exynos5250-dw-mshc + - samsung,exynos5420-dw-mshc + - samsung,exynos5420-dw-mshc-smu + - samsung,exynos7-dw-mshc + - samsung,exynos7-dw-mshc-smu + - items: + - enum: + - samsung,exynos5433-dw-mshc-smu + - samsung,exynos7885-dw-mshc-smu + - samsung,exynos850-dw-mshc-smu + - const: samsung,exynos7-dw-mshc-smu reg: maxItems: 1 From patchwork Wed Nov 8 10:43:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 742253 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 72C72C4332F for ; Wed, 8 Nov 2023 10:47:14 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id A5483E0D; Wed, 8 Nov 2023 11:46:22 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz A5483E0D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1699440432; bh=+h7xlBltId5iC5AEgRx2yNUxeGIgqDeyEoypL7cPCu8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=QrTxuxXVSp0xx0fkwaCMtFXXgWLdCwYlz9/1la0FYFnxnM1z5o9+DfP5iU1V+lUzi 1lzZ2QM+tcsE76iQGwZ2IGRGNdyjqXwlRoDme0l+ehhE+43ogIuZAflruNZr7VEdbc aQE6cf2s5WZHSOTEPfpsGh7Tr/G3iQqrVYZM7SRY= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 06C44F805C1; Wed, 8 Nov 2023 11:44:26 +0100 (CET) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 32B2BF805C3; Wed, 8 Nov 2023 11:44:26 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 3DB7EF805AC; Wed, 8 Nov 2023 11:44:22 +0100 (CET) Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 20697F80589 for ; Wed, 8 Nov 2023 11:44:18 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 20697F80589 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=zRGOGpS1 Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-40859c466efso48582315e9.3 for ; Wed, 08 Nov 2023 02:44:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1699440258; x=1700045058; darn=alsa-project.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=TGrUPXldQQyi7i1y6HTuSgGxtg81Z3Wiq2G+ebaMhpQ=; b=zRGOGpS1UPglYpz/L4lwdzlCRoh35DNb6p3lcOg4CyK/UonIGk+6EKYyELdTdcs9Cz E9wv68UYUnQY5JuoxnKCrTrBgWUPjSy4Z+7BDlAPfBuHnxt5lvHNlfxBX5tbcKT66Uba IhBohKHQfPlG7D4GORKmt91M5BLbG7ZaNhcotnPYA4vGpRcrUVSVM264W5J7IRtzyCXz m6AWo9JGfoD6EW+HxRIJ45gZMEUtHdIcuJqULID/dXE3xDmQoaP/QBq0U8uAJXw9NZCg 7GcgngQ+SbZmy2okoWMkW1I/JI6AD78xUJhoZ23BcoWJR3D3Bo5yD7i8djmatIGie8GD 3VYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699440258; x=1700045058; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TGrUPXldQQyi7i1y6HTuSgGxtg81Z3Wiq2G+ebaMhpQ=; b=BfwsZh+dTlgrTFetW2hHVkc4exsVW6B5x5Gg11CtxMzmjXZJxzocXinBE4KpmHt6jN +nQa69BH02xazDBiBc3UA9hOTbVT5VEZhni8nFDw7/wJXLzLLX4mjbByfKjNFDU3CROm jFxm44tKeQwspBfoZZ7mWyPm/v/bSMb02id8Dcx8/b7UXIJApqQsCXDlgFRudufum1uC nwvizax5GWwh6P+jIZoFZqr9qFFppysgkOyrRRYVj/E54F/33Jpbd8tOK/+fMh2tl+kj W4ElJ87nOoaaZW2GP0ISHPBOVrQ4dCPqq20SnyELnqOM263PzAJjkMei7vnh62OMqfy1 sGFg== X-Gm-Message-State: AOJu0Yx/ZciDfNJ9Th2+eSreZmu8rjH8+WyJERXeO5HORTK/LvGqJLVj cOXyX145vyAuEJw3Vz5volvXdg== X-Google-Smtp-Source: AGHT+IGzkWzdSSfC10gvMcrdr+HWpovdFD2tWKhVyooAAzLg7iLljfH0hHjLNTv+Bpu3NP726JCxaA== X-Received: by 2002:a05:600c:3553:b0:406:c6de:2bea with SMTP id i19-20020a05600c355300b00406c6de2beamr1367091wmq.17.1699440257975; Wed, 08 Nov 2023 02:44:17 -0800 (PST) Received: from krzk-bin.. ([178.197.218.126]) by smtp.gmail.com with ESMTPSA id fj12-20020a05600c0c8c00b004094c5d92bdsm19377377wmb.31.2023.11.08.02.44.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Nov 2023 02:44:17 -0800 (PST) From: Krzysztof Kozlowski To: David Airlie , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , Andi Shyti , Jonathan Cameron , Lars-Peter Clausen , Lee Jones , Ulf Hansson , Tomasz Figa , Sylwester Nawrocki , Linus Walleij , Thierry Reding , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Alessandro Zummo , Alexandre Belloni , Greg Kroah-Hartman , Jiri Slaby , Liam Girdwood , Mark Brown , Jaehoon Chung , Sam Protsenko , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-i2c@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-pwm@vger.kernel.org, linux-rtc@vger.kernel.org, linux-serial@vger.kernel.org, alsa-devel@alsa-project.org, linux-sound@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 06/17] dt-bindings: rtc: s3c-rtc: add specific compatibles for existing SoC Date: Wed, 8 Nov 2023 11:43:32 +0100 Message-Id: <20231108104343.24192-7-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231108104343.24192-1-krzysztof.kozlowski@linaro.org> References: <20231108104343.24192-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Message-ID-Hash: KT3JIXM6P73EFQ5UL5ALTGELG2M3D6JC X-Message-ID-Hash: KT3JIXM6P73EFQ5UL5ALTGELG2M3D6JC X-MailFrom: krzysztof.kozlowski@linaro.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: <> List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Samsung Exynos SoC reuses several devices from older designs, thus historically we kept the old (block's) compatible only. This works fine and there is no bug here, however guidelines expressed in Documentation/devicetree/bindings/writing-bindings.rst state that: 1. Compatibles should be specific. 2. We should add new compatibles in case of bugs or features. Add compatibles specific to each SoC in front of all old-SoC-like compatibles. Signed-off-by: Krzysztof Kozlowski Acked-by: Alexandre Belloni Acked-by: Rob Herring Reviewed-by: Alim Akhtar --- I propose to take the patch through Samsung SoC (me). See cover letter for explanation. --- Documentation/devicetree/bindings/rtc/s3c-rtc.yaml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml b/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml index d51b236939bf..bf4e11d6dffb 100644 --- a/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml +++ b/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml @@ -17,6 +17,11 @@ properties: - samsung,s3c2416-rtc - samsung,s3c2443-rtc - samsung,s3c6410-rtc + - items: + - enum: + - samsung,exynos7-rtc + - samsung,exynos850-rtc + - const: samsung,s3c6410-rtc - const: samsung,exynos3250-rtc deprecated: true From patchwork Wed Nov 8 10:43:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 742252 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C88B6C04FDE for ; Wed, 8 Nov 2023 10:47:48 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id ACEAA844; Wed, 8 Nov 2023 11:46:56 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz ACEAA844 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1699440466; bh=tvkXSaRpDx+LQn2Wp8WlC7XjtALFUXsDGz5cTqm/o5w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=SLUUSyeBaprF1zKgoGi254FpEmm4YshKYO+9xhsoaVMboa9WkjhO+kaNkrZJ2SmDh 0EuJQaNb5eTObijytdnvtZAMxWIlpGhcnG9GvuNt9GfbFjIIcZhRPkfVWGzBNG160l BmURXs9SSFgGRuoChSmr/66lozQHgto86tKAo0/8= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 4E91CF805E0; Wed, 8 Nov 2023 11:44:35 +0100 (CET) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 43240F805D8; Wed, 8 Nov 2023 11:44:35 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 7BAE6F805CB; Wed, 8 Nov 2023 11:44:31 +0100 (CET) Received: from mail-lj1-x231.google.com (mail-lj1-x231.google.com [IPv6:2a00:1450:4864:20::231]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 07550F805BE for ; Wed, 8 Nov 2023 11:44:23 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 07550F805BE Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=VYa/ua1l Received: by mail-lj1-x231.google.com with SMTP id 38308e7fff4ca-2c501bd6ff1so94533611fa.3 for ; Wed, 08 Nov 2023 02:44:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1699440262; x=1700045062; darn=alsa-project.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=932+POzuiCpVd1FMO8emES7304xq1CZHsFhbsNym7D8=; b=VYa/ua1lwRcS4amdN+U8DK/CjOEG8NGqjSNGbl1CkcuPfS4UW208LHbb6joLR97y2j yVLJ0rSpUPnpA9/JZFmDvFGtdJnMVAxId+T4SFOD9ZVLTj6bs75XY+VXzfrSZqUjUAa6 Gi9OFq0IBNqLSFyxbavUadwidSFtqYbzlRFwn3Awp3uI2Pvu5m8fchFgrPPle8F/AUeT 6uShsekAGZSKkVm2vPeFtAaxIY6hzNTr4/+PBwc/gfqKVsVhctS3i5eF2c+yZ3QCbomg bii73TWlFfLp6Q9OQrhe7mC2OrdYOLglT+KXtjbeWcJAa8KfIN0CsBuAl0xRjhP+LDvY oqfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699440262; x=1700045062; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=932+POzuiCpVd1FMO8emES7304xq1CZHsFhbsNym7D8=; b=mymqRTF88u5KzwV4jFTOJrOlLpOLwJFco3sAX8tEcWrHDKxvdGnffkc14ksQH5soJF ucByB4HXdGIUYzLZCy/eqj3w4zc2uWVCv8lPSs3mxkTQBqWRlN3kZhcHjqbaqklJOzQC SbwAuZ39NpdSVUvvH1HExI2bylYlLjgmCy7pskHkcI11zlhepuqFKkK1spV143jk/LEZ a/ViSJgVdVwGOqkhwltj97yk+ChZ9W/e2iruSOBujRGc5uZTmYsAIOJfH4w5ATnInmjH q+Dj8awURETxcDS+Hf9L84ImkYn4zDFoRgEoHlLiuM1anQwu26Xq23kMYR+7wVQunSD7 Y+ag== X-Gm-Message-State: AOJu0YxgEuNF7QJ3bbrCLwJvUi71bmbenbi6kA1rTtpa3PzuMtaD9ieo PeJ+Fe2eZB00IUGmSbGMSMdXZA== X-Google-Smtp-Source: AGHT+IGCpSGI0CR0667rdoPAw+/9BwGIOQ5vf5WLNiqXBsw+h3xPKE36aRvV/bSi7NnLY3zOJHYzOg== X-Received: by 2002:a05:651c:504:b0:2c5:14e3:f1b8 with SMTP id o4-20020a05651c050400b002c514e3f1b8mr1507701ljp.7.1699440261813; Wed, 08 Nov 2023 02:44:21 -0800 (PST) Received: from krzk-bin.. ([178.197.218.126]) by smtp.gmail.com with ESMTPSA id fj12-20020a05600c0c8c00b004094c5d92bdsm19377377wmb.31.2023.11.08.02.44.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Nov 2023 02:44:21 -0800 (PST) From: Krzysztof Kozlowski To: David Airlie , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , Andi Shyti , Jonathan Cameron , Lars-Peter Clausen , Lee Jones , Ulf Hansson , Tomasz Figa , Sylwester Nawrocki , Linus Walleij , Thierry Reding , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Alessandro Zummo , Alexandre Belloni , Greg Kroah-Hartman , Jiri Slaby , Liam Girdwood , Mark Brown , Jaehoon Chung , Sam Protsenko , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-i2c@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-pwm@vger.kernel.org, linux-rtc@vger.kernel.org, linux-serial@vger.kernel.org, alsa-devel@alsa-project.org, linux-sound@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 07/17] dt-bindings: serial: samsung: add specific compatibles for existing SoC Date: Wed, 8 Nov 2023 11:43:33 +0100 Message-Id: <20231108104343.24192-8-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231108104343.24192-1-krzysztof.kozlowski@linaro.org> References: <20231108104343.24192-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Message-ID-Hash: CBGVTZG735FCR33MUBUQF2Y2FF4SNXFD X-Message-ID-Hash: CBGVTZG735FCR33MUBUQF2Y2FF4SNXFD X-MailFrom: krzysztof.kozlowski@linaro.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Samsung Exynos SoC reuses several devices from older designs, thus historically we kept the old (block's) compatible only. This works fine and there is no bug here, however guidelines expressed in Documentation/devicetree/bindings/writing-bindings.rst state that: 1. Compatibles should be specific. 2. We should add new compatibles in case of bugs or features. Add compatibles specific to each SoC in front of all old-SoC-like compatibles. Re-shuffle also the entries in compatibles, so the one-compatible-enum is the first. Signed-off-by: Krzysztof Kozlowski Acked-by: Rob Herring --- I propose to take the patch through Samsung SoC (me). See cover letter for explanation. --- .../devicetree/bindings/serial/samsung_uart.yaml | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree/bindings/serial/samsung_uart.yaml b/Documentation/devicetree/bindings/serial/samsung_uart.yaml index ac60ab1e35e3..0d0215b23ab7 100644 --- a/Documentation/devicetree/bindings/serial/samsung_uart.yaml +++ b/Documentation/devicetree/bindings/serial/samsung_uart.yaml @@ -18,9 +18,6 @@ description: |+ properties: compatible: oneOf: - - items: - - const: samsung,exynosautov9-uart - - const: samsung,exynos850-uart - enum: - apple,s5l-uart - axis,artpec8-uart @@ -29,6 +26,17 @@ properties: - samsung,exynos4210-uart - samsung,exynos5433-uart - samsung,exynos850-uart + - items: + - enum: + - samsung,exynos7-uart + - const: samsung,exynos4210-uart + - items: + - enum: + - samsung,exynos7885-uart + - const: samsung,exynos5433-uart + - items: + - const: samsung,exynosautov9-uart + - const: samsung,exynos850-uart reg: maxItems: 1 From patchwork Wed Nov 8 10:43:36 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 742251 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 04206C4167B for ; Wed, 8 Nov 2023 10:48:10 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id BEE23E81; Wed, 8 Nov 2023 11:47:17 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz BEE23E81 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1699440487; bh=+pNIw8DSXRl+bA2UhqDcJOALE/m/y+mCrIROK55hEaU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=aDmvL2OERtVjFraKgtdzkWfe76BzWqbBBEB0rOHWTZwXv61cj02E2lW/oLsvc3Zj2 KEdTmRIhoE6WWxlsTPGcOT+Z33t/MG7+avTvcQglB2sAlBc3+sVfGR6uSyh9tIBZog O4mKds/QSBPlJ8BK9dbwtjkWFcHLAooRatMY85UA= Received: by alsa1.perex.cz (Postfix, from userid 50401) id C1D87F805FB; Wed, 8 Nov 2023 11:44:41 +0100 (CET) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 2E05FF805F1; Wed, 8 Nov 2023 11:44:41 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 41BB8F805E6; Wed, 8 Nov 2023 11:44:37 +0100 (CET) Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 2DFF4F805DA for ; Wed, 8 Nov 2023 11:44:34 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 2DFF4F805DA Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=D2LQJ/tC Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-4094301d505so49864505e9.2 for ; Wed, 08 Nov 2023 02:44:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1699440273; x=1700045073; darn=alsa-project.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=tkEvXWcKUOWY7MDhsApmZqSz9A9BrLzom2ZllyUYJqs=; b=D2LQJ/tCcRnhTJh+yBa4uh7tqER3ctRm9GTpxlEF2qQDWt55FMit5ZTpB8mgIGjOJd YVnjhMvfG+aMDkvP+y2rONpLFC0QThEaFX849XNIF3qmgAEmQ54P9aviRm9lyKq7aInH HjH3M6vcZ4QZxj4n9GLM41KG4eoAeyMe19TrEGdXSkxIaogpLyH8VrIZj8gJX8DaMFTA E5fxC7lkoJDMGuUEy9rBmQDgOVop+RDGwsoC6/SXVy/sYYdB+U07U6I9EbPXJpVauatK +/zCf/IxsSS91ijWAX5mXXX9I2UWxxaMFy7JK8o1V5H5R9RLYt8P2r7H1EgFRIQy9GQt rrMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699440273; x=1700045073; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tkEvXWcKUOWY7MDhsApmZqSz9A9BrLzom2ZllyUYJqs=; b=bWcykk05OxU9aiCOM+zBOyl0FMPWnbBfioO6r8sxVQ+tsNUFWm7+SmxKp2tds63WbU B4bPlwzwi4GUa0wc/KqnGks+JJC8XYkmw8Y6NPh18BDkGOYF9mpZEFu6vyPlcjULCCEO chVAX7csgoVY5ptUDqDIvHkrbpHMLg9wsh1ZzXV23TzBO1o5Zd8sIZFBWIwhkPGldcPK iy1U0fnL8OzDxrjjeUDnAP5LD3q2FuB+kZivEX7vUfAFUCOE/TtLGxQRb8u+LG21MPXh ox7A5YUNSgwr7DKKJOHYvP+juc8IGzgvSiOTvvAl7ZigyVM66p6rp/bsD3FWId/Ks1Y7 lQRw== X-Gm-Message-State: AOJu0Ywj4+LkRsLKjEDq49lLraGlbl3l5Ovh3dbjXHvML5D3EQZFLZbX 6+eG1JCFbnULZRHkluKqYGY2ww== X-Google-Smtp-Source: AGHT+IGkZ0Z/MGipPYgtciee5bgssBjyKrV3vFjgQq9aKLpthGkLg1gMgK3YX3rqUB7np5d3fs06BQ== X-Received: by 2002:a05:600c:4fcd:b0:407:8e85:89ad with SMTP id o13-20020a05600c4fcd00b004078e8589admr1286513wmq.14.1699440272758; Wed, 08 Nov 2023 02:44:32 -0800 (PST) Received: from krzk-bin.. ([178.197.218.126]) by smtp.gmail.com with ESMTPSA id fj12-20020a05600c0c8c00b004094c5d92bdsm19377377wmb.31.2023.11.08.02.44.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Nov 2023 02:44:32 -0800 (PST) From: Krzysztof Kozlowski To: David Airlie , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , Andi Shyti , Jonathan Cameron , Lars-Peter Clausen , Lee Jones , Ulf Hansson , Tomasz Figa , Sylwester Nawrocki , Linus Walleij , Thierry Reding , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Alessandro Zummo , Alexandre Belloni , Greg Kroah-Hartman , Jiri Slaby , Liam Girdwood , Mark Brown , Jaehoon Chung , Sam Protsenko , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-i2c@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-pwm@vger.kernel.org, linux-rtc@vger.kernel.org, linux-serial@vger.kernel.org, alsa-devel@alsa-project.org, linux-sound@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 10/17] dt-bindings: iio: samsung,exynos-adc: add specific compatibles for existing SoC Date: Wed, 8 Nov 2023 11:43:36 +0100 Message-Id: <20231108104343.24192-11-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231108104343.24192-1-krzysztof.kozlowski@linaro.org> References: <20231108104343.24192-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Message-ID-Hash: 3LYIFF7VT6BYHS6PSZPZVSPB6M7F6FCG X-Message-ID-Hash: 3LYIFF7VT6BYHS6PSZPZVSPB6M7F6FCG X-MailFrom: krzysztof.kozlowski@linaro.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Samsung Exynos SoC reuses several devices from older designs, thus historically we kept the old (block's) compatible only. This works fine and there is no bug here, however guidelines expressed in Documentation/devicetree/bindings/writing-bindings.rst state that: 1. Compatibles should be specific. 2. We should add new compatibles in case of bugs or features. Add compatibles specific to each SoC in front of all old-SoC-like compatibles. Signed-off-by: Krzysztof Kozlowski Acked-by: Rob Herring Reviewed-by: Alim Akhtar Acked-by: Jonathan Cameron --- I propose to take the patch through Samsung SoC (me). See cover letter for explanation. --- .../bindings/iio/adc/samsung,exynos-adc.yaml | 29 +++++++++++-------- 1 file changed, 17 insertions(+), 12 deletions(-) diff --git a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml index 582d0a03b814..4e40f6bed5db 100644 --- a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml +++ b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml @@ -11,18 +11,23 @@ maintainers: properties: compatible: - enum: - - samsung,exynos-adc-v1 # Exynos5250 - - samsung,exynos-adc-v2 - - samsung,exynos3250-adc - - samsung,exynos4212-adc # Exynos4212 and Exynos4412 - - samsung,exynos7-adc - - samsung,s3c2410-adc - - samsung,s3c2416-adc - - samsung,s3c2440-adc - - samsung,s3c2443-adc - - samsung,s3c6410-adc - - samsung,s5pv210-adc + oneOf: + - enum: + - samsung,exynos-adc-v1 # Exynos5250 + - samsung,exynos-adc-v2 + - samsung,exynos3250-adc + - samsung,exynos4212-adc # Exynos4212 and Exynos4412 + - samsung,exynos7-adc + - samsung,s3c2410-adc + - samsung,s3c2416-adc + - samsung,s3c2440-adc + - samsung,s3c2443-adc + - samsung,s3c6410-adc + - samsung,s5pv210-adc + - items: + - enum: + - samsung,exynos5433-adc + - const: samsung,exynos7-adc reg: maxItems: 1 From patchwork Wed Nov 8 10:43:38 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 742250 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 46AF2C4332F for ; Wed, 8 Nov 2023 10:48:39 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 7AB37E7C; Wed, 8 Nov 2023 11:47:47 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 7AB37E7C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1699440517; bh=wem3j6IamiU+gWalD2ogeTs6GZr54NDXKP8Cz9kcvvU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=cH4onoD/KxIxRKpRYJAdI71UM21PT5EyrmkWACC44+1tPY8FkYta184h6oiq21EbK oZw22i/dZVgwA/KvKhsTbNtHd3UzxoM9Bdj7pC5AapWbAaWj+OPtNTN3C6Rm3fiRmB eB9q6HXuJw3djbz0zhc6k6xnCw41Urau3vMKlMVc= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 1235AF80607; Wed, 8 Nov 2023 11:44:49 +0100 (CET) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 8819BF80602; Wed, 8 Nov 2023 11:44:48 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 568C5F805F0; Wed, 8 Nov 2023 11:44:44 +0100 (CET) Received: from mail-lj1-x22b.google.com (mail-lj1-x22b.google.com [IPv6:2a00:1450:4864:20::22b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 0E03FF805ED for ; Wed, 8 Nov 2023 11:44:41 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 0E03FF805ED Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=UjkG2Yn1 Received: by mail-lj1-x22b.google.com with SMTP id 38308e7fff4ca-2c509f2c46cso92560241fa.1 for ; Wed, 08 Nov 2023 02:44:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1699440279; x=1700045079; darn=alsa-project.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=eLncO1ADQq/KYbPV1LBS+813XGTk7ajEpj3gEwbCXmE=; b=UjkG2Yn1xyWpSB4+5zIgfM+KEQsnl+8oYzn589w8qxMDYCcIV2jOSjD/IHed4MTKqZ FcH1IBdNMfgWVkno/7JyCSwgaGGAYtPeDGXeHqbKZOjHLDJeIW2D6PxRAMenJSvWyAOk crKdCzV0zzR1ZAeaOPPrAHVLeSNeFyL7oIEQGTYl0fIfGj1kgZ55EecxeiQ085t4vO/b swbQ0B+x+rMjX6f1YxP5Sc8fBmrmHlaccKZDln8rm+Nfm9rz17hAP75qRCcGD826knA0 oJrvDtnJRYNMmQF5T15v3tRFEIL5ximT+zIQbnQUjrfgMvznnvQ/7n+iKSbQchmYSpMF RIng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699440279; x=1700045079; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eLncO1ADQq/KYbPV1LBS+813XGTk7ajEpj3gEwbCXmE=; b=oCcRpH46c2ML14a7etyv0S4waBuVIz/xtFmEP5VlCz1xIeuUpDHFvSjmp2ZClFyZ5s dIDtIFTCeNO+tiDsDxlLaGVcIi+EyXiUoLSeD7rCl5bgMxLPKGA1oq+1T5FzP0lyUyjO 8b2umhlNecIrtzJ/zpIFXr1g4Ao1BQLyVXE/HlCZ4B2rgcrqX3xkFydbtFNiAvZi5HcN LLQxIsnX/vJK+gjiUhJqvrkJNMRktHSc9AA2c3C3X1VaN29CLKibOkLzQBB9ZdZJ0riG OCLpQxpNwjcSYOAC63SAMJqgGF1Epl1OzotSy+MgjdHla0U42P5JWdr1jWytts0NTM64 YoYw== X-Gm-Message-State: AOJu0YwKcICeplrFMBf52m+gyEAGcLMgyNFA7Xo2TZM0RON1o7RMIvXh d+SFeJIBqEDJ7OWECDzq0Ocj2A== X-Google-Smtp-Source: AGHT+IE9e7WdZJcWzB5Gf22P43YL/3qsWhZ9UWDtVmtmQ2zCC7QEZqOnQRFgEbbvc33FYHTz/Q1w1g== X-Received: by 2002:a2e:81a:0:b0:2c5:7afd:75a1 with SMTP id 26-20020a2e081a000000b002c57afd75a1mr1229802lji.44.1699440279685; Wed, 08 Nov 2023 02:44:39 -0800 (PST) Received: from krzk-bin.. ([178.197.218.126]) by smtp.gmail.com with ESMTPSA id fj12-20020a05600c0c8c00b004094c5d92bdsm19377377wmb.31.2023.11.08.02.44.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Nov 2023 02:44:39 -0800 (PST) From: Krzysztof Kozlowski To: David Airlie , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , Andi Shyti , Jonathan Cameron , Lars-Peter Clausen , Lee Jones , Ulf Hansson , Tomasz Figa , Sylwester Nawrocki , Linus Walleij , Thierry Reding , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Alessandro Zummo , Alexandre Belloni , Greg Kroah-Hartman , Jiri Slaby , Liam Girdwood , Mark Brown , Jaehoon Chung , Sam Protsenko , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-i2c@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-pwm@vger.kernel.org, linux-rtc@vger.kernel.org, linux-serial@vger.kernel.org, alsa-devel@alsa-project.org, linux-sound@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 12/17] dt-bindings: pwm: samsung: add specific compatibles for existing SoC Date: Wed, 8 Nov 2023 11:43:38 +0100 Message-Id: <20231108104343.24192-13-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231108104343.24192-1-krzysztof.kozlowski@linaro.org> References: <20231108104343.24192-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Message-ID-Hash: RCOZ74VI4OCNYFI2K5P53RXINMT4LH3K X-Message-ID-Hash: RCOZ74VI4OCNYFI2K5P53RXINMT4LH3K X-MailFrom: krzysztof.kozlowski@linaro.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Samsung Exynos SoC reuses several devices from older designs, thus historically we kept the old (block's) compatible only. This works fine and there is no bug here, however guidelines expressed in Documentation/devicetree/bindings/writing-bindings.rst state that: 1. Compatibles should be specific. 2. We should add new compatibles in case of bugs or features. Add compatibles specific to each SoC in front of all old-SoC-like compatibles. Signed-off-by: Krzysztof Kozlowski Acked-by: Rob Herring Reviewed-by: Alim Akhtar --- I propose to take the patch through Samsung SoC (me). See cover letter for explanation. --- Documentation/devicetree/bindings/pwm/pwm-samsung.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/pwm/pwm-samsung.yaml b/Documentation/devicetree/bindings/pwm/pwm-samsung.yaml index 2162f661ed5a..89a3875cb50a 100644 --- a/Documentation/devicetree/bindings/pwm/pwm-samsung.yaml +++ b/Documentation/devicetree/bindings/pwm/pwm-samsung.yaml @@ -29,6 +29,8 @@ properties: - samsung,exynos4210-pwm # 32-bit, Exynos - items: - enum: + - samsung,exynos5433-pwm + - samsung,exynos7-pwm - samsung,exynosautov9-pwm - const: samsung,exynos4210-pwm From patchwork Wed Nov 8 10:43:40 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 742249 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6D380C4332F for ; Wed, 8 Nov 2023 10:49:21 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id DD3F4844; Wed, 8 Nov 2023 11:48:28 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz DD3F4844 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1699440559; bh=Xmq8AdqXRz3/FqKsFeUt6D9B883cMQgLyu6/cU4CPrY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=lWhip6E2RwHMDvDERSJ9BykYlvwvk+hFirK0FQtNC2UBNjPfqBx8XjZFpKUi/zVxk Y16tuBBOaMCselieE5NjK3tTRXECy00Vv1KeGTvef7gXj6sJDl+IQeAU4JZvC0GpeJ UVHsuLn7nWLRgGwV+VQqrYRxcHHApLdfbaXZaO/w= Received: by alsa1.perex.cz (Postfix, from userid 50401) id AF1A0F80622; Wed, 8 Nov 2023 11:45:04 +0100 (CET) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 8CA20F80620; Wed, 8 Nov 2023 11:45:03 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 644A0F80612; Wed, 8 Nov 2023 11:45:00 +0100 (CET) Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 0F2FEF80608 for ; Wed, 8 Nov 2023 11:44:48 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 0F2FEF80608 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=zPMkBmtp Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-40907b82ab9so3614295e9.1 for ; Wed, 08 Nov 2023 02:44:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1699440287; x=1700045087; darn=alsa-project.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Maq2+L1Y42eLIp6jLOTQKPo6JnaiX6HnytDKQ9hLP3M=; b=zPMkBmtpwuS6cpAFsjqn9F/rtctsGyFC3Dn2mmwo8WWjSpRmy2R45kamyvP7fN4hnI 81J0qcXFyQn/xn4oTgNBUHZs1tZ304XlcR1vmLmUEvZgRICrdGpAmiwgTBRbyUzsZ8bo 0hCXLfiVFPnXyGC5DBYpzEkWuF45z2tClwB+SY4XIu0eeQKyfoLGA2w+maL9vFdLCsjq ZUI0bIaKfEo6ByfzGaiQUQC2XEEyMQm44MPL6PS24Ic4cYAo1vj/0NrPV9KdyZVI8ZUy vqN7nTZ9bAuWQnVi+rqxdOzphBpCFovMFtdzXdXT0nlW1P+M65NyKtkFR0vJ+WS0DM5A BWTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699440287; x=1700045087; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Maq2+L1Y42eLIp6jLOTQKPo6JnaiX6HnytDKQ9hLP3M=; b=MbncL/gTZTwIvzyryHGRMnCVLmvCzjljVv7F8jXlOH7tNv21Q/Hdj5hRdUQYB9rsyT VUBqRvLK3tY5ZKhwZHV7OEV0RclzlNIs01M1vj0MrtAxErUMr5WlSsAmuFO8w4rxiaHQ Rid4KqpWTKeY6RcTNjxfzqDPnUmSS5Tzu7kIBwg7bCNbBwcOyJMCdLLzsvxaIDXOsHbT AW5P/w/4snPPdK78t9T+PPmJma0GdjNdmpYBkfbmWBkEOwCeNup0MnT9Tftqji5zQyxS UetqkOZ0RlN/mDSiSmo516YAuqXkHi3kU34PVGROyflpLeSdEiZPgXUlCcbJzW+ERtpL W+Fw== X-Gm-Message-State: AOJu0YwgV9NsntdaLNcVZ8AAI6cp27JAb/2ayYgbj8z4Hn9Nyzc6bLyy 68OCKin+9fHn3m9kjOU0TQpVew== X-Google-Smtp-Source: AGHT+IHfnKTLAUfozAkfKQV4GR2Fej9TWilPKyjgZI/joMTpp1hOhiecaU9SQRw9m85EcpIoxEyIjw== X-Received: by 2002:a05:600c:4512:b0:406:44fc:65c9 with SMTP id t18-20020a05600c451200b0040644fc65c9mr1775482wmo.8.1699440287419; Wed, 08 Nov 2023 02:44:47 -0800 (PST) Received: from krzk-bin.. ([178.197.218.126]) by smtp.gmail.com with ESMTPSA id fj12-20020a05600c0c8c00b004094c5d92bdsm19377377wmb.31.2023.11.08.02.44.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Nov 2023 02:44:46 -0800 (PST) From: Krzysztof Kozlowski To: David Airlie , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , Andi Shyti , Jonathan Cameron , Lars-Peter Clausen , Lee Jones , Ulf Hansson , Tomasz Figa , Sylwester Nawrocki , Linus Walleij , Thierry Reding , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Alessandro Zummo , Alexandre Belloni , Greg Kroah-Hartman , Jiri Slaby , Liam Girdwood , Mark Brown , Jaehoon Chung , Sam Protsenko , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-i2c@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-pwm@vger.kernel.org, linux-rtc@vger.kernel.org, linux-serial@vger.kernel.org, alsa-devel@alsa-project.org, linux-sound@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 14/17] arm64: dts: exynos7: add specific compatibles to several blocks Date: Wed, 8 Nov 2023 11:43:40 +0100 Message-Id: <20231108104343.24192-15-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231108104343.24192-1-krzysztof.kozlowski@linaro.org> References: <20231108104343.24192-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Message-ID-Hash: IOQAKRLXPOX6235JMEONT4VF5C6W7C2C X-Message-ID-Hash: IOQAKRLXPOX6235JMEONT4VF5C6W7C2C X-MailFrom: krzysztof.kozlowski@linaro.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Exynos7 reuses several devices from older designs, thus historically we kept the old (block's) compatible only. This works fine and there is no bug here, however guidelines expressed in Documentation/devicetree/bindings/writing-bindings.rst state that: 1. Compatibles should be specific. 2. We should add new compatibles in case of bugs or features. Add compatibles specific to Exynos7 in front of all old-SoC-like compatibles. This will also help reviews of new code using existing DTS as template. No functional impact on Linux drivers behavior. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Alim Akhtar --- arch/arm64/boot/dts/exynos/exynos7.dtsi | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/arch/arm64/boot/dts/exynos/exynos7.dtsi b/arch/arm64/boot/dts/exynos/exynos7.dtsi index 6ed80ddf3369..9cb6bd61262e 100644 --- a/arch/arm64/boot/dts/exynos/exynos7.dtsi +++ b/arch/arm64/boot/dts/exynos/exynos7.dtsi @@ -128,7 +128,8 @@ soc: soc@0 { ranges = <0 0 0 0x18000000>; chipid@10000000 { - compatible = "samsung,exynos4210-chipid"; + compatible = "samsung,exynos7-chipid", + "samsung,exynos4210-chipid"; reg = <0x10000000 0x100>; }; @@ -279,7 +280,7 @@ clock_fsys1: clock-controller@156e0000 { }; serial_0: serial@13630000 { - compatible = "samsung,exynos4210-uart"; + compatible = "samsung,exynos7-uart", "samsung,exynos4210-uart"; reg = <0x13630000 0x100>; interrupts = ; clocks = <&clock_peric0 PCLK_UART0>, @@ -289,7 +290,7 @@ serial_0: serial@13630000 { }; serial_1: serial@14c20000 { - compatible = "samsung,exynos4210-uart"; + compatible = "samsung,exynos7-uart", "samsung,exynos4210-uart"; reg = <0x14c20000 0x100>; interrupts = ; clocks = <&clock_peric1 PCLK_UART1>, @@ -299,7 +300,7 @@ serial_1: serial@14c20000 { }; serial_2: serial@14c30000 { - compatible = "samsung,exynos4210-uart"; + compatible = "samsung,exynos7-uart", "samsung,exynos4210-uart"; reg = <0x14c30000 0x100>; interrupts = ; clocks = <&clock_peric1 PCLK_UART2>, @@ -309,7 +310,7 @@ serial_2: serial@14c30000 { }; serial_3: serial@14c40000 { - compatible = "samsung,exynos4210-uart"; + compatible = "samsung,exynos7-uart", "samsung,exynos4210-uart"; reg = <0x14c40000 0x100>; interrupts = ; clocks = <&clock_peric1 PCLK_UART3>, @@ -539,7 +540,7 @@ pmu_system_controller: system-controller@105c0000 { }; rtc: rtc@10590000 { - compatible = "samsung,s3c6410-rtc"; + compatible = "samsung,exynos7-rtc", "samsung,s3c6410-rtc"; reg = <0x10590000 0x100>; interrupts = , ; @@ -559,7 +560,8 @@ watchdog: watchdog@101d0000 { }; gpu: gpu@14ac0000 { - compatible = "samsung,exynos5433-mali", "arm,mali-t760"; + compatible = "samsung,exynos7-mali", + "samsung,exynos5433-mali", "arm,mali-t760"; reg = <0x14ac0000 0x5000>; interrupts = , , @@ -619,7 +621,7 @@ adc: adc@13620000 { }; pwm: pwm@136c0000 { - compatible = "samsung,exynos4210-pwm"; + compatible = "samsung,exynos7-pwm", "samsung,exynos4210-pwm"; reg = <0x136c0000 0x100>; interrupts = , , From patchwork Wed Nov 8 10:43:43 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 742248 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D4067C4332F for ; Wed, 8 Nov 2023 10:49:55 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 9960DEAA; Wed, 8 Nov 2023 11:49:03 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 9960DEAA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1699440593; bh=EDnv1pz253DGTkjkFK5sH2PghffWSuz7JVwCD5PyaBA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=ZRw3uM9fIIlBGyRmP64ldcSwU9IM7IXrTygeGYoYOux2FBdl+2MHgmbxFLUgAf3PW 02ShWvtlqp0/NKaho4X3+Dg1MR8jo+3CR8U2MlcS2b8d+2it19PQT1TYEbOonZhPzB qlXSVu8QBCwbpHiNFw0SE0jMnwEVccwEwrqFvNw8= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 92968F80152; Wed, 8 Nov 2023 11:47:10 +0100 (CET) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 08E88F80152; Wed, 8 Nov 2023 11:47:10 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 1063DF8055C; Wed, 8 Nov 2023 11:47:05 +0100 (CET) Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id A0FB7F8061D for ; Wed, 8 Nov 2023 11:45:00 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz A0FB7F8061D Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=I9xaZCnP Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-4079ed65471so49560465e9.1 for ; Wed, 08 Nov 2023 02:45:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1699440299; x=1700045099; darn=alsa-project.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=YQ+G5s8RPHyPJsrBFGNZYZXOAO3f3klrHmjNTSjaK6I=; b=I9xaZCnPyeee6Uoze63jU6VcUkzbUhFf6cUv8TqLCgfEYhbvXSN1P+pbIpHVdTQFgl dek0VYqTnZqOTidJr4roegaaFLwmttK9Qbl2ilQkNp+sPx7qlrzSZzV7vzBC8ldxyknj svGa/jFYFDU6geuncXcpItwlpBDoGbTiQmLwAh5wNoHUxgHjc4Nau8cvd8QSmmE9yQFL JFfUllBKplv60362gelHC8Na3/8+9v0ZsGLm49QDcaGHkjRNdRhaGRIh8lnB457N5Yv+ oFzDcDl6P+qi3ceNRdahgBK4E6AlMWrNeZ6qi6M032D/YuLbZ7cYrjavwnc6DBuca9Sw XTeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699440299; x=1700045099; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YQ+G5s8RPHyPJsrBFGNZYZXOAO3f3klrHmjNTSjaK6I=; b=VqVxVkBnAutlrX6zm30Ev78PtJqU5G2ovBepk4Q4XtTbkdpPiHNH083TqFN06LbtIU vEKJdCvP7Hq+2o6fB0VEv3JU+idNDGX4hSh0w278u58UwJZF8aIos1g7WtL8IKbPJQbc gI9OFSHB1mR25cXtDtBjbcpB3jjDQhFFELrwpl5YVi9Do9VWbQl1pmqPEyzIXNOf7SUd XuGa/GqrSnCTehmeAzZNYXRJtKXUwMnG28tTD/t4752Ta/dplUJalBuU3gb4YADiMqpx PQP8BqOUmuRxcanDsj9/a7CfTfjb1BjYifRNRk17IvQ0jfeRd4hETUTnc/alsKn3KwNP kxAg== X-Gm-Message-State: AOJu0YxBphLvkSv6NehS8HbLWnz9pIuMhXFwHYfSHOLND9MSduXc9Nx2 C7D8LtxuIc4DhigXEv6eG1emvg== X-Google-Smtp-Source: AGHT+IFp84xxfo5QRAF0wCrKdORFx4iJmSqJoRpd/lOk7txHM8S/A55ohRCToPiG6pukjYjCgaIN3w== X-Received: by 2002:a05:600c:3b15:b0:405:95ae:4a94 with SMTP id m21-20020a05600c3b1500b0040595ae4a94mr1341542wms.5.1699440298865; Wed, 08 Nov 2023 02:44:58 -0800 (PST) Received: from krzk-bin.. ([178.197.218.126]) by smtp.gmail.com with ESMTPSA id fj12-20020a05600c0c8c00b004094c5d92bdsm19377377wmb.31.2023.11.08.02.44.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Nov 2023 02:44:58 -0800 (PST) From: Krzysztof Kozlowski To: David Airlie , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , Andi Shyti , Jonathan Cameron , Lars-Peter Clausen , Lee Jones , Ulf Hansson , Tomasz Figa , Sylwester Nawrocki , Linus Walleij , Thierry Reding , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Alessandro Zummo , Alexandre Belloni , Greg Kroah-Hartman , Jiri Slaby , Liam Girdwood , Mark Brown , Jaehoon Chung , Sam Protsenko , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-i2c@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-pwm@vger.kernel.org, linux-rtc@vger.kernel.org, linux-serial@vger.kernel.org, alsa-devel@alsa-project.org, linux-sound@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 17/17] arm64: dts: exynosautov9: add specific compatibles to several blocks Date: Wed, 8 Nov 2023 11:43:43 +0100 Message-Id: <20231108104343.24192-18-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231108104343.24192-1-krzysztof.kozlowski@linaro.org> References: <20231108104343.24192-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Message-ID-Hash: R2E2AAVZ6OR7BX66TC7NKVYVER4CZ3CE X-Message-ID-Hash: R2E2AAVZ6OR7BX66TC7NKVYVER4CZ3CE X-MailFrom: krzysztof.kozlowski@linaro.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: ExynosAutov9 reuses several devices from older designs, thus historically we kept the old (block's) compatible only. This works fine and there is no bug here, however guidelines expressed in Documentation/devicetree/bindings/writing-bindings.rst state that: 1. Compatibles should be specific. 2. We should add new compatibles in case of bugs or features. Add compatibles specific to ExynosAutov9 in front of all old-SoC-like compatibles. This will also help reviews of new code using existing DTS as template. No functional impact on Linux drivers behavior. Signed-off-by: Krzysztof Kozlowski --- arch/arm64/boot/dts/exynos/exynosautov9.dtsi | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/exynos/exynosautov9.dtsi b/arch/arm64/boot/dts/exynos/exynosautov9.dtsi index b228cd7e351e..417aa56a81f6 100644 --- a/arch/arm64/boot/dts/exynos/exynosautov9.dtsi +++ b/arch/arm64/boot/dts/exynos/exynosautov9.dtsi @@ -166,7 +166,8 @@ soc: soc@0 { ranges = <0x0 0x0 0x0 0x20000000>; chipid@10000000 { - compatible = "samsung,exynos850-chipid"; + compatible = "samsung,exynosautov9-chipid", + "samsung,exynos850-chipid"; reg = <0x10000000 0x24>; }; @@ -349,7 +350,8 @@ pinctrl_peric1: pinctrl@10830000 { }; pmu_system_controller: system-controller@10460000 { - compatible = "samsung,exynos7-pmu", "syscon"; + compatible = "samsung,exynosautov9-pmu", + "samsung,exynos7-pmu", "syscon"; reg = <0x10460000 0x10000>; reboot: syscon-reboot {