From patchwork Mon Jun 12 13:52:02 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Daniel Lezcano X-Patchwork-Id: 103618 Delivered-To: patch@linaro.org Received: by 10.140.91.77 with SMTP id y71csp203749qgd; Mon, 12 Jun 2017 06:53:35 -0700 (PDT) X-Received: by 10.99.110.132 with SMTP id j126mr1831513pgc.141.1497275615551; Mon, 12 Jun 2017 06:53:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1497275615; cv=none; d=google.com; s=arc-20160816; b=oThDpswCudK3W1VjmFcGKQ+dkukq0HE25LNY4yEPKi3IbxV+wrUwgPr/NmY9uqai6a PKLwNHsKBwLX1RFNrssk68qg2KuJ6H7OJ4zexi/g0qkvpzW9Y6d+LggQHCaWq7MhxdnQ UNWUniH0cht7cN0ANi7xfajppmtAuC8bQRPx7eSL84JFUamh9rkbDTHjSVmgJrOrhRD5 wH94Xk7YndwqJZpEybt4Q98f2BHTrTDUoY13JFnYIAB6/M4DcTn4nOtUKyBnrKUXye7T 2+NoJQxFWfhzwRIlRKnX635MJxgXKjrHiuT90ai+l/GNFOAnkEz/eeO7IUqLIvQF6NRU acuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=MogvrLiQNeMBNFZhZNN1UPIv0SSLfGoEhSCA/WEu4/M=; b=YwjgHjkkwODuLZIqNoawXIcX7yqt/B+MIRKNDV3KNMYEqu1x/I55otUIQIyczVmz90 88M2udkgYVowtuKg2oIuQ2t1OS2q1vJ3b6w2hFKc0AZ/Gkn34t/S2FrgHkKvcy+yTMLM xmBS13X4xsIX2F/GMvgXq71vPlUkfFJd0Kc5un0D0Q+aZKXgtDSQknVpWR7c6sO79PD6 VWhY+obYhtm5aaYqPkcyfDG/AQdPHJQbDmmdlyH+iKOTKYoGC6S/tT4TIvNwuZxMUTaI toC02/FZlsoj+uNgurdcYfOK6S8JPe8Duffos/Hun+Uq8pMTFISnWW/mOVzY42ey97An QtbA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u9si6987850plk.370.2017.06.12.06.53.35; Mon, 12 Jun 2017 06:53:35 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752142AbdFLNx1 (ORCPT + 25 others); Mon, 12 Jun 2017 09:53:27 -0400 Received: from mail-wr0-f180.google.com ([209.85.128.180]:36770 "EHLO mail-wr0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751977AbdFLNxZ (ORCPT ); Mon, 12 Jun 2017 09:53:25 -0400 Received: by mail-wr0-f180.google.com with SMTP id v111so98081756wrc.3 for ; Mon, 12 Jun 2017 06:53:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=MogvrLiQNeMBNFZhZNN1UPIv0SSLfGoEhSCA/WEu4/M=; b=LNT7SXKbw8gxytszSfMZMcHxLm1brn4T7ZAf3B2jw97b1r72dixflTQFI1eBmBgJ4Q YNBqCUNDP/N0AQtscnjY1E7tz2uSoyBMxE2Q30kFvX7TM3JcFcQDYy/uFWSv48vUf5H4 bK1FxuuSgObMtoBufsbAb45D5Kjc2UK0KL2qs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=MogvrLiQNeMBNFZhZNN1UPIv0SSLfGoEhSCA/WEu4/M=; b=NYOGM08xMxMblINFjLvIZMcTGlkGwBkOhgl2BZOXjARgZbo3PynNsmgcB70xxEUoLw /UfNg4brjJc4I7xmj3S19Nt9/7Pt50TCmLfjJ0jsPcqpiEcECDD094vMMEnnf+ZigPjp pPNecJ7fFl2Y5iQZSMXpWrQTF2v5KBH5rItB/tsTe+4vrQZcKGyvbzo1del7Rv9tgdMg CUjNZFK5aeJMViRr6FISrN7mW/TAS2lt1TMoBBBOHd5XJ4Ex4GOaTI2zUcqzxVC5dsnK Udby+rV5d3solqEVvXJ0ss0L/yjRjOP5twl3A1mw9VZsktXianYMI427ouz0V9mKIi3k dzXw== X-Gm-Message-State: AKS2vOxRX2GB56qnB3W8ybv+6JvpCN6ip7qr7ionmfIPX4asZ8xZfNcV BnfsEasTPw/OPjgg X-Received: by 10.28.105.136 with SMTP id z8mr7328957wmh.60.1497275603663; Mon, 12 Jun 2017 06:53:23 -0700 (PDT) Received: from localhost.localdomain ([2a01:e35:879a:6cd0:289a:9b8c:a41f:e1d5]) by smtp.gmail.com with ESMTPSA id n21sm8241428wra.38.2017.06.12.06.53.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 12 Jun 2017 06:53:23 -0700 (PDT) From: Daniel Lezcano To: tglx@linutronix.de Cc: linux-kernel@vger.kernel.org, vincent.guittot@linaro.org, peterz@infradead.org, rafael@kernel.org, nicolas.pitre@linaro.org, Mark Rutland , Vineet Gupta , Marc Zyngier , Patrice Chotard , Kukjin Kim , Javier Martinez Canillas , Christoffer Dall , Paolo Bonzini , =?utf-8?b?UmFkaW0gS3LEjW3DocWZ?= , Krzysztof Kozlowski , Russell King , Richard Cochran , Ray Jui , Christoph Hellwig , Jens Axboe , Hannes Reinecke , linux-arm-kernel@lists.infradead.org (moderated list:ARM PORT), linux-snps-arc@lists.infradead.org (open list:SYNOPSYS ARC ARCH...), linux-samsung-soc@vger.kernel.org (moderated list:ARM/SAMSUNG EXYNO...) Subject: [PATCH V10 1/3] irq: Allow to pass the IRQF_TIMER flag with percpu irq request Date: Mon, 12 Jun 2017 15:52:02 +0200 Message-Id: <1497275529-23565-1-git-send-email-daniel.lezcano@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <20170612135108.GD2261@mai> References: <20170612135108.GD2261@mai> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In the next changes, we track when the interrupts occur in order to statistically compute when is supposed to happen the next interrupt. In all the interruptions, it does not make sense to store the timer interrupt occurences and try to predict the next interrupt as when know the expiration time. The request_irq() has a irq flags parameter and the timer drivers use it to pass the IRQF_TIMER flag, letting us know the interrupt is coming from a timer. Based on this flag, we can discard these interrupts when tracking them. But, the API request_percpu_irq does not allow to pass a flag, hence specifying if the interrupt type is a timer. Add a function request_percpu_irq_flags() where we can specify the flags. The request_percpu_irq() function is changed to be a wrapper to request_percpu_irq_flags() passing a zero flag parameter. Change the timers using request_percpu_irq() to use request_percpu_irq_flags() instead with the IRQF_TIMER flag set. For now, in order to prevent a misusage of this parameter, only the IRQF_TIMER flag (or zero) is a valid parameter to be passed to the request_percpu_irq_flags() function. Signed-off-by: Daniel Lezcano Cc: Mark Rutland Cc: Vineet Gupta Cc: Marc Zyngier Cc: Patrice Chotard Cc: Kukjin Kim Cc: Javier Martinez Canillas Cc: Christoffer Dall Cc: Paolo Bonzini Cc: Radim Krčmář Acked-by: Krzysztof Kozlowski --- Changelog: V10: - Drop the change for arch arm virtual timer https://lkml.org/lkml/2017/4/25/184 V9: - Clarified the patch description - Fixed EXPORT_SYMBOL_GPL(request_percpu_irq_flags) Signed-off-by: Daniel Lezcano --- arch/arm/kernel/smp_twd.c | 3 ++- drivers/clocksource/arc_timer.c | 4 ++-- drivers/clocksource/arm_arch_timer.c | 20 ++++++++++++-------- drivers/clocksource/arm_global_timer.c | 4 ++-- drivers/clocksource/exynos_mct.c | 7 ++++--- drivers/clocksource/qcom-timer.c | 4 ++-- drivers/clocksource/time-armada-370-xp.c | 9 +++++---- drivers/clocksource/timer-nps.c | 6 +++--- include/linux/interrupt.h | 11 ++++++++++- kernel/irq/manage.c | 15 ++++++++++----- 10 files changed, 52 insertions(+), 31 deletions(-) -- 2.7.4 diff --git a/arch/arm/kernel/smp_twd.c b/arch/arm/kernel/smp_twd.c index 895ae51..ce9fdcf 100644 --- a/arch/arm/kernel/smp_twd.c +++ b/arch/arm/kernel/smp_twd.c @@ -332,7 +332,8 @@ static int __init twd_local_timer_common_register(struct device_node *np) goto out_free; } - err = request_percpu_irq(twd_ppi, twd_handler, "twd", twd_evt); + err = request_percpu_irq_flags(twd_ppi, twd_handler, IRQF_TIMER, "twd", + twd_evt); if (err) { pr_err("twd: can't register interrupt %d (%d)\n", twd_ppi, err); goto out_free; diff --git a/drivers/clocksource/arc_timer.c b/drivers/clocksource/arc_timer.c index 2164973..66f2632 100644 --- a/drivers/clocksource/arc_timer.c +++ b/drivers/clocksource/arc_timer.c @@ -301,8 +301,8 @@ static int __init arc_clockevent_setup(struct device_node *node) } /* Needs apriori irq_set_percpu_devid() done in intc map function */ - ret = request_percpu_irq(arc_timer_irq, timer_irq_handler, - "Timer0 (per-cpu-tick)", evt); + ret = request_percpu_irq_flags(arc_timer_irq, timer_irq_handler, IRQF_TIMER, + "Timer0 (per-cpu-tick)", evt); if (ret) { pr_err("clockevent: unable to request irq\n"); return ret; diff --git a/drivers/clocksource/arm_arch_timer.c b/drivers/clocksource/arm_arch_timer.c index 4bed671..22646b5 100644 --- a/drivers/clocksource/arm_arch_timer.c +++ b/drivers/clocksource/arm_arch_timer.c @@ -980,25 +980,29 @@ static int __init arch_timer_register(void) ppi = arch_timer_ppi[arch_timer_uses_ppi]; switch (arch_timer_uses_ppi) { case ARCH_TIMER_VIRT_PPI: - err = request_percpu_irq(ppi, arch_timer_handler_virt, - "arch_timer", arch_timer_evt); + err = request_percpu_irq_flags(ppi, arch_timer_handler_virt, + IRQF_TIMER, "arch_timer", + arch_timer_evt); break; case ARCH_TIMER_PHYS_SECURE_PPI: case ARCH_TIMER_PHYS_NONSECURE_PPI: - err = request_percpu_irq(ppi, arch_timer_handler_phys, - "arch_timer", arch_timer_evt); + err = request_percpu_irq_flags(ppi, arch_timer_handler_phys, + IRQF_TIMER, "arch_timer", + arch_timer_evt); if (!err && arch_timer_has_nonsecure_ppi()) { ppi = arch_timer_ppi[ARCH_TIMER_PHYS_NONSECURE_PPI]; - err = request_percpu_irq(ppi, arch_timer_handler_phys, - "arch_timer", arch_timer_evt); + err = request_percpu_irq_flags(ppi, arch_timer_handler_phys, + IRQF_TIMER, "arch_timer", + arch_timer_evt); if (err) free_percpu_irq(arch_timer_ppi[ARCH_TIMER_PHYS_SECURE_PPI], arch_timer_evt); } break; case ARCH_TIMER_HYP_PPI: - err = request_percpu_irq(ppi, arch_timer_handler_phys, - "arch_timer", arch_timer_evt); + err = request_percpu_irq_flags(ppi, arch_timer_handler_phys, + IRQF_TIMER, "arch_timer", + arch_timer_evt); break; default: BUG(); diff --git a/drivers/clocksource/arm_global_timer.c b/drivers/clocksource/arm_global_timer.c index 123ed20..5a72ec1 100644 --- a/drivers/clocksource/arm_global_timer.c +++ b/drivers/clocksource/arm_global_timer.c @@ -302,8 +302,8 @@ static int __init global_timer_of_register(struct device_node *np) goto out_clk; } - err = request_percpu_irq(gt_ppi, gt_clockevent_interrupt, - "gt", gt_evt); + err = request_percpu_irq_flags(gt_ppi, gt_clockevent_interrupt, + IRQF_TIMER, "gt", gt_evt); if (err) { pr_warn("global-timer: can't register interrupt %d (%d)\n", gt_ppi, err); diff --git a/drivers/clocksource/exynos_mct.c b/drivers/clocksource/exynos_mct.c index 670ff0f..a48ca0f 100644 --- a/drivers/clocksource/exynos_mct.c +++ b/drivers/clocksource/exynos_mct.c @@ -524,9 +524,10 @@ static int __init exynos4_timer_resources(struct device_node *np, void __iomem * if (mct_int_type == MCT_INT_PPI) { - err = request_percpu_irq(mct_irqs[MCT_L0_IRQ], - exynos4_mct_tick_isr, "MCT", - &percpu_mct_tick); + err = request_percpu_irq_flags(mct_irqs[MCT_L0_IRQ], + exynos4_mct_tick_isr, + IRQF_TIMER, "MCT", + &percpu_mct_tick); WARN(err, "MCT: can't request IRQ %d (%d)\n", mct_irqs[MCT_L0_IRQ], err); } else { diff --git a/drivers/clocksource/qcom-timer.c b/drivers/clocksource/qcom-timer.c index ee358cd..8e876fc 100644 --- a/drivers/clocksource/qcom-timer.c +++ b/drivers/clocksource/qcom-timer.c @@ -174,8 +174,8 @@ static int __init msm_timer_init(u32 dgt_hz, int sched_bits, int irq, } if (percpu) - res = request_percpu_irq(irq, msm_timer_interrupt, - "gp_timer", msm_evt); + res = request_percpu_irq_flags(irq, msm_timer_interrupt, + IRQF_TIMER, "gp_timer", msm_evt); if (res) { pr_err("request_percpu_irq failed\n"); diff --git a/drivers/clocksource/time-armada-370-xp.c b/drivers/clocksource/time-armada-370-xp.c index aea4380..fea81ad 100644 --- a/drivers/clocksource/time-armada-370-xp.c +++ b/drivers/clocksource/time-armada-370-xp.c @@ -309,10 +309,11 @@ static int __init armada_370_xp_timer_common_init(struct device_node *np) /* * Setup clockevent timer (interrupt-driven). */ - res = request_percpu_irq(armada_370_xp_clkevt_irq, - armada_370_xp_timer_interrupt, - "armada_370_xp_per_cpu_tick", - armada_370_xp_evt); + res = request_percpu_irq_flags(armada_370_xp_clkevt_irq, + armada_370_xp_timer_interrupt, + IRQF_TIMER, + "armada_370_xp_per_cpu_tick", + armada_370_xp_evt); /* Immediately configure the timer on the boot CPU */ if (res) { pr_err("Failed to request percpu irq\n"); diff --git a/drivers/clocksource/timer-nps.c b/drivers/clocksource/timer-nps.c index e74ea17..a83b6a4 100644 --- a/drivers/clocksource/timer-nps.c +++ b/drivers/clocksource/timer-nps.c @@ -256,9 +256,9 @@ static int __init nps_setup_clockevent(struct device_node *node) return ret; /* Needs apriori irq_set_percpu_devid() done in intc map function */ - ret = request_percpu_irq(nps_timer0_irq, timer_irq_handler, - "Timer0 (per-cpu-tick)", - &nps_clockevent_device); + ret = request_percpu_irq_flags(nps_timer0_irq, timer_irq_handler, + IRQF_TIMER, "Timer0 (per-cpu-tick)", + &nps_clockevent_device); if (ret) { pr_err("Couldn't request irq\n"); clk_disable_unprepare(clk); diff --git a/include/linux/interrupt.h b/include/linux/interrupt.h index a6fba48..89defd5 100644 --- a/include/linux/interrupt.h +++ b/include/linux/interrupt.h @@ -152,8 +152,17 @@ request_any_context_irq(unsigned int irq, irq_handler_t handler, unsigned long flags, const char *name, void *dev_id); extern int __must_check +request_percpu_irq_flags(unsigned int irq, irq_handler_t handler, + unsigned long flags, const char *devname, + void __percpu *percpu_dev_id); + +static inline int __must_check request_percpu_irq(unsigned int irq, irq_handler_t handler, - const char *devname, void __percpu *percpu_dev_id); + const char *devname, void __percpu *percpu_dev_id) +{ + return request_percpu_irq_flags(irq, handler, 0, + devname, percpu_dev_id); +} extern const void *free_irq(unsigned int, void *); extern void free_percpu_irq(unsigned int, void __percpu *); diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c index 070be98..057fde8 100644 --- a/kernel/irq/manage.c +++ b/kernel/irq/manage.c @@ -1958,9 +1958,10 @@ int setup_percpu_irq(unsigned int irq, struct irqaction *act) } /** - * request_percpu_irq - allocate a percpu interrupt line + * request_percpu_irq_flags - allocate a percpu interrupt line * @irq: Interrupt line to allocate * @handler: Function to be called when the IRQ occurs. + * @flags: Interrupt type flags (IRQF_TIMER only) * @devname: An ascii name for the claiming device * @dev_id: A percpu cookie passed back to the handler function * @@ -1973,8 +1974,9 @@ int setup_percpu_irq(unsigned int irq, struct irqaction *act) * the handler gets called with the interrupted CPU's instance of * that variable. */ -int request_percpu_irq(unsigned int irq, irq_handler_t handler, - const char *devname, void __percpu *dev_id) +int request_percpu_irq_flags(unsigned int irq, irq_handler_t handler, + unsigned long flags, const char *devname, + void __percpu *dev_id) { struct irqaction *action; struct irq_desc *desc; @@ -1988,12 +1990,15 @@ int request_percpu_irq(unsigned int irq, irq_handler_t handler, !irq_settings_is_per_cpu_devid(desc)) return -EINVAL; + if (flags && flags != IRQF_TIMER) + return -EINVAL; + action = kzalloc(sizeof(struct irqaction), GFP_KERNEL); if (!action) return -ENOMEM; action->handler = handler; - action->flags = IRQF_PERCPU | IRQF_NO_SUSPEND; + action->flags = flags | IRQF_PERCPU | IRQF_NO_SUSPEND; action->name = devname; action->percpu_dev_id = dev_id; @@ -2014,7 +2019,7 @@ int request_percpu_irq(unsigned int irq, irq_handler_t handler, return retval; } -EXPORT_SYMBOL_GPL(request_percpu_irq); +EXPORT_SYMBOL_GPL(request_percpu_irq_flags); /** * irq_get_irqchip_state - returns the irqchip state of a interrupt. From patchwork Mon Jun 12 13:52:03 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Lezcano X-Patchwork-Id: 103619 Delivered-To: patch@linaro.org Received: by 10.140.91.77 with SMTP id y71csp203790qgd; Mon, 12 Jun 2017 06:53:41 -0700 (PDT) X-Received: by 10.84.172.1 with SMTP id m1mr12661090plb.134.1497275621869; Mon, 12 Jun 2017 06:53:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1497275621; cv=none; d=google.com; s=arc-20160816; b=UmGKw+OGDJPteG3id3jcfbzcImpblPbh/8WpcDbldXnelyCtPDlHU3+2fpptxGSymP QzgqA/MKS9s2OfQ2wJNAOCkMzqJ1EbBtTfWrlG3EsFx0zb8VIxxm+YzDyKM4wl7RHxlM btfcjhrI20bJtuRvkqwabjREFFGDscKfOPLCO7k3CwIpSG0C8RsFdKwMSVhGhJ82QizW Hmt+JgpU5ZYIVMAdcsSBLEvHQomT37eToYcnVLwDI20oGwQSDwQubjXncuQuGTUX+5Jh Ia8EEfl4CKyw00PMpNM5zvcJo/LdnYOW2mHPVjznkuDE1uoPHw6WdztBKPNOlCbYhKcb zdLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=3ZODQpSxDAc/6+ddsE1g0FtXZYJ/XCSNiZXPs8WhrIs=; b=A3FMFi/SNhixI0uJ4Ja7C+vWw0d7nyewg8fhzL11uxE2/FcvPJXOUlzvB0Kj4O9YRJ FuTN//9oRZTVVGHiY5cIeTg2f6MD+WwOJOKGqRSWu/OCX0unAzOg5m49GAxubUEOtXzN NJ+s42cvw0nNIpakaKMp/MGexVe/FjOwnF09ypL4+aR1sjRxN0T8/tcOGC3EQuqZ0v/C beSzGV1BDvcl9kLHB2TFVM6em52Csju66xzrknkIA+Wqns5f7zYoh533wY+zZMwj9644 LteJxI3dKk5G/ScWylovDCwxEaEPYm5Y4/Qv7bF87v1vFvXbToDcccsvqKCd3avOCkI3 qXgQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v61si1341203plb.389.2017.06.12.06.53.41; Mon, 12 Jun 2017 06:53:41 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752207AbdFLNxe (ORCPT + 25 others); Mon, 12 Jun 2017 09:53:34 -0400 Received: from mail-wr0-f169.google.com ([209.85.128.169]:33509 "EHLO mail-wr0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752060AbdFLNxc (ORCPT ); Mon, 12 Jun 2017 09:53:32 -0400 Received: by mail-wr0-f169.google.com with SMTP id v104so97151464wrb.0 for ; Mon, 12 Jun 2017 06:53:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=3ZODQpSxDAc/6+ddsE1g0FtXZYJ/XCSNiZXPs8WhrIs=; b=HeXf7GaLzZnx+nu5XvH6KZrxH7WwOS/TaeuKxlDRxxpTW+Rn91TVY7wrSXfV79foz/ PJzOZY/1ygV0Aaxe3TUKqVtMxvhQDdpK75E92uukLFE5ZRMS3CZ/IHxRlkoa/9YTKKNK yOk5VwuslFRK78qeQ67EwF2hHoSNybuBaSvcs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=3ZODQpSxDAc/6+ddsE1g0FtXZYJ/XCSNiZXPs8WhrIs=; b=EnsdBtcV1xJElZ97nptXHo5XT+eMV3J+j48eKP0rqAEuhVPRDLLN8r3HFc+mTre6Li 2ID52K9xChQR/6ngat8BU5/hMP6JuF5xLOTAsP75E1tyqIlGHacRHUzLXS5J6bWkii8H kIpLZZAkKWOsnnDeRJ24Wei26jKvrspZwV11G/6t0O1jh/qUMog4mRW4+KkU0xkqUXZc AzCQwThv1B5pIdWzfQd8gfcoR866pUuwQsIJBnCc6Lv5jYqGvqtf6VPwKXVzlifHPlvk 0AlTSRdx7IXlQsf4aOV1M3KZh4pWc7z9nFuvqPUeZ34lgLkHD29Uh9I57nQcgQSGUzHo UeGw== X-Gm-Message-State: AKS2vOw+r+N0JwBpASRl6OEWXGmj7q88ovl+NzLjx15nrcH1zws5YONe 64BItZ5teU0YNOZbMxoo3Q== X-Received: by 10.28.178.198 with SMTP id b189mr7898068wmf.8.1497275609308; Mon, 12 Jun 2017 06:53:29 -0700 (PDT) Received: from localhost.localdomain ([2a01:e35:879a:6cd0:289a:9b8c:a41f:e1d5]) by smtp.gmail.com with ESMTPSA id n21sm8241428wra.38.2017.06.12.06.53.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 12 Jun 2017 06:53:28 -0700 (PDT) From: Daniel Lezcano To: tglx@linutronix.de Cc: linux-kernel@vger.kernel.org, vincent.guittot@linaro.org, peterz@infradead.org, rafael@kernel.org, nicolas.pitre@linaro.org, Christoph Hellwig , Hannes Reinecke , Jens Axboe Subject: [PATCH V10 2/3] irq: Track the interrupt timings Date: Mon, 12 Jun 2017 15:52:03 +0200 Message-Id: <1497275529-23565-2-git-send-email-daniel.lezcano@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1497275529-23565-1-git-send-email-daniel.lezcano@linaro.org> References: <20170612135108.GD2261@mai> <1497275529-23565-1-git-send-email-daniel.lezcano@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The interrupt framework gives a lot of information about each interrupt. It does not keep track of when those interrupts occur though. This patch provides a mean to record the timestamp for each interrupt occurrences in a per-CPU circular buffer to help with the prediction of the next occurrence using a statistical model. Each CPU can store IRQ_TIMINGS_SIZE events , the current value of IRQ_TIMINGS_SIZE is 32. Each event is encoded into a single u64, where the 48 bits are used for the timestamp and the next 16 bits are for the irq number. A static key is introduced so when the irq prediction is switched off at runtime, we can reduce the overhead near to zero. It results in most of the code in internals.h for inline reason and a very few in the new file timings.c. The latter will contain more in the next patch which will provide the statistical model for the next event prediction. Note this code is by default *not* compiled in the kernel. Signed-off-by: Daniel Lezcano Acked-by: Nicolas Pitre Cc: Peter Zijlstra Cc: Rafael J. Wysocki Cc: Vincent Guittot --- V9: - Changed indentation level by inverting the static key condition - Encoded interrupt and timestamp into a u64 variable - Boolean enable instead of refcount for the static key V8: - Replaced percpu field in the irqdesc by a percpu array containing the timings and the associated irq. The function irq_timings_get_next() is no longer needed, so it is removed - Removed all unused code resulting from the conversion irqdesc->percpu timings storage V7: - Mentionned in the irq_timings_get_next() function description, the function must be called inside a rcu read locked section V6: - Renamed handle_irq_timings to record_irq_time - Stored the event time instead of the interval time - Removed the 'timestamp' field from the timings structure - Moved _handle_irq_timings content inside record_irq_time V5: - Changed comment about 'deterministic' as the comment is confusing - Added license comment in the header - Replaced irq_timings_get/put by irq_timings_enable/disable - Moved IRQS_TIMINGS check in the handle_timings inline function - Dropped 'if !prev' as it is pointless - Stored time interval in nsec basis with u64 instead of u32 - Removed redundant store - Removed the math V4: - Added a static key - Added more comments for irq_timings_get_next() - Unified some function names to be prefixed by 'irq_timings_...' - Fixed a rebase error V3: - Replaced ktime_get() by local_clock() - Shared irq are not handled - Simplified code by adding the timing in the irqdesc struct - Added a function to browse the irq timings V2: - Fixed kerneldoc comment - Removed data field from the struct irq timing - Changed the lock section comment - Removed semi-colon style with empty stub - Replaced macro by static inline - Fixed static functions declaration RFC: - initial posting Signed-off-by: Daniel Lezcano --- include/linux/interrupt.h | 5 +++ kernel/irq/Kconfig | 3 ++ kernel/irq/Makefile | 1 + kernel/irq/handle.c | 2 ++ kernel/irq/internals.h | 84 +++++++++++++++++++++++++++++++++++++++++++++++ kernel/irq/manage.c | 3 ++ kernel/irq/timings.c | 30 +++++++++++++++++ 7 files changed, 128 insertions(+) create mode 100644 kernel/irq/timings.c -- 2.7.4 diff --git a/include/linux/interrupt.h b/include/linux/interrupt.h index 89defd5..4c9d3ca 100644 --- a/include/linux/interrupt.h +++ b/include/linux/interrupt.h @@ -712,6 +712,11 @@ static inline void init_irq_proc(void) } #endif +#ifdef CONFIG_IRQ_TIMINGS +void irq_timings_enable(void); +void irq_timings_disable(void); +#endif + struct seq_file; int show_interrupts(struct seq_file *p, void *v); int arch_show_interrupts(struct seq_file *p, int prec); diff --git a/kernel/irq/Kconfig b/kernel/irq/Kconfig index 3bbfd6a..38e551d 100644 --- a/kernel/irq/Kconfig +++ b/kernel/irq/Kconfig @@ -81,6 +81,9 @@ config GENERIC_MSI_IRQ_DOMAIN config HANDLE_DOMAIN_IRQ bool +config IRQ_TIMINGS + bool + config IRQ_DOMAIN_DEBUG bool "Expose hardware/virtual IRQ mapping via debugfs" depends on IRQ_DOMAIN && DEBUG_FS diff --git a/kernel/irq/Makefile b/kernel/irq/Makefile index 1d3ee31..efb5f14 100644 --- a/kernel/irq/Makefile +++ b/kernel/irq/Makefile @@ -10,3 +10,4 @@ obj-$(CONFIG_PM_SLEEP) += pm.o obj-$(CONFIG_GENERIC_MSI_IRQ) += msi.o obj-$(CONFIG_GENERIC_IRQ_IPI) += ipi.o obj-$(CONFIG_SMP) += affinity.o +obj-$(CONFIG_IRQ_TIMINGS) += timings.o diff --git a/kernel/irq/handle.c b/kernel/irq/handle.c index d3f2490..eb4d3e8 100644 --- a/kernel/irq/handle.c +++ b/kernel/irq/handle.c @@ -138,6 +138,8 @@ irqreturn_t __handle_irq_event_percpu(struct irq_desc *desc, unsigned int *flags unsigned int irq = desc->irq_data.irq; struct irqaction *action; + record_irq_time(desc); + for_each_action_of_desc(desc, action) { irqreturn_t res; diff --git a/kernel/irq/internals.h b/kernel/irq/internals.h index bc226e7..df51b5e0 100644 --- a/kernel/irq/internals.h +++ b/kernel/irq/internals.h @@ -8,6 +8,7 @@ #include #include #include +#include #ifdef CONFIG_SPARSE_IRQ # define IRQ_BITMAP_BITS (NR_IRQS + 8196) @@ -57,6 +58,7 @@ enum { IRQS_WAITING = 0x00000080, IRQS_PENDING = 0x00000200, IRQS_SUSPENDED = 0x00000800, + IRQS_TIMINGS = 0x00001000, }; #include "debug.h" @@ -226,3 +228,85 @@ irq_pm_install_action(struct irq_desc *desc, struct irqaction *action) { } static inline void irq_pm_remove_action(struct irq_desc *desc, struct irqaction *action) { } #endif + +#ifdef CONFIG_IRQ_TIMINGS + +#define IRQ_TIMINGS_SHIFT 5 +#define IRQ_TIMINGS_SIZE (1 << IRQ_TIMINGS_SHIFT) +#define IRQ_TIMINGS_MASK (IRQ_TIMINGS_SIZE - 1) + +struct irq_timings { + u64 values[IRQ_TIMINGS_SIZE]; /* our circular buffer */ + unsigned int count; /* Number of interruptions since last inspection */ +}; + +DECLARE_PER_CPU(struct irq_timings, irq_timings); + +static inline void remove_timings(struct irq_desc *desc) +{ + desc->istate &= ~IRQS_TIMINGS; +} + +static inline void setup_timings(struct irq_desc *desc, struct irqaction *act) +{ + /* + * We don't need the measurement because the idle code already + * knows the next expiry event. + */ + if (act->flags & __IRQF_TIMER) + return; + + desc->istate |= IRQS_TIMINGS; +} + +extern void irq_timings_enable(void); +extern void irq_timings_disable(void); + +extern struct static_key_false irq_timing_enabled; + +/* + * The interrupt number and the timestamp are encoded into a single + * u64 variable to optimize the size. + * 48 bit time stamp and 16 bit IRQ number is way sufficient. + * Who cares an IRQ after 78 hours of idle time? + */ +static inline u64 irq_timing_encode(u64 timestamp, int irq) +{ + return (timestamp << 16) | irq; +} + +static inline void irq_timing_decode(u64 value, u64 *timestamp, int *irq) +{ + *timestamp = value >> 16; + *irq = value & U16_MAX; +} + +/* + * The function record_irq_time is only called in one place in the + * interrupts handler. We want this function always inline so the code + * inside is embedded in the function and the static key branching + * code can act at the higher level. Without the explicit + * __always_inline we can end up with a function call and a small + * overhead in the hotpath for nothing. + */ +static __always_inline void record_irq_time(struct irq_desc *desc) +{ + if (!static_branch_likely(&irq_timing_enabled)) + return; + + if (desc->istate & IRQS_TIMINGS) { + struct irq_timings *timings = this_cpu_ptr(&irq_timings); + + timings->values[timings->count & IRQ_TIMINGS_MASK] = + irq_timing_encode(local_clock(), + irq_desc_get_irq(desc)); + + timings->count++; + } +} +#else +static inline void remove_timings(struct irq_desc *desc) {} +static inline void setup_timings(struct irq_desc *desc, + struct irqaction *act) {}; +static inline void record_irq_time(struct irq_desc *desc) {} +#endif /* CONFIG_IRQ_TIMINGS */ diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c index 057fde8..5dfa63d 100644 --- a/kernel/irq/manage.c +++ b/kernel/irq/manage.c @@ -1372,6 +1372,8 @@ __setup_irq(unsigned int irq, struct irq_desc *desc, struct irqaction *new) raw_spin_unlock_irqrestore(&desc->lock, flags); + setup_timings(desc, new); + /* * Strictly no need to wake it up, but hung_task complains * when no hard interrupt wakes the thread up. @@ -1500,6 +1502,7 @@ static struct irqaction *__free_irq(unsigned int irq, void *dev_id) irq_settings_clr_disable_unlazy(desc); irq_shutdown(desc); irq_release_resources(desc); + remove_timings(desc); } #ifdef CONFIG_SMP diff --git a/kernel/irq/timings.c b/kernel/irq/timings.c new file mode 100644 index 0000000..56cf687 --- /dev/null +++ b/kernel/irq/timings.c @@ -0,0 +1,30 @@ +/* + * linux/kernel/irq/timings.c + * + * Copyright (C) 2016, Linaro Ltd - Daniel Lezcano + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 as + * published by the Free Software Foundation. + * + */ +#include +#include +#include +#include + +#include "internals.h" + +DEFINE_STATIC_KEY_FALSE(irq_timing_enabled); + +DEFINE_PER_CPU(struct irq_timings, irq_timings); + +void irq_timings_enable(void) +{ + static_branch_enable(&irq_timing_enabled); +} + +void irq_timings_disable(void) +{ + static_branch_disable(&irq_timing_enabled); +} From patchwork Mon Jun 12 13:52:04 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Lezcano X-Patchwork-Id: 103620 Delivered-To: patch@linaro.org Received: by 10.140.91.77 with SMTP id y71csp203796qgd; Mon, 12 Jun 2017 06:53:43 -0700 (PDT) X-Received: by 10.84.162.204 with SMTP id o12mr57926998plg.23.1497275622941; Mon, 12 Jun 2017 06:53:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1497275622; cv=none; d=google.com; s=arc-20160816; b=rkaR4Lrbo4lQ4ouPIyuURam5deHRQWPcIg5gzy1i6pzYIuWJlQIky3kJdqYlrVTLEW mP/Ky7RwljC9w9hZDdmNWSGPnxgfW/4HZUnJ1uk/Xtz/zs1lYgJUxxF4ADlyNb9n3ofB r/gJE4sbac4KK3xVzgmsV/XnX6VABzcR1mAK9jVtehqMXRQwmydwsTYRpa3quewCqmkV qNP8Dae7qbquDperOHIatDRaMAn+QpvC8JknQNlPaebZZkgAp4c/mUQaBuIQJAsryaTy CafruCjXu1ZUbB6FtWCQ/SVm/VANX3c7KnGTSTCmFzcO/p858g6jnWCcfClj1i4RpWuW acpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=A/0AOjkjRUS38Bn4PRaUIsoQathIeL2sdVKDIuY7us8=; b=W0Y+qrL8tS6uvxkydr4eYcuiiG2YKRSP/W6iLv69H7hvXzS+/Y3FB/6/Pudd5khd1T p94NKBghIJ6wpGVFFsARU493PXjnAWD/PUWgq85QXB5Yc79Qfi0UuM0hbFQfmFkSk3Mw iw/0/0jUpnMDnRRTT2d9JO1kcUeRJr8XKHLsYElXvKDoEb7+bBc3YTOOYssEytnsY85A Li2mE/IAz2uZS/r2SaScotwAZoQTbEYOvuG3nkm95eei9bKWc/eiretIkHkOpBpQidLJ /mvtUO+1SJceBs5jqZ0VEaE1PQIK44eP9FFnq1RrrwxXjeSOSmP0q2Mml09+An0E+JPd rsXQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v61si1341203plb.389.2017.06.12.06.53.42; Mon, 12 Jun 2017 06:53:42 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752251AbdFLNxh (ORCPT + 25 others); Mon, 12 Jun 2017 09:53:37 -0400 Received: from mail-wr0-f171.google.com ([209.85.128.171]:35234 "EHLO mail-wr0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752159AbdFLNxf (ORCPT ); Mon, 12 Jun 2017 09:53:35 -0400 Received: by mail-wr0-f171.google.com with SMTP id q97so98301351wrb.2 for ; Mon, 12 Jun 2017 06:53:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=A/0AOjkjRUS38Bn4PRaUIsoQathIeL2sdVKDIuY7us8=; b=YXNiVdMnVWTCM9K/kUgJR2GekI8tqOQKfLfSU6qXV1O3XX3lyfa+EkRaiLC1rkFHT9 kSggSmHRUQ2xJlVujLhb8zEwKxRxIE1YaN5CKnFxK9M8y1FYxuA5eWkqaeLzu57lmvq8 L4vOR7kxpr0YX0jcp8qDCEBAgavX2mdGUFWGc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=A/0AOjkjRUS38Bn4PRaUIsoQathIeL2sdVKDIuY7us8=; b=ERCQ7tEcOt2/DV/tBHeobYNvtXY6on3TCMIK7fXn0qPuN6RaJiY04sR1D6wKnN1PHG SDmMCT+4xc3OnQqTACeKTH3/KZzHgJ65hCHmexNWkXTWeujVZY1AZnWIdnL5SxbXiI7P swSrLqG3iuT0KE4dA3at1q4D8UTP8a+UeW7zmSgj6WRvFsRgrnv8cmPl1L+xL4SL8NA6 gdW+pX77JjWzBLNK04yDyED5zIEN1gaslVZ1jWlrvv9YaUzogtFHfr0cMQV5MC477Aak rJzvet2wHXxj90zVHUkGGI4dY40Tk+8M/DxOlSv92jq7u7yfL9shRyxLoQyoh/ciSlQu Ru1g== X-Gm-Message-State: AKS2vOxPfhn0fdW/AWzV1EwBIB6bDaBxdnU/AB+KDTgd2aCBGCIJEvzf 77p6J55VR1sOfChQ X-Received: by 10.28.51.73 with SMTP id z70mr7954163wmz.65.1497275613346; Mon, 12 Jun 2017 06:53:33 -0700 (PDT) Received: from localhost.localdomain ([2a01:e35:879a:6cd0:289a:9b8c:a41f:e1d5]) by smtp.gmail.com with ESMTPSA id n21sm8241428wra.38.2017.06.12.06.53.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 12 Jun 2017 06:53:32 -0700 (PDT) From: Daniel Lezcano To: tglx@linutronix.de Cc: linux-kernel@vger.kernel.org, vincent.guittot@linaro.org, peterz@infradead.org, rafael@kernel.org, nicolas.pitre@linaro.org, Christoph Hellwig , Jens Axboe , Hannes Reinecke Subject: [PATCH V10 3/3] irq: Compute the periodic interval for interrupts Date: Mon, 12 Jun 2017 15:52:04 +0200 Message-Id: <1497275529-23565-3-git-send-email-daniel.lezcano@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1497275529-23565-1-git-send-email-daniel.lezcano@linaro.org> References: <20170612135108.GD2261@mai> <1497275529-23565-1-git-send-email-daniel.lezcano@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org An interrupt behaves with a burst of activity with periodic interval of time followed by one or two peaks of longer interval. As the time intervals are periodic, statistically speaking they follow a normal distribution and each interrupts can be tracked individually. This patch does statistics on all interrupts, except the timers which are deterministic by essence. The goal is to extract the periodicity for each interrupt, with the last timestamp and sum them, so we have the next event. Taking the earliest prediction gives the expected wakeup on the system (assuming a timer won't expire before). As stated in the previous patch, this code is not enabled in the kernel by default. Signed-off-by: Daniel Lezcano Cc: Peter Zijlstra Cc: Rafael J. Wysocki Cc: Vincent Guittot Cc: Nicolas Pitre --- Changelog: V10: - Simplified index/count computation V9: - Deal with 48+16 bits encoded values - Changed irq_stat => irqt_stat to prevent name collision on s390 - Changed div64 by constant IRQ_TIMINGS_SHIFT bit shift for average - Changed div64 by constant IRQ_TIMINGS_SHIFT bit shift for variance Signed-off-by: Daniel Lezcano --- include/linux/interrupt.h | 1 + kernel/irq/internals.h | 21 ++- kernel/irq/timings.c | 336 ++++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 357 insertions(+), 1 deletion(-) -- 2.7.4 diff --git a/include/linux/interrupt.h b/include/linux/interrupt.h index 4c9d3ca..1546ccd 100644 --- a/include/linux/interrupt.h +++ b/include/linux/interrupt.h @@ -715,6 +715,7 @@ static inline void init_irq_proc(void) #ifdef CONFIG_IRQ_TIMINGS void irq_timings_enable(void); void irq_timings_disable(void); +u64 irq_timings_next_event(u64 now); #endif struct seq_file; diff --git a/kernel/irq/internals.h b/kernel/irq/internals.h index df51b5e0..bf3d827 100644 --- a/kernel/irq/internals.h +++ b/kernel/irq/internals.h @@ -237,18 +237,26 @@ irq_pm_remove_action(struct irq_desc *desc, struct irqaction *action) { } struct irq_timings { u64 values[IRQ_TIMINGS_SIZE]; /* our circular buffer */ - unsigned int count; /* Number of interruptions since last inspection */ + int count; /* Number of interruptions since last inspection */ }; DECLARE_PER_CPU(struct irq_timings, irq_timings); +extern void irq_timings_free(int irq); +extern int irq_timings_alloc(int irq); + static inline void remove_timings(struct irq_desc *desc) { desc->istate &= ~IRQS_TIMINGS; + + irq_timings_free(irq_desc_get_irq(desc)); } static inline void setup_timings(struct irq_desc *desc, struct irqaction *act) { + int irq = irq_desc_get_irq(desc); + int ret; + /* * We don't need the measurement because the idle code already * knows the next expiry event. @@ -256,6 +264,17 @@ static inline void setup_timings(struct irq_desc *desc, struct irqaction *act) if (act->flags & __IRQF_TIMER) return; + /* + * In case the timing allocation fails, we just want to warn, + * not fail, so letting the system boot anyway. + */ + ret = irq_timings_alloc(irq); + if (ret) { + pr_warn("Failed to allocate irq timing stats for irq%d (%d)", + irq, ret); + return; + } + desc->istate |= IRQS_TIMINGS; } diff --git a/kernel/irq/timings.c b/kernel/irq/timings.c index 56cf687..4af7703 100644 --- a/kernel/irq/timings.c +++ b/kernel/irq/timings.c @@ -8,10 +8,16 @@ * published by the Free Software Foundation. * */ +#include #include +#include #include #include +#include #include +#include + +#include #include "internals.h" @@ -19,6 +25,18 @@ DEFINE_STATIC_KEY_FALSE(irq_timing_enabled); DEFINE_PER_CPU(struct irq_timings, irq_timings); +struct irqt_stat { + u64 ne; /* next event */ + u64 lts; /* last timestamp */ + u64 variance; /* variance */ + u32 avg; /* mean value */ + u32 count; /* number of samples */ + int anomalies; /* number of consecutives anomalies */ + int valid; /* behaviour of the interrupt */ +}; + +static DEFINE_IDR(irqt_stats); + void irq_timings_enable(void) { static_branch_enable(&irq_timing_enabled); @@ -28,3 +46,321 @@ void irq_timings_disable(void) { static_branch_disable(&irq_timing_enabled); } + +/** + * irqs_update - update the irq timing statistics with a new timestamp + * + * @irqs: an irqt_stat struct pointer + * @ts: the new timestamp + * + * ** This function must be called with the local irq disabled ** + * + * The statistics are computed online, in other words, the code is + * designed to compute the statistics on a stream of values rather + * than doing multiple passes on the values to compute the average, + * then the variance. The integer division introduces a loss of + * precision but with an acceptable error margin regarding the results + * we would have with the double floating precision: we are dealing + * with nanosec, so big numbers, consequently the mantisse is + * negligeable, especially when converting the time in usec + * afterwards. + * + * The computation happens at idle time. When the CPU is not idle, the + * interrupts' timestamps are stored in the circular buffer, when the + * CPU goes idle and this routine is called, all the buffer's values + * are injected in the statistical model continuying to extend the + * statistics from the previous busy-idle cycle. + * + * The observations showed a device will trigger a burst of periodic + * interrupts followed by one or two peaks of longer time, for + * instance when a SD card device flushes its cache, then the periodic + * intervals occur again. A one second inactivity period resets the + * stats, that gives us the certitude the statistical values won't + * exceed 1x10^9, thus the computation won't overflow. + * + * Basically, the purpose of the algorithm is to watch the periodic + * interrupts and eliminate the peaks. + * + * An interrupt is considered periodically stable if the interval of + * its occurences follow the normal distribution, thus the values + * comply with: + * + * avg - 3 x stddev < value < avg + 3 x stddev + * + * Which can be simplified to: + * + * -3 x stddev < value - avg < 3 x stddev + * + * abs(value - avg) < 3 x stddev + * + * In order to save a costly square root computation, we use the + * variance. For the record, stddev = sqrt(variance). The equation + * above becomes: + * + * abs(value - avg) < 3 x sqrt(variance) + * + * And finally we square it: + * + * (value - avg) ^ 2 < (3 x sqrt(variance)) ^ 2 + * + * (value - avg) x (value - avg) < 9 x variance + * + * Statistically speaking, any values out of this interval is + * considered as an anomaly and is discarded. However, a normal + * distribution appears when the number of samples is 30 (it is the + * rule of thumb in statistics, cf. "30 samples" on Internet). When + * there are three consecutive anomalies, the statistics are resetted. + * + */ +static void irqs_update(struct irqt_stat *irqs, u64 ts) +{ + u64 old_ts = irqs->lts; + u64 variance = 0; + u64 interval; + s64 diff; + + /* + * The timestamps are absolute time values, we need to compute + * the timing interval between two interrupts. + */ + irqs->lts = ts; + + /* + * The interval type is u64 in order to deal with the same + * type in our computation, that prevent mindfuck issues with + * overflow, sign and division. + */ + interval = ts - old_ts; + + /* + * The interrupt triggered more than one second apart, that + * ends the sequence as predictible for our purpose. In this + * case, assume we have the beginning of a sequence and the + * timestamp is the first value. As it is impossible to + * predict anything at this point, return. + * + * Note the first timestamp of the sequence will always fall + * in this test because the old_ts is zero. That is what we + * want as we need another timestamp to compute an interval. + */ + if (interval >= NSEC_PER_SEC) { + memset(irqs, 0, sizeof(*irqs)); + irqs->lts = ts; + return; + } + + /* + * Pre-compute the delta with the average as the result is + * used several times in this function. + */ + diff = interval - irqs->avg; + + /* + * Increment the number of samples. + */ + irqs->count++; + + /* + * Online variance divided by the number of elements if there + * is more than one sample. Normally the formula is division + * by count - 1 but we assume the number of element will be + * more than 32 and dividing by 32 instead of 31 is enough + * precise. + */ + if (likely(irqs->count > 1)) + variance = irqs->variance >> IRQ_TIMINGS_SHIFT; + + /* + * The rule of thumb in statistics for the normal distribution + * is having at least 30 samples in order to have the model to + * apply. Values outside the interval are considered as an + * anomaly. + */ + if ((irqs->count >= 30) && ((diff * diff) > (9 * variance))) { + /* + * After three consecutive anomalies, we reset the + * stats as it is no longer stable enough. + */ + if (irqs->anomalies++ >= 3) { + memset(irqs, 0, sizeof(*irqs)); + irqs->lts = ts; + return; + } + } else { + /* + * The anomalies must be consecutives, so at this + * point, we reset the anomalies counter. + */ + irqs->anomalies = 0; + } + + /* + * The interrupt is considered stable enough to try to predict + * the next event on it. + */ + irqs->valid = 1; + + /* + * Online average algorithm: + * + * new_average = average + ((value - average) / count) + * + * The variance computation depends on the new average + * to be computed here first. + * + */ + irqs->avg = irqs->avg + (diff >> IRQ_TIMINGS_SHIFT); + + /* + * Online variance algorithm: + * + * new_variance = variance + (value - average) x (value - new_average) + * + * Warning: irqs->avg is updated with the line above, hence + * 'interval - irqs->avg' is no longer equal to 'diff' + */ + irqs->variance = irqs->variance + (diff * (interval - irqs->avg)); + + /* + * Update the next event + */ + irqs->ne = ts + irqs->avg; +} + +/** + * irq_timings_next_event - Return when the next event is supposed to arrive + * + * *** This function must be called with the local irq disabled *** + * + * During the last busy cycle, the number of interrupts is incremented + * and stored in the irq_timings structure. This information is + * necessary to: + * + * - know if the index in the table wrapped up: + * + * If more than the array size interrupts happened during the + * last busy/idle cycle, the index wrapped up and we have to + * begin with the next element in the array which is the last one + * in the sequence, otherwise it is a the index 0. + * + * - have an indication of the interrupts activity on this CPU + * (eg. irq/sec) + * + * The values are 'consumed' after inserting in the statistical model, + * thus the count is reinitialized. + * + * The array of values **must** be browsed in the time direction, the + * timestamp must increase between an element and the next one. + * + * Returns a nanosec time based estimation of the earliest interrupt, + * U64_MAX otherwise. + */ +u64 irq_timings_next_event(u64 now) +{ + struct irq_timings *irqts = this_cpu_ptr(&irq_timings); + struct irqt_stat *irqs; + struct irqt_stat __percpu *s; + u64 ts, ne = U64_MAX; + int i, irq = 0; + + /* + * Number of elements in the circular buffer: If it happens it + * was flushed before, then the number of elements could be + * smaller than IRQ_TIMINGS_SIZE, so the count is used, + * otherwise the array size is used as we wrapped. The index + * begins from zero when we did not wrap. That could be done + * in a nicer way with the proper circular array structure + * type but with the cost of extra computation in the + * interrupt handler hot path. We choose efficiency. + * + * Inject measured irq/timestamp to the statistical model + * while decrementing the counter because we consume the data + * from our circular buffer. + */ + for (i = irqts->count & IRQ_TIMINGS_MASK, + irqts->count = min(IRQ_TIMINGS_SIZE, irqts->count); + irqts->count > 0; irqts->count--, i = (i + 1) & IRQ_TIMINGS_MASK) { + + irq_timing_decode(irqts->values[i], &ts, &irq); + + s = idr_find(&irqt_stats, irq); + if (s) { + irqs = this_cpu_ptr(s); + irqs_update(irqs, ts); + } + } + + /* + * Look in the list of interrupts' statistics, the earliest + * next event. + */ + idr_for_each_entry(&irqt_stats, s, i) { + + irqs = this_cpu_ptr(s); + + if (!irqs->valid) + continue; + + if (irqs->ne <= now) { + irq = i; + ne = now; + + /* + * This interrupt mustn't use in the future + * until new events occur and update the + * statistics. + */ + irqs->valid = 0; + break; + } + + if (irqs->ne < ne) { + irq = i; + ne = irqs->ne; + } + } + + return ne; +} + +void irq_timings_free(int irq) +{ + struct irqt_stat __percpu *s; + + s = idr_find(&irqt_stats, irq); + if (s) { + free_percpu(s); + idr_remove(&irqt_stats, irq); + } +} + +int irq_timings_alloc(int irq) +{ + int id; + struct irqt_stat __percpu *s; + + /* + * Some platforms can have the same private interrupt per cpu, + * so this function may be be called several times with the + * same interrupt number. Just bail out in case the per cpu + * stat structure is already allocated. + */ + s = idr_find(&irqt_stats, irq); + if (s) + return 0; + + s = alloc_percpu(*s); + if (!s) + return -ENOMEM; + + idr_preload(GFP_KERNEL); + id = idr_alloc(&irqt_stats, s, irq, irq + 1, GFP_NOWAIT); + idr_preload_end(); + + if (id < 0) { + free_percpu(s); + return id; + } + + return 0; +}