From patchwork Thu Aug 15 19:51:14 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julien Grall X-Patchwork-Id: 171447 Delivered-To: patch@linaro.org Received: by 2002:a92:d204:0:0:0:0:0 with SMTP id y4csp2611110ily; Thu, 15 Aug 2019 12:52:51 -0700 (PDT) X-Google-Smtp-Source: APXvYqyZcdPAeKpJBv9ZFVfKGesA1tASLNKtzWSH6G8CBMyiBI81qbS7I8BzMuNGbItWssLTmni5 X-Received: by 2002:a5e:990a:: with SMTP id t10mr6995052ioj.182.1565898771538; Thu, 15 Aug 2019 12:52:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565898771; cv=none; d=google.com; s=arc-20160816; b=A2+Z48sZKp1uoOAEhsLyMtth2HZtEFZAq1fqLH0Tzvfht7M8t2fUURNAuSFNspxWU+ OZhhwaaXHo+xgpkTmq01kLsx7sAhlOm1G3R8sB6zUM1YaE9DEtOh+Yjd/d734kz6loIk DV8Jpco4GbLTzP4JnYHgyyot0jD9w5pR4OpnBUvMpFdp5CUzMOrXnZOPUkx2PwJ7ZeAT dVokrDVD7jKSvgfdIn9LQp1bmPyzacaCX7kO1W6TkRhdspPrykmS5xFBUpb6qdPpm2XM nOEQdoWEub0OYY4oeo7BTm+oIAHpNnoj/u7rOORIlNhzqXyr8fgV0WHs/qWZeLRmPPmm x2yg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:cc :list-subscribe:list-help:list-post:list-unsubscribe:list-id :precedence:subject:message-id:date:to:from; bh=mQdUvx5gJgTNLstjT+D9NZa8lvRWXgEAlwdJfeAEzm8=; b=PWkWGLBL8aWRYLv8MfLxCIJxU68J0u4l70H5hVz3Nmv/0GgGXVN8iPs8I5KNGzUM/L yGRm6Me+Z9CEyXyr7GhahTBT9pqlqHczk3+3l7lPr8qfJB27Tak6OvAbAqKGI1kGqOVW f+mEjgUSpSY8e/kJFHwKis9rvI+zLSr9j40whwaquCi7Zs1m9trtN6liEUpgRyeAqMJj ACOQ4rLYY3TAaB855fvE4p/gorjLzycBKXhTZg5WZczunr5F0eZuWyfn9s+zB1BTGm9s K7Nh7KSpbISqC488rLhB4suMT3XqNHJVtEhshtnCPXdpK0VjQh0FStIcLxh0wAvDhaA2 oCUg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of xen-devel-bounces@lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org. [192.237.175.120]) by mx.google.com with ESMTPS id k11si3498623ior.16.2019.08.15.12.52.51 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 15 Aug 2019 12:52:51 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of xen-devel-bounces@lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of xen-devel-bounces@lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hyLmL-0003Hi-Q0; Thu, 15 Aug 2019 19:51:21 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hyLmK-0003Hd-GW for xen-devel@lists.xenproject.org; Thu, 15 Aug 2019 19:51:20 +0000 X-Inumbo-ID: 0cdedb7a-bf96-11e9-aee9-bc764e2007e4 Received: from foss.arm.com (unknown [217.140.110.172]) by us1-rack-iad1.inumbo.com (Halon) with ESMTP id 0cdedb7a-bf96-11e9-aee9-bc764e2007e4; Thu, 15 Aug 2019 19:51:19 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 24118344; Thu, 15 Aug 2019 12:51:19 -0700 (PDT) Received: from e108454-lin.cambridge.arm.com (e108454-lin.cambridge.arm.com [10.1.196.50]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 664763F694; Thu, 15 Aug 2019 12:51:18 -0700 (PDT) From: Julien Grall To: xen-devel@lists.xenproject.org Date: Thu, 15 Aug 2019 20:51:14 +0100 Message-Id: <20190815195114.31148-1-julien.grall@arm.com> X-Mailer: git-send-email 2.11.0 Subject: [Xen-devel] [PATCH] xen/arm: domain_build: Remove redundant check in make_vpl011_uart_node() X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Julien Grall , Stefano Stabellini , Volodymyr Babchuk MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" None of the code since the last check of res modify the value. So the check can be removed. Coverity-ID: 1476824 Signed-off-by: Julien Grall Reviewed-by: Volodymyr Babchuk Reviewed-by: Stefano Stabellini --- xen/arch/arm/domain_build.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index cf9ffbc360..173544d8c5 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -1629,8 +1629,7 @@ static int __init make_vpl011_uart_node(const struct domain *d, void *fdt) dt_child_set_range(&cells, GUEST_ROOT_ADDRESS_CELLS, GUEST_ROOT_SIZE_CELLS, GUEST_PL011_BASE, GUEST_PL011_SIZE); - if ( res ) - return res; + res = fdt_property(fdt, "reg", reg, sizeof(reg)); if ( res ) return res;