From patchwork Tue Dec 5 09:01:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Seiderer X-Patchwork-Id: 751969 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmx.net header.i=ps.report@gmx.net header.b="snfPuOVp" Received: from mout.gmx.net (mout.gmx.net [212.227.15.19]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1FB2BC9 for ; Tue, 5 Dec 2023 01:01:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1701766886; x=1702371686; i=ps.report@gmx.net; bh=udSS96naN1uCt3CFBjB4Z/lVsvR+4SbxAJ3aS6Y3A3M=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date; b=snfPuOVpwwYlrA9NZh7RdRZjucKr7CvfHLYQ4Mat6LYxWsRR9dmeIU7+T2+ZUdKD j4VdNqq8vfTP1+QEejO2M+1692FmjpAgcq3BRz3w1t4cLAiCvtT9iZC68L3fQwLct y3pBQiBHPB6Zng6EBA7JRk5L/XKkqUBDX/dPTm39IWLAYlixAuxrc3XjtLFtoErXS H558ykvVHeqyovg311T+C9X5W69EqyzasZ89Ym6KXN2Yd7/xbubtF5LkACSjRyQJi Ajyv8fB77Pm346DB71TW4k7TDhijOoKCkP2mBFun6EimUhrzoM6XKP4fIKPF3WCx7 hTMFK90sGpRYzMbhpA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from localhost.fritz.box ([62.216.209.163]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MDQeK-1qzwuG1dR8-00AY3o; Tue, 05 Dec 2023 10:01:26 +0100 From: Peter Seiderer To: linux-media@vger.kernel.org Cc: Peter Seiderer Subject: [PATCH v4l-utils v1 1/2] Revert "meson: v4l2grab needs libv4lconvert with fork support enabled" Date: Tue, 5 Dec 2023 10:01:22 +0100 Message-ID: <20231205090123.12983-1-ps.report@gmx.net> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Provags-ID: V03:K1:4cdvgrMzQmDDuFJR2yFWxvCrhCrLbHJLxyrWuw8s+Jes99DPtdU RFYuIZ8QdSuBrjbxcsbx/iC0geZGOhsn0QyMIgI2+m3rXEk4Z6DFRwPDPAxrWPkR+DXBLOx GhBfaN9iMgfDRjHb0OPu+hxoqaDuDY9zkxpjUDpeXQiYHQ0qe9Z82Oswr6P9o656hcRFKya w2qvudgXhwUY3wzdu8/DQ== UI-OutboundReport: notjunk:1;M01:P0:d1CyhJD2PpA=;GHj/9SJwdafAuNKiqQD0esedfxu laQfzSYhWzAl2+OLnWKQHGawD2jFOgWBCGpcG26/gazVSgffT5HhwfSfhxdhxuG8B23QKMk6V H5bjq4ig62rGeOdoAeJPMdosWaoj/yerj8Uj+bU5k4eV+gHKmspn9kl2Hv5fPCmeVn798VhuW mu1WP2slqX2kdtd+pMKtkLyTe49xVHQjHtmvgKPSMbFwwvwEjWiQvA1GCqq+Qr7ZYohc/PLkx 9IEe4X822P7ZohY7eGvNt1o6dVYd/BqOsWLJ+eU1OQj4wi6geTBht2Iz1es2ef+MrvOZBByvd 4c2AsZf6eOiG5nBGwUoUscGVxbqjh/5/q2pMZxzxxArCdGhftA1k1GkkUvvbDOG58yGDmYNzW i5ahE+ciqp83i+VgMozy0dW8kfXrXe2RTi76jOrNvGHGGvXFIk2ev60+ioIr3ukfvsAVmRrav ZFL3qIfupLwZHKTunHcSO7gJhOvZ9D6QbKrydCUN7dzyj6YUr+E0ABZBQsR8LoSzCvpvRCve4 zbVC9R0kDaaDDXWFBgJ8BqM1HRL+df+JKuqTL8rKT54wSK1cxWbXfcdtz7YMza1jrjzCqNVzJ 2HfVpqnP/vQeZmvDptm8WfuDQSxxt0k2uEYVk14F8rEmQdY0EutYphiKIuULxkZzeEzi4i7DB 5sv2OMwvuhDxxnTINneYtqiTkF2kerE/YFHlObQiwd/RcTdnk0hksVTCRxUe1s+Lx/dS39aOB 7KMoYSpzyZi6zBPEcRRhrWgblc5RoS4Nz9FVScWIQ/tZfeowz7yNJIyqQcTAeXKoW98j7rb9n NFu2cxoHrC4k0Vhxji6SGr2RDpQ1VLpM3jqHqbDAUqeBAOwUjmZ49kniD0Q4Mdf0aq+M/1e7h g28/HSnSXBYUZDQRrpc9SXtdEOP/JmdyybWn1MQWFgObNGlVJ+DX9IGh90zibdFzRzNtaJG15 7JqztWrXac8TWAaQbKkWggVZ8sg= This reverts commit 589da519e230e84b3603dddab42561983b1469aa as a less intrusive fix is available (make libv4lconvert helpers depend on fork support, see follow up patch). Signed-off-by: Peter Seiderer --- contrib/test/meson.build | 2 -- 1 file changed, 2 deletions(-) diff --git a/contrib/test/meson.build b/contrib/test/meson.build index c1f40354..29b51df6 100644 --- a/contrib/test/meson.build +++ b/contrib/test/meson.build @@ -25,7 +25,6 @@ sliced_vbi_detect = executable('sliced-vbi-detect', sliced_vbi_detect_sources, include_directories : v4l2_utils_incdir) -if have_fork v4l2grab_sources = files( 'v4l2grab.c', @@ -42,7 +41,6 @@ v4l2grab = executable('v4l2grab', v4l2grab_sources, dependencies : v4l2grab_deps, include_directories : v4l2_utils_incdir) -endif driver_test_sources = files( 'driver-test.c', From patchwork Tue Dec 5 09:01:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Seiderer X-Patchwork-Id: 750588 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmx.net header.i=ps.report@gmx.net header.b="TOScCsFf" Received: from mout.gmx.net (mout.gmx.net [212.227.15.19]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 21FF0182 for ; Tue, 5 Dec 2023 01:01:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1701766887; x=1702371687; i=ps.report@gmx.net; bh=gpJ/GPz7IpyXJDda1TpD55/LUNip08qxMeVqBnYlJt0=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To: References; b=TOScCsFfw0TBbMbUXtwMA4MmC+L5BNv0KqDaCIZDK+oreVr47E8tdUXy4K3jha0V i/TXACbw/oOxOLGYfSKvDxm35q8/xCYzXvbgB72fQUdPceefPpiI03Lih4JLhLRxA mF5D5wrkC/dnctpsTiaIFlVSf0D5NE1r3M+C8CK3a8bDjVcdIol+GuMt2hvTqIV6Y NyVE7rcE6Gu6zRw6S79hY+VlOgmNKciBNVaE5UdfAnQH4RpVpggeD/e7LYZK4Y5mp DBJ0uybet8MILsmCNCHSqtJNxJxd/81iE5qZQhRF2OX7i4+Sg/2CxAzpQU5tN0Hfi Ce0llo/gid7QrPmq2w== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from localhost.fritz.box ([62.216.209.163]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MY6Cl-1qlKqA1ezV-00YNXr; Tue, 05 Dec 2023 10:01:27 +0100 From: Peter Seiderer To: linux-media@vger.kernel.org Cc: Peter Seiderer Subject: [PATCH v4l-utils v1 2/2] meson: libv4lconvert helpers need fork support Date: Tue, 5 Dec 2023 10:01:23 +0100 Message-ID: <20231205090123.12983-2-ps.report@gmx.net> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231205090123.12983-1-ps.report@gmx.net> References: <20231205090123.12983-1-ps.report@gmx.net> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Provags-ID: V03:K1:fu00QAtHka3kxQ2Gelxe/6p/GfbX48kbrGXSRbo/e065A4vYhWm tPim6m14+yI61GGbQbmaXmgMQYWEO3bF4KEbP4N04KXQhVLv3O9p4SbjHNvfVLTEsDkSHWR sxRM4vHMjFFrF0cFmaWO4V0bCC02VOYY4+0TFaI1+vmP4YPkusaFToIFZmutO+zLUsOEgJ1 MMHIc0y3A9+YeQp0Ymckw== UI-OutboundReport: notjunk:1;M01:P0:1SzLbgnSguw=;PlVshZSLy34AHioZ6wkGg7b8odG z57rckGc0Uwztf3AXtHu7IqiNoPiHmMXvi3jcKneY14+kNxj3ZpEvruQ0XJO8IO0dwNRCJINm 3B6DEyw1D+i9Mtp9eoy2gbyC/HQ2PySqZDlgVcdNGRBvzwZY1kRRdBiEj5OG0NIO269eC/Pkm Kgom4TcRwGDWXUegMNUqN4Vx1Jt+lkQGweFGAndWYJWyOt554YhuP3Y2HF3+yGaGIlHmv4c2q l+mFhqurUrSrmKtw9R1INnzfO6XpXQaklrsKoxx/C7hncvqIpkpqV/n3LphWFTeICXMPUCVsw pQ0cOdAaoXqpk4ryTwlyAz1KyuHoYm/Ku0jC96r2CLR4uRMGMF5D1d2O6NrqXFFVgmbHCBin0 tnhjsqzNgDJ3COzrdJXhF9mW1ieQI5Yo/bUGik2MT38tMVNUoKZRmHd2FlcHIqeC5nf4gAb4Y kDzjodGVEm51wSKOdgPfQpcMQSQt+YhizPQmGnhv4A/HR8zOqEhLPTjdk+wJc0yQJF/OVHZK0 Eeam8t1lKwpkE87de+1nKmtrsuIUA2POkljPyrhm0TU9DaMj2yEWZ8Wh51ftD2zZ7Jvk99aie EpV1kGcb8dbqJcktLfBOkFkcR2ugRchEFgEIPIkflHJxedbhDDPn1R1qjzRd35cKDvVWbHaxu m3h9Tyt0Z+iFCKf89ZJlYcng3YTEr0zjgHH2P25Br3nvWYeiHbsOWhNxak3TZZ4cvJPebalSJ OsG94Cj9EKc2DA93M0/BNL8P+5wCPnQBc3QUXpj/EYl23eojl4wFyow6SyQxnYSGQo9Hfdx5N 3YLpJ9kubT9F38f6dNAhIlgJDqbQ1eMX+F9oMIeDdsUD/1j5dzxEVVgJg/dJ44atOwEjrqmhE EfNn+RdNNvNsKeCfBhJzxgEAlTtQ/VB91OKTAfw6d4XXcpNh1Q4GbMfhYHrQU1u2vuYel1oGE FWwHzg== - libv4lconvert helpers (v4lconvert_helper_decompress, v4lconvert_helper_cleanup, ...) need fork() support, so add additional dependency for HAVE_LIBV4LCONVERT_HELPERS Fixes: FAILED: contrib/test/v4l2grab .../bootlin-armv7m-uclibc/host/bin/arm-linux-gcc -o contrib/test/v4l2grab contrib/test/v4l2grab.p/v4l2grab.c.o -Wl,--as-needed -Wl,--no-undefined -Wl,-O1 -Wl,-elf2flt=-r -static -Wl,--start-group lib/libv4l2/libv4l2.a lib/libv4lconvert/libv4lconvert.a -largp -pthread -ldl -lm -lrt -Wl,--end-group .../bootlin-armv7m-uclibc/host/opt/ext-toolchain/arm-buildroot-uclinux-uclibcgnueabi/bin/ld.real: lib/libv4lconvert/libv4lconvert.a(libv4lconvert.c.o): in function `v4lconvert_destroy': libv4lconvert.c:(.text+0x5c0): undefined reference to `v4lconvert_helper_cleanup' .../bootlin-armv7m-uclibc/host/opt/ext-toolchain/arm-buildroot-uclinux-uclibcgnueabi/bin/ld.real: lib/libv4lconvert/libv4lconvert.a(libv4lconvert.c.o): in function `v4lconvert_convert_pixfmt': libv4lconvert.c:(.text+0x1450): undefined reference to `v4lconvert_helper_decompress' collect2: error: ld returned 1 exit status Signed-off-by: Peter Seiderer --- lib/libv4lconvert/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/libv4lconvert/meson.build b/lib/libv4lconvert/meson.build index 38740755..4bda5671 100644 --- a/lib/libv4lconvert/meson.build +++ b/lib/libv4lconvert/meson.build @@ -91,7 +91,7 @@ if have_fork include_directories : v4l2_utils_incdir) endif -if have_visibility +if have_visibility and have_fork libv4lconvert_c_args += [ '-fvisibility=hidden', '-DHAVE_LIBV4LCONVERT_HELPERS',