From patchwork Fri Dec 22 22:48:59 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ricardo Ribalda X-Patchwork-Id: 758205 Received: from mail-qk1-f178.google.com (mail-qk1-f178.google.com [209.85.222.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 09A1A1EB4F for ; Fri, 22 Dec 2023 22:49:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="F9hx13r2" Received: by mail-qk1-f178.google.com with SMTP id af79cd13be357-781197600bdso121387385a.2 for ; Fri, 22 Dec 2023 14:49:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1703285347; x=1703890147; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=o2i334eTq3BuKE++cIjl9cMjhdqV78OcXKbB9KI96cQ=; b=F9hx13r2VY1NUuUY5u1Dj0t8Ji3jONWxsSLH7tvjkZvMj4Q4ToQPxJoKdxAmg120lN 8cIMOeMPHWCwl78L1bkHaU2UL3ho4MENV9SH6/nSCrS+6ykyzIa+uvLBlyu722tvhy/D Vgz1FHFUZ23quIZEfbjGXhb3r3bB9amcnJkdg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703285347; x=1703890147; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=o2i334eTq3BuKE++cIjl9cMjhdqV78OcXKbB9KI96cQ=; b=FYhe36gUF5dmkzrhmuA6QUvcr4QpVbeqnYg7T0XeYXnOs/GpXrmM4ufQowJdugLjCR eXpXErFAq/UGCZUWqrrBi9nPAwi539s+fnCKeJoIeioItxHcRfPD+Dq3IiP9rs7ucdg3 q1KurFwR6k42KOc7nokLEPDLGpxK04DuHbWHgRrnS7x20hzdMYI118blp2L7Mv+diVYU qaSMI3yRCK5w3DUMADCQqJFSZMuvQuwj3iV0WXgjNd57YF2F6KhWKwiwHi0N7pX+kM/4 U7deRa+cb7BAk63nNob2mBKouJ7Q7mWpqJmtYFlqKiW1n4vXmnb65n++60IYzp1zrDID YY+w== X-Gm-Message-State: AOJu0Yzat/jGMUY9LielJiG+AiJcGbFASo2pBaGnmlaF9nC/wnUPhWyU ilfRJIMl1zY46gkZLpE2JnmDuDVrWoj6nbmu/+xiYTsNCQ== X-Google-Smtp-Source: AGHT+IEJcu6vJ19xBj14+zUuTLhAr4vb4xeSyeabv8Dz4dJPelHnv1JgPxCYjSBCXQxEL3WOoYbaAQ== X-Received: by 2002:a05:620a:4eb:b0:77e:fc1c:97d8 with SMTP id b11-20020a05620a04eb00b0077efc1c97d8mr1833685qkh.36.1703285346729; Fri, 22 Dec 2023 14:49:06 -0800 (PST) Received: from denia.c.googlers.com (228.221.150.34.bc.googleusercontent.com. [34.150.221.228]) by smtp.gmail.com with ESMTPSA id vy23-20020a05620a491700b0078101bf693fsm1632404qkn.96.2023.12.22.14.49.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Dec 2023 14:49:06 -0800 (PST) From: Ricardo Ribalda Date: Fri, 22 Dec 2023 22:48:59 +0000 Subject: [PATCH] usb: core: Add quirk for Logitech Rallybar Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20231222-rallybar-v1-1-82b2a4d3106f@chromium.org> X-B4-Tracking: v=1; b=H4sIAFoShmUC/6tWKk4tykwtVrJSqFYqSi3LLM7MzwNyDHUUlJIzE vPSU3UzU4B8JSMDI2NDIyMj3aLEnJzKpMQiXUPL5FSDZDOTFNNUMyWg8oKi1LTMCrBR0bG1tQA 7yQmIWgAAAA== To: Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Ricardo Ribalda X-Mailer: b4 0.12.3 Logitech Rallybar devices, despite behaving as UVC camera, they have a different power management system than the rest of the other Logitech cameras. USB_QUIRK_RESET_RESUME causes undesired USB disconnects, that make the device unusable. These are the only two devices that have this behavior, and we do not have the list of devices that require USB_QUIRK_RESET_RESUME, so lets create a new lit for them that un-apply the USB_QUIRK_RESET_RESUME quirk. Signed-off-by: Ricardo Ribalda --- Tested with a Rallybar Mini with an Acer Chromebook Spin 513 --- drivers/usb/core/quirks.c | 11 +++++++++++ 1 file changed, 11 insertions(+) --- base-commit: c0f65a7c112b3cfa691cead54bcf24d6cc2182b5 change-id: 20231222-rallybar-19ce0c64d5e6 Best regards, diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c index 15e9bd180a1d..cedb619994d2 100644 --- a/drivers/usb/core/quirks.c +++ b/drivers/usb/core/quirks.c @@ -553,6 +553,15 @@ static const struct usb_device_id usb_interface_quirk_list[] = { { } /* terminating entry must be last */ }; +static const struct usb_device_id usb_interface_unsupported_quirk_list[] = { + /* Logitech Rallybar VC systems*/ + { USB_DEVICE(0x046d, 0x089b), .driver_info = USB_QUIRK_RESET_RESUME }, + { USB_DEVICE(0x046d, 0x08d3), .driver_info = USB_QUIRK_RESET_RESUME }, + + { } /* terminating entry must be last */ +}; + + static const struct usb_device_id usb_amd_resume_quirk_list[] = { /* Lenovo Mouse with Pixart controller */ { USB_DEVICE(0x17ef, 0x602e), .driver_info = USB_QUIRK_RESET_RESUME }, @@ -718,6 +727,8 @@ void usb_detect_interface_quirks(struct usb_device *udev) u32 quirks; quirks = usb_detect_static_quirks(udev, usb_interface_quirk_list); + quirks &= ~usb_detect_static_quirks(udev, + usb_interface_unsupported_quirk_list); if (quirks == 0) return;