From patchwork Mon Feb 12 20:03:25 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Duje_Mihanovi=C4=87?= X-Patchwork-Id: 772145 Received: from mx.skole.hr (mx2.hosting.skole.hr [161.53.165.186]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6FA4B4CB55; Mon, 12 Feb 2024 20:04:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=161.53.165.186 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707768284; cv=none; b=tjyzDQJ6HfQHpqQUQz2l9G6ZAIZUKcbfgY0fG4JOL42BhcNMFif2DQ03vWe3HH4fvikx9+nUbN9iwUmyIc7PwtInypsAdlSBWEB5eRX6sPoJ4hSiG0iBybwp8uCpdFBIP73rOUL3HyeEhMBoAzYgQtm28bYH535cFzsajxpALIY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707768284; c=relaxed/simple; bh=PSXGPCrqbnaDBfgcrLl0RTka3gT8h50OxpcbtqLKeVY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Kf7Jn0kUSdo/U+t0k0KBWN0LxCWSSpnn79jn33ZF+X84C3egsg8zzTD09roC4cNdc6t+X3HYcMevlETushA2IkXVusaKeenL6fW5DBsTBrzPcBqhZhM861oRA4utlvmoWU1TdcgyW4iMNDcVYrm3mg1ns6bHwv4UHXlj2iY60Eg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=skole.hr; spf=pass smtp.mailfrom=skole.hr; arc=none smtp.client-ip=161.53.165.186 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=skole.hr Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=skole.hr Received: from mx2.hosting.skole.hr (localhost.localdomain [127.0.0.1]) by mx.skole.hr (mx.skole.hr) with ESMTP id DE5BB8507B; Mon, 12 Feb 2024 21:04:37 +0100 (CET) From: =?utf-8?q?Duje_Mihanovi=C4=87?= Date: Mon, 12 Feb 2024 21:03:25 +0100 Subject: [PATCH 1/2] Revert "leds: Only descend into leds directory when CONFIG_NEW_LEDS is set" Precedence: bulk X-Mailing-List: linux-fbdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240212-expresswire-deps-v1-1-685ad10cd693@skole.hr> References: <20240212-expresswire-deps-v1-0-685ad10cd693@skole.hr> In-Reply-To: <20240212-expresswire-deps-v1-0-685ad10cd693@skole.hr> To: Pavel Machek , Lee Jones , Daniel Thompson , Linus Walleij , Arnd Bergmann Cc: Flavio Suligoi , Hans de Goede , Jianhua Lu , "Matthew Wilcox (Oracle)" , Helge Deller , Jingoo Han , Karel Balej , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org, =?utf-8?q?Duje_Mihanovi=C4=87?= X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=openpgp-sha256; l=1040; i=duje.mihanovic@skole.hr; h=from:subject:message-id; bh=PSXGPCrqbnaDBfgcrLl0RTka3gT8h50OxpcbtqLKeVY=; b=owEBbQKS/ZANAwAIAZoRnrBCLZbhAcsmYgBlynmg1AO2BNWzA/ObjvKoEbirvyIXAvvYxitfx MmcK/0fNv2JAjMEAAEIAB0WIQRT351NnD/hEPs2LXiaEZ6wQi2W4QUCZcp5oAAKCRCaEZ6wQi2W 4ctmD/4tcF0fuxA0coVon4C8C7312+ldyuaC8IMNaeizEWBKHkJm0mENe1UP33oiF5dAyGssI44 95H+dwlBtvzANNwvK6g/oKe/1Qt/OJrcPpxaFinTRGdGF2a7/YVIPbWdRGdxUI0D+kOGpHkjKJ8 Nl7wrt9TWpqs2ABy5Aiwr0y1a3tNTx57hHkCTIWrdB/MZW3c6yxOcYeyBo+lT6zEcUuGsuEaiql 0k/BMoMtI9IPG3K84mn8KlbY1tqAjaEiL+HiusXzi88t+IgfiIi2NxP6sxpeSQrCqvlkFRo8mLY f99AfHzmk54jks9GuUMTmArCD0TdROur7XqcHoM/kt8M/B3xh0Kevs4qGQXi9COv5+bTc2LWdXU xB7NOqva9vj785yNN98a60IEct2wT0Au/zuSA94KqQmrRRLD9MqlKZqHzfYjcmg2yW1kJbWG2V4 tKsHMGRNxl1/mNti1iZy5SfKnPoQY7TyoBLBz7eHLfDTrPCVWudNcyzomdhqVG1r7hNVpNQdeDN FJImywxVWRgLegz1/5kVkdUhyNrP6nJz1Nbw0EanENzJH+3FjGJci3RybAAm6S6C3rYNee8QJtF eFM3JQS1+C0AOhRpnyHQaKKI/SkvEphXmU5iVyON3BO8crU8TJPJqGETm4X2Z+upytZmQTZbMNh vdemFIgFU3AMFtQ== X-Developer-Key: i=duje.mihanovic@skole.hr; a=openpgp; fpr=53DF9D4D9C3FE110FB362D789A119EB0422D96E1 This reverts commit b1ae40a5db6191c42e2e45d726407096f030ee08. The ExpressWire library introduced in 25ae5f5f4168 ("leds: Introduce ExpressWire library") does not depend on NEW_LEDS, but without this revert it would never get compiled if NEW_LEDS is not enabled. Revert this commit to allow the library to be compiled. Link: https://lore.kernel.org/2cacd8dc-6150-4aa2-af9e-830a202fb0a8@app.fastmail.com Suggested-by: Arnd Bergmann Signed-off-by: Duje Mihanović --- drivers/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/Makefile b/drivers/Makefile index 37fd6ce3bd7f..3bf5cab4b451 100644 --- a/drivers/Makefile +++ b/drivers/Makefile @@ -135,7 +135,7 @@ obj-$(CONFIG_CPU_IDLE) += cpuidle/ obj-y += mmc/ obj-y += ufs/ obj-$(CONFIG_MEMSTICK) += memstick/ -obj-$(CONFIG_NEW_LEDS) += leds/ +obj-y += leds/ obj-$(CONFIG_INFINIBAND) += infiniband/ obj-y += firmware/ obj-$(CONFIG_CRYPTO) += crypto/ From patchwork Mon Feb 12 20:03:26 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Duje_Mihanovi=C4=87?= X-Patchwork-Id: 772144 Received: from mx.skole.hr (mx1.hosting.skole.hr [161.53.165.185]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A43604D9E9; Mon, 12 Feb 2024 20:04:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=161.53.165.185 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707768289; cv=none; b=KYdF9Zw8QpHzr+0dHTtVKY2GmvC3euMkGxCcZIq/AGnWB3C5KOdJ14HdBKRbVEhr8Ruoj8dJZWCa78uKRcrqrqXOQ14h6tjxn1TuflGiFF6GgUmQDGrMA2kOSCHxiOP7uSVM+y9VKiRN0aWxkMYH3Qi/DwctGpF/PVm4f0tXskc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707768289; c=relaxed/simple; bh=8oXLHu5mf6GCO+ZMr+tU6h6oKIscP7uIjmv7rxzg+zo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=bkNO3HDTPNqfiW3IY/oyxMacCEOxXP3N7LhqVI9xhA34IUuSswr4xAUvyDq8TWpLr1gKDkPdbFAOD3dV4gFHqlvE7tCf6+63z/N3J+QH8Wzj/9fai4TrhyLCfPRa8EyXrW+FgOcrwm0AgOq+wuDBfeRa0uupoTSMY66wVmCQP4A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=skole.hr; spf=pass smtp.mailfrom=skole.hr; arc=none smtp.client-ip=161.53.165.185 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=skole.hr Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=skole.hr Received: from mx1.hosting.skole.hr (localhost.localdomain [127.0.0.1]) by mx.skole.hr (mx.skole.hr) with ESMTP id 982CF83C56; Mon, 12 Feb 2024 21:04:38 +0100 (CET) From: =?utf-8?q?Duje_Mihanovi=C4=87?= Date: Mon, 12 Feb 2024 21:03:26 +0100 Subject: [PATCH 2/2] leds: expresswire: don't depend on NEW_LEDS Precedence: bulk X-Mailing-List: linux-fbdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240212-expresswire-deps-v1-2-685ad10cd693@skole.hr> References: <20240212-expresswire-deps-v1-0-685ad10cd693@skole.hr> In-Reply-To: <20240212-expresswire-deps-v1-0-685ad10cd693@skole.hr> To: Pavel Machek , Lee Jones , Daniel Thompson , Linus Walleij , Arnd Bergmann Cc: Flavio Suligoi , Hans de Goede , Jianhua Lu , "Matthew Wilcox (Oracle)" , Helge Deller , Jingoo Han , Karel Balej , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org, =?utf-8?q?Duje_Mihanovi=C4=87?= X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=openpgp-sha256; l=1760; i=duje.mihanovic@skole.hr; h=from:subject:message-id; bh=8oXLHu5mf6GCO+ZMr+tU6h6oKIscP7uIjmv7rxzg+zo=; b=owEBbQKS/ZANAwAIAZoRnrBCLZbhAcsmYgBlynmgL8L0kP8ZVEOL1g3BmNLjNbTU+Q9Ykoclo JRlY2qTALGJAjMEAAEIAB0WIQRT351NnD/hEPs2LXiaEZ6wQi2W4QUCZcp5oAAKCRCaEZ6wQi2W 4ZkvD/9Tm0AdqRYDjoU8A+UDGagpNQJX5o2MxYzKRI15Kjuili8GVVflTvViVBi8H34/ML2TaNa jEeaHxyeQssz/2zcEpflayLn02Sq1FOwKnbvzp7VjdvltWyeAkIPn6Nx3gLszasLNrh3FisGZ+8 pg4FlXvlkDpxnflQ7tu8hTKLCnPWnbzIX8dZqP2JDTTljWc0fqL8CvLXfOqz3W4kdj3JYmGpAB+ NPcKfhUn+aP+MUzP3j0hxCUiaywhKiR5e0hvgIgyiXYY7KHcD/tfh6P5nefeV3x6nD/NsStw5eO sOkyzOe3hc0KlLT2sgdzGw7t1Zm5ytPX6LYjwfBwiBG9vvCC0Cxa6xbqpdr5cUPjmJL0wRFO3/Z E0baLz6BFlGEs64xGzWz1dTG+VMlG2V3Or2CKO4p4AIsx7QEio/Rjm6tGChAcqupljAZCeetnSA 4GcUqixr4W8gbqcFkylk86tIXZmqaI4YsTEyObgqQwmSFIHwUhnU8aV2pLH7JBtJQHABysUjUXz P97uJRkCfNs1CVOYbBgH3tYIKH3aSkzIuv4i+gf/8LPtge3BGEOEUHYXc8E4TvJJTnZ1tFP2Zh4 qzDs5rdjQ6ZsABIz4sdsizTeQjIJytLO0ZIWgZGxjtXnH1U9iT5vCcdUe6qTMkpr20jL9/XqD28 eOvZ3avwrFwS2jg== X-Developer-Key: i=duje.mihanovic@skole.hr; a=openpgp; fpr=53DF9D4D9C3FE110FB362D789A119EB0422D96E1 The ExpressWire library does not depend on NEW_LEDS and selecting it from a subsystem other than LEDs may cause Kconfig warnings: WARNING: unmet direct dependencies detected for LEDS_EXPRESSWIRE Depends on [n]: NEW_LEDS [=n] && GPIOLIB [=y] Selected by [y]: - BACKLIGHT_KTD2801 [=y] && HAS_IOMEM [=y] && BACKLIGHT_CLASS_DEVICE [=y] Move it out of the "if NEW_LEDS" block to allow selection from other subsystems (in particular backlight) without raising this warning. Link: https://lore.kernel.org/20240212111819.936815-1-arnd@kernel.org Reported-by: Arnd Bergmann Suggested-by: Daniel Thompson Fixes: 25ae5f5f4168 ("leds: Introduce ExpressWire library") Signed-off-by: Duje Mihanović --- drivers/leds/Kconfig | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig index 52328d295b4e..66998b938ed3 100644 --- a/drivers/leds/Kconfig +++ b/drivers/leds/Kconfig @@ -6,6 +6,12 @@ config LEDS_GPIO_REGISTER As this function is used by arch code it must not be compiled as a module. +# This library does not depend on NEW_LEDS and must be independent so it can be +# selected from other subsystems (specifically backlight). +config LEDS_EXPRESSWIRE + bool + depends on GPIOLIB + menuconfig NEW_LEDS bool "LED Support" help @@ -186,10 +192,6 @@ config LEDS_EL15203000 To compile this driver as a module, choose M here: the module will be called leds-el15203000. -config LEDS_EXPRESSWIRE - bool - depends on GPIOLIB - config LEDS_TURRIS_OMNIA tristate "LED support for CZ.NIC's Turris Omnia" depends on LEDS_CLASS_MULTICOLOR